Re: [PATCH] Input: psmouse - limit protocols that we try on passthrough ports

2015-11-25 Thread Hans de Goede
Hi Dmitry, On 25-11-15 03:16, Dmitry Torokhov wrote: PS/2 protocol is slow, and using it with pass-through port (where we encapsulate PS/2 into PS/2) is slower yet so it takes quite a bit of time to do full protocol discovery for device attached to a pass-through port. However, so far we have no

Re: [PATCH] serio: delay resume error handling til PM complete

2015-11-25 Thread Alan Stern
On Tue, 24 Nov 2015, Dmitry Torokhov wrote: > On Tue, Nov 24, 2015 at 4:58 PM, Todd Brandt > wrote: > > Delay the error rescan for serio devices until the PM > > complete phase. PM complete requires locking each device > > before checking for and executing the complete callbacks. > > Serio re

[PATCH] Input: aiptek: fix crash on detecting device without endpoints

2015-11-25 Thread Vladis Dronov
The aiptek driver crashes in aiptek_probe() when a specially crafted usb device without endpoints is detected. This fix adds a check that the device has proper configuration expected by the driver. Also an error return value is changed to more matching one in one of the error paths. Reported-by: R

Re: [PATCH] serio: delay resume error handling til PM complete

2015-11-25 Thread Todd E Brandt
On Tue, Nov 24, 2015 at 05:26:15PM -0800, Dmitry Torokhov wrote: > On Tue, Nov 24, 2015 at 4:58 PM, Todd Brandt > wrote: > > Delay the error rescan for serio devices until the PM > > complete phase. PM complete requires locking each device > > before checking for and executing the complete call

Re: [PATCH] serio: delay resume error handling til PM complete

2015-11-25 Thread Dmitry Torokhov
On Wed, Nov 25, 2015 at 10:24:07AM -0500, Alan Stern wrote: > On Tue, 24 Nov 2015, Dmitry Torokhov wrote: > > > On Tue, Nov 24, 2015 at 4:58 PM, Todd Brandt > > wrote: > > > Delay the error rescan for serio devices until the PM > > > complete phase. PM complete requires locking each device > >

Re: [PATCH] serio: delay resume error handling til PM complete

2015-11-25 Thread Dmitry Torokhov
On Wed, Nov 25, 2015 at 09:25:59AM -0800, Todd E Brandt wrote: > On Tue, Nov 24, 2015 at 05:26:15PM -0800, Dmitry Torokhov wrote: > > On Tue, Nov 24, 2015 at 4:58 PM, Todd Brandt > > wrote: > > > Delay the error rescan for serio devices until the PM > > > complete phase. PM complete requires loc

Re: [PATCH] serio: delay resume error handling til PM complete

2015-11-25 Thread Todd E Brandt
On Wed, Nov 25, 2015 at 09:51:12AM -0800, Dmitry Torokhov wrote: > On Wed, Nov 25, 2015 at 09:25:59AM -0800, Todd E Brandt wrote: > > On Tue, Nov 24, 2015 at 05:26:15PM -0800, Dmitry Torokhov wrote: > > > On Tue, Nov 24, 2015 at 4:58 PM, Todd Brandt > > > wrote: > > > > Delay the error rescan for

Re: [PATCH] HID: debug: improve hid_debug_event()

2015-11-25 Thread Joe Perches
On Tue, 2015-11-24 at 13:33 +0100, Rasmus Villemoes wrote: > The code in hid_debug_event() causes horrible code generation. First, > we do a strlen() call for every byte we copy (we're doing a store to > global memory, so gcc has no way of proving that strlen(buf) doesn't > change). Second, since b

[PATCH 00/10] Input: synaptics-rmi4: Synaptics RMI4 Driver rebased on 4.3

2015-11-25 Thread Andrew Duggan
This is a new patch series which squashes all of the development history of the RMI4 driver into patches based on functionality. The first patch adds the core RMI4 functionality needed by all RMI4 devices and then the additional patches add transport and function drivers for supporting various devi

[PATCH 01/10] Input: synaptics-rmi4: Add support for Synaptics RMI4 devices

2015-11-25 Thread Andrew Duggan
Synaptics uses the Register Mapped Interface (RMI) protocol as a communications interface for their devices. This driver adds the core functionality needed to interface with RMI4 devices. RMI devices can be connected to the host via several transport protocols and can supports a wide variety of fu

[PATCH 04/10] Input: synaptics-rmi4: Add support for 2D sensors and F11

2015-11-25 Thread Andrew Duggan
RMI4 currently defines two functions for reporting data for 2D sensors (F11 and F12). This patch adds the common functionality which is shared by devices with 2D reporting along with implementing functionality for F11. Signed-off-by: Andrew Duggan Signed-off-by: Christopher Heiny --- drivers/in

[PATCH 05/10] Input: synaptics-rmi4: Add device tree support for 2d sensors and F11

2015-11-25 Thread Andrew Duggan
2D sensors have several parameter which can be set in the platform data. This patch adds support for getting those values from devicetree. Signed-off-by: Andrew Duggan --- .../bindings/input/rmi4/rmi_2d_sensor.txt | 54 +++ drivers/input/rmi4/rmi_2d_sensor.c | 1

[PATCH 07/10] Input: synaptics-rmi4: Add support for F30

2015-11-25 Thread Andrew Duggan
RMI4 F30 supports input from clickpad buttons and controls LEDs located on the touchpad PCB. This patch adds support of the clickpad buttons and defers supporting LEDs for the future. Signed-off-by: Andrew Duggan Signed-off-by: Benjamin Tissoires --- drivers/input/rmi4/Kconfig | 9 + dri

[PATCH 06/10] Input: synaptics-rmi4: Add support for F12

2015-11-25 Thread Andrew Duggan
Function 12 implements 2D touch position sensor for newer Synaptics touch devices. It replaces F11 and no device will contain both functions. Signed-off-by: Andrew Duggan Signed-off-by: Christopher Heiny --- drivers/input/rmi4/Kconfig | 10 + drivers/input/rmi4/Makefile | 1 + drive

[PATCH 09/10] Input: synaptics-rmi4: Add device tree support to the SPI transport driver

2015-11-25 Thread Andrew Duggan
Add devicetree binding for SPI devices. Signed-off-by: Andrew Duggan --- .../devicetree/bindings/input/rmi4/rmi_spi.txt | 57 ++ drivers/input/rmi4/rmi_spi.c | 44 - 2 files changed, 100 insertions(+), 1 deletion(-) create mode 10064

[PATCH 08/10] Input: synaptics-rmi4: Add SPI transport driver

2015-11-25 Thread Andrew Duggan
Add the transport driver for devices using RMI4 over SPI. Signed-off-by: Andrew Duggan --- drivers/input/rmi4/Kconfig | 9 + drivers/input/rmi4/Makefile | 1 + drivers/input/rmi4/rmi_spi.c | 422 +++ include/linux/rmi.h | 53 ++ 4 file

[PATCH 03/10] Input: synaptics-rmi4: Add device tree support for RMI4 I2C devices

2015-11-25 Thread Andrew Duggan
Add devicetree binding for I2C devices and add bindings for optional parameters in the function drivers. Parameters for function drivers are defined in child nodes for each of the functions. Signed-off-by: Andrew Duggan --- .../devicetree/bindings/input/rmi4/rmi_f01.txt | 39 ..

[PATCH 10/10] HID: rmi: Make hid-rmi a transport driver for synaptics-rmi4

2015-11-25 Thread Andrew Duggan
The Synaptics RMI4 driver provides support for RMI4 devices. Instead of duplicating the RMI4 processing code, make hid-rmi a transport driver and register it with the Synaptics RMI4 core. Signed-off-by: Andrew Duggan --- drivers/hid/hid-rmi.c | 922 +--

[PATCH 02/10] Input: synaptics-rmi4: Add I2C transport driver

2015-11-25 Thread Andrew Duggan
Add the transport driver for devices using RMI4 over I2C. Signed-off-by: Andrew Duggan Signed-off-by: Christopher Heiny --- drivers/input/rmi4/Kconfig | 11 ++ drivers/input/rmi4/Makefile | 3 + drivers/input/rmi4/rmi_i2c.c | 260 +++ 3 files change

Re: [PATCH 02/26] Input: synaptics-rmi4 - add a common input device in rmi_driver

2015-11-25 Thread Andrew Duggan
On 11/10/2015 01:23 AM, Benjamin Tissoires wrote: On Tue, Nov 10, 2015 at 12:13 AM, Dmitry Torokhov wrote: diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input/rmi4/rmi_f01.c index ee5f4a1..2d72dc8 100644 --- a/drivers/input/rmi4/rmi_f01.c +++ b/drivers/input/rmi4/rmi_f01.c @@ -176,6 +176,1

Re: Synaptics touchpad reset issue

2015-11-25 Thread Andrew Duggan
Hi Tuomas, It looks like some other people have reported similar issues with this particular touchpad module. I think there might be a hardware issue with some touchpads with the board/product id of 2991. Since this maybe a hardware issue there might not be a fix, but there might be a work around.

Re: [PATCH 10/10] HID: rmi: Make hid-rmi a transport driver for synaptics-rmi4

2015-11-25 Thread kbuild test robot
Hi Andrew, [auto build test ERROR on input/next] [cannot apply to v4.4-rc2 next-20151124] url: https://github.com/0day-ci/linux/commits/Andrew-Duggan/Input-synaptics-rmi4-Synaptics-RMI4-Driver-rebased-on-4-3/20151126-081351 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.gi

[RFC PATCH] HID: rmi: rmi_hid_2d_sensor_data can be static

2015-11-25 Thread kbuild test robot
Signed-off-by: Fengguang Wu --- hid-rmi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c index 81472c9..832c77d 100644 --- a/drivers/hid/hid-rmi.c +++ b/drivers/hid/hid-rmi.c @@ -497,7 +497,7 @@ static int rmi_check_valid_repo

Re: [PATCH 10/10] HID: rmi: Make hid-rmi a transport driver for synaptics-rmi4

2015-11-25 Thread kbuild test robot
Hi Andrew, [auto build test WARNING on input/next] [cannot apply to v4.4-rc2 next-20151124] url: https://github.com/0day-ci/linux/commits/Andrew-Duggan/Input-synaptics-rmi4-Synaptics-RMI4-Driver-rebased-on-4-3/20151126-081351 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.