This is preparation work for splitting it up for two event nodes.
The error handling for the touch init failure must be special-cased, a
device may respond to a touch query with a zero reply. In this case we
don't have a touch device, but we don't have a true failure either.
Returning 1 as special
If a device failed at the pen setup and gets a zero reply from the touch
device, we need to return an error. Otherwise we have a device with
nothing but a name and the EV_KEY and EV_ABS bits.
Signed-off-by: Peter Hutterer
Acked-by: Benjamin Tissoires
---
Change to v1:
- return -ENXIO if the firs
These devices have a pen device and a touch device through the same serial
protocol, split it up into two separate devices like we do for USB Wacom
tablets too.
Userspace already matches on the device name so we can't drop it completely.
Compose the same basename based on capabilities and append t
Hi,
I have added a bug report on https://bugzilla.kernel.org/show_bug.cgi?id=107971
Further info:
The touchpad (/sys/devices/platform/i8042/serio1/input) just totally gone after
resume.
before suspend:
#ls /sys/devices/platform/i8042/serio1/
bind_mode drvctl paritycheck reg_10 reg_23 resolutio
On Mon, Nov 30, 2015 at 06:02:20PM +, Charles Keepax wrote:
> A small copy and paste error was preventing the haptics device being
> disabled. This patch corrects the value written on disable.
>
> Signed-off-by: Charles Keepax
Applied, thank you.
> ---
> drivers/input/misc/arizona-haptics.
3.13.11-ckt31 -stable review patch. If anyone has any objections, please let
me know.
--
From: Richard Purdie
commit 79b568b9d0c7c5d81932f4486d50b38efdd6da6d upstream.
hid_connect adds various strings to the buffer but they're all
conditional. You can find circumstances where
This is a note to let you know that I have just added a patch titled
HID: core: Avoid uninitialized buffer access
to the linux-3.13.y-queue branch of the 3.13.y-ckt extended stable tree
which can be found at:
http://kernel.ubuntu.com/git/ubuntu/linux.git/log/?h=linux-3.13.y-queue
This
Retrieve refs data from the T37 diagnostic data object and expose it via
a binary attribute in debugfs.
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/atmel_mxt_ts.c | 212 +++
1 file changed, 212 insertions(+)
diff --git a/drivers/input/touchscreen/atmel_mxt
There are different datatypes available from a maXTouch chip. Add
support to retrieve reference data as well.
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/atmel_mxt_ts.c | 78
1 file changed, 60 insertions(+), 18 deletions(-)
diff --git a/drivers/input
Add a file in debugfs directory with info about the chip.
Signed-off-by: Nick Dyer
---
Documentation/ABI/testing/debugfs-heatmap | 14 ++
drivers/input/touchscreen/atmel_mxt_ts.c | 22 ++
2 files changed, 36 insertions(+)
diff --git a/Documentation/ABI/testing/d
Add information to debugfs to allow a generic utility to retrieve
screen parameters and info.
Signed-off-by: Nick Dyer
---
Documentation/ABI/testing/debugfs-heatmap | 60 +++
drivers/input/touchscreen/atmel_mxt_ts.c | 46 ++--
2 files changed, 103
Hello-
This is a series of patches to add diagnostic data support to the Atmel
maXTouch driver. There's an existing implementation in the open-source mxt-app
tool, however there are performance advantages to moving this code into the
driver.
The algorithm for retrieving the data has been fairly c
Both T100 and T9 handle range and orientation in a similar fashion.
Reduce duplication between the two implementations.
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/atmel_mxt_ts.c | 68
1 file changed, 26 insertions(+), 42 deletions(-)
diff --git a/dri
The mXT1386 family of chips have a different architecture which splits
the diagnostic data into 3 columns.
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/atmel_mxt_ts.c | 30 +++---
1 file changed, 27 insertions(+), 3 deletions(-)
diff --git a/drivers/input/touch
The touchscreen may have a margin where not all the matrix is used. Read
the parameters from T9 and T100 and take account of the difference.
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/atmel_mxt_ts.c | 41
1 file changed, 36 insertions(+), 5 deletions(
Invert the diagnostic data to match the orientation of the input device.
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/atmel_mxt_ts.c | 22 +++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c
b/drivers/input/tou
On Mon, 30 Nov 2015, Jason Gerecke wrote:
> Begin slimming down the body of 'wacom_intuos_irq' by moving out its
> largest block of code to a dedicated 'wacom_intuos_pad' function.
>
> Signed-off-by: Jason Gerecke
I really like the cleanups done by this patchset, thanks. I have applied
it to f
Hello Dmitry,
On 11/20/2015 04:46 PM, Javier Martinez Canillas wrote:
> On 11/20/2015 04:32 PM, Javier Martinez Canillas wrote:
>
> [snip]
>
>>
>> But is not complete because the .driver_data in i2c_device_id is an
>> kernel_ulong_t while the .data in of_device_id is a const void * so
>> some ca
On Wed, Dec 02, 2015 at 11:20:44AM -0800, Dmitry Torokhov wrote:
> This makes Logitech PS2++ protocol implementation consistent with
> the naming in other protocols.
>
> Signed-off-by: Dmitry Torokhov
Well, if I did not forget to add drivers/input/mouse/logips2pp.c that
woudl be better...
> ---
This makes Logitech PS2++ protocol implementation consistent with
the naming in other protocols. Also mark the stub as "static inline"
Signed-off-by: Dmitry Torokhov
---
V2: add forgotten drivers/input/mouse/logips2pp.c file.
drivers/input/mouse/logips2pp.c| 2 +-
drivers/input/mouse/logip
This makes Logitech PS2++ protocol implementation consistent with
the naming in other protocols.
Signed-off-by: Dmitry Torokhov
---
drivers/input/mouse/logips2pp.h| 4 ++--
drivers/input/mouse/psmouse-base.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/input
Hi Hans,
On Wed, Dec 02, 2015 at 04:20:48PM +0100, Hans de Goede wrote:
> Hi,
>
> Thanks for splitting out the series, patches 1 - 4 look good to me and are:
>
> Reviewed-by: Hans de Goede
>
> I've some comments inline for this one.
Thanks for spending time on reviewing this.
> >@@ -1025,68
On Wed, Dec 02, 2015 at 10:45:28AM -0800, Greg Kroah-Hartman wrote:
> On Wed, Dec 02, 2015 at 09:26:34AM -0800, Dmitry Torokhov wrote:
> > On Wed, Dec 02, 2015 at 07:31:24AM -0800, Greg Kroah-Hartman wrote:
> > > On Tue, Dec 01, 2015 at 06:21:06PM -0800, Sinclair Yeh wrote:
> > > > On Tue, Dec 01,
Hello,
On Wed, Dec 02, 2015 at 01:52:58PM +0100, Rojhalat Ibrahim wrote:
> On Wednesday 02 December 2015 11:07:11 Uwe Kleine-König wrote:
> > some time ago I worked on the rotary encoder driver to make it support
> > more than two input lines. This is the (only slightly tested[1]) rebase of
> > th
On Wed, Dec 02, 2015 at 10:45:28AM -0800, Greg Kroah-Hartman wrote:
> On Wed, Dec 02, 2015 at 09:26:34AM -0800, Dmitry Torokhov wrote:
> > On Wed, Dec 02, 2015 at 07:31:24AM -0800, Greg Kroah-Hartman wrote:
> > > On Tue, Dec 01, 2015 at 06:21:06PM -0800, Sinclair Yeh wrote:
> > > > On Tue, Dec 01,
On Wed, Dec 02, 2015 at 09:26:34AM -0800, Dmitry Torokhov wrote:
> On Wed, Dec 02, 2015 at 07:31:24AM -0800, Greg Kroah-Hartman wrote:
> > On Tue, Dec 01, 2015 at 06:21:06PM -0800, Sinclair Yeh wrote:
> > > On Tue, Dec 01, 2015 at 04:04:08PM -0800, Greg Kroah-Hartman wrote:
> > > > On Tue, Dec 01,
3.19.8-ckt11 -stable review patch. If anyone has any objections, please let me
know.
--
From: Richard Purdie
commit 79b568b9d0c7c5d81932f4486d50b38efdd6da6d upstream.
hid_connect adds various strings to the buffer but they're all
conditional. You can find circumstances where
On Wed, Dec 02, 2015 at 05:25:19PM +0100, Thierry Reding wrote:
> From: Thierry Reding
>
> These new helpers simplify implementing multi-driver modules and
> properly handle failure to register one driver by unregistering all
> previously registered drivers.
>
> Signed-off-by: Thierry Reding
A
On 12/02/2015 06:26 PM, Dmitry Torokhov wrote:
> On Wed, Dec 02, 2015 at 07:31:24AM -0800, Greg Kroah-Hartman wrote:
>> On Tue, Dec 01, 2015 at 06:21:06PM -0800, Sinclair Yeh wrote:
>>> On Tue, Dec 01, 2015 at 04:04:08PM -0800, Greg Kroah-Hartman wrote:
On Tue, Dec 01, 2015 at 02:54:20PM -0800
On Wed, Dec 02, 2015 at 07:31:24AM -0800, Greg Kroah-Hartman wrote:
> On Tue, Dec 01, 2015 at 06:21:06PM -0800, Sinclair Yeh wrote:
> > On Tue, Dec 01, 2015 at 04:04:08PM -0800, Greg Kroah-Hartman wrote:
> > > On Tue, Dec 01, 2015 at 02:54:20PM -0800, Sinclair Yeh wrote:
> > > > Hi,
> > > >
> > >
From: Thierry Reding
These new helpers simplify implementing multi-driver modules and
properly handle failure to register one driver by unregistering all
previously registered drivers.
Signed-off-by: Thierry Reding
---
drivers/input/misc/sparcspkr.c | 18 +++---
1 file changed, 7 i
On Wed, Dec 02, 2015 at 07:31:24AM -0800, Greg Kroah-Hartman wrote:
> On Tue, Dec 01, 2015 at 06:21:06PM -0800, Sinclair Yeh wrote:
> > On Tue, Dec 01, 2015 at 04:04:08PM -0800, Greg Kroah-Hartman wrote:
> > > On Tue, Dec 01, 2015 at 02:54:20PM -0800, Sinclair Yeh wrote:
> > > > Hi,
> > > >
> > >
On Tue, Dec 01, 2015 at 06:21:06PM -0800, Sinclair Yeh wrote:
> On Tue, Dec 01, 2015 at 04:04:08PM -0800, Greg Kroah-Hartman wrote:
> > On Tue, Dec 01, 2015 at 02:54:20PM -0800, Sinclair Yeh wrote:
> > > Hi,
> > >
> > > On Tue, Dec 01, 2015 at 02:45:27PM -0800, Dmitry Torokhov wrote:
> > > > On Tu
On Wed, 2 Dec 2015, Jiri Kosina wrote:
> I know that this code (and other instances of similar spaghetti) has been
> there before already and you are just moving it around, but isn't this the
> proper time to clean it up a bit?
>
> Like change it to a for-loop that'd use BTN_ as an array index
Hi,
On 29-11-15 06:13, Dmitry Torokhov wrote:
PS/2 protocol is slow, and using it with pass-through port (where we
encapsulate PS/2 into PS/2) is slower yet so it takes quite a bit of time
to do full protocol discovery for device attached to a pass-through port.
However, so far we have not see a
On Mon, 30 Nov 2015, Jason Gerecke wrote:
> Begin slimming down the body of 'wacom_intuos_irq' by moving out its
> largest block of code to a dedicated 'wacom_intuos_pad' function.
>
> Signed-off-by: Jason Gerecke
> ---
> drivers/hid/wacom_wac.c | 482
> +---
Hi,
Thanks for splitting out the series, patches 1 - 4 look good to me and are:
Reviewed-by: Hans de Goede
I've some comments inline for this one.
On 29-11-15 06:13, Dmitry Torokhov wrote:
In preparation of limiting protocols that we try on pass-through ports,
let's rework initialization co
On Wed, Dec 02, 2015 at 11:07:14AM +0100, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König
> ---
> .../devicetree/bindings/input/rotary-encoder.txt | 2 +-
For the binding:
Acked-by: Rob Herring
> arch/arm/mach-pxa/raumfeld.c | 25 +++-
> drivers/input/misc
On Tue, 1 Dec 2015, Benjamin Tissoires wrote:
[ ... snip ... ]
> Not so sure if this is 4.4 material. On the one hand we have a regression
> since 4.4-rc0 for this particular panel.
> On the other hand, there is still the chance that doing so will break a
> different panel. In the list of devices
On Tue, 1 Dec 2015, Benjamin Tissoires wrote:
> Looks like 29fae1c85 ("HID: logitech: Add support for G29") was a little
> bit aggressive and broke other devices.
>
> Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=108121
>
> Signed-off-by: Benjamin Tissoires
> ---
>
> Hi Jiri,
>
> as repo
On Wednesday 02 December 2015 11:07:11 Uwe Kleine-König wrote:
> Hello,
>
> some time ago I worked on the rotary encoder driver to make it support
> more than two input lines. This is the (only slightly tested[1]) rebase of
> this series on top of 4.4-rc2 (from 4.1).
>
> It would be great to get
On Wed, Dec 02, 2015 at 02:07:18PM -0500, Wan Zongshun wrote:
> Detecting x86 platform supporting i8042 or not, we should resort
> to BIOS's FADT i8042 flag per ACPI spec.
>
> Currently, Windows is conforming to this spec, and request this
> flag to detect i8042 supporting.
>
> Signed-off-by: Wan
Detecting x86 platform supporting i8042 or not, we should resort
to BIOS's FADT i8042 flag per ACPI spec.
Currently, Windows is conforming to this spec, and request this
flag to detect i8042 supporting.
Signed-off-by: Wan Zongshun
---
drivers/input/serio/i8042-x86ia64io.h | 4
1 file chang
Hello, Dmitry,
> > + if (intf->altsetting[0].desc.bNumEndpoints < 1) {
> > + dev_warn(&intf->dev,
>
> This should be dev_err as we are aborting device initialization. I know
> the driver user warn/info in similar places, but it is not right, we
> might want to adjust it at some point.
Hi,
On Mon, 16 Nov 2015 18:42:38 +
Mark Brown wrote:
> On Mon, Nov 16, 2015 at 01:23:59PM +0100, Boris Brezillon wrote:
> > Mark Brown wrote:
> > > On Mon, Nov 16, 2015 at 09:56:32AM +0100, Boris Brezillon wrote:
>
> > > > - pwm_reg_period = pwm_get_period(drvdata->pwm);
> > > > +
This is a preparation for the next few patches. There is no change in
behaviour intended.
Signed-off-by: Uwe Kleine-König
---
drivers/input/misc/rotary_encoder.c | 166
1 file changed, 94 insertions(+), 72 deletions(-)
diff --git a/drivers/input/misc/rotary_
For all operations called in .probe there are devm_* variants.
(input_register_device is clever enough to be devm aware on its own.)
This allows to get rid of the error unwind code paths in .probe and the
complete .remove function.
Signed-off-by: Uwe Kleine-König
---
drivers/input/misc/rotary_en
Hello,
some time ago I worked on the rotary encoder driver to make it support
more than two input lines. This is the (only slightly tested[1]) rebase of
this series on top of 4.4-rc2 (from 4.1).
It would be great to get some feedback, especially (but not only) for my
change to raumfeld.c.
Before
Signed-off-by: Uwe Kleine-König
---
.../devicetree/bindings/input/rotary-encoder.txt | 2 +-
arch/arm/mach-pxa/raumfeld.c | 25 +++-
drivers/input/misc/rotary_encoder.c| 127 +
include/linux/rotary_encoder.h | 4
Thank you all for your help on this.
Adrien
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
50 matches
Mail list logo
