[patch] Input: egalax: potential NULL dereference on error

2015-12-19 Thread Dan Carpenter
We didn't check input_allocate_device() for failures so it could lead to a NULL deref. Fixes: 6b0f8f9c52ef ('Input: add eGalaxTouch serial touchscreen driver') Signed-off-by: Dan Carpenter diff --git a/drivers/input/touchscreen/egalax_ts_serial.c b/drivers/input/touchscreen/egalax_ts_serial.c i

Re: [patch] Input: egalax: potential NULL dereference on error

2015-12-19 Thread Julia Lawall
On Sat, 19 Dec 2015, Dan Carpenter wrote: > We didn't check input_allocate_device() for failures so it could lead to > a NULL deref. The patch does several other things... julia > > Fixes: 6b0f8f9c52ef ('Input: add eGalaxTouch serial touchscreen driver') > Signed-off-by: Dan Carpenter > > di

Re: [PATCH] HID: sensor-hub: Add quirk for Lenovo Yoga 900 with ITE Chips

2015-12-19 Thread Nish Aravamudan
On Fri, Dec 18, 2015 at 10:31 PM, Nish Aravamudan wrote: > On Fri, Dec 18, 2015 at 10:34 AM, Srinivas Pandruvada > wrote: >> This needs same quirk as applied to other YOGA sensor hubs. >> Refer to >> 47eeca8a48 (" HID: sensor-hub: Add in quirk for Lenovo Yogas with ITE") >> >> Signed-off-by: Srin

Re: [patch] Input: egalax: potential NULL dereference on error

2015-12-19 Thread Dmitry Torokhov
Hi Dan, On Sat, Dec 19, 2015 at 01:58:24PM +0300, Dan Carpenter wrote: > We didn't check input_allocate_device() for failures so it could lead to > a NULL deref. > > Fixes: 6b0f8f9c52ef ('Input: add eGalaxTouch serial touchscreen driver') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/

Re: [PATCH] HID: sensor-hub: Add quirk for Lenovo Yoga 900 with ITE Chips

2015-12-19 Thread Srinivas Pandruvada
On Fri, 2015-12-18 at 22:31 -0800, Nish Aravamudan wrote: > On Fri, Dec 18, 2015 at 10:34 AM, Srinivas Pandruvada > wrote: > > This needs same quirk as applied to other YOGA sensor hubs. > > Refer to > > 47eeca8a48 (" HID: sensor-hub: Add in quirk for Lenovo Yogas with > > ITE") > > > > Signed-of

Re: [PATCH] HID: sensor-hub: Add quirk for Lenovo Yoga 900 with ITE Chips

2015-12-19 Thread Srinivas Pandruvada
On Sat, 2015-12-19 at 09:21 -0800, Nish Aravamudan wrote: > On Fri, Dec 18, 2015 at 10:31 PM, Nish Aravamudan > wrote: > > On Fri, Dec 18, 2015 at 10:34 AM, Srinivas Pandruvada > > wrote: > > > This needs same quirk as applied to other YOGA sensor hubs. > > > Refer to > > > 47eeca8a48 (" HID: sen

Quanta touchscreen 0408:3003 does not work with hid-multitouch

2015-12-19 Thread Dmitry Torokhov
On Tue, Nov 10, 2015 at 10:21:15PM -0600, Jim lovell wrote: > [1.] 0408:3003 Quanta Computer, Inc. Touchscreen Controller Detected > But Doesn't Work > > [2.] Booting my computer using the newest mainline kernel, the > built-in USB 0408:3003 Quanta Computer, Inc. touchscreen controller is > detect

Re: [patch] Input: egalax: potential NULL dereference on error

2015-12-19 Thread Dan Carpenter
On Sat, Dec 19, 2015 at 12:04:56PM +0100, Julia Lawall wrote: > On Sat, 19 Dec 2015, Dan Carpenter wrote: > > > We didn't check input_allocate_device() for failures so it could lead to > > a NULL deref. > > The patch does several other things... Not really. It's all part of fixing the input_all

New FocalTech FT6236 touchscreen driver is a duplicate with the existing edt-ft5x06.c driver

2015-12-19 Thread Hans de Goede
Hi All, While looking into getting a focaltech touchscreen on a tablet working I noticed that we've 2 overlapping drivers, the ft6236.c and the edt-ft5x06.c driver both support the exact same i2c touchscreen protocol. In the latter the code for the "M09" variant offers identical functionality to

Re: [PATCH] Input: xpad - use LED API when identifying wireless controllers

2015-12-19 Thread Clement Calmels
On Wed, 16 Dec 2015 14:44:08 -0800 Dmitry Torokhov wrote: > When lighting up the segment identifying wireless controller, Instead > of sending command directly to the controller, let's do it via LED > API (usinf led_set_brightness) so that LED object state is in sync > with controller state and w

Re: [PATCH v10 3/8] ARM: dt: Binding documentation for imx25 touchscreen controller

2015-12-19 Thread Rob Herring
On Mon, Dec 14, 2015 at 02:53:49PM +0100, Markus Pargmann wrote: > This is the touchscreen conversion queue binding documentation. It uses > the shared imx25 ADC. > > Signed-off-by: Markus Pargmann > --- > > Notes: > Changes in v9: > - Updated binding descriptions > > Changes i

Re: [PATCH] Input: xpad - use LED API when identifying wireless controllers

2015-12-19 Thread Dmitry Torokhov
On Sat, Dec 19, 2015 at 10:17:09PM +0100, Clement Calmels wrote: > On Wed, 16 Dec 2015 14:44:08 -0800 > Dmitry Torokhov wrote: > > > When lighting up the segment identifying wireless controller, Instead > > of sending command directly to the controller, let's do it via LED > > API (usinf led_set_