Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2016-01-06 Thread Simon Wood
On Wed, January 6, 2016 6:47 pm, Dmitry Torokhov wrote: > It is wrong. Aside form the fact that IMO xpad.c is the wrong place for > this code to be in, why are we waiting for the input device to be opened by > userspace before we do the switch instead of doing it immediately? The 'send magic' mig

Re: [PATCH] [v4]Input: evdev - drop partial events after emptying the buffer

2016-01-06 Thread Aniroop Mathur
Hello Mr. Torokhov, Could you please help to update about below patch ? Thanks, Aniroop Mathur On Tue, Jan 5, 2016 at 3:26 AM, Aniroop Mathur wrote: > This patch introduces concept to drop partial events in evdev handler > itself after emptying the buffer which are dropped by all evdev > client

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2016-01-06 Thread Dmitry Torokhov
On Wed, Jan 06, 2016 at 03:36:57PM +0100, Jiri Kosina wrote: > On Mon, 4 Jan 2016, Benjamin Tissoires wrote: > > > Jiri, I *think* this commit still is in your next pull request for > > Linus. We might want to drop it before it hits Linus' tree. > > What exactly would be the reasoning for droppin

Re: [PATCH] Input: ALPS - Report v3 pinnacle trackstick device only if is present

2016-01-06 Thread Dmitry Torokhov
On Tue, Jan 05, 2016 at 05:54:19PM +0100, Pali Rohár wrote: > On Monday 23 March 2015 12:42:25 Hans de Goede wrote: > > Hi, > > > > On 22-03-15 14:47, Pali Rohár wrote: > > >This patch move v3 pinnacle code for trackstick detection from > > >alps_hw_init_v3() > > >to alps_set_protocol() so ALPS_D

Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

2016-01-06 Thread Dmitry Torokhov
On Wed, Jan 06, 2016 at 09:12:30AM +0100, Hans de Goede wrote: > Hi, > > On 05-01-16 17:44, Pali Rohár wrote: > >On Sunday 22 March 2015 14:46:11 Pali Rohár wrote: > >>This patch adds detection of trackstick for v7 protocol devices. Code in > >>this > >>patch is used in official Dell touchpad lin

[PATCH] Input: rohm_bu21023 - fix handling of retrying firmware update

2016-01-06 Thread Dmitry Torokhov
Because of the wrong condition we'd never retry firmware update. Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/rohm_bu21023.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/rohm_bu21023.c b/drivers/input/touchscreen/rohm_bu21023.c in

Re: [PATCH] input: gpio_keys: Fix check for disabling unsupported key

2016-01-06 Thread Dmitry Torokhov
On Tue, Jan 05, 2016 at 09:24:40AM +0200, Ivaylo Dimitrov wrote: > Hi, > > On 5.01.2016 03:19, Dmitry Torokhov wrote: > >>/* First validate */ > >>- for (i = 0; i < ddata->pdata->nbuttons; i++) { > >>- struct gpio_button_data *bdata = &ddata->data[i]; > >>+ for (i = 0; i < n_eve

[PATCH] HID: wacom: Use correct report to query pen ID from INTUOSHT2 devices

2016-01-06 Thread Jason Gerecke
Unlike other tablets which are compatible with the wacom_intuos_irq handler, INTUOSHT2 devices provide pen ID with report ID 8 instead of 5. To ensure wacom_intuos_schedule_prox_event works as intended for these tablets, we must be sure it uses the correct report ID in this case. Signed-off-by: Ja

Re: [PATCH v2 2/3] Input: cyttsp - add device tree support

2016-01-06 Thread Rob Herring
On Tue, Jan 05, 2016 at 01:59:14PM +0100, Oreste Salerno wrote: > Add support for retrieving the platform data from the device > tree. Converting platform data to DT as is is typically not the right thing to do. There's some overlap, but it is not typically 1-1. > Signed-off-by: Oreste Salerno

[PATCH] hid: core: add managed version of hid_hw_start

2016-01-06 Thread Heiner Kallweit
Most calls to hid_hw_stop are boilerplate code. The function comment states: "This is usually called from remove function or from probe when something failed and hid_hw_start was called already." A managed version of hid_hw_start allows to avoid this boilerplate code in most cases (similar to the

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2016-01-06 Thread Jiri Kosina
On Mon, 4 Jan 2016, Benjamin Tissoires wrote: > Jiri, I *think* this commit still is in your next pull request for > Linus. We might want to drop it before it hits Linus' tree. What exactly would be the reasoning for dropping it? I am all for implementing the skeleton HID driver to take over the

[PATCH] usb: hid: Add new PID for Microchip Pick16F1454

2016-01-06 Thread Kristian Evensen
From: Kristian Evensen There seems to be a new version of the Microchip Pick16F1454 with a different PID (0xf2f7). This device should also be ignored by the HID driver. The PID was observed with the second version of the Yepkit Ykush USB hub. Signed-off-by: Kristian Evensen --- drivers/hid/hid

Re: Add support(re-using) for Cypress CY8CTMA884 part in exiting cypress touch controller driver(drivers/input/touchscreen/cyttsp4_core.c)

2016-01-06 Thread rajeev kumar
Hello Ferruh On Mon, Jan 4, 2016 at 12:46 PM, rajeev kumar wrote: > Hello Ferruh, > > I was going through exiting cypress touch screen driver > (drivers/input/touchscreen/cyttsp4_core.c). Driver copy write suggest > that it supports TMA4XX and TMA1036 cypress touch part. Is there any > plannin

Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

2016-01-06 Thread Hans de Goede
Hi, On 05-01-16 17:44, Pali Rohár wrote: On Sunday 22 March 2015 14:46:11 Pali Rohár wrote: This patch adds detection of trackstick for v7 protocol devices. Code in this patch is used in official Dell touchpad linux drivers for Dell models: Dell Latitude E5250/5250, E5450/5450, E5550/5550 Dete