On 09/05/2014 06:57 AM, Benjamin Tissoires wrote:
In the Dell XPS 13 9333, it appears that sometimes the bus get confused
and corrupts the incoming data. It fills the input report with the
sentinel value "ff". Synaptics told us that such behavior does not comes
from the touchpad itself, so we fil
On 09/09/2014 10:06 AM, Dmitry Torokhov wrote:
On Tue, Sep 09, 2014 at 09:44:17AM +0200, Hans de Goede wrote:
Hi,
On 09/08/2014 06:55 PM, Dmitry Torokhov wrote:
ForcePads are found on HP EliteBook 1040 laptops. They lack any kind of
physical buttons, instead they generate primary button click
ned-off-by: Benjamin Tissoires
Signed-off-by: Andrew Duggan
---
Here is a v2 based of Benjamin's patch with the feedback from the list.
I added size checks to rmi_f11_input_event and rmi_f30_input_event. For F30 I
print a message it any data is missing so that a user is notified if a button
cl
has the mouse interface protocol set. This patch takes a different
approach and scans
the report descriptor looking for the Vendor Specific Top Level Collection and
the associated
usages and report IDs needed by the hid-rmi driver to interface with the device.
Signed-off-by: Andrew Duggan
Hi Benjamin,
Thanks for reviewing.
On 10/03/2014 02:25 PM, Benjamin Tissoires wrote:
Hi Andrew,
On Oct 02 2014 or thereabouts, Andrew Duggan wrote:
On composite HID devices there may be multiple HID devices on separate
interfaces, but hid-rmi
should only bind to the touchpad. Commit
On 10/09/2014 10:28 AM, Dmitry Torokhov wrote:
On Thu, Oct 09, 2014 at 09:52:46AM -0700, Dmitry Torokhov wrote:
On Thu, Oct 09, 2014 at 11:34:26AM +0200, Nicole Faerber wrote:
Hi!
Just installed the just released 3.17 kernel and found a bad behavior of
the new Synaptics driver on my Thinkpad Yo
On Wed, Nov 5, 2014 at 3:09 PM, Luiz Carlos Ramos
wrote:
> Hi, Benjamin.
>
> I'm just using vanilla 3.16.3, no patches, with .config built from the
> one from Slackware stable (kernel 3.10.17). Anyway, I'll try to upgrade
> it to the lastest 3.16.
>
I pulled 3.16.3 from linux-stable and tested wi
protocol set. This patch takes a different approach and scans the report
descriptor looking for
the Generic Desktop Pointer usage and the Vendor Specific Top Level Collection
needed by the
hid-rmi driver to interface with the device.
Signed-off-by: Andrew Duggan
---
This is a second attempt at the
se reports instead of through the F30 like it is on ClickPads.
Signed-off-by: Andrew Duggan
---
This patch depends on the "HID: rmi: Scan the report descriptor to determine if
the device is
suitable for the hid-rmi driver" I submitted earlier today to correctly bind to
the touchp
On 12/08/2014 09:59 AM, Benjamin Tissoires wrote:
On Mon, Dec 8, 2014 at 12:14 PM, Amordea Whiteoak wrote:
There may be a thing I am failing to understand about dmesg here, but
a grep through both dmesg and /var/log/dmesg yielded no hits on
"i2c_hid.debug=1". I did find plenty of hits on just "
On 12/08/2014 10:39 AM, Amordea Whiteoak wrote:
My Linux newbieness is showing. :)
I attempted to edit and boot the grub configuration, but I don't think
I did it right. I went with the seemingly more sure-fire way to get
your data and followed the second set of instructions.
Enclosed is all th
report button state when this functionality is present. This
patch accounts
for the additional data in the report.
Fixes:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1398533
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-rmi.c | 61 +++
1
If a touchpad does not report relative data then query 6 will not be present
and the address
of query 8 will be one less. This patches calculates the location of query 8
instead of
hardcoding the offset.
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-rmi.c | 24
1
On 11/24/2014 03:37 PM, Andrew Duggan wrote:
On composite HID devices there may be multiple HID devices on separate
interfaces, but hid-rmi
should only bind to the touchpad. The previous version simply checked that the
interface protocol
was set to mouse. Unfortuately, it is not always the
On 11/24/2014 04:20 PM, Andrew Duggan wrote:
The Razer Blade 14 has a Synaptic's TouchPad on one of the interfaces of
a composite USB device. This patch allows the hid-rmi driver to bind
to that interface. It also adds support for the external click buttons
on the Razer's touchpad
Hi Benjamin,
Thanks for reviewing my patch. Comments and questions below.
On 12/10/2014 12:51 PM, Benjamin Tissoires wrote:
On Mon, Dec 8, 2014 at 7:16 PM, Andrew Duggan wrote:
On 11/24/2014 04:20 PM, Andrew Duggan wrote:
The Razer Blade 14 has a Synaptic's TouchPad on one of the inter
On 12/11/2014 10:16 AM, Gabriele Mazzotta wrote:
On Thursday 11 December 2014 16:03:07 Mika Westerberg wrote:
On Thu, Dec 11, 2014 at 10:58:01AM +0200, Mika Westerberg wrote:
On Wed, Dec 10, 2014 at 06:04:51PM +0100, Gabriele Mazzotta wrote:
my laptop uses a touchpad that needs hid-rmi along w
On 12/11/2014 11:11 AM, Gabriele Mazzotta wrote:
On Thursday 11 December 2014 10:40:05 Andrew Duggan wrote:
On 12/11/2014 10:16 AM, Gabriele Mazzotta wrote:
On Thursday 11 December 2014 16:03:07 Mika Westerberg wrote:
On Thu, Dec 11, 2014 at 10:58:01AM +0200, Mika Westerberg wrote:
On Wed
On 12/11/2014 11:40 AM, Gabriele Mazzotta wrote:
On Thursday 11 December 2014 11:21:43 Andrew Duggan wrote:
On 12/11/2014 11:11 AM, Gabriele Mazzotta wrote:
On Thursday 11 December 2014 10:40:05 Andrew Duggan wrote:
On 12/11/2014 10:16 AM, Gabriele Mazzotta wrote:
On Thursday 11 December
On 12/11/2014 01:17 PM, Gabriele Mazzotta wrote:
On Thursday 11 December 2014 12:46:53 Andrew Duggan wrote:
On 12/11/2014 11:40 AM, Gabriele Mazzotta wrote:
On Thursday 11 December 2014 11:21:43 Andrew Duggan wrote:
On 12/11/2014 11:11 AM, Gabriele Mazzotta wrote:
On Thursday 11 December
On 12/11/2014 01:57 PM, Gabriele Mazzotta wrote:
On Thursday 11 December 2014 13:34:02 Andrew Duggan wrote:
On 12/11/2014 01:17 PM, Gabriele Mazzotta wrote:
On Thursday 11 December 2014 12:46:53 Andrew Duggan wrote:
On 12/11/2014 11:40 AM, Gabriele Mazzotta wrote:
On Thursday 11 December
protocol set.
This patch takes a different approach and scans the report descriptor looking
for the Generic Desktop Pointer usage and the Vendor Specific Top Level
Collection needed by the hid-rmi driver to interface with the device.
Signed-off-by: Andrew Duggan
Reviewed-by: Benjamin Tissoires
On 12/12/2014 12:12 AM, Gabriele Mazzotta wrote:
On Thursday 11 December 2014 16:26:00 Andrew Duggan wrote:
On 12/11/2014 01:57 PM, Gabriele Mazzotta wrote:
On Thursday 11 December 2014 13:34:02 Andrew Duggan wrote:
On 12/11/2014 01:17 PM, Gabriele Mazzotta wrote:
On Thursday 11 December
devices.
Then hid-rmi's probe can look for the rmi specific HID report IDs and decide if
it should handle the device as a rmi device or simply report that the events
needs additional processing.
Signed-off-by: Andrew Duggan
---
This patch series is my second attempt at getting the hid-rmi d
The external buttons on HID touchpads are connected as pass through devices and
button events are not reported in the rmi registers. As a result on these
devices we need to allow the HID generic desktop button events to be processed
by hid-input.
Signed-off-by: Andrew Duggan
---
drivers/hid/hid
Have hid-rmi handle all of the Razer Blade HID devices that are part of the
composite USB device. This will allow hid-rmi to operate the touchpad in rmi
mode while passing events from the other devices to hid-input.
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-core.c | 1 +
drivers/hid/hid
touchpad to determine
that it has pass through buttons so the RMI_DEVICE_HAS_PHYS_BUTTONS should be
set manually when adding the device to rmi_id[].
Signed-off-by: Andrew Duggan
---
Here is the second version of the remaining patches in this patch series from
last month. The most significant changes are
Now that hid_report_len is in hid.h we can use this function instead of
duplicating the code which computes it.
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-rmi.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
index
Have hid-rmi handle all of the Razer Blade HID devices that are part of the
composite USB device. This will allow hid-rmi to operate the touchpad in rmi
mode while passing events from the other devices to hid-input.
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-core.c | 1 +
drivers/hid/hid
On 12/24/2014 03:53 PM, Gabriele Mazzotta wrote:
[...snip...]
Also, if you can get the firmware id from your touchpad that would also
be useful.
$ sudo ./rmihidtool -f /dev/hidraw0
firmware id: 1522295
Thanks, I will see if I can get any additional information on this.
Andrew
Hi,
I think I
On 01/09/2015 12:04 AM, Gabriele Mazzotta wrote:
On Thursday 08 January 2015 15:58:54 Andrew Duggan wrote:
On 12/24/2014 03:53 PM, Gabriele Mazzotta wrote:
[...snip...]
Also, if you can get the firmware id from your touchpad that would also
be useful.
$ sudo ./rmihidtool -f /dev/hidraw0
Multitouch touchpads built for Win 8.1 need to be sent an input mode feature
report
in order to start reporting multitouch events. This is the same process sent
to Win 7 multitouch touchscreens except the value of the feature report is 3 for
touchpads.
Signed-off-by: Andrew Duggan
Reviewed-by
two collections.
I would personally be in favor of having a priority mechanism: if abs
is here, skip rel, otherwise use rel. But I have no clue if you will
ship devices which will require both. So you make the call.
Signed-off-by: Andrew Duggan
Acked-by: Christopher Heiny
Cc: Dmitry
The rmi4 spec defines some optional query registers in F11 which appear before
query 12. This patch checks for the existence of some of the lesser used
queries to
compute the location of query12 and all subsequent query registers.
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-rmi.c | 33
The rmi4 spec defines some optional query registers in F11 which appear before
query 12. This patch checks for the existence of some of the lesser used
queries to
compute the location of query12 and all subsequent query registers.
Signed-off-by: Andrew Duggan
Reviewed-by: Benjamin Tissoires
The F11 data in the HID report contains four bits of data for w_x and the least
significant bits
of x. Currently only the first three bits are being used which is resulting in
small jumps in
the position data on the x axis and in the w_x data.
Signed-off-by: Andrew Duggan
---
drivers/hid/hid
-by: Andrew Duggan
---
drivers/hid/hid-rmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
index 578bbe6..25f571a 100644
--- a/drivers/hid/hid-rmi.c
+++ b/drivers/hid/hid-rmi.c
@@ -377,7 +377,7 @@ static int rmi_input_event(str
presence of these optional queries.
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-rmi.c | 35 +--
1 file changed, 25 insertions(+), 10 deletions(-)
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
index 578bbe6..3221a95 100644
--- a/drivers/hid/hid-rmi.c
driver.
Signed-off-by: Andrew Duggan
Signed-off-by: Vincent Huang
---
Hi Benjamin,
This is the patch which Vincent and I came up with to fix the behavior which we
were seeing with touchpads not being operational after resuming. We only use
the reset_resume callback since i2c_hid_resume is always
of dereferencing a null pointer.
related bug:
https://bugzilla.kernel.org/show_bug.cgi?id=80091
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-rmi.c | 26 --
1 file changed, 20 insertions(+), 6 deletions(-)
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
Since the USB Vendor ID is Synaptic's, hid-core is currently trying to bind
hid-rmi to all\of
the HID devices. This patch ensures that hid-rmi only binds to the mouse
interface.
related bug:
https://bugzilla.kernel.org/show_bug.cgi?id=80091
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-
of dereferencing a null pointer.
related bug:
https://bugzilla.kernel.org/show_bug.cgi?id=80091
Signed-off-by: Andrew Duggan
---
Added hid_err messages as suggested by Benjamin. This fixes the null pointer
dereference from
bug 80091 while the next patch addresses the binding issue in hid-core
couple of days. Can you do that, and add a
Tested-by: or rev the patch, as appropriate?
Thanks,
Chris
It compiles cleanly and works on my test system.
Tested-by: Andrew Duggan
---
drivers/input/rmi4/rmi_f11.c | 135
+++---
RMI4 Function 0x30 provides support for GPIOs, LEDs and mechanical
buttons. In particular, the mechanical button support is used in
an increasing number of touchpads.
Signed-off-by: Andrew Duggan
Signed-off-by: Allie Xiong
Acked-by: Christopher Heiny
---
I discovered that the v3 version of
file. If the probe returns -EIO
the hidraw device won't be created. So instead of failing the probe, just print
an error message, but leave the device accessible from userspace.
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-rmi.c | 13 +
1 file changed, 9 insertions(+), 4
iptor.
Signed-off-by: Andrew Duggan
---
drivers/hid/i2c-hid/i2c-hid.c | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
index 2b1799a..a71c9a7 100644
--- a/drivers/hid/i2c-hid/i2c-hid.c
+++ b/dr
iptor.
Signed-off-by: Andrew Duggan
---
This is the second version of the patch which includes Benjamin's suggestions.
The comment
now follows the multi line guidelines and in the i2c_hid_set_report function,
hidcmd is now
a pointer.
drivers/hid/i2c-hid/i2c-hid.c | 20 +-
every used multiple
F11 sensors on a single device.
Signed-off-by: Andrew Duggan
---
drivers/input/rmi4/rmi_f11.c | 374 +++
include/linux/rmi.h | 10 +-
2 files changed, 170 insertions(+), 214 deletions(-)
diff --git a/drivers/input/rmi4/rmi_f1
Hi Jiri and Linux-Input,
This patch fixes sending SIGIO from hidraw_report_event by creating a fasync
handler which adds the fasync entry.
Signed-off-by: Andrew Duggan
---
drivers/hid/hidraw.c |8
1 file changed, 8 insertions(+)
diff --git a/drivers/hid/hidraw.c b/drivers/hid
On Tue, Jan 27, 2015 at 8:13 AM, Benjamin Tissoires
wrote:
> On Tue, Jan 27, 2015 at 10:10 AM, Simon Wörner wrote:
>> Thanks for the feedback, this is my first commit to the linux kernel so
>> I don't know much about how the input / hid is working.
>>
>> I will add the changelog to the patch emai
On 01/30/2015 07:41 AM, Benjamin Tissoires wrote:
On Fri, Jan 30, 2015 at 4:03 AM, Hans de Goede wrote:
Hi,
On 01/29/2015 07:48 PM, Benjamin Tissoires wrote:
Hi Daniel,
in one hand I would like to see that upstream ASAP. But on the other
hand, I have some concerns here and there regarding th
On 01/30/2015 07:34 AM, Benjamin Tissoires wrote:
On Fri, Jan 30, 2015 at 4:59 AM, Hans de Goede wrote:
Hi,
On 01/29/2015 08:50 PM, Benjamin Tissoires wrote:
On Thu, Jan 29, 2015 at 2:02 PM, Benjamin Tissoires
wrote:
Hi Daniel,
On Tue, Jan 27, 2015 at 3:34 AM, Daniel Martin
wrote:
From:
On 02/04/2015 01:29 PM, Benjamin Tissoires wrote:
On Feb 02 2015 or thereabouts, Benjamin Tissoires wrote:
On Mon, Feb 2, 2015 at 4:46 PM, Dmitry Torokhov
wrote:
On Wed, Jan 28, 2015 at 03:10:05PM -0500, Benjamin Tissoires wrote:
The current code releases the extra buttons right after they ar
On 02/05/2015 12:38 PM, Benjamin Tissoires wrote:
Lenovos 2015 series has the physical tracktick buttons wired
through the touchpad. The kernel should re-route them through
the pass-through interface.
Signed-off-by: Benjamin Tissoires
---
Hi Dmitry,
Well, in one of your replies regarding the
On 02/04/2015 01:29 PM, Benjamin Tissoires wrote:
On Feb 02 2015 or thereabouts, Benjamin Tissoires wrote:
On Mon, Feb 2, 2015 at 4:46 PM, Dmitry Torokhov
wrote:
On Wed, Jan 28, 2015 at 03:10:05PM -0500, Benjamin Tissoires wrote:
The current code releases the extra buttons right after they ar
output included in bug reports.
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-rmi.c | 99 +++
1 file changed, 99 insertions(+)
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
index 49d4fe4..28579d7 100644
--- a/drivers/hid/hid-rmi.c
On 02/17/2015 04:30 AM, Jiri Kosina wrote:
On Thu, 29 Jan 2015, li...@simon-woerner.de wrote:
From: Simon Wörner
HID: Add driver for acer keybard with broken rdesc
Hi Simon,
to make sure proper device <-> driver binding is performed, you also have
to add device ID to the hid_have_special_dr
On 02/22/2015 01:37 PM, Gabriele Mazzotta wrote:
On Friday 09 January 2015 16:29:04 Andrew Duggan wrote:
On 01/09/2015 12:04 AM, Gabriele Mazzotta wrote:
On Thursday 08 January 2015 15:58:54 Andrew Duggan wrote:
On 12/24/2014 03:53 PM, Gabriele Mazzotta wrote:
[...snip...]
Also, if you can
Writing to registers is needed for setting configuration parameters.
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-rmi.c | 40
1 file changed, 40 insertions(+)
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
index 28579d7..e2a43a1 100644
servicing of
dribble interrupts on Linux unnecessary. This patch simply disables dribble
interupts when configuring the touchpad.
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-rmi.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
.
Signed-off-by: Andrew Duggan
---
Hi Gabriele,
Can you test this patch on your system to confirm that it fixes your issue?
I was able to test the other two patches so I can confirm that the write
fuction works. But, I don't have a touchpad with the palm detect gesture
enabled so it would be
On 03/17/2015 08:27 AM, Benjamin Tissoires wrote:
On Tue, Mar 17, 2015 at 11:13 AM, Tobias Naumann wrote:
Hi,
I have recorded the requested records today but I am very confused by the
result. I have done the following (evemu):
1. I found out the device to record with "cat /proc/bus/input/devi
ing work, please let me know.
With best regards
Tobbe
On 18.03.2015 02:31, Andrew Duggan wrote:
On 03/17/2015 08:27 AM, Benjamin Tissoires wrote:
On Tue, Mar 17, 2015 at 11:13 AM, Tobias Naumann
wrote:
Hi,
I have recorded the requested records today but I am very confused by
the
result. I have
to set the
device as wake capable. Which results in power/wakeup files in sysfs for
the HID device which do not do anything.
Signed-off-by: Andrew Duggan
---
drivers/hid/i2c-hid/i2c-hid.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-h
.
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-rmi.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
index 368ffdf..721f7f9 100644
--- a/drivers/hid/hid-rmi.c
+++ b/drivers/hid/hid-rmi.c
@@ -1013,6 +1013,7 @@ static int
On 06/16/2015 02:26 PM, Benjamin Tissoires wrote:
Hi Andrew,
On Jun 16 2015 or thereabouts, Andrew Duggan wrote:
Physical buttons do not use F30 to report their state and in some cases the
data reported in F30 is incorrect and inconsistent with what is reported by
the HID descriptor. When
On 06/23/2015 12:17 PM, Benjamin Tissoires wrote:
If the device has been registered but is not populated, we should not
process any incoming interrupt.
Make sure the pointers we are following are valid.
Signed-off-by: Benjamin Tissoires
---
Reviewed-by: Andrew Duggan
drivers/input/rmi4
em in
the core until there is a critical mass of function drivers which
justifies doing dynamic loading.
Reviewed-by: Andrew Duggan
drivers/input/rmi4/Kconfig | 5 +
drivers/input/rmi4/Makefile | 2 +-
drivers/input/rmi4/rmi_bus.c| 11 ++-
drivers/input/rmi4/rm
rmi_process_interrupt_requests() to
trigger a process of the alert.
Signed-off-by: Benjamin Tissoires
---
This will also be needed by hid-rmi when it is eventually converted into
a rmi transport driver.
Reviewed-by: Andrew Duggan
drivers/input/rmi4/rmi_driver.c | 18 +-
drivers/input/rmi4
On 06/23/2015 12:17 PM, Benjamin Tissoires wrote:
num_irq_regs is the count of registers of 1 bytes that we use to check
the irqs. bitmap_and() expects the number of bits.
Signed-off-by: Benjamin Tissoires
---
Reviewed-by: Andrew Duggan
drivers/input/rmi4/rmi_f11.c | 4 ++--
1 file
On 06/23/2015 12:17 PM, Benjamin Tissoires wrote:
Signed-off-by: Benjamin Tissoires
---
Reviewed-by: Andrew Duggan
drivers/input/rmi4/rmi_f11.c | 60 ++--
1 file changed, 35 insertions(+), 25 deletions(-)
diff --git a/drivers/input/rmi4/rmi_f11.c
On 06/23/2015 12:17 PM, Benjamin Tissoires wrote:
Kernel tracking is used in 2 use cases:
- filter out jumps when the sensor is not relieable enough
- provide a MT protocol B when the sensor is providing MT protocol A data
Signed-off-by: Benjamin Tissoires
---
Reviewed-by: Andrew Duggan
On 06/23/2015 12:17 PM, Benjamin Tissoires wrote:
abs_bit and rel_bits should not be computed at each iteration of the for
loop.
finger_press_count is unused.
Break out rmi_f11_parse_finger_state in its own function.
Signed-off-by: Benjamin Tissoires
---
Reviewed-by: Andrew Duggan
be able to
differentiate the various models.
Signed-off-by: Benjamin Tissoires
---
Reviewed-by: Andrew Duggan
drivers/input/rmi4/rmi_driver.c | 43 +
drivers/input/rmi4/rmi_driver.h | 6 ++
drivers/input/rmi4/rmi_f01.c| 7 +++
include/l
-off-by: Benjamin Tissoires
---
Reviewed-by: Andrew Duggan
drivers/input/rmi4/rmi_f11.c | 5 +
include/linux/rmi.h | 3 +++
2 files changed, 8 insertions(+)
diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c
index 77a18aa..50df7a1 100644
--- a/drivers/input
On 06/23/2015 12:17 PM, Benjamin Tissoires wrote:
The SMBus devices have their IRQs disabled after a reset. We need to
configure them by calling rmi_driver_process_config_request() when
enabling the sensor.
Signed-off-by: Benjamin Tissoires
---
Reviewed-by: Andrew Duggan
drivers/input
Hi Gabriele,
On 07/06/2015 03:20 AM, Gabriele Mazzotta wrote:
Hi,
I recently noticed that there's a minor issue with hid-rmi.c. After a
suspend/resume cycle the f11 control register is set to the default
configuration, thus undoing the changes performed on init.
This is because i2c_hid does a
source and ensures scanning is enabled on resume.
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-rmi.c | 56 ++-
1 file changed, 55 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
index 4cf80bb..af191a2
When a device is reset the values of control registers will be reset to
the defaults. This patch reapplies the control register values set for F11
by the driver.
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-rmi.c | 41 ++---
1 file changed, 34 insertions
On 07/09/2015 03:40 PM, Gabriele Mazzotta wrote:
On Thursday 09 July 2015 15:14:17 Andrew Duggan wrote:
When a device is reset the values of control registers will be reset to
the defaults. This patch reapplies the control register values set for F11
by the driver.
Hi,
thanks for this, it
When a device is reset the values of control registers will be reset to
the defaults. This patch reapplies the control register values set for F11
by the driver.
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-rmi.c | 56 +++
1 file changed, 43
correct value based on interrupt mask computed while scanning the PDT.
Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=91102
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-rmi.c | 57 ++-
1 file changed, 52 insertions(+), 5 deletions(-)
diff --git
On at least one platform the kernel prints a warning on resume saying
"Unbalanced IRQ 37 wake disable". This is because enable_irq_wake in the
suspend function is failing. This patch checks to see if the call to
enable_irq_wake succeeded before calling disable_irq_wake.
Signed-off-
On 07/28/2015 04:33 AM, Mika Westerberg wrote:
On Mon, Jul 27, 2015 at 05:08:06PM -0700, Andrew Duggan wrote:
On at least one platform the kernel prints a warning on resume saying
"Unbalanced IRQ 37 wake disable". This is because enable_irq_wake in the
suspend function is failing.
failed during suspend.
Signed-off-by: Andrew Duggan
---
This patch is based on Jiri's for-4.3/i2c-hid and needs Gabriele Mazzotta's
patch which moves where the HID driver's suspend callback call to apply
cleanly.
drivers/hid/i2c-hid/i2c-hid.c | 24
1 f
d
to essentially start over. But, this time I will make sure to follow up
and hopefully not waste your time in the future.
On 07/27/2014 12:26 AM, Dmitry Torokhov wrote:
Hi Andrew,
On Thu, Jul 24, 2014 at 04:47:21PM -0700, Andrew Duggan wrote:
RMI4 Function 0x30 provides support for GPIOs,
Add devicetree binding for I2C devices and add bindings for optional
parameters in the function drivers.
Signed-off-by: Andrew Duggan
---
I saw Benjamin Tissoires's email about the lack of a devicetree implementation
for rmi_i2c.c. I decided to clean up and add documentation to the implemen
Hi Dmitry,
On 08/09/2015 12:40 AM, Dmitry Torokhov wrote:
Hi Andrew,
On Fri, Aug 07, 2015 at 05:37:49PM -0700, Andrew Duggan wrote:
+Optional Properties:
+- syna,sensor-name: The string containing the name of the sensor.
+- syna,attn-gpio: The GPIO number used to assert attention.
+- syna
Hi Dmitry,
On 08/13/2015 09:38 AM, Dmitry Torokhov wrote:
Hi Andrew,
On Fri, Aug 07, 2015 at 05:36:51PM -0700, Andrew Duggan wrote:
Hi Dmitry,
With the renewed interest in supporting SMBus with the Synaptics
RMI4 driver I thought I would look into this again. I'm sorry for
not respondi
This patch removes the GPIO code and instead gets the irq passed
up from the underlying transport (ie i2c-core).
Signed-off-by: Andrew Duggan
---
Hi Dmitry,
I went ahead and removed the GPIO handling code. If we end up needing GPIO
support in the future it sounds like the right thing go to would
Add devicetree binding for I2C devices and add bindings for optional
parameters in the function drivers. Parameters for function drivers are
defined in child nodes for each of the functions.
Signed-off-by: Andrew Duggan
---
This version depends on the "Use generic interrupt handling"
This patch removes the GPIO code and instead gets the irq passed
up from the underlying transport (ie i2c-core).
Signed-off-by: Andrew Duggan
---
After additional testing on a platform which uses board files I realized
that the platform data should be able to provide irq flags. This patch
adds to
Add devicetree binding for I2C devices and add bindings for optional
parameters in the function drivers. Parameters for function drivers are
defined in child nodes for each of the functions.
Signed-off-by: Andrew Duggan
---
This version fixes the issues in v2 pointed out by Benjamin Tissoires
On 09/28/2015 03:10 AM, David Herrmann wrote:
Hi
On Mon, Sep 28, 2015 at 2:23 AM, Dmitry Torokhov
wrote:
[...]
}
static int mt_probe(struct hid_device *hdev, const struct hid_device_id *id)
[snip]
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
index 2c14812..33280f3 100644
On 10/07/2015 08:56 AM, Seth Forshee wrote:
On Wed, Oct 07, 2015 at 09:34:10AM -0400, Benjamin Tissoires wrote:
[sorry for the late answer Jiri, I was on vacations last week]
On Oct 07 2015 or thereabouts, Mika Westerberg wrote:
Some newer Intel Skylake based Dell laptops with Win8 precision
On 10/08/2015 02:40 AM, Mika Westerberg wrote:
On Wed, Oct 07, 2015 at 06:12:42PM -0700, Andrew Duggan wrote:
I can confirm that it is working on the Dell XPS 13 and the buttonpad
property is set correctly. However, I also tried it on an older non
production precision touchpad and it didn&#
On 10/31/2015 01:41 PM, Linus Walleij wrote:
On Thu, Jul 23, 2015 at 7:10 PM, Benjamin Tissoires
wrote:
Dmitry, the Sony guys are currently working on upstreaming their work.
Their Xperia are using a Synaptics I2C touchscreen. They are able to
boot with an upstream kernel a lot of parts now, a
On 11/03/2015 06:01 AM, Linus Walleij wrote:
On Mon, Nov 2, 2015 at 11:14 PM, Andrew Duggan wrote:
I have been continuing to work on the synaptics-rmi4 driver and was just
trying to figure out what the next step should be. I recently uploaded my
changes here https://github.com/aduggan/linux
esn't contain hid-rmi. However, if we want to stick with 3.14 I can
make the appropriate modifications.
Thanks,
Andrew
Andrew Duggan (14):
Input: synaptics-rmi4: Use generic interrupt handling
Input: synaptics-rmi4: Add device tree support for RMI4 I2C devices
Input: synaptics-rmi4: Clean u
process of the alert.
Signed-off-by: Benjamin Tissoires
Tested-by: Andrew Duggan
---
drivers/input/rmi4/rmi_driver.c | 18 +-
drivers/input/rmi4/rmi_driver.h | 3 +++
include/linux/rmi.h | 3 +++
3 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/drivers
1 - 100 of 150 matches
Mail list logo
