Re: [PATCH 1/2] HID: Use multitouch driver for Type Covers

2015-12-18 Thread Bastien Nocera
On Mon, 2015-12-14 at 21:50 +0900, Akihiko Odaki wrote: > Use multitouch driver instead of microsoft one for Microsoft Surface > Type Covers. > > By using MT_CLS_EXPORT_ALL_INPUTS, the keyboards function as well as > the multitouch pads do. > > Signed-off-by: Akihiko Odaki All the multimedia ke

Re: [PATCH 1/2] HID: Use multitouch driver for Type Covers

2015-12-14 Thread Bastien Nocera
On Mon, 2015-12-14 at 21:50 +0900, Akihiko Odaki wrote: > Use multitouch driver instead of microsoft one for Microsoft Surface > Type Covers. > > By using MT_CLS_EXPORT_ALL_INPUTS, the keyboards function as well as > the multitouch pads do. I've discussed this a couple of weeks back with Benjamin

Re: [PATCH 2/2] input: gt801_2plus1 - Add initial support for Goodix GT801 2+1

2015-12-08 Thread Bastien Nocera
Hey Priit, On Mon, 2015-12-07 at 09:26 +0200, Priit Laes wrote: > This patch adds Goodix GT801 2+1 touchscreen controller support. > > GT801 2+1 is a 10-finger touch controller consisting of > ARM controller interfacing two GT801 5-finger controllers. This would implement support for the "Guitar

Re: [PATCH 0/2] input: Driver for Goodix GT801 2+1 touchscreen

2015-12-08 Thread Bastien Nocera
On Mon, 2015-12-07 at 09:25 +0200, Priit Laes wrote: > This series adds support for Goodix GT801 2+1 touchscreen controller > and hooks it up on Gemei G9 tablet. > > Now about GT801 2+1 - I initially tried to implement this inside the > existing Goodix driver, but unfortunately there are too many

Re: [PATCH v11 4/8] Input: goodix - add power management support

2015-11-23 Thread Bastien Nocera
ut doesn't break anything Tested-by: Bastien Nocera -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v11 8/8] Input: goodix - add runtime power management support

2015-11-23 Thread Bastien Nocera
device will suspend if no > handles to it are open for 2 seconds. > > The runtime management support is only available if the gpio pins > are properly initialized from ACPI/DT. > > Signed-off-by: Irina Tirdea Tested-by: Bastien Nocera -- To unsubscribe from this list: send the

Re: [PATCH v11 6/8] Input: goodix - add support for ESD

2015-11-23 Thread Bastien Nocera
On Thu, 2015-11-19 at 14:26 +0200, Irina Tirdea wrote: > > Signed-off-by: Irina Tirdea > For the binding: Acked-by: Rob Herring > > Signed-off-by: Irina Tirdea Tested-by: Bastien Nocera -- To unsubscribe from this list: send the line "unsubscribe linux-input" in

Re: [PATCH v11 3/8] Input: goodix - write configuration data to device

2015-11-23 Thread Bastien Nocera
On Thu, 2015-11-19 at 14:26 +0200, Irina Tirdea wrote: > > Signed-off-by: Octavian Purdila > Signed-off-by: Irina Tirdea Works on the WinBook TW100 Tested-by: Bastien Nocera -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of

Re: [PATCH v11 2/8] Input: goodix - reset device at init

2015-11-23 Thread Bastien Nocera
On Thu, 2015-11-19 at 14:26 +0200, Irina Tirdea wrote: > > Signed-off-by: Octavian Purdila > Signed-off-by: Irina Tirdea Works on the WinBook TW100 Acked-by: Bastien Nocera Tested-by: Bastien Nocera -- To unsubscribe from this list: send the line "unsubscribe linux-input&quo

Re: [PATCH v11 2/8] Input: goodix - reset device at init

2015-11-19 Thread Bastien Nocera
On Thu, 2015-11-19 at 14:26 +0200, Irina Tirdea wrote: > After power on, it is recommended that the driver resets the device. > The reset procedure timing is described in the datasheet and is used > at device init (before writing device configuration) and > for power management. It is a sequence of

Re: Touchpad stops to work after a suspend/hibernate and resume

2015-11-03 Thread Bastien Nocera
On Mon, 2015-11-02 at 19:01 -0600, Mike Mestnik wrote: > Not sure the OP makes the distinction or not.  No model is listed, so > this could be anything from a multi touch mouse to a tablet or phone. I would hope that Marcos can see the difference between a touchscreen and a touchpad. The problem i

Re: Touchpad stops to work after a suspend/hibernate and resume

2015-11-02 Thread Bastien Nocera
On Mon, 2015-11-02 at 22:12 -0200, Marcos Souza wrote: > HI Mike, > > thanks for the quick answer! > > Here I'm using Fedora 22 with GNOME. So, the problem is related to > gnome-settings-daemon and not with the kernel itself? > > Thanks, > > 2015-11-02 22:10 GMT-02:00 Mike Mestnik : > > For som

Re: [PATCH v9 0/9] Goodix touchscreen enhancements

2015-10-26 Thread Bastien Nocera
On Mon, 2015-10-26 at 19:21 +0100, Karsten Merker wrote: > On Mon, Oct 26, 2015 at 04:06:29PM +0100, Bastien Nocera wrote: > > On Mon, 2015-10-12 at 18:24 +0300, Irina Tirdea wrote: > > > > v9 only adds GPIOLIB dependency in Kconfig for patch 2: > > > "Input: go

Re: [PATCH v9 0/9] Goodix touchscreen enhancements

2015-10-26 Thread Bastien Nocera
Hey, On Mon, 2015-10-12 at 18:24 +0300, Irina Tirdea wrote: > v9 only adds GPIOLIB dependency in Kconfig for patch 2: > "Input: goodix - reset device at init". There are no other code > changes from v8. > > Thanks for testing these changes, Bastien and Aleksei! > > Karsten, there is no need to r

Surface 3 Type Cover touchpad: no multi-touch

2015-10-18 Thread Bastien Nocera
Hey, The Type Cover detachable keyboard for the Surface 3 contains a multi- touch touchpad (up to 3 finger gestures). However, this doesn't seem to be working. Attached is the output of hid-recorder doing a 2-finger scroll, and pressing Ctrl+C on the keyboard. CheersD: 0 R: 935 05 01 09 06 a1 01

Re: [PATCH v9 9/9] Input: goodix - sort includes using inverse Xmas tree order

2015-10-12 Thread Bastien Nocera
On Mon, 2015-10-12 at 16:51 +0100, Mark Rutland wrote: > On Mon, Oct 12, 2015 at 05:40:37PM +0200, Bastien Nocera wrote: > > On Mon, 2015-10-12 at 16:39 +0100, Mark Rutland wrote: > > > Why? > > > > It was already discussed in the thread for a previous version

Re: [PATCH v9 9/9] Input: goodix - sort includes using inverse Xmas tree order

2015-10-12 Thread Bastien Nocera
On Mon, 2015-10-12 at 16:39 +0100, Mark Rutland wrote: > Why? It was already discussed in the thread for a previous version, please refer to that. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH RFC V2 2/3] Input: goodix - use "inverted_[xy]" flags instead of "rotated_screen"

2015-10-12 Thread Bastien Nocera
"touchscreen-inverted-x" and > "touchscreen-inverted-y", a separate "rotated_screen" flag > is not necessary any more. This patch replaces it by setting > the inverted_x and inverted_y flags instead. > > Signed-off-by: Karsten Merker Acked-

Re: [PATCH RFC V2 1/3] Input: goodix - add dt axis swapping and axis inversion support

2015-10-12 Thread Bastien Nocera
gt;  - touchscreen-swapped-x-y: X and Y axis are swapped (boolean) > > These are necessary on tablets which have a display in portrait > format while the touchscreen is in landscape format, such as e.g. > the MSI Primo 81. > > Signed-off-by: Karsten Merker Acked-by: Bastien Nocera --

Re: [PATCH RFC V2 0/3] Input: goodix - add axis swapping and axis inversion support

2015-10-12 Thread Bastien Nocera
riate hardware to do a real-world > test of the "rotated_screen" code path, so I would appreciate very > much if somebody with appropriate hardware (WinBook TW100 or TW700) > could give it a try. I've pushed the first 2 patches of this patchset to: https://github.com/hadess/gt

Re: [PATCH v8 2/9] Input: goodix - reset device at init

2015-10-09 Thread Bastien Nocera
D,  Package () > { > ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), > Package () > { > Package (2) {"irq-gpio", Package() {^STAC, 0, 0, 0 }}, > Package (2) {"reset-gpio", Package() {^STAC, 1, 0, 0 }}, > ... > } > } >

Re: [PATCH v8 0/9] Goodix touchscreen enhancements

2015-10-09 Thread Bastien Nocera
On Thu, 2015-10-08 at 17:23 +0300, Irina Tirdea wrote: > Add several enhancements to the Goodix touchscreen driver. > > The new functionality is only available for devices that > declare named gpio pins for interrupt and reset in their > ACPI/DT configuration. You can add Tes

Re: [PATCH v7 2/9] Input: goodix - reset device at init

2015-10-08 Thread Bastien Nocera
On Thu, 2015-10-08 at 12:54 +0200, Arnd Bergmann wrote: > I think lists like this in drivers should be avoided if at all > possible, > it just leads to other people adding their platform in the lists as > opposed to fixing their boot loaders. Instructions on fixing UEFI firmwares without the sourc

Re: [PATCH] HID: wacom: Add support for Cintiq Companion 2

2015-10-07 Thread Bastien Nocera
On Wed, 2015-10-07 at 16:55 -0700, Jason Gerecke wrote: > Signed-off-by: Jason Gerecke > Signed-off-by: Clifford Jolly Is that support for using the Cintiq Companion 2 as an accessory (eg. still running Windows on the machine, and plugging it in to a Linux machine), or for the Wacom device insid

Re: [PATCH RFC 0/2] Input: Goodix - add axis swapping and inversion support

2015-09-30 Thread Bastien Nocera
Can't test for now, but: Reviewed-by: Bastien Nocera We'll have to wait until Irina's patchset lands though, and we'll test at that point. Cheers -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to m

Re: [PATCH v3 1/5] Input: goodix - reset device at init

2015-09-30 Thread Bastien Nocera
On Tue, 2015-09-29 at 17:47 +, Tirdea, Irina wrote: > > > -Original Message- > > From: Bastien Nocera [mailto:had...@hadess.net] > > Sent: 29 September, 2015 5:04 > > To: Tirdea, Irina; linux-input@vger.kernel.org > > Cc: linux-ker...@vger.kernel.

Re: [PATCH v3 1/5] Input: goodix - reset device at init

2015-09-28 Thread Bastien Nocera
On Fri, 2015-09-25 at 21:04 +, Tirdea, Irina wrote: > > > -Original Message- > > From: Bastien Nocera [mailto:had...@hadess.net] > > Sent: 25 September, 2015 17:44 > > To: Tirdea, Irina; linux-input@vger.kernel.org > > Cc: linux-ker...@vger.kernel.

Re: [PATCH v6 4/9] Input: goodix - write configuration data to device

2015-09-25 Thread Bastien Nocera
On Tue, 2015-09-15 at 17:31 +0300, Irina Tirdea wrote: > Goodix devices can be configured by writing custom data to the device > at > init. The configuration data is read with request_firmware from > "goodix__cfg.bin", where is the product id read from the > device > (e.g.: goodix_911_cfg.bin for

Re: [PATCH v3 1/5] Input: goodix - reset device at init

2015-09-25 Thread Bastien Nocera
On Thu, 2015-09-10 at 14:04 +, Tirdea, Irina wrote: > > > -Original Message- > > From: Bastien Nocera [mailto:had...@hadess.net] > > Sent: 09 September, 2015 20:03 > > To: Tirdea, Irina; linux-input@vger.kernel.org > > Cc: linux-ker...@vger.kernel.

Re: [PATCH RESEND v2] HID: Add new Microsoft Type Cover 3 product ID

2015-09-15 Thread Bastien Nocera
On Tue, 2015-09-15 at 12:48 -0400, Donavan Lance wrote: > Patch resent again since it got mangled again. I've tested emailing > this one multiple times and so should be fine, but I'll refrain from > sending out this patch again. Apologies for spamming the list with > this > patch. Are you using E

Re: [PATCH v3 1/5] Input: goodix - reset device at init

2015-09-09 Thread Bastien Nocera
On Thu, 2015-07-30 at 11:27 +, Tirdea, Irina wrote: > I can send some additional patches that will simplify testing the > configuration update to the Goodix device. I think this feature is > the easiest > to test so we can determine if writing to the interrupt pin actually > works. > However, e

Re: [PATCH v5 3/9] Input: goodix - reset device at init

2015-09-09 Thread Bastien Nocera
On Mon, 2015-09-07 at 17:36 +0300, Irina Tirdea wrote: > After power on, it is recommended that the driver resets the device. > The reset procedure timing is described in the datasheet and is used > at device init (before writing device configuration) and > for power management. It is a sequence of

Re: [PATCH v5 2/9] Input: goodix - use actual config length for each device type

2015-09-09 Thread Bastien Nocera
nfiguration length as specified in the datasheet for > each device model, so we do not read more than the actual size of the > configuration registers. > > Signed-off-by: Irina Tirdea Acked-by: Bastien Nocera > --- > drivers/input/touchscreen/goodix.c | 25 +++

Re: [PATCH v5 1/9] Input: goodix - sort includes alphabetically

2015-09-09 Thread Bastien Nocera
On Mon, 2015-09-07 at 17:36 +0300, Irina Tirdea wrote: > Signed-off-by: Irina Tirdea Acked-by: Bastien Nocera > --- > drivers/input/touchscreen/goodix.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/input/touchscreen/goodix.c

Re: "Super Joy Box 7" gameport adapter

2015-08-31 Thread Bastien Nocera
On Sun, 2015-08-30 at 16:44 +0200, Clément Vuchener wrote: > > Are those the correct values, or are they indeed supposed to be > > reversed in software (in the kernel, or in user-space)? > It is the same on mine (MS Sidewinder Precision 2) and it never > bothered me. You just have to configure your

Re: "Super Joy Box 7" gameport adapter

2015-08-30 Thread Bastien Nocera
On Sun, 2015-08-30 at 15:39 +0200, Bastien Nocera wrote: > On Sun, 2015-08-30 at 15:28 +0200, Clément Vuchener wrote: > > It looks like the kind of thing that would happen if the throttle > > was > > reported as a hat switch in the HID descriptor. But I think there >

Re: "Super Joy Box 7" gameport adapter

2015-08-30 Thread Bastien Nocera
evel to know how much the hardware is wrong and > if this can be fixed by the kernel. hid-record output attached. Doesn't look too good. > On 08/30/2015 12:58 PM, Bastien Nocera wrote: > > Hey, > > > > I've recently found my old Gravis Blackhawk again, and bough

"Super Joy Box 7" gameport adapter

2015-08-30 Thread Bastien Nocera
Hey, I've recently found my old Gravis Blackhawk again, and bought a "Super Joy Box 7" gameport adapter[2] to try and play some Descent or X-Wing vs. Tie Fighter. Problem is that the throttle (just about the tip of "l" in the box photo) throws ABS_HAT0X/ABS_HAT0Y values instead of ABS_THROTTLE.

Re: Adding an interface to evdev for tablet orientation

2015-08-16 Thread Bastien Nocera
On Sun, 2015-08-16 at 22:12 +0200, Hans de Goede wrote: > > Interesting, so you're suggesting to not add any new evdev event > types for this at all, and to instead use a sysfs attribute + > change kevents on orientation changes so that userspace will know > when to re-read the sysfs attribute ?

Re: Adding an interface to evdev for tablet orientation

2015-08-16 Thread Bastien Nocera
Hey Hans, On Thu, 2015-08-06 at 15:19 +0200, Hans de Goede wrote: > Hi All, > > Many accelerometers used in tablets not only offer acceleration > data along 3 axis, but also have a notion of the orientation of > the tablet (right side up, upside down, rotated 90 degrees > left/right), > currentl

Re: [PATCH v4 0/8] Goodix touchscreen enhancements

2015-08-03 Thread Bastien Nocera
On Fri, 2015-07-31 at 20:42 +0300, Irina Tirdea wrote: > Add several enhancements to the Goodix touchscreen driver. It's going to be a couple of weeks before I have the time to sit down and test most of those. Also note that I'll be using a different device (WinBook TW100), though the new owner of

Re: [PATCH v2] Input: goodix - Fix touch coords on WinBook TW100 and TW700

2015-07-24 Thread Bastien Nocera
On Fri, 2015-07-24 at 09:08 -0700, Dmitry Torokhov wrote: > On Fri, Jul 24, 2015 at 01:13:24PM +0200, Bastien Nocera wrote: > > On Thu, 2015-07-23 at 14:56 -0700, Dmitry Torokhov wrote: > > > Hi Bastien, > > > > > > On Thu, Jul 23, 2015 at 04:13:28PM +020

[PATCH v3] Input: goodix - Fix touch coords on WinBook TW100 and TW700

2015-07-24 Thread Bastien Nocera
0,800 +-+ | | | | | | +-+ 1280,0 0,0 It's unfortunately impossible to detect this problem with data from the DSDT, or other auxiliary metadata, so fallback to quirking this specific model of tablet instead. Signed-off-by: Bastien Nocera Reviewed-by: Benjamin Tissoires --- dri

Re: [PATCH v2] Input: goodix - Fix touch coords on WinBook TW100 and TW700

2015-07-24 Thread Bastien Nocera
On Thu, 2015-07-23 at 14:56 -0700, Dmitry Torokhov wrote: > Hi Bastien, > > On Thu, Jul 23, 2015 at 04:13:28PM +0200, Bastien Nocera wrote: > > The touchscreen on the WinBook TW100 and TW700 don't match the > > default > > display, with 0,0 touches being reported

Re: [RFC_v2 0/4] HID: hid-sony: Add IIO Suport for Motion Controllers

2015-07-23 Thread Bastien Nocera
On Tue, 2015-06-23 at 18:30 -0600, Simon Wood wrote: > > (1) > https://richardstechnotes.wordpress.com/2015/06/17/rteiioimu-driving-a-9-dof-imu-via-industrial-io-iio/ > That URL doesn't seem to work anymore. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body

[PATCH v2] Input: goodix - Fix touch coords on WinBook TW100 and TW700

2015-07-23 Thread Bastien Nocera
0,800 +-+ | | | | | | +-+ 1280,0 0,0 It's unfortunately impossible to detect this problem with data from the DSDT, or other auxiliary metadata, so fallback to quirking this specific model of tablet instead. Signed-off-by: Bastien Nocera Reviewed-by: Benjamin Tissoires --- dri

Re: How to add support for Motorola RZ100?

2015-07-23 Thread Bastien Nocera
On Thu, 2015-07-23 at 12:57 +0200, Hanno Zulla wrote: > Hi there, > > how can I help add support for the following device? > > The "Motorola Smart Controller RZ100" is a combined telephony headset > and HID touchpad with four Android-specific buttons. It is designed > to > work as a remote contr

[PATCH] Input: goodix - Fix touch coords on WinBook TW100

2015-07-20 Thread Bastien Nocera
0,800 +-+ | | | | | | +-+ 1280,0 0,0 It's unfortunately impossible to detect this problem with data from the DSDT, or other auxiliary metadata, so fallback to quirking this specific model of tablet instead. Signed-off-by: Bastien Nocera Reviewed-by: Benjamin Tissoires --- dri

Re: [PATCH v2] usbtouchscreen: adds support for inverting X or Y axis (or both)

2015-07-13 Thread Bastien Nocera
On Mon, 2015-07-13 at 12:15 +0200, Philippe Coval wrote: > Invert Y is needed (together with swap XY) for some touchscreens : > - LeadingTouch screens (at least for some of them) > - CarTft 8in4 (USB ID=0eef:0001) Wouldn't it be useful to force those settings for touchscreen devices which you can

Re: [PATCH v3 1/5] Input: goodix - reset device at init

2015-06-30 Thread Bastien Nocera
On Mon, 2015-06-29 at 19:28 +0300, Irina Tirdea wrote: > After power on, it is recommended that the driver resets the device. > The reset procedure timing is described in the datasheet and is used > at device init (before writing device configuration) and > for power management. It is a sequence of

Re: [PATCH v3 3/5] Input: goodix - add power management support

2015-06-30 Thread Bastien Nocera
On Mon, 2015-06-29 at 19:28 +0300, Irina Tirdea wrote: > Implement suspend/resume for goodix driver. > > The suspend and resume process uses the gpio pins. > If the device ACPI/DT information does not declare gpio pins, > suspend/resume will not be available for these devices. > > This is based o

Re: [PATCH v2 4/8] input: goodix: reset device at init

2015-06-23 Thread Bastien Nocera
On Tue, 2015-06-23 at 13:23 +, Tirdea, Irina wrote: > > > -Original Message- > > From: linux-input-ow...@vger.kernel.org [mailto: > > linux-input-ow...@vger.kernel.org] On Behalf Of Bastien Nocera > > Sent: 09 June, 2015 18:53 > > To: Tirdea, Ir

Re: [RFC] HID: hid-sony: Add basic iio-subsystem reading of SixAxis Accelerometers

2015-06-11 Thread Bastien Nocera
On Thu, 2015-06-11 at 08:54 -0600, Simon Wood wrote: > [resent as I screwed up addressing... sorry] > > This patch is a RFC/POC for the idea of using the iio-subsystem as > the > 'proper' way to communicate the state of motion enabled controllers > to > the Linux internals. > > I have started w

Re: [PATCH] Input: goodix - do not explicitly set evbits in input device

2015-06-10 Thread Bastien Nocera
On Wed, 2015-06-10 at 10:39 -0400, Benjamin Tissoires wrote: > On Jun 10 2015 or thereabouts, Bastien Nocera wrote: > > On Tue, 2015-06-09 at 11:52 -0700, Dmitry Torokhov wrote: > > > input_mt_init_slots() will do that for us. > > > > I'm guessing you know wha

Re: [PATCH] Input: goodix - do not explicitly set evbits in input device

2015-06-10 Thread Bastien Nocera
On Tue, 2015-06-09 at 11:52 -0700, Dmitry Torokhov wrote: > input_mt_init_slots() will do that for us. I'm guessing you know what you're doing here, but I couldn't find where the EV_SYN bit would have been set in the input_mt_init_slots() call chain. > Signed-off-by: Dmitry Torokhov > --- > dri

Re: [PATCH v2 4/8] input: goodix: reset device at init

2015-06-09 Thread Bastien Nocera
On Tue, 2015-06-09 at 17:34 +0200, Bastien Nocera wrote: > On Mon, 2015-06-08 at 17:37 +0300, Irina Tirdea wrote: > > After power on, it is recommended that the driver resets the > > device. > > The reset procedure timing is described in the datasheet and is > > used

Re: [PATCH v2 2/8] input: goodix: fix variable length array warning

2015-06-09 Thread Bastien Nocera
resources. > > Signed-off-by: Irina Tirdea Acked-by: Bastien Nocera > --- > drivers/input/touchscreen/goodix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/goodix.c > b/drivers/input/touchscreen/goodix.c > index a65

Re: [PATCH v2 4/8] input: goodix: reset device at init

2015-06-09 Thread Bastien Nocera
On Mon, 2015-06-08 at 17:37 +0300, Irina Tirdea wrote: > After power on, it is recommended that the driver resets the device. > The reset procedure timing is described in the datasheet and is used > at device init (before writing device configuration) and > for power management. It is a sequence of

Re: [PATCH v2 3/8] input: goodix: export id and version read from device

2015-06-09 Thread Bastien Nocera
product id and > firmware version read from the device rather than using constant > values. > > Signed-off-by: Octavian Purdila > Signed-off-by: Irina Tirdea Acked-by: Bastien Nocera -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the b

Re: Handling Controllers with Acc/Gyro/Mag via HID system

2015-06-09 Thread Bastien Nocera
On Mon, 2015-06-08 at 22:38 -0400, si...@mungewell.org wrote: > > > > Hi all, > > I'm in the process of fixing the HID descriptor for the PS3 Move > Controller. which has a particularly convoluted layout for it's > > Accelormeters, Gyros and Magnetometers involving 2 sets of data per > > output >

Re: [PATCH 0/3] Switch input leds over to standard LED class devices

2015-06-08 Thread Bastien Nocera
On Mon, 2015-06-08 at 14:43 -0700, Dmitry Torokhov wrote: > Hi, > > I finally was able to spend some time looking over Samuel's patch set > switching input LEDs from custom implementation over to standard LED > class > devices and I think this is the shape I am reasonably happy with. The > change

Re: [PATCH 0/9] Goodix touchscreen enhancements

2015-06-04 Thread Bastien Nocera
Hey Irina, On Thu, 2015-05-28 at 15:47 +0300, Irina Tirdea wrote: > Add several enhancements to the Goodix touchscreen driver: > - write configuration data to the device > - power management support > - cleanup and refactoring > > Irina Tirdea (9): > input: goodix: fix alignment issues > i

Re: [PATCH 7/9] input: goodix: add power management support

2015-06-04 Thread Bastien Nocera
On Thu, 2015-05-28 at 15:47 +0300, Irina Tirdea wrote: > Implement suspend/resume for goodix driver. > > Signed-off-by: Octavian Purdila > Signed-off-by: Irina Tirdea > --- > drivers/input/touchscreen/goodix.c | 81 > +++--- > 1 file changed, 76 insertions(+), 5

Re: [PATCH 8/9] input: goodix: add support for ESD

2015-06-04 Thread Bastien Nocera
On Thu, 2015-05-28 at 14:26 +, Tirdea, Irina wrote: > > > -Original Message- > > From: linux-input-ow...@vger.kernel.org [mailto: > > linux-input-ow...@vger.kernel.org] On Behalf Of Mark Rutland > > Sent: 28 May, 2015 16:24 > > To: Tirdea, Irina > &

Re: [PATCH 6/9] input: goodix: write configuration data to device

2015-06-04 Thread Bastien Nocera
On Thu, 2015-05-28 at 13:51 +, Tirdea, Irina wrote: > > > -Original Message- > > From: Mark Rutland [mailto:mark.rutl...@arm.com] > > Sent: 28 May, 2015 16:22 > > To: Tirdea, Irina > > Cc: Dmitry Torokhov; Bastien Nocera; linux-input@vger.kernel.org

Re: [PATCH 4/9] input: goodix: add ACPI IDs for GT911 and GT9271

2015-06-04 Thread Bastien Nocera
On Thu, 2015-05-28 at 15:47 +0300, Irina Tirdea wrote: > Add ACPI IDs to support Goodix GT911 and GT9271 > touchscreens. Those devices are present on which systems which you would have tested this on? > Signed-off-by: Irina Tirdea > --- > drivers/input/touchscreen/goodix.c | 2 ++ > 1 file chan

Re: [PATCH 1/9] input: goodix: fix alignment issues

2015-06-04 Thread Bastien Nocera
On Thu, 2015-05-28 at 15:47 +0300, Irina Tirdea wrote: > Fix alignment to match open parenthesis detected by > running checkpatch.pl --strict. > > Signed-off-by: Irina Tirdea Looks innocuous enough. Acked-by: Bastien Nocera > --- > drivers/input/touchsc

Re: [PATCH v2] input: goodix: Check the 'buffer status' bit before reading data

2015-05-01 Thread Bastien Nocera
; ignored, which resulted in a lot of incorrect detections of "finger > removed" events. > > Signed-off-by: Paul Cercueil Signed-off-by: Bastien Nocera -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to

Re: [PATCH] input: goodix: Check the 'data ready' bit before reading data

2015-04-25 Thread Bastien Nocera
called "buffer status" in the datasheets) when an interrupt is raised. Previously, this bit was ignored, which resulted in a lot of incorrect detections of "finger removed" events. And for the commit subject: input: goodix: Check the 'buffer status' bit before reading

Re: [PATCH] Input: goodix - preliminary support for GT801-2+1

2015-04-08 Thread Bastien Nocera
On Sun, 2015-04-05 at 16:56 -0700, Dmitry Torokhov wrote: > On Sun, Apr 05, 2015 at 06:04:24PM +0200, Bastien Nocera wrote: > > On Sun, 2015-04-05 at 00:08 +0300, Priit Laes wrote: > > > This patch implements GT801x2 touchscreen support. > > > Unfortunately, there is a b

Re: [PATCH] Input: goodix - preliminary support for GT801-2+1

2015-04-08 Thread Bastien Nocera
On Sun, 2015-04-05 at 20:06 +0300, Priit Laes wrote: > On Sun, 2015-04-05 at 18:04 +0200, Bastien Nocera wrote: > > On Sun, 2015-04-05 at 00:08 +0300, Priit Laes wrote: > > > This patch implements GT801x2 touchscreen support. > > > Unfortunately, there is a big differe

Re: [PATCH] Input: goodix - preliminary support for GT801-2+1

2015-04-05 Thread Bastien Nocera
On Sun, 2015-04-05 at 00:08 +0300, Priit Laes wrote: > This patch implements GT801x2 touchscreen support. > Unfortunately, there is a big difference between GT801 and GT9xx > series > chips, therefore some advice is needed on how to proceed. > > Differences between GT801x2 and GT9xx series: > >

Re: [PATCH] Documentation: input - define INPUT_PROP_ACCELEROMETER behavior

2015-03-26 Thread Bastien Nocera
EEL. > > It is not permitted to mix normal directional axes and accelerometer > axes on > the same device node. > > Signed-off-by: Peter Hutterer Looks good. Reviewed-by: Bastien Nocera -- To unsubscribe from this list: send the line "unsubscribe linux-inp

Re: [PATCH v2] add support for Freescale's MMA8653FC 10 bit accelerometer

2015-03-19 Thread Bastien Nocera
On Wed, 2015-03-18 at 19:28 +0100, Martin Kepplinger wrote: > Am 2015-03-18 um 19:05 schrieb Bastien Nocera: > > On Wed, 2015-03-18 at 19:02 +0100, Martin Kepplinger wrote: > > > Am 2015-03-18 um 17:59 schrieb Bastien Nocera: > > > > On Wed, 2015-03-18 at 17:42

Re: [PATCH v2] add support for Freescale's MMA8653FC 10 bit accelerometer

2015-03-18 Thread Bastien Nocera
On Wed, 2015-03-18 at 19:02 +0100, Martin Kepplinger wrote: > Am 2015-03-18 um 17:59 schrieb Bastien Nocera: > > On Wed, 2015-03-18 at 17:42 +0100, Martin Kepplinger wrote: > > > > > > > > It could have gone to drivers/iio/accel if it would use an iio >

Re: [PATCH v2] add support for Freescale's MMA8653FC 10 bit accelerometer

2015-03-18 Thread Bastien Nocera
On Wed, 2015-03-18 at 17:42 +0100, Martin Kepplinger wrote: > > It could have gone to drivers/iio/accel if it would use an iio > interface, which would make more sense, you are right, but I simply > don't have the time to merge it in to iio. > > It doesn't use an input interface either but I d

Re: [RFC v2 2/7] media: rc: Add cec protocol handling

2015-03-10 Thread Bastien Nocera
On Tue, 2015-03-10 at 13:02 +0100, Kamil Debski wrote: > Hi Bastien, > > From: Bastien Nocera [mailto:had...@hadess.net] > Sent: Monday, March 09, 2015 5:44 PM > > > > On Mon, 2015-03-09 at 17:22 +0100, Kamil Debski wrote: > > > Hi Mauro, > > > >

Re: [RFC v2 2/7] media: rc: Add cec protocol handling

2015-03-09 Thread Bastien Nocera
On Mon, 2015-03-09 at 17:22 +0100, Kamil Debski wrote: > Hi Mauro, > > From: Mauro Carvalho Chehab [mailto:mche...@osg.samsung.com] > Sent: Sunday, March 08, 2015 3:21 PM > > > Em Thu, 22 Jan 2015 17:04:34 +0100 > > Kamil Debski escreveu: > > > > (c/c linux-input ML) > > > > > Add cec protocol

Re: [PATCH v3] input: goodix: Add device tree support

2015-03-06 Thread Bastien Nocera
umber from config instead of hardcoding. > * Update description in Kconfig. > > Datasheets can be found here: > https://drive.google.com/folderview?id=0BxCVOQS3ZymGfmJyY2RKbE5XbVlKNlktVTlwV0lxNEdxd2dzeWZER094cmJPVnMxN1F0Yzg&usp=sharing > > Signed-off-by: Aleksei Mamlin Reviewed-b

Re: [PATCH] input: goodix: Use max touch number from device config

2015-03-06 Thread Bastien Nocera
On Thu, 2015-03-05 at 20:32 +0300, Aleksei Mamlin wrote: > Use max number of touches from device config instead of hardcoding. > > Signed-off-by: Aleksei Mamlin Tested-by: Bastien Nocera Acked-by: Bastien Nocera > --- > drivers/input/touchscreen/goodix.c | 13 - &g

Re: [PATCH v2] input: goodix: Add device tree support

2015-03-05 Thread Bastien Nocera
On Thu, 2015-03-05 at 19:18 +0300, Aleksei Mamlin wrote: > This patch adds device tree support and binding information for > Goodix GT9xx series touchscreen controller. > It also adds support for 5-finger chips, like GT911 and GT912, which > can be found on ARM tablets, like Wexler TAB7200 and MS

Re: [PATCH] Add short KEY_DIRECTION description

2015-03-04 Thread Bastien Nocera
I need the same key in my Thinkpad patch. But could you use a more descriptive name, such as KEY_ROTATE_DISPLAY? > On 4 Mar 2015, at 22:42, Stefan Brüns wrote: > > Signed-off-by: Stefan Brüns > --- > Requested 5 years ago: https://lkml.org/lkml/2010/2/27/36 > See also http://comments.gmane.o

Re: [PATCH 1/2] input: goodix: Add device tree support

2015-03-04 Thread Bastien Nocera
On Wed, 2015-03-04 at 11:33 +0300, Aleksei Mamlin wrote: > This patch adds device tree support for Goodix GT9xx series > touchscreen controller. > diff --git a/drivers/input/touchscreen/Kconfig > b/drivers/input/touchscreen/Kconfig > index 5891752..7a6ab8c 100644 > --- a/drivers/input/touchscre

Re: [PATCH 2/2] input: goodix: Add device tree support for 5-finger chips

2015-03-04 Thread Bastien Nocera
On Wed, 2015-03-04 at 11:34 +0300, Aleksei Mamlin wrote: > This patch adds device tree support for 5-finger chips, like GT911 > and GT912. You should add the same support to the ACPI matching. > #ifdef CONFIG_OF > static struct of_device_id goodix_of_match[] = { > - { .compatible = "goo

[PATCH] thinkpad_acpi: use DEVICE_ATTR_* macros

2015-03-02 Thread Bastien Nocera
Use the DEVICE_ATTR_* macros to reduce boiler plate. Signed-off-by: Bastien Nocera --- drivers/platform/x86/thinkpad_acpi.c | 72 ++-- 1 file changed, 20 insertions(+), 52 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86

[PATCH 2/4] thinkpad_acpi: Factor out get/set adaptive kbd mode

2015-03-02 Thread Bastien Nocera
Move the getting/setting of the adaptive keyboard mode to separate functions, so that we can reuse them later through sysfs attributes. Signed-off-by: Bastien Nocera --- drivers/platform/x86/thinkpad_acpi.c | 61 ++-- 1 file changed, 38 insertions(+), 23

[PATCH 3/4] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr

2015-03-02 Thread Bastien Nocera
Add a sysfs attribute to allow privileged users to change the keyboard mode. This could be used by desktop environments to change the keyboard mode depending on the application focused, as the Windows application does. Signed-off-by: Bastien Nocera --- Documentation/laptops/thinkpad-acpi.txt

[PATCH 4/4] thinkpad_acpi: Add support for more adaptive kbd buttons

2015-03-02 Thread Bastien Nocera
This commit adds new elements to the ThinkPad keymaps, and will send key events for keys for which an input.h declaration exists. Signed-off-by: Bastien Nocera --- drivers/platform/x86/thinkpad_acpi.c | 80 +++- 1 file changed, 79 insertions(+), 1 deletion

[PATCH 1/4] thinkpad_acpi: Remember adaptive kbd presence

2015-03-02 Thread Bastien Nocera
Rather than checking on each suspend and resume whether the laptop has an adaptive keyboard, check when the driver is initialised. Signed-off-by: Bastien Nocera --- drivers/platform/x86/thinkpad_acpi.c | 37 ++-- 1 file changed, 18 insertions(+), 19 deletions

Re: udev timeout for mma8450 unless the accelerometer is shaken

2015-02-26 Thread Bastien Nocera
On Thu, 2015-02-26 at 14:05 +0100, Stefan Sauer wrote: > hi, > > on my beaglebone-black I get these lines during bootup > > [ 71.745951] udevd[105]: worker [113] > /devices/ocp.2/4819c000.i2c/i2c-2/2-001d/input/input2/event1 timeout; > kill it > [ 71.771991] udevd[105]: seq 1243 > '/devices/o

Re: [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-02-26 Thread Bastien Nocera
On Wed, 2015-02-25 at 22:18 -0800, Darren Hart wrote: > On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote: > > Rather than checking on each suspend and resume whether the laptop > > has an adaptive keyboard, check when the driver is initialised. > > Bastien,

Re: [PATCH 5/7] input: Add keycodes used by Lenovo Carbon X1 2014

2015-02-24 Thread Bastien Nocera
On Fri, 2015-02-20 at 19:54 +0100, Bastien Nocera wrote: > Hey Dmitry, > > On Fri, 2015-02-20 at 10:40 -0800, Dmitry Torokhov wrote: > > On Fri, Feb 20, 2015 at 10:04:04AM -0500, Benjamin Tissoires wrote: > > > On Fri, Feb 20, 2015 at 9:44 AM, Bastien Nocera wrote: > &

Re: [PATCH 3/6] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr

2015-02-23 Thread Bastien Nocera
On Mon, 2015-02-23 at 14:00 -0300, Henrique de Moraes Holschuh wrote: > On Fri, Feb 20, 2015, at 02:28, Darren Hart wrote: > > On Wed, Feb 18, 2015 at 09:53:44PM +0100, Bastien Nocera wrote: > > > > Commit message please. > > > > > Signed-off-by: Bastien Nocer

Re: [PATCH 5/6] input: Add keycodes used by Lenovo Carbon X1 2014

2015-02-23 Thread Bastien Nocera
On Mon, 2015-02-23 at 07:49 -0300, Henrique de Moraes Holschuh wrote: > On Mon, Feb 23, 2015, at 07:15, Bastien Nocera wrote: > > On Wed, 2015-02-18 at 21:34 -0200, Henrique de Moraes Holschuh wrote: > > > On Wed, 18 Feb 2015, Bastien Nocera wrote: > > > >

Re: [PATCH 7/7] thinkpad_acpi: use DEVICE_ATTR_* macros

2015-02-23 Thread Bastien Nocera
On Mon, 2015-02-23 at 07:25 -0300, Henrique de Moraes Holschuh wrote: > On Fri, Feb 20, 2015, at 11:44, Bastien Nocera wrote: > > Use the DEVICE_ATTR_RW macro to reduce boiler plate > > So far, so good, but you also used the DEVICE_ATTR_RO macro... > > > and move the attr

Re: [PATCH 5/6] input: Add keycodes used by Lenovo Carbon X1 2014

2015-02-23 Thread Bastien Nocera
On Wed, 2015-02-18 at 21:34 -0200, Henrique de Moraes Holschuh wrote: > On Wed, 18 Feb 2015, Bastien Nocera wrote: > > Signed-off-by: Bastien Nocera > > This one requires an ACK from the input maintainers, or no go... Any comments about the other patches? -- To unsubscribe from

Re: [PATCH 6/7] thinkpad_acpi: More Carbon X1 2014 keys

2015-02-23 Thread Bastien Nocera
On Fri, 2015-02-20 at 11:27 -0800, Andy Lutomirski wrote: > On 02/20/2015 06:44 AM, Bastien Nocera wrote: > > + KEY_MICCANCEL_MODE, /* Microphone cancellation */ > > What's this? We already have KEY_MICMUTE. Is this different? If so, > can you improve the

Re: [PATCH 5/7] input: Add keycodes used by Lenovo Carbon X1 2014

2015-02-20 Thread Bastien Nocera
Hey Dmitry, On Fri, 2015-02-20 at 10:40 -0800, Dmitry Torokhov wrote: > On Fri, Feb 20, 2015 at 10:04:04AM -0500, Benjamin Tissoires wrote: > > On Fri, Feb 20, 2015 at 9:44 AM, Bastien Nocera wrote: > > > Signed-off-by: Bastien Nocera > > > --- > > &

Re: [PATCH 3/7] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr

2015-02-20 Thread Bastien Nocera
On Fri, 2015-02-20 at 17:27 +0200, Mika Westerberg wrote: > On Fri, Feb 20, 2015 at 04:22:07PM +0100, Bastien Nocera wrote: > > On Fri, 2015-02-20 at 17:20 +0200, Mika Westerberg wrote: > > > On Fri, Feb 20, 2015 at 03:44:22PM +0100, Bastien Nocera wrote: > > > >

Re: [PATCH 3/7] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr

2015-02-20 Thread Bastien Nocera
On Fri, 2015-02-20 at 17:20 +0200, Mika Westerberg wrote: > On Fri, Feb 20, 2015 at 03:44:22PM +0100, Bastien Nocera wrote: > > Add a sysfs attribute to allow privileged users to change the keyboard > > mode. This could be used by desktop environments to change the keyboard > &

  1   2   >