Re: [PATCH] HID-picoLCD: Deletion of unnecessary checks before three function calls

2015-06-29 Thread Bruno Prémont
); } int picolcd_resume_lcd(struct picolcd_data *data) Would you like to integrate this update suggestion into another source code repository? Sorry for forgetting about this patch. Looks good to me: Reviewed-by: Bruno Prémont bonb...@linux-vserver.org Jiri, can you take it? Best

Re: Logitech G-series drivers

2015-02-19 Thread Bruno Prémont
Hi Ciprian, Adding linux-input and Jiri (HID maintainer) to CC. On Sun, 15 Feb 2015 23:17:27 +0200 Ciprian Ciubotariu wrote: I would like to submit to your attention for inclusion in the mainline kernel a series of drivers for a set of Logitech keybord devices. I forked the sources under a

Re: [PATCH] Input: evdev - add EVIOCREVOKE ioctl

2015-02-04 Thread Bruno Prémont
Hi David, Sorry for reviving this old thread (I didn't find more recent patch series at first glance or have not been using the proper keyword while searching). At FOSDEM 2015 last Sunday Hans presented libinput X input driver and mentioned evdev FD revoking. A question I raise was how are

Re: [PATCH] Input: evdev - add EVIOCREVOKE ioctl

2015-02-04 Thread Bruno Prémont
Hi David, On Wed, 04 February 2015 David Herrmann wrote: On Wed, Feb 4, 2015 at 2:12 PM, Bruno Prémont wrote: Hi David, Sorry for reviving this old thread (I didn't find more recent patch series at first glance or have not been using the proper keyword while searching). At FOSDEM

Re: [PATCH] input: Add soft kill switch for input devices

2015-01-06 Thread Bruno Prémont
On Sat, 03 January 2015 Tristan Lelong tris...@lelong.xyz wrote: This adds a sysfs attribute named 'mute' to all input devices. It allows to disable them by software in a generic way. It can be set to 0 or 1: echo 1 /sys/class/input/inputX/mute: will set all the input_events() call to

Re: [PATCH v7 0/6] mfd: AXP20x: Add support for AXP202 and AXP209

2014-10-22 Thread Bruno Prémont
On Sun, 29 Jun 2014 20:23:51 +0200 Carlo Caione wrote: During the merging of v6 several patches were left out. This v7 comprises all the patches that are still pending. Any progress on this or reason why these are stuck? //-- AXP209 and AXP202 are the PMUs (Power Management Unit) used by

Re: [PATCH 2/2] HID: picolcd: sanity check report size in raw_event() callback

2014-08-27 Thread Bruno Prémont
...@vger.kernel.org Reported-by: Steven Vittitoe scvi...@google.com Signed-off-by: Jiri Kosina jkos...@suse.cz Acked-by: Bruno Prémont bonb...@linux-vserver.org --- drivers/hid/hid-picolcd_core.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/hid/hid-picolcd_core.c b

Re: [PATCH 2/2] HID: picolcd: sanity check report size in raw_event() callback

2014-08-27 Thread Bruno Prémont
Subject: [PATCH] HID: picolcd: be more verbose when reporting report size error picolcd device is not expected to send any report with size larger than 64 bytes. If this impossible event happens (sic!), print also a report ID to allow for easier debugging. Suggested-by: Bruno

Re: How write driver for gamepad, that detected by usbhid but not work correctly?

2013-09-29 Thread Bruno Prémont
On Sun, 29 September 2013 v1kt0p@gmail.com v1kt0p@gmail.com wrote: I have Genesis to USB adapter and two genesis gamepads. On windows it is work correctly. On linux do not work left and up buttons on D-pad, and two gamepads appear as one with double buttons. At first I tried to write

HID: picolcd: Prevent NULL pointer dereference on _remove()

2013-08-31 Thread Bruno Prémont
[c14696a4] hid_destroy_device+0x24/0x60 [c1474cbb] usbhid_disconnect+0x1b/0x40 ... Signed-off-by: Bruno Prémont bonb...@linux-vserver.org Cc: sta...@kernel.org --- drivers/hid/hid-picolcd_cir.c | 3 ++- drivers/hid/hid-picolcd_fb.c | 6 +- 2 files changed, 7 insertions(+), 2 deletions

Re: [PATCH] HID: fix data access in implement()

2013-07-10 Thread Bruno Prémont
Hi Jiri, Some notes regarding picoLCD part below. On Tue, 09 July 2013 Jiri Kosina jkos...@suse.cz wrote: implement() is setting bytes in LE data stream. In case the data is not aligned to 64bits, it reads past the allocated buffer. It doesn't really change any value there (it's properly

Re: [PATCH] HID: Separate struct hid_device's driver_lock into two locks.

2013-02-13 Thread Bruno Prémont
On Wed, 13 Feb 2013 21:08:20 -0800 Andrew de los Reyes wrote: /** + * hid_device_io_start - enable HID input during probe, remove + * + * @hid - the device + * + * This should only be called during probe or remove. It will allow + * incoming packets to be delivered to

Re: [PATCH] HID: Separate struct hid_device's driver_lock into two locks.

2012-11-26 Thread Bruno Prémont
Hi Andrew, [CCing David Herrmann] On Sun, 25 November 2012 Andrew de los Reyes wrote: Benjamin Tissoires and Nestor Lopez Casado have been helping me to add Linux support for new Logitech Touch Mice (T620, T400). After running into a road-block in hid-core, and solving it with this patch, we

HID: picoLCD: optimize for inactive debugfs

2012-09-30 Thread Bruno Prémont
Matthieu CASTET adjusted picolcd_debug_out_report() to only operate when there is an active listener on debugfs for events. His change got lost while splitting hid_picolcd.c, restore it. Signed-off-by: Bruno Prémont bonb...@linux-vserver.org --- diff --git a/drivers/hid/hid-picolcd_debugfs.c

Re: [PATCH] HID: picolcd_core: Remove setting hdev-claimed before calling hid_hw_start()

2012-09-17 Thread Bruno Prémont
On Fri, 14 September 2012 Axel Lin axel@gmail.com wrote: Current implementation of hid_hw_start() allows connect_mask to be 0. Setting hdev-claimed = HID_CLAIMED_INPUT before calling hid_hw_start() is not necessary. Remove it. Signed-off-by: Axel Lin axel@gmail.com Acked-By: Bruno

Re: [patch] HID: picoLCD: off by one in dump_buff_as_hex()

2012-09-17 Thread Bruno Prémont
Hi Dan, On Fri, 14 September 2012 Dan Carpenter dan.carpen...@oracle.com wrote: We're placing the NUL terminator one character beyond the end of the buffer here. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- This change obviously don't make the code worse, but I'm not positive

Re: [PATCH] HID: picolcd_fb: Use flush_delayed_work instead of flush_delayed_work_sync

2012-09-11 Thread Bruno Prémont
Hi Axel, On Wed, 12 Sep 2012 13:39:09 Axel Lin axel@gmail.com wrote: Seems this is a left over of commit 4382973 workqueue: deprecate flush[_delayed]_work_sync() It is, see https://lkml.org/lkml/2012/9/6/297 for a previous patch. This should fix itself when Linus merges Tejun's workqueue

Re: [PATCH] HID: picoLCD: Remove use of deprecated function

2012-09-06 Thread Bruno Prémont
(declared at include/linux/workqueue.h:454) [-Wdeprecated-declarations] Signed-off-by: Emil Goode emilgo...@gmail.com Acked-by: Bruno Prémont bonb...@linux-vserver.org This matches a patch by Tejun a few weeks ago which was partially skipped in -next due to merge conflict with code split

[PATCH 3/6] HID: picoLCD: Add support for CIR

2012-08-19 Thread Bruno Prémont
Implement support for picoLCD's CIR header using RC_CORE for decoding the IR event stream. Signed-off-by: Bruno Prémont bonb...@linux-vserver.org --- drivers/hid/hid-picolcd.h |5 ++- drivers/hid/hid-picolcd_cir.c | 95 +++- drivers/hid/hid

[PATCH 5/6] HID: picoLCD: fix dumping of IR_DATA report

2012-08-19 Thread Bruno Prémont
The first payload byte indicates how many IR data bytes are following, not including itself. The IR data bytes appear in pairs as they represent a series of 16bit intervals. Signed-off-by: Bruno Prémont bonb...@linux-vserver.org --- drivers/hid/hid-picolcd_debugfs.c |4 ++-- 1 files changed

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-18 Thread Bruno Prémont
On Sat, 18 August 2012 Bruno Prémont bonb...@linux-vserver.org wrote: One thing I just though about, how does usbhid handle the calls to usbhid_submit_report() when hid_hw_stop()/hid_hw_close() have already been called? I will attempt to see if it makes a difference to shortcut my

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-16 Thread Bruno Prémont
On Wed, 15 August 2012 Jiri Kosina jkos...@suse.cz wrote: On Wed, 15 Aug 2012, Bruno Prémont wrote: I see. Alan Stern has fixed a huge pile of things in this area in 3.6-rc1. I have expected all of those to actually be on theoretical problems not ever having happened in the wild

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-15 Thread Bruno Prémont
Hi Jiri, On Wed, 15 August 2012 Jiri Kosina jkos...@suse.cz wrote: On Mon, 30 Jul 2012, Bruno Prémont wrote: Hi, This series updates picoLCD driver: - split the driver functions into separate files which get included depending on Kconfig selection (implementation for CIR using

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-15 Thread Bruno Prémont
Hi Jiri, On Wed, 15 August 2012 Jiri Kosina jkos...@suse.cz wrote: I see. Alan Stern has fixed a huge pile of things in this area in 3.6-rc1. I have expected all of those to actually be on theoretical problems not ever having happened in the wild, but it might be that you are actually

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-14 Thread Bruno Prémont
Hello Tejun, [Tejun: sorry for duplicate, did hit reply instead of reply to all] On Mon, 13 Aug 2012 16:27:08 Tejun Heo t...@kernel.org wrote: On Thu, Aug 09, 2012 at 08:09:47PM +0200, Bruno Prémont wrote: As you are working on workqueues and related code, could you have a look at my usage