Re: [PATCH 2/2] HID: i2c-hid: Fill in physical device providing HID functionality

2015-09-28 Thread Daniel Martin
ame), "%s %04hX:%04hX", > client->name, hid->vendor, hid->product); > + strlcpy(hid->phys, dev_name(&client->dev), sizeof(hid->phys)); > > ret = hid_add_device(hid); > if (ret) { > -- Tested and Reviewed-by: Daniel Mar

Re: [PATCH] HID: multitouch: Add suffix for HID_DG_TOUCHPAD

2015-09-28 Thread Daniel Martin
uot;Touchpad"; > + break; > case HID_GD_SYSTEM_CONTROL: > suffix = "System Control"; > break; > -- I will drop my locally pending patch for this. ;) Reviewed-by: Daniel Martin -- To unsubscribe fr

Re: [PATCH 1/2] HID: Show I2C bus type in hid_connect()

2015-09-28 Thread Daniel Martin
On 28 September 2015 at 14:15, Mika Westerberg wrote: > For I2C HID devices output currently looks like: > > hid-multitouch ... input,hidraw0: HID v1.00 Mouse ... > > Add knowledge about I2C bus to hid_connect() so that it shows "I2C" > correctly instead of "". > > Signed-off-by: Mika Westerber

Why do we ignore constant fields?

2015-09-23 Thread Daniel Martin
Hi, why do we skip constant fields (HID_MAIN_ITEM_CONSTANT) in hid-input and hid-core? In the "Device Class Definition for Human Interface Devices" (v1.11) one can read: "Constant indicates the item is a static read-only field in a report and cannot be modified (written) by the host." (As an

Re: [PATCH] HID: multitouch: Add quirk for N-trig (1b96:1B05)

2015-09-18 Thread Daniel Martin
What's the problem with last minute fixes, which look so simple that they can't cause any harm? ... This patch is discarded! :/ -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.

[PATCH] HID: multitouch: Add quirk for N-trig (1b96:1B05)

2015-09-17 Thread Daniel Martin
02 c5 02 ff ff ff ff 00 cd 01 e7 3a 00 a6 19 a6 19 5a 05 5a 05 e2 01 29 02 ff ff ff ff 00 cd 01 e7 3b 00 bc 15 bc 15 84 09 84 09 df 01 24 02 ff ff ff ff 00 cd 01 e7 3c 00 fb 16 fb 16 4c 13 4c 13 8b 01 bd 01 ff ff ff ff 00 Next frame and we're back to normal mode/data. Signed-off-

[PATCH] Input: Fix typo in MT documentation

2015-09-17 Thread Daniel Martin
Section "Event Computation" had this: ... ABS_MT_TOOL_X := C_X ABS_MT_TOOL_X := C_Y Replace the second ABS_MT_TOOL_X with ABS_MT_TOOL_Y. Signed-off-by: Daniel Martin --- Documentation/input/multi-touch-protocol.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH] HID: Make I2C a known bus in hid_connect()

2015-09-17 Thread Daniel Martin
Just to prettify the log message. Otherwise it would be . Signed-off-by: Daniel Martin --- drivers/hid/hid-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index e6fce23..2636fac 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid

Re: Problem: Touchscreen (SP3) stops sending events

2015-09-17 Thread Daniel Martin
On 14 September 2015 at 16:37, Daniel Martin wrote: > I've retried this issue with v4.2 and it still exists. I've got it! The patch(es) should pop up soon. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord.

Problem: Touchscreen (SP3) stops sending events

2015-06-09 Thread Daniel Martin
oblem / keeps the events floating. Anyone has a clue, why we end up in such a state? Do you need more logs, which? Cheers, Daniel Martin [0.00] Linux version 3.19.6-grsec+ (be1060@ts-4) (gcc version 4.9.2 (Debian 4.9.2-10) ) #11 SMP Tue Jun 9 11:03:29 CEST 2015 [0.00] Command line:

Re: [PATCH] hid: Add secondary vendor id for the marco, USB_DEVICE_ID_MS_TYPE_COVER_3_V2

2015-06-09 Thread Daniel Martin
On 21 May 2015 at 04:40, Alan Wu wrote: > Hello Jiri, > I believe the patch may work, but I would rename the IDs. Obviously > I can't test Surface 3 non-Pro cover, but the difference is likely due > to the following: > > This is 0x07dc (I do own) > http://www.microsoftstore.com/store/msusa/en_U

Re: [PATCH] input: synaptics: min_max quirk for Thinkpad E440

2015-03-25 Thread Daniel Martin
On 25 March 2015 at 02:20, Filip Ayazi wrote: > Sets min_max_quirk values for LEN2006 touchpad found in Lenovo Thinkpad E440 > (board_id=2691). Dmitry already applied a patch for the E440: http://www.spinics.net/lists/linux-input/msg37497.html -- To unsubscribe from this list: send the line "

Re: [PATCH 8/7] Input: synaptics - Remove X250 from the topbuttonpad list

2015-02-27 Thread Daniel Martin
@@ static const char * const topbuttonpad_pnp_ids[] = { > "LEN0041", > "LEN0042", /* Yoga */ > "LEN0045", > - "LEN0046", > "LEN0047", > "LEN0049", > "LEN2000", >

[PATCH 1/5] Input: synaptics - Split synaptics_resolution(), query first

2015-02-06 Thread Daniel Martin
From: Daniel Martin Split the function synaptics_resolution() into synaptics_resolution() and synaptics_quirks(). synaptics_resolution() will be called before synaptics_quirks() to query dimensions and resolutions before overwriting them with quirks. v2: Removed SYN_ID_MAJOR() check from

[PATCH 2/5] Input: synaptics - Log queried and quirked dimension values

2015-02-06 Thread Daniel Martin
From: Daniel Martin Logging the dimension values we queried (info) and the values we use from a quirk to overwrite (warn) can be helpful for debugging. This partly relates to bug: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Signed-off-by: Daniel Martin --- drivers/input/mouse

[PATCH 3/5] Input: synaptics - Query min dimensions for fw v8.1

2015-02-06 Thread Daniel Martin
From: Daniel Martin Query the min dimensions even if the check SYN_EXT_CAP_REQUESTS(priv->capabilities) >= 7 fails, but we know that the firmware version 8.1 is safe. With that we don't need quirks for post-2013 models anymore as they expose correct min and max dimensions. v2:

[PATCH 5/5] Input: synaptics - Support min/max board id in min_max_pnpid_table

2015-02-06 Thread Daniel Martin
Add a min/max range for board ids to the min/max coordinates quirk. This makes it possible to restrict quirks to specific models based upon their board id. The define ANY_BOARD_ID (0) serves as a wildcard. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Signed-off-by: Daniel Martin

[PATCH 4/5] Input: synaptics - Remove obsolete min/max quirk for X240

2015-02-06 Thread Daniel Martin
From: Daniel Martin The firmware of the X240 (LEN0035, 2013/12) exposes the same values x [1232..5710], y [1156..4696] as the quirk applies. Signed-off-by: Daniel Martin --- drivers/input/mouse/synaptics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input

[v3] synaptics: match PNP-Id is not sufficient for min/max quirks

2015-02-06 Thread Daniel Martin
s Cheers, Daniel Martin -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 4/5] Input: synaptics - Skip quirks when post-2013 dimensions

2015-01-31 Thread Daniel Martin
te: > >>> Hi Daniel, > >>> > >>> On Tue, Jan 27, 2015 at 3:34 AM, Daniel Martin > >>> wrote: > >>>> From: Daniel Martin > >>>> > >>>> If we queried min/max dimensions of x [1266..5674], y [1170..4684] w

Re: [PATCH v2 3/5] Input: synaptics - Query min dimensions when safe firmware

2015-01-31 Thread Daniel Martin
niel, > >>> > >>>in one hand I would like to see that upstream ASAP. But on the other > >>>hand, I have some concerns here and there regarding this series. > >>> > >>>On Tue, Jan 27, 2015 at 3:34 AM, Daniel Martin > >>> wrote:

[v2] synaptics: match PNP-Id is not sufficient for min/max quirks

2015-01-27 Thread Daniel Martin
Hi, this is the second version of my patches to address the problems described at: https://bugzilla.kernel.org/show_bug.cgi?id=91541 I have incorporated changes according to Hans comments. That means I removed the patch Input: synaptics - Add PnP id for X1 Carbon 1nd as the PnP id doesn't

[PATCH v2 3/5] Input: synaptics - Query min dimensions when safe firmware

2015-01-27 Thread Daniel Martin
From: Daniel Martin Query the min dimensions even if the check SYN_EXT_CAP_REQUESTS(priv->capabilities) >= 7 fails, but we know that the firmware version is safe. Atm. this is version 8.1 only. With that we don't need quirks for post-2013 models anymore as they expose correct

[PATCH v2 1/5] Input: synaptics - Split synaptics_resolution(), query first

2015-01-27 Thread Daniel Martin
From: Daniel Martin Split the function synaptics_resolution() into synaptics_resolution() and synaptics_quirks(). synaptics_resolution() will be called before synaptics_quirks() to query dimensions and resolutions before overwriting them with quirks. v2: Removed SYN_ID_MAJOR() check from

[PATCH v2 5/5] Input: synaptics - Remove obsolete min/max quirk for X240

2015-01-27 Thread Daniel Martin
From: Daniel Martin The firmware of the X240 (LEN0035, 2013/12) exposes the same values x [1232..5710], y [1156..4696] as the quirk applies. Signed-off-by: Daniel Martin --- drivers/input/mouse/synaptics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input

[PATCH v2 4/5] Input: synaptics - Skip quirks when post-2013 dimensions

2015-01-27 Thread Daniel Martin
From: Daniel Martin If we queried min/max dimensions of x [1266..5674], y [1170..4684] we have post-2013 model and don't need to apply any quirk. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Signed-off-by: Daniel Martin --- drivers/input/mouse/synaptics.c | 5 + 1

[PATCH v2 2/5] Input: synaptics - Log queried and quirked dimension values

2015-01-27 Thread Daniel Martin
From: Daniel Martin Logging the dimension values we queried (info) and the values we use from a quirk to overwrite (warn) can be helpful for debugging. This partly relates to bug: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Signed-off-by: Daniel Martin --- drivers/input/mouse

Re: [PATCH 5/6] Input: synaptics - Add PnP id for X1 Carbon 1nd

2015-01-23 Thread Daniel Martin
Withdrawn! On 22 January 2015 at 17:46, Daniel Martin wrote: > From: Daniel Martin > > This adds the PnP id (LEN0030) for the X1 Carbon 1nd (2013/07) to the > list of known PnP ids. > > The firmware exposes the correct dimensions: > x [1264..5678], y [1124..4732]. >

Re: [PATCH 5/6] Input: synaptics - Add PnP id for X1 Carbon 1nd

2015-01-23 Thread Daniel Martin
On 22 January 2015 at 17:46, Daniel Martin wrote: > From: Daniel Martin > > This adds the PnP id (LEN0030) for the X1 Carbon 1nd (2013/07) to the > list of known PnP ids. > > The firmware exposes the correct dimensions: > x [1264..5678], y [1124..4732]. > > S

[PATCH 1/6] Input: synaptics - Split synaptics_resolution(), query first

2015-01-22 Thread Daniel Martin
From: Daniel Martin Split the function synaptics_resolution() into synaptics_resolution() and synaptics_quirks(). synaptics_resolution() will be called before synaptics_quirks() to query dimensions and resolutions before overwriting them with quirks. Signed-off-by: Daniel Martin

synaptics: match PNP-Id is not sufficient for min/max quirks

2015-01-22 Thread Daniel Martin
), Helix (2013?) and X1 Carbon (2013, LEN0030). Any comments are welcome, Daniel Martin -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 6/6] Input: synaptics - Remove obsolete min/max quirk for X240

2015-01-22 Thread Daniel Martin
From: Daniel Martin The firmware of the X240 (LEN0035, 2013/12) exposes the same values x [1232..5710], y [1156..4696] as the quirk applies. Signed-off-by: Daniel Martin --- drivers/input/mouse/synaptics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input

[PATCH 2/6] Input: synaptics - Log queried and quirked dimension values

2015-01-22 Thread Daniel Martin
From: Daniel Martin Logging the dimension values we queried (info) and the values we use from a quirk to overwrite (warn) can be helpful for debugging. This partly relates to bug: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Signed-off-by: Daniel Martin --- drivers/input/mouse

[PATCH 5/6] Input: synaptics - Add PnP id for X1 Carbon 1nd

2015-01-22 Thread Daniel Martin
From: Daniel Martin This adds the PnP id (LEN0030) for the X1 Carbon 1nd (2013/07) to the list of known PnP ids. The firmware exposes the correct dimensions: x [1264..5678], y [1124..4732]. Signed-off-by: Daniel Martin --- drivers/input/mouse/synaptics.c | 1 + 1 file changed, 1

[PATCH 4/6] Input: synaptics - Skip quirks when post-2013 dimensions

2015-01-22 Thread Daniel Martin
From: Daniel Martin If we queried min/max dimensions of x [1266..5674], y [1170..4684] we have post-2013 model and don't need to apply any quirk. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Signed-off-by: Daniel Martin --- drivers/input/mouse/synaptics.c | 5 + 1

[PATCH 3/6] Input: synaptics - Query min dimensions when safe firmware

2015-01-22 Thread Daniel Martin
From: Daniel Martin Query the min dimensions even if the check SYN_EXT_CAP_REQUESTS(priv->capabilities) >= 7 fails, but we know that the firmware version is safe. Atm. this is version 8.1 only. With that we don't need quirks for post-2013 models anymore as they expose correct