Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-05-30 Thread David Daney
("gpio: removing gpiochip with gpios still requested\n"); panic? NACK to the patch for this reason. The strongest thing you should do here is WARN. That said, I am not sure why we need this whole patch set in the first place. David Daney Is this likely to happen? Gr{o

Re: [PATCH] gpio: removes all usage of gpiochip_remove retval

2014-05-29 Thread David Daney
On 05/29/2014 02:54 PM, abdoulaye berthe wrote: Did you forget a changelog explaining why this is either needed, or even a good idea? I joined the conversation late and don't know why you are doing this. Thanks, David Daney Signed-off-by: abdoulaye berthe --- arch/arm/common/sc

Re: Why Cypress does not upstream its trackpad driver?

2012-11-07 Thread David Daney
What benefit do you enjoy by keeping the code out of the upstream kernel? 2) What are the benefits of having a driver for your hardware in the upstream kernel? If 2 > 1, then the course of action seems obvious. Doing nothing because of some perceived impediment doesn't help anybody.