Re: [PATCH] HID: input: fix confusion on conflicting mappings

2015-01-08 Thread Fredrik Hallenberg
Jiri, I suppose you can close bugzilla bug 70181? On Thu, Jan 8, 2015 at 6:50 AM, Christopher Head ch...@chead.ca wrote: On Tue, 6 Jan 2015 13:37:26 +0100 Fredrik Hallenberg megahal...@gmail.com wrote: ... if (!(field-flags (HID_MAIN_ITEM_RELATIVE

Re: [PATCH] HID: input: fix confusion on conflicting mappings

2015-01-06 Thread Fredrik Hallenberg
I can confirm that the patch breaks things when not using n key rollover. If using the Corsair K70 in BIOS mode or just using a plain USB-keyboard keys repeat forever as reported. David, I noticed that in the first version of your patch, where the ignore check was done in hid-core.c, you only

Re: [PATCH] HID: input: fix confusion on conflicting mappings

2014-12-29 Thread Fredrik Hallenberg
that didn't change. This patch is tagged for 'stable' as it fixes a lot of n-key RollOver hardware. We might wanna wait with backporting for a while, before we know it doesn't break anything else, though. Cc: sta...@vger.kernel.org Reported-by: Adam Goode a...@spicenitz.org Reported-by: Fredrik

Re: [PATCH] Handle spurious backslash key repeats on some keyboards

2014-12-20 Thread Fredrik Hallenberg
Did you already find someone with a US keyboard? Yes as mentioned in thread it does not seem possible to write a hwdb-rule that works for both US and non-US keyboard. Also it is a general problem that affects other keyboards than Corsair, again see previous mails in this thread. David, it would

Re: Problem with Das Keyboard 4 in N-key rollover mode

2014-10-16 Thread Fredrik Hallenberg
Hi, this issue was discussed on this list a while ago. Look for spurious backslash in the archive. I submitted a patch that fixed the problem but David Herrmann did a better one later in the thread. However the patch was not applied. David, are there remaining issues with your patch? On Thu, Oct

Re: [PATCH] Handle spurious backslash key repeats on some keyboards

2014-09-15 Thread Fredrik Hallenberg
FYI I just got a lsusb -v dump from a US version of my keyboard, and it is exactly the same as the one from my nordic version. On Mon, Sep 15, 2014 at 12:53 AM, Fredrik Hallenberg megahal...@gmail.com wrote: Thank you for this, I felt that it would be difficult to do a good solution with hwdb

Re: [PATCH] Handle spurious backslash key repeats on some keyboards

2014-09-14 Thread Fredrik Hallenberg
dh.herrm...@gmail.com wrote: Hi On Sun, Aug 10, 2014 at 11:56 AM, Fredrik Hallenberg megahal...@gmail.com wrote: Here is my attempt on a fix for bug 70181, please review it. It is tested on my nordic Corsair K70, if this solution is deemed acceptable I can ask some people with other problematic

Re: [PATCH] Handle spurious backslash key repeats on some keyboards

2014-09-12 Thread Fredrik Hallenberg
On Thu, Sep 11, 2014 at 10:35 PM, Fredrik Hallenberg megahal...@gmail.com wrote: Thanks I had no idea about the hwdb but I have tried it now, it works if I use KEYBOARD_KEY_70031=reserved Thanks for confirming! on my nordic keyboard, but a US keyboard user would have to use scancode 70032

Re: [PATCH] Handle spurious backslash key repeats on some keyboards

2014-09-12 Thread Fredrik Hallenberg
say there could be some other value that could be used, I will try to find someone with a US-version of this keyboard and compare the values. On Fri, Sep 12, 2014 at 1:47 PM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Fri, Sep 12, 2014 at 1:34 PM, Fredrik Hallenberg megahal...@gmail.com

Re: [PATCH] Handle spurious backslash key repeats on some keyboards

2014-09-11 Thread Fredrik Hallenberg
The nicest fix, obviously, is to blacklist keys that are not physically present on the keyboard. But I assume the keyboard reports Hmm, somebody could still load keymap with duplicate keycodes though... The HID mapping is hardcoded, so only key code 43 will have this problem regardless of

Re: [PATCH] Handle spurious backslash key repeats on some keyboards

2014-09-11 Thread Fredrik Hallenberg
. On Thu, Sep 11, 2014 at 2:41 PM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Thu, Sep 11, 2014 at 10:50 AM, Fredrik Hallenberg megahal...@gmail.com wrote: The nicest fix, obviously, is to blacklist keys that are not physically present on the keyboard. But I assume the keyboard reports

Re: [PATCH] Handle spurious backslash key repeats on some keyboards

2014-09-10 Thread Fredrik Hallenberg
: On Tue, 9 Sep 2014, Fredrik Hallenberg wrote: Hi, time for a bump on this one. On Sun, Aug 10, 2014 at 11:56 AM, Fredrik Hallenberg megahal...@gmail.com wrote: Here is my attempt on a fix for bug 70181, please review it. It is tested on my nordic Corsair K70, if this solution is deemed

Re: [PATCH] Handle spurious backslash key repeats on some keyboards

2014-09-09 Thread Fredrik Hallenberg
Hi, time for a bump on this one. On Sun, Aug 10, 2014 at 11:56 AM, Fredrik Hallenberg megahal...@gmail.com wrote: Here is my attempt on a fix for bug 70181, please review it. It is tested on my nordic Corsair K70, if this solution is deemed acceptable I can ask some people with other

Re: [PATCH] Handle spurious backslash key repeats on some keyboards

2014-09-09 Thread Fredrik Hallenberg
to a single Linux key code. On Tue, Sep 9, 2014 at 11:42 AM, Jiri Kosina jkos...@suse.cz wrote: On Tue, 9 Sep 2014, Fredrik Hallenberg wrote: Hi, time for a bump on this one. Do you have any idea how common this pattern is? How many keyboards have you encountered doing this? I hate

Backslash repeat bug

2014-08-08 Thread Fredrik Hallenberg
Hi, On my Corsair K70 keyboard, when pressing some key and then the backslash key (KEY_BACKSLASH) in rapid succession the backslash character will be repeated three times. This bug has been mentioned on this list before (by Norbert Veber on the 24th of februrary) but there was no responses, also

Re: Backslash repeat bug

2014-08-08 Thread Fredrik Hallenberg
I just found bugzilla bug #70181 which is the same problem as I describe but seen with a QPAD MK-85 keyboard. I will add my findings to that bug. On Fri, Aug 8, 2014 at 4:11 PM, Fredrik Hallenberg megahal...@gmail.com wrote: Hi, On my Corsair K70 keyboard, when pressing some key