Hi Sudip,
On Mon, Nov 9, 2015 at 2:05 PM, Sudip Mukherjee
wrote:
> On Sat, Nov 07, 2015 at 04:53:23PM +0100, Geert Uytterhoeven wrote:
>> WARNING: vmlinux.o(.text+0x1056606): Section mismatch in reference from the
>> function parkbd_attach() to the function .init.text:parkbd
b97cbb676d ("Input: parkbd - use parallel port device model")
Signed-off-by: Geert Uytterhoeven
---
drivers/input/serio/parkbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/serio/parkbd.c b/drivers/input/serio/parkbd.c
index 74bb17270255439c..92c31b8f8
on, Jul 06, 2015 at 04:29:33PM +0300, Laurent Pinchart wrote:
>> > > > On Monday 06 July 2015 12:55:32 Geert Uytterhoeven wrote:
>> > > > > Replace the deprecated generic "adi,adxl34x" compatible value by the
>> > > > > adxl345-specific &q
.
Signed-off-by: Geert Uytterhoeven
Acked-by: Linus Walleij
---
v2:
- Add Acked-by.
---
drivers/input/keyboard/Kconfig| 4 ++--
drivers/input/misc/Kconfig| 11 ++-
drivers/input/mouse/Kconfig | 2 +-
drivers/input/touchscreen/Kconfig | 8
4 files changed, 13
force_read_packet’:
drivers/input/touchscreen/zforce_ts.c:432: warning: comparison is
always false due to limited range of data type
After:
drivers/input/touchscreen/zforce_ts.c: In function ‘zforce_read_packet’:
drivers/input/touchscreen/zforce_ts.c:434: warning: comparison is
always false due t
TC *driver* in the DA9062 MFD driver core".
Ah, I read "core" as in "hardware IP core".
And as the full patch description for [1/3] doesn't say "da9063" elsewhere,
I thought it was a typo.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterh
the DA9062 RTC.
[...]
> S Twiss (3):
> mfd: da9062: Support for the DA9063 RTC in the DA9062 core
"DA9062 RTC"?
> rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver
> devicetree: da9062: Add device tree bindings for DA9062 RTC
Gr{oetje,eeting}s,
Replace the deprecated generic "adi,adxl34x" compatible value by the
adxl345-specific "adi,adxl345" value, cfr. commit e465bf6fc55d5ce2 ("DT:
i2c: Deprecate adi,adxl34x compatible string").
Signed-off-by: Geert Uytterhoeven
---
Depends on commit 3a38958d2477b718 (
di,adxl34x";
>> + compatible = "adi,adxl345", "adi,adxl34x";
>
> "adi,adxl34x" is deprecated and shouldn't be used in DT. You can just specify
> "adi,adxl345".
Right, we only care (sometimes ;-) about backward-compatibi
The accelerometer node used the generic compatible property only.
Add the device-specific one, to make it future proof.
Signed-off-by: Geert Uytterhoeven
---
Depends on commit 3a38958d2477b718 ("Input: adxl34x - add OF match
support"), which is in v4.2-rc1.
---
arch/arm/boot/
Hi Dmitry,
On Sat, May 23, 2015 at 1:32 AM, Dmitry Torokhov
wrote:
> On Thu, May 21, 2015 at 01:42:24PM +0200, Geert Uytterhoeven wrote:
>> This is a resent of a series by Laurent Pinchart to fix OF matching for
>> the adxl34x driver.
> Applied and sorry for the delay.
Thank
Sang
Signed-off-by: Geert Uytterhoeven
---
v2:
- Add Acked-by.
Documentation/devicetree/bindings/i2c/trivial-devices.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
b/Documentation/devicetree/bindings/i2c
/trivial-devices.txt | 3 +--
drivers/input/misc/adxl34x-i2c.c| 21 +
2 files changed, 22 insertions(+), 2 deletions(-)
--
1.9.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of L
XL346 is
backward-compatible with the ADXL345 with differences handled by runtime
detection of the device model.
Signed-off-by: Laurent Pinchart
Reviewed-by: Wolfram Sang
Signed-off-by: Geert Uytterhoeven
---
v2:
- Add Reviewed-by.
drivers/input/misc/adxl34x-i2c.c | 21 +
1
INX selects VIDEOBUF2_DMA_CONTIG, which bypasses its dependency
on HAS_DMA. Make VIDEO_XILINX depend on HAS_DMA to fix this.
Signed-off-by: Geert Uytterhoeven
---
drivers/media/platform/xilinx/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform
DMA_SG without depending on HAS_DMA, as
Kconfig will give a warning.
Signed-off-by: Geert Uytterhoeven
---
drivers/media/v4l2-core/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/Kconfig b/drivers/media/v4l2-core/Kconfig
index ba7e21a73023
G, which bypasses its
dependency on HAS_DMA. Make TOUCHSCREEN_SUR40 depend on HAS_DMA to fix
this.
Signed-off-by: Geert Uytterhoeven
---
drivers/input/touchscreen/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/Kconfig
b/drivers/input/touchscre
e.
Kzm9g uses gpio-keys with a PCF8575 i2c GPIO expander, cfr.
arch/arm/boot/dts/sh73a0-kzm9g.dts. It doesn't use regmap, though.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversat
.. else if ..." is used in other places, remove the
superfluous "if" to silence the compiler warning.
Signed-off-by: Geert Uytterhoeven
---
Alternatively, we can pre-initialize max_element_cnt and offset to zero,
and add "if (!max_element_cnt) goto out;" before the loop.
d
ame = "bfin-rotary",
>
> You missed
>.owner = THIS_MODULE,
> here.
That line was removed in v3.19-rc1 by commit 776bd315a7721574
("input: misc: drop owner assignment from platform_drivers").
Gr{oetje,eeting}s,
Geert
--
The patch "module: fix types of device tables aliases" newly requires
that invocations of
MODULE_DEVICE_TABLE(type, name);
come *after* the definition of `name'. That is reasonable, but gscps2
wasn't doing this. Fix it.
Signed-off-by: Geert Uytterhoeven
---
One more fix
From: Michael Karcher
Signed-off-by: Michael Karcher
Acked-by: Thorsten Glaser
Tested-by: Stefan Niestegge
Signed-off-by: Geert Uytterhoeven
---
drivers/input/keyboard/atakbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/atakbd.c b/drivers
t; the problem that we are solving here?
Because there's no guarantee that the driver actually supports all
"adi,adxl34" with = 0..9, some of which don't exist yet.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux b
On Thu, Jan 15, 2015 at 6:43 PM, Wolfram Sang wrote:
> On Thu, Jan 15, 2015 at 06:32:31PM +0100, Geert Uytterhoeven wrote:
>> On Thu, Jan 15, 2015 at 6:02 PM, Wolfram Sang wrote:
>> >> --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
>> >> +++ b/
.
>
> Signed-off-by: Laurent Pinchart
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker.
ry. There's no need to add the "adi,adxl346" entry as the ADXL346 is
> backward-compatible with the ADXL345 with differences handled by runtime
> detection of the device model.
Thanks!
> Signed-off-by: Laurent Pinchart
Acked-by: Geert Uytterhoeven
> --- a/drivers/in
op adi,adxl346, checkpatch will start complaining if it encounters
it in a .dts.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a h
ch-bf548/boards/ezkit.c
arch/blackfin/mach-bf609/boards/ezkit.c
The shmobile variants are all adxl345.
The tll6527m is also an adxl345.
For the remaining, it's not clear to me. I Googled a bit, but no luck.
So they'll have to live with adxl345, too ;-)
>> 2) also add "34x
1) add specific compatible values to the driver. We do those updates for
> new devices all the time
> 2) also add "34x" as a compatible but mark it as deprecateed
> 3) delete "34x" from trivial devices
>
> Everyone OK with that?
Sounds fine to me. Thanks!
Gr{oe
On Fri, Aug 29, 2014 at 6:14 PM, Geert Uytterhoeven
wrote:
> If CONFIG_VT=n:
>
> arch/m68k/atari/built-in.o: In function `atari_keyboard_interrupt':
> atakeyb.c:(.text+0x1846): undefined reference to `keyboard_tasklet'
> atakeyb.c:(.text+0x1852): undefined reference to
Hi Michael,
On Sun, Aug 31, 2014 at 11:16 AM, Geert Uytterhoeven
wrote:
> On Sun, Aug 31, 2014 at 11:07 AM, Michael Schmitz
> wrote:
>>> If CONFIG_VT=n:
>>>
>>> arch/m68k/atari/built-in.o: In function `atari_keyboard_interrupt':
>>> a
On Thu, Jan 8, 2015 at 6:40 PM, Walter Lozano
wrote:
> On Wed, Jan 7, 2015 at 6:42 AM, Geert Uytterhoeven
> wrote:
>> On Wed, Jan 7, 2015 at 3:58 AM, Walter Lozano
>> wrote:
>>> diff --git a/Documentation/devicetree/bindings/input/adxl34x.txt
>>> b/Doc
;adxl34x"
"adi,adxl34x"?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer&
Hi Laurent, Wolfram,
On Thu, Dec 18, 2014 at 8:23 PM, Laurent Pinchart
wrote:
> On Thursday 18 December 2014 14:03:18 Geert Uytterhoeven wrote:
>> On Thu, Dec 18, 2014 at 1:49 PM, Laurent Pinchart wrote:
>> > There are three compatible strings defined for the ADXL
Signed-off-by: Geert Uytterhoeven
---
drivers/hid/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 230b6f887cd86e9b..303b295a5413d39b 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -388,7 +388,7 @@ config
atible string.
FWIW, I'm the evil person who added the adxl entries to that file...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hack
Hi Dmitry,
On Wed, Dec 3, 2014 at 11:59 PM, Dmitry Torokhov
wrote:
> On Sun, Nov 30, 2014 at 10:30:20AM +0100, Geert Uytterhoeven wrote:
>> Allocate the temporary buffer needed for initialization of the console
>> keyboard maps (512 bytes, as NR_KEYS = 256) on the stack instead o
board maps
into amikbd_init_console_keymaps(), protected by #ifdef
CONFIG_HW_CONSOLE.
Signed-off-by: Geert Uytterhoeven
---
Discovered during randconfig builds.
v2:
- No changes
---
drivers/input/keyboard/amikbd.c | 46 ++---
1 file changed, 29 insertions(+), 17 deletions
temp_map 512 --512
Signed-off-by: Geert Uytterhoeven
---
v2:
- Allocate temp_map[] on the stack instead of using kmalloc().
---
drivers/input/keyboard/amikbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard
358 370 +12
vermagic 63 57 -6
temp_map 512 --512
Signed-off-by: Geert Uytterhoeven
---
drivers/input/keyboard/amikbd.c | 14 +++---
1 file changed, 11 insertions(+), 3
board maps
into amikbd_init_console_keymaps(), protected by #ifdef
CONFIG_HW_CONSOLE.
Signed-off-by: Geert Uytterhoeven
---
Discovered during randconfig builds.
---
drivers/input/keyboard/amikbd.c | 46 ++---
1 file changed, 29 insertions(+), 17 deletions(-)
diff --git
This allows checkpatch to validate more DTSes.
Signed-off-by: Geert Uytterhoeven
---
Documentation/devicetree/bindings/i2c/trivial-devices.txt | 5 +
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
b/Documentation/devicetree/bindings
This allows checkpatch to validate more DTSes.
Signed-off-by: Geert Uytterhoeven
---
Documentation/devicetree/bindings/i2c/trivial-devices.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
b/Documentation/devicetree/bindings
keyboard there I should find no
> different),
Keyboard was still working on ARAnyM.
But AFAICU, the keyboard_tasklet is used for the LED state only.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In p
d, as I
believe it's handled by drivers/tty/vt/keyboard.c based on events
received from the input subsystem. So just remove it.
Signed-off-by: Geert Uytterhoeven
---
Not tested on real hardware. ARAnyM doesn't have keyboard LEDs.
arch/m68k/atari/atakeyb.c | 1 -
1 file changed, 1 delet
m TSCs are stable when switching CPU
> frequency. Earlier systems had bunch of issues there IIRC.
>From the success stories above, it seems gameport doesn't work on only
a limited number of systems.
Perhaps the subsystem can fail with a big fat warning at runtime if such
a system is detect
d. The m68k and mips world does include a department of relics and
> retro-computing 8)
It seems there are no m68k-specific drivers with gameport support...
Good, let's kill all joystick ports that are newer than ports with 2600-style
connectors ;-)
Gr{oetje,eeting}s,
If CONFIG_PM is not set:
drivers/hid/wacom_sys.c:1436: warning: ‘wacom_reset_resume’ defined but
not used
Protect the unused functions by #ifdef CONFIG_PM to fix this.
Signed-off-by: Geert Uytterhoeven
---
drivers/hid/wacom_sys.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers
ll casts, except in header
files...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say &
If CONFIG_PM_SLEEP=n:
drivers/input/keyboard/st-keyscan.c:219: warning: ‘keyscan_suspend’ defined but
not used
drivers/input/keyboard/st-keyscan.c:236: warning: ‘keyscan_resume’ defined but
not used
Signed-off-by: Geert Uytterhoeven
---
drivers/input/keyboard/st-keyscan.c | 2 ++
1 file
If CONFIG_PM=n:
drivers/hid/hid-rmi.c:432: warning: ‘rmi_post_reset’ defined but not used
drivers/hid/hid-rmi.c:437: warning: ‘rmi_post_resume’ defined but not used
Signed-off-by: Geert Uytterhoeven
---
drivers/hid/hid-rmi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hid/hid
f (test_bit(FLAG_REQUESTED, &chip->desc[id].flags))
> + panic("gpio: removing gpiochip with gpios still
> requested\n");
panic?
Is this likely to happen?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's
From: Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven
---
drivers/input/mouse/logips2pp.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/logips2pp.c b/drivers/input/mouse/logips2pp.c
index 84de2fc6acc1..136e222e2a16 100644
--- a/drivers/input
dropping the "!X86" too?
Because the "if EXPERT" only mattered for X86.
Apply De Morgan and it read like "do not ask the question if !EXPERT && X86".
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux bey
HAS_DMA) ||
(!bus->controller->dma_mask &&
!(hcd->driver->flags & HCD_LOCAL_MEM))) {
*dma = ~(dma_addr_t) 0;
return kmalloc(size, mem_flags);
}
Thanks for your clarification!
Gr{oetje,eeting}s,
ependently of DMA support.
However, having the link errors helps when annotating the Kconfig files
with HAS_DMA dependencies.
Unfortunately the check for "hcd->self.uses_dma" (which boils down to
"dev->dma_mask != NULL") isn't sufficient to cause breakage at compilation
tim
f "depends on HAS_DMA", make
those drivers depend on USB, instead of depending on USB_ARCH_HAS_HCD and
selecting USB. Drivers for other busses (e.g. MOUSE_SYNAPTICS_I2C) already
handle this in a similar way.
Signed-off-by: Geert Uytterhoeven
---
drivers/input/joystick/Kconfig|
> + else
> + wr_buf[0] = op;
Can the if-clause and the first branch just be removed, or is there a real bug
involved (e.g. wrong type for "reg")?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
(), cyttsp4_core_wake(), and cyttsp4_core_wake_()
(which is called from cyttsp4_core_wake() only) inside the existing section
protected by #if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM_RUNTIME)
Signed-off-by: Geert Uytterhoeven
---
drivers/input/touchscreen/cyttsp4_core.c | 200
On Tue, Jun 18, 2013 at 1:16 AM, Samuel Ortiz wrote:
> On Tue, May 14, 2013 at 11:42:48PM -0700, Dmitry Torokhov wrote:
>> On Wed, May 08, 2013 at 09:25:56PM -0600, Simon Glass wrote:
>> > On Wed, May 8, 2013 at 3:45 PM, Geert Uytterhoeven
>> > wrote:
>>
If CONFIG_PM_SLEEP is not set:
drivers/input/keyboard/cros_ec_keyb.c:211: warning:
‘cros_ec_keyb_clear_keyboard’ defined but not used
Move the definition of cros_ec_keyb_clear_keyboard() inside the section
protected by #ifdef CONFIG_PM_SLEEP to fix this.
Signed-off-by: Geert Uytterhoeven
we may have drivers that (now) work perfectly fine with
module_platform_driver_probe()/platform_driver_probe(), but will start
failing suddenly in the future?
I guess we need a big fat WARN_ON(-EPROBE_DEFER) in
platform_driver_probe() to catch these?
Gr{oetje,eeting}s,
On Mon, Nov 12, 2012 at 1:35 PM, Jiri Slaby wrote:
> On 11/12/2012 01:30 PM, Geert Uytterhoeven wrote:
>> My comment was purely cosmetic, as it applies to the quoted compiler error
>> messages only.
>
> Ah, I see. When you are applying the patch Jiri, could you remove errors
On Mon, Nov 12, 2012 at 1:15 PM, Jiri Kosina wrote:
> On Mon, 12 Nov 2012, Geert Uytterhoeven wrote:
>> On Mon, Nov 12, 2012 at 10:16 AM, Jiri Slaby wrote:
>> > In patch "HID: microsoft: fix invalid rdesc for 3k kbd" I fixed
>> > support for MS 3k keyboards.
where was not indirectly included.
> On x86_64, memcmp is a function, so I did not see the error.
>
> Signed-off-by: Jiri Slaby
> Reported-by: Geert Uytterhoeven
> ---
> drivers/hid/hid-microsoft.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --
On Sun, Nov 4, 2012 at 11:37 PM, Jiri Slaby wrote:
> On 11/04/2012 10:06 PM, Geert Uytterhoeven wrote:
>> On Fri, Oct 19, 2012 at 1:28 PM, Jiri Slaby wrote:
>>> + if ((quirks & MS_RDESC_3K) && *rsize == 106 &&
>>> +
Hi Jiri,
On Sun, Nov 4, 2012 at 11:37 PM, Jiri Slaby wrote:
> On 11/04/2012 10:06 PM, Geert Uytterhoeven wrote:
>> On Fri, Oct 19, 2012 at 1:28 PM, Jiri Slaby wrote:
>>> + if ((quirks & MS_RDESC_3K) && *rsize == 106 &&
>>> +
{
return memcmp((char []){ 0x19, 0x00, 0x29, 0xff }, &rdesc[94], 4);
}
---snip---
it also fails with gcc-3.4/4.1/4.2/4.3/4.4 of Ubuntu 10.04 on amd64.
Interestingly, it doesn't fail if I remove the #define for memcmp. So it seems
to work if memcmp() is a real function, not a #define.
Gr
On Sun, Sep 2, 2012 at 11:21 AM, Geert Uytterhoeven
wrote:
> JFYI, when comparing v3.6-rc4 to v3.6-rc3[3], the summaries are:
> - build errors: +6/-13
6 regressions:
+ drivers/input/touchscreen/edt-ft5x06.c: error: 'struct
edt_ft5x06_ts_data' has no member named 'ra
-picolcd_debugfs.c:112: error: implicit declaration of function
‘copy_to_user’
Signed-off-by: Geert Uytterhoeven
---
http://kisskb.ellerman.id.au/kisskb/buildresult/6990818/
drivers/hid/hid-picolcd_debugfs.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/hid
70 matches
Mail list logo
