Re: [PATCHv9 14/15] cec: s5p-cec: Add s5p-cec driver

2015-10-12 Thread Kamil Debski
Hi, On 12 October 2015 at 14:39, Hans Verkuil wrote: > On 10/12/2015 02:33 PM, Kamil Debski wrote: >> Hi, >> >> On 12 October 2015 at 12:50, Hans Verkuil wrote: >>> On 10/06/2015 12:32 AM, Russell King - ARM Linux wrote: >>>> On Mon, Sep 07, 20

Re: [PATCHv9 14/15] cec: s5p-cec: Add s5p-cec driver

2015-10-12 Thread Kamil Debski
Hi, On 12 October 2015 at 12:50, Hans Verkuil wrote: > On 10/06/2015 12:32 AM, Russell King - ARM Linux wrote: >> On Mon, Sep 07, 2015 at 03:44:43PM +0200, Hans Verkuil wrote: >>> +if (status & CEC_STATUS_TX_DONE) { >>> +if (status & CEC_STATUS_TX_ERROR) { >>> +

Re: [PATCHv7 14/15] cec: s5p-cec: Add s5p-cec driver

2015-07-23 Thread Kamil Debski
Hi, On 21 July 2015 at 15:03, Marek Szyprowski wrote: > Hello, > > On 2015-07-16 15:09, Hans Verkuil wrote: >> >> Marek, Kamil, >> >> On 06/29/15 12:14, Hans Verkuil wrote: >>> >>> From: Kamil Debski >>> >>> Add CEC interfac

[PATCH v5 11/11] DocBook/media: add CEC documentation

2015-04-29 Thread Kamil Debski
From: Hans Verkuil Add DocBook documentation for the CEC API. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: add documentation for passthrough mode] [k.deb...@samsung.com: minor fixes and change of reserved field sizes] Signed-off-by: Kamil Debski --- Documentation/DocBook/media/Makefile

[PATCH] libgencec: Add userspace library for the generic CEC kernel interface

2015-04-29 Thread Kamil Debski
create mode 100644 m4/.gitkeep create mode 100644 src/Makefile.am create mode 100644 src/gencec.c diff --git a/AUTHORS b/AUTHORS new file mode 100644 index 000..e4b7117 --- /dev/null +++ b/AUTHORS @@ -0,0 +1 @@ +Kamil Debski diff --git a/INSTALL b/INSTALL new file mode 100644 index 000

[PATCH v5 06/11] cec: add HDMI CEC framework

2015-04-29 Thread Kamil Debski
, with minor additions] Signed-off-by: Kamil Debski --- Documentation/cec.txt | 396 +++ drivers/media/Kconfig |6 + drivers/media/Makefile|2 + drivers/media/cec.c | 1200 + include/media/cec.h | 142

[PATCH v5 07/11] v4l2-subdev: add HDMI CEC ops

2015-04-29 Thread Kamil Debski
From: Hans Verkuil Add callbacks to the v4l2_subdev_video_ops. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski --- include/media/v4l2-subdev.h |8 1 file changed, 8 insertions(+) diff --git a

[PATCH v5 03/11] dts: exynos4412-odroid*: enable the HDMI CEC device

2015-04-29 Thread Kamil Debski
Add a dts node entry and enable the HDMI CEC device present in the Exynos4 family of SoCs. Signed-off-by: Kamil Debski --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot

RE: [PATCH v4 06/10] cec: add HDMI CEC framework

2015-04-27 Thread Kamil Debski
ans Verkuil wrote: > > On 04/23/2015 03:03 PM, Kamil Debski wrote: > >> From: Hans Verkuil > >> > >> The added HDMI CEC framework provides a generic kernel interface for > >> HDMI CEC devices. > >> > >> Signed-off-by: Hans Verkuil

RE: [PATCH v4 06/10] cec: add HDMI CEC framework

2015-04-27 Thread Kamil Debski
horugh" mode in which handling of CEC messages by the kernel CEC framework will be very limited. I think that the three functions listed above should be enough. Any comments on this solution? > > thanks, > > Lars Op den Kamp Best wishes, -- Kamil Debski Samsung R&D I

[PATCH v4 08/10] cec: adv7604: add cec support.

2015-04-23 Thread Kamil Debski
functions] Signed-off-by: Kamil Debski --- drivers/media/i2c/adv7604.c | 207 ++- 1 file changed, 206 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c index 60ffcf0..4921276 100644 --- a/drivers/media/i2c/adv7604

[PATCH v4 04/10] HID: add HDMI CEC specific keycodes

2015-04-23 Thread Kamil Debski
Add HDMI CEC specific keycodes to the keycodes definition. Signed-off-by: Kamil Debski --- include/uapi/linux/input.h | 12 1 file changed, 12 insertions(+) diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h index 731417c..7430a3f 100644 --- a/include/uapi

[PATCH v4 06/10] cec: add HDMI CEC framework

2015-04-23 Thread Kamil Debski
problem] [k.deb...@samsung.com: add cec.h to include/uapi/linux/Kbuild] Signed-off-by: Kamil Debski --- Documentation/cec.txt | 396 drivers/media/Kconfig |6 + drivers/media/Makefile|2 + drivers/media/cec.c | 1161

[PATCH v4 05/10] rc: Add HDMI CEC protoctol handling

2015-04-23 Thread Kamil Debski
Add handling of remote control events coming from the HDMI CEC bus. This patch includes a new keymap that maps values found in the CEC messages to the keys pressed and released. Also, a new protocol has been added to the core. Signed-off-by: Kamil Debski --- drivers/media/rc/keymaps/Makefile

[PATCH v4 09/10] cec: adv7511: add cec support.

2015-04-23 Thread Kamil Debski
From: Hans Verkuil Add CEC support to the adv7511 driver. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski --- drivers/media/i2c/adv7511.c | 347 ++- include/media

[PATCH v4 07/10] v4l2-subdev: add HDMI CEC ops

2015-04-23 Thread Kamil Debski
From: Hans Verkuil Add callbacks to the v4l2_subdev_video_ops. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski --- include/media/v4l2-subdev.h |8 1 file changed, 8 insertions(+) diff --git a

[PATCH v4 03/10] dts: exynos4412-odroid*: enable the HDMI CEC device

2015-04-23 Thread Kamil Debski
Add a dts node entry and enable the HDMI CEC device present in the Exynos4 family of SoCs. Signed-off-by: Kamil Debski --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot

[PATCH v4 02/10] dts: exynos4: add node for the HDMI CEC device

2015-04-23 Thread Kamil Debski
This patch adds HDMI CEC node specific to the Exynos4210/4x12 SoC series. Signed-off-by: Kamil Debski --- arch/arm/boot/dts/exynos4.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index e20cdc2..8776db9

[PATCH v4 01/10] dts: exynos4*: add HDMI CEC pin definition to pinctrl

2015-04-23 Thread Kamil Debski
Add pinctrl nodes for the HDMI CEC device to the Exynos4210 and Exynos4x12 SoCs. These are required by the HDMI CEC device. Signed-off-by: Kamil Debski --- arch/arm/boot/dts/exynos4210-pinctrl.dtsi |7 +++ arch/arm/boot/dts/exynos4x12-pinctrl.dtsi |7 +++ 2 files changed, 14

[PATCH v4 00/10] HDMI CEC framework

2015-04-23 Thread Kamil Debski
caused some discussion and I decided to drop it. In my opinion it can be useful for debugging, but on the other hand I believe it can be easily added at a later time, if appropriate. Best wishes, Kamil Debski Changes since v3 - remove the promiscuous mode - rewrite the devicetree

RE: [RFC v3 5/9] cec: add new driver for cec support.

2015-04-20 Thread Kamil Debski
Hi Hans, From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Hans Verkuil Sent: Friday, April 17, 2015 2:17 PM > > On 04/13/2015 03:19 PM, Kamil Debski wrote: > > Hi Hans, > > > > Thank you so much for the review. >

RE: [RFC v3 5/9] cec: add new driver for cec support.

2015-04-13 Thread Kamil Debski
some comments, see below. > > On 03/20/2015 05:52 PM, Kamil Debski wrote: > > Add the CEC framework. > > > > Signed-off-by: Hans Verkuil > > [k.deb...@samsung.com: Merged CEC Updates commit by Hans Verkuil] > > [k.deb...@samsung.com: Merged Update author commit by H

[RFC v3 9/9] s5p-cec: Add s5p-cec driver

2015-03-20 Thread Kamil Debski
Add CEC interface driver present in the Samsung Exynos range of SoCs. The following files were based on work by SangPil Moon: - exynos_hdmi_cec.h - exynos_hdmi_cecctl.c Signed-off-by: Kamil Debski --- drivers/media/platform/Kconfig |7 + drivers/media/platform/Makefile

[RFC v3 8/9] adv7511: add cec support.

2015-03-20 Thread Kamil Debski
From: Hans Verkuil Add CEC support to the adv7511 driver. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski --- drivers/media/i2c/adv7511.c | 325 ++- include/media

[RFC v3 7/9] adv7604: add cec support.

2015-03-20 Thread Kamil Debski
From: Hans Verkuil Add CEC support to the adv7604 driver. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski --- drivers/media/i2c/adv7604.c | 182 +++ 1 file changed

[RFC v3 4/9] rc: add a map for devices communicating over the HDMI CEC bus

2015-03-20 Thread Kamil Debski
This patch add a map for devices that communicate over the HDMI CEC bus. Sgined-off-by: Kamil Debski --- drivers/media/rc/keymaps/Makefile |1 + drivers/media/rc/keymaps/rc-cec.c | 144 + drivers/media/rc/rc-main.c|1 + include/media/rc

[RFC v3 6/9] v4l2-subdev: add cec ops.

2015-03-20 Thread Kamil Debski
From: Hans Verkuil Add callbacks to the v4l2_subdev_video_ops. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski --- include/media/v4l2-subdev.h |8 1 file changed, 8 insertions(+) diff --git a

[RFC v3 5/9] cec: add new driver for cec support.

2015-03-20 Thread Kamil Debski
possibility to clear assigned logical addresses] Signed-off-by: Kamil Debski --- Documentation/cec.txt| 321 + drivers/media/Kconfig|6 + drivers/media/Makefile |2 + drivers/media/cec.c | 1158 ++ include/media/cec.h

[RFC v3 3/9] Input: add key codes specific to the HDMI CEC bus

2015-03-20 Thread Kamil Debski
The HDMI CEC bus allows device to communicate with one another. This includes sending remote control key codes. Some of key codes defined in the CEC standard are not defined in the input.h. This patch adds the key codes that are missing. Signed-off-by: Kamil Debski --- include/uapi/linux

[RFC v3 2/9] dts: add s5p-cec to exynos4412-odroidu3

2015-03-20 Thread Kamil Debski
Add support for the s5p-mfc device to the exynos4412-odroidu3.dts. Signed-off-by: Kamil Debski --- arch/arm/boot/dts/exynos4412-odroidu3.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3

[RFC v3 1/9] dts: add hdmi-cec to to pinctrl definitions

2015-03-20 Thread Kamil Debski
Add entry for hdmi-cec to the pinctrl_1. Signed-off-by: Kamil Debski --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi index de80b5b

[RFC v3 0/9] HDMI CEC framework

2015-03-20 Thread Kamil Debski
back the discussion on a common CEC interface framework. There are a few things that were still left as TODO, I think they might need some discussion - for instance the way how the remote controls should be handled. Best wishes, Kamil Debski Original RFC by Hans Verkuil/Martin Bugge

RE: [RFC v2 2/7] media: rc: Add cec protocol handling

2015-03-11 Thread Kamil Debski
Hi Mauro, I have some more comments/questions below. From: Mauro Carvalho Chehab [mailto:mche...@osg.samsung.com] Sent: Sunday, March 08, 2015 3:21 PM > > Em Thu, 22 Jan 2015 17:04:34 +0100 > Kamil Debski escreveu: > > (c/c linux-input ML) > > > Add cec protocol h

RE: [RFC v2 2/7] media: rc: Add cec protocol handling

2015-03-10 Thread Kamil Debski
From: Bastien Nocera [mailto:had...@hadess.net] Sent: Tuesday, March 10, 2015 3:15 PM > > On Tue, 2015-03-10 at 13:02 +0100, Kamil Debski wrote: > > Hi Bastien, > > > > From: Bastien Nocera [mailto:had...@hadess.net] > > Sent: Monday, March 09, 2015 5:44 PM > >

RE: [RFC v2 2/7] media: rc: Add cec protocol handling

2015-03-10 Thread Kamil Debski
Hi Bastien, From: Bastien Nocera [mailto:had...@hadess.net] Sent: Monday, March 09, 2015 5:44 PM > > On Mon, 2015-03-09 at 17:22 +0100, Kamil Debski wrote: > > Hi Mauro, > > > > From: Mauro Carvalho Chehab [mailto:mche...@osg.samsung.com] > > Sent: Sunday, March 08,

RE: [RFC v2 2/7] media: rc: Add cec protocol handling

2015-03-09 Thread Kamil Debski
Hi Mauro, From: Mauro Carvalho Chehab [mailto:mche...@osg.samsung.com] Sent: Sunday, March 08, 2015 3:21 PM > Em Thu, 22 Jan 2015 17:04:34 +0100 > Kamil Debski escreveu: > > (c/c linux-input ML) > > > Add cec protocol handling the RC framework. > > I added some