Re: [PATCH 03/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag

2015-10-05 Thread Laxman Dewangan
HIGH, pdev->name, kbc); Acked-by: Laxman Dewangan -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/1] Input: gpio_keys - add device tree support for interrupt only keys

2014-11-13 Thread Laxman Dewangan
On Thursday 13 November 2014 04:35 PM, Arnd Bergmann wrote: On Thursday 13 November 2014 16:29:02 Laxman Dewangan wrote: Yes, I posted patch for interrupt key on context on key connected to PMIC-Onkey. On PMIC, there is onkey pin input which generates interrupt only when it toggles. So if we

Re: [PATCH v2 1/1] Input: gpio_keys - add device tree support for interrupt only keys

2014-11-13 Thread Laxman Dewangan
On Thursday 13 November 2014 04:30 PM, Arnd Bergmann wrote: On Thursday 13 November 2014 11:52:48 Alexander Stein wrote: On Thursday 13 November 2014 11:47:13, Arnd Bergmann wrote: Regarding your initial use case of testing interrupt polarity, would you have been able to do the same thing by lo

Re: [PATCH v2 1/1] Input: gpio_keys - add device tree support for interrupt only keys

2014-11-13 Thread Laxman Dewangan
hecked each occurrence. I didn't found any usage of IRQ based input keys. Ok, I see. I notice that Laxman Dewangan initially added the feature as part of (I assume) work on Tegra, but these days Tegra is DT-only so it can't actually get used for that any more. If we have a real usecase, I

Re: [patch]GPIO button is supposed to wake the system up if the wakeup attribute is set

2014-04-17 Thread Laxman Dewangan
On Thursday 17 April 2014 10:12 PM, Li, Aubrey wrote: On 2014/4/16 20:35, Laxman Dewangan wrote: On Tuesday 15 April 2014 09:48 PM, Li, Aubrey wrote: On 2014/4/15 20:38, Laxman Dewangan wrote: On Monday 14 April 2014 09:12 PM, Li, Aubrey wrote: ping... On 2014/4/10 18:48, One Thousand

Re: [patch]GPIO button is supposed to wake the system up if the wakeup attribute is set

2014-04-16 Thread Laxman Dewangan
On Tuesday 15 April 2014 09:48 PM, Li, Aubrey wrote: On 2014/4/15 20:38, Laxman Dewangan wrote: On Monday 14 April 2014 09:12 PM, Li, Aubrey wrote: ping... On 2014/4/10 18:48, One Thousand Gnomes wrote: I think when we say irq_wake_enable() then based on underlying HW, it should not turn

Re: [patch]GPIO button is supposed to wake the system up if the wakeup attribute is set

2014-04-15 Thread Laxman Dewangan
On Monday 14 April 2014 09:12 PM, Li, Aubrey wrote: ping... On 2014/4/10 18:48, One Thousand Gnomes wrote: On Thu, 10 Apr 2014 10:11:09 +0800 "Li, Aubrey" wrote: When the wakeup attribute is set, GPIO button is supposed to set irqflag - IRQF_NO_SUSPEND to request irq. So when the system ente

Re: [PATCH 1/2] include: dt-binding: input: create a DT header defining key codes.

2013-08-19 Thread Laxman Dewangan
On Monday 12 August 2013 11:29 PM, Stephen Warren wrote: On 08/12/2013 11:15 AM, Dmitry Torokhov wrote: Device tree files can only include headers in include/dt-bindings. Eventually/soon, all the DT files and the headers in the dt-bindings/ directory will be split out into a separate git tree,

Re: [PATCH 1/2] include: dt-binding: input: create a DT header defining key codes.

2013-08-08 Thread Laxman Dewangan
On Thursday 08 August 2013 10:43 PM, Dmitry Torokhov wrote: On Thu, Aug 08, 2013 at 10:41:20PM +0530, Laxman Dewangan wrote: On Wednesday 07 August 2013 12:58 AM, Stephen Warren wrote: (CC'ing DT bindings maintainers too, hence quoting a bit of the patch) On 08/06/2013 08:12 AM, L

Re: [PATCH 1/2] include: dt-binding: input: create a DT header defining key codes.

2013-08-08 Thread Laxman Dewangan
On Wednesday 07 August 2013 12:58 AM, Stephen Warren wrote: (CC'ing DT bindings maintainers too, hence quoting a bit of the patch) On 08/06/2013 08:12 AM, Laxman Dewangan wrote: Many of Key device tree bindings uses the constant number as key code which matches with kernel header key cod

[PATCH 2/2] ARM: tegra: use dt-binding header for key code

2013-08-06 Thread Laxman Dewangan
In place of hardcoding the key code in DTS file and comment the key code as side notes, use the key code macro defines in the dt-bindings/input/input.h directly. Signed-off-by: Laxman Dewangan --- arch/arm/boot/dts/tegra114-dalmore.dts |9 + 1 files changed, 5 insertions(+), 4

[PATCH 1/2] include: dt-binding: input: create a DT header defining key codes.

2013-08-06 Thread Laxman Dewangan
gs can use it as follows: linux,code = ; Signed-off-by: Laxman Dewangan --- Just adding the change for Tegra114-dalmore DTS file along with this change. If this is accpeted and no issue on this then I will cleanup more Tegra specific DTS files. include/dt-bindings/input/input.h

[PATCH V2] input: keyboard: tegra: support for defining row/columns based on SoC

2013-03-13 Thread Laxman Dewangan
NVIDIA's Tegra20 and Tegra30 supports the 16x8 keyboard matrix and T114 support the 11x8 Key matrix. Add support for defining the maximum row/columns based on SoC through proper compatibity. Signed-off-by: Laxman Dewangan Reviewed-by: Stephen Warren --- Changes from V1: - cleanup chang

[PATCH] input: keyboard: tegra: support for defining row/columns based on SoC

2013-03-12 Thread Laxman Dewangan
NVIDIA's Tegra20 and Tegra30 supports the 16x8 keyboard matrix and T114 support the 11x8 Key matrix. Add support for defining the maximum row/columns based on SoC through proper compatibity. Signed-off-by: Laxman Dewangan --- drivers/input/keyboard/tegra-kbc.c |

Re: [PATCH V4 0/4] input: keyboard: tegra: cleanups and DT supports

2013-01-10 Thread Laxman Dewangan
On Thursday 10 January 2013 11:14 PM, Dmitry Torokhov wrote: Hi Laxman, On Thu, Jan 10, 2013 at 12:01:23PM +0530, Laxman Dewangan wrote: Hi Dmitry, On Monday 07 January 2013 10:22 PM, Stephen Warren wrote: On 01/06/2013 04:14 AM, Laxman Dewangan wrote: This patch series: - fix build

Re: [PATCH V4 0/4] input: keyboard: tegra: cleanups and DT supports

2013-01-09 Thread Laxman Dewangan
Hi Dmitry, On Monday 07 January 2013 10:22 PM, Stephen Warren wrote: On 01/06/2013 04:14 AM, Laxman Dewangan wrote: This patch series: - fix build warning, - use devm_* for allocation, - make column/rows configuration through DT and - remove the rarely used key mapping table. The

Re: [PATCH v3] Input: mms114: Use devm_* APIs

2013-01-09 Thread Laxman Dewangan
On Wednesday 09 January 2013 02:52 PM, Sachin Kamat wrote: devm_* APIs are device managed and make the exit and clean up code simpler. Signed-off-by: Sachin Kamat Cc: Joonyoung Shim --- Acked-by: Laxman Dewangan

Re: [PATCH Resend] Input: mms114: Use devm_* APIs

2013-01-08 Thread Laxman Dewangan
On Wednesday 09 January 2013 09:45 AM, Sachin Kamat wrote: devm_* APIs are device managed and make the exit and clean up code simpler. Signed-off-by: Sachin Kamat Cc: Joonyoung Shim --- I think this is not resend patch, it is Patch V2. Also you can specify the changes done from last patch t

Re: [PATCH] mfd: stmpe: Pull IRQ GPIO number from DT during DT-based probe

2013-01-08 Thread Laxman Dewangan
On Tuesday 08 January 2013 04:44 PM, Viresh Kumar wrote: On 8 January 2013 16:41, Lee Jones wrote: Hmm.. I tried a bit, but couldn't find any such call :( Probably an assumption is taken here. GPIO pins which are going to be used as interrupt lines, wouldn't be getting set in output mode at all

Re: [PATCH 1/1] Input: mms114: Use devm_* APIs

2013-01-08 Thread Laxman Dewangan
On Tuesday 08 January 2013 03:35 PM, Sachin Kamat wrote: devm_* APIs are device managed and make the exit and clean up code simpler. Signed-off-by: Sachin Kamat Cc: Joonyoung Shim --- Compile tested against linux-next tree (20130108). --- drivers/input/touchscreen/mms114.c | 41 +++

[PATCH V4 4/4] input: keyboard: tegra: remove default key mapping

2013-01-06 Thread Laxman Dewangan
. Signed-off-by: Laxman Dewangan --- Changes from V1, V2 and V3: None. drivers/input/keyboard/tegra-kbc.c | 156 +--- 1 files changed, 1 insertions(+), 155 deletions(-) diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c index

[PATCH V4 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-06 Thread Laxman Dewangan
Use devm_* for memory, clock, irq, input device allocation. This reduces code for freeing these resources. Signed-off-by: Laxman Dewangan --- Changes from V1: None Changes from V2: - remove the error checks changes from original. - return -EBUSY when reg mapping fail. - remove

[PATCH V4 3/4] input: keyboard: tegra: add support for rows/cols configuration from dt

2013-01-06 Thread Laxman Dewangan
y for configuring pins to either row or column from DT. Update the devicetree binding document accordingly. Signed-off-by: Laxman Dewangan --- Changes from V1: - renames the rows and pins property array. - nit cleanups. Changes from V2/V3: None .../bindings/input/nvidia,tegra20-kbc.txt |

[PATCH V4 0/4] input: keyboard: tegra: cleanups and DT supports

2013-01-06 Thread Laxman Dewangan
from original. - return -EBUSY when reg mapping fail. - remove unregister_input_device() devm_* version is used. - Pass correct argument in free_irq. Changes from V3: - use devm_request_irq() and remove the kbc_remove() callback. Laxman Dewangan (4): input: keyboard: tegra: fix build warning

[PATCH V4 1/4] input: keyboard: tegra: fix build warning

2013-01-06 Thread Laxman Dewangan
Fix the following build warning when building driver with CONFIG_PM_SLEEP not selected. tegra-kbc.c:360:13: warning: 'tegra_kbc_set_keypress_interrupt' defined but not used [-Wunused-function] Signed-off-by: Laxman Dewangan --- Changes from V1, V2 and V3: None drivers/inpu

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-06 Thread Laxman Dewangan
On Sunday 06 January 2013 04:48 AM, Dmitry Torokhov wrote: On Sat, Jan 05, 2013 at 04:50:58PM +0530, Laxman Dewangan wrote: HI Dmitry, Thanks for quick review. I will take care of your comment in next version. Some have my answer. On Saturday 05 January 2013 01:36 PM, Dmitry Torokhov wrote

[PATCH V3 1/4] input: keyboard: tegra: fix build warning

2013-01-05 Thread Laxman Dewangan
Fix the following build warning when building driver with CONFIG_PM_SLEEP not selected. tegra-kbc.c:360:13: warning: 'tegra_kbc_set_keypress_interrupt' defined but not used [-Wunused-function] Signed-off-by: Laxman Dewangan --- Changes from V1 and V2: None drivers/input/keyboard/t

[PATCH V3 3/4] input: keyboard: tegra: add support for rows/cols configuration from dt

2013-01-05 Thread Laxman Dewangan
y for configuring pins to either row or column from DT. Update the devicetree binding document accordingly. Signed-off-by: Laxman Dewangan --- Changes from V1: - renames the rows and pins property array. - nit cleanups. Changes from V2: None .../bindings/input/nvidia,tegra20-kbc.txt |

[PATCH V3 4/4] input: keyboard: tegra: remove default key mapping

2013-01-05 Thread Laxman Dewangan
. Signed-off-by: Laxman Dewangan --- Changes from V1 and V2: None. drivers/input/keyboard/tegra-kbc.c | 156 +--- 1 files changed, 1 insertions(+), 155 deletions(-) diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c index

[PATCH V3 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-05 Thread Laxman Dewangan
Use devm_* for memory, clock, input device allocation. This reduces code for freeing these resources. Signed-off-by: Laxman Dewangan --- Changes from V1: None Changes from V2: - remove the error checks changes from original. - return -EBUSY when reg mapping fail. - remove unregister_input_device

[PATCH V3 0/4] input: keyboard: tegra: cleanups and DT supports

2013-01-05 Thread Laxman Dewangan
from original. - return -EBUSY when reg mapping fail. - remove unregister_input_device() devm_* version is used. - Pass correct argument in free_irq. Laxman Dewangan (4): input: keyboard: tegra: fix build warning input: keyboard: tegra: use devm_* for resource allocation input: keyboard: tegra

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-05 Thread Laxman Dewangan
HI Dmitry, Thanks for quick review. I will take care of your comment in next version. Some have my answer. On Saturday 05 January 2013 01:36 PM, Dmitry Torokhov wrote: Hi Laxman, On Sat, Jan 05, 2013 at 01:15:08PM +0530, Laxman Dewangan wrote: Use devm_* for memory, clock, input device

[PATCH v2] input: keyboard: tegra: add support for rows/cols configuration from dt

2013-01-04 Thread Laxman Dewangan
y for configuring pins to either row or column from DT. Update the devicetree binding document accordingly. Signed-off-by: Laxman Dewangan --- Changes from V1: - renames kbc-rows and kbc-cols to kbc-row-pins and kbc-col-pins. - cleanusp. .../bindings/input/nvidia,tegra20-kbc.txt | 22 ++ dr

[PATCH v2 1/4] input: keyboard: tegra: fix build warning

2013-01-04 Thread Laxman Dewangan
Fix the following build warning when building driver with CONFIG_PM_SLEEP not selected. tegra-kbc.c:360:13: warning: 'tegra_kbc_set_keypress_interrupt' defined but not used [-Wunused-function] Signed-off-by: Laxman Dewangan --- Changes form V1: - none drivers/input/keyboard/t

[PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-04 Thread Laxman Dewangan
Use devm_* for memory, clock, input device allocation. This reduces code for freeing these resources. Signed-off-by: Laxman Dewangan --- Changes from V1: None drivers/input/keyboard/tegra-kbc.c | 93 +++- 1 files changed, 28 insertions(+), 65 deletions

[PATCH v2 4/4] input: keyboard: tegra: remove default key mapping

2013-01-04 Thread Laxman Dewangan
. Signed-off-by: Laxman Dewangan --- Changes from V1: - None drivers/input/keyboard/tegra-kbc.c | 156 +--- 1 files changed, 1 insertions(+), 155 deletions(-) diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c index ef7a0ac

[PATCH V2 0/4] input: keyboard: tegra: cleanups and DT supports

2013-01-04 Thread Laxman Dewangan
This patch series: - fix build warning, - use devm_* for allocation, - make column/rows configuration through DT and - remove the rarely used key mapping table. Changes from V1: - renames the rows and pins property array. - nit cleanups. Laxman Dewangan (4): input: keyboard: tegra: fix

Re: [PATCH 4/4] input: keyboard: tegra: remove default key mapping

2013-01-04 Thread Laxman Dewangan
On Saturday 05 January 2013 01:22 AM, Stephen Warren wrote: On 01/04/2013 04:02 AM, Laxman Dewangan wrote: Tegra KBC driver have the default key mapping for 16x8 configuration. The key mapping can be provided through platform data or through DT and the mapping varies from platform to platform

[PATCH 4/4] input: keyboard: tegra: remove default key mapping

2013-01-04 Thread Laxman Dewangan
. Signed-off-by: Laxman Dewangan --- drivers/input/keyboard/tegra-kbc.c | 156 +--- 1 files changed, 1 insertions(+), 155 deletions(-) diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c index 69f8b04..4e33929 100644 --- a

[PATCH 3/4] input: keyboard: tegra: add support for rows/cols configuration from dt

2013-01-04 Thread Laxman Dewangan
y for configuring pins to either row or column from DT. Update the devicetree binding document accordingly. Signed-off-by: Laxman Dewangan --- .../bindings/input/nvidia,tegra20-kbc.txt | 22 ++ drivers/input/keyboard/tegra-kbc.c | 73 +++ 2 files change

[PATCH 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-04 Thread Laxman Dewangan
Use devm_* for memory, clock, input device allocation. This reduces code for freeing these resources. Signed-off-by: Laxman Dewangan --- drivers/input/keyboard/tegra-kbc.c | 93 +++- 1 files changed, 28 insertions(+), 65 deletions(-) diff --git a/drivers/input

[PATCH 1/4] input: keyboard: tegra: fix build warning

2013-01-04 Thread Laxman Dewangan
Fix the following build warning when building driver with CONFIG_PM_SLEEP not selected. tegra-kbc.c:360:13: warning: 'tegra_kbc_set_keypress_interrupt' defined but not used [-Wunused-function] Signed-off-by: Laxman Dewangan --- drivers/input/keyboard/tegra-kb

[PATCH 0/4] input: keyboard: tegra: cleanups and DT supports

2013-01-04 Thread Laxman Dewangan
This patch series: - fix build warning, - use devm_* for allocation, - make column/rows configuration through DT and - remove the rarely used key mapping table. Laxman Dewangan (4): input: keyboard: tegra: fix build warning input: keyboard: tegra: use devm_* for resource allocation

Re: [Patch v1 7/7] DA9055 Onkey driver

2012-09-14 Thread Laxman Dewangan
On Friday 14 September 2012 07:04 PM, Ashish Jangam wrote: +static irqreturn_t da9055_onkey_irq(int irq, void *data) +{ + struct input_dev *input_dev = data; + + input_report_key(input_dev, KEY_POWER, 1); When do you send the release key event? Overall driver looks like you can use

Re: [Patch v1 4/7] DA9055 GPIO driver

2012-09-14 Thread Laxman Dewangan
On Friday 14 September 2012 07:00 PM, Ashish Jangam wrote: This is the GPIO patch for the DA9055 PMIC. This patch has got dependency on the DA9055 MFD core. This patch is functionally tested on SMDK6410 board. Signed-off-by: David Dajun Chen Signed-off-by: Ashish Jangam --- +struct da9055_g