Re: [PATCH v5] input: drv260x: Add TI drv260x haptics driver

2014-08-13 Thread Mark Rutland
Hi Dan, Apologies for the delay. On Thu, Jul 31, 2014 at 08:14:49PM +0100, Dan Murphy wrote: > Add the TI drv260x haptics/vibrator driver. > This device uses the input force feedback > to produce a wave form to driver an > ERM or LRA actuator device. > > The initial driver supports the devices >

Re: [PATCH v2] Input: add i2c/smbus driver for elan touchpad

2014-10-06 Thread Mark Rutland
On Fri, Oct 03, 2014 at 10:06:51PM +0100, Dmitry Torokhov wrote: > [adding devicetree folks...] > > On Fri, Oct 03, 2014 at 02:03:57PM -0700, Dmitry Torokhov wrote: > > Hi Duson, > > > > On Tue, Jan 07, 2014 at 11:08:03AM +0800, Duson Lin wrote: > > > This driver adds support for elan i2c/smbus to

Re: [PATCH v6 1/3] cap11xx: make driver generic for variant support

2014-10-13 Thread Mark Rutland
On Sat, Oct 11, 2014 at 06:06:52AM +0100, Matt Ranostay wrote: > cap1106 driver can support much more one device make the driver > generic for support of similar parts. > > Signed-off-by: Matt Ranostay > --- > .../devicetree/bindings/input/cap1106.txt | 53 > .../devicetree/bindin

Re: [PATCH v2 1/5] drivers: input: keyboard: st-keyscan: add keyscan driver

2014-03-18 Thread Mark Rutland
On Tue, Mar 18, 2014 at 03:00:02PM +, Gabriel FERNANDEZ wrote: > This patch adds ST Keyscan driver to use the keypad hw a subset > of ST boards provide. Specific board setup will be put in the > given dt. > > Signed-off-by: Gabriel Fernandez > Signed-off-by: Giuseppe Condorelli > --- > .../

Re: [PATCHv4 2/5] Input: edt-ft5x06: Add DT support

2014-03-20 Thread Mark Rutland
On Wed, Mar 19, 2014 at 01:09:20PM +, Lothar Waßmann wrote: > > Signed-off-by: Lothar Waßmann > --- > .../bindings/input/touchscreen/edt-ft5x06.txt | 41 ++ > drivers/input/touchscreen/edt-ft5x06.c | 144 > +++- > 2 files changed, 154 insertions(+), 3

Re: [PATCHv4 2/5] Input: edt-ft5x06: Add DT support

2014-03-20 Thread Mark Rutland
On Thu, Mar 20, 2014 at 11:18:10AM +, Simon Budig wrote: > On 20/03/14 10:37, Mark Rutland wrote: > > On Wed, Mar 19, 2014 at 01:09:20PM +, Lothar Waßmann wrote: > >> +FocalTech EDT-FT5x06 Polytouch driver > >> += >

Re: [PATCHv4 2/5] Input: edt-ft5x06: Add DT support

2014-03-20 Thread Mark Rutland
On Thu, Mar 20, 2014 at 11:40:55AM +, Lothar Waßmann wrote: > Hi, > > Mark Rutland wrote: > > On Wed, Mar 19, 2014 at 01:09:20PM +, Lothar Waßmann wrote: > > > > > > Signed-off-by: Lothar Waßmann > > > --- > > > .../bi

Re: [PATCH] input: rotary encoder: implement quarter period mode

2014-05-07 Thread Mark Rutland
smaller than 0. For absolute axis only. > - rotary-encoder,half-period: Makes the driver work on half-period mode. > +- rotary-encoder,quarter-period: Makes the driver work on quarter-period > mode. The new property looks as sane to me as the half-period property, so for the binding

Re: [PATCH 1/2] Input: mcs_touchkey: add device tree support

2014-05-21 Thread Mark Rutland
On Wed, May 21, 2014 at 06:51:49AM +0100, Beomho Seo wrote: > Add device tree support for mcs touchkey driver. > Tested on exynos 4412 board. > > Signed-off-by: Beomho Seo > Cc: Joonyoung Shim > --- > drivers/input/keyboard/mcs_touchkey.c | 73 > +++-- > 1 file ch

Re: [PATCH 2/2] Input: mcs_touchkey: add device tree binding document

2014-05-21 Thread Mark Rutland
On Wed, May 21, 2014 at 06:51:57AM +0100, Beomho Seo wrote: > This patch add simple device tree bindings to > MELFAS MCS5000/5080 controller. > > Signed-off-by: Beomho Seo > --- > .../devicetree/bindings/input/mcs-touchkey.txt | 25 > > 1 file changed, 25 insertions(+

Re: [PATCH v7 3/6] input: misc: Add driver for AXP20x Power Enable Key

2014-06-30 Thread Mark Rutland
On Sun, Jun 29, 2014 at 07:23:54PM +0100, Carlo Caione wrote: > This patch add support for the Power Enable Key found on MFD AXP202 and > AXP209. Besides the basic support for the button, the driver adds two > entries in sysfs to configure the time delay for power on/off. > > Signed-off-by: Carlo

Re: [PATCH v7 1/6] mfd: AXP20x: Add bindings documentation

2014-06-30 Thread Mark Rutland
On Sun, Jun 29, 2014 at 07:23:52PM +0100, Carlo Caione wrote: > Bindings documentation for the AXP20x driver. In this file also > sub-nodes are documented. > > Signed-off-by: Carlo Caione > Acked-by: Maxime Ripard > --- > Documentation/devicetree/bindings/mfd/axp20x.txt | 93 >

Re: [PATCH v2] Input: Add driver for Microchip's CAP1106

2014-07-14 Thread Mark Rutland
On Fri, Jul 11, 2014 at 11:06:33AM +0100, Daniel Mack wrote: > This patch adds a driver for Microchips CAP1106, an I2C driven, 6-channel > capacitive touch sensor. > > For now, only the capacitive buttons are supported, and no specific > settings that can be tweaked for individual channels, except

Re: [PATCH v2] Input: Add driver for Microchip's CAP1106

2014-07-15 Thread Mark Rutland
On Mon, Jul 14, 2014 at 11:20:17AM +0100, Daniel Mack wrote: > Hi Mark, > > thanks a lot for your feedback! Much appreciated. > > On 07/14/2014 11:52 AM, Mark Rutland wrote: > > On Fri, Jul 11, 2014 at 11:06:33AM +0100, Daniel Mack wrote: > > >> +++ b/Docume

Re: [PATCH v4] Input: Add driver for Microchip's CAP1106

2014-07-15 Thread Mark Rutland
On Mon, Jul 14, 2014 at 07:46:43PM +0100, Dmitry Torokhov wrote: > On Mon, Jul 14, 2014 at 04:28:02PM +0200, Daniel Mack wrote: > > + > > +static int cap1106_i2c_remove(struct i2c_client *i2c_client) > > +{ > > + struct cap1106_priv *priv = i2c_get_clientdata(i2c_client); > > + > > + input_unre

Re: [PATCH v2] Input: Add driver for Microchip's CAP1106

2014-07-15 Thread Mark Rutland
On Tue, Jul 15, 2014 at 10:12:22AM +0100, Daniel Mack wrote: > On 07/15/2014 10:51 AM, Mark Rutland wrote: > > On Mon, Jul 14, 2014 at 11:20:17AM +0100, Daniel Mack wrote: > > >> Hmm, I thought about that, but there are - in theory - more details that > >> could be

Re: [PATCH v2] Input: Add driver for Microchip's CAP1106

2014-07-15 Thread Mark Rutland
On Tue, Jul 15, 2014 at 05:41:49PM +0100, Dmitry Torokhov wrote: > Hi Mark, > > On Tue, Jul 15, 2014 at 09:51:38AM +0100, Mark Rutland wrote: > > On Mon, Jul 14, 2014 at 11:20:17AM +0100, Daniel Mack wrote: > > > > > > linux,keycode feels a bit overkill he

Re: [v2] input: drv260x: Add TI drv260x haptics driver

2014-07-29 Thread Mark Rutland
On Mon, Jul 28, 2014 at 05:53:23PM +0100, Dan Murphy wrote: > Add the TI drv260x haptics/vibrator driver. > This device uses the input force feedback > to produce a wave form to driver an > ERM or LRA actuator device. > > The initial driver supports the devices > real time playback mode. But the

Re: [v2] input: drv260x: Add TI drv260x haptics driver

2014-07-29 Thread Mark Rutland
On Tue, Jul 29, 2014 at 02:50:48PM +0100, Murphy, Dan wrote: > Mark > > Thanks for the feedback > > On 07/29/2014 04:37 AM, Mark Rutland wrote: > > On Mon, Jul 28, 2014 at 05:53:23PM +0100, Dan Murphy wrote: > >> Add the TI drv260x haptics/vibrator driver. > &g

Re: [PATCH v2 2/2] input: rotary-encoder: Add 'on-each-step' to binding documentation

2013-10-04 Thread Mark Rutland
On Fri, Oct 04, 2013 at 01:53:23PM +0100, Ezequiel Garcia wrote: > The driver now supports a new mode to handle the interruptions generated > by the device: on this new mode an input event is generated on each step > (i.e. on each IRQ). Therefore, add a new DT property, to select the > mode: 'rotar

Re: [PATCHv2 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-23 Thread Mark Rutland
On Wed, Oct 23, 2013 at 04:01:20PM +0100, Sebastian Reichel wrote: > Add device tree support for twl4030 power button driver. This requires a binding document. As it is it's not possible to review. Mark. > > Signed-off-by: Sebastian Reichel > --- > drivers/input/misc/twl4030-pwrbutton.c | 16

Re: [PATCH V4 1/2] tps6507x-ts: Add DT support

2013-10-23 Thread Mark Rutland
On Wed, Oct 23, 2013 at 05:28:52PM +0100, Manish Badarkhe wrote: > Add device tree based support for TI's tps6507x touchscreen. > > Signed-off-by: Manish Badarkhe > --- > Changes since V3: > - Rebased on top of Dmitry's changes > - Removed error handling for optional DT properties > > Changes

Re: [PATCH V4 1/2] tps6507x-ts: Add DT support

2013-10-24 Thread Mark Rutland
On Thu, Oct 24, 2013 at 06:05:53PM +0100, Manish Badarkhe wrote: > Hi Mark, > > Thank you for your reply. > > On Wed, Oct 23, 2013 at 10:15 PM, Mark Rutland wrote: > > On Wed, Oct 23, 2013 at 05:28:52PM +0100, Manish Badarkhe wrote: > > Add device tree base

Re: [PATCH 4/5] input: tc3589x-keypad: support probing from device tree

2013-10-31 Thread Mark Rutland
On Tue, Oct 15, 2013 at 10:21:11PM +0100, Linus Walleij wrote: > Implement device tree probing for the tc3589x keypad driver. > This is modeled on the STMPE keypad driver and tested on the > Ux500 TVK1281618 UIB. > > Signed-off-by: Linus Walleij > --- > drivers/input/keyboard/tc3589x-keypad.c |

Re: [PATCH] Input: Add new driver for GPIO beeper

2013-11-12 Thread Mark Rutland
On Tue, Nov 12, 2013 at 10:07:13AM +, Alexander Shiyan wrote: > This patch adds a new driver for the beeper controlled via GPIO pin. > The driver does not depend on the architecture and is positioned as > a replacement for the specific drivers that are used for this function. > > Signed-off-by

Re: [PATCH] Input: Add new driver for GPIO beeper

2013-11-12 Thread Mark Rutland
On Tue, Nov 12, 2013 at 10:47:57AM +, Alexander Shiyan wrote: > Hello. > > > On Tue, Nov 12, 2013 at 10:07:13AM +, Alexander Shiyan wrote: > > > This patch adds a new driver for the beeper controlled via GPIO pin. > > > The driver does not depend on the architecture and is positioned as >

Re: [PATCH 1/2] input: touchscreen: fix spelling mistake in TSC/ADC DT binding

2013-11-14 Thread Mark Rutland
On Tue, Oct 22, 2013 at 01:02:53PM +0100, Felipe Balbi wrote: > Hi, > > On Tue, Oct 22, 2013 at 10:42:00AM +0200, Sebastian Andrzej Siewior wrote: > > On 10/21/2013 10:13 PM, Felipe Balbi wrote: > > > diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c > > > b/drivers/input/touchscreen/ti_am33

Re: [PATCH 1/2] input: touchscreen: fix spelling mistake in TSC/ADC DT binding

2013-11-15 Thread Mark Rutland
On Thu, Nov 14, 2013 at 03:54:04PM +, Felipe Balbi wrote: > HI, > > On Thu, Nov 14, 2013 at 11:19:59AM +0000, Mark Rutland wrote: > > > On Tue, Oct 22, 2013 at 10:42:00AM +0200, Sebastian Andrzej Siewior wrote: > > > > On 10/21/2013 10:13 PM, Felipe Balbi wrote:

Re: [PATCH 1/2] input: touchscreen: fix spelling mistake in TSC/ADC DT binding

2013-11-18 Thread Mark Rutland
On Fri, Nov 15, 2013 at 05:53:56PM +, Felipe Balbi wrote: > Hi, > > On Fri, Nov 15, 2013 at 03:55:40PM +0000, Mark Rutland wrote: > > > > > > > diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c > > > > > > > b/drivers/input/touc

Re: [PATCH] input: touchscreen: ti_am335x_tsc: warn about incorrect spelling

2013-11-18 Thread Mark Rutland
the bogus version > of our touchscreen's DTS. > > Suggested-by: Mark Rutland > Signed-off-by: Felipe Balbi > --- > > Here you go, I've added your Suggested-by Mark, > if you wish I can remove or change to something > else. > > cheers Looks fine t

Re: [PATCH 2/2] Input: edt-ft5x06: Add DT support

2014-01-13 Thread Mark Rutland
On Mon, Jan 13, 2014 at 10:17:04AM +, Lothar Waßmann wrote: > This patch allows the edt-ft5x06 multitouch panel driver to be > configured via DT. > > Signed-off-by: Lothar Waßmann > --- > .../bindings/input/touchscreen/edt-ft5x06.txt | 31 > drivers/input/touchscreen/edt-ft5x06.c

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-26 Thread Mark Rutland
On Mon, Jan 26, 2015 at 02:29:33PM +, Mika Westerberg wrote: > The HID over I2C specification allows to have the interrupt for a HID > device to be GPIO instead of directly connected to the IO-APIC. > > Add support for this so that when the driver does not find proper interrupt > number from t

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-26 Thread Mark Rutland
On Mon, Jan 26, 2015 at 02:47:29PM +, Mika Westerberg wrote: > On Mon, Jan 26, 2015 at 02:37:24PM +0000, Mark Rutland wrote: > > On Mon, Jan 26, 2015 at 02:29:33PM +, Mika Westerberg wrote: > > > The HID over I2C specification allows to have the interrupt for a HID >

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-26 Thread Mark Rutland
On Mon, Jan 26, 2015 at 03:16:37PM +, Mika Westerberg wrote: > On Mon, Jan 26, 2015 at 02:50:01PM +0000, Mark Rutland wrote: > > On Mon, Jan 26, 2015 at 02:47:29PM +, Mika Westerberg wrote: > > > On Mon, Jan 26, 2015 at 02:37:24PM +, Mark Rutland wrote: > > >

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-26 Thread Mark Rutland
On Mon, Jan 26, 2015 at 04:13:56PM +, Mika Westerberg wrote: > On Mon, Jan 26, 2015 at 04:01:20PM +0000, Mark Rutland wrote: > > On Mon, Jan 26, 2015 at 03:16:37PM +, Mika Westerberg wrote: > > > On Mon, Jan 26, 2015 at 02:50:01PM +, Mark Rutland wrote: > > >

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-27 Thread Mark Rutland
On Tue, Jan 27, 2015 at 10:16:10AM +, Mika Westerberg wrote: > On Mon, Jan 26, 2015 at 04:39:30PM +0000, Mark Rutland wrote: > > What I don't follow is why GpioInt seems to be translated as a GPIO > > rather than as an interrupt which happens to be backed by a GPIO. Were

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-27 Thread Mark Rutland
On Tue, Jan 27, 2015 at 10:59:31AM +, Mika Westerberg wrote: > On Tue, Jan 27, 2015 at 10:39:25AM +0000, Mark Rutland wrote: > > > If the above is not the right way to use GPIOs as interrupt, can you > > > please tell me how it is done then? > > > > >

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-27 Thread Mark Rutland
On Tue, Jan 27, 2015 at 11:30:41AM +, Mika Westerberg wrote: > On Tue, Jan 27, 2015 at 11:14:58AM +0000, Mark Rutland wrote: > > On Tue, Jan 27, 2015 at 10:59:31AM +, Mika Westerberg wrote: > > > On Tue, Jan 27, 2015 at 10:39:25AM +, Mark Rutland wrote: > > &

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-27 Thread Mark Rutland
On Tue, Jan 27, 2015 at 02:41:27PM +, Mika Westerberg wrote: > On Tue, Jan 27, 2015 at 02:33:34PM +0000, Mark Rutland wrote: > > Ok, that allays my fear w.r.t. ordering of the resources. > > > > As I see it, the fact that we convert GpioInt entries to GPIOs rather >

Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts

2015-01-27 Thread Mark Rutland
On Tue, Jan 27, 2015 at 03:21:27PM +, Mika Westerberg wrote: > On Tue, Jan 27, 2015 at 03:06:06PM +0000, Mark Rutland wrote: > > On Tue, Jan 27, 2015 at 02:41:27PM +, Mika Westerberg wrote: > > > On Tue, Jan 27, 2015 at 02:33:34PM +, Mark Rutland wrote: > > >

Re: [PATCH 1/5] i8042: intel-8042 DT documentation

2015-02-03 Thread Mark Rutland
On Mon, Feb 02, 2015 at 09:48:46PM +, Roman Volkov wrote: > Documentation for 'intel,8042' DT compatible node. > > Signed-off-by: Tony Prisk > Signed-off-by: Roman Volkov > --- > .../devicetree/bindings/input/intel-8042.txt | 29 > ++ > 1 file changed, 29 insertio

Re: [PATCH 5/5] i8042: Add i8042_dt.h glue for DT support

2015-02-03 Thread Mark Rutland
On Mon, Feb 02, 2015 at 09:48:50PM +, Roman Volkov wrote: > This header file designed to be similar to other glue layers found > for i8042. The difference is that interrupt numbers, device address, > and other information should be retrieved from the device tree. > > Signed-off-by: Tony Prisk

Re: [PATCH 1/2] Documentation: Device Tree binding information for gpio-joy driver

2015-02-06 Thread Mark Rutland
On Fri, Feb 06, 2015 at 09:32:01AM +, Hans Holmberg wrote: > This document describes the Device Tree bindings for the gpio-joy > driver. > > Signed-off-by: Hans Holmberg > --- > .../devicetree/bindings/input/gpio-joy.txt | 29 > ++ > 1 file changed, 29 insertions

Re: [PATCH 2/2] input: gpio-joy - GPIO joystick driver

2015-02-06 Thread Mark Rutland
On Fri, Feb 06, 2015 at 09:32:02AM +, Hans Holmberg wrote: > This is an interrupt-driven driver for digital joysticks > connected to GPIOs. Supports any digital joystick with > signals for up, down, left, right and one signal for > trigger button press, i.e. C64/Atari joysticks. > > Signed-off

Re: [PATCH v3] add support for Freescale's MMA8653FC 10 bit accelerometer

2015-03-19 Thread Mark Rutland
> diff --git a/Documentation/devicetree/bindings/misc/fsl,mma8653fc.txt > b/Documentation/devicetree/bindings/misc/fsl,mma8653fc.txt > new file mode 100644 > index 000..3921acb > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/fsl,mma8653fc.txt > @@ -0,0 +1,96 @@ > +Freescale MMA8

Re: [PATCH 5/9] input: goodix: reset device at init

2015-05-28 Thread Mark Rutland
Hi, On Thu, May 28, 2015 at 01:47:41PM +0100, Irina Tirdea wrote: > After power on, it is recommended that the driver resets the device. > For reset the driver needs to control the interrupt and > reset gpio pins (configured through ACPI/device tree). Why is it necessary to mess with the GPIO the

Re: [PATCH 6/9] input: goodix: write configuration data to device

2015-05-28 Thread Mark Rutland
On Thu, May 28, 2015 at 01:47:42PM +0100, Irina Tirdea wrote: > Goodix devices can be configured by writing this information > to the device at init. The configuration data can > be provided through the ACPI/device tree property > "device-config". If "device-config" is not set, the default > device

Re: [PATCH 8/9] input: goodix: add support for ESD

2015-05-28 Thread Mark Rutland
On Thu, May 28, 2015 at 01:47:44PM +0100, Irina Tirdea wrote: > Add ESD (Electrostatic Discharge) protection mechanism. > > The driver enables ESD protection in HW and checks a register > to determine if ESD occurred. If ESD is signalled by the HW, > the driver will reset the device. > > The ESD

Re: [PATCH 2/5] Documentation: Detail permitted DT properties for the imx6ul_tsc

2015-07-27 Thread Mark Rutland
On Mon, Jul 27, 2015 at 12:26:44PM +0100, Haibo Chen wrote: > Here we apply required documentation for the imx6ul touch screen > controller driver which describe available properties and how to > use them. > > Signed-off-by: Haibo Chen > --- > .../devicetree/bindings/input/touchscreen/imx6ul_tsc

Re: [PATCH 4/5] ARM: dts: imx6ul.dtsi: add TSC support

2015-07-27 Thread Mark Rutland
On Mon, Jul 27, 2015 at 12:26:46PM +0100, Haibo Chen wrote: > Add imx6ul touchscreen controller support. > > TSC module need ADC2 module to measure the touchscreen > coordinate value. This patch put TSC and ADC2 together, > make ADC2 module only be used for TSC, can't be used as > a normal ADC. >

Re: [PATCH v9 9/9] Input: goodix - sort includes using inverse Xmas tree order

2015-10-12 Thread Mark Rutland
Why? Mark. On Mon, Oct 12, 2015 at 06:24:37PM +0300, Irina Tirdea wrote: > Signed-off-by: Irina Tirdea > Tested-by: Bastien Nocera > Tested-by: Aleksei Mamlin > --- > drivers/input/touchscreen/goodix.c | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --gi

Re: [PATCH v9 9/9] Input: goodix - sort includes using inverse Xmas tree order

2015-10-12 Thread Mark Rutland
On Mon, Oct 12, 2015 at 05:40:37PM +0200, Bastien Nocera wrote: > On Mon, 2015-10-12 at 16:39 +0100, Mark Rutland wrote: > > Why? > > It was already discussed in the thread for a previous version, please > refer to that. Fine, but surely that should be in the commit message,