RE: [PATCH V2] input: da9063: report KEY_POWER instead of KEY_SLEEP during power key-press

2015-12-14 Thread Opensource [Steve Twiss]
Regarding: > To: Dmitry Torokhov; LINUX-INPUT; LINUXKERNEL > Subject: [PATCH V2] input: da9063: report KEY_POWER instead of KEY_SLEEP > during power key-press Hi Dmitry, Thanks for your Signed-off-by and merge. Regards, Steve repo linux-next tag next-20151214 commit f889beaaab1ce2ff9d018302359ab

RE: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey

2015-09-30 Thread Opensource [Steve Twiss]
On 30 September 2015 00:54 Dmitry Torokhov wrote: > To: Opensource [Steve Twiss] > Cc: Lee Jones; DEVICETREE; Ian Campbell; Kumar Gala; LINUXINPUT; > LINUXKERNEL; Mark Rutland; Pawel Moll; RTCLINUX; Rob Herring; David > Dajun Chen; Samuel Ortiz; Support Opensource > Subject: Re

RE: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey

2015-09-28 Thread Opensource [Steve Twiss]
> Subject: Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for > DA9062 OnKey > > On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote: > > On Thu, Jul 23, 2015 at 05:17:41PM +0100, S Twiss wrote: > > > From: S Twiss > > > > > > Add device tree bindings for the DA9062

RE: [PATCH V3 2/3] onkey: da9063: Add DA9062 OnKey capability to DA9063 OnKey driver

2015-09-15 Thread Opensource [Steve Twiss]
This is a resend of my previous e-mail sent just a couple of minutes ago -- this one removes the copyright footer that was added by our IT department On 23 July 2015 17:18, Steve Twiss wrote: > Subject: [PATCH V3 2/3] onkey: da9063: Add DA9062 OnKey capability to DA9063 > OnKey driver > > From

RE: [PATCH V3 3/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver

2015-08-05 Thread Opensource [Steve Twiss]
On 05 August 2015 02:55 Alexandre Belloni wrote: > Subject: Re: [PATCH V3 3/3] rtc: da9063: Add DA9062 RTC capability to DA9063 > RTC driver > > On 21/07/2015 at 11:29:07 +0100, S Twiss wrote : > > From: S Twiss > > > > Add DA9062 RTC support into the existing DA9063 RTC driver component by > >

RE: [PATCH] Input: da9052_onkey: Convert to managed resources

2015-08-04 Thread Opensource [Steve Twiss]
On 27 July 2015 03:56, Vaishali Thakkar wrote: > Subject: [PATCH] Input: da9052_onkey: Convert to managed resources > > Use managed resource functions devm_input_allocate_device and > devm_kzalloc. To be compatible with the change, replace various > gotos by direct returns and drop unneeded label

RE: [PATCH V3 0/3] da9062: Add DA9062 OnKey support using the existing DA9063 OnKey driver

2015-07-28 Thread Opensource [Steve Twiss]
On 28 July 2015 09:52 Lee Jones wrote: > To: Opensource [Steve Twiss] > > Steve, > > Can you sort out your git configuration please. Your name should be > represented in full. No abbreviations or synonyms please. > > I would expect to see: 'Steve Twiss ' S

RE: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey

2015-07-28 Thread Opensource [Steve Twiss]
On 28 July 2015 08:43 Lee Jones wrote: > To: Dmitry Torokhov > Subject: Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for > DA9062 OnKey > > On Mon, 27 Jul 2015, Dmitry Torokhov wrote: > > > On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote: > > > On Thu, Jul 23

RE: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey

2015-07-28 Thread Opensource [Steve Twiss]
On 28 July 2015 06:40, Dmitry Torokhov wrote: > Subject: Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for > DA9062 OnKey > > On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote: > > On Thu, Jul 23, 2015 at 05:17:41PM +0100, S Twiss wrote: > > > From: S Twiss > > >

RE: [PATCH V2 3/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver

2015-07-21 Thread Opensource [Steve Twiss]
On 21 July 2015 11:02, Alexandre Belloni wrote: Hi Alexandre, Thanks for your help on this I will send patch v3 with the following changes ... > On 21/07/2015 at 10:43:10 +0100, S Twiss wrote : > > - if (val & (DA9063_E_ALARM)) > > + if (val & (config->rtc_event_alarm_mask)) > unneeded pare

RE: [PATCH RFC V1 2/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver

2015-07-21 Thread Opensource [Steve Twiss]
ensource [Steve Twiss] wrote : > > On 18 July 2015 00:45, Alexandre Belloni wrote: [...] > > > > diff --git a/drivers/rtc/rtc-da9063.c b/drivers/rtc/rtc-da9063.c > > > > index 7ffc570..e94fb6d 100644 > > > > --- a/drivers/rtc/rtc-da9063.c > > >

RE: [PATCH RFC V1 2/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver

2015-07-20 Thread Opensource [Steve Twiss]
On 18 July 2015 00:45, Alexandre Belloni wrote: > On 09/07/2015 at 08:45:53 +0100, S Twiss wrote : > > From: S Twiss > > > > Add DA9062 RTC support into the existing DA9063 RTC driver component by > > using generic access tables for common register and bit mask definitions. > > > > The following

RE: [PATCH RFC V1 3/3] devicetree: da9062: Add device tree bindings for DA9062 RTC

2015-07-20 Thread Opensource [Steve Twiss]
On 18 July 2015 00:48, Alexandre Belloni wrote: > On 09/07/2015 at 08:45:54 +0100, S Twiss wrote : > > From: S Twiss > > > > Add device tree bindings for the DA9062 RTC driver component > > > > Signed-off-by: Steve Twiss [...] > > +- rtc : This node defines settings required for the Real-Time

RE: [PATCH RFC V1 2/3] onkey: da9063: Add DA9062 OnKey capability to DA9063 OnKey driver

2015-07-20 Thread Opensource [Steve Twiss]
On 17 July 2015 23:51, Dmitry Torokhov wrote: > Hi Steve, > On Tue, Jul 14, 2015 at 02:07:50PM +0100, S Twiss wrote: > > From: S Twiss > > Add DA9062 OnKey support into the existing DA9063 OnKey driver component by > > using generic access tables for common register and bit mask definitions. > >

RE: [PATCH RFC V1 0/3] da9062: Add DA9062 RTC support using the existing DA9063 RTC driver

2015-07-09 Thread Opensource [Steve Twiss]
On 09 July 2015 09:02, Geert Uytterhoeven wrote: > Subject: Re: [PATCH RFC V1 0/3] da9062: Add DA9062 RTC support using the > existing DA9063 RTC driver > > Hi Steve, > > On Thu, Jul 9, 2015 at 9:45 AM, S Twiss > wrote: > > From: S Twiss > > > > This patch set adds RTC support for the Dialog D

RE: [PATCH V5 1/2] mfd: da9062: DA9062 MFD core driver

2015-07-07 Thread Opensource [Steve Twiss]
On 07 July 2015 12:42, Lee Jones wrote: > To: Opensource [Steve Twiss] > Subject: Re: [PATCH V5 1/2] mfd: da9062: DA9062 MFD core driver > > > From: S Twiss > > > > Add MFD core driver support for DA9062 > > > > Signed-off-by: Steve Twiss > > [...]

RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver

2015-06-29 Thread Opensource [Steve Twiss]
On 11 June 2015 09:57, Lee Jones wrote: > To: Opensource [Steve Twiss] > Subject: Re: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver > > > > > > Steve Twiss wrote: > > > > > +#define DA9062AA_PAGE_SHIFT 0 > > > > > +#define DA906

RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver

2015-06-11 Thread Opensource [Steve Twiss]
On 11 June 2015 09:57 Lee Jones wrote: > To: Opensource [Steve Twiss] > Subject: Re: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver > > > > > > diff --git a/include/linux/mfd/da9062/registers.h [...] > > > > > +#define DA9062AA_W

RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver

2015-06-11 Thread Opensource [Steve Twiss]
On 28 May 2015 13:53, Steve Twiss wrote: > To: 'Lee Jones' > Subject: RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver > > Hi Lee, > > I will refactor a lot of the driver and implement your changes as requested. Hi Lee, I realise this is a busy kernel time for you, as ever, so this is ju

RE: [RESEND PATCH V4 3/3] mfd: da9063: MFD support for OnKey driver

2015-06-09 Thread Opensource [Steve Twiss]
On 09 June 2015 07:51 Lee Jones wrote: > On Mon, 08 Jun 2015, Dmitry Torokhov wrote: > > On Tue, May 19, 2015 at 11:32:45AM +0100, S Twiss wrote: > > > From: Steve Twiss > > > > > > Add MFD support for the DA9063 OnKey driver > > > > > > The function da9063_clear_fault_log() is added to mitigate

RE: [RESEND PATCH V4 1/1] input: misc: da9063: OnKey driver

2015-06-08 Thread Opensource [Steve Twiss]
On 05 June 2015 18:50 Dmitry Torokhov wrote: > Subject: Re: [RESEND PATCH V4 1/1] input: misc: da9063: OnKey driver > On Thu, Jun 04, 2015 at 12:02:32PM +0100, S Twiss wrote: > > From: Steve Twiss > > > > Add OnKey driver support for DA9063 > > > > Signed-off-by: Steve Twiss > > > > --- > > The

RE: [RESEND PATCH V4 1/3] input: misc: da9063: OnKey driver

2015-06-01 Thread Opensource [Steve Twiss]
On 27 May 2015 16:38, Steve Twiss wrote: > On 19 May 2015 11:33, S Twiss wrote: > > > To: Dmitry Torokhov > > Subject: [RESEND PATCH V4 1/3] input: misc: da9063: OnKey driver > > > > From: Steve Twiss > > Add OnKey driver support for DA9063 > > Signed-off-by: Steve Twiss > > > > --- > > The ch

RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver

2015-05-28 Thread Opensource [Steve Twiss]
Please find more detailed comments below. thanks, Steve On 26 May 2015 17:10 Lee Jones wrote > To: Opensource [Steve Twiss] > Cc: LINUXKERNEL; Samuel Ortiz; Alessandro Zummo; DEVICETREE; David > Dajun Chen; Dmitry Torokhov; Ian Campbell; Kumar Gala; LINUXINPUT; > LINUXWATCHDOG; L

RE: [RESEND PATCH V4 1/3] input: misc: da9063: OnKey driver

2015-05-27 Thread Opensource [Steve Twiss]
On 19 May 2015 11:33, S Twiss wrote: > To: Dmitry Torokhov > Cc: DT; David Dajun Chen; INPUT; Ian Campbell; Kumar Gala; LKML; Lee > Jones; Mark Rutland; Pawel Moll; Rob Herring; Samuel Ortiz; Opensource > [Steve Twiss]; Support Opensource > Subject: [RESEND PATCH V4 1/3] inpu

RE: [RESEND PATCH V4 3/3] mfd: da9063: MFD support for OnKey driver

2015-05-26 Thread Opensource [Steve Twiss]
On 26 May 2015 14:58 Lee Jones wrote: > To: Opensource [Steve Twiss] > Cc: Samuel Ortiz; DT; David Dajun Chen; Dmitry Torokhov; INPUT; Ian > Campbell; Kumar Gala; LKML; Mark Rutland; Pawel Moll; Rob Herring; > Support Opensource > Subject: Re: [RESEND PATCH V4 3/3] mfd: da9063:

RE: [PATCH V3 2/4] regulator: da9062: DA9062 regulator driver

2015-05-21 Thread Opensource [Steve Twiss]
On 21 May 2015 13:04 Mark Brown wrote: > Subject: Re: [PATCH V3 2/4] regulator: da9062: DA9062 regulator driver > > On Tue, May 19, 2015 at 02:10:30PM +0100, S Twiss wrote: > > From: S Twiss > > > > Add BUCK and LDO regulator driver support for DA9062 > > Applied, thanks. Thank you Regards, St

RE: [PATCH V3 3/4] watchdog: da9062: DA9062 watchdog driver

2015-05-21 Thread Opensource [Steve Twiss]
On 20 May 2015 21:30 Guenter Roeck wrote: > Subject: Re: [PATCH V3 3/4] watchdog: da9062: DA9062 watchdog driver > > On Tue, May 19, 2015 at 02:10:30PM +0100, S Twiss wrote: > > From: S Twiss > > > > Add watchdog driver support for DA9062 > > > > > > Signed-off-by: Steve Twiss > > > Reviewed-by

RE: [rtc-linux] RE: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver

2015-05-19 Thread Opensource [Steve Twiss]
On 18 May 2015 18:39 Alexandre Belloni wrote: > Sure, what I understand is that the base functionality is the same and > even the registers are compatible. Are you sure the new features can't > be added to the da9063 and called conditionally? Plenty of drivers are > doing that. Hi Alexandre/Guent

RE: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver

2015-05-15 Thread Opensource [Steve Twiss]
> > + > > +/* E_WDG_WARN interrupt handler */ > > +static irqreturn_t da9062_wdt_wdg_warn_irq_handler(int irq, void *data) > > +{ > > + struct da9062_watchdog *wdt = data; > > + > > + dev_notice(wdt->hw->dev, "Watchdog timeout warning trigger.\n"); > > + return IRQ_HANDLED; > > +} > > + On

RE: [PATCH V1 6/6] devicetree: da9062: Add bindings for DA9062 driver

2015-04-29 Thread Opensource [Steve Twiss]
On 29 April 2015 11:54 Lee Jones wrote : > On Fri, 17 Apr 2015, S Twiss wrote: > > From: S Twiss > > > > Add device tree bindings for the DA9062 driver > > > > Signed-off-by: Steve Twiss > > > > --- > > > > This patch applies against linux-next and v4.0 > > > > Documentation/devicetree/binding

RE: [PATCH V1 1/6] mfd: da9062: DA9062 MFD core driver

2015-04-24 Thread Opensource [Steve Twiss]
On 17 April 2015 15:24 Steve Twiss wrote. > Subject: [PATCH V1 1/6] mfd: da9062: DA9062 MFD core driver > From: S Twiss > > Add MFD core driver support for DA9062 > > Signed-off-by: Steve Twiss > > --- > > This patch applies against linux-next and v4.0 > > drivers/mfd/Kconfig

RE: [PATCH V1 2/6] regulator: da9062: DA9062 regulator driver

2015-04-24 Thread Opensource [Steve Twiss]
On 18 April 2015 12:48 Mark Brown wrote: > On Fri, Apr 17, 2015 at 03:23:32PM +0100, S Twiss wrote: > > > +/* Regulator interrupt handlers */ > > +static irqreturn_t da9062_ldo_lim_event(int irq, void *data) > > +{ > > + struct da9062_regulators *regulators = data; > > + struct da9062 *hw =

RE: [RESEND PATCH V2 1/2] input: misc: da9063: OnKey driver

2015-04-24 Thread Opensource [Steve Twiss]
On 18 April 2015 08:55 Paul Bolle wrote: > There's still a license mismatch left (it probably got lost in the noise > when I finally noticed that the header comment mentioned the LGPL in > V1). > > On Fri, 2015-04-17 at 13:03 +0100, S Twiss wrote: > > + * as published by the Free Software Foundat

RE: [RESEND PATCH V2 1/2] input: misc: da9063: OnKey driver

2015-04-24 Thread Opensource [Steve Twiss]
On 17 April 2015 17:16 Dmitry Torokhov wrote > On Fri, Apr 17, 2015 at 01:03:20PM +0100, S Twiss wrote: > > From: Steve Twiss > > > > Add OnKey driver support for DA9063 > > > > Isn't this almost to the letter identical to da9062 that I just looked > at? Please find a way to not make a brand new

RE: [PATCH V1 2/2] devicetree: Add bindings for DA9063 OnKey

2015-04-09 Thread Opensource [Steve Twiss]
On 09 April 2015 10:22 Lee Jones wrote > > From: Steve Twiss > What format is this? Why aren't you using `git send-email`? I am using a git format-patch to generate the patches but our in-house IT department complications disallow the use of git send-email. > > This patch is dependent on PATCH

RE: [PATCH V1 1/2] input: misc: da9063: OnKey driver

2015-04-09 Thread Opensource [Steve Twiss]
On 09 April 2015 09:48 Paul Bolle wrote: > > This patch is dependent on PATCH V1 2/2 > This patch is dependent on PATCH V1 1/2 > Which makes it all rather confusing. It is a bit circular, I'll take that out for the next patch > > +++ b/drivers/input/misc/da9063-onkey.c > > @@ -0,0 +1,227 @@

[PATCH V2] input: misc: da9063: OnKey driver

2014-03-10 Thread Opensource [Steve Twiss]
From: Opensource [Steve Twiss] Add the OnKey driver for DA9063 Plus some minor dependencies: - Addition of "ONKEY" name to OnKey IRQ resource structure; - Bool key_power platform data driver configuration option. Signed-off-by: Opensource [Steve Twiss] --- Checks performed with

RE: [PATCH V1 1/2] mfd: da9063: Linkages for ONKEY support in core files

2014-03-10 Thread Opensource [Steve Twiss]
On 10 March 2014 16:40, Lee Jones wrote: >> From: Opensource [Steve Twiss] >> >> This change adds the name field "ONKEY" to the properties of the >> the OnKey IORESOURCE_IRQ resource structure (part of the mfd_cell >> Onkey resource). >> >> Th

[PATCH V1 2/2] input: misc: da9063: OnKey driver

2014-03-10 Thread Opensource [Steve Twiss]
From: Opensource [Steve Twiss] Add the OnKey driver for DA9063. Signed-off-by: Opensource [Steve Twiss] --- Checks performed with linux-next/next-20140307/scripts/checkpatch.pl da9063-onkey.ctotal: 0 errors, 0 warnings, 209 lines checked Kconfig total: 0 errors

[PATCH V1 0/2] da9063: Support for OnKey

2014-03-10 Thread Opensource [Steve Twiss]
From: Opensource [Steve Twiss] This patch series adds support for the DA9063 OnKey. It has been split into two parts because the OnKey driver requires a minor alteration to the da9063-core.c file and the platform data header file. These parts have been separated out. - Add a new OnKey driver

[PATCH V1 1/2] mfd: da9063: Linkages for ONKEY support in core files

2014-03-10 Thread Opensource [Steve Twiss]
From: Opensource [Steve Twiss] This change adds the name field "ONKEY" to the properties of the the OnKey IORESOURCE_IRQ resource structure (part of the mfd_cell Onkey resource). The addition of bool key_power which will be passed to the onkey driver and allow KEY_POWER support to be

RE: [RFC V1 2/2] input: misc: da9063: OnKey driver

2014-03-08 Thread Opensource [Steve Twiss]
On 07 March 2014 17:46, Dmitry Torokhov wrote: >Hi Steve, > >On Fri, Mar 07, 2014 at 12:37:45PM +, Opensource [Steve Twiss] wrote: >> From: Opensource [Steve Twiss] >> >> Add the OnKey driver for DA9063. >> >> >> Signed-off-by: Opensource [Steve

[RFC V1 2/2] input: misc: da9063: OnKey driver

2014-03-07 Thread Opensource [Steve Twiss]
From: Opensource [Steve Twiss] Add the OnKey driver for DA9063. Signed-off-by: Opensource [Steve Twiss] --- Checks performed with next-20140307/scripts/checkpatch.pl da9063-onkey.ctotal: 0 errors, 0 warnings, 202 lines checked Kconfig total: 0 errors, 11