Re: [PATCH v2] hid: usbhid: hid-core: fix recursive deadlock

Hi Jiri, On Tue, Dec 1, 2015 at 8:36 AM, Jiri Kosina wrote: > On Fri, 20 Nov 2015, Ioan-Adrian Ratiu wrote: > >> The critical section protected by usbhid->lock in hid_ctrl() is too >> big and because of this it causes a recursive deadlock. "Too big" means >> the case statement and the call to hid

Re: drivers/hid/wacom_wac.c:2484: bad if test ?

Oh, boy! It should be: if (features->type>= INTUOSHT && features->type <= BAMBOO_PT) Thank you David for your sharp eyes ;-). Jiri, Can you fix it upstream or do you need a patch from me? Ping On Mon, Nov 16, 2015 at 2:39 PM, Jiri Kosina wrote: > On Mon, 16 Nov 2015, David Binderman wrote:

[PATCH] HID: wacom: Add outbounding area for DTU1141

DTU1141 has an extra 1 mm tablet active outbounding area on each side of the display, same as those recently released DTUs. Signed-off-by: Ping Cheng --- drivers/hid/wacom_wac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid

Re: [PATCH v2] HID: wacom: Call 'wacom_query_tablet_data' only after 'hid_hw_start'

more. But, that's for future. This patch is good to go. > Signed-off-by: Jason Gerecke Reviewed-by: Ping Cheng Ping > --- > Jiri, > > Ping clued me in to the fact that 'wacom_query_tablet_data' hasn't always > been in this problematic location. The offending c

Re: [PATCH 2/3] HID: wacom: Remove useless conditions from 'wacom_query_tablet_data'

re, > we remove the unnecessary CINTIQ_HYBRID and CINTIQ_COMPANION_2 conditions. > > Signed-off-by: Jason Gerecke Reviewed-by: Ping Cheng for this patch and the 3/3 of this set. Ping > --- > drivers/hid/wacom_sys.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH 1/3] HID: wacom: Call 'wacom_query_tablet_data' only after 'hid_hw_start'

call to 'hid_hw_start'. Alternately, we > could have potentially modified 'wacom_hid_set_device_mode' to use > 'hid_hw_raw_reqest'. > > Signed-off-by: Jason Gerecke Nacked-by: Ping Cheng Ping > --- > Jiri, > > Please mark this for stable sin

[PATCH] HID: wacom: fix Intuos wireless report id issue

Intuos Pen in wireless mode does not have the same report id (2) as when it is in USB mode (17). This patch also moves WIRELESS next to REMOTE in type enum so we can group devices with similar features easily. Reported-by: Dale Brewe Tested-by: Dale Brewe Signed-off-by: Ping Cheng

[PATCH 2/2] HID: wacom: Add four new Intuos devices

This series of devices supports both pen and touch. It reports touch data in Bamboo3 format and pen data in Intuos pro format. Signed-off-by: Ping Cheng Tested-By: Aaron Skomra --- drivers/hid/wacom_sys.c | 11 -- drivers/hid/wacom_wac.c | 97

[PATCH 2/2] HID: wacom: Add four new Intuos devices

Signed-off-by: Ping Cheng Tested-By: Aaron Skomra --- drivers/hid/wacom_sys.c | 11 -- drivers/hid/wacom_wac.c | 97 + drivers/hid/wacom_wac.h | 2 + 3 files changed, 82 insertions(+), 28 deletions(-) diff --git a/drivers/hid/wacom_sys.c b

[PATCH 1/2] HID: wacom: Cleanup unsupported device_type for BAMBOO_PT

Not all Bamboo support both pen and touch. Make sure we deal with pen only and touch only devices properly. Signed-off-by: Ping Cheng Tested-By: Aaron Skomra --- drivers/hid/wacom_sys.c | 49 ++--- drivers/hid/wacom_wac.c | 31

[PATCH v3] HID: wacom: retrieve name from HID descriptor for generic devices

ul name is reported. Otherwise, affix its product ID to "Wacom HID". Names from descriptor may contain extra whitespaces. To comfort readers' eyes, we removed those extra whitespaces too. Signed-off-by: Ping Cheng Reviewed-by: Jason Gerecke --- v3: get rid of trailing whitesp

[PATCH v2] HID: wacom: retrieve name from HID descriptor for generic devices

ul name is reported. Otherwise, affix its product ID to "Wacom HID". Signed-off-by: Ping Cheng --- v2: updated with Jason's pid affix and extract whitespace suggestions. --- drivers/hid/wacom_sys.c | 53 +++-- 1 file changed, 42 in

[PATCH 4/4] HID: wacom: remove unused packet lengths

We use generic hid_report_len() to get individual packet length now. Signed-off-by: Ping Cheng --- drivers/hid/wacom_wac.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/hid/wacom_wac.h b/drivers/hid/wacom_wac.h index 4700ac9..f5a5f68 100644 --- a/drivers/hid/wacom_wac.h +++ b

[PATCH 3/4] HID: wacom: move unit and unitExpo initialization to wacom_calculate_res

That is where they belong... Signed-off-by: Ping Cheng --- drivers/hid/wacom_sys.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index ca30eab..855f3b3 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid

[PATCH 2/4] HID: wacom: move all quirks to wacom_setup_device_quirks

It makes probe routine easy to follow. Signed-off-by: Ping Cheng --- drivers/hid/wacom.h | 2 +- drivers/hid/wacom_sys.c | 39 +-- drivers/hid/wacom_wac.c | 30 +- 3 files changed, 31 insertions(+), 40 deletions(-) diff --git

[PATCH 1/4] HID: wacom: retrieve name from HID descriptor for generic devices

ul name is reported. Otherwise, affix its product ID to "Wacom HID". Signed-off-by: Ping Cheng --- drivers/hid/wacom_sys.c | 45 ++--- 1 file changed, 34 insertions(+), 11 deletions(-) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom

Re: [PATCH 0/3] Cleanup to get rid of a static checker warning

On Thu, Apr 2, 2015 at 5:21 AM, Jiri Kosina wrote: > On Fri, 20 Mar 2015, Ping Cheng wrote: > >> Patch e2c7d8877e5c leads to the following Smatch complaint: >> >> drivers/hid/wacom_wac.c:602 wacom_intuos_inout() >> error: we previously assumed 'wacom-&

Re: [PATCH 3/3] Add support for Cintiq 27QHD and 27QHD touch

On Wed, Mar 25, 2015 at 10:57 PM, Peter Hutterer wrote: > On Tue, Jan 27, 2015 at 01:30:03PM -0800, Ping Cheng wrote: >> These devices have accelerometers. To report accelerometer coordinates, >> a new property, INPUT_PROP_ACCELEROMETER, is added. >> >>

[PATCH] HID: wacom: Add support for Cintiq 13HD Touch

Cintiq 13HD Touch is a new display tablet with pen and 10 finger touches. Signed-off-by: Ping Cheng --- Hi Jiri, this patch is based on your for-4.1/wacom branch. drivers/hid/wacom_wac.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid

[PATCH 2/3] HID: wacom: use wacom_wac_finger_count_touches to set touch_down

Counting number of touching fingers by wacom_wac_finger_count_touches so we don't have to count them inside individual routines. Signed-off-by: Ping Cheng --- drivers/hid/wacom_wac.c | 84 +++-- 1 file changed, 33 insertions(+), 51 deletions(-)

[PATCH 3/3] HID: wacom: set stylus_in_proximity before checking touch_down

In wacom_bpt_pen, we checked touch_down before assigning new stylus_in_proximity value. This would cause stylus_in_proximity not updated properly if touch is down before pen is in proximity. Signed-off-by: Ping Cheng --- drivers/hid/wacom_wac.c | 35 --- 1 file

[PATCH 1/3] HID: wacom: remove hardcoded WACOM_QUIRK_MULTI_INPUT

to make the decision. Also, we make it certain that wacom_wac->shared is always created. That is, the driver will not be loaded if it fails to create wacom_wac->shared. Signed-off-by: Ping Cheng --- drivers/hid/wacom_sys.c | 24 +++- drivers/hid/wacom_wac.

[PATCH 0/3] Cleanup to get rid of a static checker warning

fixes a logic order. The patchset is based on Jiri's for-4.0/upstream-fixes branch. Ping Cheng (3): HID: wacom: remove hardcoded WACOM_QUIRK_MULTI_INPUT HID: wacom: use wacom_wac_finger_count_touches to set touch_down HID: wacom: set stylus_in_proximity before checking touch_down drive

Re: HID: wacom: check for wacom->shared before following the pointer

On Thu, Mar 19, 2015 at 9:06 AM, Benjamin Tissoires wrote: > Hi Dan, > > On Mar 19 2015 or thereabouts, Dan Carpenter wrote: >> Hello Benjamin Tissoires, >> >> This is a semi-automatic email about new static checker warnings. >> >> The patch e2c7d8877e5c: "HID: wacom: check for wacom->shared befor

Re: [PATCH 1/7] HID: wacom: Move handling of Intuos status packets to seperate function

case BAMBOO_PAD: > diff --git a/drivers/hid/wacom_wac.h b/drivers/hid/wacom_wac.h > index a3d0828..ee6a545 100644 > --- a/drivers/hid/wacom_wac.h > +++ b/drivers/hid/wacom_wac.h > @@ -71,6 +71,7 @@ > #define WACOM_REPORT_USB 192 > #define WACOM_REPORT_BPAD_PEN

Re: [PATCH] HID: wacom: check for wacom->shared before following the pointer

On Thu, Mar 5, 2015 at 2:36 PM, Benjamin Tissoires wrote: > 486b908 (HID: wacom: do not send pen events before touch is up/forced out) > introduces a kernel oops when plugging a tablet without touch. Thank you for the catch. You must have tried an Intuos 4 or earlier model. WACOM_QUIRK_MULTI_INPU

Re: [PATCH 0/2] Cleanup and fix touch_down implementation

On Fri, Feb 27, 2015 at 12:18 PM, Jiri Kosina wrote: > On Fri, 27 Feb 2015, Ping Cheng wrote: > >> >> before sending pen events. This idea has been implemented for >> >> Tablet PCs. But other tablets that support both pen and touch are >> >> not f

Re: [PATCH 0/2] Cleanup and fix touch_down implementation

On Thu, Feb 26, 2015 at 11:38 PM, Jiri Kosina wrote: > On Fri, 20 Feb 2015, Ping Cheng wrote: > >> Hi Jiri, >> >> This set is based on your for-3.20/upstream-fixes branch. >> >> If pen comes in proximity while touch is down, we force touch up >> bef

Re: [PATCH v3 2/2] HID: wacom: add full support of the Wacom Bamboo PAD

> > Tested-by: Josep Sanchez Ferreres > Signed-off-by: Benjamin Tissoires Acked-by: Ping Cheng for the series. Cheers, Ping > --- > changes in v3: > - store touch_down information to not send pen events before the touch has > been > released > >

Re: [PATCH v2 2/2] HID: wacom: add full support of the Wacom Bamboo PAD

On Wed, Feb 25, 2015 at 8:43 AM, Benjamin Tissoires wrote: > The stylus of this device works just fine out of the box. > The touch is seen by default as a mouse with relative events and some > gestures. > The wireless and the wired version have slightly different firmwares, but > the debug mode 2

[PATCH 2/2] HID: wacom: rely on actual touch down count to decide touch_down

touch_down. Signed-off-by: Ping Cheng --- drivers/hid/wacom_wac.c | 75 - 1 file changed, 43 insertions(+), 32 deletions(-) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index 69827c9..cf76741 100644 --- a/drivers/hid/wacom_wac.c

[PATCH 0/2] Cleanup and fix touch_down implementation

Hi Jiri, This set is based on your for-3.20/upstream-fixes branch. If pen comes in proximity while touch is down, we force touch up before sending pen events. This idea has been implemented for Tablet PCs. But other tablets that support both pen and touch are not fully considered. Ping Cheng (2

[PATCH 1/2] HID: wacom: do not send pen events before touch is up/forced out

. Signed-off-by: Ping Cheng --- drivers/hid/wacom_wac.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index 046351c..69827c9 100644 --- a/drivers/hid/wacom_wac.c +++ b/drivers/hid/wacom_wac.c @@ -554,6 +554,9 @@ static int wacom_intuos_inout

Re: [PATCH] HID: wacom: do not directly use input_mt_report_pointer_emulation

this driver, it is better to > use input_mt_sync_frame(). It is sensible to me, except I think you meant input_mt_slot() instead of input_mt_assign_slot(). > Signed-off-by: Benjamin Tissoires Reviewed-by: Ping Cheng Ping > --- > drivers/hid/wacom_wac.c | 10 +- > 1 fi

[PATCH v2] Add missing ABS_MISC event and feature declaration for 27QHD

27QHD has the same x_min/y_min (WACOM_CINTIQ_OFFSET) as other Cintiqs. ABS_MISC event is required for PAD packet to work properly with xf86-input-wacom. Signed-off-by: Ping Cheng --- v2: v1 updated the wrong line for features_0x32A. --- drivers/hid/wacom_wac.c | 11 --- 1 file changed

[PATCH] Add missing ABS_MISC event and feature declaration for 27QHD

27QHD has the same x_min/y_min (WACOM_CINTIQ_OFFSET) as other Cintiqs. ABS_MISC event is required for PAD packet to work properly with xf86-input-wacom. Signed-off-by: Ping Cheng --- drivers/hid/wacom_wac.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/hid

[PATCH 1/3] Make sure touch arbitration is applied consistently across devices

imity before sending touch events. This patch fixes those issues. Signed-off-by: Ping Cheng --- v2: added commit comments as reqested by Jiri. No code update. --- drivers/hid/wacom_wac.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/hid/wacom_wac.c b/driver

[PATCH 3/3] Add support for Cintiq 27QHD and 27QHD touch

These devices have accelerometers. To report accelerometer coordinates, a new property, INPUT_PROP_ACCELEROMETER, is added. Signed-off-by: Ping Cheng --- drivers/hid/wacom_sys.c| 3 ++ drivers/hid/wacom_wac.c| 87 ++ drivers/hid/wacom_wac.h

[PATCH 2/3] Consolidate input capability settings for pen and touch

After PAD moved to its own interface, there were duplicated statements in wacom_setup_pentouch_input_capabilities. Merge them together to reduce future maintenance effort. Signed-off-by: Ping Cheng --- drivers/hid/wacom_wac.c | 67 - 1 file

[PATCH 1/3] Make sure touch arbitration is applied consistently across devices

Signed-off-by: Ping Cheng --- drivers/hid/wacom_wac.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index f886149..6d490f6 100644 --- a/drivers/hid/wacom_wac.c +++ b/drivers/hid/wacom_wac.c @@ -1042,7 +1042,7 @@ static

[PATCH 2/2] Report In Range event according to the spec

rejection on both pen and touch enabled devices. While exiting, it means the tool has reached its maximum detectable distance. Signed-off-by: Ping Cheng --- v2: Updated typos in commit comments as pointed out by Bastien Nocera. --- drivers/hid/wacom_wac.c | 15 --- drivers/hid

[PATCH 1/2] Process invalid Cintiq and Intuos data in wacom_intuos_inout

: Ping Cheng --- v2: Added commit comments as suggested by Jiri Kosina. --- drivers/hid/wacom_wac.c | 50 + 1 file changed, 26 insertions(+), 24 deletions(-) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index 596a6fb5..5276689

[PATCH 2/2] Report In Range event according to the spec

rejection on both pen and touch enabled devices. While exiting, it means the tool has reached its maximum detectable distance. Signed-off-by: Ping Cheng --- drivers/hid/wacom_wac.c | 15 --- drivers/hid/wacom_wac.h | 1 + 2 files changed, 9 insertions(+), 7 deletions(-) diff --git

[PATCH 1/2] Process invalid Cintiq and Intuos data in wacom_intuos_inout

Signed-off-by: Ping Cheng --- drivers/hid/wacom_wac.c | 50 + 1 file changed, 26 insertions(+), 24 deletions(-) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index 596a6fb5..4ccf622 100644 --- a/drivers/hid/wacom_wac.c +++ b

Re: [PATCH] hid: Initialize battery_no to -1 & correct its format string

Hi Benjamin, The relevant code was introduced by d70420b914c98a3758674c6e9858810e0ab4ea30. Can you take a look and let us know if Aniroop's patch fits your original thought or not? Thanks, Ping On Tue, Jan 6, 2015 at 6:32 AM, Aniroop Mathur wrote: > Dear Mr. Jason and Mr. Ping, > > Please upda

[PATCH 2/2] HID: wacom - Update maximum X/Y accounding to outbound offset

Defined outbound offset for DTU and Cintiq. But didn't update the relevant maximum values. Oops... Signed-off-by: Ping Cheng --- drivers/hid/wacom_wac.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c

[PATCH 1/2] HID: wacom - Add support for DTU-1031X

Signed-off-by: Ping Cheng --- drivers/hid/wacom_wac.c | 7 +++ drivers/hid/wacom_wac.h | 1 + 2 files changed, 8 insertions(+) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index a8a19a5..b65e0d7 100644 --- a/drivers/hid/wacom_wac.c +++ b/drivers/hid/wacom_wac.c @@ -1847,6

[PATCH] HID: wacom - add defines for new Cintiq and DTU outbound tracking

There are screen to tablet offsets for newer Cintiq and DTU models. These offsets serve as outbound tracking for those display tablets. Use defines instead of hardcoded numbers for the offsets. Signed-off-by: Ping Cheng --- drivers/hid/wacom_wac.c | 37 ++--- 1

Re: [PATCH] HID: wacom - PAD is independent with pen/touch

On Tue, Nov 25, 2014 at 11:56 AM, Jiri Kosina wrote: > On Tue, 25 Nov 2014, Ping Cheng wrote: > >> Please don't forget to merge this patch. It fixes a bad pointer issue... > > Hi Ping, > > yes, it's in my queue for this evening or tomorrow. Thank you. > I

Re: [PATCH] HID: wacom - PAD is independent with pen/touch

Hi Jiri, Please don't forget to merge this patch. It fixes a bad pointer issue... Thanks, Ping On Thu, Nov 20, 2014 at 4:31 PM, Ping Cheng wrote: > PAD can be on pen interface (Intuos Pro and Cintiq series) or touch > interface (Bamboo PT and Intuos PT series) or its own interfac

Re: [PATCH 1/2] HID: wacom: Report ABS_TILT_{X,Y} as signed values

hout needing hardware-specific knowledge. The xf86-input-wacom driver > was updated to support signed tilt values in late-2012 (2f2acec). > > Signed-off-by: Jason Gerecke Reviewed-by: Ping Cheng for the series. Thanks Jason for the patches, Ping > --- > drivers/hid/wacom_wac.c | 16

[PATCH] HID: wacom - PAD is independent with pen/touch

PAD can be on pen interface (Intuos Pro and Cintiq series) or touch interface (Bamboo PT and Intuos PT series) or its own interface (Bamboo pen-only and Intuos Pen M/S). We need to mark it independently. Signed-off-by: Ping Cheng Reviewed-by: Benjamin Tissoires --- drivers/hid/wacom_sys.c | 8

[PATCH 3/3] HID: wacom - Bamboo pen-only tablet does not support PAD

Bamboo models do not support HID_DG_CONTACTMAX. Plus, Bamboo pen-only has touch descriptor. This leads to some complications in the code. This patch also fixes duplicated PAD interfeaces for Intuos Pen models. Signed-off-by: Ping Cheng Reviewed-by: Benjamin Tissoires --- v2: updated with

[PATCH 2/3] HID: wacom - Cleanup input_capabilities for Graphire 4 and Bamboo Fun

Graphire 4 only has two tablet buttons; Bamboo Fun touch ring is only for PAD. Signed-off-by: Ping Cheng Reviewed-by: Benjamin Tissoires --- drivers/hid/wacom_wac.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index 372d890..792569c

[PATCH 1/3] HID: wacom - return ENODEV for failed wacom_setup_pad_input_capabilities

ENODEV indicates no device is added. Hence, the associated pad input device is simply freed. Signed-off-by: Ping Cheng Reviewed-by: Benjamin Tissoires --- drivers/hid/wacom_wac.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid

Re: [PATCH] HID: wacom - Bamboo pen only tablet does not support PAD

Hi Benjamin, Thank you for the review. An updated version will be posted soon. Let me know if you need us to capture data from more devices for your testing. Cheers, Ping On Mon, Nov 17, 2014 at 2:38 PM, Benjamin Tissoires wrote: > Hi Ping, > > On Mon, Nov 17, 2014 at 4:45 PM, P

[PATCH] HID: wacom - Bamboo pen only tablet does not support PAD

Bamboo models do not support HID_DG_CONTACTMAX. We should not rely on that description to decide touch_max for them. Plus, no Bamboo device supports single touch. Signed-off-by: Ping Cheng --- drivers/hid/wacom_sys.c | 4 ++-- drivers/hid/wacom_wac.c | 30 ++ 2

[PATCH] HID: wacom - Add support for Intuos Pen Medium

Signed-off-by: Ping Cheng --- drivers/hid/wacom_wac.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index 586b240..8ce7fab 100644 --- a/drivers/hid/wacom_wac.c +++ b/drivers/hid/wacom_wac.c @@ -2878,6 +2878,10 @@ static const struct

[PATCH] HID: wacom - make sure touch_input is valid before using it

yakov http://www.spinics.net/lists/linux-input/msg33971.html Reviewed-by: Hans Petter Selasky Tested-by: Denis Akiyakov Signed-off-by: Ping Cheng --- drivers/hid/wacom_wac.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_

Re: Problems with Wacom Intuos PT M (CTH680) on FreeBSD

On Tue, Nov 4, 2014 at 10:06 AM, Dmitry Torokhov wrote: > On Tue, Nov 04, 2014 at 09:38:38AM -0800, Ping Cheng wrote: >> Hi Dmitry, >> >> On Tue, Nov 4, 2014 at 12:08 AM, Dmitry Torokhov >> wrote: >> > On Sat, Nov 01, 2014 at 08:40:19AM +0100, Hans Petter Se

Re: Problems with Wacom Intuos PT M (CTH680) on FreeBSD

Hi Dmitry, On Tue, Nov 4, 2014 at 12:08 AM, Dmitry Torokhov wrote: > On Sat, Nov 01, 2014 at 08:40:19AM +0100, Hans Petter Selasky wrote: >> On 11/01/14 00:27, Ping Cheng wrote: >> >If touch_input is NULL on FreeBSD, you need to figure out the root >> >cause. Checking

Re: Problems with Wacom Intuos PT M (CTH680) on FreeBSD

Hi Hans, On Wed, Oct 22, 2014 at 10:54 PM, Hans Petter Selasky wrote: > > On 10/23/14 06:54, Denis Akiyakov wrote: >> >> On 22.10.2014 05:33, Dmitry Torokhov wrote: >>> >>> Hi Denis, >>> >>> On Sat, Oct 18, 2014 at 05:56:48PM +0700, Denis Akiyakov wrote: Hello, I'm using FreeB

Fwd: [PATCH] HID: input: Fix TransducerSerialNumber implementation

; the driver to crash when a tablet with this usage is connected. Secondly, > the call to 'set_bit' causes MSC_PULSELED to be sent instead of the > expected MSC_SERIAL. This commit addreses both issues. > > Signed-off-by: Jason Gerecke Reviewed-by: Ping Cheng

Fwd: [PATCH] HID: wacom: make the WL connection friendly for the desktop

and was rejected, we may have to keep clients confused. With that said, the patch is > > This way, tablets connected through WL can be used from the user point of > view in the same way they are used while connected through wire. > > Signed-off-by: Benjamin Tissoires Reviewed-by:

[PATCH 4/4 v2] HID: wacom - enable LED support for Wireless Intuos5/Pro

And associate all LED/OLED to PAD device Signed-off-by: Ping Cheng Tested-by: Benjamin Tissoires --- drivers/hid/wacom_sys.c | 52 + 1 file changed, 35 insertions(+), 17 deletions(-) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c

[PATCH 3/4 v2] HID: wacom - remove report_id from wacom_get_report interface

It is assigned in buf[0] anyway. Signed-off-by: Ping Cheng Reviewed-by: Benjamin Tissoires --- drivers/hid/wacom_sys.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index 4a7b9c8..f911f97 100644 --- a/drivers/hid

[PATCH 2/4 v2] HID: wacom - Clean up of sysfs

changed to scnprintf(buf, PAGE_SIZE, ... ) as suggested in sysfs.txt for show functions Signed-off-by: Paul A. Tessier Signed-Off-by: Ping Cheng Tested-by: Benjamin Tissoires --- v2: Move actual permission to patch one. drivers/hid/wacom_sys.c | 12 ++-- 1 file changed, 10 insertions

[PATCH 1/4 v2] HID: wacom - Add default permission defines for sysfs attributes

RW : ug=rw,o=r WO : ug=w And enabled reading relavent sysfs attributes. Signed-off-by: Paul A. Tessier Signed-Off-by: Ping Cheng Tested-by: Benjamin Tissoires --- v2: Integrate actual permission with defines. drivers/hid/wacom_sys.c | 11 +++ 1 file changed, 7 insertions(+), 4

[PATCH 4/4] HID: wacom - enable LED support for Wireless Intuos5/Pro

And associate all LED/OLED to PAD device Signed-off-by: Ping Cheng Tested-by: Benjamin Tissoires --- drivers/hid/wacom_sys.c | 52 + 1 file changed, 35 insertions(+), 17 deletions(-) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c

[PATCH 3/4] HID: wacom - remove report_id from wacom_get_report interface

It is assigned in buf[0] anyway. Signed-off-by: Ping Cheng Reviewed-by: Benjamin Tissoires --- drivers/hid/wacom_sys.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index 4a7b9c8..f911f97 100644 --- a/drivers/hid

[PATCH 2/4] HID: wacom - enable reading relavent sysfs attributes

changed to scnprintf(buf, PAGE_SIZE, ... ) as suggested in sysfs.txt for show functions Signed-off-by: Paul A. Tessier Signed-Off-by: Ping Cheng Tested-by: Benjamin Tissoires --- drivers/hid/wacom_sys.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a

[PATCH 1/4] HID: wacom - Add default permission defines for sysfs attributes

RW : ug=rw,o=r WO : ug=w Signed-off-by: Paul A. Tessier Signed-Off-by: Ping Cheng Tested-by: Benjamin Tissoires --- drivers/hid/wacom_sys.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index f0db7ec..2ce102b 100644 --- a/drivers/hid

Re: [PATCH v2] Input - wacom: update the ABI doc according to latest changes

. > For OLEDs, Bluetooth devices handle only 1-bit images instead of 4 for USB. > The documentation has been updated to match this. > > Signed-off-by: Benjamin Tissoires Reviewed-by: Ping Cheng Ping > Documentation/ABI/testing/sysfs-driver-wacom | 70 > +++---

Re: [PATCH] Input - wacom: update the ABI doc according to latest changes

On Tue, Aug 5, 2014 at 2:34 PM, Benjamin Tissoires wrote: > Hi Ping, > > On Aug 05 2014 or thereabouts, Ping Cheng wrote: >> Thank you Benjamin for updating the ABI docs. My comments are inline. >> >> With those lines updated, this patch is: >> >&

Re: [PATCH] Input - wacom: update the ABI doc according to latest changes

Thank you Benjamin for updating the ABI docs. My comments are inline. With those lines updated, this patch is: Reviewed-by: Ping Cheng Cheers, Ping On Tue, Aug 5, 2014 at 8:34 AM, Benjamin Tissoires wrote: > Now the devices show up under hid no matter the connection. So update the >

Re: [PATCH v3 4/7] Input - wacom: Check for bluetooth protocol while setting OLEDs

t; + if (hdev->bus == BUS_BLUETOOTH) { >> + len = 256; >> + xfer_id = WAC_CMD_ICON_BT_XFER; >> + } else { >> + len = 1024; >> + xfer_id = WAC_CMD_ICON_XFER; >> + } >> + >> + if (count != len) >>

Re: [PATCH v2 07/10] Input - wacom: handle Graphire BT tablets in wacom.ko

incrementally - the patch is still sound as far as I > am concerned. I will wait a bit for other to chime in with comments or > acks before applying this series. Thank you Benjamin and Dmitry for your support. The whole series is: Acked-by: Ping Cheng Cheers, Ping -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Input - wacom: split out the pad device for the wireless receiver

ency, the function wacom_register_input() is renamed into > wacom_register_input(). wacom_register_inputs(). > > Signed-off-by: Benjamin Tissoires Reviewed-by: Ping Cheng . Ping > --- > > Hi, > > I noticed this afternoon that the "pad-in-a-separate-device" was missing the >

Re: [PATCH 1/5] Input - wacom: create a separate input device for pads

pad. Unless you plan to use other means to tell userland those events are from PAD tool, ABS_MISC is necessary and is a reasonable way to group PAD events. So, I do not think it is for backward compatibility. It is there to stay. With that said, the whole patchset is > Signed-off-by:

Re: [PATCH] Input - wacom: put a flag when the led are initialized

Hi Benjamin, On Monday, June 16, 2014, Benjamin Tissoires wrote: > > Hi Ping, > > On Jun 13 2014 or thereabouts, Ping Cheng wrote: > > Hi Benjamin, > > > > On Fri, Jun 13, 2014 at 1:29 PM, Benjamin Tissoires > > wrote: > > > This solves a bug with t

Re: [PATCH] Input - wacom: put a flag when the led are initialized

ed/disconnected. > Signed-off-by: Benjamin Tissoires Thank you for your support. But, sorry NAKed-by: Ping Cheng Ping > --- > drivers/input/tablet/wacom.h | 1 + > drivers/input/tablet/wacom_sys.c | 6 ++ > 2 files changed, 7 insertions(+) > > diff --git a/drivers/inp

[PATCH] HID: input - Add two new usages for digitizer

-off-by: Ping Cheng Reviewed-by: Benjamin Tissoires --- drivers/hid/hid-debug.c | 2 ++ drivers/hid/hid-input.c | 5 + include/linux/hid.h | 7 ++- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c index 53b771d..f299f42

[PATCH] Input: wacom - cleanup multitouch code when touch_max is 2

Historically we dealt with touch_max equals to 2 differently from other MT devices. Now we use input_mt_*() to process all MT events, as long as touch_max is greater than 1. So, there is no need to take (touch_max == 2) as a special case any more. Signed-off-by: Ping Cheng --- drivers/input

Re: [PATCH 2/3] Input: wacom - Don't declare ABS_X/Y for multitouch

On Thu, May 29, 2014 at 12:08 AM, Dmitry Torokhov wrote: > On Tue, May 27, 2014 at 04:18:07PM -0700, Ping Cheng wrote: >> We use ABS_MT_POSITION_X/Y for multitouch (touch_max > 1) events now. >> No need to declare ABS_X/Y for touch_max == 2 any more. > > This will make leg

[PATCH 3/3] Input: wacom - process outbound for newer Cintiqs

New Cintiq tablets have a 200 tablet counts outside of screen area. Add x/y_min for ABS_X/Y to pass this information to userland. Signed-off-by: Ping Cheng Reviewed-by: Jason Gerecke Tested-by: Jason Gerecke --- drivers/input/tablet/wacom_wac.c | 44

[PATCH 2/3] Input: wacom - Don't declare ABS_X/Y for multitouch

We use ABS_MT_POSITION_X/Y for multitouch (touch_max > 1) events now. No need to declare ABS_X/Y for touch_max == 2 any more. Signed-off-by: Ping Cheng Reviewed-by: Jason Gerecke Tested-by: Jason Gerecke --- drivers/input/tablet/wacom_wac.c | 6 +++--- 1 file changed, 3 insertions(+)

[PATCH 1/3] Input: wacom - set stylus_in_proximity when pen is in range

Signed-off-by: Ping Cheng Reviewed-by: Jason Gerecke Tested-by: Jason Gerecke --- drivers/input/tablet/wacom_wac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c index 24c0733..c98e51c 100644 --- a/drivers/input/tablet

Re: [PATCH 1/2] Input: wacom: Add support for 0x116 sensor on Win8 Panasonic CF-H2

= le16_to_cpup((__le16 *)&data[5]); Above two lines should use get_unaligned_le16() instead. wacom_mt_touch() needs some cleanup too. Except that, the whole patchset looks good to me. Reviewed-by: Ping Cheng Ping > } else { > prox = data[1]

Fwd: [PATCH 1/4] Input: wacom: Use full 32-bit HID Usage value in switch statement

. Ping On Fri, Apr 11, 2014 at 2:23 PM, Ping Cheng wrote: > Dmitry, > > This patchset has been outstanding for more than 2 months. Can you merge > them upstream? > > Thank you. > > Ping > > > On Tue, Mar 4, 2014 at 1:10 PM, Ping Cheng wrote: >> >> Hi D

[PATCH 2/2] input: wacom - unify outbound support for Cintiq and Intuos series

Signed-off-by: Ping Cheng --- drivers/input/tablet/wacom_wac.c | 88 drivers/input/tablet/wacom_wac.h | 4 +- 2 files changed, 75 insertions(+), 17 deletions(-) diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c index

[PATCH 1/2] input: wacom - missed the last bit of expresskey for DTU-1031

Signed-off-by: Ping Cheng --- drivers/input/tablet/wacom_wac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c index 05f371d..3d094c9 100644 --- a/drivers/input/tablet/wacom_wac.c +++ b/drivers/input/tablet

Re: [PATCH 1/4] Input: wacom: Use full 32-bit HID Usage value in switch statement

Hi Dmitry, This patchset has been Tested-by: Aaron Skomra and Reviewed-by: Carl Worth . I think they are ready to go upstream. Do you have other comments? Ping On Thu, Feb 27, 2014 at 10:37 AM, Aaron Armstrong Skomra wrote: > On Thu, Jan 30, 2014 at 10:48 AM, Jason Gerecke wrote: >> >> A HID

Re: wacom: Fixes for stylus pressure values for Thinkpad Yoga

Hi Carl, Thank you for the heads up. I believe Jason's patchset 4 of 4 (http://www.spinics.net/lists/linux-input/msg29435.html) fixed the issue for your device and for other's. The patch was submitted last month. If you can test the set on your device and give us a Tested-by here, it will help Dmi

[PATCH v2] Input: wacom - add support for DTU-1031

Signed-off-by: Ping Cheng --- v2: use get_unaligned_be16 instead of be16_to_cpup for unaligned data ([3] and [5]) drivers/input/tablet/wacom_wac.c | 76 +++- drivers/input/tablet/wacom_wac.h | 6 +++- 2 files changed, 80 insertions(+), 2 deletions

[PATCH] Input: wacom - add support for DTU-1031

Signed-off-by: Ping Cheng --- drivers/input/tablet/wacom_wac.c | 80 +++- drivers/input/tablet/wacom_wac.h | 6 ++- 2 files changed, 84 insertions(+), 2 deletions(-) diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c index

[PATCH] Input: wacom - Fix wacom->shared guards for dual input devices

features->quirks can have multiple bits set. For dual input, we only need to check WACOM_QUIRK_MULTI_INPUT. Reviewed-by: Jason Gerecke Signed-off-by: Ping Cheng --- drivers/input/tablet/wacom_wac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/tab

[PATCH v4] Input: wacom - add SW_MUTE_DEVICE to include/uapi/linux/input.h

Signed-off-by: Ping Cheng --- v4: Changed SW_TOUCH to SW_MUTE_DEVICE as suggested by Dmitry. --- drivers/input/tablet/wacom_sys.c | 12 drivers/input/tablet/wacom_wac.c | 30 +++--- drivers/input/tablet/wacom_wac.h | 5 + include/uapi/linux/input.h

Re: [PATCH 4/4 v3] Input: wacom - add SW_TOUCH to include/uapi/linux/input.h

On Mon, Nov 25, 2013 at 6:59 PM, Dmitry Torokhov wrote: > Hi Ping, > > On Fri, Nov 15, 2013 at 12:00:02PM -0800, Ping Cheng wrote: >>> @@ -856,6 +856,7 @@ struct input_keymap_entry { >> #define SW_FRONT_PROXIMITY 0x0b /* set = front proximity sensor active */ &g

Re: [PATCH 4/4 v3] Input: wacom - add SW_TOUCH to include/uapi/linux/input.h

On Fri, Nov 15, 2013 at 1:28 PM, Chris Bagwell wrote: > Thanks for breaking out... Its easier to review now as well. > > Small question below. > > On Fri, Nov 15, 2013 at 2:00 PM, Ping Cheng wrote: >> New Intuos series models added a hardware switch to turn touch >>

Re: [PATCH 4/4 v3] Input: wacom - add SW_TOUCH to include/uapi/linux/input.h

On Fri, Nov 15, 2013 at 1:33 PM, Chris Bagwell wrote: > On Fri, Nov 15, 2013 at 2:00 PM, Ping Cheng wrote: >> New Intuos series models added a hardware switch to turn touch >> data on/off. To report the state of the switch, SW_TOUCH >> is added in include/uapi/linux/input.h.

  1   2   >