Re: [PATCH v2] hid: usbhid: hid-core: fix recursive deadlock

Hi Jiri, On Tue, Dec 1, 2015 at 8:36 AM, Jiri Kosina wrote: > On Fri, 20 Nov 2015, Ioan-Adrian Ratiu wrote: > >> The critical section protected by usbhid->lock in hid_ctrl() is too >> big and because of this it causes a recursive deadlock. "Too big" means >> the case statement

Re: drivers/hid/wacom_wac.c:2484: bad if test ?

Oh, boy! It should be: if (features->type>= INTUOSHT && features->type <= BAMBOO_PT) Thank you David for your sharp eyes ;-). Jiri, Can you fix it upstream or do you need a patch from me? Ping On Mon, Nov 16, 2015 at 2:39 PM, Jiri Kosina wrote: > On Mon, 16 Nov 2015,

Re: [PATCH v2] HID: wacom: Call 'wacom_query_tablet_data' only after 'hid_hw_start'

But, that's for future. This patch is good to go. > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> Reviewed-by: Ping Cheng <pi...@wacom.com> Ping > --- > Jiri, > > Ping clued me in to the fact that 'wacom_query_tablet_data' hasn't always > been in this

Re: [PATCH 1/3] HID: wacom: Call 'wacom_query_tablet_data' only after 'hid_hw_start'

_hw_start'. Alternately, we > could have potentially modified 'wacom_hid_set_device_mode' to use > 'hid_hw_raw_reqest'. > > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> Nacked-by: Ping Cheng <pi...@wacom.com> Ping > --- > Jiri, > > Please mark this f

Re: [PATCH 2/3] HID: wacom: Remove useless conditions from 'wacom_query_tablet_data'

nfusion in the future, > we remove the unnecessary CINTIQ_HYBRID and CINTIQ_COMPANION_2 conditions. > > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> Reviewed-by: Ping Cheng <pi...@wacom.com> for this patch and the 3/3 of this set. Ping > --- > drivers/hid/w

[PATCH] HID: wacom: fix Intuos wireless report id issue

<dlbr...@hotmail.com> Signed-off-by: Ping Cheng <pi...@wacom.com> --- drivers/hid/wacom_sys.c | 2 +- drivers/hid/wacom_wac.c | 1 - drivers/hid/wacom_wac.h | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index 125e9

[PATCH 1/2] HID: wacom: Cleanup unsupported device_type for BAMBOO_PT

Not all Bamboo support both pen and touch. Make sure we deal with pen only and touch only devices properly. Signed-off-by: Ping Cheng <pi...@wacom.com> Tested-By: Aaron Skomra <aaron.sko...@wacom.com> --- drivers/hid/wacom_sys.c | 49 ++---

[PATCH 2/2] HID: wacom: Add four new Intuos devices

Signed-off-by: Ping Cheng <pi...@wacom.com> Tested-By: Aaron Skomra <aaron.sko...@wacom.com> --- drivers/hid/wacom_sys.c | 11 -- drivers/hid/wacom_wac.c | 97 + drivers/hid/wacom_wac.h | 2 + 3 files changed, 82 insertions(+),

[PATCH 2/2] HID: wacom: Add four new Intuos devices

This series of devices supports both pen and touch. It reports touch data in Bamboo3 format and pen data in Intuos pro format. Signed-off-by: Ping Cheng <pi...@wacom.com> Tested-By: Aaron Skomra <aaron.sko...@wacom.com> --- drivers/hid/wacom_sys.c | 11 -- drivers/hid/waco

[PATCH v3] HID: wacom: retrieve name from HID descriptor for generic devices

is reported. Otherwise, affix its product ID to Wacom HID. Names from descriptor may contain extra whitespaces. To comfort readers' eyes, we removed those extra whitespaces too. Signed-off-by: Ping Cheng pi...@wacom.com Reviewed-by: Jason Gerecke killert...@gmail.com --- v3: get rid of trailing

[PATCH v2] HID: wacom: retrieve name from HID descriptor for generic devices

is reported. Otherwise, affix its product ID to Wacom HID. Signed-off-by: Ping Cheng pi...@wacom.com --- v2: updated with Jason's pid affix and extract whitespace suggestions. --- drivers/hid/wacom_sys.c | 53 +++-- 1 file changed, 42 insertions(+), 11

[PATCH 2/4] HID: wacom: move all quirks to wacom_setup_device_quirks

It makes probe routine easy to follow. Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom.h | 2 +- drivers/hid/wacom_sys.c | 39 +-- drivers/hid/wacom_wac.c | 30 +- 3 files changed, 31 insertions(+), 40 deletions

[PATCH 1/4] HID: wacom: retrieve name from HID descriptor for generic devices

is reported. Otherwise, affix its product ID to Wacom HID. Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_sys.c | 45 ++--- 1 file changed, 34 insertions(+), 11 deletions(-) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index

[PATCH 3/4] HID: wacom: move unit and unitExpo initialization to wacom_calculate_res

That is where they belong... Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_sys.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index ca30eab..855f3b3 100644 --- a/drivers/hid/wacom_sys.c

[PATCH 4/4] HID: wacom: remove unused packet lengths

We use generic hid_report_len() to get individual packet length now. Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_wac.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/hid/wacom_wac.h b/drivers/hid/wacom_wac.h index 4700ac9..f5a5f68 100644 --- a/drivers/hid

Re: [PATCH 0/3] Cleanup to get rid of a static checker warning

On Thu, Apr 2, 2015 at 5:21 AM, Jiri Kosina jkos...@suse.cz wrote: On Fri, 20 Mar 2015, Ping Cheng wrote: Patch e2c7d8877e5c leads to the following Smatch complaint: drivers/hid/wacom_wac.c:602 wacom_intuos_inout() error: we previously assumed 'wacom-shared' could be null (see

Re: [PATCH 3/3] Add support for Cintiq 27QHD and 27QHD touch

On Wed, Mar 25, 2015 at 10:57 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Jan 27, 2015 at 01:30:03PM -0800, Ping Cheng wrote: These devices have accelerometers. To report accelerometer coordinates, a new property, INPUT_PROP_ACCELEROMETER, is added. Signed-off-by: Ping Cheng pi

[PATCH] HID: wacom: Add support for Cintiq 13HD Touch

Cintiq 13HD Touch is a new display tablet with pen and 10 finger touches. Signed-off-by: Ping Cheng pi...@wacom.com --- Hi Jiri, this patch is based on your for-4.1/wacom branch. drivers/hid/wacom_wac.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/hid/wacom_wac.c b

[PATCH 0/3] Cleanup to get rid of a static checker warning

order. The patchset is based on Jiri's for-4.0/upstream-fixes branch. Ping Cheng (3): HID: wacom: remove hardcoded WACOM_QUIRK_MULTI_INPUT HID: wacom: use wacom_wac_finger_count_touches to set touch_down HID: wacom: set stylus_in_proximity before checking touch_down drivers/hid/wacom_sys.c

[PATCH 2/3] HID: wacom: use wacom_wac_finger_count_touches to set touch_down

Counting number of touching fingers by wacom_wac_finger_count_touches so we don't have to count them inside individual routines. Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_wac.c | 84 +++-- 1 file changed, 33 insertions(+), 51

[PATCH 1/3] HID: wacom: remove hardcoded WACOM_QUIRK_MULTI_INPUT

to make the decision. Also, we make it certain that wacom_wac-shared is always created. That is, the driver will not be loaded if it fails to create wacom_wac-shared. Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_sys.c | 24 +++- drivers/hid/wacom_wac.c | 18

[PATCH 3/3] HID: wacom: set stylus_in_proximity before checking touch_down

In wacom_bpt_pen, we checked touch_down before assigning new stylus_in_proximity value. This would cause stylus_in_proximity not updated properly if touch is down before pen is in proximity. Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_wac.c | 35

Re: [PATCH 1/7] HID: wacom: Move handling of Intuos status packets to seperate function

is used. Do I miss something? Except that, the patchset looks good. Acked-by: Ping Cheng pin...@wacom.com Ping /* device quirks */ #define WACOM_QUIRK_MULTI_INPUT0x0001 -- 2.3.0 -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message

Re: [PATCH] HID: wacom: check for wacom-shared before following the pointer

On Thu, Mar 5, 2015 at 2:36 PM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: 486b908 (HID: wacom: do not send pen events before touch is up/forced out) introduces a kernel oops when plugging a tablet without touch. Thank you for the catch. You must have tried an Intuos 4 or earlier

Re: [PATCH 0/2] Cleanup and fix touch_down implementation

On Thu, Feb 26, 2015 at 11:38 PM, Jiri Kosina jkos...@suse.cz wrote: On Fri, 20 Feb 2015, Ping Cheng wrote: Hi Jiri, This set is based on your for-3.20/upstream-fixes branch. If pen comes in proximity while touch is down, we force touch up before sending pen events. This idea has been

Re: [PATCH 0/2] Cleanup and fix touch_down implementation

On Fri, Feb 27, 2015 at 12:18 PM, Jiri Kosina jkos...@suse.cz wrote: On Fri, 27 Feb 2015, Ping Cheng wrote: before sending pen events. This idea has been implemented for Tablet PCs. But other tablets that support both pen and touch are not fully considered. Ping Cheng (2): HID

Re: [PATCH v3 2/2] HID: wacom: add full support of the Wacom Bamboo PAD

...@est.fib.upc.edu Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Acked-by: Ping Cheng pi...@wacom.com for the series. Cheers, Ping --- changes in v3: - store touch_down information to not send pen events before the touch has been released changes in v2: - re-route the pen

Re: [PATCH v2 2/2] HID: wacom: add full support of the Wacom Bamboo PAD

On Wed, Feb 25, 2015 at 8:43 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: The stylus of this device works just fine out of the box. The touch is seen by default as a mouse with relative events and some gestures. The wireless and the wired version have slightly different

[PATCH 2/2] HID: wacom: rely on actual touch down count to decide touch_down

of touch_down. Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_wac.c | 75 - 1 file changed, 43 insertions(+), 32 deletions(-) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index 69827c9..cf76741 100644 --- a/drivers/hid

[PATCH 0/2] Cleanup and fix touch_down implementation

Hi Jiri, This set is based on your for-3.20/upstream-fixes branch. If pen comes in proximity while touch is down, we force touch up before sending pen events. This idea has been implemented for Tablet PCs. But other tablets that support both pen and touch are not fully considered. Ping Cheng (2

[PATCH 1/2] HID: wacom: do not send pen events before touch is up/forced out

. Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_wac.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index 046351c..69827c9 100644 --- a/drivers/hid/wacom_wac.c +++ b/drivers/hid/wacom_wac.c @@ -554,6 +554,9 @@ static int

Re: [PATCH] HID: wacom: do not directly use input_mt_report_pointer_emulation

input_mt_assign_slot() in this driver, it is better to use input_mt_sync_frame(). It is sensible to me, except I think you meant input_mt_slot() instead of input_mt_assign_slot(). Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Reviewed-by: Ping Cheng pi...@wacom.com Ping --- drivers/hid

[PATCH] Add missing ABS_MISC event and feature declaration for 27QHD

27QHD has the same x_min/y_min (WACOM_CINTIQ_OFFSET) as other Cintiqs. ABS_MISC event is required for PAD packet to work properly with xf86-input-wacom. Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_wac.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH 1/3] Make sure touch arbitration is applied consistently across devices

before sending touch events. This patch fixes those issues. Signed-off-by: Ping Cheng pi...@wacom.com --- v2: added commit comments as reqested by Jiri. No code update. --- drivers/hid/wacom_wac.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/hid/wacom_wac.c b

[PATCH 1/3] Make sure touch arbitration is applied consistently across devices

Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_wac.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index f886149..6d490f6 100644 --- a/drivers/hid/wacom_wac.c +++ b/drivers/hid/wacom_wac.c @@ -1042,7

[PATCH 2/2] Report In Range event according to the spec

rejection on both pen and touch enabled devices. While exiting, it means the tool has reached its maximum detectable distance. Signed-off-by: Ping Cheng pi...@wacom.com --- v2: Updated typos in commit comments as pointed out by Bastien Nocera. --- drivers/hid/wacom_wac.c | 15

[PATCH 1/2] Process invalid Cintiq and Intuos data in wacom_intuos_inout

-by: Ping Cheng pi...@wacom.com --- v2: Added commit comments as suggested by Jiri Kosina. --- drivers/hid/wacom_wac.c | 50 + 1 file changed, 26 insertions(+), 24 deletions(-) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index

[PATCH 1/2] Process invalid Cintiq and Intuos data in wacom_intuos_inout

Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_wac.c | 50 + 1 file changed, 26 insertions(+), 24 deletions(-) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index 596a6fb5..4ccf622 100644 --- a/drivers/hid

[PATCH 2/2] Report In Range event according to the spec

rejection on both pen and touch enabled devices. While exiting, it means the tool has reached its maximum detectable distance. Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_wac.c | 15 --- drivers/hid/wacom_wac.h | 1 + 2 files changed, 9 insertions(+), 7 deletions

Re: [PATCH] hid: Initialize battery_no to -1 correct its format string

Hi Benjamin, The relevant code was introduced by d70420b914c98a3758674c6e9858810e0ab4ea30. Can you take a look and let us know if Aniroop's patch fits your original thought or not? Thanks, Ping On Tue, Jan 6, 2015 at 6:32 AM, Aniroop Mathur aniroop.mat...@gmail.com wrote: Dear Mr. Jason and

[PATCH 1/2] HID: wacom - Add support for DTU-1031X

Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_wac.c | 7 +++ drivers/hid/wacom_wac.h | 1 + 2 files changed, 8 insertions(+) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index a8a19a5..b65e0d7 100644 --- a/drivers/hid/wacom_wac.c +++ b/drivers/hid

[PATCH 2/2] HID: wacom - Update maximum X/Y accounding to outbound offset

Defined outbound offset for DTU and Cintiq. But didn't update the relevant maximum values. Oops... Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_wac.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid

[PATCH] HID: wacom - add defines for new Cintiq and DTU outbound tracking

There are screen to tablet offsets for newer Cintiq and DTU models. These offsets serve as outbound tracking for those display tablets. Use defines instead of hardcoded numbers for the offsets. Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_wac.c | 37

Re: [PATCH] HID: wacom - PAD is independent with pen/touch

Hi Jiri, Please don't forget to merge this patch. It fixes a bad pointer issue... Thanks, Ping On Thu, Nov 20, 2014 at 4:31 PM, Ping Cheng pingli...@gmail.com wrote: PAD can be on pen interface (Intuos Pro and Cintiq series) or touch interface (Bamboo PT and Intuos PT series) or its own

Re: [PATCH] HID: wacom - PAD is independent with pen/touch

On Tue, Nov 25, 2014 at 11:56 AM, Jiri Kosina jkos...@suse.cz wrote: On Tue, 25 Nov 2014, Ping Cheng wrote: Please don't forget to merge this patch. It fixes a bad pointer issue... Hi Ping, yes, it's in my queue for this evening or tomorrow. Thank you. I will also add Cc: stable, ok

Re: [PATCH 1/2] HID: wacom: Report ABS_TILT_{X,Y} as signed values

without needing hardware-specific knowledge. The xf86-input-wacom driver was updated to support signed tilt values in late-2012 (2f2acec). Signed-off-by: Jason Gerecke killert...@gmail.com Reviewed-by: Ping Cheng pi...@wacom.com for the series. Thanks Jason for the patches, Ping --- drivers/hid

[PATCH] HID: wacom - PAD is independent with pen/touch

PAD can be on pen interface (Intuos Pro and Cintiq series) or touch interface (Bamboo PT and Intuos PT series) or its own interface (Bamboo pen-only and Intuos Pen M/S). We need to mark it independently. Signed-off-by: Ping Cheng pi...@wacom.com Reviewed-by: Benjamin Tissoires benjamin.tissoi

[PATCH 2/3] HID: wacom - Cleanup input_capabilities for Graphire 4 and Bamboo Fun

Graphire 4 only has two tablet buttons; Bamboo Fun touch ring is only for PAD. Signed-off-by: Ping Cheng pi...@wacom.com Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/wacom_wac.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/hid/wacom_wac.c b

[PATCH 3/3] HID: wacom - Bamboo pen-only tablet does not support PAD

Bamboo models do not support HID_DG_CONTACTMAX. Plus, Bamboo pen-only has touch descriptor. This leads to some complications in the code. This patch also fixes duplicated PAD interfeaces for Intuos Pen models. Signed-off-by: Ping Cheng pi...@wacom.com Reviewed-by: Benjamin Tissoires

[PATCH] HID: wacom - Bamboo pen only tablet does not support PAD

Bamboo models do not support HID_DG_CONTACTMAX. We should not rely on that description to decide touch_max for them. Plus, no Bamboo device supports single touch. Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_sys.c | 4 ++-- drivers/hid/wacom_wac.c | 30

Re: [PATCH] HID: wacom - Bamboo pen only tablet does not support PAD

at 4:45 PM, Ping Cheng pingli...@gmail.com wrote: Bamboo models do not support HID_DG_CONTACTMAX. We should not rely on that description to decide touch_max for them. Plus, no Bamboo device supports single touch. Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_sys.c | 4

[PATCH] HID: wacom - Add support for Intuos Pen Medium

Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_wac.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index 586b240..8ce7fab 100644 --- a/drivers/hid/wacom_wac.c +++ b/drivers/hid/wacom_wac.c @@ -2878,6 +2878,10 @@ static

Re: Problems with Wacom Intuos PT M (CTH680) on FreeBSD

On Tue, Nov 4, 2014 at 10:06 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Tue, Nov 04, 2014 at 09:38:38AM -0800, Ping Cheng wrote: Hi Dmitry, On Tue, Nov 4, 2014 at 12:08 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Sat, Nov 01, 2014 at 08:40:19AM +0100, Hans Petter

[PATCH] HID: wacom - make sure touch_input is valid before using it

http://www.spinics.net/lists/linux-input/msg33971.html Reviewed-by: Hans Petter Selasky h...@selasky.org Tested-by: Denis Akiyakov d.akiya...@gmail.com Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_wac.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: Problems with Wacom Intuos PT M (CTH680) on FreeBSD

Hi Dmitry, On Tue, Nov 4, 2014 at 12:08 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Sat, Nov 01, 2014 at 08:40:19AM +0100, Hans Petter Selasky wrote: On 11/01/14 00:27, Ping Cheng wrote: If touch_input is NULL on FreeBSD, you need to figure out the root cause. Checking

Fwd: [PATCH] HID: input: Fix TransducerSerialNumber implementation

the driver to crash when a tablet with this usage is connected. Secondly, the call to 'set_bit' causes MSC_PULSELED to be sent instead of the expected MSC_SERIAL. This commit addreses both issues. Signed-off-by: Jason Gerecke jason.gere...@wacom.com Reviewed-by: Ping Cheng pi...@wacom.com

Fwd: [PATCH] HID: wacom: make the WL connection friendly for the desktop

-by: Ping Cheng pi...@wacom.com Cheers, Ping --- Hi guys, to continue on Ping's work regarding the Wireless reciever, here is a patch which allows to have the same user experience regardless the transport layer. Unfortunately, a libwacom patch is also required, but once both are applied

[PATCH 1/4] HID: wacom - Add default permission defines for sysfs attributes

RW : ug=rw,o=r WO : ug=w Signed-off-by: Paul A. Tessier phern...@gmail.com Signed-Off-by: Ping Cheng pi...@wacom.com Tested-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/wacom_sys.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/hid/wacom_sys.c b/drivers

[PATCH 2/4] HID: wacom - enable reading relavent sysfs attributes

changed to scnprintf(buf, PAGE_SIZE, ... ) as suggested in sysfs.txt for show functions Signed-off-by: Paul A. Tessier phern...@gmail.com Signed-Off-by: Ping Cheng pi...@wacom.com Tested-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/wacom_sys.c | 20 ++-- 1

[PATCH 3/4] HID: wacom - remove report_id from wacom_get_report interface

It is assigned in buf[0] anyway. Signed-off-by: Ping Cheng pi...@wacom.com Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/wacom_sys.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index

[PATCH 4/4] HID: wacom - enable LED support for Wireless Intuos5/Pro

And associate all LED/OLED to PAD device Signed-off-by: Ping Cheng pi...@wacom.com Tested-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/wacom_sys.c | 52 + 1 file changed, 35 insertions(+), 17 deletions(-) diff --git

[PATCH 1/4 v2] HID: wacom - Add default permission defines for sysfs attributes

RW : ug=rw,o=r WO : ug=w And enabled reading relavent sysfs attributes. Signed-off-by: Paul A. Tessier phern...@gmail.com Signed-Off-by: Ping Cheng pi...@wacom.com Tested-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- v2: Integrate actual permission with defines. drivers/hid

[PATCH 2/4 v2] HID: wacom - Clean up of sysfs

changed to scnprintf(buf, PAGE_SIZE, ... ) as suggested in sysfs.txt for show functions Signed-off-by: Paul A. Tessier phern...@gmail.com Signed-Off-by: Ping Cheng pi...@wacom.com Tested-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- v2: Move actual permission to patch one. drivers

[PATCH 3/4 v2] HID: wacom - remove report_id from wacom_get_report interface

It is assigned in buf[0] anyway. Signed-off-by: Ping Cheng pi...@wacom.com Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/wacom_sys.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index

[PATCH 4/4 v2] HID: wacom - enable LED support for Wireless Intuos5/Pro

And associate all LED/OLED to PAD device Signed-off-by: Ping Cheng pi...@wacom.com Tested-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/wacom_sys.c | 52 + 1 file changed, 35 insertions(+), 17 deletions(-) diff --git

Re: [PATCH v2] Input - wacom: update the ABI doc according to latest changes

devices handle only 1-bit images instead of 4 for USB. The documentation has been updated to match this. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Reviewed-by: Ping Cheng pi...@wacom.com Ping Documentation/ABI/testing/sysfs-driver-wacom | 70

Re: [PATCH] Input - wacom: update the ABI doc according to latest changes

Thank you Benjamin for updating the ABI docs. My comments are inline. With those lines updated, this patch is: Reviewed-by: Ping Cheng pi...@wacom.com Cheers, Ping On Tue, Aug 5, 2014 at 8:34 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: Now the devices show up under hid

Re: [PATCH] Input - wacom: update the ABI doc according to latest changes

On Tue, Aug 5, 2014 at 2:34 PM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: Hi Ping, On Aug 05 2014 or thereabouts, Ping Cheng wrote: Thank you Benjamin for updating the ABI docs. My comments are inline. With those lines updated, this patch is: Reviewed-by: Ping Cheng pi

Re: [PATCH v3 4/7] Input - wacom: Check for bluetooth protocol while setting OLEDs

; mutex_lock(wacom-lock); - err = wacom_led_putimage(wacom, button_id, buf); + err = wacom_led_putimage(wacom, button_id, xfer_id, len, buf); mutex_unlock(wacom-lock); Signed-off-by: Przemo Firszt prz...@firszt.eu Reviewed-by: Ping Cheng pi...@wacom.com I'll test the whole series

Re: [PATCH v2 07/10] Input - wacom: handle Graphire BT tablets in wacom.ko

about doing it incrementally - the patch is still sound as far as I am concerned. I will wait a bit for other to chime in with comments or acks before applying this series. Thank you Benjamin and Dmitry for your support. The whole series is: Acked-by: Ping Cheng pi...@wacom.com Cheers, Ping

Re: [PATCH] Input - wacom: split out the pad device for the wireless receiver

, the function wacom_register_input() is renamed into wacom_register_input(). wacom_register_inputs(). Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Reviewed-by: Ping Cheng pi...@wacom.com. Ping --- Hi, I noticed this afternoon that the pad-in-a-separate-device was missing

Re: [PATCH 1/5] Input - wacom: create a separate input device for pads

, ABS_MISC is necessary and is a reasonable way to group PAD events. So, I do not think it is for backward compatibility. It is there to stay. With that said, the whole patchset is Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Reviewed-by: Ping Cheng pi...@wacom.com Thank you

Re: [PATCH] Input - wacom: put a flag when the led are initialized

Hi Benjamin, On Monday, June 16, 2014, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: Hi Ping, On Jun 13 2014 or thereabouts, Ping Cheng wrote: Hi Benjamin, On Fri, Jun 13, 2014 at 1:29 PM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: This solves a bug

Re: [PATCH] Input - wacom: put a flag when the led are initialized

-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Thank you for your support. But, sorry NAKed-by: Ping Cheng pi...@wacom.com Ping --- drivers/input/tablet/wacom.h | 1 + drivers/input/tablet/wacom_sys.c | 6 ++ 2 files changed, 7 insertions(+) diff --git a/drivers/input/tablet

[PATCH] HID: input - Add two new usages for digitizer

-off-by: Ping Cheng pi...@wacom.com Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/hid-debug.c | 2 ++ drivers/hid/hid-input.c | 5 + include/linux/hid.h | 7 ++- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-debug.c b

Re: [PATCH 2/3] Input: wacom - Don't declare ABS_X/Y for multitouch

On Thu, May 29, 2014 at 12:08 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Tue, May 27, 2014 at 04:18:07PM -0700, Ping Cheng wrote: We use ABS_MT_POSITION_X/Y for multitouch (touch_max 1) events now. No need to declare ABS_X/Y for touch_max == 2 any more. This will make legacy

[PATCH] Input: wacom - cleanup multitouch code when touch_max is 2

Historically we dealt with touch_max equals to 2 differently from other MT devices. Now we use input_mt_*() to process all MT events, as long as touch_max is greater than 1. So, there is no need to take (touch_max == 2) as a special case any more. Signed-off-by: Ping Cheng pi...@wacom.com

[PATCH 1/3] Input: wacom - set stylus_in_proximity when pen is in range

Signed-off-by: Ping Cheng pi...@wacom.com Reviewed-by: Jason Gerecke killert...@gmail.com Tested-by: Jason Gerecke killert...@gmail.com --- drivers/input/tablet/wacom_wac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c

[PATCH 2/3] Input: wacom - Don't declare ABS_X/Y for multitouch

We use ABS_MT_POSITION_X/Y for multitouch (touch_max 1) events now. No need to declare ABS_X/Y for touch_max == 2 any more. Signed-off-by: Ping Cheng pi...@wacom.com Reviewed-by: Jason Gerecke killert...@gmail.com Tested-by: Jason Gerecke killert...@gmail.com --- drivers/input/tablet

[PATCH 3/3] Input: wacom - process outbound for newer Cintiqs

New Cintiq tablets have a 200 tablet counts outside of screen area. Add x/y_min for ABS_X/Y to pass this information to userland. Signed-off-by: Ping Cheng pi...@wacom.com Reviewed-by: Jason Gerecke killert...@gmail.com Tested-by: Jason Gerecke killert...@gmail.com --- drivers/input/tablet

Re: [PATCH 1/2] Input: wacom: Add support for 0x116 sensor on Win8 Panasonic CF-H2

() instead. wacom_mt_touch() needs some cleanup too. Except that, the whole patchset looks good to me. Reviewed-by: Ping Cheng pi...@wacom.com Ping } else { prox = data[1] 0x01; x = le16_to_cpup((__le16 *)data[2]); @@ -2298,6

Fwd: [PATCH 1/4] Input: wacom: Use full 32-bit HID Usage value in switch statement

. Ping On Fri, Apr 11, 2014 at 2:23 PM, Ping Cheng pingli...@gmail.com wrote: Dmitry, This patchset has been outstanding for more than 2 months. Can you merge them upstream? Thank you. Ping On Tue, Mar 4, 2014 at 1:10 PM, Ping Cheng pingli...@gmail.com wrote: Hi Dmitry, This patchset

[PATCH 1/2] input: wacom - missed the last bit of expresskey for DTU-1031

Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/input/tablet/wacom_wac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c index 05f371d..3d094c9 100644 --- a/drivers/input/tablet/wacom_wac.c +++ b/drivers

[PATCH 2/2] input: wacom - unify outbound support for Cintiq and Intuos series

Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/input/tablet/wacom_wac.c | 88 drivers/input/tablet/wacom_wac.h | 4 +- 2 files changed, 75 insertions(+), 17 deletions(-) diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet

Re: [PATCH 1/4] Input: wacom: Use full 32-bit HID Usage value in switch statement

Hi Dmitry, This patchset has been Tested-by: Aaron Skomra aaron.sko...@wacom.com and Reviewed-by: Carl Worth cwo...@cworth.org. I think they are ready to go upstream. Do you have other comments? Ping On Thu, Feb 27, 2014 at 10:37 AM, Aaron Armstrong Skomra sko...@gmail.com wrote: On Thu, Jan

Re: wacom: Fixes for stylus pressure values for Thinkpad Yoga

Hi Carl, Thank you for the heads up. I believe Jason's patchset 4 of 4 (http://www.spinics.net/lists/linux-input/msg29435.html) fixed the issue for your device and for other's. The patch was submitted last month. If you can test the set on your device and give us a Tested-by here, it will help

[PATCH v2] Input: wacom - add support for DTU-1031

Signed-off-by: Ping Cheng pi...@wacom.com --- v2: use get_unaligned_be16 instead of be16_to_cpup for unaligned data ([3] and [5]) drivers/input/tablet/wacom_wac.c | 76 +++- drivers/input/tablet/wacom_wac.h | 6 +++- 2 files changed, 80 insertions(+), 2

[PATCH] Input: wacom - add support for DTU-1031

Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/input/tablet/wacom_wac.c | 80 +++- drivers/input/tablet/wacom_wac.h | 6 ++- 2 files changed, 84 insertions(+), 2 deletions(-) diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet

[PATCH] Input: wacom - Fix wacom-shared guards for dual input devices

features-quirks can have multiple bits set. For dual input, we only need to check WACOM_QUIRK_MULTI_INPUT. Reviewed-by: Jason Gerecke killert...@gmail.com Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/input/tablet/wacom_wac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH v4] Input: wacom - add SW_MUTE_DEVICE to include/uapi/linux/input.h

peter.hutte...@who-t.net Tested-by: Jason Gerecke killert...@gmail.com Signed-off-by: Ping Cheng pi...@wacom.com --- v4: Changed SW_TOUCH to SW_MUTE_DEVICE as suggested by Dmitry. --- drivers/input/tablet/wacom_sys.c | 12 drivers/input/tablet/wacom_wac.c | 30

Re: [PATCH 4/4 v3] Input: wacom - add SW_TOUCH to include/uapi/linux/input.h

On Mon, Nov 25, 2013 at 6:59 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Ping, On Fri, Nov 15, 2013 at 12:00:02PM -0800, Ping Cheng wrote: @@ -856,6 +856,7 @@ struct input_keymap_entry { #define SW_FRONT_PROXIMITY 0x0b /* set = front proximity sensor active */ #define

[PATCH 0/4 v3] input: wacom - Add support for new Intuos devices

Hutterer peter.hutte...@who-t.net for relevant patches. Jason's patch is included to avoid missing patch in mailling list. Jason Gerecke (1): input: wacom - Scale up touch width and height values for Intuos Pro Ping Cheng (3): input: wacom - make sure touch_max is set for touch devices Input

[PATCH 1/4 v3] input: wacom - Scale up touch width and height values for Intuos Pro

From: Signed-off-by: Jason Gerecke killert...@gmail.com The width and height values reported by the Intuos Pro are not in surface units as required by the MT protocol. A simple multiplier of 100x corrects it. Signed-off-by: Jason Gerecke killert...@gmail.com Acked-by: Ping Cheng pi...@wacom.com

[PATCH 2/4 v3] input: wacom - make sure touch_max is set for touch devices

Old single touch Tablet PCs do not have touch_max set at wacom_features. Since touch device at lease supports one finger, assign touch_max to 1 when touch usage is defined in its HID Descriptor and touch_max is not pre-defined. Tested-by: Jason Gerecke killert...@gmail.com Signed-off-by: Ping

[PATCH 3/4 v3] Input: wacom - add support for three new Intuos devices

-by: Ping Cheng pi...@wacom.com --- drivers/input/tablet/wacom_sys.c | 6 ++-- drivers/input/tablet/wacom_wac.c | 62 ++-- drivers/input/tablet/wacom_wac.h | 2 ++ 3 files changed, 52 insertions(+), 18 deletions(-) diff --git a/drivers/input/tablet/wacom_sys.c b

[PATCH 4/4 v3] Input: wacom - add SW_TOUCH to include/uapi/linux/input.h

New Intuos series models added a hardware switch to turn touch data on/off. To report the state of the switch, SW_TOUCH is added in include/uapi/linux/input.h. Acked-by: Peter Hutterer peter.hutte...@who-t.net Tested-by: Jason Gerecke killert...@gmail.com Signed-off-by: Ping Cheng pi...@wacom.com

Re: [PATCH 4/4 v3] Input: wacom - add SW_TOUCH to include/uapi/linux/input.h

On Fri, Nov 15, 2013 at 1:33 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Fri, Nov 15, 2013 at 2:00 PM, Ping Cheng pingli...@gmail.com wrote: New Intuos series models added a hardware switch to turn touch data on/off. To report the state of the switch, SW_TOUCH is added in include/uapi

Re: [PATCH 4/4 v3] Input: wacom - add SW_TOUCH to include/uapi/linux/input.h

On Fri, Nov 15, 2013 at 1:28 PM, Chris Bagwell ch...@cnpbagwell.com wrote: Thanks for breaking out... Its easier to review now as well. Small question below. On Fri, Nov 15, 2013 at 2:00 PM, Ping Cheng pingli...@gmail.com wrote: New Intuos series models added a hardware switch to turn touch

Fwd: [PATCH v2 2/2] Input: wacom - add support for three new Intuos devices

On Monday, November 11, 2013, Chris Bagwell wrote: On Fri, Nov 8, 2013 at 1:13 PM, Ping Cheng pingli...@gmail.com wrote: On Thu, Nov 7, 2013 at 6:25 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Thu, Oct 10, 2013 at 4:17 PM, Ping Cheng pingli...@gmail.com wrote: This series of models

Re: [PATCH v2 2/2] Input: wacom - add support for three new Intuos devices

On Thu, Nov 7, 2013 at 6:25 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Thu, Oct 10, 2013 at 4:17 PM, Ping Cheng pingli...@gmail.com wrote: This series of models added a hardware switch to turn touch data on/off. To report the state of the switch, SW_TOUCH is added in include/uapi/linux

  1   2   >