Re: [PATCH 0/4] Touchscreen performance related fixes

2014-11-03 Thread Richard Cochran
On Mon, Oct 27, 2014 at 04:38:27PM +0530, Vignesh R wrote: > This series of patches fix TSC defects related to lag in touchscreen > performance and cursor jump at touch release. The lag was result of > udelay in TSC interrupt handler. Cursor jump due to false pen-up event. > The patches implement A

Re: [PATCH 1/4] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps

2014-11-06 Thread Richard Cochran
On Mon, Oct 27, 2014 at 04:38:28PM +0530, Vignesh R wrote: ... > @@ -209,6 +214,7 @@ static void titsc_read_coordinates(struct titsc *ts_dev, > unsigned int read, diff; > unsigned int i, channel; > unsigned int creads = ts_dev->coordinate_readouts; > + unsigned int first_ste

Re: [PATCH 1/4] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps

2014-11-07 Thread Richard Cochran
On Fri, Nov 07, 2014 at 11:04:05AM +0530, Vignesh R wrote: > > Currently, there is too much noise in the TSC hardware that is being > removed by delta filtering. The so called "filter" was only programmed because the fifo entries were being mixed up. Sebastian fixed that. > I tested TSC unit by

Re: [PATCH 1/4] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps

2014-11-07 Thread Richard Cochran
On Fri, Nov 07, 2014 at 11:04:05AM +0530, Vignesh R wrote: > Currently, there is too much noise in the TSC hardware that is being > removed by delta filtering. I tested TSC unit by removing filtering > logic, the performance was not at all satisfactory. The cursor jumps > wayward and smooth circles

Re: [PATCH v4 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler

2014-11-15 Thread Richard Cochran
On Fri, Nov 14, 2014 at 10:37:27AM +0530, Vignesh R wrote: > From: Brad Griffis > > TSC interrupt handler had udelay to avoid reporting of false pen-up > interrupt to user space. This patch implements workaround suggesting in > Advisory 1.0.31 of silicon errata for am335x, thus eliminating udelay

Re: [PATCH v4 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler

2014-11-17 Thread Richard Cochran
On Mon, Nov 17, 2014 at 09:57:05AM +0530, Vignesh R wrote: > My patches are based on v3.18rc2. I tested my patches on am335x-evm > using tslib. No beaglebone + cape testing? > Please explain "touch is broken"? What is the behaviour of TSC? With plain v3.17 plus your series, the cursor is almost

Re: [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-20 Thread Richard Cochran
Brad, What you wrote is just the kind of thing one would like to see in the cover letter or change log... On Thu, Nov 20, 2014 at 02:23:30PM +, Griffis, Brad wrote: > In that thread the user was registering multiple press events for a single > press. By increasing the udelay to 1.5ms they w

Re: [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-20 Thread Richard Cochran
On Thu, Nov 20, 2014 at 07:26:00PM +0530, Sekhar Nori wrote: > I tested this using lcd7 cape connected to beaglebone black. The latest > kernel I could find on this board was a TI BSP based v3.14 kernel. So I > had to port these patches to that kernel. Cc Robert Nelson to see if he > knows about a

Re: [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-21 Thread Richard Cochran
On Fri, Nov 21, 2014 at 05:40:12PM +0530, Sekhar Nori wrote: > Not sure how to reproduce the jumping on pen-up. Does the cursor stay in exactly the same spot when you lift up the stylus? Then you don't have the issue. On the BB white using the LCD4 cape and the shipped debian kernel, the cursor *

Re: [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-21 Thread Richard Cochran
On Fri, Nov 21, 2014 at 07:17:18PM +0100, Johannes Pointner wrote: > Before the patches were also jumps but I thought it is something > Vignesh should know. Maybe there is some fix for that too? > As Richard also noted, it would be nice if ti could let us know how to > get the delay values right. B

Re: [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-24 Thread Richard Cochran
On Mon, Nov 24, 2014 at 09:57:46AM +0100, Sebastian Andrzej Siewior wrote: > On 11/21/2014 02:10 PM, Richard Cochran wrote: > > > On the BB white using the LCD4 cape and the shipped debian kernel, the > > cursor *does* jump away, but not as often or as far as on the custo

Re: [PATCH v4 0/6] Touchscreen performance related fixes

2014-12-16 Thread Richard Cochran
On Tue, Dec 16, 2014 at 10:31:47AM +0200, Catalin Crenguta wrote: > > It seems that because the ribbon cable has both the analog and digital > signals, the analog signals are affected by the digital ones (hence > the touchscreen was working OK when the display was disabled). Putting > decoupling c