Re: [PATCH v3 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-28 Thread Roger Quadros
On 28/07/15 00:20, Dmitry Torokhov wrote: > On Mon, Jul 27, 2015 at 04:49:22PM +0530, Vignesh R wrote: >> >> >> On 07/27/2015 04:19 PM, Roger Quadros wrote: >>> Hi, >>> >>> On 23/07/15 17:54, Vignesh R wrote: >>>> On am437x-gp-evm, pixc

Re: [PATCH v3 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-27 Thread Roger Quadros
Hi, On 23/07/15 17:54, Vignesh R wrote: > On am437x-gp-evm, pixcir touchscreen can wake the system from low power > state by generating wake-up interrupt via pinctrl and IO daisy chain. > Add support for optional wakeup interrupt source by regsitering to > automated wake IRQ framework introduced b

Re: [PATCH 2/3] Input: of_touchscreen - fix setting max values on X/Y axis

2015-07-10 Thread Roger Quadros
On 09/07/15 21:16, Dmitry Torokhov wrote: > On Thu, Jul 09, 2015 at 11:32:11AM +0300, Roger Quadros wrote: >> Dmitry, >> >> On 08/07/15 18:08, Dmitry Torokhov wrote: >>> On Wed, Jul 08, 2015 at 10:59:04AM +0300, Roger Quadros wrote: >>>> Dmitry, >>

Re: [PATCH 2/3] Input: of_touchscreen - fix setting max values on X/Y axis

2015-07-09 Thread Roger Quadros
Dmitry, On 08/07/15 18:08, Dmitry Torokhov wrote: > On Wed, Jul 08, 2015 at 10:59:04AM +0300, Roger Quadros wrote: >> Dmitry, >> >> On 07/07/15 19:25, Dmitry Torokhov wrote: >>> Hi Roger, >>> >>> On Tue, Jul 07, 2015 at 12:37:31PM +0300, Roger Quad

Re: [PATCH 2/3] Input: of_touchscreen - fix setting max values on X/Y axis

2015-07-08 Thread Roger Quadros
Dmitry, On 07/07/15 19:25, Dmitry Torokhov wrote: Hi Roger, On Tue, Jul 07, 2015 at 12:37:31PM +0300, Roger Quadros wrote: Hi Dmitry, On 07/07/15 03:27, Dmitry Torokhov wrote: The binding specification says that "touchscreen-size-x" and "-y" specify horizontal and vertic

Re: [PATCH 6/6] Input: pixcir_i2c_ts - use standard OF touchscreen parsing code

2015-07-07 Thread Roger Quadros
On 07/07/15 03:30, Dmitry Torokhov wrote: Let's switch to using standard touchscreen device properties parsing module instead of doing it by hand in the driver. Signed-off-by: Dmitry Torokhov Acked-by: Roger Quadros cheers, -roger --- drivers/input/touchscreen/pixcir_i2c_ts.c

Re: [PATCH 5/6] Input: pixcir_i2c_ts - simplify input device initialization

2015-07-07 Thread Roger Quadros
On 07/07/15 03:30, Dmitry Torokhov wrote: input_mt_init_slots() will perform necessary settings for performing multi-touch to single-touch emulation, we do not need to do that ourselves. Signed-off-by: Dmitry Torokhov Acked-by: Roger Quadros cheers, -roger --- drivers/input

Re: [PATCH 3/6] Input: pixcir_i2c_ts - allow using with GPIO expanders

2015-07-07 Thread Roger Quadros
Acked-by: Roger Quadros cheers, -roger --- drivers/input/touchscreen/pixcir_i2c_ts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c index 9093aa9..8965d7c 100644 --- a/drivers/

Re: [PATCH 2/6] Input: pixcir_i2c_ts - switch the device over to gpiod

2015-07-07 Thread Roger Quadros
On 07/07/15 03:30, Dmitry Torokhov wrote: This allows uniform parsing on legacy, DT and ACPI systems. Signed-off-by: Dmitry Torokhov Acked-by: Roger Quadros cheers, -roger --- drivers/input/touchscreen/pixcir_i2c_ts.c | 26 +- include/linux/platform_data

Re: [PATCH 1/6] Input: pixcir_i2c_ts - move platform data

2015-07-07 Thread Roger Quadros
On 07/07/15 03:30, Dmitry Torokhov wrote: Let's move driver's platform data definitions from include/linux/input/ into include/linux/platform_data/ so that it stays with the rest of platform data definitions. Signed-off-by: Dmitry Torokhov Acked-by: Roger Quadros chee

Re: [PATCH 2/3] Input: of_touchscreen - fix setting max values on X/Y axis

2015-07-07 Thread Roger Quadros
Hi Dmitry, On 07/07/15 03:27, Dmitry Torokhov wrote: The binding specification says that "touchscreen-size-x" and "-y" specify horizontal and vertical resolution of the touchscreen and therefore maximum absolute coordinates should be reduced by 1 since we are starting with 0. Signed-off-by: Dmi

Re: [PATCH v2] Input: pixcir_i2c_ts - Add RESET gpio

2015-07-06 Thread Roger Quadros
Hi Dmitry, On 02/06/15 12:33, Roger Quadros wrote: The controller has a RESET pin which is usually controlled over a GPIO line. If such a GPIO is provided, perform a RESET during probe. Signed-off-by: Roger Quadros Could you please pick this up for v4.3? Thanks. cheers, -roger

[PATCH v2] Input: pixcir_i2c_ts - Add RESET gpio

2015-06-02 Thread Roger Quadros
The controller has a RESET pin which is usually controlled over a GPIO line. If such a GPIO is provided, perform a RESET during probe. Signed-off-by: Roger Quadros --- .../bindings/input/touchscreen/pixcir_i2c_ts.txt | 3 ++ drivers/input/touchscreen/pixcir_i2c_ts.c | 37

Re: [PATCH] Input: pixcir_i2c_ts - Add RESET gpio

2015-02-10 Thread Roger Quadros
Hi Dmitry, On 06/02/15 18:54, Dmitry Torokhov wrote: > Hi Roger, > > On Fri, Feb 06, 2015 at 02:53:10PM +0200, Roger Quadros wrote: >> The controller has a RESET pin which is usually controlled over >> a GPIO line. If such a GPIO is provided, perform a RESET >> during

[PATCH] Input: pixcir_i2c_ts - Add RESET gpio

2015-02-06 Thread Roger Quadros
The controller has a RESET pin which is usually controlled over a GPIO line. If such a GPIO is provided, perform a RESET during probe. Signed-off-by: Roger Quadros --- .../bindings/input/touchscreen/pixcir_i2c_ts.txt | 3 ++ drivers/input/touchscreen/pixcir_i2c_ts.c | 37

Re: [PATCH v7 0/5] Input: pixcir_i2c_ts: Add Type-B Multi-touch and DT support

2014-07-28 Thread Roger Quadros
Hi Dmitry, Gentle ping. Would be nice to get these into 3.17. Thanks :). cheers, -roger On 07/03/2014 12:34 PM, Roger Quadros wrote: > Hi Dmitry, > > Gentle reminder to pick this series for -next. Thanks :). > > cheers, > -roger > > On 06/17/2014 12:31 PM, Roger Qua

Re: [PATCH v7 0/5] Input: pixcir_i2c_ts: Add Type-B Multi-touch and DT support

2014-07-03 Thread Roger Quadros
Hi Dmitry, Gentle reminder to pick this series for -next. Thanks :). cheers, -roger On 06/17/2014 12:31 PM, Roger Quadros wrote: > Hi Dmitry, > > These are the pending patches that didn't go through in the 3.16 merge window. > Please queue them for -next. Thanks. > &

Re: [PATCH v7 0/5] Input: pixcir_i2c_ts: Add Type-B Multi-touch and DT support

2014-06-17 Thread Roger Quadros
On 06/17/2014 12:51 PM, Tony Lindgren wrote: > * Roger Quadros [140617 02:33]: >> Hi Dmitry, >> >> These are the pending patches that didn't go through in the 3.16 merge >> window. >> Please queue them for -next. Thanks. >> >> The series doe

[PATCH v7 3/5] Input: pixcir_i2c_ts: Add device tree support

2014-06-17 Thread Roger Quadros
Provide device tree support and binding information. Also provide support for a new chip "pixcir_tangoc". Signed-off-by: Roger Quadros --- .../bindings/input/touchscreen/pixcir_i2c_ts.txt | 26 .../devicetree/bindings/vendor-prefixes.txt| 1 + drivers/input/t

[PATCH v7 5/5] ARM: dts: am437x-gp-evm: Update binding for touchscreen size

2014-06-17 Thread Roger Quadros
Update the bindings for touchscreen size. CC: Benoit Cousson CC: Tony Lindgren CC: Mugunthan V N Signed-off-by: Roger Quadros --- arch/arm/boot/dts/am437x-gp-evm.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot

[PATCH v7 1/5] Input: pixcir_i2c_ts: Use Type-B Multi-Touch protocol

2014-06-17 Thread Roger Quadros
Switch to using the Type-B Multi-Touch protocol. Reviewed-by: Henrik Rydberg Signed-off-by: Roger Quadros --- drivers/input/touchscreen/pixcir_i2c_ts.c | 125 ++ 1 file changed, 94 insertions(+), 31 deletions(-) diff --git a/drivers/input/touchscreen

[PATCH v7 2/5] Input: pixcir_i2c_ts: support upto 5 fingers and hardware provided tracking IDs

2014-06-17 Thread Roger Quadros
Some variants of the Pixcir touch controller support upto 5 simultaneous fingers and hardware tracking IDs. Prepare the driver for that. Signed-off-by: Roger Quadros --- drivers/input/touchscreen/pixcir_i2c_ts.c | 74 --- include/linux/input/pixcir_ts.h

[PATCH v7 4/5] ARM: dts: am43x-epos-evm: Update binding for touchscreen size

2014-06-17 Thread Roger Quadros
Update the bindings for touchscreen size. CC: Benoit Cousson CC: Tony Lindgren CC: Mugunthan V N Signed-off-by: Roger Quadros --- arch/arm/boot/dts/am43x-epos-evm.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot

[PATCH v7 0/5] Input: pixcir_i2c_ts: Add Type-B Multi-touch and DT support

2014-06-17 Thread Roger Quadros
while touchscreen in use - Fixed module removal while touchscreen in use v2: - Addressed review comments and re-arranged patch order v1: - http://article.gmane.org/gmane.linux.kernel/1616417 -- Roger Quadros (5): Input: pixcir_i2c_ts: Use Type-B Multi-Touch protocol Input: pixcir_i2c_ts: s

Re: [PATCH v6 4/7] Input: pixcir_i2c_ts: Use Type-B Multi-Touch protocol

2014-06-04 Thread Roger Quadros
Hi Dmitry, We're still missing patches 4, 5 and 7 for 3.16, to get device tree and type-B support. Do you want me to send them separately? cheers, -roger On 05/19/2014 11:24 AM, Roger Quadros wrote: > From: Roger Quadros > > Switch to using the Type-B Multi-Touch protocol. &g

[PATCH v6 7/7] Input: pixcir_i2c_ts: Add device tree support

2014-05-19 Thread Roger Quadros
From: Roger Quadros Provide device tree support and binding information. Also provide support for a new chip "pixcir_tangoc". Signed-off-by: Roger Quadros --- .../bindings/input/touchscreen/pixcir_i2c_ts.txt | 26 .../devicetree/bindings/vendor-prefixes.txt| 1

[PATCH v6 5/7] Input: pixcir_i2c_ts: support upto 5 fingers and hardware provided tracking IDs

2014-05-19 Thread Roger Quadros
From: Roger Quadros Some variants of the Pixcir touch controller support upto 5 simultaneous fingers and hardware tracking IDs. Prepare the driver for that. Signed-off-by: Roger Quadros --- drivers/input/touchscreen/pixcir_i2c_ts.c | 74 --- include/linux/input

[PATCH v6 4/7] Input: pixcir_i2c_ts: Use Type-B Multi-Touch protocol

2014-05-19 Thread Roger Quadros
From: Roger Quadros Switch to using the Type-B Multi-Touch protocol. Reviewed-by: Henrik Rydberg Signed-off-by: Roger Quadros --- drivers/input/touchscreen/pixcir_i2c_ts.c | 125 ++ 1 file changed, 94 insertions(+), 31 deletions(-) diff --git a/drivers/input

Re: [PATCH v5 7/7] Input: pixcir_i2c_ts: Add device tree support

2014-05-19 Thread Roger Quadros
On 05/19/2014 08:54 AM, Dmitry Torokhov wrote: > On Tue, May 06, 2014 at 02:06:12PM +0300, Roger Quadros wrote: >> Provide device tree support and binding information. >> Also provide support for a new chip "pixcir_tangoc". >> >> Signed-off-by: Roger Q

Re: [PATCH v5 4/7] Input: pixcir_i2c_ts: Use Type-B Multi-Touch protocol

2014-05-19 Thread Roger Quadros
Hi Henrik, On 05/19/2014 10:04 AM, Henrik Rydberg wrote: > Hi Roger, > > Thanks for the patch series. I think the patch looks great in general. Please > see some minor comments below. > > On 05/06/2014 01:06 PM, Roger Quadros wrote: >> Switch to using the Typ

[PATCH v5 3/7] Input: pixcir_i2c_ts: Get rid of pdata->attb_read_val()

2014-05-06 Thread Roger Quadros
Get rid of the attb_read_val() platform hook. Instead, read the ATTB gpio directly from the driver. Fail if valid ATTB gpio is not provided by patform data. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- drivers/input/touchscreen/pixcir_i2c_ts.c | 16 +++- include/linux

[PATCH v5 4/7] Input: pixcir_i2c_ts: Use Type-B Multi-Touch protocol

2014-05-06 Thread Roger Quadros
Switch to using the Type-B Multi-Touch protocol. Signed-off-by: Roger Quadros --- drivers/input/touchscreen/pixcir_i2c_ts.c | 125 ++ 1 file changed, 94 insertions(+), 31 deletions(-) diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input

[PATCH v5 2/7] Input: pixcir_i2c_ts - initialize interrupt mode and power mode

2014-05-06 Thread Roger Quadros
Introduce helper functions to configure power and interrupt registers. Default to IDLE mode on probe as device supports auto wakeup to ACVIE mode on detecting finger touch. Configure interrupt mode and polarity on start up. Power down on device closure or module removal. Signed-off-by: Roger

[PATCH v5 5/7] Input: pixcir_i2c_ts: support upto 5 fingers and hardware provided tracking IDs

2014-05-06 Thread Roger Quadros
Some variants of the Pixcir touch controller support upto 5 simultaneous fingers and hardware tracking IDs. Prepare the driver for that. Signed-off-by: Roger Quadros --- drivers/input/touchscreen/pixcir_i2c_ts.c | 74 --- include/linux/input/pixcir_ts.h

[PATCH v5 7/7] Input: pixcir_i2c_ts: Add device tree support

2014-05-06 Thread Roger Quadros
Provide device tree support and binding information. Also provide support for a new chip "pixcir_tangoc". Signed-off-by: Roger Quadros --- .../bindings/input/touchscreen/pixcir_i2c_ts.txt | 26 .../devicetree/bindings/vendor-prefixes.txt| 1 + drivers/input/t

[PATCH v5 6/7] Input: pixcir_i2c_ts: Implement wakeup from suspend

2014-05-06 Thread Roger Quadros
Improve the suspend and resume handlers to allow the device to wakeup the system from suspend. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- drivers/input/touchscreen/pixcir_i2c_ts.c | 47 --- 1 file changed, 43 insertions(+), 4 deletions(-) diff --git a

[PATCH v5 0/7] Input: pixcir_i2c_ts: Add Type-B Multi-touch and DT support

2014-05-06 Thread Roger Quadros
uchscreen in use - Fixed module removal while touchscreen in use v2: - Addressed review comments and re-arranged patch order v1: - http://article.gmane.org/gmane.linux.kernel/1616417 -- Roger Quadros (7): Input: pixcir_i2c_ts: Use devres managed resource allocations Input: pixcir_i2c_ts - init

[PATCH v5 1/7] Input: pixcir_i2c_ts: Use devres managed resource allocations

2014-05-06 Thread Roger Quadros
Use devm_() and friends for allocating memory, input device and IRQ. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- drivers/input/touchscreen/pixcir_i2c_ts.c | 38 --- 1 file changed, 15 insertions(+), 23 deletions(-) diff --git a/drivers/input

Re: [PATCH v4 6/7] Input: pixcir_i2c_ts: Implement wakeup from suspend

2014-05-06 Thread Roger Quadros
On 05/06/2014 08:21 AM, Dmitry Torokhov wrote: > On Mon, May 05, 2014 at 12:04:37PM +0300, Roger Quadros wrote: >> Improve the suspend and resume handlers to allow the device >> to wakeup the system from suspend. >> >> Signed-off-by: Roger Quadros >> Acked-by:

Re: [PATCH v4 2/7] Input: pixcir_i2c_ts: Initialize interrupt mode and power mode

2014-05-06 Thread Roger Quadros
Dmitry, On 05/06/2014 08:19 AM, Dmitry Torokhov wrote: > Hi Roger, > > On Mon, May 05, 2014 at 12:04:33PM +0300, Roger Quadros wrote: >> @@ -192,8 +364,8 @@ static int pixcir_i2c_ts_remove(struct i2c_client >> *client) >> >> device_init_wakeup(&

[PATCH v4 1/7] Input: pixcir_i2c_ts: Use devres managed resource allocations

2014-05-05 Thread Roger Quadros
Use devm_() and friends for allocating memory, input device and IRQ. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- drivers/input/touchscreen/pixcir_i2c_ts.c | 38 --- 1 file changed, 15 insertions(+), 23 deletions(-) diff --git a/drivers/input

[PATCH v4 0/7] Input: pixcir_i2c_ts: Add Type-B Multi-touch and DT support

2014-05-05 Thread Roger Quadros
http://article.gmane.org/gmane.linux.kernel/1616417 --- Roger Quadros (7): Input: pixcir_i2c_ts: Use devres managed resource allocations Input: pixcir_i2c_ts: Initialize interrupt mode and power mode Input: pixcir_i2c_ts: Get rid of pdata->attb_read_val() Input: pixcir_i2c_ts: Use Type-B Mul

[PATCH v4 2/7] Input: pixcir_i2c_ts: Initialize interrupt mode and power mode

2014-05-05 Thread Roger Quadros
Introduce helper functions to configure power and interrupt registers. Default to IDLE mode on probe as device supports auto wakeup to ACVIE mode on detecting finger touch. Configure interrupt mode and polarity on start up. Power down on device closure or module removal. Signed-off-by: Roger

[PATCH v4 3/7] Input: pixcir_i2c_ts: Get rid of pdata->attb_read_val()

2014-05-05 Thread Roger Quadros
Get rid of the attb_read_val() platform hook. Instead, read the ATTB gpio directly from the driver. Fail if valid ATTB gpio is not provided by patform data. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- drivers/input/touchscreen/pixcir_i2c_ts.c | 16 +++- include/linux

[PATCH v4 5/7] Input: pixcir_i2c_ts: support upto 5 fingers and hardware provided tracking IDs

2014-05-05 Thread Roger Quadros
Some variants of the Pixcir touch controller support upto 5 simultaneous fingers and hardware tracking IDs. Prepare the driver for that. Signed-off-by: Roger Quadros --- drivers/input/touchscreen/pixcir_i2c_ts.c | 74 --- include/linux/input/pixcir_ts.h

[PATCH v4 4/7] Input: pixcir_i2c_ts: Use Type-B Multi-Touch protocol

2014-05-05 Thread Roger Quadros
Switch to using the Type-B Multi-Touch protocol. Signed-off-by: Roger Quadros --- drivers/input/touchscreen/pixcir_i2c_ts.c | 125 ++ 1 file changed, 94 insertions(+), 31 deletions(-) diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input

[PATCH v4 6/7] Input: pixcir_i2c_ts: Implement wakeup from suspend

2014-05-05 Thread Roger Quadros
Improve the suspend and resume handlers to allow the device to wakeup the system from suspend. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- drivers/input/touchscreen/pixcir_i2c_ts.c | 53 --- 1 file changed, 49 insertions(+), 4 deletions(-) diff --git a

[PATCH v4 7/7] Input: pixcir_i2c_ts: Add device tree support

2014-05-05 Thread Roger Quadros
Provide device tree support and binding information. Also provide support for a new chip "pixcir_tangoc". Signed-off-by: Roger Quadros --- .../bindings/input/touchscreen/pixcir_i2c_ts.txt | 26 .../devicetree/bindings/vendor-prefixes.txt| 1 + drivers/input/t

Re: [PATCH v3 1/7] Input: pixcir_i2c_ts: Use devres managed resource allocations

2014-05-05 Thread Roger Quadros
On 04/30/2014 07:30 PM, Dmitry Torokhov wrote: > Hi Roger, > > On Wed, Apr 30, 2014 at 03:36:26PM +0300, Roger Quadros wrote: > >> static int pixcir_i2c_ts_remove(struct i2c_client *client) >> @@ -198,10 +194,8 @@ static int pixcir_i2c_ts_remove(struc

Re: [PATCH v3 2/7] Input: pixcir_i2c_ts: Initialize interrupt mode and power mode

2014-05-05 Thread Roger Quadros
Hi Dmitry, On 04/30/2014 07:29 PM, Dmitry Torokhov wrote: > Hi Roger, > > On Wed, Apr 30, 2014 at 03:36:27PM +0300, Roger Quadros wrote: >> +static int pixcir_stop(struct pixcir_i2c_ts_data *ts) >> +{ >> +struct device *dev = &ts->client->dev; >>

[PATCH v3 1/7] Input: pixcir_i2c_ts: Use devres managed resource allocations

2014-04-30 Thread Roger Quadros
Use devm_() and friends for allocating memory, input device and IRQ. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- drivers/input/touchscreen/pixcir_i2c_ts.c | 36 +-- 1 file changed, 15 insertions(+), 21 deletions(-) diff --git a/drivers/input

[PATCH v3 3/7] Input: pixcir_i2c_ts: Get rid of pdata->attb_read_val()

2014-04-30 Thread Roger Quadros
Get rid of the attb_read_val() platform hook. Instead, read the ATTB gpio directly from the driver. Fail if valid ATTB gpio is not provided by patform data. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- drivers/input/touchscreen/pixcir_i2c_ts.c | 16 +++- include/linux

[PATCH v3 4/7] Input: pixcir_i2c_ts: Use Type-B Multi-Touch protocol

2014-04-30 Thread Roger Quadros
Switch to using the Type-B Multi-Touch protocol. Signed-off-by: Roger Quadros --- drivers/input/touchscreen/pixcir_i2c_ts.c | 125 ++ 1 file changed, 94 insertions(+), 31 deletions(-) diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input

[PATCH v3 6/7] Input: pixcir_i2c_ts: Implement wakeup from suspend

2014-04-30 Thread Roger Quadros
Improve the suspend and resume handlers to allow the device to wakeup the system from suspend. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- drivers/input/touchscreen/pixcir_i2c_ts.c | 53 --- 1 file changed, 49 insertions(+), 4 deletions(-) diff --git a

[PATCH v3 5/7] Input: pixcir_i2c_ts: support upto 5 fingers and hardware provided tracking IDs

2014-04-30 Thread Roger Quadros
Some variants of the Pixcir touch controller support upto 5 simultaneous fingers and hardware tracking IDs. Prepare the driver for that. Signed-off-by: Roger Quadros --- drivers/input/touchscreen/pixcir_i2c_ts.c | 74 --- include/linux/input/pixcir_ts.h

[PATCH v3 7/7] Input: pixcir_i2c_ts: Add device tree support

2014-04-30 Thread Roger Quadros
Provide device tree support and binding information. Also provide support for a new chip "pixcir_tangoc". Signed-off-by: Roger Quadros --- .../bindings/input/touchscreen/pixcir_i2c_ts.txt | 26 .../devicetree/bindings/vendor-prefixes.txt| 1 + drivers/input/t

[PATCH v3 2/7] Input: pixcir_i2c_ts: Initialize interrupt mode and power mode

2014-04-30 Thread Roger Quadros
Introduce helper functions to configure power and interrupt registers. Default to IDLE mode on probe as device supports auto wakeup to ACVIE mode on detecting finger touch. Configure interrupt mode and polarity on start up. Power down on device closure or module removal. Signed-off-by: Roger

[PATCH v3 0/7] Input: pixcir_i2c_ts: Add Type-B Multi-touch and DT support

2014-04-30 Thread Roger Quadros
to 3.15-rc3 - Fixed suspend while touchscreen in use - Fixed module removal while touchscreen in use v2: - Addressed review comments and re-arranged patch order v1: - http://article.gmane.org/gmane.linux.kernel/1616417 --- Roger Quadros (7): Input: pixcir_i2c_ts: Use devres managed resource

Re: [PATCH v2 4/8] Input: pixcir_i2c_ts: Use Type-B Multi-Touch protocol

2014-03-19 Thread Roger Quadros
Henrik, On 03/10/2014 06:37 PM, Felipe Balbi wrote: > On Mon, Mar 10, 2014 at 10:57:10AM +0200, Roger Quadros wrote: >> Hi Henrik, >> >> On 03/08/2014 05:11 PM, Henrik Rydberg wrote: >>> Hi Roger, >>> >>> the MT implementation seems mostly fine,

Re: [PATCH v2 4/8] Input: pixcir_i2c_ts: Use Type-B Multi-Touch protocol

2014-03-11 Thread Roger Quadros
On 03/10/2014 06:37 PM, Felipe Balbi wrote: > On Mon, Mar 10, 2014 at 10:57:10AM +0200, Roger Quadros wrote: >> Hi Henrik, >> >> On 03/08/2014 05:11 PM, Henrik Rydberg wrote: >>> Hi Roger, >>> >>> the MT implementation seems mostly fine,

Re: [PATCH v2 4/8] Input: pixcir_i2c_ts: Use Type-B Multi-Touch protocol

2014-03-10 Thread Roger Quadros
Hi Henrik, On 03/08/2014 05:11 PM, Henrik Rydberg wrote: > Hi Roger, > > the MT implementation seems mostly fine, just one curiosity: > >> static irqreturn_t pixcir_ts_isr(int irq, void *dev_id) >> { >> struct pixcir_i2c_ts_data *tsdata = dev_id; >> const struct pixcir_ts_platform_da

Re: [PATCH v2 0/8] Input: pixcir_i2c_ts: Add Type-B Multi-touch and DT support

2014-03-04 Thread Roger Quadros
Hi Dmitry, Gentle reminder to comment on this series. Thanks. cheers, -roger On 02/26/2014 05:27 PM, Roger Quadros wrote: > Hi, > > This series does the following > > - use devres managed resource allocations > - convert to Type-B multi touch protocol > - support upto 5

[PATCH v2 4/8] Input: pixcir_i2c_ts: Use Type-B Multi-Touch protocol

2014-02-26 Thread Roger Quadros
Switch to using the Type-B Multi-Touch protocol. Signed-off-by: Roger Quadros --- drivers/input/touchscreen/pixcir_i2c_ts.c | 125 ++ 1 file changed, 94 insertions(+), 31 deletions(-) diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input

[PATCH v2 3/8] Input: pixcir_i2c_ts: Get rid of pdata->attb_read_val()

2014-02-26 Thread Roger Quadros
Get rid of the attb_read_val() platform hook. Instead, read the ATTB gpio directly from the driver. Fail if valid ATTB gpio is not provided by patform data. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- drivers/input/touchscreen/pixcir_i2c_ts.c | 16 +++- include/linux

[PATCH v2 5/8] Input: pixcir_i2c_ts: support upto 5 fingers and hardware provided tracking IDs

2014-02-26 Thread Roger Quadros
Some variants of the Pixcir touch controller support upto 5 simultaneous fingers and hardware tracking IDs. Prepare the driver for that. Signed-off-by: Roger Quadros --- drivers/input/touchscreen/pixcir_i2c_ts.c | 74 --- include/linux/input/pixcir_ts.h

[PATCH v2 2/8] Input: pixcir_i2c_ts: Initialize interrupt mode and power mode

2014-02-26 Thread Roger Quadros
Introduce helper functions to configure power and interrupt registers. Default to IDLE mode on probe as device supports auto wakeup to ACVIE mode on detecting finger touch. Configure interrupt mode and polarity on start up. Power down on device closure or module removal. Signed-off-by: Roger

[PATCH v2 0/8] Input: pixcir_i2c_ts: Add Type-B Multi-touch and DT support

2014-02-26 Thread Roger Quadros
://article.gmane.org/gmane.linux.kernel/1616417 cheers, -roger --- Roger Quadros (8): Input: pixcir_i2c_ts: Use devres managed resource allocations Input: pixcir_i2c_ts: Initialize interrupt mode and power mode Input: pixcir_i2c_ts: Get rid of pdata->attb_read_val() Input: pixcir_i2c_ts: Use Typ

[PATCH v2 6/8] Input: pixcir_i2c_ts: Implement wakeup from suspend

2014-02-26 Thread Roger Quadros
Improve the suspend and resume handlers to allow the device to wakeup the system from suspend. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- drivers/input/touchscreen/pixcir_i2c_ts.c | 46 --- 1 file changed, 42 insertions(+), 4 deletions(-) diff --git a

[PATCH v2 8/8] ARM: dts: am43x-epos-evm: Correct Touch controller info

2014-02-26 Thread Roger Quadros
Fixup Y resolution and add default pin state. Also update the compatible id. CC: Benoit Cousson CC: Tony Lindgren CC: Mugunthan V N Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- arch/arm/boot/dts/am43x-epos-evm.dts | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions

[PATCH v2 7/8] Input: pixcir_i2c_ts: Add device tree support

2014-02-26 Thread Roger Quadros
Provide device tree support and binding information. Also provide support for a new chip "pixcir_tangoc". Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- .../bindings/input/touchscreen/pixcir_i2c_ts.txt | 26 .../devicetree/bindings/vendor-prefixes.txt

[PATCH v2 1/8] Input: pixcir_i2c_ts: Use devres managed resource allocations

2014-02-26 Thread Roger Quadros
Use devm_() and friends for allocating memory, input device and IRQ. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- drivers/input/touchscreen/pixcir_i2c_ts.c | 34 --- 1 file changed, 13 insertions(+), 21 deletions(-) diff --git a/drivers/input

Re: [PATCH 1/9] Input: pixcir_i2c_ts: Add device tree support

2013-12-18 Thread Roger Quadros
On 12/18/2013 07:39 PM, Dmitry Torokhov wrote: > Hi Roger, > > On Wed, Dec 18, 2013 at 02:51:12PM +0530, Roger Quadros wrote: >> Provide device tree support and binding information. >> Change platform data parameters from x/y_max to x/y_size.. > > I'd ra

Re: [PATCH 3/9] Input: pixcir_i2c_ts: Initialize interrupt mode and power mode

2013-12-18 Thread Roger Quadros
On 12/18/2013 07:44 PM, Dmitry Torokhov wrote: > On Wed, Dec 18, 2013 at 02:51:14PM +0530, Roger Quadros wrote: >> + >> +static int pixcir_stop(struct pixcir_i2c_ts_data *ts) >> +{ >> +struct device *dev = &ts->client->dev; >> +int ret; &

Re: [PATCH 5/9] Input: pixcir_i2c_ts: Get rid of pdata->attb_read_val()

2013-12-18 Thread Roger Quadros
On 12/18/2013 07:50 PM, Dmitry Torokhov wrote: > On Wed, Dec 18, 2013 at 02:51:16PM +0530, Roger Quadros wrote: >> Get rid of the attb_read_val() platform hook. Instead, >> read the ATTB gpio directly from the driver. >> >> Fail if valid ATTB gpio is not provided by pat

Re: [PATCH 7/9] Input: pixcir_i2c_ts: Implement Type B Multi Touch reporting

2013-12-18 Thread Roger Quadros
Hi Dmitry, On 12/18/2013 07:48 PM, Dmitry Torokhov wrote: > On Wed, Dec 18, 2013 at 02:51:18PM +0530, Roger Quadros wrote: >> Some pixcir controllers e.g. tangoC family report finger IDs with >> the co-ordinates and are more suitable for Type-B MT protocol. >> >> S

[PATCH 1/9] Input: pixcir_i2c_ts: Add device tree support

2013-12-18 Thread Roger Quadros
Provide device tree support and binding information. Change platform data parameters from x/y_max to x/y_size.. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- .../bindings/input/touchscreen/pixcir_i2c_ts.txt | 26 drivers/input/touchscreen/pixcir_i2c_ts.c | 77

[PATCH 4/9] Input: pixcir_i2c_ts: Use devres managed resource allocations

2013-12-18 Thread Roger Quadros
Use devm_() and friends for allocating memory, input device and IRQ. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- drivers/input/touchscreen/pixcir_i2c_ts.c | 35 --- 1 file changed, 13 insertions(+), 22 deletions(-) diff --git a/drivers/input

[PATCH 2/9] Input: pixcir_i2c_ts: Add register definitions

2013-12-18 Thread Roger Quadros
Add power and interrupt register definitions. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- include/linux/input/pixcir_ts.h | 42 + 1 file changed, 42 insertions(+) diff --git a/include/linux/input/pixcir_ts.h b/include/linux/input

[PATCH 7/9] Input: pixcir_i2c_ts: Implement Type B Multi Touch reporting

2013-12-18 Thread Roger Quadros
Some pixcir controllers e.g. tangoC family report finger IDs with the co-ordinates and are more suitable for Type-B MT protocol. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- drivers/input/touchscreen/pixcir_i2c_ts.c | 202 +++--- 1 file changed, 155

[PATCH 5/9] Input: pixcir_i2c_ts: Get rid of pdata->attb_read_val()

2013-12-18 Thread Roger Quadros
Get rid of the attb_read_val() platform hook. Instead, read the ATTB gpio directly from the driver. Fail if valid ATTB gpio is not provided by patform data. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- drivers/input/touchscreen/pixcir_i2c_ts.c | 19 +-- include

[PATCH 3/9] Input: pixcir_i2c_ts: Initialize interrupt mode and power mode

2013-12-18 Thread Roger Quadros
Introduce helper functions to configure power and interrupt registers. Default to IDLE mode on probe as device supports auto wakeup to ACVIE mode on detecting finger touch. Configure interrupt mode and polarity on start up. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- drivers

[PATCH 9/9] Input: pixcir_i2c_ts: Implement wakeup from suspend

2013-12-18 Thread Roger Quadros
Improve the suspend and resume handlers to allow the device to wakeup the system from suspend. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- drivers/input/touchscreen/pixcir_i2c_ts.c | 89 ++- 1 file changed, 63 insertions(+), 26 deletions(-) diff --git

[PATCH 8/9] Input: pixcir_i2c_ts: Add support for TangoC family

2013-12-18 Thread Roger Quadros
Add support for Pixcir TangoC controller. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- .../devicetree/bindings/input/touchscreen/pixcir_i2c_ts.txt | 2 +- drivers/input/touchscreen/pixcir_i2c_ts.c | 6 ++ 2 files changed, 7 insertions(+), 1

[PATCH 6/9] Input: pixcir_i2c_ts: Add chip specific data structure

2013-12-18 Thread Roger Quadros
This is the data that differentiates different pixcir chips. Signed-off-by: Roger Quadros Acked-by: Mugunthan V N --- drivers/input/touchscreen/pixcir_i2c_ts.c | 8 +--- include/linux/input/pixcir_ts.h | 11 +++ 2 files changed, 16 insertions(+), 3 deletions(-) diff

[PATCH 0/9] Input: pixcir_i2c_ts: Add Type-B Multitouch support

2013-12-18 Thread Roger Quadros
Hi, Some variants of the Pixcir I2C touch controller are more suitable for Type-B multi-touch reporting (e.g. Tango C). This series enhances the driver to support Type-B multi-touch reports. It also adds device tree support and power management. cheers, -roger Roger Quadros (9): Input