Re: Bug in i2c-core?

2015-02-28 Thread Thomas Petazzoni
scussion. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org Mor

Re: Bug in i2c-core?

2015-02-27 Thread Thomas Petazzoni
egards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

Re: [PATCH 04/15] iio: adc: at91_adc: Add support for touchscreens without TSMR

2014-03-05 Thread Thomas Petazzoni
q(int irq, struct at91_adc_state *st, u32 status) and this one should be 'static'. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-input"

Re: [PATCH 2/5] input: sun4i-ts: Add support for temperature sensor

2013-12-26 Thread Thomas Petazzoni
use: ts-attached; when a touchscreen is attached. And nothing when no touchscreen is attached. Note that this patch is also changing the DT binding, so it should update the DT binding documentation created in the first patch. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electro

Re: [PATCH 1/5] input: Add new sun4i-ts driver for Allwinner sunxi SoC's rtp controller

2013-12-26 Thread Thomas Petazzoni
const struct of_device_id sun4i_ts_of_match[] = { > + { .compatible = "allwinner,sun4i-ts", }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, sun4i_ts_of_match); You're introducing a new DT binding, so the appropriate documentation should be written for

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Thomas Petazzoni
uld work but is kind of non-obvious when reading a driver's code: that's the problem with bus notifier, they do things a bit "behind your back" without you noticing. Having the driver request its own pinctrl state, and switch between states upon suspend/resume is a lot more expli

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Thomas Petazzoni
suspend()/resume(). > > Using bus notifiers for that is quite a hack IMHO. Agreed. Just like drivers do their ioremap, request_irq and others, they should also request their pin resources using the pinctrl API. Hiding this behind a bus notifier is not nice. Best regards, Thomas -- Tho