Re: [PATCH] HID: input: fix confusion on conflicting mappings

2015-01-08 Thread Fredrik Hallenberg
Jiri, I suppose you can close bugzilla bug 70181? On Thu, Jan 8, 2015 at 6:50 AM, Christopher Head ch...@chead.ca wrote: On Tue, 6 Jan 2015 13:37:26 +0100 Fredrik Hallenberg megahal...@gmail.com wrote: ... if (!(field-flags (HID_MAIN_ITEM_RELATIVE |

Re: [PATCH] HID: input: fix confusion on conflicting mappings

2015-01-06 Thread Fredrik Hallenberg
I can confirm that the patch breaks things when not using n key rollover. If using the Corsair K70 in BIOS mode or just using a plain USB-keyboard keys repeat forever as reported. David, I noticed that in the first version of your patch, where the ignore check was done in hid-core.c, you only

Re: [PATCH] HID: input: fix confusion on conflicting mappings

2015-01-06 Thread David Herrmann
Hi On Tue, Jan 6, 2015 at 1:37 PM, Fredrik Hallenberg megahal...@gmail.com wrote: I can confirm that the patch breaks things when not using n key rollover. If using the Corsair K70 in BIOS mode or just using a plain USB-keyboard keys repeat forever as reported. David, I noticed that in the

Re: [PATCH] HID: input: fix confusion on conflicting mappings

2015-01-06 Thread Jiri Kosina
On Tue, 6 Jan 2015, David Herrmann wrote: On an PC-101/103/104 keyboard (American layout) the 'Enter' key and its neighbours look like this: +---+ +---+ +---+ | 1 | | 2 | | 5 | +---+ +---+ +---+ +---+ +---+

Re: [PATCH] HID: input: fix confusion on conflicting mappings

2015-01-06 Thread David Herrmann
Hi On Tue, Jan 6, 2015 at 10:19 PM, Jiri Kosina jkos...@suse.cz wrote: On Mon, 29 Dec 2014, David Herrmann wrote: On an PC-101/103/104 keyboard (American layout) the 'Enter' key and its neighbours look like this: +---+ +---+ +---+ | 1 | | 2 | | 5 |

Re: [PATCH] HID: input: fix confusion on conflicting mappings

2015-01-06 Thread Jiri Kosina
On Mon, 29 Dec 2014, David Herrmann wrote: On an PC-101/103/104 keyboard (American layout) the 'Enter' key and its neighbours look like this: +---+ +---+ +---+ | 1 | | 2 | | 5 | +---+ +---+ +---+ +---+ +---+ |

Re: [PATCH] HID: input: fix confusion on conflicting mappings

2014-12-30 Thread Christopher Head
Hi, I tried your patch on my North American Das Keyboard 4. In N-key rollover mode the patch fixes the backslash problem. Unfortunately, with the patch applied, when in 6-key rollover mode (which, if I remember correctly, uses a one-byte DATA VAR ABS for modifiers and a six-byte DATA ARRAY ABS for

[PATCH] HID: input: fix confusion on conflicting mappings

2014-12-29 Thread David Herrmann
On an PC-101/103/104 keyboard (American layout) the 'Enter' key and its neighbours look like this: +---+ +---+ +---+ | 1 | | 2 | | 5 | +---+ +---+ +---+ +---+ +---+ | 3 | | 4 | +---+ +---+

Re: [PATCH] HID: input: fix confusion on conflicting mappings

2014-12-29 Thread Fredrik Hallenberg
Thanks for completing the patch, it works fine with my Corsair K70. On Mon, Dec 29, 2014 at 3:21 PM, David Herrmann dh.herrm...@gmail.com wrote: On an PC-101/103/104 keyboard (American layout) the 'Enter' key and its neighbours look like this: +---+ +---+ +---+ | 1