Re: [PATCH] HID: wacom: check for wacom->shared before following the pointer

2015-03-06 Thread Benjamin Tissoires
On Thu, Mar 5, 2015 at 8:54 PM, Ping Cheng wrote: > On Thu, Mar 5, 2015 at 2:36 PM, Benjamin Tissoires > wrote: >> 486b908 (HID: wacom: do not send pen events before touch is up/forced out) >> introduces a kernel oops when plugging a tablet without touch. > > Thank you for the catch. You must hav

Re: [PATCH] HID: wacom: check for wacom->shared before following the pointer

2015-03-05 Thread Ping Cheng
On Thu, Mar 5, 2015 at 2:36 PM, Benjamin Tissoires wrote: > 486b908 (HID: wacom: do not send pen events before touch is up/forced out) > introduces a kernel oops when plugging a tablet without touch. Thank you for the catch. You must have tried an Intuos 4 or earlier model. WACOM_QUIRK_MULTI_INPU

[PATCH] HID: wacom: check for wacom->shared before following the pointer

2015-03-05 Thread Benjamin Tissoires
486b908 (HID: wacom: do not send pen events before touch is up/forced out) introduces a kernel oops when plugging a tablet without touch. wacom->shared is null for these devices so this leads to a null pointer exception. Change the condition to make it clear that what we need is wacom->shared not