Re: [PATCH] Input: don't push static constants on stack for %*ph

2015-12-17 Thread Nick Dyer
> On Wed, 2013-09-04 at 13:41 +0300, Andy Shevchenko wrote: >> There is no need to pass constants via stack. The width may be >> explicitly >> specified in the format. > > Dmitry, any comments on this? Hi Andy- Just to weigh in on the atmel_mxt_ts part - it's made moot by: http://git.kernel.org/

Re: [PATCH] Input: don't push static constants on stack for %*ph

2015-12-14 Thread Dmitry Torokhov
On Thu, Dec 10, 2015 at 5:46 AM, Andy Shevchenko wrote: > On Wed, 2013-09-04 at 13:41 +0300, Andy Shevchenko wrote: >> There is no need to pass constants via stack. The width may be >> explicitly >> specified in the format. > > Dmitry, any comments on this? My personal preference is to have lengt

Re: [PATCH] Input: don't push static constants on stack for %*ph

2015-12-10 Thread Andy Shevchenko
On Wed, 2013-09-04 at 13:41 +0300, Andy Shevchenko wrote: > There is no need to pass constants via stack. The width may be > explicitly > specified in the format. Dmitry, any comments on this? > > Signed-off-by: Andy Shevchenko > --- >  drivers/input/mouse/hgpk.c   | 7 +++ >  dr

Re: [PATCH] Input: don't push static constants on stack for %*ph

2013-11-14 Thread Andy Shevchenko
On Wed, 2013-09-04 at 13:41 +0300, Andy Shevchenko wrote: > There is no need to pass constants via stack. The width may be explicitly > specified in the format. Any comments on this so far? > > Signed-off-by: Andy Shevchenko > --- > drivers/input/mouse/hgpk.c | 7 +++ > drive

[PATCH] Input: don't push static constants on stack for %*ph

2013-09-04 Thread Andy Shevchenko
There is no need to pass constants via stack. The width may be explicitly specified in the format. Signed-off-by: Andy Shevchenko --- drivers/input/mouse/hgpk.c | 7 +++ drivers/input/touchscreen/atmel_mxt_ts.c | 4 ++-- 2 files changed, 5 insertions(+), 6 deletions(-) diff --