Re: [PATCH] Input: gpio_keys: allocate pins

2012-10-25 Thread Daniel Mack
On 25.10.2012 10:08, Linus Walleij wrote: > On Thu, Oct 25, 2012 at 9:58 AM, Lee Jones wrote: >> On Fri, 12 Oct 2012, Linus Walleij wrote: > (...) >>> Is biasing what you need to do? > (...) >>> All I really want is that platforms have a clear idea about >>> how and where the pins will be handled,

Re: [PATCH] Input: gpio_keys: allocate pins

2012-10-25 Thread Lee Jones
On Thu, 25 Oct 2012, Linus Walleij wrote: > On Thu, Oct 25, 2012 at 9:58 AM, Lee Jones wrote: > > On Fri, 12 Oct 2012, Linus Walleij wrote: > (...) > >> Is biasing what you need to do? > (...) > >> All I really want is that platforms have a clear idea about > >> how and where the pins will be han

Re: [PATCH] Input: gpio_keys: allocate pins

2012-10-25 Thread Linus Walleij
On Thu, Oct 25, 2012 at 9:58 AM, Lee Jones wrote: > On Fri, 12 Oct 2012, Linus Walleij wrote: (...) >> Is biasing what you need to do? (...) >> All I really want is that platforms have a clear idea about >> how and where the pins will be handled, and that if GPIO >> and pinctrl handle the same lin

Re: [PATCH] Input: gpio_keys: allocate pins

2012-10-25 Thread Lee Jones
On Fri, 12 Oct 2012, Linus Walleij wrote: > On Fri, Oct 12, 2012 at 11:40 PM, Daniel Mack wrote: > > >> Because we wrote in Documentation/pinctrl.txt that if GPIO > >> and pin control handle the same lines, they should be > >> implemented in the gpio driver by calling out to pinctrl's > >> exter

Re: [PATCH] Input: gpio_keys: allocate pins

2012-10-12 Thread Linus Walleij
On Fri, Oct 12, 2012 at 11:40 PM, Daniel Mack wrote: >> Because we wrote in Documentation/pinctrl.txt that if GPIO >> and pin control handle the same lines, they should be >> implemented in the gpio driver by calling out to pinctrl's >> extern int pinctrl_request_gpio(unsigned gpio); >> extern vo

Re: [PATCH] Input: gpio_keys: allocate pins

2012-10-12 Thread Linus Walleij
On Fri, Oct 12, 2012 at 11:35 PM, Dmitry Torokhov wrote: > On Friday, October 12, 2012 11:26:00 PM Linus Walleij wrote: >> On Fri, Oct 12, 2012 at 5:55 PM, Daniel Mack wrote: >> > This allows DT driven boards to allocate and configure the pinmux once >> > the driver is probed. >> > >> > Signed-of

Re: [PATCH] Input: gpio_keys: allocate pins

2012-10-12 Thread Daniel Mack
On 12.10.2012 23:37, Linus Walleij wrote: > On Fri, Oct 12, 2012 at 11:27 PM, Daniel Mack wrote: >> On 12.10.2012 23:26, Linus Walleij wrote: >>> On Fri, Oct 12, 2012 at 5:55 PM, Daniel Mack wrote: >>> This allows DT driven boards to allocate and configure the pinmux once the driver is

Re: [PATCH] Input: gpio_keys: allocate pins

2012-10-12 Thread Linus Walleij
On Fri, Oct 12, 2012 at 11:27 PM, Daniel Mack wrote: > On 12.10.2012 23:26, Linus Walleij wrote: >> On Fri, Oct 12, 2012 at 5:55 PM, Daniel Mack wrote: >> >>> This allows DT driven boards to allocate and configure the pinmux once >>> the driver is probed. >>> >>> Signed-off-by: Daniel Mack >>> C

Re: [PATCH] Input: gpio_keys: allocate pins

2012-10-12 Thread Dmitry Torokhov
On Friday, October 12, 2012 11:26:00 PM Linus Walleij wrote: > On Fri, Oct 12, 2012 at 5:55 PM, Daniel Mack wrote: > > This allows DT driven boards to allocate and configure the pinmux once > > the driver is probed. > > > > Signed-off-by: Daniel Mack > > Cc: Linus Walleij > > Cc: Dmitry Torokho

Re: [PATCH] Input: gpio_keys: allocate pins

2012-10-12 Thread Daniel Mack
On 12.10.2012 23:26, Linus Walleij wrote: > On Fri, Oct 12, 2012 at 5:55 PM, Daniel Mack wrote: > >> This allows DT driven boards to allocate and configure the pinmux once >> the driver is probed. >> >> Signed-off-by: Daniel Mack >> Cc: Linus Walleij >> Cc: Dmitry Torokhov > > (...) >> +

Re: [PATCH] Input: gpio_keys: allocate pins

2012-10-12 Thread Linus Walleij
On Fri, Oct 12, 2012 at 5:55 PM, Daniel Mack wrote: > This allows DT driven boards to allocate and configure the pinmux once > the driver is probed. > > Signed-off-by: Daniel Mack > Cc: Linus Walleij > Cc: Dmitry Torokhov (...) > + /* request pin mux */ > + pinctrl = devm_pinctrl_

[PATCH] Input: gpio_keys: allocate pins

2012-10-12 Thread Daniel Mack
This allows DT driven boards to allocate and configure the pinmux once the driver is probed. Signed-off-by: Daniel Mack Cc: Linus Walleij Cc: Dmitry Torokhov --- drivers/input/keyboard/gpio_keys.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/input/keyboard/gpio_keys.c b/