RE: [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y

2014-08-13 Thread Dexuan Cui
> -Original Message- > From: Dmitry Torokhov > > How about this: > > in libps2.c let's add and export a function pointer > > i8042_lock_chip_if_port_owner: it is used to replace the current > > if (i8042_check_port_owner(ps2dev->serio)) > > i8042_lock_chip(); > > The functi

Re: [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y

2014-08-13 Thread Dmitry Torokhov
On Wed, Aug 13, 2014 at 05:24:35AM +, Dexuan Cui wrote: > > -Original Message- > > From: Dmitry Torokhov > > Sent: Wednesday, August 13, 2014 1:55 AM > > > > > To decouple the dependency between the hyperv-keyboard and i8042 > > > > > modules, I suppose we probably have to re-implement

RE: [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y

2014-08-12 Thread Dexuan Cui
> -Original Message- > From: KY Srinivasan > > The Arch users can simply select to build i8042 into the kernel as a > > workaround. > > > > The proper solution is to allow loading libps2 module even if i8042 did not > find > > its device. I wish I could simply drop this i8042_lock_chip and

RE: [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y

2014-08-12 Thread Dexuan Cui
> -Original Message- > From: Dmitry Torokhov > Sent: Wednesday, August 13, 2014 1:55 AM > > > > To decouple the dependency between the hyperv-keyboard and i8042 > > > > modules, I suppose we probably have to re-implement hyperv- > keyboard by > > > > using input_allocate_device(), input_reg

RE: [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y

2014-08-12 Thread KY Srinivasan
...@aepfle.de; > a...@canonical.com; jasow...@redhat.com; KY Srinivasan; Haiyang Zhang > Subject: Re: [PATCH] Input: serio: make HYPERV_KEYBOARD depend on > SERIO_I8042=y > > On Tue, Aug 12, 2014 at 07:15:25AM +, Dexuan Cui wrote: > > > -Original Message- > > > Fro

Re: [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y

2014-08-12 Thread Dmitry Torokhov
On Tue, Aug 12, 2014 at 07:15:25AM +, Dexuan Cui wrote: > > -Original Message- > > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > > ow...@vger.kernel.org] On Behalf Of Greg KH > > > > What exactly needs to be done to fix this "correctly" that is going to > > > > take t

RE: [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y

2014-08-12 Thread Dexuan Cui
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Greg KH > > > What exactly needs to be done to fix this "correctly" that is going to > > > take too much work at the moment? > > > > To decouple the dependency between

Re: [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y

2014-08-11 Thread Greg KH
On Tue, Aug 12, 2014 at 05:51:28AM +, Dexuan Cui wrote: > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > > Decoupling the dependency between hyperv_keyboard and i8042 needs > > > non-trivial efforts and is hence a long term goal. > > > > > > For now, let'

RE: [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y

2014-08-11 Thread Dexuan Cui
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Decoupling the dependency between hyperv_keyboard and i8042 needs > > non-trivial efforts and is hence a long term goal. > > > > For now, let's make the dependency explicit so people can beware of this. > > You did

Re: [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y

2014-08-11 Thread Greg KH
On Mon, Aug 11, 2014 at 08:30:40PM -0700, Dexuan Cui wrote: > hyperv_keyboard invokes serio_interrupt(), which needs a valid serio driver > like atkbd.c. > atkbd.c depends on libps2.c because it invokes ps2_command(). > libps2.c depends on i8042.c because it invokes i8042_check_port_owner(). > As a

[PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y

2014-08-11 Thread Dexuan Cui
hyperv_keyboard invokes serio_interrupt(), which needs a valid serio driver like atkbd.c. atkbd.c depends on libps2.c because it invokes ps2_command(). libps2.c depends on i8042.c because it invokes i8042_check_port_owner(). As a result, hyperv_keyboard actually depends on i8042.c. For a Generatio