Re: [PATCH] i2c-HID: Delete unnecessary checks before the function call "gpiod_put"

2015-07-09 Thread Benjamin Tissoires
On Thu, Jul 9, 2015 at 8:34 AM, Jiri Kosina wrote: > On Wed, 8 Jul 2015, SF Markus Elfring wrote: > >> From: Markus Elfring >> Date: Wed, 8 Jul 2015 22:12:25 +0200 >> >> The gpiod_put() function performs also input parameter validation >> by forwarding its single input pointer to the gpiod_free()

Re: [PATCH] i2c-HID: Delete unnecessary checks before the function call "gpiod_put"

2015-07-09 Thread Jiri Kosina
On Wed, 8 Jul 2015, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 8 Jul 2015 22:12:25 +0200 > > The gpiod_put() function performs also input parameter validation > by forwarding its single input pointer to the gpiod_free() function. > Thus the test around the calls is not needed.

Re: [PATCH] i2c-HID: Delete unnecessary checks before the function call "gpiod_put"

2015-07-09 Thread Dan Carpenter
This one deserves some extra review because it introduces a call to: WARN_ON(extra_checks); in gpiod_free(). That may or may not matter... regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.

[PATCH] i2c-HID: Delete unnecessary checks before the function call "gpiod_put"

2015-07-08 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 8 Jul 2015 22:12:25 +0200 The gpiod_put() function performs also input parameter validation by forwarding its single input pointer to the gpiod_free() function. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software.