Re: [PATCH 01/15] mfd: add new driver for Sharp LoCoMo

2014-11-14 Thread Dmitry Eremin-Solenikov
2014-11-14 18:10 GMT+03:00 Mark Brown : > On Fri, Nov 14, 2014 at 04:47:00PM +0400, Dmitry Eremin-Solenikov wrote: > >> I'm actually looking at the regulator interface. Since this DAC serves mostly >> like a (semi-)constant voltage interface, would it be rather logical to use >> regulator subsystem

Re: [PATCH 01/15] mfd: add new driver for Sharp LoCoMo

2014-11-14 Thread Mark Brown
On Fri, Nov 14, 2014 at 04:47:00PM +0400, Dmitry Eremin-Solenikov wrote: > I'm actually looking at the regulator interface. Since this DAC serves mostly > like a (semi-)constant voltage interface, would it be rather logical to use > regulator subsystem to drive it? Possibly... it's mostly a func

Re: [PATCH 01/15] mfd: add new driver for Sharp LoCoMo

2014-11-14 Thread Dmitry Eremin-Solenikov
Hello, 2014-11-05 23:24 GMT+03:00 Mark Brown : > On Thu, Nov 06, 2014 at 12:02:49AM +0400, Dmitry Eremin-Solenikov wrote: >> 2014-11-03 16:41 GMT+03:00 Linus Walleij : > >> > The point is still the same: no unrelated code in drivers/mfd, >> > then either use IIO DAC as a middle layer or sink the D

Re: [PATCH 01/15] mfd: add new driver for Sharp LoCoMo

2014-11-05 Thread Lars-Peter Clausen
On 11/05/2014 09:32 PM, Lars-Peter Clausen wrote: If it is a generic DAC it should go into drivers/iio/, this will allow code sharing and code re-usability. Given the simplicity of the DAC there might even be other existing drivers that can be used to control it. I just had a quick look and I t

Re: [PATCH 01/15] mfd: add new driver for Sharp LoCoMo

2014-11-05 Thread Lars-Peter Clausen
On 11/05/2014 09:02 PM, Dmitry Eremin-Solenikov wrote: 2014-11-03 16:41 GMT+03:00 Linus Walleij : On Fri, Oct 31, 2014 at 10:54 AM, Dmitry Eremin-Solenikov wrote: 2014-10-31 10:42 GMT+03:00 Linus Walleij : It seems some DAC handling is part of the MFD driver, and we recently discussed that

Re: [PATCH 01/15] mfd: add new driver for Sharp LoCoMo

2014-11-05 Thread Mark Brown
On Thu, Nov 06, 2014 at 12:02:49AM +0400, Dmitry Eremin-Solenikov wrote: > 2014-11-03 16:41 GMT+03:00 Linus Walleij : > > The point is still the same: no unrelated code in drivers/mfd, > > then either use IIO DAC as a middle layer or sink the DAC handling > > into respective subdriver, i.e. push i

Re: [PATCH 01/15] mfd: add new driver for Sharp LoCoMo

2014-11-05 Thread Dmitry Eremin-Solenikov
2014-11-03 16:41 GMT+03:00 Linus Walleij : > On Fri, Oct 31, 2014 at 10:54 AM, Dmitry Eremin-Solenikov > wrote: >> 2014-10-31 10:42 GMT+03:00 Linus Walleij : > >>> It seems some DAC handling is part of the MFD driver, and we recently >>> discussed that MFD should not be doing misc stuff but mainly

Re: [PATCH 01/15] mfd: add new driver for Sharp LoCoMo

2014-11-03 Thread Linus Walleij
On Fri, Oct 31, 2014 at 10:54 AM, Dmitry Eremin-Solenikov wrote: > 2014-10-31 10:42 GMT+03:00 Linus Walleij : >> It seems some DAC handling is part of the MFD driver, and we recently >> discussed that MFD should not be doing misc stuff but mainly act as >> arbiter and switching station. >> >> Can

Re: [PATCH 01/15] mfd: add new driver for Sharp LoCoMo

2014-10-31 Thread Dmitry Eremin-Solenikov
Hello, Thank you for the review of patches. 2014-10-31 10:42 GMT+03:00 Linus Walleij : > On Tue, Oct 28, 2014 at 1:01 AM, Dmitry Eremin-Solenikov > wrote: > >> LoCoMo is a GA used on Sharp Zaurus SL-5x00. Current driver does has >> several design issues (special bus instead of platform bus, does

Re: [PATCH 01/15] mfd: add new driver for Sharp LoCoMo

2014-10-31 Thread Linus Walleij
On Tue, Oct 28, 2014 at 1:01 AM, Dmitry Eremin-Solenikov wrote: > LoCoMo is a GA used on Sharp Zaurus SL-5x00. Current driver does has > several design issues (special bus instead of platform bus, doesn't use > mfd-core, etc). > > Implement 'core' parts of locomo support as an mfd driver. > > Sig

[PATCH 01/15] mfd: add new driver for Sharp LoCoMo

2014-10-27 Thread Dmitry Eremin-Solenikov
LoCoMo is a GA used on Sharp Zaurus SL-5x00. Current driver does has several design issues (special bus instead of platform bus, doesn't use mfd-core, etc). Implement 'core' parts of locomo support as an mfd driver. Signed-off-by: Dmitry Eremin-Solenikov --- drivers/mfd/Kconfig| 8 +