Re: [PATCH v2] Input: Add driver for Microchip's CAP1106

2014-07-15 Thread Mark Rutland
On Tue, Jul 15, 2014 at 05:41:49PM +0100, Dmitry Torokhov wrote: > Hi Mark, > > On Tue, Jul 15, 2014 at 09:51:38AM +0100, Mark Rutland wrote: > > On Mon, Jul 14, 2014 at 11:20:17AM +0100, Daniel Mack wrote: > > > > > > linux,keycode feels a bit overkill here though, so I'd rather go for a > > > f

Re: [PATCH v2] Input: Add driver for Microchip's CAP1106

2014-07-15 Thread Dmitry Torokhov
Hi Mark, On Tue, Jul 15, 2014 at 09:51:38AM +0100, Mark Rutland wrote: > On Mon, Jul 14, 2014 at 11:20:17AM +0100, Daniel Mack wrote: > > > > linux,keycode feels a bit overkill here though, so I'd rather go for a > > fixed-size linux,keycodes property. The number of entries is fixed, > > anyway.

Re: [PATCH v2] Input: Add driver for Microchip's CAP1106

2014-07-15 Thread Mark Rutland
On Tue, Jul 15, 2014 at 10:12:22AM +0100, Daniel Mack wrote: > On 07/15/2014 10:51 AM, Mark Rutland wrote: > > On Mon, Jul 14, 2014 at 11:20:17AM +0100, Daniel Mack wrote: > > >> Hmm, I thought about that, but there are - in theory - more details that > >> could be specified per channel. I left th

Re: [PATCH v2] Input: Add driver for Microchip's CAP1106

2014-07-15 Thread Daniel Mack
On 07/15/2014 10:51 AM, Mark Rutland wrote: > On Mon, Jul 14, 2014 at 11:20:17AM +0100, Daniel Mack wrote: >> Hmm, I thought about that, but there are - in theory - more details that >> could be specified per channel. I left those functions out for the first >> version, as I have no good way to te

Re: [PATCH v2] Input: Add driver for Microchip's CAP1106

2014-07-15 Thread Mark Rutland
On Mon, Jul 14, 2014 at 11:20:17AM +0100, Daniel Mack wrote: > Hi Mark, > > thanks a lot for your feedback! Much appreciated. > > On 07/14/2014 11:52 AM, Mark Rutland wrote: > > On Fri, Jul 11, 2014 at 11:06:33AM +0100, Daniel Mack wrote: > > >> +++ b/Documentation/devicetree/bindings/input/cap1

Re: [PATCH v2] Input: Add driver for Microchip's CAP1106

2014-07-14 Thread Daniel Mack
Hi Mark, thanks a lot for your feedback! Much appreciated. On 07/14/2014 11:52 AM, Mark Rutland wrote: > On Fri, Jul 11, 2014 at 11:06:33AM +0100, Daniel Mack wrote: >> +++ b/Documentation/devicetree/bindings/input/cap1106.txt >> @@ -0,0 +1,63 @@ >> +Device tree bindings for Microchip CAP1106, 6

Re: [PATCH v2] Input: Add driver for Microchip's CAP1106

2014-07-14 Thread Mark Rutland
On Fri, Jul 11, 2014 at 11:06:33AM +0100, Daniel Mack wrote: > This patch adds a driver for Microchips CAP1106, an I2C driven, 6-channel > capacitive touch sensor. > > For now, only the capacitive buttons are supported, and no specific > settings that can be tweaked for individual channels, except

[PATCH v2] Input: Add driver for Microchip's CAP1106

2014-07-11 Thread Daniel Mack
This patch adds a driver for Microchips CAP1106, an I2C driven, 6-channel capacitive touch sensor. For now, only the capacitive buttons are supported, and no specific settings that can be tweaked for individual channels, except for the device-wide sensitivity gain. The defaults seem to work just f