[PATCH v3 4/4] mfd: max8997: move regmap handling to function drivers

2014-03-13 Thread Robert Baldyga
This patch moves code creating new i2c clients and regmaps to function drivers which use them. It allows to avoid creating this instances when individual function drivers are not enabled. Signed-off-by: Robert Baldyga --- drivers/extcon/extcon-max8997.c | 131 +-- dr

Re: [PATCH v3 4/4] mfd: max8997: move regmap handling to function drivers

2014-03-13 Thread Krzysztof Kozlowski
On Thu, 2014-03-13 at 10:38 +0100, Robert Baldyga wrote: > This patch moves code creating new i2c clients and regmaps to function > drivers which use them. It allows to avoid creating this instances when > individual function drivers are not enabled. > > Signed-off-by: Robert Baldyga > --- > dri

Re: [PATCH v3 4/4] mfd: max8997: move regmap handling to function drivers

2014-03-13 Thread Chanwoo Choi
Hi Robert, Is it necessary? If previous mfd driver has various i2c line, previous mfd driver initialize regmap/i2c setting on mfd driver. I'm not sure that regmap/i2c setting code move from mfd driver to each driver. Dear Lee Jones, I need your opinion about moving regmap/i2c code from mfd drive

Re: [PATCH v3 4/4] mfd: max8997: move regmap handling to function drivers

2014-03-13 Thread Lee Jones
> Is it necessary? If previous mfd driver has various i2c line, previous mfd > driver > initialize regmap/i2c setting on mfd driver. > I'm not sure that regmap/i2c setting code move from mfd driver to each driver. > > Dear Lee Jones, > I need your opinion about moving regmap/i2c code from mfd dri

Re: [PATCH v3 4/4] mfd: max8997: move regmap handling to function drivers

2014-03-13 Thread Mark Brown
On Thu, Mar 13, 2014 at 12:55:04PM +, Lee Jones wrote: > > Is it necessary? If previous mfd driver has various i2c line, previous mfd > > driver > > initialize regmap/i2c setting on mfd driver. > > I'm not sure that regmap/i2c setting code move from mfd driver to each > > driver. > > > > Dea

Re: [PATCH v3 4/4] mfd: max8997: move regmap handling to function drivers

2014-03-14 Thread Robert Baldyga
Hi, On 03/13/2014 03:09 PM, Mark Brown wrote: > On Thu, Mar 13, 2014 at 12:55:04PM +, Lee Jones wrote: >>> Is it necessary? If previous mfd driver has various i2c line, previous mfd >>> driver >>> initialize regmap/i2c setting on mfd driver. >>> I'm not sure that regmap/i2c setting code move

Re: [PATCH v3 4/4] mfd: max8997: move regmap handling to function drivers

2014-03-18 Thread Lee Jones
> >>> Is it necessary? If previous mfd driver has various i2c line, previous > >>> mfd driver > >>> initialize regmap/i2c setting on mfd driver. > >>> I'm not sure that regmap/i2c setting code move from mfd driver to each > >>> driver. > >>> > >>> Dear Lee Jones, > >>> I need your opinion about m