[PATCH v8] Touchscreen driver for FT5x06 based EDT displays

2012-07-08 Thread simon . budig
From: Simon Budig This is a driver for the EDT "Polytouch" family of touch controllers based on the FocalTech FT5x06 line of chips. Signed-off-by: Simon Budig --- Documentation/input/edt-ft5x06.txt | 56 ++ drivers/input/touchscreen/Kconfig | 13 + drivers/input/touchscreen/Makefi

[PATCH v8] Touchscreen driver for FT5x06 based EDT displays

2012-07-08 Thread simon . budig
Hi all. This is a new iteration of the driver for the edt ft5x06 based polytouch series of touchscreens. This version moves some of the code in separate functions as requested by Henrik (with one exception where I did not see the point, namely the inital readout of some sensor parameters in _prob

Re: [PATCH v8] Touchscreen driver for FT5x06 based EDT displays

2012-07-09 Thread Henrik Rydberg
Hi Simon, On Sun, Jul 08, 2012 at 06:05:22PM +0200, simon.bu...@kernelconcepts.de wrote: > From: Simon Budig > > This is a driver for the EDT "Polytouch" family of touch controllers > based on the FocalTech FT5x06 line of chips. > > Signed-off-by: Simon Budig > --- (The area below the '---' c

Re: [PATCH v8] Touchscreen driver for FT5x06 based EDT displays

2012-07-18 Thread Dmitry Torokhov
Hi Simon, Henrik, On Mon, Jul 09, 2012 at 10:06:40AM +0200, Henrik Rydberg wrote: > Hi Simon, > > On Sun, Jul 08, 2012 at 06:05:22PM +0200, simon.bu...@kernelconcepts.de wrote: > > From: Simon Budig > > > > This is a driver for the EDT "Polytouch" family of touch controllers > > based on the Fo

Re: [PATCH v8] Touchscreen driver for FT5x06 based EDT displays

2012-07-19 Thread Henrik Rydberg
Hi Dmitry, > OK, so the patch below should fix most of Henrik's comments and some of > mine. Compile-tested only though. It would be nice to have it verified > on real hardware so we could get it in in the next merge window. Looking good, just a question for Simon: In the mt report function, the

Re: [PATCH v8] Touchscreen driver for FT5x06 based EDT displays

2012-07-19 Thread Simon Budig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/19/2012 03:50 PM, Henrik Rydberg wrote: > Looking good, just a question for Simon: In the mt report > function, the loop uses every fourth byte of rdbuf, but the access > looks a bit funny; buf[5], buf[6] etc. It is fine as long as it > works, ju