Add device tree support for twl4030 keypad driver.
Tested on Nokia N900.
Signed-off-by: Sebastian Reichel
---
drivers/input/keyboard/twl4030_keypad.c | 91 +++--
1 file changed, 74 insertions(+), 17 deletions(-)
diff --git a/drivers/input/keyboard/twl4030_keypad.c
Hi!
> + if (of_get_property(np, "linux,input-no-autorepeat", NULL))
> + keypad_data->no_autorepeat = true;
>From 2/2:
+Optional Properties specific to linux:
+- linux,keypad-no-autorepeat: do not enable autorepeat feature.
I'm confused now.
--
(english) http://www.livejournal.
Hi,
On Mon, Nov 11, 2013 at 11:19:41PM +0100, Pavel Machek wrote:
> > + if (of_get_property(np, "linux,input-no-autorepeat", NULL))
> > + keypad_data->no_autorepeat = true;
>
> From 2/2:
>
> +Optional Properties specific to linux:
> +- linux,keypad-no-autorepeat: do not enable autore
Hi!
> On Mon, Nov 11, 2013 at 11:19:41PM +0100, Pavel Machek wrote:
> > > + if (of_get_property(np, "linux,input-no-autorepeat", NULL))
> > > + keypad_data->no_autorepeat = true;
> >
> > From 2/2:
> >
> > +Optional Properties specific to linux:
> > +- linux,keypad-no-autorepeat: do not e
On Sun, Nov 17, 2013 at 07:28:40PM +0100, Pavel Machek wrote:
> Hi!
>
> > On Mon, Nov 11, 2013 at 11:19:41PM +0100, Pavel Machek wrote:
> > > > + if (of_get_property(np, "linux,input-no-autorepeat", NULL))
> > > > + keypad_data->no_autorepeat = true;
> > >
> > > From 2/2:
> >
Hi!
> > > DRIVER CODEDOCUMENTATION
> > > twl4030-keypad linux,input-no-autorepeat linux,keypad-no-autorepeat
> > > omap4-keypadlinux,input-no-autorepeat linux,keypad-no-autorepeat
> > > samsung-keypad linux,input-no-autorepeat linux,keyp
Hi,
> > > I'd suggest just simple "autorepeat", so that we get rid of ugly
> > > double-negation.
> > The idea was that majority of setups want autorepeat so in the absence
> > of the property autorepeat is turned on.
>
> I see... but autorepeat on by default makes sense on devices that are
> us