Re: [Patch v1 7/7] DA9055 Onkey driver

2012-09-17 Thread Ashish Jangam
jun Chen > Subject: Re: [Patch v1 7/7] DA9055 Onkey driver > > On Friday 14 September 2012 07:04 PM, Ashish Jangam wrote: > > +static irqreturn_t da9055_onkey_irq(int irq, void *data) > > +{ > > + struct input_dev *input_dev = data; > > + > > + input_re

Re: [Patch v1 7/7] DA9055 Onkey driver

2012-09-14 Thread Laxman Dewangan
On Friday 14 September 2012 07:04 PM, Ashish Jangam wrote: +static irqreturn_t da9055_onkey_irq(int irq, void *data) +{ + struct input_dev *input_dev = data; + + input_report_key(input_dev, KEY_POWER, 1); When do you send the release key event? Overall driver looks like you can use

[Patch v1 7/7] DA9055 Onkey driver

2012-09-14 Thread Ashish Jangam
This is the ONKEY driver of the Dialog DA9055 PMIC and depends on the DA9055 MFD core driver. This patch is functionally tested on SMDK6410 board. Signed-off-by: David Dajun Chen Signed-off-by: Ashish Jangam --- drivers/input/misc/Kconfig| 10 +++ drivers/input/misc/Makefile |