Re: [patch] HID: wacom: bitwise vs logical ORs

2015-12-17 Thread Jiri Kosina
On Wed, 16 Dec 2015, Jason Gerecke wrote: > This patch looks fine to me (the 'prox' calculation /should/ be > logical, but I suppose bitwise works too :D). Found two other bugs > from c7f0522 while reviewing though -- I'll have patches for you > shortly. > > Reviewed-by: Jason Gerecke

Re: [patch] HID: wacom: bitwise vs logical ORs

2015-12-16 Thread Jason Gerecke
On Wed, Dec 16, 2015 at 6:57 AM, Jiri Kosina wrote: > On Wed, 9 Dec 2015, Dan Carpenter wrote: > >> Smatch complains that these should probably be bitwise ORs instead of >> logical. It doesn't matter for "prox" but it makes a difference for >> "strip1" and "strip2". >> >>

Re: [patch] HID: wacom: bitwise vs logical ORs

2015-12-16 Thread Jiri Kosina
On Wed, 9 Dec 2015, Dan Carpenter wrote: > Smatch complains that these should probably be bitwise ORs instead of > logical. It doesn't matter for "prox" but it makes a difference for > "strip1" and "strip2". > > Fixes: c7f0522a1ad1 ('HID: wacom: Slim down wacom_intuos_pad processing') >

[patch] HID: wacom: bitwise vs logical ORs

2015-12-09 Thread Dan Carpenter
Smatch complains that these should probably be bitwise ORs instead of logical. It doesn't matter for "prox" but it makes a difference for "strip1" and "strip2". Fixes: c7f0522a1ad1 ('HID: wacom: Slim down wacom_intuos_pad processing') Signed-off-by: Dan Carpenter diff