> > > Adding Rob to CC as he wrote of_irq_get and put it into
> > > platform_get_irq. Rob, we use of_irq_get() in the I2C core and the
> > > question is now if we need to dispose the mapping and if so what would
> > > be a good place for it so managed devices will not have their mappings
> > > rem
Hi Wolfram,
On Sunday 08 March 2015 09:26:17 Wolfram Sang wrote:
> On Wed, Mar 04, 2015 at 09:22:37AM +0100, Wolfram Sang wrote:
> I am writing an I2C touchscreen driver for an i.MX6 based board. I
> compiled it as a module and when I unload it, I get the following
> warning:
>
On Wed, Mar 04, 2015 at 09:22:37AM +0100, Wolfram Sang wrote:
>
> > > > I am writing an I2C touchscreen driver for an i.MX6 based board. I
> > > > compiled it as a module and when I unload it, I get the following
> > > > warning:
> > > >
> > > > # modprobe sx8654
> > > > [ 46.261494] input: SX
> > > I am writing an I2C touchscreen driver for an i.MX6 based board. I
> > > compiled it as a module and when I unload it, I get the following warning:
> > >
> > > # modprobe sx8654
> > > [ 46.261494] input: SX8654 I2C Touchscreen as
> > > /devices/soc0/soc/210.aips-bus/21a.i2c/i2c-0/
> > Yes, this commit breaks all drivers using devm* for IRQ management on
> > OF-based systemsi because devm* cleanup happens in device code, after
> > bus's remove() method returns. I'd recommend reverting and finding a
> > better way (making cleanup a custom devm action as well?).
>
> Ouch, my
Hi Dmitry,
On Friday 27 February 2015 08:59:44 Dmitry Torokhov wrote:
> On Fri, Feb 27, 2015 at 12:09:51PM +0100, Sébastien SZYMANSKI wrote:
> > Hi,
> >
> > I am writing an I2C touchscreen driver for an i.MX6 based board. I
> > compiled it as a module and when I unload it, I get the following war
Dmitry, Uwe,
On Fri, 27 Feb 2015 19:39:49 +0100, Uwe Kleine-König wrote:
> > Input is allocated with devm_* and input_register_device knows how to
> > deal with that:
> ah, something new each day. Thanks for teaching me.
Thanks as well, I also discovered that thanks to this discussion.
Best reg
Hi,
I am writing an I2C touchscreen driver for an i.MX6 based board. I
compiled it as a module and when I unload it, I get the following warning:
# modprobe sx8654
[ 46.261494] input: SX8654 I2C Touchscreen as
/devices/soc0/soc/210.aips-bus/21a.i2c/i2c-0/0-0048/input/input1
# rmmod sx86
Hello,
On Fri, Feb 27, 2015 at 09:46:11AM -0800, Dmitry Torokhov wrote:
> On Fri, Feb 27, 2015 at 06:05:45PM +0100, Uwe Kleine-König wrote:
> > On Fri, Feb 27, 2015 at 07:29:30AM -0800, Dmitry Torokhov wrote:
> > > On February 27, 2015 6:37:25 AM PST, Thomas Petazzoni
> > > wrote:
> > > >Dear Sé
On Fri, Feb 27, 2015 at 06:05:45PM +0100, Uwe Kleine-König wrote:
> On Fri, Feb 27, 2015 at 07:29:30AM -0800, Dmitry Torokhov wrote:
> > On February 27, 2015 6:37:25 AM PST, Thomas Petazzoni
> > wrote:
> > >Dear Sébastien SZYMANSKI,
> > >
> > >On Fri, 27 Feb 2015 12:09:51 +0100, Sébastien SZYMANS
On Fri, Feb 27, 2015 at 07:29:30AM -0800, Dmitry Torokhov wrote:
> On February 27, 2015 6:37:25 AM PST, Thomas Petazzoni
> wrote:
> >Dear Sébastien SZYMANSKI,
> >
> >On Fri, 27 Feb 2015 12:09:51 +0100, Sébastien SZYMANSKI wrote:
> >
> >> error = input_register_device(sx8654->input);
> >>
On Fri, Feb 27, 2015 at 08:59:44AM -0800, Dmitry Torokhov wrote:
> On Fri, Feb 27, 2015 at 12:09:51PM +0100, Sébastien SZYMANSKI wrote:
> > Hi,
> >
> > I am writing an I2C touchscreen driver for an i.MX6 based board. I
> > compiled it as a module and when I unload it, I get the following warning:
On Fri, Feb 27, 2015 at 12:09:51PM +0100, Sébastien SZYMANSKI wrote:
> Hi,
>
> I am writing an I2C touchscreen driver for an i.MX6 based board. I
> compiled it as a module and when I unload it, I get the following warning:
>
> # modprobe sx8654
> [ 46.261494] input: SX8654 I2C Touchscreen as
>
On February 27, 2015 6:37:25 AM PST, Thomas Petazzoni
wrote:
>Dear Sébastien SZYMANSKI,
>
>On Fri, 27 Feb 2015 12:09:51 +0100, Sébastien SZYMANSKI wrote:
>
>> error = input_register_device(sx8654->input);
>> if (error)
>> return error;
>
>Where is your ->remove() f
Dear Sébastien SZYMANSKI,
On Fri, 27 Feb 2015 12:09:51 +0100, Sébastien SZYMANSKI wrote:
> error = input_register_device(sx8654->input);
> if (error)
> return error;
Where is your ->remove() function that unregisters the input device?
Best regards,
Thomas
--
Th
15 matches
Mail list logo
