Re: Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices

2013-07-09 Thread Ferruh Yigit
On 07/07/2013 10:15 PM, Geert Uytterhoeven wrote: On Fri, Jul 5, 2013 at 1:51 AM, Linux Kernel Mailing List wrote: +++ b/drivers/input/touchscreen/cyttsp4_spi.c +static int cyttsp_spi_xfer(struct device *dev, u8 *xfer_buf, + u8 op, u8 reg, u8 *buf, int length) +{

Re: Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices

2013-07-07 Thread Geert Uytterhoeven
On Fri, Jul 5, 2013 at 1:51 AM, Linux Kernel Mailing List wrote: > +++ b/drivers/input/touchscreen/cyttsp4_spi.c > +static int cyttsp_spi_xfer(struct device *dev, u8 *xfer_buf, > + u8 op, u8 reg, u8 *buf, int length) > +{ > + if (reg > 255) As "reg" is "u8", this

Re: Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices

2013-07-03 Thread Dan Carpenter
On Wed, Jul 03, 2013 at 04:24:18PM +0300, Ferruh Yigit wrote: > I have a patch for this, but should I create it against previous patch I > have sent or against latest next tree? > Latest linux-next. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-input"

Re: Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices

2013-07-03 Thread Ferruh Yigit
On 07/03/2013 12:47 AM, Dan Carpenter wrote: Hello Ferruh Yigit, The patch 67bf12ca50d5: "Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices" from Jun 30, 2013, leads to the following Smatch warning: "drivers/input/touchscreen/cyttsp4_spi.c:66 cyttsp_spi_xfe

re: Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices

2013-07-02 Thread Dan Carpenter
Hello Ferruh Yigit, The patch 67bf12ca50d5: "Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices" from Jun 30, 2013, leads to the following Smatch warning: "drivers/input/touchscreen/cyttsp4_spi.c:66 cyttsp_spi_xfer() warn: impossible condition '(reg &g

Re: [PATCH v3 4/4] Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices

2013-06-06 Thread Greg Kroah-Hartman
On Tue, Jun 04, 2013 at 12:34:44PM +0300, Ferruh Yigit wrote: > Cypress TrueTouch(tm) Standard Product controllers, > Generation4 devices, SPI adapter module. > > This driver adds communication support with TTSP controller > using SPI bus. > > Signed-off-by: Ferruh Yigit Acked-by: Greg Kroah-Ha

[PATCH v3 4/4] Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices

2013-06-04 Thread Ferruh Yigit
Cypress TrueTouch(tm) Standard Product controllers, Generation4 devices, SPI adapter module. This driver adds communication support with TTSP controller using SPI bus. Signed-off-by: Ferruh Yigit --- drivers/input/touchscreen/Kconfig |9 ++ drivers/input/touchscreen/Makefile |

[PATCH v2 3/3] Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices

2012-09-14 Thread Ferruh Yigit
Cypress TrueTouch(tm) Standard Product controllers, Generation4 devices, SPI adapter module. This driver adds communication support with TTSP controller using SPI bus. Signed-off-by: Ferruh Yigit --- drivers/input/touchscreen/Kconfig | 12 ++ drivers/input/touchscreen/Makefile |