RE: [PATCH v2] HID: wacom: Fix wacom_probe error handling

2012-09-17 Thread Ping Cheng
If device_remove_file is needed for hid-wacom.c, it should be considered for wacm_sys.c as well. Eduard, what do you think? Ping -Original Message- From: Axel Lin [mailto:axel@gmail.com] Sent: Monday, September 17, 2012 1:54 AM To: Jiri Kosina Cc: Przemo Firszt; Ping Cheng; linux-

Re: [PATCH v2] HID: wacom: Fix wacom_probe error handling

2012-09-18 Thread Przemo Firszt
On Mon, 2012-09-17 at 16:53 +0800, Axel Lin wrote: > OLEDs/LED are not critical for tablet functioning thus ignore OLED/LED > initialisation failures. > > This patch does clean up all the sysfs attribute files in error paths. > > Signed-off-by: Axel Lin > --- > drivers/hid/hid-wacom.c | 23 ++

Re: [PATCH v2] HID: wacom: Fix wacom_probe error handling

2012-09-19 Thread Jiri Kosina
On Tue, 18 Sep 2012, Przemo Firszt wrote: > > OLEDs/LED are not critical for tablet functioning thus ignore OLED/LED > > initialisation failures. > > > > This patch does clean up all the sysfs attribute files in error paths. > > > > Signed-off-by: Axel Lin > > --- > > drivers/hid/hid-wacom.c |