On Mon, 16 Nov 2015, David Binderman wrote:
> Hello there,
>
> drivers/hid/wacom_wac.c:2484:35: warning: logical ‘or’ of collectively
> exhaustive tests is always true [-Wlogical-op]
>
> Source code is
>
> if (features->type>= INTUOSHT || features->type <= BAMBOO_PT)
Good catch, that code is
Oh, boy! It should be:
if (features->type>= INTUOSHT && features->type <= BAMBOO_PT)
Thank you David for your sharp eyes ;-).
Jiri,
Can you fix it upstream or do you need a patch from me?
Ping
On Mon, Nov 16, 2015 at 2:39 PM, Jiri Kosina wrote:
> On Mon, 16 Nov 2015, David Binderman wrote:
On Mon, 16 Nov 2015, Ping Cheng wrote:
> Oh, boy! It should be:
>
> if (features->type>= INTUOSHT && features->type <= BAMBOO_PT)
>
> Thank you David for your sharp eyes ;-).
>
> Jiri,
>
> Can you fix it upstream or do you need a patch from me?
Yup, I have already comitted fix with David's R