>From Jiri Kosina , Wed, Sep 03, 2014 at 04:37:05PM +0200:
> On Wed, 3 Sep 2014, Dylan Alex Simon wrote:
>
> > I think that did the trick. I've run through the whole cycle about 20 times
> > in various conditions, and it seems solid so far. Thanks!
>
> Thanks. I actually think that the minimal
On Wed, 3 Sep 2014, Benjamin Tissoires wrote:
> > From: Benjamin Tissoires
> > Date: Tue, 2 Sep 2014 15:50:43 -0400
> > Subject: [PATCH] HID: thingm: set the proper error code before leaving
> >
> > In case of an unsupported firmware, the driver bails out without setting
> > the LEDs interfaces,
On Tue, Sep 2, 2014 at 3:58 PM, Benjamin Tissoires
wrote:
> Hi,
>
> On 09/02/2014 01:46 PM, Dylan Alex Simon wrote:
>> Whenever either disconnecting the USB device or simply rmmod'ing the module
>> (even when not in use), I get a kernel panic. I haven't managed to capture a
>> backtrace, but at l
On Wed, 3 Sep 2014, Dylan Alex Simon wrote:
> I think that did the trick. I've run through the whole cycle about 20 times
> in various conditions, and it seems solid so far. Thanks!
Thanks. I actually think that the minimal necessary fix is below. Could
you please do a (hopefully last) round o
> Hrm, what we really want is to first destroy the LED interface, otherwise
> someone might have re-queued the workqueue through thingm_led_set() after
> it has been flushed / cancelled already.
>
> Could you please give it one more shot with the patch below? Thanks for
> your prompt testing.
>
> I sent you wrong version of the patch, sorry for that. Could you please
> try the one below instead?
>
>
> diff --git a/drivers/hid/hid-thingm.c b/drivers/hid/hid-thingm.c
> index 134be89..dffc50d 100644
> --- a/drivers/hid/hid-thingm.c
> +++ b/drivers/hid/hid-thingm.c
> @@ -208,7 +208,7 @@ un
On Wed, 3 Sep 2014, Dylan Alex Simon wrote:
> Still no luck (it really is using the new module, even though it didn't
> rebuild the kernel). I should also mention this is gcc 4.9.1. I can rebuild
> with 4.8.3 if there's a reason to suspect that, though I haven't seen any
> other issues.
>
> [
On Wed, 3 Sep 2014, Dylan Alex Simon wrote:
> > Alright, this supports my original hunch. I think I see the race. Could
> > you please try the patch below? Thanks.
> >
> >
> >
> >
> > diff --git a/drivers/hid/hid-thingm.c b/drivers/hid/hid-thingm.c
> > index 134be89..743a517 100644
> > --- a/
>From Jiri Kosina , Wed, Sep 03, 2014 at 09:29:07AM +0200:
> On Tue, 2 Sep 2014, Dylan Alex Simon wrote:
>
> > Some combination of kernel debugging options and killing processes let it
> > survive long enough to write the backtrace to disk. A simple modprobe/rmmod
> > wasn't enough, though, it re
On Tue, 2 Sep 2014, Dylan Alex Simon wrote:
> Some combination of kernel debugging options and killing processes let it
> survive long enough to write the backtrace to disk. A simple modprobe/rmmod
> wasn't enough, though, it required a few tries removing the device and then
> rmmod (though has d
>From Jiri Kosina , Tue, Sep 02, 2014 at 11:32:30PM +0200:
> On Tue, 2 Sep 2014, Benjamin Tissoires wrote:
>
> > > Whenever either disconnecting the USB device or simply rmmod'ing the
> > > module
> > > (even when not in use), I get a kernel panic. I haven't managed to
> > > capture a
> > > bac
On Tue, 2 Sep 2014, Benjamin Tissoires wrote:
> > Whenever either disconnecting the USB device or simply rmmod'ing the module
> > (even when not in use), I get a kernel panic. I haven't managed to capture
> > a
> > backtrace, but at least the first two lines were saved after an rmmod:
> >
> > 1
>From Benjamin Tissoires , Tue, Sep 02, 2014 at
>03:58:08PM -0400:
> Hi,
>
> On 09/02/2014 01:46 PM, Dylan Alex Simon wrote:
> > Whenever either disconnecting the USB device or simply rmmod'ing the module
> > (even when not in use), I get a kernel panic. I haven't managed to capture
> > a
> > b
Hi,
On 09/02/2014 01:46 PM, Dylan Alex Simon wrote:
> Whenever either disconnecting the USB device or simply rmmod'ing the module
> (even when not in use), I get a kernel panic. I haven't managed to capture a
> backtrace, but at least the first two lines were saved after an rmmod:
>
> 18:53:17 k
Whenever either disconnecting the USB device or simply rmmod'ing the module
(even when not in use), I get a kernel panic. I haven't managed to capture a
backtrace, but at least the first two lines were saved after an rmmod:
18:53:17 kernel: thingm 0003:27B8:01ED.0004: hidraw3: USB HID v1.01 Devic
15 matches
Mail list logo
