Re: [PATCH] scripts: Make cleanfile/cleanpatch warn about long lines

2007-05-25 Thread H. Peter Anvin
Andrew Morton wrote: > On Fri, 25 May 2007 17:58:26 -0700 "H. Peter Anvin" <[EMAIL PROTECTED]> wrote: > >> Make the "cleanfile" and "cleanpatch" script warn about long lines, >> by default lines whose visual width exceeds 79 characters. >> >> Per suggestion from Auke Kok. >> >> Signed-off-by: H.

Re: [PATCH] fix compat console unimap regression

2007-05-25 Thread David Miller
From: Hugh Dickins <[EMAIL PROTECTED]> Date: Sat, 26 May 2007 00:39:17 +0100 (BST) > Why is it that since the 2f1a2ccb9c0de632ab07193becf5f7121794f6ae console > UTF-8 fixes went into 2.6.22-rc1, the PowerMac G5 shows only inverse video > question marks for the text on tty2-6? whereas tty1 is

Re: [PATCH] scripts: Make cleanfile/cleanpatch warn about long lines

2007-05-25 Thread Andrew Morton
On Fri, 25 May 2007 17:58:26 -0700 "H. Peter Anvin" <[EMAIL PROTECTED]> wrote: > Make the "cleanfile" and "cleanpatch" script warn about long lines, > by default lines whose visual width exceeds 79 characters. > > Per suggestion from Auke Kok. > > Signed-off-by: H. Peter Anvin <[EMAIL

reg: modules make in Ubuntu

2007-05-25 Thread Tej Parkash
make[1]: Entering directory `/usr/src/linux-headers-2.6.20-15-generic' CHK include/linux/version.h CHK include/linux/utsrelease.h make[2]: *** No rule to make target `arch/i386/kernel/msr.c', needed by `arch/i386/kernel/msr.o'. Stop. make[1]: *** [arch/i386/kernel] Error 2 make[1]:

Re: [AppArmor 01/41] Pass struct vfsmount to the inode_create LSM hook

2007-05-25 Thread Crispin Cowan
Casey Schaufler wrote: > --- Andreas Gruenbacher <[EMAIL PROTECTED]> wrote: > >> AppArmor cannot assume anything about argv[0], >> >> and it would be a really bad idea to change the well-established semantics of >> >> argv[0]. >> >> There is no actual need for looking at argv[0], though:

Re: [AppArmor 01/41] Pass struct vfsmount to the inode_create LSM hook

2007-05-25 Thread Kyle Moffett
On May 24, 2007, at 14:58:41, Casey Schaufler wrote: On Fedora zcat, gzip and gunzip are all links to the same file. I can imagine (although it is a bit of a stretch) allowing a set of users access to gunzip but not gzip (or the other way around). That is a COMPLETE straw-man argument. I

Re: BUG in 2.6.22-rc2-mm1: NIC module b44.c broken (Broadcom 4400)

2007-05-25 Thread Michael Buesch
On Friday 25 May 2007 21:40, Uwe Bugla wrote: > Am Freitag, 25. Mai 2007 20:48 schrieben Sie: > > On Fri, 25 May 2007 17:59:29 +0200, Uwe Bugla wrote: > > > Perhaps someone reading this could try to reproduce that problem on his > > > machine. > > > Now who of the readers owes a Broadcom 4401 NIC

[PATCH] fix compat futex code for private futexes

2007-05-25 Thread Ulrich Drepper
When the private futex support was added the compat code wasn't changed. The result is that code using compat code which fail, e.g., because the timeout values are not correctly passed. The following patch should fix that. Signed-off-by: Ulrich Drepper <[EMAIL PROTECTED]> ---

Linux v2.6.22-rc3

2007-05-25 Thread Linus Torvalds
It's Friday evening, and the US is preparing for a long three-day weekend, often considered the official start of summer here. So what's a pasty white nerd to do? You can't go out on the beach, because the goodlooking people will laugh at you, and kick sand in your face. I'm not bitter. But

[PATCH, RFT, v4] sata_mv: convert to new EH

2007-05-25 Thread Jeff Garzik
Already uncovered and fixed a few bugs in v3. Here's v4 of the sata_mv new-EH patch. diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index 705a020..4a75b48 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c @@ -192,8 +192,10 @@ enum { EDMA_ERR_DEV_DCON = (1

Re: [PATCH] AFS: Implement file locking

2007-05-25 Thread Kyle Moffett
On May 25, 2007, at 22:23:42, J. Bruce Fields wrote: On Thu, May 24, 2007 at 05:55:54PM +0100, David Howells wrote: + /* only whole-file locks are supported */ + if (fl->fl_start != 0 || fl->fl_end != OFFSET_MAX) + return -EINVAL; Do you allow upgrades and

Re: [PATCH 1/1] Work around Dell E520 BIOS reboot bug.

2007-05-25 Thread Matt Domsch
On Wed, May 23, 2007 at 01:12:44PM -0600, Tim Gardner wrote: > From: Tim Gardner <[EMAIL PROTECTED]> > Subject: [PATCH] Work around Dell E520 BIOS reboot bug. > > Force Dell E520 to use the BIOS to shutdown/reboot. > > Signed-off-by: Tim Gardner <[EMAIL PROTECTED]> Acked-by: Matt Domsch <[EMAIL

Re: [PROBLEM] 2.6.22-rc2 panics on x86-64 with slub

2007-05-25 Thread Srihari Vijayaraghavan
--- Christoph Lameter <[EMAIL PROTECTED]> wrote: > I finally figured out the second issue. Took some time to get that figure > out. Sorry. But now all the bug reports make sense. [...] Impressive Christoph. Indeed, this fixes my problem on latest -git (its hg equivalent :-)). Well done.

Re: 2.6.22-rc1-mm1: evm BUG when reading sysfs file

2007-05-25 Thread Reiner Sailer
On Tue, 22 May 2007 03:25:48 -0400 [EMAIL PROTECTED] (Joseph Fannin) wrote: > > I've been getting this since 2.6.21-rc7-mm1: > > [2.379310] BUG: unable to handle kernel paging request at virtual address 4400d340 > [2.379491] printing eip: > [2.379573] c021c978 > [2.379656]

[PATCH] x86: fix oprofile double free (was Re: Multiple free during oprofile unload)

2007-05-25 Thread Chris Wright
* Alan Cox ([EMAIL PROTECTED]) wrote: > I'd agree entirely with Dave - if you are applying a fix to something > that is currently totally broken which may make it work and which doesn't > affect any other bit of code then it goes into the stable tree. And, in this case we're in luck. It's not

Re: [PATCH] AFS: Implement file locking

2007-05-25 Thread J. Bruce Fields
On Thu, May 24, 2007 at 05:55:54PM +0100, David Howells wrote: > +/* > + * initialise the lock manager thread if it isn't already running > + */ > +static int afs_init_lock_manager(void) > +{ > + if (!afs_lock_manager) { > + afs_lock_manager =

Re: Current utrace breaks UML

2007-05-25 Thread Jeff Dike
On Fri, May 25, 2007 at 06:35:13PM -0700, Roland McGrath wrote: > Oops! I overlooked the need to preserve the orig_eax value, though its > necessity is obvious. This makes me wonder about those previous > reports that UML was working OK. The one from me was on x86_64, where PTRACE_SYSEMU isn't

Re: [PROBLEM] 2.6.22-rc2 panics on x86-64 with slub

2007-05-25 Thread Christoph Lameter
I finally figured out the second issue. Took some time to get that figure out. Sorry. But now all the bug reports make sense. Here is the fix SLUB: Fix NUMA / SYSFS bootstrap issue The kmem_cache_node cache is very special because it is needed for NUMA bootstrap. Under certain conditions

Re: [AppArmor 01/41] Pass struct vfsmount to the inode_create LSM hook

2007-05-25 Thread Tetsuo Handa
Hello. Casey Schaufler wrote: > Sorry, but I don't understand your objection. If AppArmor is configured > to allow everyone access to /bin/gzip but only some people access to > /bin/gunzip and (important detail) the single binary uses argv[0] > as documented and (another important detail) there

Re: Current utrace breaks UML

2007-05-25 Thread Roland McGrath
> UML, obviously. Below is a smaller test. orig_eax is wrong, so you > can't read the system call number from the process. Oops! I overlooked the need to preserve the orig_eax value, though its necessity is obvious. This makes me wonder about those previous reports that UML was working OK. I

Re: [RFD] BIO_RW_BARRIER - what it means for devices, filesystems, and dm/md.

2007-05-25 Thread Andreas Dilger
On May 25, 2007 17:58 +1000, Neil Brown wrote: >These devices would find it very hard to support BIO_RW_BARRIER. >Doing this would require keeping track of all in-flight requests >(which some, possibly all, of the above don't) and then: > When a BIO_RW_BARRIER request arrives: >

[PATCH] scripts: Make cleanfile/cleanpatch warn about long lines

2007-05-25 Thread H. Peter Anvin
Make the "cleanfile" and "cleanpatch" script warn about long lines, by default lines whose visual width exceeds 79 characters. Per suggestion from Auke Kok. Signed-off-by: H. Peter Anvin <[EMAIL PROTECTED]> --- scripts/cleanfile | 54 ++-

Re: [ckrm-tech] [RFC] [PATCH 0/3] Add group fairness to CFS

2007-05-25 Thread Peter Williams
Srivatsa Vaddagiri wrote: Good example :) USER2's single task will have to share its CPU with USER1's 50 tasks (unless we modify the smpnice load balancer to disregard cpu affinity that is - which I would not prefer to do). I don't think that ignoring cpu affinity is an option. Setting the

Re: [git patches] libata fixes

2007-05-25 Thread Jeff Garzik
Mikael Pettersson wrote: On Fri, 25 May 2007 18:03:07 -0400, Jeff Garzik wrote: Jeff Garzik (4): [libata] sata_promise: fix flags typo ... --- a/drivers/ata/sata_promise.c +++ b/drivers/ata/sata_promise.c @@ -297,7 +297,7 @@ static const struct ata_port_info pdc_port_info[] = {

Re: rmmod e1000 hangs (Was Re: 2.6.22-rc2-mm1)

2007-05-25 Thread Herbert Xu
On Fri, May 25, 2007 at 07:48:14PM -0400, Jeff Garzik wrote: > > Is this for -stable or upstream? I got confused with all the patches > flying about. > > Send it to me, if it's for upstream. It's for upstream. Once you take then I'll rediff it for stable. [E1000]: Restore netif_poll_enable

trivial typo in CodingStyle patch

2007-05-25 Thread Claudio Fontana
Hello, I casually noticed this trivial typo while lurking the mailing list archives: Signed-off-by: Auke Kok <[EMAIL PROTECTED]> [...] diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle index f518395..3635b38 100644 --- a/Documentation/CodingStyle +++ b/Documentation/CodingStyle

Re: [git patches] libata fixes

2007-05-25 Thread Mikael Pettersson
On Fri, 25 May 2007 18:03:07 -0400, Jeff Garzik wrote: >Jeff Garzik (4): > [libata] sata_promise: fix flags typo ... >--- a/drivers/ata/sata_promise.c >+++ b/drivers/ata/sata_promise.c >@@ -297,7 +297,7 @@ static const struct ata_port_info pdc_port_info[] = { > > /* board_2057x_pata */

Re: 2.6.22-rc2-mm1: NetworkManager fails to find ipw2200 again

2007-05-25 Thread Andrew Morton
On Fri, 25 May 2007 16:12:57 -0700 Greg KH <[EMAIL PROTECTED]> wrote: > On Fri, May 25, 2007 at 06:01:09PM -0500, Matt Mackall wrote: > > Bisect sequence went 56+ 84+ 98+ 105- 102- 100+ 101+. Looks like 102's > > to blame: > > > > driver-core-check-return-code-of-sysfs_create_link.patch > > >

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-25 Thread H. Peter Anvin
Ben Collins wrote: > On Fri, 2007-05-25 at 16:28 -0700, H. Peter Anvin wrote: >> Jesse Barnes wrote: >>> But how often do you have to debug bootloader or compressed boot code? In >>> fact, most debug output like this isn't very useful after some initial >>> debugging, so we usually take it out.

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-25 Thread Ben Collins
On Fri, 2007-05-25 at 16:28 -0700, H. Peter Anvin wrote: > Jesse Barnes wrote: > > > > But how often do you have to debug bootloader or compressed boot code? In > > fact, most debug output like this isn't very useful after some initial > > debugging, so we usually take it out. I'm not sure

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-25 Thread Jesse Barnes
On Friday, May 25, 2007 4:43:41 H. Peter Anvin wrote: > Jesse Barnes wrote: > > Right, but you're special that way. And moreover, you would know how to > > add such debug statements as needed. But is this output something we > > really need enabled unconditionally for everyone? > > *I* can do

Re: rmmod e1000 hangs (Was Re: 2.6.22-rc2-mm1)

2007-05-25 Thread Jeff Garzik
Kok, Auke wrote: Herbert Xu wrote: On Fri, May 25, 2007 at 11:04:04PM +1000, Herbert Xu wrote: [E1000]: Call netif_poll_enable in e1000_open Here is a better one. [E1000]: Restore netif_poll_enable call but make sure IRQs are off This restores the previously removed netif_poll_enable call

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-25 Thread H. Peter Anvin
Jesse Barnes wrote: > > Right, but you're special that way. And moreover, you would know how to add > such debug statements as needed. But is this output something we really need > enabled unconditionally for everyone? > *I* can do that, yes, but I usually don't have access to the platform

Re: 2.6.22-rc2-mm1: NetworkManager fails to find ipw2200 again

2007-05-25 Thread Kay Sievers
On Fri, 2007-05-25 at 16:12 -0700, Greg KH wrote: > On Fri, May 25, 2007 at 06:01:09PM -0500, Matt Mackall wrote: > > Bisect sequence went 56+ 84+ 98+ 105- 102- 100+ 101+. Looks like 102's > > to blame: > > > > driver-core-check-return-code-of-sysfs_create_link.patch > > > > From: Cornelia Huck

[PATCH] fix compat console unimap regression

2007-05-25 Thread Hugh Dickins
Why is it that since the 2f1a2ccb9c0de632ab07193becf5f7121794f6ae console UTF-8 fixes went into 2.6.22-rc1, the PowerMac G5 shows only inverse video question marks for the text on tty2-6? whereas tty1 is fine, and so is x86. No fault of that patch: by removing the old fallback behaviour, it

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-25 Thread Jesse Barnes
On Friday, May 25, 2007 4:28:18 H. Peter Anvin wrote: > Jesse Barnes wrote: > > But how often do you have to debug bootloader or compressed boot code? > > In fact, most debug output like this isn't very useful after some initial > > debugging, so we usually take it out. I'm not sure why this

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-25 Thread H. Peter Anvin
Jesse Barnes wrote: > > But how often do you have to debug bootloader or compressed boot code? In > fact, most debug output like this isn't very useful after some initial > debugging, so we usually take it out. I'm not sure why this would be any > different... > You're asking me this? I

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-25 Thread Jesse Barnes
On Friday, May 25, 2007 12:45:40 H. Peter Anvin wrote: > Ben Collins wrote: > > On Fri, 2007-05-25 at 13:33 +0200, Andi Kleen wrote: > >> Ben Collins <[EMAIL PROTECTED]> writes: > >> > >> Why? > > > > Because there's no other way to make the kernel totally quiet. We've > > been patching this out

Re: 2.6.22-rc2-mm1: NetworkManager fails to find ipw2200 again

2007-05-25 Thread Greg KH
On Fri, May 25, 2007 at 06:01:09PM -0500, Matt Mackall wrote: > Bisect sequence went 56+ 84+ 98+ 105- 102- 100+ 101+. Looks like 102's > to blame: > > driver-core-check-return-code-of-sysfs_create_link.patch > > From: Cornelia Huck <[EMAIL PROTECTED]> > > Check for return value of

Re: 2.6.22-rc2-mm1: NetworkManager fails to find ipw2200 again

2007-05-25 Thread Matt Mackall
On Fri, May 25, 2007 at 04:01:52PM -0500, Matt Mackall wrote: > On Fri, May 25, 2007 at 12:53:19PM -0500, Matt Mackall wrote: > > On Fri, May 25, 2007 at 07:37:46PM +0200, Kay Sievers wrote: > > > On 5/25/07, Greg KH <[EMAIL PROTECTED]> wrote: > > > >On Fri, May 25, 2007 at 11:36:22AM -0500, Matt

Re: [PATCH] MIPS: Transform old-style macros to newer "__noreturn" standard.

2007-05-25 Thread Satyam Sharma
On 5/26/07, H. Peter Anvin <[EMAIL PROTECTED]> wrote: Satyam Sharma wrote: >> >> Sorry to say, but weren't you the person who didn't recognize !! as the >> idiomatic booleanizing operator? > > Yes, of course, please prove a link / connection between that and this? > Very simple: it shows a lack

Re: [patch 4/7] ps3: Storage Driver Probing

2007-05-25 Thread Benjamin Herrenschmidt
On Fri, 2007-05-25 at 21:48 +0200, Geert Uytterhoeven wrote: > > > + msleep_interruptible(ms); > > > + if (ms < 6) > > > + ms <<= 1; > > > > Is this timeout only for the disk spinup, or also for detecting > media > > added at run time, like inserting a

Re: [patch 5/7] ps3: Disk Storage Driver

2007-05-25 Thread Benjamin Herrenschmidt
On Fri, 2007-05-25 at 21:40 +0200, Geert Uytterhoeven wrote: > > I used a kthread because the request function of a block device driver > must be > non-blocking, and ps3stor_read_write_sectors() calls > wait_for_completion(). Which as I said before looks terribly sad... Why the heck would it

Re: [patch 5/7] ps3: Disk Storage Driver

2007-05-25 Thread Benjamin Herrenschmidt
> So the hypervison uses guest-real addresses here? I would have expected > it to use the kernel page tables, which lets you use vmap() to do > scatter-gather. Ugh ? Maybe s390 can do that but no other hypervisor that I know about :-) It would be nice, sure, but heh. > I don't really understand

Re: [PATCH] MIPS: Transform old-style macros to newer "__noreturn" standard.

2007-05-25 Thread H. Peter Anvin
Satyam Sharma wrote: >> >> Sorry to say, but weren't you the person who didn't recognize !! as the >> idiomatic booleanizing operator? > > Yes, of course, please prove a link / connection between that and this? > Very simple: it shows a lack of understanding of idiomatic use of C. -hpa

Re: [patch 4/7] ps3: Storage Driver Probing

2007-05-25 Thread Benjamin Herrenschmidt
On Fri, 2007-05-25 at 18:18 +0200, Arnd Bergmann wrote: > > +static u64 ps3stor_wait_for_completion(u64 devid, u64 tag, > > +unsigned int timeout) > > +{ > > + unsigned int retries = 0; > > + u64 res = -1, status; > > + > > + for (retries = 0;

Re: [PATCH 2.6.21 1/3] x86_64: EFI64 support

2007-05-25 Thread chandramouli narayanan
Andi Kleen wrote: On Tuesday 01 May 2007 20:59:46 Chandramouli Narayanan wrote: General note on EFI x86_64 support -- More review. This code unfortunately has some problems. First this seems to be quite different from what the 32bit EFI support does

Re: [patch 6/7] ps3: ROM Storage Driver

2007-05-25 Thread Benjamin Herrenschmidt
On Fri, 2007-05-25 at 13:24 +0200, Olaf Hering wrote: > On Fri, May 25, [EMAIL PROTECTED] wrote: > > > +++ b/drivers/scsi/ps3rom.c > > > + kaddr = kmap_atomic(sgpnt->page, KM_USER0); > > linux/highmem.h is not included to get the kmap_* prototypes. Beside, I don't see the

Re: [patch 5/7] ps3: Disk Storage Driver

2007-05-25 Thread Arnd Bergmann
On Friday 25 May 2007, Geert Uytterhoeven wrote: > On Fri, 25 May 2007, Arnd Bergmann wrote: > > > Ok, but why does it call wait_for_completion() then? > > I thought you could end_that_request_* from the interrupt handler instead. > > Actually I tried that first, but I ran into other problems,

Re: [PATCH] MIPS: Transform old-style macros to newer "__noreturn" standard.

2007-05-25 Thread Satyam Sharma
On 5/26/07, H. Peter Anvin <[EMAIL PROTECTED]> wrote: Satyam Sharma wrote: > > But __attribute__((noreturn)) is simply a _function attribute_. Of course, > it is legal / valid only for functions with return-type void, so it does > make > sense to combine both void and __attribute__((noreturn))

Re: [patch 1/7] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver

2007-05-25 Thread Benjamin Herrenschmidt
On Fri, 2007-05-25 at 10:36 +0200, [EMAIL PROTECTED] wrote: > -#if defined(CONFIG_FB_PS3) || defined(CONFIG_FB_PS3_MODULE) > +#if defined(CONFIG_FB_PS3) || defined(CONFIG_FB_PS3_MODULE) || \ > +defined(CONFIG_PS3_FLASH_MODULE) || > defined(CONFIG_PS3_FLASH_MODULE) As I said multiple times,

Re: [PATCH] MIPS: Transform old-style macros to newer "__noreturn" standard.

2007-05-25 Thread H. Peter Anvin
Satyam Sharma wrote: > > But __attribute__((noreturn)) is simply a _function attribute_. Of course, > it is legal / valid only for functions with return-type void, so it does > make > sense to combine both void and __attribute__((noreturn)) in the same > macro like you say. But that's not

Re: [PATCH] MIPS: Transform old-style macros to newer "__noreturn" standard.

2007-05-25 Thread Satyam Sharma
Hi Peter, On 5/26/07, H. Peter Anvin <[EMAIL PROTECTED]> wrote: Robert P. J. Day wrote: >> ... and declare functions as: >> >> __noreturn f(); >> >> ... which is the syntactially sane way of doing it. > > that may be, but keep in mind that gcc allows attributes to *follow* > the parameter list

Re: rmmod e1000 hangs (Was Re: 2.6.22-rc2-mm1)

2007-05-25 Thread Kok, Auke
Herbert Xu wrote: On Fri, May 25, 2007 at 11:04:04PM +1000, Herbert Xu wrote: [E1000]: Call netif_poll_enable in e1000_open Here is a better one. [E1000]: Restore netif_poll_enable call but make sure IRQs are off This restores the previously removed netif_poll_enable call in e1000_open.

[GIT PULL] please pull infiniband.git

2007-05-25 Thread Roland Dreier
Linus, please pull from master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This tree is also available from kernel.org mirrors at: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This will get a few more 2.6.22-rc2 fixes: Eli

[git patches] libata fixes

2007-05-25 Thread Jeff Garzik
And a few trivial documentation patches. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/libata-scsi.c |5 ++- drivers/ata/pata_artop.c |2 +-

Re: [2.6.22-rc1-mm1] ehci-hcd - BUG: scheduling while atomic: rmmod/0x00000001/4568

2007-05-25 Thread Andrew Morton
On Fri, 25 May 2007 14:40:05 -0700 Greg KH <[EMAIL PROTECTED]> wrote: > On Mon, May 21, 2007 at 11:44:37AM +0900, Mattia Dongili wrote: > > Hello, > > > > with gregkh-usb-usb-ehci-cpufreq-fix.patch removing ehci-hcd causes the > > following BUG: > > Thanks for letting me know. > > Stuart, any

Re: idle=poll burns my box [was Re: 2.6.22-rc2-mm1]

2007-05-25 Thread Andrew Morton
On Fri, 25 May 2007 23:20:25 +0200 "J.A. Magallón" <[EMAIL PROTECTED]> wrote: > Is idle=poll a quick and dirty way to burn your box in flames ? yep ;) It makes the CPU(s) busy-wait when they have nothing else to do. It was originally added as a thing to maybe save a few cycles of latency in

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Brice Goglin
Eric W. Biederman wrote: > @@ -1677,43 +1650,16 @@ static int __devinit msi_ht_cap_enabled(struct > pci_dev *dev) > return 0; > } > > -/* Check the hypertransport MSI mapping to know whether MSI is enabled or > not */ > +/* Enable MSI on hypertransport chipsets supporting MSI */ >

Re: [2.6.22-rc1-mm1] ehci-hcd - BUG: scheduling while atomic: rmmod/0x00000001/4568

2007-05-25 Thread Greg KH
On Mon, May 21, 2007 at 11:44:37AM +0900, Mattia Dongili wrote: > Hello, > > with gregkh-usb-usb-ehci-cpufreq-fix.patch removing ehci-hcd causes the > following BUG: Thanks for letting me know. Stuart, any help here? thanks, greg k-h > [ 459.800033] BUG: scheduling while atomic:

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Greg KH
On Fri, May 25, 2007 at 03:06:22PM -0600, Eric W. Biederman wrote: > Greg KH <[EMAIL PROTECTED]> writes: > > It's a trade off, and I'd like to choose the one that over the long > > term, causes the least ammount of work and maintaiblity. I think the > > current blacklist meets that goal. > > A

Re: 2.6.22-rc2 built on ppc (1)

2007-05-25 Thread Greg KH
On Sun, May 20, 2007 at 01:04:19PM +0200, Elimar Riesebieter wrote: > Hi, > > FYI, building 2.6.22-rc2 with > gcc (GCC) 4.1.3 20070514 (prerelease) (Debian 4.1.2-7) > on my powerbook (PPC) gives: > > ... > arch/powerpc/kernel/pci_32.c: In function 'pcibios_assign_resources': >

Re: any value to "NORET_TYPE" macro?

2007-05-25 Thread Adrian Bunk
On Fri, May 25, 2007 at 03:40:18PM -0400, Robert P. J. Day wrote: > On Sat, 26 May 2007, Satyam Sharma wrote: > > > Hi Robert, > > > > On 5/25/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote: > > > On Fri, 25 May 2007, Satyam Sharma wrote: > > > ... > > > > 1. If this is a function _declaration_

Re: [PATCH] MIPS: Transform old-style macros to newer "__noreturn" standard.

2007-05-25 Thread H. Peter Anvin
Robert P. J. Day wrote: >> ... and declare functions as: >> >> __noreturn f(); >> >> ... which is the syntactially sane way of doing it. > > that may be, but keep in mind that gcc allows attributes to *follow* > the parameter list as well, and some people might prefer to do the > following: > >

Re: Nvidiafb issues on Inspiron 8100

2007-05-25 Thread Antonino A. Daplas
On Thu, 2007-05-24 at 01:37 -0400, Dmitry Torokhov wrote: > Hi Antonino, > > I am having the following issues on my Dell Inspiron 8100. They are not > new but I just got around to report them. > > With CONFIG_FB_NVIDIA_I2C I get 1600x1200 resolution but pixels > "swarming" and it is unuseable.

Re: double exclamation (!!) suckage in the kernel

2007-05-25 Thread Satyam Sharma
On 5/26/07, Al Viro <[EMAIL PROTECTED]> wrote: On Sat, May 26, 2007 at 02:26:11AM +0530, Satyam Sharma wrote: > also be brave enough to take a C quiz here :-) > > >what type should x have for !!x to be a valid expression? > > Any integer type (includes pointers) Er, no... Pointers are

Re: double exclamation (!!) suckage in the kernel

2007-05-25 Thread Al Viro
On Fri, May 25, 2007 at 10:32:13PM +0100, Al Viro wrote: > On Sat, May 26, 2007 at 02:26:11AM +0530, Satyam Sharma wrote: > > also be brave enough to take a C quiz here :-) > > > > >what type should x have for !!x to be a valid expression? > > > > Any integer type (includes pointers) >

Re: [PATCH 1/2] non-string based tsc unstable reasons

2007-05-25 Thread Daniel Walker
On Fri, 2007-05-25 at 23:05 +0200, Andi Kleen wrote: > On Fri, May 25, 2007 at 12:32:10PM -0700, Daniel Walker wrote: > > Just passing a string to mark_tsc_unstable() doesn't allow real code to > > change > > based on the reason for the instablility. I changed mark_tsc_unstable() > > to accept a

Re: BUG in 2.6.22-rc2-mm1: Parts of Alsa sound architecture broken

2007-05-25 Thread Takashi Iwai
At Fri, 25 May 2007 10:28:06 -0700, Andrew Morton wrote: > > On Fri, 25 May 2007 18:01:34 +0200 Takashi Iwai <[EMAIL PROTECTED]> wrote: > > > At Thu, 24 May 2007 13:09:21 -0700, > > Andrew Morton wrote: > > > > > > On Thu, 24 May 2007 22:00:52 +0200 > > > "Uwe Bugla" <[EMAIL PROTECTED]> wrote:

Re: double exclamation (!!) suckage in the kernel

2007-05-25 Thread Al Viro
On Sat, May 26, 2007 at 02:26:11AM +0530, Satyam Sharma wrote: > also be brave enough to take a C quiz here :-) > > >what type should x have for !!x to be a valid expression? > > Any integer type (includes pointers) Er, no... Pointers are not integer types *and* you can use ! on any

Re: [PATCH] pata_hpt37x: Further improvements based on the IDE updates and vendor drivers

2007-05-25 Thread Jeff Garzik
Alan Cox wrote: Better DPLL use and calibration Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] [CodingStyle] Add comment to not put spaces before tabs.

2007-05-25 Thread H. Peter Anvin
Kok, Auke wrote: > > ahh yes, I'll incorporate that. > > BTW, would it be possible for cleanfile/cleanpatch to dump warnings to > stderr for lines exceeding 80 characters? I think that would really be > useful... > Should be trivial enough to do, although it probably should be an option.

Re: [patch 5/7] ps3: Disk Storage Driver

2007-05-25 Thread Geert Uytterhoeven
On Fri, 25 May 2007, Arnd Bergmann wrote: > On Friday 25 May 2007, Geert Uytterhoeven wrote: > > > I don't really understand what the kthread is needed for. You probably > > > thought about multiple options and ended up with this, but having > > > a comment in front of it might be helpful. > > >

idle=poll burns my box [was Re: 2.6.22-rc2-mm1]

2007-05-25 Thread J.A. Magallón
On Wed, 23 May 2007 00:42:33 -0700, Andrew Morton <[EMAIL PROTECTED]> wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc2/2.6.22-rc2-mm1/ > Don't know if it's specific to this kernel, but as I have realized it now... I booted with idle=poll to check some issues

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Roland Dreier
> I think for most of Intel I can reduce my test to: > If (bus == 0 , device == 0, function == 0 && vendor == Intel && > has a pci express capability) { > Enable msi on all busses(). > } MSI was working on every Intel PCI-X chipset I ever saw too... - R. - To unsubscribe from this

Re: double exclamation (!!) suckage in the kernel

2007-05-25 Thread David Miller
From: "Satyam Sharma" <[EMAIL PROTECTED]> Date: Sat, 26 May 2007 01:53:59 +0530 WHat is with multiple people asking about "!!" all of a sudden today? > Are all these occurrences merely the debris of > s/something/!notsomething/g kind of patches or is there some > dark, unknown C / gcc wizardry I

Re: [PATCH] MIPS: Transform old-style macros to newer "__noreturn" standard.

2007-05-25 Thread Robert P. J. Day
On Fri, 25 May 2007, H. Peter Anvin wrote: > Robert P. J. Day wrote: > > > > > > f() __attribute__((noreturn)) ; > > > > you get: > > > > warning: data definition has no type or storage class > > > > but gcc doesn't complain if you declare it thusly: > > > > __attribute__((noreturn)) f() ;

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Eric W. Biederman
Greg KH <[EMAIL PROTECTED]> writes: >> MSI appears to have enough problems that enabling it in a kernel >> that is supposed to run lots of different hardware (like a distro >> kernel) is a recipe for disaster. > > Oh, I agree it's a major pain in the ass at times... > > But I'm real hesitant to

2.6.21-rt2..8 troubles

2007-05-25 Thread Rui Nuno Capela
Hi Ingo et al. It's been quite a while, since last time I've complained about the -rt kernel patch series. This time I'm afraid I have a nasty specialty I've been trying to figure out and isolate but to no definitive results. Fact is, since 2.6.21-rt2 and still on latest -rt8, that I'm facing

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Roland Dreier
> > In addition to PCI INTx compatible interrupt emulation, PCI Express > > requires support of MSI or MSI-X or both. > Which suggests that INTx support is required. > > I do not find any wording that suggest the opposite. > I do see it stated that it is intended to EOL support for INTx at

Re: 2.6.22-rc1-mm1: evm BUG when reading sysfs file

2007-05-25 Thread Mimi Zohar
Andrew Morton <[EMAIL PROTECTED]> wrote on 05/22/2007 05:23:05 PM: > On Tue, 22 May 2007 03:25:48 -0400 > [EMAIL PROTECTED] (Joseph Fannin) wrote: > > > This comes a bit after IMA bails out successfully, if that's relevant: ... > > > > [1.708761] ima (ima_init): No TPM chip found(rc =

Re: [patch 6/7] ps3: ROM Storage Driver

2007-05-25 Thread Arnd Bergmann
On Friday 25 May 2007, Geert Uytterhoeven wrote: > > > What is the problem? Is there infrastructure missing in the > > CD-ROM layer? > > As the CD/DVD/BD part just accepts SCSI/ATAPI commands (except for plain > read/write), I was suggested to keep it as a SCSI driver. Ok, so I guess the

Re: [PATCH 1/2] non-string based tsc unstable reasons

2007-05-25 Thread Andi Kleen
On Fri, May 25, 2007 at 12:32:10PM -0700, Daniel Walker wrote: > Just passing a string to mark_tsc_unstable() doesn't allow real code to change > based on the reason for the instablility. I changed mark_tsc_unstable() > to accept a string and a flag which denotes a general reason why the tsc > is

Re: 2.6.22-rc2-mm1: NetworkManager fails to find ipw2200 again

2007-05-25 Thread Stephen Hemminger
On Fri, 25 May 2007 11:36:22 -0500 Matt Mackall <[EMAIL PROTECTED]> wrote: > 2.6.22-rc2 works. CONFIG_SYSFS_DEPRECATED = y, though that shouldn't > matter. Bringing up the interface manually still works, so I suspect > this is sysfs or HAL related again. Again, Debian unstable so > userspace is

Re: double exclamation (!!) suckage in the kernel

2007-05-25 Thread Satyam Sharma
On 5/26/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: On 5/26/07, Al Viro <[EMAIL PROTECTED]> wrote: > > That's a question for a quiz in introductory course on C: Ugh ... ok, I've embarrassed myself publicly already, so I'll also be brave enough to take a C quiz here :-) Hmmm, and now I seem

Re: 2.6.22-rc2-mm1: NetworkManager fails to find ipw2200 again

2007-05-25 Thread Matt Mackall
On Fri, May 25, 2007 at 12:53:19PM -0500, Matt Mackall wrote: > On Fri, May 25, 2007 at 07:37:46PM +0200, Kay Sievers wrote: > > On 5/25/07, Greg KH <[EMAIL PROTECTED]> wrote: > > >On Fri, May 25, 2007 at 11:36:22AM -0500, Matt Mackall wrote: > > >> 2.6.22-rc2 works. CONFIG_SYSFS_DEPRECATED = y,

Re: double exclamation (!!) suckage in the kernel

2007-05-25 Thread Satyam Sharma
On 5/26/07, Al Viro <[EMAIL PROTECTED]> wrote: On Sat, May 26, 2007 at 01:53:59AM +0530, Satyam Sharma wrote: > Hello, > > Grepping through the sources I found 500+ occurrences of double > exclamation marks before identifier names (such as !!x -- I took care > to ignore occurrences of !! inside

Re: [2.6.21] BUG: at fs/inotify.c:172 set_dentry_child_flags()

2007-05-25 Thread Daniel Drake
Matheus Izvekov wrote: Got this BUG_ON twice in a row, just found it by scrolling thru my dmesg. BUG: at fs/inotify.c:172 set_dentry_child_flags() http://bugzilla.kernel.org/show_bug.cgi?id=7785 If you can reproduce it, looks like some help diagnosing it would be useful. Daniel - To

Re: [patch 5/7] ps3: Disk Storage Driver

2007-05-25 Thread Olaf Hering
On Fri, May 25, Geert Uytterhoeven wrote: > On Fri, 25 May 2007, Olaf Hering wrote: > > On Fri, May 25, [EMAIL PROTECTED] wrote: > > > Add a Disk Storage Driver for the PS3: > > > > There is no device symlink in /sys/block/ps3da/ > > Interesting... Do you know how to create it? No, that was

Re: [patch 5/7] ps3: Disk Storage Driver

2007-05-25 Thread Arnd Bergmann
On Friday 25 May 2007, Geert Uytterhoeven wrote: > > > I don't really understand what the kthread is needed for. You probably > > thought about multiple options and ended up with this, but having > > a comment in front of it might be helpful. > > I used a kthread because the request function of

Re: double exclamation (!!) suckage in the kernel

2007-05-25 Thread Al Viro
On Sat, May 26, 2007 at 01:53:59AM +0530, Satyam Sharma wrote: > Hello, > > Grepping through the sources I found 500+ occurrences of double > exclamation marks before identifier names (such as !!x -- I took care > to ignore occurrences of !! inside comment blocks, because there > are plenty of

Re: double exclamation (!!) suckage in the kernel

2007-05-25 Thread Björn Steinbrink
On 2007.05.26 01:53:59 +0530, Satyam Sharma wrote: > Hello, > > Grepping through the sources I found 500+ occurrences of double > exclamation marks before identifier names (such as !!x -- I took care > to ignore occurrences of !! inside comment blocks, because there > are plenty of that sort

Re: [2/3] 2.6.22-rc2: known regressions v2

2007-05-25 Thread David Miller
From: Chris Newport <[EMAIL PROTECTED]> Date: Fri, 25 May 2007 19:03:51 +0100 > Not really a Solaris feature. This is a feature of the Openboot PROM > which is also used by several other vendors. > The Openboot PROM knows how to write to disk. The same should > apply on Apple hardware and

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Greg KH
On Fri, May 25, 2007 at 09:17:35AM -0600, Eric W. Biederman wrote: > Greg KH <[EMAIL PROTECTED]> writes: > > > Originally I would have thought this would be a good idea, but now that > > Vista is out, which supports MSI, I don't think we are going to need > > this in the future. All new chipsets

Re: double exclamation (!!) suckage in the kernel

2007-05-25 Thread Satyam Sharma
On 5/26/07, Russell King <[EMAIL PROTECTED]> wrote: On Sat, May 26, 2007 at 01:53:59AM +0530, Satyam Sharma wrote: > Are all these occurrences merely the debris of > s/something/!notsomething/g kind of patches or is there some > dark, unknown C / gcc wizardry I have absolutely no clue of? Try

Re: double exclamation (!!) suckage in the kernel

2007-05-25 Thread Russell King
On Sat, May 26, 2007 at 01:53:59AM +0530, Satyam Sharma wrote: > Are all these occurrences merely the debris of > s/something/!notsomething/g kind of patches or is there some > dark, unknown C / gcc wizardry I have absolutely no clue of? Try building and running this: #include int main() {

Re: [PATCH 1/2] [CodingStyle] Add comment to not put spaces before tabs.

2007-05-25 Thread Kok, Auke
H. Peter Anvin wrote: Stefan Richter wrote: Auke Kok wrote: +Don't put spaces before tabs or mix them. Make it "Don't put spaces before tabs." We do mix them if we combine tabs for indentation with spaces for alignment. It would probably be good to add a pointer to the cleanfile/cleanpatch

Re: [AppArmor 01/41] Pass struct vfsmount to the inode_create LSM hook

2007-05-25 Thread Casey Schaufler
--- Andreas Gruenbacher <[EMAIL PROTECTED]> wrote: > On Friday 25 May 2007 19:43, Casey Schaufler wrote: > > [...] but the AppArmor code could certainly check for that in exec by > > enforcing the argv[0] convention. It would be perfectly reasonable for a > > system that is so dependent on

Re: [PATCH 1/2] msi: Invert the sense of the MSI enables.

2007-05-25 Thread Jonathan Lundell
On May 24, 2007, at 10:51 PM, Andi Kleen wrote: Do we have a feel for how much performace we're losing on those systems which _could_ do MSI, but which will end up defaulting to not using it? At least on 10GB ethernet it is a significant difference; you usually cannot go anywhere near line

double exclamation (!!) suckage in the kernel

2007-05-25 Thread Satyam Sharma
Hello, Grepping through the sources I found 500+ occurrences of double exclamation marks before identifier names (such as !!x -- I took care to ignore occurrences of !! inside comment blocks, because there are plenty of that sort too). !! are to be found even in the definitions of common macros

  1   2   3   4   5   6   7   8   9   >