Re: [PATCH/RFC] signal races/bugs, losing TIF_SIGPENDING and other woes

2007-06-05 Thread Davide Libenzi
On Wed, 6 Jun 2007, Benjamin Herrenschmidt wrote: > On Tue, 2007-06-05 at 08:52 -0700, Davide Libenzi wrote: > > if (tsk == current) > > recalc_sigpending(); > > > > What can happen, is that a task may notice TIF_SIGPENDING and not find > > a > > signal once it calls

Re: [PATCH] Protection for exploiting null dereference using mmap

2007-06-05 Thread Chris Wright
* Eric Paris ([EMAIL PROTECTED]) wrote: > +mmap_protect_memory I'm terrible at names, but something like mmap_minimum_addr would be a little clearer at describing that it's a lower bound on mapping memory. BTW, this is also an arch specific issue, those with disjoint kernel and user memory space

Re: [PATCH] Protection for exploiting null dereference using mmap

2007-06-05 Thread H. Peter Anvin
Eric Paris wrote: > > While I understand, there are a few users who will have problems with > this default are we really better to not provide this defense in depth > for the majority of users and let those with problems turn it off rather > than provide no defense by default? I could even

Re: [patch] cpusets: do not allow TIF_MEMDIE tasks to allocate globally

2007-06-05 Thread David Rientjes
On Tue, 5 Jun 2007, Christoph Lameter wrote: > On Tue, 5 Jun 2007, David Rientjes wrote: > > > Reverts git commit c596d9f320aaf30d28c1d793ff3a976dee1db8f5. > > > > OOM-killed tasks, marked as TIF_MEMDIE, should not be able to access > > memory outside its cpuset because it could potentially

Re: [patch] cpusets: do not allow TIF_MEMDIE tasks to allocate globally

2007-06-05 Thread Christoph Lameter
On Tue, 5 Jun 2007, David Rientjes wrote: > Reverts git commit c596d9f320aaf30d28c1d793ff3a976dee1db8f5. > > OOM-killed tasks, marked as TIF_MEMDIE, should not be able to access > memory outside its cpuset because it could potentially cause other > exclusive cpusets to OOM themselves. Those

[patch] cpusets: do not allow TIF_MEMDIE tasks to allocate globally

2007-06-05 Thread David Rientjes
Reverts git commit c596d9f320aaf30d28c1d793ff3a976dee1db8f5. OOM-killed tasks, marked as TIF_MEMDIE, should not be able to access memory outside its cpuset because it could potentially cause other exclusive cpusets to OOM themselves. Cc: Andi Kleen <[EMAIL PROTECTED]> Cc: Christoph Lameter

Re: [PATCH TRIVIAL] icom whitespace cleanups

2007-06-05 Thread Paul Mackerras
Chris Snook writes: > Clean up whitespace and comments in drivers/serial/icom.c These changes seem totally unnecessary, as the existing indentation is according to a commonly-accepted style and is quite reasonable: > @@ -149,23 +149,23 @@ static void free_port_memory(struct icom >

Re: [-mm patch] kernel/lockdep_proc.c: make 2 functions static

2007-06-05 Thread Peter Zijlstra
On Tue, 2007-06-05 at 23:51 +0200, Adrian Bunk wrote: > On Wed, May 30, 2007 at 11:58:23PM -0700, Andrew Morton wrote: > >... > > Changes since 2.6.22-rc2-mm1: > >... > > +lockstat-human-readability-tweaks.patch > >... > > lockstat-via-lockdep > >... > > This patch makes two needlessly global

Re: [patch 1/2] ufd v1 - unsequential O(1) fdmap core

2007-06-05 Thread Eric Dumazet
Ingo Molnar a écrit : no, i just wanted to make a demonstration that one can be pretty nasty in on-lkml replies while being technically correct :-) I think you went a bit overboard in your replies to Davide. Lets move this back into constructive channels, ok? :) In any case, here is one

Re: volatile and atomic_t/spinlock_t

2007-06-05 Thread Heiko Carstens
On Tue, Jun 05, 2007 at 11:38:27AM -0700, Luck, Tony wrote: > > So is > > > > while (__raw_spin_is_locked()); > > > > supposed to work? Or should that be > > > > while (__raw_spin_is_locked()) > > cpu_relax(); > > > > as well and all the volatiles can/should go away? > >

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Jeff Garzik
On Tue, Jun 05, 2007 at 11:03:45PM +0100, Russell King wrote: > On Tue, Jun 05, 2007 at 05:48:30PM -0400, Jeff Garzik wrote: > > On Tue, Jun 05, 2007 at 10:38:15PM +0100, Russell King wrote: > > > There is one final point on this which I wish to make, in case anyone > > > has decided that this is

Re: [PATCH/RFC] signal races/bugs, losing TIF_SIGPENDING and other woes

2007-06-05 Thread Benjamin Herrenschmidt
On Tue, 2007-06-05 at 08:52 -0700, Davide Libenzi wrote: > if (tsk == current) > recalc_sigpending(); > > What can happen, is that a task may notice TIF_SIGPENDING and not find > a > signal once it calls dequeue_signal(), but this is fine as far as > signalfd > goes.

Re: [1/5] 2.6.22-rc4: known regressions

2007-06-05 Thread Rafael J. Wysocki
On Tuesday, 5 June 2007 16:43, Michal Piotrowski wrote: > Hi all, > > Here is a list of some known regressions in 2.6.22-rc4. > > Feel free to add new regressions/remove fixed etc. > http://kernelnewbies.org/known_regressions > > > > Unclassified > > Subject: Kernel hang on CMOS_READ >

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 05:48:30PM -0400, Jeff Garzik wrote: > On Tue, Jun 05, 2007 at 10:38:15PM +0100, Russell King wrote: > > There is one final point on this which I wish to make, in case anyone > > has decided that this is caused by some recent change at my end. > > > > I've been adding this

Re: [-mm patch] kernel/power/disk.c: make code static

2007-06-05 Thread Rafael J. Wysocki
On Tuesday, 5 June 2007 23:50, Adrian Bunk wrote: > On Wed, May 30, 2007 at 11:58:23PM -0700, Andrew Morton wrote: > >... > > Changes since 2.6.22-rc2-mm1: > >... > > +swsusp-remove-code-duplication-between-diskc-and-userc.patch > >... > > freezer/swsusp updates > >... > > This patch makes

Re: Linux 2.6.22-rc4

2007-06-05 Thread Rafael J. Wysocki
On Tuesday, 5 June 2007 22:19, Pavel Machek wrote: > Hi! > > > > > [ 116.733327] PM: suspend-to-disk mode set to 'shutdown' [ > > > > 116.738849] swsusp: Basic memory bitmaps created [ 116.745353] > > > > Stopping tasks ... WARNING: at > > > > /home/devel/linux-git/kernel/lockdep.c:2414

[PATCH] Make i386 kernel show the segfaults in kernel dmesg, like x86_64.

2007-06-05 Thread Masoud Asgharifard Sharbiani
Hello, This patch makes the i386 behave the same way that x86_64 does when a segfault happens. A line gets printed to the kernel log so that tools that need to check for failures can behave more uniformly between different kernels. Like x86_64, it can be disabled by setting debug.exception-trace

Re: usb-scanner-cameras kernel-2.6.22 and udev-095 problem

2007-06-05 Thread Greg KH
On Tue, Jun 05, 2007 at 02:18:26PM +0200, Michal Piotrowski wrote: > Hi, > > On 24/05/07, Greg KH <[EMAIL PROTECTED]> wrote: > > On Thu, May 17, 2007 at 07:00:58PM -0500, [EMAIL PROTECTED] wrote: > > > greg > > > > > > and part of /etc/udev/rules.d/60-libsane.rules > > > > > > ... > > >

Re: Linux 2.6.22-rc4 - sata_promise regression since -rc3

2007-06-05 Thread Jeff Garzik
On Tue, Jun 05, 2007 at 11:31:46PM +0200, Mikael Pettersson wrote: > I can easily reproduce the problem in 2.6.22-rc4. There are no > sata_promise changes between rc3 and rc4, but Tejun's libata > polling SETXFER change was included in rc4. Reverting it makes > sata_promise work again for me.

[-mm patch] fs/proc/base.c: make a struct static

2007-06-05 Thread Adrian Bunk
This patch makes the needlessly global struct proc_pid_sched_operations static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- --- linux-2.6.22-rc3-mm1/fs/proc/base.c.old 2007-06-05 22:01:08.0 +0200 +++ linux-2.6.22-rc3-mm1/fs/proc/base.c 2007-06-05 22:41:57.0 +0200 @@

[-mm patch] kernel/sched{,_fair}.c: make code static

2007-06-05 Thread Adrian Bunk
This patch makes some needlessly global code static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- BTW: Please don't #include C files in sched.c kernel/sched.c |2 +- kernel/sched_fair.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) ---

[-mm patch] kernel/lockdep_proc.c: make 2 functions static

2007-06-05 Thread Adrian Bunk
On Wed, May 30, 2007 at 11:58:23PM -0700, Andrew Morton wrote: >... > Changes since 2.6.22-rc2-mm1: >... > +lockstat-human-readability-tweaks.patch >... > lockstat-via-lockdep >... This patch makes two needlessly global functions static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> ---

[2.6 patch] fs/afs/: possible cleanups

2007-06-05 Thread Adrian Bunk
This patch contains the following possible cleanups: - make the following needlessly global functions static: - rxrpc.c: afs_send_pages() - vlocation.c: afs_vlocation_queue_for_updates() - write.c: afs_writepages_region() - make the following needlessly global variables static: - mntpt.c:

[-mm patch] kernel/power/disk.c: make code static

2007-06-05 Thread Adrian Bunk
On Wed, May 30, 2007 at 11:58:23PM -0700, Andrew Morton wrote: >... > Changes since 2.6.22-rc2-mm1: >... > +swsusp-remove-code-duplication-between-diskc-and-userc.patch >... > freezer/swsusp updates >... This patch makes needlessly global code static. Signed-off-by: Adrian Bunk <[EMAIL

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Jeff Garzik
On Tue, Jun 05, 2007 at 10:38:15PM +0100, Russell King wrote: > There is one final point on this which I wish to make, in case anyone > has decided that this is caused by some recent change at my end. > > I've been adding this header to all my messages for about the last seven > years. It's only

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 10:25:23PM +0100, Russell King wrote: > On Tue, Jun 05, 2007 at 12:27:45PM -0700, David Miller wrote: > > From: Russell King <[EMAIL PROTECTED]> > > Date: Tue, 5 Jun 2007 16:21:33 +0100 > > > > > Oh sod it, I'm unsubscribing from LKML. Jeff, hope your happy. > > > > What

Re: How to access correctly serial port inside module?

2007-06-05 Thread Tilman Schmidt
Am 03.06.2007 22:28 schrieb Lars K.W. Gohlke: > Tilman Schmidt schrieb: >> Am 17.05.2007 08:15 schrieb huang ying: >>> I think the "serio" (through drivers/input/serio/serport.c) may be a >>> choice too, like that in linux/drivers/input/mouse/sermouse.c, which >>> is an example to program serial

Re: Linux 2.6.22-rc4 - sata_promise regression since -rc3

2007-06-05 Thread Mikael Pettersson
On Tue, 05 Jun 2007 17:14:46 +0100, David Greaves <[EMAIL PROTECTED]> wrote: >[Tejun, Jeff, added you since the bisect points to your patch.] > >Sorry, mail glitch means I lost a couple of emails... > >I said: >Compile warnings and a new regression: hang on boot during sata_promise >detection... >

[PATCH 2.6.21.3] USB: add support for TRU-install and new VID/PIDs to Sierra Wireless driver

2007-06-05 Thread Kevin Lloyd
From: Kevin Lloyd <[EMAIL PROTECTED]> This patch is derived from the 2.6.21.3 kernel source and adds support for the new TRU-install feature (without this support new devices will not work), and add new UMTS device VID/PIDs. Signed-off-by: Kevin Lloyd <[EMAIL PROTECTED]> --- diff -uprN

Re: [PATCH] lguest-fix-divide-error-implement-sched_clock

2007-06-05 Thread Andi Kleen
On Tuesday 05 June 2007 23:15:28 H. Peter Anvin wrote: > Andi Kleen wrote: > > > > I don't think it's a good idea for the TSC. There are various > > setups where it is unreliable and also often simulators don't > > implement it correctly. And it's always a valuable workaround > > to be able to

Re: [PATCH] Protection for exploiting null dereference using mmap

2007-06-05 Thread Eric Paris
On Tue, 2007-06-05 at 17:16 -0400, Alan Cox wrote: > On Tue, Jun 05, 2007 at 05:00:51PM -0400, James Morris wrote: > > This should be an unsigned long. > > > > I wonder if the default should be for this value to be zero (i.e. preserve > > existing behavior). It could break binaries, albeit

[PATCH 4/3] Char: stallion, remove user class report request

2007-06-05 Thread Jiri Slaby
Ok, one more. -- stallion, remove user class report request Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit 400de8dd765298a11daec2a4a936a70798f428aa tree 81675ba379783ad98f5c0387620a59b2ff2247a7 parent d62c04c8fe3271ab2089f442e04ad522a158bf8f author Jiri Slaby <[EMAIL PROTECTED]> Tue,

[PATCH 3/3] Char: stallion, proper fail return values

2007-06-05 Thread Jiri Slaby
stallion, proper fail return values do not return 0 in one case and return proper values in other 2. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit d62c04c8fe3271ab2089f442e04ad522a158bf8f tree 31beaaee84ef718acc5401b3cb07a7f2e340f0fe parent e7488128b7b4f61c82b6e323067d221c9397c43b

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 12:27:45PM -0700, David Miller wrote: > From: Russell King <[EMAIL PROTECTED]> > Date: Tue, 5 Jun 2007 16:21:33 +0100 > > > Oh sod it, I'm unsubscribing from LKML. Jeff, hope your happy. > > What an adult way for you to handle this. Indeed; it's obvious that you're not

[PATCH 2/3] Char: stallion, alloc tty before pci devices init

2007-06-05 Thread Jiri Slaby
stallion, alloc tty before pci devices init this causes oops, because pci prboe function calls tty_register_device for each device found. Thanks to Ingo. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: "Ingo Korb" <[EMAIL PROTECTED]> --- commit e7488128b7b4f61c82b6e323067d221c9397c43b tree

[PATCH TRIVIAL] icom whitespace cleanups

2007-06-05 Thread Chris Snook
From: Chris Snook <[EMAIL PROTECTED]> Clean up whitespace and comments in drivers/serial/icom.c Signed-off-by: Chris Snook <[EMAIL PROTECTED]> The patch is very large (30k) so I have attached it. Please let me know if you really, really want it inline. --- a/drivers/serial/icom.c

[PATCH 1/3] Char: stallion, don't fail with less than max panels

2007-06-05 Thread Jiri Slaby
stallion, don't fail with less than max panels Thanks to Ingo. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: "Ingo Korb" <[EMAIL PROTECTED]> --- commit aa7cfc04f92ec2b20a07b29a89527d836a93d00f tree 064efb1346d6efffcd59cce827e15116c836da5b parent db6329f0ce9fe4e7773edcabfb97f63e4f4a948f

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 12:23:35PM -0700, David Miller wrote: > From: Russell King <[EMAIL PROTECTED]> > Date: Tue, 5 Jun 2007 15:59:46 +0100 > > > It's the fact that I _am_ CC'd on replies, so I get one message from LKML > > one from the original poster, maybe one via another mailing list if

Re: Device hang when offlining a CPU due to IRQ misrouting

2007-06-05 Thread Siddha, Suresh B
On Tue, Jun 05, 2007 at 01:09:54PM -0700, Darrick J. Wong wrote: > On Tue, Jun 05, 2007 at 11:40:15AM -0700, Siddha, Suresh B wrote: > > > Does this problem happen only under certain stress or something simple, like > > > > boot the kernel > > echo 2 > /proc/irq/114/smp_affinity > > wait for irq

[PATCH 1/1] Char: Kconfig, mxser_new: remove experimental comment

2007-06-05 Thread Jiri Slaby
Kconfig, mxser_new: remove experimental comment Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit 70591fd7231ee9767b813b052ff5b6123c8963b9 tree 0a686cee41b4f9f5e964b36a9001e3c0b03dc29d parent 1a5e44385253ef9a193badf768f40543af6996ca author Jiri Slaby <[EMAIL PROTECTED]> Mon, 28 May 2007

Re: [PATCH 03/22] 2.6.22-rc3 perfmon2 : new system calls support

2007-06-05 Thread Stephane Eranian
David, On Mon, Jun 04, 2007 at 07:38:23AM -0700, David Rientjes wrote: > On Tue, 29 May 2007, Stephane Eranian wrote: > > +static int pfm_task_incompatible(struct pfm_context *ctx, struct > > task_struct *task) > > +{ > > + /* > > +* no kernel task or task not owned by caller > > +*/ >

Re: [PATCH] lguest-fix-divide-error-implement-sched_clock

2007-06-05 Thread H. Peter Anvin
Andi Kleen wrote: > > I don't think it's a good idea for the TSC. There are various > setups where it is unreliable and also often simulators don't > implement it correctly. And it's always a valuable workaround > to be able to turn it off. > For all I can tell, if this is the case, then

Re: [PATCH] Protection for exploiting null dereference using mmap

2007-06-05 Thread Alan Cox
On Tue, Jun 05, 2007 at 05:00:51PM -0400, James Morris wrote: > This should be an unsigned long. > > I wonder if the default should be for this value to be zero (i.e. preserve > existing behavior). It could break binaries, albeit potentially insecure Agreed - DOSemu type apps and lrmi need to

Re: [RFC][PATCH] muptiple bugs in PI futexes

2007-06-05 Thread Thomas Gleixner
On Wed, 2007-06-06 at 01:00 +0400, Alexey Kuznetsov wrote: > Hello! > > > We actually need to do something about this, as we might loop for ever > > there. The robust cleanup code can fail (e.g. due to list corruption) > > and we would see exit_state != 0 and the OWNER_DIED bit would never be > >

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Chuck Ebbert
On 06/05/2007 03:24 PM, David Miller wrote: > > I totally agree, Russel you are being totally unreasonable. > ^^ Uh-oh. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: Linux 2.6.22-rc4

2007-06-05 Thread Badari Pulavarty
On Mon, 2007-06-04 at 20:50 -0700, Linus Torvalds wrote: > So -rc4 is out there now, hopefully shrinking the regression list further. > Nothing serious, compile warnings .. mm/sparse.c:244: warning: `__kmalloc_section_memmap' defined but not used mm/sparse.c:274: warning:

[PATCH] UML - Improve host PTRACE_SYSEMU check

2007-06-05 Thread Jeff Dike
Make the PTRACE_SYSEMU checking more robust. It will make sure that system call numbers are reported correctly. If there is a problem, it will disable PTRACE_SYSEMU use and use PTRACE_SYSCALL instead. This fixes a hang on boot on FC6 hosts with a broken PTRACE_SYSEMU. Signed-off-by: Jeff Dike

Re: [PATCH] S390: Replace calls to __get_free_pages() with __get_dma_pages().

2007-06-05 Thread Satyam Sharma
Hi, On 6/6/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote: Replace a number of calls to __get_free_pages() with the corresponding calls to __get_dma_pages(). [...] once the __GFP_DMA argument is removed, it does look weird to see the first argument of just 0. should that be filled in with

Re: [PATCH] Protection for exploiting null dereference using mmap

2007-06-05 Thread James Morris
On Tue, 5 Jun 2007, Eric Paris wrote: > +extern int mmap_protect_memory; This should be an unsigned long. I wonder if the default should be for this value to be zero (i.e. preserve existing behavior). It could break binaries, albeit potentially insecure ones. - James -- James Morris

Re: [RFC][PATCH] muptiple bugs in PI futexes

2007-06-05 Thread Alexey Kuznetsov
Hello! > We actually need to do something about this, as we might loop for ever > there. The robust cleanup code can fail (e.g. due to list corruption) > and we would see exit_state != 0 and the OWNER_DIED bit would never be > set, so we are stuck in a busy loop. Yes... It is possible to take

Re: [Intel-IOMMU 02/10] Library routines for handling pre-allocated pool of objects

2007-06-05 Thread Keshavamurthy, Anil S
On Tue, Jun 05, 2007 at 04:30:48PM -0400, Jeff Garzik wrote: > On Tue, Jun 05, 2007 at 01:24:33PM -0700, Keshavamurthy, Anil S wrote: > > 1 file changed, 65 insertions(+), 19 deletions(-) > > > > Index: linux-2.6.22-rc3/lib/respool.c > >

[PATCH] lib: Replace calls to __get_free_pages() with __get_dma_pages().

2007-06-05 Thread Robert P. J. Day
Replace a couple calls to __get_free_pages() with the corresponding calls to __get_dma_pages(). Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- that's the lot of them. diff --git a/lib/swiotlb.c b/lib/swiotlb.c index 10c13ad..8fc38dc 100644 --- a/lib/swiotlb.c +++ b/lib/swiotlb.c @@

[PATCH 1/2] UML - Fix request->sector update

2007-06-05 Thread Jeff Dike
[ This is post-2.6.22 material - it fixes a bug, but not one that I think has been seen in the wild, plus an earlier version of this fix caused file corruption ] It is theoretically possible for a request to finish and be freed between writing it to the I/O thread and updating the sector count.

[PATCH 2/2] UML - Fix kernel stack size on x86_64

2007-06-05 Thread Jeff Dike
[ This is 2.6.22 material ] Having KERNEL_STACK_ORDER in defconfig overrides the value provided by Kconfig, breaking UML/x86_64, which wants 2 page stacks. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/defconfig |1 - 1 file changed, 1 deletion(-) Index:

Re: [patch 1/2] ufd v1 - unsequential O(1) fdmap core

2007-06-05 Thread Eric Dumazet
Ingo Molnar a écrit : * Eric Dumazet <[EMAIL PROTECTED]> wrote: For example, the recent futex.c changes you did in commit 34f01cc1 are, and unfortunately there's no better word i can find: plain disgusting. You apparently have plopped the 'fshared' code into the existing logic via

[PATCH] S390: Replace calls to __get_free_pages() with __get_dma_pages().

2007-06-05 Thread Robert P. J. Day
Replace a number of calls to __get_free_pages() with the corresponding calls to __get_dma_pages(). Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- once the __GFP_DMA argument is removed, it does look weird to see the first argument of just 0. should that be filled in with GFP_ATOMIC

Re: [patch 1/2] ufd v1 - unsequential O(1) fdmap core

2007-06-05 Thread Thomas Gleixner
On Tue, 2007-06-05 at 22:37 +0200, Ingo Molnar wrote: > * Eric Dumazet <[EMAIL PROTECTED]> wrote: > > > > For example, the recent futex.c changes you did in commit 34f01cc1 > > > are, and unfortunately there's no better word i can find: plain > > > disgusting. You apparently have plopped the

Re: [Patch 04/18] include/linux/logfs.h

2007-06-05 Thread Bill Davidsen
Segher Boessenkool wrote: It would be better if GCC had a 'nopadding' attribute which gave us what we need without the _extra_ implications about alignment. That's impossible; removing the padding from a struct _will_ make accesses to its members unaligned (think about arrays of that struct).

[PATCH] S390: Replace __get_free_pages() with __get_dma_pages().

2007-06-05 Thread Robert P. J. Day
Replace the call to __get_free_pages() with the more specific __get_dma_pages(). Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/arch/s390/kernel/smp.c b/arch/s390/kernel/smp.c index 8ff2fea..108e7df 100644 --- a/arch/s390/kernel/smp.c +++ b/arch/s390/kernel/smp.c @@

Re: [patch 1/2] ufd v1 - unsequential O(1) fdmap core

2007-06-05 Thread Ingo Molnar
* Eric Dumazet <[EMAIL PROTECTED]> wrote: > > For example, the recent futex.c changes you did in commit 34f01cc1 > > are, and unfortunately there's no better word i can find: plain > > disgusting. You apparently have plopped the 'fshared' code into the > > existing logic via conditionals and

[PATCH] Protection for exploiting null dereference using mmap

2007-06-05 Thread Eric Paris
Assuming there is a kernel bug which includes a null dereference that bug may allow for a process to place information on the first page on the system and get the kernel to act in unintended ways. This patch adds a new security check on mmap operations to see if the user is attempting to mmap to

Re: [Intel-IOMMU 02/10] Library routines for handling pre-allocated pool of objects

2007-06-05 Thread Jeff Garzik
On Tue, Jun 05, 2007 at 01:24:33PM -0700, Keshavamurthy, Anil S wrote: > 1 file changed, 65 insertions(+), 19 deletions(-) > > Index: linux-2.6.22-rc3/lib/respool.c > === > --- linux-2.6.22-rc3.orig/lib/respool.c 2007-06-05

Re: [Intel-IOMMU 02/10] Library routines for handling pre-allocated pool of objects

2007-06-05 Thread Keshavamurthy, Anil S
On Mon, Jun 04, 2007 at 04:51:05PM -0700, Keshavamurthy, Anil S wrote: > On Mon, Jun 04, 2007 at 07:43:54PM -0400, Jeff Garzik wrote: > > On Mon, Jun 04, 2007 at 04:06:49PM -0700, Keshavamurthy, Anil S wrote: > > > On Mon, Jun 04, 2007 at 06:57:14PM -0400, Jeff Garzik wrote: > > > > you should add

Re: [PATCH 17/22] 2.6.22-rc3 perfmon2 : modified powerpc files

2007-06-05 Thread Stephane Eranian
David, On Tue, Jun 05, 2007 at 09:52:19AM -0700, David Rientjes wrote: > > > > @@ -330,10 +330,22 @@ > > > > #define __NR_signalfd 305 > > > > #define __NR_timerfd 306 > > > > #define __NR_eventfd 307 > > > > +#define __NR_pfm_create_context308 > > > >

Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware before hibernation/suspend

2007-06-05 Thread Pavel Machek
Hi! > > > With the USB subsystem I have followed the approach taken by the PM > > > core, which is that tasks are frozen. But one can -- and Linus has on > > > at least one occasion -- make a good case that tasks should be left > > > running while only I/O is frozen. This would require the

Re: Linux 2.6.22-rc4

2007-06-05 Thread Pavel Machek
Hi! > > > [ 116.733327] PM: suspend-to-disk mode set to 'shutdown' [ > > > 116.738849] swsusp: Basic memory bitmaps created [ 116.745353] > > > Stopping tasks ... WARNING: at > > > /home/devel/linux-git/kernel/lockdep.c:2414 check_flags() > > > > [ 116.755052] irq event stamp: 69 > > > [

Re: Linux 2.6.22-rc4

2007-06-05 Thread Pavel Machek
Hi! > > isnt the refrigerator() suspend related? Perhaps suspend disables irqs > > somewhere that we forgot to track? > > There _is_ something strange there. For that whole sequence to trigger, > the current task has to have the TIF_FREEZE bit set, but I don't see why > it would be during

Re: [NFS] [PATCH 2/2] nfs4: on a O_EXCL OPEN make sure the SETATTR sets the fields holding the verifier

2007-06-05 Thread Trond Myklebust
On Tue, 2007-06-05 at 15:35 -0400, Jeff Layton wrote: > On Tue, 05 Jun 2007 14:13:02 -0400 > Trond Myklebust <[EMAIL PROTECTED]> wrote: > > > On Tue, 2007-06-05 at 13:56 -0400, Jeff Layton wrote: > > > The Linux NFS4 client simply skips over the bitmask in an O_EXCL open > > > call and so it

Re: [PATCH] fix race in AF_UNIX

2007-06-05 Thread David Miller
From: Miklos Szeredi <[EMAIL PROTECTED]> Date: Tue, 05 Jun 2007 09:42:41 +0200 > From: Miklos Szeredi <[EMAIL PROTECTED]> > > A recv() on an AF_UNIX, SOCK_STREAM socket can race with a > send()+close() on the peer, causing recv() to return zero, even though > the sent data should be received. >

Re: Device hang when offlining a CPU due to IRQ misrouting

2007-06-05 Thread Darrick J. Wong
On Tue, Jun 05, 2007 at 11:40:15AM -0700, Siddha, Suresh B wrote: > Does this problem happen only under certain stress or something simple, like > > boot the kernel > echo 2 > /proc/irq/114/smp_affinity > wait for irq to hit the cpu1. > echo 0 > /sys/devices/system/cpu/cpu1/online > > will

Re: HPT374 IDE problem with 2.6.21.* kernels

2007-06-05 Thread Sergei Shtylyov
Hello, I wrote: This looks promising. Using a vanilla 2.6.22-rc3 I was able to reproduce the problem within a few seconds. With the above modification the machine is running under heavy disk I/O without problems since 30 minutes... Did it fix the problem for good? It seems so far. There

Re: Interesting interaction between lguest and CFS

2007-06-05 Thread Ingo Molnar
* Dmitry Adamushko <[EMAIL PROTECTED]> wrote: > On 05/06/07, Dmitry Adamushko <[EMAIL PROTECTED]> wrote: > >> now at 257428593818894 nsecs > >> > >> cpu: 0 > >> .nr_running: 3 > >> .raw_weighted_load : 2063 > >> .nr_switches : 242830075 > >> .nr_load_updates

Re: [PATCH] allow file system to configure for no leases

2007-06-05 Thread Peter Staubach
Trond Myklebust wrote: On Tue, 2007-06-05 at 15:10 -0400, Peter Staubach wrote: Hi. Attached is a small patch to allow file systems to inform the file system independent layers that they don't support file leases. The problem is that some file system such as NFSv2 and NFSv3 do not have

Re: Linux 2.6.22-rc4

2007-06-05 Thread Linus Torvalds
On Tue, 5 Jun 2007, Ingo Molnar wrote: > > isnt the refrigerator() suspend related? Perhaps suspend disables irqs > somewhere that we forgot to track? There _is_ something strange there. For that whole sequence to trigger, the current task has to have the TIF_FREEZE bit set, but I don't see

Re: [PATCH 3/4] mm: move_page_tables{,_up}

2007-06-05 Thread Christoph Lameter
On Tue, 5 Jun 2007, Peter Zijlstra wrote: > Provide functions for moving page tables upwards. Could you make this more general so that it allows arbitrary page table pages moving? That would be useful for Mel's memory defragmentation since it increases the types of pages that can be moved. -

Re: Interesting interaction between lguest and CFS

2007-06-05 Thread Ingo Molnar
* Matt Mackall <[EMAIL PROTECTED]> wrote: > On Tue, Jun 05, 2007 at 02:37:38PM +1000, Rusty Russell wrote: > > On Mon, 2007-06-04 at 23:18 -0500, Matt Mackall wrote: > > > On Tue, Jun 05, 2007 at 12:31:15PM +1000, Rusty Russell wrote: > > > > Does this solve it for you? > > > > > > Nope.

Re: Linux 2.6.22-rc4

2007-06-05 Thread Ingo Molnar
* Linus Torvalds <[EMAIL PROTECTED]> wrote: > > this looks harmless > > > > [ 116.733327] PM: suspend-to-disk mode set to 'shutdown' [ > > 116.738849] swsusp: Basic memory bitmaps created [ 116.745353] > > Stopping tasks ... WARNING: at > > /home/devel/linux-git/kernel/lockdep.c:2414

Re: [NFS] [PATCH 2/2] nfs4: on a O_EXCL OPEN make sure the SETATTR sets the fields holding the verifier

2007-06-05 Thread Jeff Layton
On Tue, 05 Jun 2007 14:13:02 -0400 Trond Myklebust <[EMAIL PROTECTED]> wrote: > On Tue, 2007-06-05 at 13:56 -0400, Jeff Layton wrote: > > The Linux NFS4 client simply skips over the bitmask in an O_EXCL open > > call and so it doesn't bother to reset any fields that may be holding > > the

Re: [PATCH] allow file system to configure for no leases

2007-06-05 Thread Trond Myklebust
On Tue, 2007-06-05 at 15:10 -0400, Peter Staubach wrote: > Hi. > > Attached is a small patch to allow file systems to inform the file > system independent layers that they don't support file leases. > > The problem is that some file system such as NFSv2 and NFSv3 do > not have sufficient support

Re: Linux 2.6.22-rc4

2007-06-05 Thread Linus Torvalds
On Tue, 5 Jun 2007, Michal Piotrowski wrote: > > It is too stable for me. I wish all our testers were you ;) > this looks harmless > > [ 116.733327] PM: suspend-to-disk mode set to 'shutdown' > [ 116.738849] swsusp: Basic memory bitmaps created > [ 116.745353] Stopping tasks ... WARNING:

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread David Miller
From: Russell King <[EMAIL PROTECTED]> Date: Tue, 5 Jun 2007 16:21:33 +0100 > Oh sod it, I'm unsubscribing from LKML. Jeff, hope your happy. What an adult way for you to handle this. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread David Miller
From: Russell King <[EMAIL PROTECTED]> Date: Tue, 5 Jun 2007 16:18:47 +0100 > On Tue, Jun 05, 2007 at 11:11:04AM -0400, Jeff Garzik wrote: > > You are NOT more important that everyone else. > > That's not the issue. Yes it is, you're imposing your lousy solution to your problems on other

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 5 Jun 2007 11:11:04 -0400 > On Tue, Jun 05, 2007 at 03:59:46PM +0100, Russell King wrote: > > Give me a way to stop people CC'ing me on replies and I'll happily remove > > the header. Unfortunately there isn't, so I can't. > > So by fiat, you

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread David Miller
From: Russell King <[EMAIL PROTECTED]> Date: Tue, 5 Jun 2007 15:59:46 +0100 > It's the fact that I _am_ CC'd on replies, so I get one message from LKML > one from the original poster, maybe one via another mailing list if it's > also copied there. Add that in to the mix of all the other mail

Re: [NFS] [PATCH 2/2] nfs4: on a O_EXCL OPEN make sure the SETATTR sets the fields holding the verifier

2007-06-05 Thread Jeff Layton
Thanks for the comments, Trond. Here's a new patch. It builds but I haven't done any thorough testing of it. If this looks reasonable, I'll do some more thorough testing with it to make sure it fixes the testcase. Also, do you have any suggestions of other attrs I should be checking in

Re: glitch1 results - 2.6.21.3-cfs-v15

2007-06-05 Thread Ingo Molnar
* Bill Davidsen <[EMAIL PROTECTED]> wrote: > I have added cfs15 to the chart at > www.tmr.com/~davidsen/sched_smooth_05.html and updated the source of > the test at www.tmr.com/~public/source if anyone wants to run test on > their hardware. thanks! > I feel that on my hardware cfs-13 was

Re: [2/2] 2.6.22-rc4: known regressions with patches

2007-06-05 Thread David Miller
From: Michal Piotrowski <[EMAIL PROTECTED]> Date: Tue, 05 Jun 2007 16:54:35 +0200 > Sparc64 > > Subject: arch/sparc64/time.c doesn't compile on Ultra 1 (no PCI) > References : http://bugzilla.kernel.org/show_bug.cgi?id=8540 > Submitter : Horst H. von Brand <[EMAIL PROTECTED]> > Status :

Re: [RFC][PATCH] muptiple bugs in PI futexes

2007-06-05 Thread Thomas Gleixner
On Tue, 2007-06-05 at 20:48 +0200, Thomas Gleixner wrote: > > > This does not really explain, why you do prevent the -ESRCH return value > > > in the next cycle, > > > > Because right curval is refetched, it already has FUTEX_OWNER_DIED bit set > > and we succesfully take the lock. > > Ok,

[PATCH] kconfig: fix typos in Makefile

2007-06-05 Thread Massimo Maiurana
kxgettext fails generating pot file for um arch due to wrong filenames and related symlinks in Makefile. Fixed with the patch below. Signed-off-by: Massimo Maiurana <[EMAIL PROTECTED]> --- diff -Nru linux/scripts/kconfig/Makefile linux.new/scripts/kconfig/Makefile

[PATCH] allow file system to configure for no leases

2007-06-05 Thread Peter Staubach
Hi. Attached is a small patch to allow file systems to inform the file system independent layers that they don't support file leases. The problem is that some file system such as NFSv2 and NFSv3 do not have sufficient support to be able to support leases correctly. In particular for these two

Re: Interesting interaction between lguest and CFS

2007-06-05 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > Matt, could you send me your .config too? Maybe i can reproduce it > with your config. ok, got it (off-list) and you seem to have the default HZ=250. Could you change it to HZ=1000 - does the delay get alot smaller? if yes then this could be roughly

Re: SLUB: Return ZERO_SIZE_PTR for kmalloc(0)

2007-06-05 Thread Pekka Enberg
Rene Herman wrote: If I'd have a few small children around I'd show them the word ZERO_SIZE_PTR and make pictures of them bursting out in tears. I strongly recommend against it, linux/mm/*.c is for adults only. Pekka - To unsubscribe from this list: send the line

Re: [patch 5/9] Conditional Calls - i386 Optimization

2007-06-05 Thread Mathieu Desnoyers
* Andi Kleen ([EMAIL PROTECTED]) wrote: > Mathieu Desnoyers <[EMAIL PROTECTED]> writes: > > > +#define cond_call_optimized(flags, name, func) \ > > + ({ \ > > + static const char __cstrtab_name_##name[] \ > > + __attribute__((section("__cond_call_strings"))) = #name; \ > > +

Re: 4Gb ram not showing up

2007-06-05 Thread Lennart Sorensen
On Mon, Jun 04, 2007 at 03:43:08PM -0400, Tom Moore wrote: > Thank you for the reply back. Your answer makes perfect sense to me, > and it is what I had suspected but was not sure about. The math seems > to indicate that 4Gb of ram plus 1Gb of PCI address space equals 5Gb of > memory space.

Re: Linux 2.6.22-rc4

2007-06-05 Thread Michal Piotrowski
Linus Torvalds pisze: So -rc4 is out there now, hopefully shrinking the regression list further. It is too stable for me. aio_dio_bugs ok aiostress ok bash_shared_mapping ok cpu_hotplug ok fio ok fsx ok interbench ok iozone ok isic ok linus_stress ok the latest ltp ok this looks harmless

Re: [PATCH] lguest-fix-divide-error-implement-sched_clock

2007-06-05 Thread Andi Kleen
> > That's a vendor check foul. That should be a CPU feature flag. > > Looks like there is some work to be done here. No. That would just move that code elsewhere, but there is still only a single caller who actually uses this. Besides there are further checks to be done here (see x86-64)

Re: [Patch 04/18] include/linux/logfs.h

2007-06-05 Thread Segher Boessenkool
It would be better if GCC had a 'nopadding' attribute which gave us what we need without the _extra_ implications about alignment. That's impossible; removing the padding from a struct _will_ make accesses to its members unaligned (think about arrays of that struct). It _might_ make accesses

Re: [RFC][PATCH] muptiple bugs in PI futexes

2007-06-05 Thread Thomas Gleixner
On Tue, 2007-06-05 at 21:39 +0400, Alexey Kuznetsov wrote: > Hello! > > > Hmm, what means not expected ? -ESRCH is returned, when the owner task > > is not found. > > This is not supposed to happen with robust futexes. Hmm, right. > > This does not really explain, why you do prevent the

Re: [PATCH] update checkpatch.pl to version 0.03

2007-06-05 Thread Andy Whitcroft
jschopp wrote: >> The original suggestion was to count them and only complain if there >> were "lots". I had thought though that the general consensus was that >> #ifdef in C files was pretty much frowned upon. I must admit to working >> to the "you must be able to justify all winges in the

Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware before hibernation/suspend

2007-06-05 Thread Alan Stern
On Mon, 4 Jun 2007, Pavel Machek wrote: > > With the USB subsystem I have followed the approach taken by the PM > > core, which is that tasks are frozen. But one can -- and Linus has on > > at least one occasion -- make a good case that tasks should be left > > running while only I/O is frozen.

<    1   2   3   4   5   6   7   8   9   >