Re: [PATCH] posix-timer: fix deletion race

2007-07-17 Thread Thomas Gleixner
On Wed, 2007-07-18 at 08:05 +0200, Thomas Gleixner wrote: > On Tue, 2007-07-17 at 16:58 -0700, Jeremy Katz wrote: > > > Scratch that. I had infrastructure problems, and ended up using the wrong > > build. > > > EFLAGS: 00010246 (2.6.22.1-WR1.4aq_cgl #2) > > Hmm. Are there any other patches o

Re: [PATCH 4/10] cpu: deliver CPU_UP_CANCELED only to NOTIFY_OKed callbacks with CPU_UP_PREPARE

2007-07-17 Thread Gautham R Shenoy
Hi! On Wed, Jul 18, 2007 at 02:18:41AM +0900, Akinobu Mita wrote: > >> So it is natural to deliver CPU_UP_CANCELED event only to the functions > >> that have returned NOTIFY_OK with CPU_UP_PREPARE event and not to call > >> the function that have returned NOTIFY_BAD. This is what this patch is > >

Re: [ofa-general] Further 2.6.23 merge plans...

2007-07-17 Thread Or Gerlitz
Roland Dreier wrote: > I would like to see these features moved upstream. DOE funded this > work as part of the items we see needing on our large scale IB > deployment (both present and future). So from at least one big customer > perspective we see this as useful. Does your refere

Re: [PATCH] vmalloc_32 should use GFP_KERNEL

2007-07-17 Thread Benjamin Herrenschmidt
On Tue, 2007-07-17 at 23:33 -0700, Andrew Morton wrote: > whoops, yes. > > Are those errors serious and common enough for 2.6.22.x? No idea, so far, the nouveau DRM isn't something I would recommend to people to use in stable environments but heh... I don't know who else uses vmalloc_32. Cheer

Re: [patch] CFS scheduler, -v19

2007-07-17 Thread Ian Kent
On Tue, 2007-07-17 at 21:24 -0400, Bill Davidsen wrote: > Ingo Molnar wrote: > > * Ian Kent <[EMAIL PROTECTED]> wrote: > > > > > >>> ah! It passes in a low-res time source into a high-res time interface > >>> (pthread_cond_timedwait()). Could you change the time(NULL) + 1 to > >>> time(NULL) +

Re: uninline check_signature()

2007-07-17 Thread Geert Uytterhoeven
On Tue, 17 Jul 2007, Linus Torvalds wrote: > On Tue, 17 Jul 2007, Geert Uytterhoeven wrote: > > OR I'll have to disable HAS_IOMEM on m68k, and invent a new Kconfig > > symbol for lots of other stuff that currently depends on HAS_IOMEM... > > Well, as far as I'm concerned, you could also make all d

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-17 Thread Ray Lee
On 7/17/07, Alan Cox <[EMAIL PROTECTED]> wrote: On Mon, 16 Jul 2007 16:15:28 -0700 "Ray Lee" <[EMAIL PROTECTED]> wrote: > Heh :-). No, it's not a question of trust. First and foremost, it's > that there are still users who say that they can crash a current > 4k+interrupt stacks kernel, while the

Re: [PATCH] Add nid sanity on alloc_pages_node

2007-07-17 Thread Joe Jin
On 2007-07-18 05:49, Hugh Dickins wrote: > On Wed, 18 Jul 2007, Joe Jin wrote: > > > > With your patch, I have reproduced the panic: > > That is... surprising to me. (I hadn't been able to reproduce it with > or without the patches: maybe I just need to try harder.) Please post > your gcc --ve

Re: VESAFB CUSTOM RESOLUTION

2007-07-17 Thread Sasa Ostrouska
On 7/18/07, Daniel Drake <[EMAIL PROTECTED]> wrote: Sasa Ostrouska wrote: > I want to ask one question about a custom resolution in the console. > I have a Sony Vaio Laptop VGN-SZ2VP/X, the screen resolution is > 1280x800, now I'm using the vga=773 which is an 1024x768 but this is > ugly as I get

Re: [PATCH] vmalloc_32 should use GFP_KERNEL

2007-07-17 Thread Andrew Morton
On Wed, 18 Jul 2007 16:25:34 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > I've noticed lots of failures of vmalloc_32 on machines where it > shouldn't have failed unless it was doing an atomic operation. > > Looking closely, I noticed that: > > #if defined(CONFIG_64BIT) && defined(

Re: [Resend][PATCH 1/9] ACPI: Implement the set_target() callback from pm_ops

2007-07-17 Thread Rafael J. Wysocki
On Wednesday, 18 July 2007 02:02, Andrew Morton wrote: > On Tue, 17 Jul 2007 22:40:06 +0200 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > > > In the future some drivers may need to use ACPI to determine the low power > > states in which to

Re: regression: disk error loop (panic?) ide_do_rw_disk-bad:

2007-07-17 Thread Giacomo Catenazzi
Linus Torvalds wrote: > > On Tue, 17 Jul 2007, Bartlomiej Zolnierkiewicz wrote: >> ide-disk driver and type 2 (REQ_TYPE_BLOCK_PC) requests don't mix well >> >> Probably some dumb application is sending packet commands without >> checking the device type... > > Ok, we should definitely try to just

[PATCH] vmalloc_32 should use GFP_KERNEL

2007-07-17 Thread Benjamin Herrenschmidt
I've noticed lots of failures of vmalloc_32 on machines where it shouldn't have failed unless it was doing an atomic operation. Looking closely, I noticed that: #if defined(CONFIG_64BIT) && defined(CONFIG_ZONE_DMA32) #define GFP_VMALLOC32 GFP_DMA32 #elif defined(CONFIG_64BIT) && defined(CONFIG_ZO

Re: [PATCH] Re: 2.6.22-git ppc build failure

2007-07-17 Thread Tony Breeds
On Tue, Jul 17, 2007 at 07:27:51PM -0700, Linus Torvalds wrote: > Ok, thanks. Maybe it's the merge, and maybe it's one of the sides. You > might want to double-check that both parents are ok before you look too > closely at the merge itself. Turns out the boot failure wasn't related to the mer

Re: fbdev: make fb_append_extra_logo() depend on fb=y

2007-07-17 Thread Geert Uytterhoeven
On Wed, 18 Jul 2007, Arnd Bergmann wrote: > We can't show the extra logo from boot code if FB is built as > a module. Make the FB_LOGO_EXTRA depend on FB=y. Bummer... > Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]> Acked-by: Geert Uytterhoeven <[EMAIL PROTECTED]> > Reported by Al Viro. I don

Re: [PATCH] posix-timer: fix deletion race

2007-07-17 Thread Thomas Gleixner
On Tue, 2007-07-17 at 16:58 -0700, Jeremy Katz wrote: > Scratch that. I had infrastructure problems, and ended up using the wrong > build. > EFLAGS: 00010246 (2.6.22.1-WR1.4aq_cgl #2) Hmm. Are there any other patches on that kernel ? Is there a chance that you can whip up a test program whi

Re: Containers: css_put() dilemma

2007-07-17 Thread Paul (宝瑠) Menage
On 7/17/07, Balbir Singh <[EMAIL PROTECTED]> wrote: Ok.. so my problem still remains, how do I get a non-blocking atomic reference increment/decrement routine, that would prevent my container from being deleted? css_put() in my new patchset will be non-blocking. I don't find cpusets using c

RE: [patch] CFS scheduler, -v19

2007-07-17 Thread Ian Kent
On Tue, 2007-07-17 at 14:16 -0700, David Schwartz wrote: > > * Ian Kent <[EMAIL PROTECTED]> wrote: > > > > > Yes it does and I have two reported bugs so far. > > > > > > In several places I have code similar to: > > > > > > wait.tv_sec = time(NULL) + 1; > > > wait.tv_nsec = 0; > > > > > > signaled

Re: [PATCH] x86: make SMP locks handling interact properly with CONFIG_DEBUG_RODATA (2nd try)

2007-07-17 Thread Jan Beulich
>> void alternatives_smp_module_del(struct module *mod) >> { >> struct smp_alt_module *item; >> -unsigned long flags; >> >> if (smp_alt_once || noreplace_smp) >> return; >> >> -spin_lock_irqsave(&smp_alt, flags); >> +spin_lock(&smp_alt); > >Unrelated change?

[PATCH 3/3] x86-64: make flush_tlb_kernel_range() a static inline function

2007-07-17 Thread Jeff Garzik
The following change was checked into 'warnings' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git commit b1c9131343597967d8fcc042f59e4ed36ea2855f Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Wed Jul 18 01:47:39 2007 -0400 [X86-64] make flush_tlb_kernel_range()

[PATCH 2/3] drivers/video/aty/radeon_base: fix radeonfb_pci_register() err handling

2007-07-17 Thread Jeff Garzik
The following change was checked into 'warnings' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git commit 61470a24062de01853fb922ec4a81dcd1c0ba1d0 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Wed Jul 18 01:43:05 2007 -0400 drivers/video/aty/radeon_base: fix rade

[PATCH 1/3] drivers/base/core: improve device_add() error handling, fix bugs

2007-07-17 Thread Jeff Garzik
The following change was checked into 'warnings' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git commit 5330916f5a11d8b7def46a6b3e14a831684032f5 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Wed Jul 18 01:41:29 2007 -0400 drivers/base/core: improve device_add()

Re: oops with 2.6.22.1 - bad magic number for tty struct

2007-07-17 Thread Jiri Slaby
John Stoffel napsal(a): > Zdenek> I get kernel oopses when I run powertop on my old BP6 SMP dual > Zdenek> Celeron board. > > Zdenek> In case more details are needed - send me a replay. > > Since it's tainted with a proprietary module, we can't do anything > here. Please re-create the oops witho

Re: Oops while modprobing phy fixed module

2007-07-17 Thread Tejun Heo
Okay, successfully reproduced here. Will hunt down. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Add nid sanity on alloc_pages_node

2007-07-17 Thread Andrew Morton
On Wed, 18 Jul 2007 05:49:50 +0100 (BST) Hugh Dickins <[EMAIL PROTECTED]> wrote: > > With your patch, I have reproduced the panic: > > That is... surprising to me. To me also. I'd like to double-check the code which Joe actually tested, please - have a sneaking suspicion that the 2.6.22 version

Re: Containers: css_put() dilemma

2007-07-17 Thread Srivatsa Vaddagiri
On Wed, Jul 18, 2007 at 11:00:39AM +0530, Balbir Singh wrote: > Thinking out loud again, can we add can_destory() callbacks? I remember suggesting such a callback long before : http://marc.info/?l=linux-kernel&m=117576241131788&w=2 -- Regards, vatsa - To unsubscribe from this list: send

Re: Containers: css_put() dilemma

2007-07-17 Thread Balbir Singh
Balbir Singh wrote: > Paul (??) Menage wrote: >> On 7/17/07, Balbir Singh <[EMAIL PROTECTED]> wrote: >>> without too much knowledge of each other. BTW, what are the semantics >>> of css_put() is it expected to free the container/run the release agent >>> when the reference count of the container_su

Re: [PATCH] appletouch powersaving - please apply for 2.6.23-rc1 take #3

2007-07-17 Thread Soeren Sonnenburg
On Tue, 2007-07-17 at 21:48 -0400, Dmitry Torokhov wrote: > On Tuesday 17 July 2007 14:16, Soeren Sonnenburg wrote: > > On Tue, 2007-07-17 at 11:01 -0400, Dmitry Torokhov wrote: > [...] > > > How many boxes did you try this patch on? > > > > Mine plus 1 other. However please note that Matthews pat

[PATCH] sysfs: make sysfs_init_inode() static

2007-07-17 Thread Tejun Heo
With sysfs_fill_super() converted to use sysfs_get_inode(), there is no user of sysfs_init_inode() outside of fs/sysfs/inode.c. Make it static. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- fs/sysfs/inode.c |2 +- fs/sysfs/sysfs.h |1 - 2 files changed, 1 insertion(+), 2 deletions(-)

[PATCH] sysfs: fix sysfs root inode nlink accounting

2007-07-17 Thread Tejun Heo
While making sysfs indoes hashed, sysfs root inode was left out. Now that nlink accounting depends on the inode being on the hash, sysfs root inode nlink isn't adjusted properly. Put sysfs root inode on the inode hash by allocating it using sysfs_get_inode() like other sysfs inodes. While at it,

[git pull] More input updates for post-2.6.22

2007-07-17 Thread Dmitry Torokhov
Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for input subsystem. Changelog: - Dmitry Torokhov (3): Input: add driver fo

RE: [ofa-general] Further 2.6.23 merge plans...

2007-07-17 Thread Sean Hefty
>I think this is an important question. If we merge the local SA >stuff, then are we creating a problem for dealing with QoS? Yes - I do believe that merging PR caching and QoS together will be difficult. I don't think the problems are insurmountable, but I can't say that I have a definite soluti

Re: [PATCH] Documentation fix devres.txt: lib/iomap.c -> lib/devres.c

2007-07-17 Thread Tejun Heo
Brandon Philips wrote: > Signed-off-by: Brandon Philips <[EMAIL PROTECTED]> Acked-by: Tejun Heo <[EMAIL PROTECTED]> -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majo

Re: [git patches 1/2] warnings: attack valid cases spotted by warnings

2007-07-17 Thread Linus Torvalds
On Tue, 17 Jul 2007, Roland Dreier wrote: > > > Anyway, here's a totally untested cleanup that compiles but probably > > doesn't work, because I didn't check that I did the right thing with all > > the pointer arithmetic (ie when I change "wqe" to a real structure pointer > > instead of j

[PATCH] Documentation fix devres.txt: lib/iomap.c -> lib/devres.c

2007-07-17 Thread Brandon Philips
Signed-off-by: Brandon Philips <[EMAIL PROTECTED]> --- Documentation/driver-model/devres.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/driver-model/devres.txt b/Documentation/driver-model/devres.txt index 6c8d8f2..8569072 100644 --- a/Documentation/dr

compile error if CONFIG_BLOCK not enabled related to linux/ide.h include

2007-07-17 Thread Kumar Gala
M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] We get the following compile error if CONFIG_BLOCK isn't enabled: CC arch/powerpc/kernel/setup_32.o In file included from arch/powerpc/kernel/setup_32.c:14: include/linux/ide.h:558: error: expected specifier-qualifier-list before 'reques

Re: attempting to open a VT from elsewhere and take raw keyboard input

2007-07-17 Thread Shawn Rutledge
Yes I know that X does it; I'm trying to write a new windowing system which also does that, and the question is how they did it. I would have expected if I just open /dev/tty1, set raw mode, and set some termios flags I'd get every key press and release; and it would be my choice whether to use b

Re: [PATCH] Add nid sanity on alloc_pages_node

2007-07-17 Thread Hugh Dickins
On Wed, 18 Jul 2007, Joe Jin wrote: > > With your patch, I have reproduced the panic: That is... surprising to me. (I hadn't been able to reproduce it with or without the patches: maybe I just need to try harder.) Please post your gcc --version, and the disassembly (objdump -d) output for alloc

[PATCH] Mark sparc and sparc64 as not having virt_to_bus

2007-07-17 Thread Stephen Rothwell
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> --- arch/sparc/Kconfig |3 +++ arch/sparc64/Kconfig |3 +++ include/asm-sparc64/io.h |5 - 3 files changed, 6 insertions(+), 5 deletions(-) This is part of a rash attempt to make allmodconfig builds work for sparc and

Re: [PATCH] Optimize struct task_delay_info

2007-07-17 Thread Zhang, Yanmin
On Wed, 2007-07-11 at 17:16 +0530, Balbir Singh wrote: > Zhang, Yanmin wrote: > > struct task_delay_info is used by per process block I/O delay statistics > > feature which is useful in kernel. This struct is not optimized. > > > > My patch against kernel 2.6.22 shrinks it a half. > > > > 1) Dele

Re: Containers: css_put() dilemma

2007-07-17 Thread Balbir Singh
Paul (??) Menage wrote: > On 7/17/07, Balbir Singh <[EMAIL PROTECTED]> wrote: >> without too much knowledge of each other. BTW, what are the semantics >> of css_put() is it expected to free the container/run the release agent >> when the reference count of the container_subsys_state drops to zero?

init_mm locking

2007-07-17 Thread Benjamin Herrenschmidt
Another things I stumbled on lately when toying with some mm rework on powerpc, is the lack of any locking when manipulating init_mm page tables. We don't use the pte_lockptr (well, we don't know where the pmd comes from here, we can't toy around with that struct page), but we don't use anything el

Re: [PATCH] UP: smp_call_function_single() must warn on irqs_disabled()

2007-07-17 Thread Satyam Sharma
On Wed, 18 Jul 2007, Satyam Sharma wrote: > On Wed, 18 Jul 2007, Al Viro wrote: > > > On Wed, Jul 18, 2007 at 01:24:46AM +0200, Uwe Kleine-Konig wrote: > > > [...] > > > a52b1752c07 introduces usage of the WARN_ON macro in , but > > > doesn't pull in . ( is not enough, at least > > > for arm, be

Re: [git patches 1/2] warnings: attack valid cases spotted by warnings

2007-07-17 Thread Roland Dreier
> Quite frankly, I don't quite understand where you get those enormous balls > you have, that you can then talk about how ugly it is to just add a "= 0" > that shuts up a compiler warning. That's the _least_ ugly part of the > whole damn function! The clanking when I walk annoys people in t

Re: Hibernation considerations

2007-07-17 Thread david
On Wed, 18 Jul 2007, Matthew Garrett wrote: On Tue, Jul 17, 2007 at 08:19:32AM -0700, [EMAIL PROTECTED] wrote: On Tue, 17 Jul 2007, Matthew Garrett wrote: Powering off rather than using S4 means you lose most wakeup device support. That would be a functional regression compared to the current

Re: [git patches 1/2] warnings: attack valid cases spotted by warnings

2007-07-17 Thread Linus Torvalds
On Tue, 17 Jul 2007, Roland Dreier wrote: > > I think this patch (on top of the previous one) actually makes the > code clearer Quite frankly, calling this "making the code clearer" is a bit ridiculous. That code still is absolute *crap* from a readability angle. It doesn't follow any sane cod

[PATCH] UP: smp_call_function_single() must warn on irqs_disabled()

2007-07-17 Thread Satyam Sharma
On Wed, 18 Jul 2007, Al Viro wrote: > On Wed, Jul 18, 2007 at 01:24:46AM +0200, Uwe Kleine-Konig wrote: > > [...] > > a52b1752c07 introduces usage of the WARN_ON macro in , but > > doesn't pull in . ( is not enough, at least > > for arm, because WARN_ON uses printk there.) > > > > The obvious

CONFIG_IDE_PROC_FS: /sys is not full replacement of /proc

2007-07-17 Thread Andrey Borzenkov
May be I miss something obvious but most information that was available in /proc/ide is missing under /sys. At the very least, Mandriva hardware detection expects /proc/ide/hdX/model; nothing close is under /sys. Are there any plans to extend IDE /sys interface to provide full range of informat

Re: [git patches 1/2] warnings: attack valid cases spotted by warnings

2007-07-17 Thread Jeff Garzik
Roland Dreier wrote: In this case the code is basically u32 x; for (n = 0; cond; ++n) { ... if (!n) x = something; ... } if (n) { ... use(x);

Re: [ofa-general] Further 2.6.23 merge plans...

2007-07-17 Thread Roland Dreier
> > But to be fair, it will be difficult to enable both QoS and local PR > > caching. To me, this would be the strongest reason against using it. > > However, QoS places additional burden on the SA, which will make scaling > > even more challenging. > > my understanding is that the local sa

Re: [PATCH] fs: Add romfs version 2

2007-07-17 Thread Lindsay Roberts
On 7/18/07, Matt Mackall <[EMAIL PROTECTED]> wrote: > > * Adds new derivative of romfs filesystem (rom2fs) with > > block aligned regular file data to bring performance > > parity with ext2/3. This is about 225% of the read > > speed of the existing romfs. Doesn't that make these filesyste

Re: [git patches 1/2] warnings: attack valid cases spotted by warnings

2007-07-17 Thread Roland Dreier
> > So setting a variable to something meaningless (guaranteeing that a > > garbage value is used in case of a bug) just to shut up a warning makes > > no sense -- it's no safer than leaving the code as is. > > Wrong. > > It's safer for two reasons: > - now everybody will see the *sa

Re: sysfs root link count broken in 2.6.22-git5

2007-07-17 Thread Tejun Heo
Hello, Sorry about late response. -EWASPUBLICHOLIDAY. That's something I've broken apparently. Will fix soon. Thanks. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.or

Re: [PATCH][DOC]hpet.txt broken link fix

2007-07-17 Thread Dave Young
On 7/11/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: Dave Young wrote: > Hi, randy > > how about remove the spec links in the header files as well. > > Subject: > Remove document links in hpet header files. > > Signed-off-by: Dave Young <[EMAIL PROTECTED]> Agreed. Acked-by: Randy Dunlap <[EMAIL P

Re: [git patches 1/2] warnings: attack valid cases spotted by warnings

2007-07-17 Thread Linus Torvalds
On Tue, 17 Jul 2007, Roland Dreier wrote: > > So setting a variable to something meaningless (guaranteeing that a > garbage value is used in case of a bug) just to shut up a warning makes > no sense -- it's no safer than leaving the code as is. Wrong. It's safer for two reasons: - now ever

Re: [git patches 1/2] warnings: attack valid cases spotted by warnings

2007-07-17 Thread Roland Dreier
I think this patch (on top of the previous one) actually makes the code clearer, and also makes it smaller: add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-41 (-41) function old new delta mthca_tavor_post_send 13441335 -9 mthca_

[PATCH 3/3] [net/core] move __dev_addr_discard adjacent to dev_addr_discard for readability

2007-07-17 Thread Denis Cheng
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- net/core/dev.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 17c9cbd..6357f54 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2715,20 +2715,6 @@ int

[PATCH 2/3] [net/core] merge dev_unicast_discard and dev_mc_discard into one

2007-07-17 Thread Denis Cheng
this two functions could share the dev->_xmit_lock acquired context. Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- net/core/dev.c | 16 1 files changed, 4 insertions(+), 12 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 3ba63aa..17c9cbd 100644 --- a/net/c

[PATCH 1/3] [net/core] move dev_mc_discard from dev_mcast.c to dev.c

2007-07-17 Thread Denis Cheng
Because this function is only called by unregister_netdevice, this moving could make this non-global function static, and also remove its declaration in netdevice.h; Any further, function __dev_addr_discard is also just called by dev_mc_discard and dev_unicast_discard, keeping this two functions b

Re: [git patches 1/2] warnings: attack valid cases spotted by warnings

2007-07-17 Thread Roland Dreier
> I don't buy that performance argument, in this case. You are already > dirtying the same cacheline with other variable initializations. > > Like I noted in the changeset description (hey, this is precisely why > I included it, so that we could have this discussion), IMO the flow of > cont

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-17 Thread Rene Herman
On 07/17/2007 01:27 AM, Matt Mackall wrote: Larger soft pages waste tremendous amounts of memory (mostly in page cache) for minimal benefit on, say, the typical desktop. While there are workloads where it's a win, it's probably on a small percentage of machines. So it's absolutely no help in fi

Re: [PATCH] Re: 2.6.22-git ppc build failure

2007-07-17 Thread Linus Torvalds
On Wed, 18 Jul 2007, Tony Breeds wrote: > > On Tue, Jul 17, 2007 at 06:44:26PM -0700, Linus Torvalds wrote: > > > Thanks. I assume this has been boot-tested too, and everything else from > > the PCI merge was ok? > > *cough* umm the boot test fails. I'll look harder at the merge, and > provid

Re: [PATCH] Re: 2.6.22-git ppc build failure

2007-07-17 Thread Tony Breeds
On Tue, Jul 17, 2007 at 06:44:26PM -0700, Linus Torvalds wrote: > Thanks. I assume this has been boot-tested too, and everything else from > the PCI merge was ok? *cough* umm the boot test fails. I'll look harder at the merge, and provide a better patch. Yours Tony linux.conf.auhttp

Re: Hibernation considerations

2007-07-17 Thread Matthew Garrett
On Tue, Jul 17, 2007 at 08:19:32AM -0700, [EMAIL PROTECTED] wrote: > On Tue, 17 Jul 2007, Matthew Garrett wrote: > >Powering off rather than using S4 means you lose most wakeup device > >support. That would be a functional regression compared to the current > >code. > > only if the kexec isn't abl

Re: [PATCH 0/2] SELinux Netlabel updates

2007-07-17 Thread Paul Moore
On Tuesday 17 July 2007 8:24:55 pm Linus Torvalds wrote: > On Tue, 17 Jul 2007, James Morris wrote: > > These are updated Netlabel/SELinux changes from Paul, reworked so that > > they don't break userspace. Michal says they work for him. Please apply > > for 2.6.23. > > They don't work AT ALL for

Re: VESAFB CUSTOM RESOLUTION

2007-07-17 Thread Daniel Drake
Sasa Ostrouska wrote: I want to ask one question about a custom resolution in the console. I have a Sony Vaio Laptop VGN-SZ2VP/X, the screen resolution is 1280x800, now I'm using the vga=773 which is an 1024x768 but this is ugly as I get a border of about 2-3cm on one the sides of the screen. So

Re: [PATCH] appletouch powersaving - please apply for 2.6.23-rc1 take #3

2007-07-17 Thread Dmitry Torokhov
On Tuesday 17 July 2007 14:16, Soeren Sonnenburg wrote: > On Tue, 2007-07-17 at 11:01 -0400, Dmitry Torokhov wrote: > > Hi, > > > > On 7/17/07, Soeren Sonnenburg <[EMAIL PROTECTED]> wrote: > > > > > > err_free_buffer: > > > @@ -656,6 +699,7 @@ static void atp_disconnect(struct usb_interface > >

Re: [PATCH] Re: 2.6.22-git ppc build failure

2007-07-17 Thread Linus Torvalds
On Wed, 18 Jul 2007, Tony Breeds wrote: > > Fix compile failure in arch/powerpc/kernel/pci-common.c Thanks. I assume this has been boot-tested too, and everything else from the PCI merge was ok? Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH] Add nid sanity on alloc_pages_node

2007-07-17 Thread Joe Jin
With your patch, I have reproduced the panic: Unable to handle kernel paging request at 186a RIP: [] __alloc_pages+0x2f/0x2c3 PGD 72595067 PUD 72594067 PMD 0 Oops: [1] SMP CPU 0 Modules linked in: xt_tcpudp iptable_filter ip_tables x_tables cpufreq_ondemand dm_mirror dm_mul

Re: Geode GX framebuffer driver: Arcom vs. AMD

2007-07-17 Thread Jordan Crouse
On 14/07/07 17:05 -0400, Andrew Paprocki wrote: > Tony, > > Do you have the patch working already? I'd love to try this out in the > meantime on the LX system I am developing with at the moment. I'm > assuming you worked this into the existing Arcom framework (gxfb) and > pulled the necessary piec

Re: Patches for REALLY TINY 386 kernels

2007-07-17 Thread Andi Kleen
Jonathan Campbell <[EMAIL PROTECTED]> writes: > I wrote a set of patches out of concern that even if you compile a 386 > kernel a lot of code irrelevent to legacy machines still > remains. Things like the Pentium TSC register, DMI information, ESCD > parsing, and the use of CPUID do not apply to t

Re: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats}

2007-07-17 Thread Chris Wright
* Andrew Morton ([EMAIL PROTECTED]) wrote: > Sorry, but I can't be bothered splitting it up. Greg, Chris: please just > apply the bits which apply and drop the other bits if that's OK. Yup - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [patch] CFS scheduler, -v19

2007-07-17 Thread Bill Davidsen
Ingo Molnar wrote: * Ian Kent <[EMAIL PROTECTED]> wrote: ah! It passes in a low-res time source into a high-res time interface (pthread_cond_timedwait()). Could you change the time(NULL) + 1 to time(NULL) + 2, or change it to: gettimeofday(&wait, NULL); wait.tv_sec++;

Re: [PATCH] Pass nr_wake2 to futex_wake_op

2007-07-17 Thread Andrew Morton
On Tue, 17 Jul 2007 13:31:29 +0200 Andreas Schwab <[EMAIL PROTECTED]> wrote: > The fourth argument of sys_futex is ignored when op == FUTEX_WAKE_OP, > but futex_wake_op expects it as its nr_wake2 parameter. > > The only user of this operation in glibc is always passing 1, so this > bug had no con

[PATCH] Re: 2.6.22-git ppc build failure

2007-07-17 Thread Tony Breeds
On Tue, Jul 17, 2007 at 11:04:57AM -0700, Bret Towe wrote: > this is off my g4 mac mini > latest git as of when this email was sent > config file attached Hi Bret, the patch below will fix it. From: Tony Breeds <[EMAIL PROTECTED]> Fix compile failure in arch/powerpc/kernel/pci-common.c

Re: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats}

2007-07-17 Thread Andrew Morton
On Tue, 17 Jul 2007 14:36:10 +0200 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > > > On every open/close one struct seq_operations leaks. > > Kudos to /proc/slab_allocators. > > > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> > > ouch ... > >

Re: [PATCH] AFS: Fix file locking

2007-07-17 Thread Andrew Morton
On Tue, 17 Jul 2007 13:47:32 +0100 David Howells <[EMAIL PROTECTED]> wrote: > + if (type == AFS_LOCK_READ && > + vnode->flags & (1 << AFS_VNODE_READLOCKED)) { Here we use vnode->flags & (1 << foo) > + set_bit(AFS_VNODE_LOCKING, &vnode->flags); and elsewhere we u

Re: 2.6.23 compile failure - slab/slob interspanking

2007-07-17 Thread Matt Mackall
On Wed, Jul 18, 2007 at 09:18:36AM +0900, Paul Mundt wrote: > On Tue, Jul 17, 2007 at 10:00:08PM +0200, Jan Engelhardt wrote: > > 81cda6626178cd55297831296ba8ecedbfd8b52d is first bad commit > > commit 81cda6626178cd55297831296ba8ecedbfd8b52d > > Author: Christoph Lameter <[EMAIL PROTECTED]> > > Da

Re: [PATCH 0/2] SELinux Netlabel updates

2007-07-17 Thread Linus Torvalds
On Wed, 18 Jul 2007, Michal Piotrowski wrote: > > Once again I tested both patches, build log shows only this You clearly didn't test them with CONFIG_NETLABEL set to off, or you have a buggy compiler. You had int netlbl_enabled(void) { return 0; } in

Re: [patch 37/44] xen: add virtual network device driver

2007-07-17 Thread Jeremy Fitzhardinge
Rusty Russell wrote: > The default function points to the internal stats... > Right you are. J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please r

Re: [PATCH 0/2] SELinux Netlabel updates

2007-07-17 Thread Michal Piotrowski
Linus Torvalds pisze: > > On Tue, 17 Jul 2007, James Morris wrote: >> These are updated Netlabel/SELinux changes from Paul, reworked so that >> they don't break userspace. Michal says they work for him. Please apply >> for 2.6.23. > > They don't work AT ALL for me: > > security/selinux

Re: 2.6.23 compile failure - slab/slob interspanking

2007-07-17 Thread Andrew Morton
On Wed, 18 Jul 2007 09:18:36 +0900 Paul Mundt <[EMAIL PROTECTED]> wrote: > --- a/include/linux/slob_def.h > +++ b/include/linux/slob_def.h > @@ -33,14 +33,4 @@ static inline void *__kmalloc(size_t size, gfp_t flags) > return kmalloc(size, flags); > } > > -/** > - * kzalloc - allocate memo

Re: [PATCH 0/2] Kexec jump: The first step to kexec base hibernation

2007-07-17 Thread david
On Tue, 17 Jul 2007, Rafael J. Wysocki wrote: On Tuesday, 17 July 2007 14:48, Huang, Ying wrote: On Tue, 2007-07-17 at 01:13 -0700, [EMAIL PROTECTED] wrote: however, since the resume designed for ACPI won't work would the following approach work 1. boot one kernel 2. setup a kexec the same wa

Re: block/bsg.c

2007-07-17 Thread Bartlomiej Zolnierkiewicz
[ James, please remeber to cc: linux-ide on IDE patches, thanks. ] On Wednesday 18 July 2007, Jeff Garzik wrote: > James Bottomley wrote: > > @@ -1052,9 +1054,10 @@ int generic_ide_ioctl(ide_drive_t *drive, struct > > file *file, struct block_device > > int err, (*setfunc)(ide_drive_t *, int

Re: [PATCH 0/2] SELinux Netlabel updates

2007-07-17 Thread Linus Torvalds
On Tue, 17 Jul 2007, James Morris wrote: > > These are updated Netlabel/SELinux changes from Paul, reworked so that > they don't break userspace. Michal says they work for him. Please apply > for 2.6.23. They don't work AT ALL for me: security/selinux/ss/sidtab.o: In function `netl

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-17 Thread Rene Herman
On 07/18/2007 01:39 AM, Jesper Juhl wrote: On 17/07/07, William Lee Irwin III <[EMAIL PROTECTED]> wrote: At hch's suggestion I rewrote the separate IRQ stack configurability patch into one making IRQ stacks mandatory and unconfigurable, and hence enabled with 8K stacks. For what it's worth,

Re: block/bsg.c

2007-07-17 Thread FUJITA Tomonori
From: James Bottomley <[EMAIL PROTECTED]> Subject: Re: block/bsg.c Date: Tue, 17 Jul 2007 13:53:54 -0500 > On Tue, 2007-07-17 at 12:19 +0200, Jens Axboe wrote: > > > > Since Linus is happily snoring by now, could you test and see if the > > > > tree works for you? > > > > > > It works for me. I'l

Occational lockups during boot with post 2.6.22 kernels

2007-07-17 Thread Peter Osterlund
Current -git kernels sometimes lock up on my computer during boot. I guess it happens about 10-20% of the time. I first saw this maybe a week ago, but never with kernels <= 2.6.22. The last reported info on the console is that named is started. SysRq-T still works and reports the non-sleeping task

Re: 2.6.23 compile failure - slab/slob interspanking

2007-07-17 Thread Paul Mundt
On Tue, Jul 17, 2007 at 10:00:08PM +0200, Jan Engelhardt wrote: > 81cda6626178cd55297831296ba8ecedbfd8b52d is first bad commit > commit 81cda6626178cd55297831296ba8ecedbfd8b52d > Author: Christoph Lameter <[EMAIL PROTECTED]> > Date: Tue Jul 17 04:03:29 2007 -0700 > > Slab allocators: Cleanup

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-17 Thread Alan Cox
> I can't speak for Fedora, but RHEL disables XFS in their kernel likely > because it is known to cause problems with 4K stacks. -was- - the SGI folks submitted patches to deal with some gcc problems with stack usage. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-17 Thread Alan Cox
On Mon, 16 Jul 2007 16:15:28 -0700 "Ray Lee" <[EMAIL PROTECTED]> wrote: > On 7/16/07, Rene Herman <[EMAIL PROTECTED]> wrote: > > Yes but it's also an argument that the 4K stacks don't make the _current_ > > situation without CONFIG_4KSTACKS selected worse and given that you trust > > that current

Re: [PATCH] smp_call_function_single() should be a macro on UP

2007-07-17 Thread Linus Torvalds
On Wed, 18 Jul 2007, Ben Dooks wrote: > > This has broken _all_ ARM builds, due to using WARN_ON() > in this header. I think Al's patch already fixes that, since now it's back to being a macro, and thus the whole WARN_ON() is only visible where the macro is _used_, not in the header itself.

Re: [Resend][PATCH 1/9] ACPI: Implement the set_target() callback from pm_ops

2007-07-17 Thread Andrew Morton
On Tue, 17 Jul 2007 22:40:06 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > In the future some drivers may need to use ACPI to determine the low power > states in which to place their devices, but to provide the drivers with this > informati

Re: [PATCH] posix-timer: fix deletion race

2007-07-17 Thread Jeremy Katz
On Tue, 17 Jul 2007, Jeremy Katz wrote: On Tue, 17 Jul 2007, Thomas Gleixner wrote: With 2.6.14 or with current mainline ? I haven't been keeping notes quite as studiously as I should have been, but this just occurred with 2.6.22.1 + the hrt6 patch + your proposed fix: Scratch that. I ha

Re: [PATCH] smp_call_function_single() should be a macro on UP

2007-07-17 Thread Al Viro
On Wed, Jul 18, 2007 at 12:54:17AM +0100, Ben Dooks wrote: > This has broken _all_ ARM builds, due to using WARN_ON() > in this header. Warn on needs and this is > needs to make it compile cleanly on ARM > which is unfortuantely what we where trying to avoid in > the first place? > > This patch

[PATCH 6/6] drivers edac add to edac docs

2007-07-17 Thread dougthompson
From: Doug Thompson <[EMAIL PROTECTED]> Updated the EDAC kernel documentation Signed-off-by: Doug Thompson <[EMAIL PROTECTED]> --- edac.txt | 192 ++- 1 file changed, 165 insertions(+), 27 deletions(-) Index: linux-2.6.22-rc6-mm1/D

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-17 Thread Rene Herman
On 07/18/2007 01:19 AM, Bodo Eggert wrote: Please post a list of things you have designed, so I can avoid them. - The ability to read - The ability to understand You're doing a hell of a job already. Rene. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

[PATCH 5/6] drivers edac fix edac_device sysfs corner case bug

2007-07-17 Thread dougthompson
From: Doug Thompson <[EMAIL PROTECTED]> Some simple fixes to properly reference counter values from the block attribute level of edac_device objects. Properly sequencing the array pointer was added, resulting in correct identification of block level attributes from their base class functions. A

[PATCH 3/6] drivers edac new i82975x driver

2007-07-17 Thread dougthompson
From: Ranganathan Desikan <[EMAIL PROTECTED]> New EDAC driver for the i82975x memory controller chipset Used on ASUS motherboards Signed-off-by: [EMAIL PROTECTED] Signed-off-by: Ranganathan Desikan <[EMAIL PROTECTED]> Signed-off-by: Doug Thompson <[EMAIL PROTECTED]> --- Kconfig|7

[PATCH 4/6] drivers edac add to maintainers new info

2007-07-17 Thread dougthompson
From: Douglas Thompson <[EMAIL PROTECTED]> Update maintainer information on edac components Signed-off-by: Doug Thompson <[EMAIL PROTECTED]> --- MAINTAINERS | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) Index: linux-2.6.22-rc6-mm1/MAINTAINERS =

  1   2   3   4   5   6   7   >