Re: About get_page for compound page

2007-07-19 Thread Peter Zijlstra
On Fri, 2007-07-20 at 07:59 +0800, Fengwei Yin wrote: > On 7/20/07, Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > On Thu, 2007-07-19 at 23:54 +0800, Fengwei Yin wrote: > > > Hi, > > > In get_page(), the parameter page is changed by > > > page = compound_head(page); > > > if the page is not

Re: [PATCH] Move KVM, paravirt, lguest, VMI and Xen under arch-level Virtualization option

2007-07-19 Thread Zachary Amsden
Rusty Russell wrote: Otherwise we end up with $NARCH copies of that Kconfig, each slightly different. The top-level entry can be made to depend on the archs that actually have some virt capability, so as not to show empty an menu. I dislike the duplication, too, but 1) it's a CPU capab

Re: 2.6.22-git: known regressions with patches

2007-07-19 Thread Cornelia Huck
On Thu, 19 Jul 2007 18:35:04 +0200, Michal Piotrowski <[EMAIL PROTECTED]> wrote: > FS > > Subject : AFS compile broken > References : http://lkml.org/lkml/2007/7/19/218 > Last known good : ? > Submitter : Meelis Roos <[EMAIL PROTECTED]> > Caused-By : ? > Handled-By :

Re: [PATCH 1/1][RESEND] Driver for the Atmel on-chip SSC on AT32AP and AT91.

2007-07-19 Thread Hans-Christian Egtvedt
On Thu, 2007-07-19 at 10:29 +0200, Andrew Victor wrote: > hi Hans-Christian, > > > This driver is used in the ALSA sound driver for the AT73C213 external DAC > > on > > the ATSTK1000 development board for AVR32. This sound driver will be > > submitted > > soon. > > Seems to be more of an SCC u

Re: BUG: unable to handle kernel NULL pointer dereference - nfs v3

2007-07-19 Thread Neil Brown
On Thursday July 19, [EMAIL PROTECTED] wrote: > Ugh, not a good day for me today ... my earlier conclusion was right, > but not the reasoning behind it ... hopefully this time I'll do better :-) Looks good. Thanks for your helpful analysis. > > 0x34 bytes is the offset of ex_uuid in struct fh_

Re: [PATCH] fallout from kbuild changes

2007-07-19 Thread Sam Ravnborg
On Fri, Jul 20, 2007 at 02:01:16AM +0100, Al Viro wrote: > Change in 'kbuild: do section mismatch check on full vmlinux' > should've been replicated in arch/um/Makefile. Thanks Al. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: libata [ata_piix] still no resume from S3 ?

2007-07-19 Thread Tejun Heo
Rúben Fonseca wrote: > I wish I could disable this card reader. It is built in on the hardware, > and there are no drivers for Linux. There is no option on the BIOS to > disable the device. Is there any way (kernel parameters, magic program, > etc) to disable this device without opening my laptop t

Re: [PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-19 Thread Andrew Morton
On Thu, 19 Jul 2007 03:38:04 +0400 Vitaly Bordug <[EMAIL PROTECTED]> wrote: > > device_bind_driver() error code returning has been fixed. > release() function has been written, so that to free resources > in correct way; the release path is now clean. > > Before the rework, it used to cause

Re: [patch] fix some conversion overflows

2007-07-19 Thread David Chinner
On Fri, Jul 20, 2007 at 07:40:04AM +0200, Nick Piggin wrote: > Fix page index to offset conversion overflows in buffer layer, ecryptfs, > and ocfs2. > > It would be nice to convert the whole tree to page_offset, but for now > just fix the bugs. Yup, that's part of the clean-ups in Christoph Lamet

Re: [PATCH] Fix Dreamcast DMA

2007-07-19 Thread Mike Frysinger
On Thursday 19 July 2007, Adrian McMenamin wrote: > Signed-off by: Adrian McMenamin <[EMAIL PROTECTED]> > @@ -183,6 +183,7 @@ int dmac_search_free_channel(const char *dev_id) > return result; > > atomic_set(&channel->busy, 1); > + > return channel->

[PATCH] mm: Fix memory hotplug oops from ZONE_MOVABLE changes.

2007-07-19 Thread Paul Mundt
zone_movable_pfn is presently marked as __initdata and referenced from adjust_zone_range_for_zone_movable(), which in turn is referenced by zone_spanned_pages_in_node(). Both of these are __meminit annotated. When memory hotplug is enabled, this will oops on a hot-add, due to zone_movable_pfn havin

Re: [PATCH] virtual sched_clock() for s390

2007-07-19 Thread Jeremy Fitzhardinge
Paul Mackerras wrote: > Do you think this makes the PURR more useful for CFS, or less? To me > it looks like this would mean that CFS can make a more equitable > distribution of CPU time if, for example, you had 3 runnable tasks on > a 2-core x dual-threaded machine (4 virtual CPUs). > Sounds

Re: [PATCH] Move KVM, paravirt, lguest, VMI and Xen under arch-level Virtualization option

2007-07-19 Thread Rusty Russell
On Fri, 2007-07-20 at 08:24 +0300, Avi Kivity wrote: > Rusty Russell wrote: > > Any objections? > > > > Rusty. > > === > > Having KVM appear in the middle of "drivers" is kinda strange, and > > having it alone under a menu called "virtualization" doubly so. > > > > 1) Move the "Virtualization" menu

Please pull Open Firmware consolidation patches

2007-07-19 Thread Stephen Rothwell
Hi Linus, Please pull the Open Firmware device tree consolidation patches from the master branch of git://git.kernel.org/pub/scm/linux/kernel/git/sfr/ofcons.git master The intention here is that there should be no behavioural changes and minimal code changes (apart from movement of the code to

Re: [RFH] Partion table recovery

2007-07-19 Thread Dave Young
On 7/20/07, Dave Young <[EMAIL PROTECTED]> wrote: >On 7/20/07, Al Boldi <[EMAIL PROTECTED]> wrote: > As always, a good friend of mine managed to scratch my partion table by > cat'ing /dev/full into /dev/sda. I was able to push him out of the way, but /dev/null ? withdraw my wrong comment. > a

Re: [PATCH] [15/58] i386: Rewrite sched_clock (cmpxchg8b)

2007-07-19 Thread Mathieu Desnoyers
* Nick Piggin ([EMAIL PROTECTED]) wrote: > Mathieu Desnoyers wrote: > > >I tried it with and without the LOCK prefix on my Pentium 4. > > > >Locked cmpxchg8b : 90 cycles > >Non locked cmpxchg8b: 30 cycles > >sti: 166 cycles > >cli: 159 cycles > > > >So, hrm, even if we use the locked version, it i

Re: [RFH] Partion table recovery

2007-07-19 Thread Dave Young
On 7/20/07, Willy Tarreau <[EMAIL PROTECTED]> wrote: On Fri, Jul 20, 2007 at 08:13:03AM +0300, Al Boldi wrote: > As always, a good friend of mine managed to scratch my partion table by > cat'ing /dev/full into /dev/sda. I was able to push him out of the way, but > at least the first 100MB are gon

[patch] fix some conversion overflows

2007-07-19 Thread Nick Piggin
Fix page index to offset conversion overflows in buffer layer, ecryptfs, and ocfs2. It would be nice to convert the whole tree to page_offset, but for now just fix the bugs. Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> --- diff --git a/fs/buffer.c b/fs/buffer.c index 02ebb1f..0e5ec37 100644 --

Re: [RFH] Partion table recovery

2007-07-19 Thread Willy Tarreau
On Fri, Jul 20, 2007 at 08:13:03AM +0300, Al Boldi wrote: > As always, a good friend of mine managed to scratch my partion table by > cat'ing /dev/full into /dev/sda. I was able to push him out of the way, but > at least the first 100MB are gone. I can probably live without the first > partion

Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-19 Thread Avi Kivity
S.Çağlar Onur wrote: > Hi; > > 18 Tem 2007 Çar tarihinde, Avi Kivity şunları yazmıştı: > >>> http://cekirdek.pardus.org.tr/~caglar/kvm/netconsole_wo_apparmor is the >>> vanilla one's netconsole output, by the way without apparmor patchset >>> system not hard freezes. >>> >> This trace is

Re: [RFH] Partion table recovery

2007-07-19 Thread Jeffrey V. Merkey
Al Boldi wrote: As always, a good friend of mine managed to scratch my partion table by cat'ing /dev/full into /dev/sda. I was able to push him out of the way, but at least the first 100MB are gone. I can probably live without the first partion, but there are many partitions after that, whic

Re: [PATCH] kill DECLARE_MUTEX_LOCKED

2007-07-19 Thread Satyam Sharma
Hi Christoph, On 7/20/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote: DECLARE_MUTEX_LOCKED was used for semaphores used as completions and we've got rid of them. Thanks, I'd been meaning to do this for months :-) Had even audited the kernel for its usage ... just didn't make or send out a pat

Re: [patch] Change softlockup trigger limit using a kernel parameter

2007-07-19 Thread Ravikiran G Thirumalai
On Wed, Jul 18, 2007 at 11:09:07PM -0700, Andrew Morton wrote: >On Wed, 18 Jul 2007 22:41:21 -0700 Ravikiran G Thirumalai <[EMAIL PROTECTED]> >wrote: > >> On Wed, Jul 18, 2007 at 04:08:58PM -0700, Andrew Morton wrote: >> > On Mon, 16 Jul 2007 15:26:50 -0700 >> > Ravikiran G Thirumalai <[EMAIL PROT

Re: [RFH] Partion table recovery

2007-07-19 Thread James Lamanna
On 7/19/07, Al Boldi <[EMAIL PROTECTED]> wrote: As always, a good friend of mine managed to scratch my partion table by cat'ing /dev/full into /dev/sda. I was able to push him out of the way, but at least the first 100MB are gone. I can probably live without the first partion, but there are man

Re: [PATCH] Move KVM, paravirt, lguest, VMI and Xen under arch-level Virtualization option

2007-07-19 Thread Avi Kivity
Rusty Russell wrote: > Any objections? > > Rusty. > === > Having KVM appear in the middle of "drivers" is kinda strange, and > having it alone under a menu called "virtualization" doubly so. > > 1) Move the "Virtualization" menu into the arch-specific i386 and >x86-64 Kconfig. > Virtualizat

Re: [RFH] Partion table recovery

2007-07-19 Thread Dave Young
On 7/20/07, Al Boldi <[EMAIL PROTECTED]> wrote: As always, a good friend of mine managed to scratch my partion table by cat'ing /dev/full into /dev/sda. I was able to push him out of the way, but /dev/null ? at least the first 100MB are gone. I can probably live without the first partion, but

Re: Documentation for sysfs, hotplug, and firmware loading.

2007-07-19 Thread Rob Landley
On Wednesday 18 July 2007 7:33:19 pm Kay Sievers wrote: > On 7/18/07, Rob Landley <[EMAIL PROTECTED]> wrote: > > > > /sys/block/*/dev > > > > /sys/block/*/*/dev > > > > > > Note that this will change to /sys/class/block/ in the future. > > > > At OLS, Kay Sievers said in a future version they wer

[RFH] Partion table recovery

2007-07-19 Thread Al Boldi
As always, a good friend of mine managed to scratch my partion table by cat'ing /dev/full into /dev/sda. I was able to push him out of the way, but at least the first 100MB are gone. I can probably live without the first partion, but there are many partitions after that, which I hope should e

Re: [PATCH] [15/58] i386: Rewrite sched_clock (cmpxchg8b)

2007-07-19 Thread Nick Piggin
Mathieu Desnoyers wrote: I tried it with and without the LOCK prefix on my Pentium 4. Locked cmpxchg8b : 90 cycles Non locked cmpxchg8b: 30 cycles sti: 166 cycles cli: 159 cycles So, hrm, even if we use the locked version, it is still much faster than the sti/cli. I am thoughtful about the com

Re: [PATCH] procfs fixes for inotify/dnotify

2007-07-19 Thread Alexey Dobriyan
On Thu, Jul 19, 2007 at 03:03:55PM -0700, Andrew Morton wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8782 [fsnotify and /proc] > > --- linux-2.6.15/fs/proc/base.c > > +++ linux-2.6.15.4/fs/proc/base.c > > @@ -1945,6 +1945,7 @@ > > if(proc_dentry != NULL) { > > shrink_

Re: Hibernation considerations

2007-07-19 Thread Al Boldi
Rafael J. Wysocki wrote: > On Wednesday, 18 July 2007 16:29, Alan Stern wrote: > > > > Never mind. It seems clear that this approach will suffer the same > > drawback as the proposal for removing the freezer from the > > suspend-to-RAM pathway. Namely, device drivers will have to be changed > > t

Re: [PATCH] Memory leak in tpm_ascii_bios_measurements_open() fix.

2007-07-19 Thread Satyam Sharma
On 7/20/07, Yinghai Lu <[EMAIL PROTECTED]> wrote: out_free: kfree(log->bios_event_log); kfree(log); out: return err; could kill one extra goto. Such constructs disallow the success path from falling through to the same "return err;" (with err = 0 for success obviously) - To unsubscri

Re: [git pull] More input updates for post-2.6.22

2007-07-19 Thread Dmitry Torokhov
Hi Linus, On Wednesday 18 July 2007 01:27, Dmitry Torokhov wrote: > Linus, > > Please pull from: > > git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus > > or > > master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus > > to receive updates for in

Re: [PATCH] Move KVM, paravirt, lguest, VMI and Xen under arch-level Virtualization option

2007-07-19 Thread Alexey Eremenko
On 7/20/07, Rusty Russell <[EMAIL PROTECTED]> wrote: Any objections? Rusty. === Having KVM appear in the middle of "drivers" is kinda strange, and having it alone under a menu called "virtualization" doubly so. Hi Rusty ! Very good move, that I have thought about too... I believe that since

Re: [PATCH for review] [12/48] x86_64: use the global PIT lock

2007-07-19 Thread Dmitry Torokhov
On Thursday 19 July 2007 15:52, Andi Kleen wrote: > > > > > I was not talking about sysdevs. I was talking about platform devices > > that are already being created for pcspkr by arch code. Now I want > > arch code to provide a spinlock for pcspkr driver to use when > > accessing PIT. What it doe

Re: [NFS] [PATCH 013 of 20] knfsd: nfsd: factor out code from show_expflags

2007-07-19 Thread Satyam Sharma
On 7/20/07, Neil Brown <[EMAIL PROTECTED]> wrote: On Thursday July 19, [EMAIL PROTECTED] wrote: > On Thu, Jul 19, 2007 at 10:16:14AM +1000, Neil Brown wrote: > > On Wednesday July 18, [EMAIL PROTECTED] wrote: > > > OK, here I'm still confused--what should we be doing instead? > > > > Cast the var

[PATCH] Move KVM, paravirt, lguest, VMI and Xen under arch-level Virtualization option

2007-07-19 Thread Rusty Russell
Any objections? Rusty. === Having KVM appear in the middle of "drivers" is kinda strange, and having it alone under a menu called "virtualization" doubly so. 1) Move the "Virtualization" menu into the arch-specific i386 and x86-64 Kconfig. 2) Add a help message to the menu. 3) Move CONFIG_PARA

Re: [PATCH] Memory leak in tpm_ascii_bios_measurements_open() fix.

2007-07-19 Thread Yinghai Lu
On 7/19/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: On 7/20/07, Reiner Sailer <[EMAIL PROTECTED]> wrote: > > Jesper Juhl <[EMAIL PROTECTED]> wrote on 07/18/2007 07:11:54 PM: > > > > +++ b/drivers/char/tpm/tpm_bios.c > > @@ -427,7 +427,7 @@ static int > > tpm_ascii_bios_measurements_open(stru

Re: [PATCH] [15/58] i386: Rewrite sched_clock (cmpxchg8b)

2007-07-19 Thread Mathieu Desnoyers
* Mathieu Desnoyers ([EMAIL PROTECTED]) wrote: > I just want to rectify a detail: local_t uses type "long", which is 32 > bits on x86_32 and 64 bits on x86_64. > > Using a cmpxchg8b on i386 seems to require the LOCK prefix to be taken, > so it may degrate performances too much. Therefore, you ma

Re: [PATCH] Memory leak in tpm_ascii_bios_measurements_open() fix.

2007-07-19 Thread Satyam Sharma
On 7/20/07, Reiner Sailer <[EMAIL PROTECTED]> wrote: Jesper Juhl <[EMAIL PROTECTED]> wrote on 07/18/2007 07:11:54 PM: > > +++ b/drivers/char/tpm/tpm_bios.c > @@ -427,7 +427,7 @@ static int > tpm_ascii_bios_measurements_open(struct inode *inode, >return -ENOMEM; > > if ((err =

[PATCH] fs: use kmem_cache_zalloc instead

2007-07-19 Thread Denis Cheng
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- fs/file_table.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/fs/file_table.c b/fs/file_table.c index d17fd69..37453ff 100644 --- a/fs/file_table.c +++ b/fs/file_table.c @@ -102,12 +102,11 @@ struct file *get_empty_fil

Re: pata_platform: Fix NULL pointer dereference

2007-07-19 Thread Paul Mundt
On Fri, Jul 20, 2007 at 12:50:58PM +0900, Magnus Damm wrote: > pata_platform: Fix NULL pointer dereference > > pata_platform currently dereferences a NULL pointer in pata_platform_probe() > if pdev->dev.platform_data is set to NULL. This breakage was most likely > introduced by commit 5f45bc50976e

Re: Kernel Error / Crash

2007-07-19 Thread Satyam Sharma
Hi Werner, On 7/20/07, werner <[EMAIL PROTECTED]> wrote: To: linux-kernel@vger.kernel.org copied from the screen: ... proc on /proc type proc (rw) sysfs on /sys type sysfs (rw) Starting udevd: /sbin/udevd -- daemon [cut here]--- Kernel BUG at mm/slub.c:2401! That

pata_platform: Fix NULL pointer dereference

2007-07-19 Thread Magnus Damm
pata_platform: Fix NULL pointer dereference pata_platform currently dereferences a NULL pointer in pata_platform_probe() if pdev->dev.platform_data is set to NULL. This breakage was most likely introduced by commit 5f45bc50976ee1f408f7171af155aec646655a37. Signed-off-by: Magnus Damm <[EMAIL PROTE

Re: v2.6.22.1-rt3

2007-07-19 Thread Daniel Walker
On Thu, 2007-07-19 at 20:37 -0700, Daniel Walker wrote: > I reworked the broken out series for 2.6.22.1-rt5 (note not -rt3) so Woops , I mean , 2.6.22.1-rt4 here.. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordo

Re: [PATCH] [15/58] i386: Rewrite sched_clock

2007-07-19 Thread Mathieu Desnoyers
* Mathieu Desnoyers ([EMAIL PROTECTED]) wrote: > > > +/* > > > + * Scheduler clock - returns current time in nanosec units. > > > + * All data is local to the CPU. > > > + * The values are approximately[1] monotonic local to a CPU, but not > > > + * between CPUs. There might be also an occa

Re: asm-offsets

2007-07-19 Thread Oleg Verych
On Fri, Jul 20, 2007 at 01:23:40PM +1000, Rusty Russell wrote: > I appreciate your frustration! It isn't, just a conversation, everyone can skip, you know. > Unfortunately I'm not fluent enough in kbuild to be able to give > meaningful commentary, Modest Rusty :) > so pinging Sam is my wa

Re: v2.6.22.1-rt3

2007-07-19 Thread Daniel Walker
I reworked the broken out series for 2.6.22.1-rt5 (note not -rt3) so that it's a little more bisectable. I found that many of the patches would compile but wouldn't boot. Combined patch, ftp://source.mvista.com/pub/dwalker/rt/patch-2.6.22.1-rt4-dw1 The broken out series is here, ftp://source.m

[GIT PATCH] more USB patches for 2.6.22

2007-07-19 Thread Greg KH
Here are some more USB patches and fixes against your 2.6.22 git tree. They add a new usb gadget driver, more urb->status cleanups, a new sysfs attribute to get the raw config of the usb device, and some bugfixes and documentation updates. Please pull from: master.kernel.org:/pub/scm/linu

Re: [PATCH] AFS: Fix file locking

2007-07-19 Thread Andrew Morton
On Wed, 18 Jul 2007 15:56:53 +1000 Nick Piggin <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > On Tue, 17 Jul 2007 13:47:32 +0100 > > David Howells <[EMAIL PROTECTED]> wrote: > > > > > >>+ if (type == AFS_LOCK_READ && > >>+ vnode->flags & (1 << AFS_VNODE_READLOCKED)) { > > > > >

[PATCH 8/8] m68k: exclude more unbuildable drivers

2007-07-19 Thread Al Viro
anything that wants working dma-mapping won't work parport_pc won't work on m68k unless we have ISA Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- arch/m68k/Kconfig |3 +++ drivers/parport/Kconfig |2 +- 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/arch/m68k/Kconf

[PATCH] parse_table() earlier check.

2007-07-19 Thread Tetsuo Handa
/* The part parse_table() does */ for ( ; table->ctl_name || table->procname; table++) { if (!table->ctl_name) continue; if (n == table->ctl_name) { return do_sysctl_strategy(); } } return -ENOTDIR; /* is equivalent to */ for ( ; table->ctl

[PATCH 6/8] m68k: remove empty ->setup is several consoles

2007-07-19 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/char/serial167.c |6 -- drivers/char/vme_scc.c |8 2 files changed, 0 insertions(+), 14 deletions(-) diff --git a/drivers/char/serial167.c b/drivers/char/serial167.c index c585b47..f1497ce 100644 --- a/drivers/char/ser

[PATCH 7/8] mac89x0: missing __init

2007-07-19 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/net/mac89x0.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/mac89x0.c b/drivers/net/mac89x0.c index 26a3b45..62c1c62 100644 --- a/drivers/net/mac89x0.c +++ b/drivers/net/mac89x0.c @@ -608,7 +608,7 @@ mo

[PATCH 4/8] m68k: missing exports

2007-07-19 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- arch/m68k/atari/atakeyb.c |9 - arch/m68k/kernel/setup.c |1 + arch/m68k/mac/config.c |1 + arch/m68k/mm/sun3kmap.c|2 ++ drivers/ide/legacy/falconide.c |2 ++ drivers/scsi/NCR53C9x.c|

[PATCH 5/8] m68k: missing __init

2007-07-19 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- arch/m68k/apollo/config.c |4 ++-- arch/m68k/apollo/dn_ints.c |2 +- arch/m68k/bvme6000/config.c |2 +- arch/m68k/kernel/time.c |2 +- arch/m68k/mac/config.c |6 +++--- arch/m68k/mac/macints.c |4 +++- arch/m68

[PATCH 3/8] m68k: use .text.head

2007-07-19 Thread Al Viro
i.e. tell modpost that entry point code (that has to be outside of .init.text for external reasons) is OK to refer to .init.* Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- arch/m68k/kernel/head.S |2 +- arch/m68k/kernel/sun3-head.S |2 +- arch/m68k/kernel/vmlinux-std.lds

Re: [PATCH] Memory leak in tpm_ascii_bios_measurements_open() fix.

2007-07-19 Thread Reiner Sailer
Jesper, thank you very much for finding this error and for posting a patch proposal. Since Kylene is not online, I am responding. Please see my inlines and an alternative patch proposal below. Jesper Juhl <[EMAIL PROTECTED]> wrote on 07/18/2007 07:11:54 PM: > Ehlo, > > Coverity found a memor

[PATCH 2/8] m68k iomem (based on Geert's tree + memcpy_... stuff)

2007-07-19 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- arch/m68k/Kconfig |4 ++ include/asm-m68k/io.h | 75 +--- include/asm-m68k/raw_io.h |8 +++- 3 files changed, 73 insertions(+), 14 deletions(-) diff --git a/arch/m68k/Kconfig b/arch/m68k/

[PATCH 1/8] m68k: teach modpost about .m68_fixup

2007-07-19 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- scripts/mod/modpost.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 04579a5..5ab7914 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -1076,6 +1076,7 @@ s

Where did KVM go in 2.6.22-git9?

2007-07-19 Thread Bill Davidsen
I just built a 2.6.22-git9 kernel, and when I run oldconfig it (a) sets the processor type to pentium-pro, and (b) the KVM stuff simply isn't in the config. Before I spend a lot of time on this, was it disabled temporarily for some reason, or is it a known bug, or ??? Processor is a Core2 E660

Kernel Error / Crash

2007-07-19 Thread werner
To: linux-kernel@vger.kernel.org copied from the screen: ... proc on /proc type proc (rw) sysfs on /sys type sysfs (rw) Starting udevd: /sbin/udevd -- daemon [cut here]--- Kernel BUG at mm/slub.c:2401! Invalid opcode: [#1] SMP Modules linked in: CPU: 0 EIP: 0060:

Re: lguest, Re: -mm merge plans for 2.6.23

2007-07-19 Thread Rusty Russell
On Thu, 2007-07-19 at 19:27 +0200, Christoph Hellwig wrote: > The version that just got into mainline still has the __put_task_struct > export despite not needing it anymore. Care to fix this up? No, it got patched in then immediately patched out again. Andrew mis-mixed my patches, but there hav

Re: asm-offsets

2007-07-19 Thread Rusty Russell
On Fri, 2007-07-20 at 05:22 +0200, Oleg Verych wrote: > On Fri, Jul 20, 2007 at 11:34:13AM +1000, Rusty Russell wrote: > > On Thu, 2007-07-19 at 23:46 +0200, Oleg Verych wrote: > > > > This is the structure offsets required by lg.ko's switcher.S. > > > > > > > > Unfortunately we don't have infrastr

Re: [PATCH 1/2] net/core: merge the content of dev_mcast.c into dev.c

2007-07-19 Thread rae l
On 7/20/07, David Miller <[EMAIL PROTECTED]> wrote: Please don't quote a big huge patch just to say one sentence that doesn't apply to any particular specific part of a patch. That's wastes bandwidth, annoys people you might actually want a response from, and is bad netiquette in general. Thank

[PATCH] dpt_i2o depends on virt_to_bus

2007-07-19 Thread Stephen Rothwell
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> --- drivers/scsi/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Cheers, Stephen Rothwell[EMAIL PROTECTED] diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 3727231..a947257 100644 --- a

[PATCH] TOSHIBA_FIR depends on virt_to_bus

2007-07-19 Thread Stephen Rothwell
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> --- drivers/net/irda/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Cheers, Stephen Rothwell[EMAIL PROTECTED] diff --git a/drivers/net/irda/Kconfig b/drivers/net/irda/Kconfig index 829da9a..23b0c33

[PATCH] stradis and zoran depend on virt_to_bus

2007-07-19 Thread Stephen Rothwell
I assume that is why they were marked as !PPC64. Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> --- drivers/media/video/Kconfig |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- Cheers, Stephen Rothwell[EMAIL PROTECTED] diff --git a/drivers/media/video/K

Re: [patch] Change softlockup trigger limit using a kernel parameter

2007-07-19 Thread Ravikiran G Thirumalai
On Thu, Jul 19, 2007 at 11:51:14AM -0700, Jeremy Fitzhardinge wrote: >Ingo Molnar wrote: >> just in case someone sees false positives and wants to turn it off. > >Why not make 0=off? A patch to disable softlockup during boot already went in. http://git.kernel.org/?p=linux/kernel/git/torvalds/linux

Re: [PATCH] [15/58] i386: Rewrite sched_clock

2007-07-19 Thread Mathieu Desnoyers
* Daniel Walker ([EMAIL PROTECTED]) wrote: > On Thu, 2007-07-19 at 11:54 +0200, Andi Kleen wrote: > > Move it into an own file for easy sharing. > > Do everything per CPU. This avoids problems with TSCs that > > tick at different frequencies per CPU. > > Resync properly on cpufreq changes. CPU freq

asm-offsets

2007-07-19 Thread Oleg Verych
On Fri, Jul 20, 2007 at 11:34:13AM +1000, Rusty Russell wrote: > On Thu, 2007-07-19 at 23:46 +0200, Oleg Verych wrote: > > > This is the structure offsets required by lg.ko's switcher.S. > > > > > > Unfortunately we don't have infrastructure for private asm-offsets > > > creation. > > > > I did as

Re: [PATCH 1/2] net/core: merge the content of dev_mcast.c into dev.c

2007-07-19 Thread David Miller
From: "rae l" <[EMAIL PROTECTED]> Date: Fri, 20 Jul 2007 09:51:05 +0800 > Is there any more comments on this? Please don't quote a big huge patch just to say one sentence that doesn't apply to any particular specific part of a patch. That's wastes bandwidth, annoys people you might actually want

Re: [PATCH] async_tx: fix kmap_atomic usage in async_memcpy

2007-07-19 Thread Dan Williams
On 7/19/07, Andrew Morton <[EMAIL PROTECTED]> wrote: Neato. You (or at least, Shannon) run a git tree. I always get confused when git-tree-owners send me patches, because I expect them to put the patches into their git trees. So if you, a git-tree-owner, wish me to merge-test-and-forward a pat

[AGPGART] intel_agp: fix ids for 945GME, 965GME

2007-07-19 Thread Zhenyu Wang
Subject: [PATCH] [AGPGART] intel_agp: fix ids for 945GME and 965GME These chipsets actually have new host bridge ids. This should fix the gart init problem on them. Please apply, thanks. Signed-off-by: Wang Zhenyu <[EMAIL PROTECTED]> --- drivers/char/agp/intel-agp.c | 10 ++ 1 files c

[RFC] what should 'uptime' be on suspend?

2007-07-19 Thread Bill Davidsen
I just found a machine which will resume after suspend to memory, using the mainline kernel (no suspend2 patch). On resume I was looking at the uptime output, and it was about six minutes, FAR longer than the time since resume. So the topic for discussion is, should the uptime be - time sine

Re: [patch] CFS scheduler, -v19

2007-07-19 Thread Bill Davidsen
Ingo Molnar wrote: * Bill Davidsen <[EMAIL PROTECTED]> wrote: Does the patch below help? Spectacularly no! With this patch the "glitch1" script with multiple scrolling windows has all xterms and glxgears stop totally dead for ~200ms once per second. I didn't properly test anything else after

[PATCH 2/2] Debug handling of early spurious interrupts

2007-07-19 Thread Fernando Luis Vázquez Cao
With the advent of kdump it is possible that device drivers receive interrupts generated in the context of a previous kernel. Ideally quiescing the underlying devices should suffice but not all drivers do this, either because it is not possible or because they did not contemplate this case. Thus dr

Re: [NFS] [PATCH 013 of 20] knfsd: nfsd: factor out code from show_expflags

2007-07-19 Thread Neil Brown
On Thursday July 19, [EMAIL PROTECTED] wrote: > On Thu, Jul 19, 2007 at 10:16:14AM +1000, Neil Brown wrote: > > On Wednesday July 18, [EMAIL PROTECTED] wrote: > > > OK, here I'm still confused--what should we be doing instead? > > > > Cast the variable to a type that printf knows about. > >

Re: [PATCH] AFS: Fix file locking

2007-07-19 Thread Nick Piggin
Andrew Morton wrote: On Tue, 17 Jul 2007 13:47:32 +0100 David Howells <[EMAIL PROTECTED]> wrote: + if (type == AFS_LOCK_READ && + vnode->flags & (1 << AFS_VNODE_READLOCKED)) { Here we use vnode->flags & (1 << foo) + set_bit(AFS_VNODE_LOCKING, &vnode

[PATCH 1/2] Remove Kconfig setting CONFIG_DEBUG_SHIRQ

2007-07-19 Thread Fernando Luis Vázquez Cao
request_irq() and setup_irq() are not fast paths and free_irq() much less so. In fact, by enabling this feature unconditionally we would have _everyone_ (unknowingly) testing devices drivers, which hopefully will result in more bug-reports and, in turn, better drivers. Signed-off-by: Fernando Luis

Re: [PATCH RFC] Debug handling of early spurious interrupts

2007-07-19 Thread Fernando Luis Vázquez Cao
On Wed, 2007-07-18 at 15:46 -0700, Andrew Morton wrote: > On Tue, 17 Jul 2007 19:09:57 +0900 > Fernando Luis V__zquez Cao <[EMAIL PROTECTED]> wrote: > > > With the advent of kdump it is possible that device drivers receive > > interrupts generated in the context of a previous kernel. Ideally > > q

Re: [PATCH 1/2] net/core: merge the content of dev_mcast.c into dev.c

2007-07-19 Thread rae l
On 7/18/07, Denis Cheng <[EMAIL PROTECTED]> wrote: - removed three function declarations from header file to mark them static, - reduced one file Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- this one is just merging by concatenating, and I'll try to adjust some function definitions' order

Re: [BUGFIX]{PATCH] flush icache on ia64 take2

2007-07-19 Thread KAMEZAWA Hiroyuki
On Thu, 19 Jul 2007 17:18:59 +0200 Zoltan Menyhart <[EMAIL PROTECTED]> wrote: > KAMEZAWA Hiroyuki wrote: > > > Hmm...but the current code flushes the page. just do it in "lazy" way. > > much difference ? > > I agree the current code flushes the I-cache for all kinds of file > systems (for PTEs w

Some 'Section mismatch' warnings on current git head with allmodconfig

2007-07-19 Thread Gabriel C
Hi, I got this warnings with allmodconfig on 64fb98fc40738ae1a98bcea9ca3145b89fb71524 ... MODPOST 2126 modules CC arch/i386/boot/tty.o CC arch/i386/boot/video.o WARNING: vmlinux(.text+0xc0101183): Section mismatch: reference to .init.text:start_kernel (between 'is386' and 'check

Re: [PATCH 2/2] nbd: change a parameter's type to remove a memcpy call

2007-07-19 Thread rae l
On 7/20/07, Paul Clements <[EMAIL PROTECTED]> wrote: Denis Cheng wrote: > this memcpy looks so strange, in fact it's merely a pointer dereference, > so I change the parameter's type to refer it more directly, > this could make the memcpy not needed anymore. > > in the function nbd_read_stat where

Re: [GIT PULL] mm: Remove slab destructors from kmem_cache_create().

2007-07-19 Thread Linus Torvalds
On Fri, 20 Jul 2007, Paul Mundt wrote: > > Perhaps this is something that should go in later, as it does > cause a bit of churn across the tree. However, there shouldn't be > anything here that causes trouble for git merges, as it's all pretty > straightforward removal. I've placed it in a git t

Re: i386: pata_cs5520 does not work

2007-07-19 Thread Tejun Heo
Alan Cox wrote: > O> > rc = devm_request_irq(&pdev->dev, irq[ap->port_no], >>> ata_interrupt, 0, DRV_NAME, host); >> devm_request_irq() is called twice from loop. >> In 1st time, ap->port_no is 0. devm_request_irq() is success. >> 2nd time, ap->port_no is 0 too. devm_request_irq() failed. > >

Re: [PATCH] Fix a use after free bug in kernel->userspace relay file support

2007-07-19 Thread Mathieu Desnoyers
* Andrew Morton ([EMAIL PROTECTED]) wrote: > On Thu, 19 Jul 2007 21:09:09 -0400 > Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > > > Coverity spotted what looks like a real possible case of using a > > variable after it has been freed. > > The problem is in kernel/relay.c::relay_open_buf() > > >

Re: [PATCH][resend] Remove spec doc links in hpet header files

2007-07-19 Thread Dave Young
On 7/20/07, Andrew Morton <[EMAIL PROTECTED]> wrote: On Fri, 20 Jul 2007 08:45:10 + Dave Young <[EMAIL PROTECTED]> wrote: > Hi, > The links are broken, and already exist in Documentation/hpet.txt, so > remove them for header files. > > Signed-off-by: Dave Young <[EMAIL PROTECTED]> > Acked-by:

Re: [PATCH][resend] Remove spec doc links in hpet header files

2007-07-19 Thread Andrew Morton
On Fri, 20 Jul 2007 08:45:10 + Dave Young <[EMAIL PROTECTED]> wrote: > Hi, > The links are broken, and already exist in Documentation/hpet.txt, so > remove them for header files. > > Signed-off-by: Dave Young <[EMAIL PROTECTED]> > Acked-by: Randy Dunlap <[EMAIL PROTECTED]> > > --- > include

Re: - lguest-the-asm-offsets.patch removed from -mm tree

2007-07-19 Thread Rusty Russell
On Thu, 2007-07-19 at 23:46 +0200, Oleg Verych wrote: > > This is the structure offsets required by lg.ko's switcher.S. > > > > Unfortunately we don't have infrastructure for private asm-offsets > > creation. > > I did asm-offsets build rewrite RFC caled asm-values more than four week > ago:

Re: [PATCH] async_tx: fix kmap_atomic usage in async_memcpy

2007-07-19 Thread Andrew Morton
On Thu, 19 Jul 2007 18:12:52 -0700 Dan Williams <[EMAIL PROTECTED]> wrote: > Andrew Morton: > [async_memcpy] is very wrong if both ASYNC_TX_KMAP_DST and > ASYNC_TX_KMAP_SRC can ever be set. We'll end up using the same kmap > slot for both src add dest and we get either corrupted

Re: [PATCH] Fix a use after free bug in kernel->userspace relay file support

2007-07-19 Thread Andrew Morton
On Thu, 19 Jul 2007 21:09:09 -0400 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > Coverity spotted what looks like a real possible case of using a > variable after it has been freed. > The problem is in kernel/relay.c::relay_open_buf() > > If the code hits "goto free_buf;" it ends up in this cod

[GIT PULL] mm: Remove slab destructors from kmem_cache_create().

2007-07-19 Thread Paul Mundt
Slab destructors were no longer supported after Christoph's c59def9f222d44bb7e2f0a559f2906191a0862d7 change. They've been BUGs for both slab and slub, and slob never supported them either. This rips out support for the dtor pointer from kmem_cache_create() completely and fixes up every single call

Re: new text patching for review

2007-07-19 Thread Zachary Amsden
Mathieu Desnoyers wrote: Yes, kprobes is case 1: atomic update. And we don't even have to bother about Intel's erratum. This one is ok. That's mainly the alternatives/paravirt code I worry about. Paravirt and alternatives should all be ok because they are done before SMP bringup and with NM

Re: [GIT PULL] XFS update

2007-07-19 Thread Linus Torvalds
On Fri, 20 Jul 2007, Timothy Shimmin wrote: > > The window between pulling in and applying changes was obviously > large enough for Nick's changes to get in. Don't worry. Basically, merging is my job, and I happily do it. If I hit something that makes me nervous enough, I'll just push back an

[PATCH] async_tx: fix kmap_atomic usage in async_memcpy

2007-07-19 Thread Dan Williams
Andrew Morton: [async_memcpy] is very wrong if both ASYNC_TX_KMAP_DST and ASYNC_TX_KMAP_SRC can ever be set. We'll end up using the same kmap slot for both src add dest and we get either corrupted data or a BUG. Evgeniy Polyakov: Btw, shouldn't it always be kmap_at

[PATCH] Fix a use after free bug in kernel->userspace relay file support

2007-07-19 Thread Mathieu Desnoyers
Coverity spotted what looks like a real possible case of using a variable after it has been freed. The problem is in kernel/relay.c::relay_open_buf() If the code hits "goto free_buf;" it ends up in this code : free_buf: relay_destroy_buf(buf); <--- calls kfree() on 'buf'. free_name:

Re: [PATCH] virtual sched_clock() for s390

2007-07-19 Thread Paul Mackerras
Ingo Molnar writes: > CFS does measure time elapsed across task-sleep periods (and does > something similar to what the old scheduler's 'sleep average' > interactivity mechanism did), but that mechanism measures "time spent > running during sleep", not "time spent idling". PowerPC's sched_cloc

Re: [PATCH] Fix a use after free bug in kernel->userspace relay file support

2007-07-19 Thread Jesper Juhl
On 19/07/07, David J. Wilder <[EMAIL PROTECTED]> wrote: ACK Thanks for catching this. Your patch looks fine. I tested for regression, no problems. I also tested the error path and had the expected results. Ok, thank you for testing. I see that Mathieu Desnoyers also ack'ed the patch (thank you

  1   2   3   4   5   6   7   8   >