Re: [git patches] two warning fixes

2007-07-20 Thread Tim Tassonis
Linus Torvalds wrote: I think "must_check" is an abomination. It makes the callee dictate what the caller has to do, but dammit, if the callee really "knows" its errors are that serious, it should damn well handle them itself. The whole "sysfs_create_file()" thing is an example of that. If

[PATCH] splice: fix bad unlock_page() in error case

2007-07-20 Thread Jens Axboe
Hi, If add_to_page_cache_lru() fails, the page will not be locked. But splice jumps to an error path that does a page release and unlock, causing a BUG() in unlock_page(). Fix this by adding one more label that just releases the page. This bug was actually triggered on EL5 by gurudas pai <[EMAIL

Re: [PATCH] IP_VS should depend on EXPERIMENTAL ?

2007-07-20 Thread Robert P. J. Day
On Fri, 20 Jul 2007, Gabriel C wrote: > Robert P. J. Day wrote: > > this has *nothing* to do with the aforementioned maturity levels. > > i understand entirely the inconsistency above. what i'm > > suggesting is that it might very well be more appropriate to *drop > > the dependency* rather

Re: mm/Kconfig MEMORY_HOTPLUG typo ?

2007-07-20 Thread Gabriel C
Paul Mundt wrote: > On Fri, Jul 20, 2007 at 02:23:48PM +0200, Gabriel C wrote: >> I'm a bit confused about the following from mm/Kconfig: >> >> .. >> >> config MEMORY_HOTPLUG >> bool "Allow for memory hot-add" >> depends on SPARSEMEM || X86_64_ACPI_NUMA >> depends on

Re: [PATCH] mm: Fix memory hotplug oops from ZONE_MOVABLE changes.

2007-07-20 Thread Mel Gorman
On (20/07/07 20:42), Paul Mundt didst pronounce: > On Fri, Jul 20, 2007 at 12:20:25PM +0100, Mel Gorman wrote: > > On (20/07/07 15:03), Paul Mundt didst pronounce: > > > zone_movable_pfn is presently marked as __initdata and referenced > > > from adjust_zone_range_for_zone_movable(), which in turn

Re: [PATCH for review] [12/48] x86_64: use the global PIT lock

2007-07-20 Thread Dmitry Torokhov
On 7/20/07, Andi Kleen <[EMAIL PROTECTED]> wrote: > +static DEFINE_SPINLOCK(i8253_lock); > + > static __init int add_pcspkr(void) > { > struct platform_device *pd; > @@ -1501,9 +1503,14 @@ static __init int add_pcspkr(void) > if (!pd) > return -ENOMEM; > > +pd->dev.platform_data = _lock; That

Re: [PATCH/RFC] msleep() with hrtimers

2007-07-20 Thread Roman Zippel
Hi, On Mon, 16 Jul 2007, Jonathan Corbet wrote: > > That's a bit my problem - we have to consider other setups as well. > > Is it worth converting all msleep users behind their back or should we > > just a provide a separate function for those who care? > > Any additional overhead is clearly

Re: mm/Kconfig MEMORY_HOTPLUG typo ?

2007-07-20 Thread Paul Mundt
On Fri, Jul 20, 2007 at 02:23:48PM +0200, Gabriel C wrote: > I'm a bit confused about the following from mm/Kconfig: > > .. > > config MEMORY_HOTPLUG > bool "Allow for memory hot-add" > depends on SPARSEMEM || X86_64_ACPI_NUMA > depends on HOTPLUG && !SOFTWARE_SUSPEND &&

Re: [PATCH] IP_VS should depend on EXPERIMENTAL ?

2007-07-20 Thread Gabriel C
Robert P. J. Day wrote: > On Fri, 20 Jul 2007, Gabriel C wrote: > >> Robert P. J. Day wrote: >>> On Fri, 20 Jul 2007, Gabriel C wrote: >>> Hi, IP_VS has : .. tristate "IP virtual server support (EXPERIMENTAL)" .. but it does not depend on

Re: mm/Kconfig MEMORY_HOTPLUG typo ?

2007-07-20 Thread Adrian Bunk
On Fri, Jul 20, 2007 at 02:23:48PM +0200, Gabriel C wrote: > Hi, > > I'm a bit confused about the following from mm/Kconfig: > > .. > > config MEMORY_HOTPLUG > bool "Allow for memory hot-add" > depends on SPARSEMEM || X86_64_ACPI_NUMA > depends on HOTPLUG &&

Re: [RFH] Partition table recovery

2007-07-20 Thread Rene Herman
On 07/20/2007 02:22 PM, Al Boldi wrote: Oh, gpart is great, but if we had a backup copy of the partition table on every partition location on disk, then this backup copy could easily be reused to reconstruct the original partition table without further searching. As long as you don't reboot

mm/Kconfig MEMORY_HOTPLUG typo ?

2007-07-20 Thread Gabriel C
Hi, I'm a bit confused about the following from mm/Kconfig: .. config MEMORY_HOTPLUG bool "Allow for memory hot-add" depends on SPARSEMEM || X86_64_ACPI_NUMA depends on HOTPLUG && !SOFTWARE_SUSPEND && ARCH_ENABLE_MEMORY_HOTPLUG depends on (IA64 || X86 || PPC64 ||

Re: [PATCH] IP_VS should depend on EXPERIMENTAL ?

2007-07-20 Thread Robert P. J. Day
On Fri, 20 Jul 2007, Gabriel C wrote: > Robert P. J. Day wrote: > > On Fri, 20 Jul 2007, Gabriel C wrote: > > > >> Hi, > >> > >> IP_VS has : > >> > >> .. > >> > >> tristate "IP virtual server support (EXPERIMENTAL)" > >> > >> .. > >> > >> but it does not depend on EXPERIMENTAL. > >> > >> > >>

[PATCH] sb1250-duart: __maybe_unused, etc. fixes

2007-07-20 Thread Maciej W. Rozycki
This is a set of small fixes addressing points raised with the original driver submission. In particular, __maybe_unused is used rather than a local hack and sbd_ops is made const. Additionally I have made two local string variables automatic as rodata space was wasted for pointers

Re: [RFH] Partition table recovery

2007-07-20 Thread Al Boldi
Jan-Benedict Glaw wrote: > On Fri, 2007-07-20 14:29:34 +0300, Al Boldi <[EMAIL PROTECTED]> wrote: > > But, I want something much more automated. And the partition table > > backup per partition entry isn't really a bad idea. > > That's called `gpart'. Oh, gpart is great, but if we had a backup

Re: [PATCH] IP_VS should depend on EXPERIMENTAL ?

2007-07-20 Thread Gabriel C
Robert P. J. Day wrote: > On Fri, 20 Jul 2007, Gabriel C wrote: > >> Hi, >> >> IP_VS has : >> >> .. >> >> tristate "IP virtual server support (EXPERIMENTAL)" >> >> .. >> >> but it does not depend on EXPERIMENTAL. >> >> >> Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTED]> >> >> --- >> >>

[PATCH] defxx: Use __maybe_unused rather than a local hack

2007-07-20 Thread Maciej W. Rozycki
This is a change to remove a local hack in favour to __maybe_unused that has been recently added. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- Hi, It should be obvious. The code builds, therefore it works. Please apply, Maciej patch-mips-2.6.22-20070710-defxx-unused-0 diff

[PATCH 3/3] lguest: override sched_clock

2007-07-20 Thread Rusty Russell
Guests currently use the default scheduler clock: this means they always use jiffies even if TSC is actually available. It doesn't make any noticeable difference here, but it's a better thing to do. Also remove commented-out asm/sched-clock.h from -mm tree. Signed-off-by: Rusty Russell <[EMAIL

Re: [PATCH] IP_VS should depend on EXPERIMENTAL ?

2007-07-20 Thread Robert P. J. Day
as a short followup to my previous post, at the *very least*, a cleanup that could be done now is to find all entries which have an actual dependency on "EXPERIMENTAL" but don't advertise themselves as such: ... config MA600_DONGLE tristate "Mobile Action MA600 dongle" depends

[PATCH 2/3] lguest: trivial: We now have asm/processor-flags.h, so use it.

2007-07-20 Thread Rusty Russell
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r f41cd1b8d7ef drivers/lguest/lguest_asm.S --- a/drivers/lguest/lguest_asm.S Fri Jul 20 13:46:40 2007 +1000 +++ b/drivers/lguest/lguest_asm.S Fri Jul 20 14:17:04 2007 +1000 @@ -2,9 +2,7 @@ #include #include #include - -/*

Re: [PATCH 1/6] compacting file_ra_state

2007-07-20 Thread Fengguang Wu
On Fri, Jul 20, 2007 at 01:34:42PM +0200, Andi Kleen wrote: > Fengguang Wu <[EMAIL PROTECTED]> writes: > > > Use 'unsigned int' instead of 'unsigned long' for the readahead > > indexes/sizes. > > > > This helps reduce memory consumption on 64bit CPU when > > a lot of files are opened. > > > >

[PATCH 1/3] lguest: fix sense if IF flag on interrupt injection

2007-07-20 Thread Rusty Russell
The sense of the IF bit is backwards in the host interrupt handling. This means we always save "IF=1" on the stack when injecting an interrupt. It turns out this is almost always correct (unless the guest is taking a page fault in an interrupt due to an unpopulated vmalloc mapping), so went

Re: Kernel Error / Crash

2007-07-20 Thread Satyam Sharma
On 7/20/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: Hi Werner, On 7/20/07, werner <[EMAIL PROTECTED]> wrote: > To: linux-kernel@vger.kernel.org > > > copied from the screen: > > ... > proc on /proc type proc (rw) > sysfs on /sys type sysfs (rw) > Starting udevd: /sbin/udevd -- daemon >

Re: workqueue is not working?

2007-07-20 Thread Misbah khan
I didnt got very clearly what you actually did. But i guess you did faced some problem to work with work queue ( Bottom half of the handler ) I suggest you with an example code so that you could try with it and hope your doubt would get cleared. /* work queue register and initialize */ static

Re: [PATCH] Remove -static from Documentation/lguest/Makefile

2007-07-20 Thread Rusty Russell
On Thu, 2007-07-19 at 23:13 +0300, S.Çağlar Onur wrote: > Hi; > > Remove -static from Documentation/lguest/Makefile, most distros only provides > shared library form of zlib in their default installation. > And shared linking also provides litte tiny security for hypotetical security >

Re: [PATCH] IP_VS should depend on EXPERIMENTAL ?

2007-07-20 Thread Robert P. J. Day
On Fri, 20 Jul 2007, Gabriel C wrote: > Hi, > > IP_VS has : > > .. > > tristate "IP virtual server support (EXPERIMENTAL)" > > .. > > but it does not depend on EXPERIMENTAL. > > > Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTED]> > > --- > > net/ipv4/ipvs/Kconfig |2 +- > 1 files

Re: kobject link failure

2007-07-20 Thread Cornelia Huck
On Fri, 20 Jul 2007 11:32:21 +0200, Cornelia Huck <[EMAIL PROTECTED]> wrote: > Hm, this would be an interface change (the uevent attribute used to > exist even for !CONFIG_HOTPLUG, it just triggered nothing). How about > moving kobject_actions[] out of the #ifdef (maybe next to > kobject_action)?

Re: [RFH] Partition table recovery

2007-07-20 Thread Anton Altaparmakov
On 20 Jul 2007, at 12:29, Al Boldi wrote: Anton Altaparmakov wrote: parted and its derivatives are pile of crap... They cause corruption to totally healthy systems at the best of times. Don't go near them. Use TestDisk (http://www.cgsecurity.org/wiki/TestDisk) and be happy. (-: This one

Re: Correct comment in libata-sff.c

2007-07-20 Thread Jeff Garzik
Dave Jones wrote: The filename in the file header is incorrect. Signed-off-by: Dave Jones <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Chris Snook
Satyam Sharma wrote: On 7/20/07, Chris Snook <[EMAIL PROTECTED]> wrote: Satyam Sharma wrote: > On 7/20/07, Chris Snook <[EMAIL PROTECTED]> wrote: >> Satyam Sharma wrote: >> > [ Just cleaning up my inbox, and stumbled across this thread ... ] >> > >> > >> > On 5/31/07, [EMAIL PROTECTED] <[EMAIL

Re: pata_platform: Fix NULL pointer dereference

2007-07-20 Thread Jeff Garzik
Magnus Damm wrote: pata_platform: Fix NULL pointer dereference pata_platform currently dereferences a NULL pointer in pata_platform_probe() if pdev->dev.platform_data is set to NULL. This breakage was most likely introduced by commit 5f45bc50976ee1f408f7171af155aec646655a37. Signed-off-by:

[PATCH] IP_VS should depend on EXPERIMENTAL ?

2007-07-20 Thread Gabriel C
Hi, IP_VS has : .. tristate "IP virtual server support (EXPERIMENTAL)" .. but it does not depend on EXPERIMENTAL. Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTED]> --- net/ipv4/ipvs/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH] Use wbinvd() macro instead of raw inline assembly in .c files

2007-07-20 Thread Andi Kleen
On Friday 20 July 2007 00:55:40 Glauber de Oliveira Costa wrote: > This patch uses the already-existant wbinvd() macro to replace > raw assembly to perform this very same task in some .c files > > Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]> > > diff --git

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Satyam Sharma
On 7/20/07, Chris Snook <[EMAIL PROTECTED]> wrote: Satyam Sharma wrote: > On 7/20/07, Chris Snook <[EMAIL PROTECTED]> wrote: >> Satyam Sharma wrote: >> > [ Just cleaning up my inbox, and stumbled across this thread ... ] >> > >> > >> > On 5/31/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: >>

Re: [PATCH] mm: Fix memory hotplug oops from ZONE_MOVABLE changes.

2007-07-20 Thread Paul Mundt
On Fri, Jul 20, 2007 at 12:20:25PM +0100, Mel Gorman wrote: > On (20/07/07 15:03), Paul Mundt didst pronounce: > > zone_movable_pfn is presently marked as __initdata and referenced > > from adjust_zone_range_for_zone_movable(), which in turn is > > referenced by zone_spanned_pages_in_node(). Both

Re: [PATCH 1/1][RESEND] Driver for the Atmel on-chip SSC on AT32AP and AT91.

2007-07-20 Thread Hans-Christian Egtvedt
Hi Andrew, On Fri, 2007-07-20 at 08:55 +0200, Andrew Victor wrote: > > Just an example from sound/soc/at91/at91-ssc.c > > > > rcmr =(( ssc_p->rcmr_period << 24) & AT91_SSC_PERIOD) > > | (( 1 << 16) & > > AT91_SSC_STTDLY) > >

Re: [RFH] Partition table recovery

2007-07-20 Thread Jan-Benedict Glaw
On Fri, 2007-07-20 14:29:34 +0300, Al Boldi <[EMAIL PROTECTED]> wrote: > > But, I want something much more automated. And the partition table backup > per partition entry isn't really a bad idea. That's called `gpart'. MfG, JBG -- Jan-Benedict Glaw [EMAIL PROTECTED]

Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-20 Thread S.Çağlar Onur
Hi; 20 Tem 2007 Cum tarihinde, Avi Kivity şunları yazmıştı: > Turned out kvm and slub didn't like each other. Please try applying > these two patches, in order: > > http://people.qumranet.com:/avi/kvm-late-fixes-rollup.patch > http://people.qumranet.com:/avi/kvm-vs-slub-fix.patch

Re: [RFH] Partition table recovery

2007-07-20 Thread Al Boldi
James Lamanna wrote: > On 7/19/07, Al Boldi <[EMAIL PROTECTED]> wrote: > > As always, a good friend of mine managed to scratch my partion table by > > cat'ing /dev/full into /dev/sda. I was able to push him out of the way, > > but at least the first 100MB are gone. I can probably live without

Re: [RFH] Partition table recovery

2007-07-20 Thread Al Boldi
Dave Young wrote: > >On 7/20/07, Al Boldi <[EMAIL PROTECTED]> wrote: > > As always, a good friend of mine managed to scratch my partion table by > > cat'ing /dev/full into /dev/sda. I was able to push him out of the way, > > but > > /dev/null ? > > > at least the first 100MB are gone. I can

Re: [RFH] Partition table recovery

2007-07-20 Thread Al Boldi
Jan Engelhardt wrote: > On Jul 20 2007 07:35, Willy Tarreau wrote: > >On Fri, Jul 20, 2007 at 08:13:03AM +0300, Al Boldi wrote: > >> As always, a good friend of mine managed to scratch my partion table by > >> cat'ing /dev/full into /dev/sda. I was able to push him out of the > >> way, but at

Re: [RFH] Partition table recovery

2007-07-20 Thread Al Boldi
Jeffrey V. Merkey wrote: > Al Boldi wrote: > >As always, a good friend of mine managed to scratch my partion table by > >cat'ing /dev/full into /dev/sda. I was able to push him out of the way, > > but at least the first 100MB are gone. I can probably live without the > > first partion, but there

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Chris Snook
Satyam Sharma wrote: On 7/20/07, Chris Snook <[EMAIL PROTECTED]> wrote: Satyam Sharma wrote: > [ Just cleaning up my inbox, and stumbled across this thread ... ] > > > On 5/31/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: >> Introduce CONFIG_STABLE to control checks only useful for

Re: [PATCH] fallout from kbuild changes

2007-07-20 Thread Sam Ravnborg
On Fri, Jul 20, 2007 at 10:20:29AM +0100, Al Viro wrote: > BTW, the presense of vmlinux in the second modpost generates warnings > in two cases - i386 with CONFIG_RELOCATABLE and sparc32 (always). > The warnings tend to be bogus. Do we really want them there now that > we should (in theory) get

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Satyam Sharma
On 7/20/07, Chris Snook <[EMAIL PROTECTED]> wrote: Satyam Sharma wrote: > [ Just cleaning up my inbox, and stumbled across this thread ... ] > > > On 5/31/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: >> Introduce CONFIG_STABLE to control checks only useful for development. >> >>

Re: [PATCH 4/6] remove the limit max_sectors_kb imposed on max_readahead_kb

2007-07-20 Thread Fengguang Wu
On Fri, Jul 20, 2007 at 01:07:43PM +0200, Jens Axboe wrote: > On Fri, Jul 20 2007, Fengguang Wu wrote: > > Remove the size limit max_sectors_kb imposed on max_readahead_kb. > > > > max_sectors_kb cannot grow larger than max_hw_sectors_kb, which can be > > rather small for some disk drives. > >

Re: [PATCH 1/6] compacting file_ra_state

2007-07-20 Thread Fengguang Wu
On Fri, Jul 20, 2007 at 12:48:59PM +0200, Peter Zijlstra wrote: > On Fri, 2007-07-20 at 12:26 +0200, Peter Zijlstra wrote: > > On Fri, 2007-07-20 at 18:07 +0800, Fengguang Wu wrote: > > > plain text document attachment (short-rasize.patch) > > > Use 'unsigned int' instead of 'unsigned long' for

Re: Linux, tcpdump and vlan

2007-07-20 Thread Florian Lohoff
On Wed, Jul 18, 2007 at 12:34:33PM -0700, andrei radulescu-banu wrote: > > Dear kernel networking gurus, > > I am trying to understand why tcpdump does not work properly for vlan packets > on linux. Here is the existing behavior, observed with: > - kernel 2.6.16, > - e1000 driver > -

Re: [PATCH] mm: Fix memory hotplug oops from ZONE_MOVABLE changes.

2007-07-20 Thread Mel Gorman
On (20/07/07 15:03), Paul Mundt didst pronounce: > zone_movable_pfn is presently marked as __initdata and referenced > from adjust_zone_range_for_zone_movable(), which in turn is > referenced by zone_spanned_pages_in_node(). Both of these are > __meminit annotated. When memory hotplug is enabled,

Re: [PATCH] Inhibit NMI watchdog when Alt-SysRq-T operation is underway.

2007-07-20 Thread Konrad Rzeszutek
Hey Andrew, I tested your patch along with mine and found two things out: 1). Missing this patch (for i386 platform) diff --git a/arch/i386/kernel/traps.c b/arch/i386/kernel/traps.c index 90da057..9f3a7ff 100644 --- a/arch/i386/kernel/traps.c +++ b/arch/i386/kernel/traps.c @@ -207,6 +207,7 @@

Re: which signal is sent to freeze process?

2007-07-20 Thread Rafael J. Wysocki
On Friday, 20 July 2007 01:22, Agarwal, Lomesh wrote: > I am using Linux in an embedded platform with x86. Applications don't do > anything special. The system call which is returning EINTR is poll. Also > in one of the thread read is returning ENODATA after resume. If I just > try the system

Re: [linux-pm] Re: Hibernation considerations

2007-07-20 Thread Rafael J. Wysocki
On Friday, 20 July 2007 01:07, [EMAIL PROTECTED] wrote: > On Thu, 19 Jul 2007, Rafael J. Wysocki wrote: > > > On Thursday, 19 July 2007 17:46, Milton Miller wrote: > >> > >> The currently identified problems under discussion include: > >> (1) how to interact with acpi to enter into S4. > >> (2)

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Chris Snook
Satyam Sharma wrote: [ Just cleaning up my inbox, and stumbled across this thread ... ] On 5/31/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Introduce CONFIG_STABLE to control checks only useful for development. Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> [...] menu "General

Re: [PATCH 4/6] remove the limit max_sectors_kb imposed on max_readahead_kb

2007-07-20 Thread Jens Axboe
On Fri, Jul 20 2007, Fengguang Wu wrote: > Remove the size limit max_sectors_kb imposed on max_readahead_kb. > > max_sectors_kb cannot grow larger than max_hw_sectors_kb, which can be > rather small for some disk drives. Please CC me on core block layer changes, thanks. The patch looks fine

Re: Hibernation considerations

2007-07-20 Thread Rafael J. Wysocki
On Friday, 20 July 2007 06:40, Al Boldi wrote: > Rafael J. Wysocki wrote: > > On Wednesday, 18 July 2007 16:29, Alan Stern wrote: > > > > > > Never mind. It seems clear that this approach will suffer the same > > > drawback as the proposal for removing the freezer from the > > > suspend-to-RAM

Re: [PATCH 1/6] compacting file_ra_state

2007-07-20 Thread Peter Zijlstra
On Fri, 2007-07-20 at 12:26 +0200, Peter Zijlstra wrote: > On Fri, 2007-07-20 at 18:07 +0800, Fengguang Wu wrote: > > plain text document attachment (short-rasize.patch) > > Use 'unsigned int' instead of 'unsigned long' for the readahead > > indexes/sizes. > > > > This helps reduce memory

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-07-20 Thread Satyam Sharma
[ Just cleaning up my inbox, and stumbled across this thread ... ] On 5/31/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Introduce CONFIG_STABLE to control checks only useful for development. Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> [...] menu "General setup" +config STABLE +

Re: [PATCH] fs/fuse/dev.c: use zero_user_page instead

2007-07-20 Thread Dave Young
On 7/20/07, rae l <[EMAIL PROTECTED]> wrote: On 7/20/07, Dave Young <[EMAIL PROTECTED]> wrote: > > - if (page && zeroing && count < PAGE_SIZE) { > > - void *mapaddr = kmap_atomic(page, KM_USER1); > > - memset(mapaddr, 0, PAGE_SIZE); > > -

[PATCH 6/6] basic support of interleaved reads

2007-07-20 Thread Fengguang Wu
This is a simplified version of the pagecache context based readahead. It handles the case of multiple threads reading on the same fd and invalidating each others' readahead state. It does the trick by scanning the pagecache and recovering the current read stream's readahead status. The algorithm

[PATCH 2/6] mmap read-around simplification

2007-07-20 Thread Fengguang Wu
Fold file_ra_state.mmap_hit into file_ra_state.mmap_miss and make it an int. Signed-off-by: Fengguang Wu <[EMAIL PROTECTED]> --- include/linux/fs.h |3 +-- mm/filemap.c |4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) --- linux-2.6.22-rc6-mm1.orig/include/linux/fs.h +++

Re: [PATCH] fs/fuse/dev.c: use zero_user_page instead

2007-07-20 Thread rae l
On 7/20/07, Dave Young <[EMAIL PROTECTED]> wrote: > - if (page && zeroing && count < PAGE_SIZE) { > - void *mapaddr = kmap_atomic(page, KM_USER1); > - memset(mapaddr, 0, PAGE_SIZE); > - kunmap_atomic(mapaddr, KM_USER1); > - } > + if

[PATCH 4/6] remove the limit max_sectors_kb imposed on max_readahead_kb

2007-07-20 Thread Fengguang Wu
Remove the size limit max_sectors_kb imposed on max_readahead_kb. max_sectors_kb cannot grow larger than max_hw_sectors_kb, which can be rather small for some disk drives. Signed-off-by: Fengguang Wu <[EMAIL PROTECTED]> --- block/ll_rw_blk.c |9 - 1 file changed, 9 deletions(-) ---

[PATCH 0/6] readahead cleanups and interleaved readahead

2007-07-20 Thread Fengguang Wu
Andrew, The following readahead updates have been tested and should be OK for 2.6.23 :-) smaller file_ra_state: [PATCH 1/6] compacting file_ra_state [PATCH 2/6] mmap read-around simplification code cleanups: [PATCH 3/6] remove several readahead macros [PATCH 4/6] remove the limit

[PATCH 3/6] remove several readahead macros

2007-07-20 Thread Fengguang Wu
Remove VM_MAX_CACHE_HIT, MAX_RA_PAGES and MIN_RA_PAGES. Signed-off-by: Fengguang Wu <[EMAIL PROTECTED]> --- include/linux/mm.h |2 -- mm/readahead.c | 10 +- 2 files changed, 1 insertion(+), 11 deletions(-) --- linux-2.6.22-rc6-mm1.orig/include/linux/mm.h +++

[PATCH 5/6] introduce radix_tree_scan_hole()

2007-07-20 Thread Fengguang Wu
Introduce radix_tree_scan_hole(root, index, max_scan) to scan radix tree for the first hole. It will be used in interleaved readahead. The implementation is dumb and obviously correct. It can help debug the possible smart one in future. Signed-off-by: Fengguang Wu <[EMAIL PROTECTED]> ---

[PATCH 1/6] compacting file_ra_state

2007-07-20 Thread Fengguang Wu
Use 'unsigned int' instead of 'unsigned long' for the readahead indexes/sizes. This helps reduce memory consumption on 64bit CPU when a lot of files are opened. Note that the (smaller) 32bit index can support up to 16PB file. Which should be sufficient large at least for now. Signed-off-by:

Re: [PATCH] fs/fuse/dev.c: use zero_user_page instead

2007-07-20 Thread Dave Young
On 7/20/07, Denis Cheng <[EMAIL PROTECTED]> wrote: Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- I'm not very sure zero_user_page is correctly used here, so please feel free to give comments. and why here it uses KM_USER1 not KM_USER0, What are the differences? fs/fuse/dev.c |8

[ALSA PATCH] alsa-git merge request

2007-07-20 Thread Jaroslav Kysela
Linus, please pull from [the linus branch at]: master.kernel.org:/pub/scm/linux/kernel/git/perex/alsa.git linus gitweb interface: http://www.kernel.org/git/?p=linux/kernel/git/perex/alsa.git The GNU patch is available at:

[PATCH] AFS: Use patched rxrpc_kernel_send_data() correctly [try #2]

2007-07-20 Thread David Howells
Fix afs_send_simple_reply() to accept a greater-than-zero return value from rxrpc_kernel_send_data() as being a successful return rather than thinking it an error and aborting the call. rxrpc_kernel_send_data() previously returned zero incorrectly when it worked successfully, but has been patched

[PATCH] NET: Add missing entries to family name tables

2007-07-20 Thread David Howells
Add missing entries to af_family_clock_key_strings[]. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- net/core/sock.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net/core/sock.c b/net/core/sock.c index bd209c4..cfed7d4 100644 --- a/net/core/sock.c +++

[GIT PULL] More sh updates for 2.6.23-rc1

2007-07-20 Thread Paul Mundt
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/lethal/sh-2.6.git Which contains: Kristoffer Ericson (1): sh: hd64461 tidying. Magnus Damm (10): sh: Fix irq assignment for uarts on sh7722 sh: intc - shared IPR and INTC2 controller sh: intc - add

Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-20 Thread Ingo Molnar
* Olaf Kirch <[EMAIL PROTECTED]> wrote: > On Thursday 19 July 2007 21:56, Ingo Molnar wrote: > > nope - with this patch applied the box still has no network, symptoms > > are similar. (should i apply the WARN_ON() patch too?) > > Yes, that would be nice. If that doesn't help, you can also

[PATCH] fs/fuse/dev.c: use zero_user_page instead

2007-07-20 Thread Denis Cheng
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- I'm not very sure zero_user_page is correctly used here, so please feel free to give comments. and why here it uses KM_USER1 not KM_USER0, What are the differences? fs/fuse/dev.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-)

Re: kobject link failure

2007-07-20 Thread Cornelia Huck
On Fri, 20 Jul 2007 01:00:59 -0700, Greg KH <[EMAIL PROTECTED]> wrote: > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -250,6 +250,7 @@ static struct kset_uevent_ops device_uev > .uevent = dev_uevent, > }; > > +#ifdef CONFIG_HOTPLUG > static ssize_t show_uevent(struct

Re: [PATCH] fallout from kbuild changes

2007-07-20 Thread Al Viro
BTW, the presense of vmlinux in the second modpost generates warnings in two cases - i386 with CONFIG_RELOCATABLE and sparc32 (always). The warnings tend to be bogus. Do we really want them there now that we should (in theory) get all useful stuff from vmlinux.o? Other targets get aways with

[GIT PULL] Trivial sh64 updates for 2.6.23-rc1

2007-07-20 Thread Paul Mundt
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/lethal/sh64-2.6.git Which contains: Paul Mundt (5): sh64: Wire up fallocate() syscall. sh64: Update cayman defconfig. sh64: Fix up PCI section mismatch warnings. sh64: Move entry point code to

Re: [PATCH] ext2 statfs improvement for block and inode free count

2007-07-20 Thread Andreas Dilger
On Jul 19, 2007 08:18 -0700, Badari Pulavarty wrote: > In my setups (4 & 8-way), I didn't measure any significant performance > improvements (in any reasonable workload). I see some decent > improvements on cooked-up (1 million stats) tests :( I don't have any numbers to publish, but this did

Re: [PATCH 3/8] m68k: use .text.head

2007-07-20 Thread Paul Mundt
On Fri, Jul 20, 2007 at 10:06:24AM +0200, Heiko Carstens wrote: > On Fri, Jul 20, 2007 at 04:33:08AM +0100, Al Viro wrote: > > > > i.e. tell modpost that entry point code (that has to be outside > > of .init.text for external reasons) is OK to refer to .init.* > > > I was wondering how to "fix"

man-pages-2.63 is released

2007-07-20 Thread Michael Kerrisk
Gidday, I recently released man-pages-2.63. This release is now available for download at: http://www.kernel.org/pub/linux/docs/manpages or ftp://ftp.kernel.org/pub/linux/docs/manpages and soon at: ftp://ftp.win.tue.nl/pub/linux-local/manpages Changes in this release that may be

Re: build fix for x86_64...

2007-07-20 Thread Andi Kleen
On Friday 20 July 2007 01:54:51 Luck, Tony wrote: > > Tony, perhaps it would make sense to define some common CONFIG > > for COMPAT_FOR_U64_ALIGNMENT longer term to make the #ifs for this > > case a little less ugly. > > Certainly if there is ever a third architecture that needs this the > #if

Re: [PATCH] [15/58] i386: Rewrite sched_clock

2007-07-20 Thread Andi Kleen
> I noticed the same thing about interrupts off when going through the > code. That's only on a slow path during cpu frequency changing while the TSC is instable. Shouldn't be that common. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: new text patching for review

2007-07-20 Thread Andi Kleen
On Thu, Jul 19, 2007 at 07:49:12PM -0400, Mathieu Desnoyers wrote: > * Andi Kleen ([EMAIL PROTECTED]) wrote: > > Mathieu Desnoyers <[EMAIL PROTECTED]> writes: > > > > > * Andi Kleen ([EMAIL PROTECTED]) wrote: > > > > > > > > > Ewww you plan to run this in SMP ? So you actually go

[RFC][-mm PATCH 8/8] Add switch to control what type of pages to limit (v3)

2007-07-20 Thread Balbir Singh
Choose if we want cached pages to be accounted or not. By default both are accounted for. A new set of tunables are added. echo -n 1 > mem_control_type switches the accounting to account for only mapped pages echo -n 2 > mem_control_type switches the behaviour back Signed-off-by: <[EMAIL

Re: [PATCH for review] [12/48] x86_64: use the global PIT lock

2007-07-20 Thread Andi Kleen
> +static DEFINE_SPINLOCK(i8253_lock); > + >  static __init int add_pcspkr(void) >  { > struct platform_device *pd; > @@ -1501,9 +1503,14 @@ static __init int add_pcspkr(void) > if (!pd) > return -ENOMEM; >   > +   pd->dev.platform_data = _lock; That seems

[RFC][-mm PATCH 7/8] Memory controller OOM handling (v3)

2007-07-20 Thread Balbir Singh
From: Pavel Emelianov <[EMAIL PROTECTED]> Out of memory handling for containers over their limit. A task from the container over limit is chosen using the existing OOM logic and killed. TODO: 1. As discussed in the OLS BOF session, consider implementing a user space policy for OOM handling.

[RFC][-mm PATCH 6/8] Memory controller add per container LRU and reclaim (v3)

2007-07-20 Thread Balbir Singh
Add the meta_page to the per container LRU. The reclaim algorithm has been modified to make the isolate_lru_pages() as a pluggable component. The scan_control data structure now accepts the container on behalf of which reclaims are carried out. try_to_free_pages() has been extended to become

[RFC][-mm PATCH 5/8] Memory controller task migration (v3)

2007-07-20 Thread Balbir Singh
Allow tasks to migrate from one container to the other. We migrate mm_struct's mem_container only when the thread group id migrates. Signed-off-by: <[EMAIL PROTECTED]> --- mm/memcontrol.c | 35 +++ 1 file changed, 35 insertions(+) diff -puN

[RFC][-mm PATCH 2/8] Memory controller containers setup (v3)

2007-07-20 Thread Balbir Singh
Setup the memory container and add basic hooks and controls to integrate and work with the container. Signed-off-by: <[EMAIL PROTECTED]> --- include/linux/container_subsys.h |6 + include/linux/memcontrol.h | 21 + init/Kconfig |8 ++ mm/Makefile

[RFC][-mm PATCH 3/8] Memory controller accounting setup (v3)

2007-07-20 Thread Balbir Singh
From: Pavel Emelianov <[EMAIL PROTECTED]> Basic setup routines, the mm_struct has a pointer to the container that it belongs to and the the page has a meta_page associated with it. Signed-off-by: Pavel Emelianov <[EMAIL PROTECTED]> Signed-off-by: <[EMAIL PROTECTED]> ---

[RFC][-mm PATCH 4/8] Memory controller memory accounting (v3)

2007-07-20 Thread Balbir Singh
Changelog 1. Improved error handling, uncharge on errors and check to see if we are leaking pages (review by YAMAMOTO Takashi) Add the accounting hooks. The accounting is carried out for RSS and Page Cache (unmapped) pages. There is now a common limit and accounting for both. The RSS

[RFC][-mm PATCH 1/8] Memory controller resource counters (v3)

2007-07-20 Thread Balbir Singh
From: Pavel Emelianov <[EMAIL PROTECTED]> Introduce generic structures and routines for resource accounting. Each resource accounting container is supposed to aggregate it, container_subsystem_state and its resource-specific members within. Signed-off-by: Pavel Emelianov <[EMAIL PROTECTED]>

[RFC][-mm PATCH 0/8] Memory controller introduction (v3)

2007-07-20 Thread Balbir Singh
Changelog since version 2 1. Improved error handling in mm/memory.c (spotted by YAMAMOTO Takashi) 2. Test results included 3. try_to_free_mem_container_pages() bug fix (sc->may_writepage is now set to !laptop_mode) Changelog since version 1 1. Fixed some compile time errors (in mm/migrate.c

Re: new text patching for review

2007-07-20 Thread Andi Kleen
On Friday 20 July 2007 02:37:20 Zachary Amsden wrote: > Andi Kleen wrote: > > + *addr = opcode; > > + /* Not strictly needed, but can speed CPU recovery up */ > > + if (cpu_has_clflush) > > + asm("clflush (%0) " :: "r" (addr) : "memory"); > > + if (addr != oaddr) > > +

[2.6.23 regression fix] X86_POWERNOW_K8_ACPI must depend on ACPI

2007-07-20 Thread Adrian Bunk
This patch fixes the following compile error introduced by commit e8666b2718fdb5bf0ea7c3126f7e292bbbf2946b and reported by Alexey Dobriyan: <-- snip --> CC arch/i386/kernel/acpi/cstate.o In file included from arch/i386/kernel/acpi/cstate.c:17: include/acpi/processor.h:88: error:

Re: [PATCH] kill DECLARE_MUTEX_LOCKED

2007-07-20 Thread Satyam Sharma
Hi, On 7/20/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote: On Fri, Jul 20, 2007 at 10:58:34AM +0530, Satyam Sharma wrote: > That comment in libusual is quite nonsensical, IMHO. Note that > usu_init_notify is declared as DECLARE_MUTEX_LOCKED and yet the > author wants us to believe (later,

Re: Documentation for sysfs, hotplug, and firmware loading.

2007-07-20 Thread Greg KH
On Fri, Jul 20, 2007 at 09:54:01AM +0200, Cornelia Huck wrote: > On Fri, 20 Jul 2007 00:00:01 -0700, > Greg KH <[EMAIL PROTECTED]> wrote: > > > > I don't insist on it, mknod insists on it. You cannot mknod a dev node > > > without specifying block or char. > > > > > > You're saying that sysfs

Re: [PATCH] Documentation update sched-stat.txt

2007-07-20 Thread Nick Piggin
On Fri, Jul 20, 2007 at 09:56:03AM +0200, Joachim Deguara wrote: > On Friday 20 July 2007 09:25:22 Nick Piggin wrote: > > On Wed, Jul 18, 2007 at 11:11:30AM +0200, Joachim Deguara wrote: > > > While learning about schedstats I found that the documentation in the > > > tree is old. I updated it

Re: [PATCH 3/8] m68k: use .text.head

2007-07-20 Thread Heiko Carstens
On Fri, Jul 20, 2007 at 04:33:08AM +0100, Al Viro wrote: > > i.e. tell modpost that entry point code (that has to be outside > of .init.text for external reasons) is OK to refer to .init.* > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > --- > diff --git a/arch/m68k/kernel/sun3-head.S

Re: drivers/base/core.c broken for non-CONFIG_HOTPLUG

2007-07-20 Thread Andrew Morton
On Fri, 20 Jul 2007 09:01:06 +0200 Robert Schwebel <[EMAIL PROTECTED]> wrote: > You add and use > > extern const char *kobject_actions[]; Added it in a .c file, too. Even checkpatch.pl knows that was wrong. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: kobject link failure

2007-07-20 Thread Greg KH
On Thu, Jul 19, 2007 at 08:11:26PM +0200, Gabriel C wrote: > Jan Engelhardt wrote: > > Hi, > > > > > > top is 275afcac9953ece0828972edeab9684cfe1a5ef3, error is: > > LD .tmp_vmlinux1 > > drivers/built-in.o: In function `store_uevent': > > core.c:(.text+0x20ebb): undefined reference to

<    1   2   3   4   5   6   7   8   9   10   >