Re: [RFC][PATCH] Removal of duplicated include arch/x86_64/kernel/pci-calgary.c

2007-08-01 Thread Muli Ben-Yehuda
On Wed, Aug 01, 2007 at 07:53:15PM +0200, Michal Piotrowski wrote: > Hi, > > There is no need to include linux/init.h twice Thanks, looks good. Will be pushed for 2.6.24. Cheers, Muli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [RFC PATCH] type safe allocator

2007-08-01 Thread Christoph Lameter
On Wed, 1 Aug 2007, Miklos Szeredi wrote: > I wonder why we don't have type safe object allocators a-la new() in > C++ or g_new() in glib? > > fooptr = k_new(struct foo, GFP_KERNEL); > > is nicer and more descriptive than > > fooptr = kmalloc(sizeof(*fooptr), GFP_KERNEL); > > and more

Re: [patch 3/4] Enable link power management for ata drivers

2007-08-01 Thread Tejun Heo
Kristen Carlson Accardi wrote: > On Wed, 01 Aug 2007 17:27:39 +0900 > Tejun Heo <[EMAIL PROTECTED]> wrote: > >> Kristen Carlson Accardi wrote: > >> Is it safe to use ALPM on a device which only claims to support DIPM? > > Yes - I doubled checked this with the AHCI people - and of course you >

[patch] radix-tree: use indirect bit

2007-08-01 Thread Nick Piggin
Rather than sign direct radix-tree pointers with a special bit, sign the indirect one that hangs off the root. This means that, given a lookup_slot operation, the invalid result will be differentiated from the valid (previously, valid results could have the bit either set or clear). This does

Re: [RFC 12/26] ext2 white-out support

2007-08-01 Thread Ph. Marek
On Mittwoch, 1. August 2007, Josef Sipek wrote: > Alright not the greatest of examples, there is something to be said about > symmetry, so...let me try again :) ... > Oops! There's a whiteout in /b that hides the directory in /c -- rename(2) > shouldn't make directory subtrees disappear. > > There

Re: 2.6.23-rc1: no setup signature found... SOLVED!

2007-08-01 Thread Borislav Petkov
On Wed, Aug 01, 2007 at 10:36:07AM -0400, H. Peter Anvin wrote: > Borislav Petkov wrote: >> Breakpoint 4, 0x00040200 in ?? () >> 1: x/i ($cs << 4) + $eip 0x40300: lea(%si),%dx >> (gdb) c >> Continuing. >> if i do delete here, it loads the second stage of grub and

Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())

2007-08-01 Thread Andrew Morton
On Wed, 1 Aug 2007 21:03:50 -0600 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Wed, Aug 01, 2007 at 05:26:53PM -0700, Andrew Morton wrote: > > Why on earth is that using GFP_ATOMIC? This function later goes on to > > create procfs files and such things. > > Seems fairly common in driver

Re: [PATCH 025 of 35] Treat rq->hard_nr_sectors as setting an overriding limit in the size of the request

2007-08-01 Thread Tejun Heo
Neil Brown wrote: > On Thursday August 2, [EMAIL PROTECTED] wrote: >> This is pretty confusing. In all other places, bi_size -> #sector >> conversion is done by rounding down but only in blk_rq_bio_prep() it's >> being rounded up. >> >> Is my following reasoning correct? >> >> It was okay till

Re: CFS review

2007-08-01 Thread Willy Tarreau
On Wed, Aug 01, 2007 at 07:17:51PM -0700, Linus Torvalds wrote: > > > On Wed, 1 Aug 2007, Roman Zippel wrote: > > > > I'm not so sure about that. sched_clock() has to be fast, so many archs > > may want to continue to use jiffies. As soon as one does that one can also > > save a lot of

Re: [PATCH 67] net/ipv4/route.c: mostly kmalloc + memset conversion to k[cz]alloc

2007-08-01 Thread David Miller
From: Mariusz Kozlowski <[EMAIL PROTECTED]> Date: Tue, 31 Jul 2007 23:55:02 +0200 > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 66] net/ipv4/raw.c: kmalloc + memset conversion to kzalloc

2007-08-01 Thread David Miller
From: Mariusz Kozlowski <[EMAIL PROTECTED]> Date: Tue, 31 Jul 2007 23:54:00 +0200 > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 58] net/ipv4/netfilter/nf_conntrack_l3proto_ipv4_compat.c: kmalloc + memset conversion to kzalloc

2007-08-01 Thread David Miller
From: Mariusz Kozlowski <[EMAIL PROTECTED]> Date: Tue, 31 Jul 2007 23:32:04 +0200 > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 57] net/netfilter/nf_conntrack_expect.c: kmalloc + memset conversion to kzalloc

2007-08-01 Thread David Miller
From: Mariusz Kozlowski <[EMAIL PROTECTED]> Date: Tue, 31 Jul 2007 23:31:02 +0200 > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [RFC][PATCH] Removal of duplicated include net/wanrouter/wanmain.c

2007-08-01 Thread David Miller
From: Michal Piotrowski <[EMAIL PROTECTED]> Date: Wed, 01 Aug 2007 19:58:53 +0200 > Hi, > > There is no need to include linux/init.h twice ... > Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> Patch applied, thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-08-01 Thread Alan Curry
Matt Sealey writes the following: > >Yeah please do a fixup for the boot wrapper. > >Or, if you have trouble, go into the firmware and type "nvedit", add >these lines; > >" /isa/8042" find-device >" 8042" encode-string device-type > >(then ctrl-c to exit and nvstore to run it on next reboot. Try

Re: 2.6.23-rc1-mm2

2007-08-01 Thread Torsten Kaiser
On 8/2/07, Mel Gorman <[EMAIL PROTECTED]> wrote: > On (01/08/07 22:52), Torsten Kaiser didst pronounce: > > Next try with 2.6.23-rc1-mm2 and SPARSEMEM: > > Probably the same exception, but this time with Call Trace: > > [0.00] Bootmem setup node 0 -8000 > > [

Re: Is PIE randomization breaking klibc binaries?

2007-08-01 Thread Ulrich Kunitz
Jiri Kosina wrote: > On Tue, 31 Jul 2007, H. Peter Anvin wrote: > > > > So it seems to me that either it is something x86_64 specific or > > > initramfs-specific. Will try to reproduce it. > > My guess would be the former, rather than the latter. I haven't had a > > chance to reproduce it

Re: [PATCH -mm] Introduce strtol_check_range()

2007-08-01 Thread Alexey Dobriyan
On Thu, Aug 02, 2007 at 05:16:59AM +0530, Satyam Sharma wrote: > On Wed, 1 Aug 2007, Alexey Dobriyan wrote: > > > On Tue, Jul 31, 2007 at 10:04:10PM +0530, Satyam Sharma wrote: > > > Callers (especially "store" functions for sysfs or configfs attributes) > > > that want to convert an input string

Touchpad loses sync with ACPI on.

2007-08-01 Thread Matthew Marshall
I am having a problem with the touchpad and pointer stick on my HP compaq nc6000 laptop. It only happens when using ACPI. Both pointing devices work for a while, but eventually start to 'stick'. The cursor won't move for about a second, and then it jerks all over the screen, clicking. This

Re: [PATCH] retrieve VBE EDID/DDC info independent of used video mode

2007-08-01 Thread H. Peter Anvin
Antonino A. Daplas wrote: On Wed, 2007-08-01 at 09:54 +0800, Antonino A. Daplas wrote: On Tue, 2007-07-31 at 21:17 -0400, Daniel Drake wrote: Zwane Mwaikambo wrote: Sorry if this has been hashed out before, but could you point me towards the gentoo bugzilla entry? I'm trying to understand how

Re: [RFC PATCH] type safe allocator

2007-08-01 Thread Linus Torvalds
On Wed, 1 Aug 2007, Miklos Szeredi wrote: > > I wonder why we don't have type safe object allocators a-la new() in > C++ or g_new() in glib? > > fooptr = k_new(struct foo, GFP_KERNEL); I would object to this if only because of the horrible name. C++ is not a good language to take ideas

Re: [PATCH 000 of 35] Refactor block layer to improve support for stacked devices.

2007-08-01 Thread Neil Brown
On Wednesday August 1, [EMAIL PROTECTED] wrote: > > In any case, why does something so complicated need to be a macro, why > not a function instead? There needs to be a macro so you can put a statement after it to be executed "for each ..." But you are right that it doesn't all need to be in the

Re: [rfc] balance-on-fork NUMA placement

2007-08-01 Thread Nick Piggin
On Tue, Jul 31, 2007 at 04:40:18PM -0700, Christoph Lameter wrote: > On Tue, 31 Jul 2007, Andi Kleen wrote: > > > On Tuesday 31 July 2007 07:41, Nick Piggin wrote: > > > > > I haven't given this idea testing yet, but I just wanted to get some > > > opinions on it first. NUMA placement still

Re: 2.6.22: oops in sbp2_remove_device

2007-08-01 Thread Stefan Richter
Olaf Hering wrote: > On Wed, Aug 01, Stefan Richter wrote: >> Revert commit 0555659d63c285ceb7ead3115532e1b71b0f27a7 from 2.6.22-rc1. > This change fixes the oops, and I can access the drive again. Did it oops always or only sometimes? -- Stefan Richter -=-=-=== =--- ---=-

Re: [PATCH 013 of 35] Don't update bi_hw_*_size if we aren't going to merge.

2007-08-01 Thread Neil Brown
On Thursday August 2, [EMAIL PROTECTED] wrote: > On Tue, Jul 31, 2007 at 12:16:55PM +1000, NeilBrown wrote: > > > > ll_merge_requests_fn can update bi_hw_*_size in one case where we end > > up not merging. This is wrong. > > > > Signed-off-by: Neil Brown <[EMAIL PROTECTED]> > > As this is a

Re: [PATCH] Fix WARN_ON() on bitfield ops for all other archs

2007-08-01 Thread Satyam Sharma
On Thu, 2 Aug 2007, Heiko Carstens wrote: > From: Heiko Carstens <[EMAIL PROTECTED]> > > Fixes WARN_ON() on bitfiels ops for all architectures that have > been left out in 8d4fbcfbe0a4bfc73e7f0297c59ae514e1f1436f. Well, considering ... On Tue, 31 Jul 2007, Alexey Dobriyan wrote: > But I

Re: [PATCH 025 of 35] Treat rq->hard_nr_sectors as setting an overriding limit in the size of the request

2007-08-01 Thread Neil Brown
On Thursday August 2, [EMAIL PROTECTED] wrote: > > This is pretty confusing. In all other places, bi_size -> #sector > conversion is done by rounding down but only in blk_rq_bio_prep() it's > being rounded up. > > Is my following reasoning correct? > > It was okay till now because unaligned

Re: [PATCH 026 of 35] Split any large bios that arrive at __make_request.

2007-08-01 Thread Neil Brown
On Thursday August 2, [EMAIL PROTECTED] wrote: > Neil Brown wrote: > > > > If you confirm that 027 isn't applying, I'll track down what happened. > > You're right. I don't have patch 27. Looking Ummm... It's not in > my LKML folder either. Can you resend it? > > Thanks. > > -- > tejun

[PATCH] debugfs helper for decimal challenged

2007-08-01 Thread Robin Getz
From: Robin Getz <[EMAIL PROTECTED]> Allows debugfs helper functions to have a hex output, rather than just decimal Signed-off-by: Robin Getz <[EMAIL PROTECTED]> --- fs/debugfs/file.c | 36 1 file changed, 36 insertions(+) Index: fs/debugfs/file.c

Re: [PATCH] retrieve VBE EDID/DDC info independent of used video mode

2007-08-01 Thread Antonino A. Daplas
On Wed, 2007-08-01 at 09:54 +0800, Antonino A. Daplas wrote: > On Tue, 2007-07-31 at 21:17 -0400, Daniel Drake wrote: > > Zwane Mwaikambo wrote: > > > Sorry if this has been hashed out before, but could you point me towards > > > the gentoo bugzilla entry? I'm trying to understand how your setup

Re: [PATCH] Fix WARN_ON() on bitfield ops for all other archs

2007-08-01 Thread Paul Mundt
On Thu, Aug 02, 2007 at 12:18:38AM +0200, Heiko Carstens wrote: > From: Heiko Carstens <[EMAIL PROTECTED]> > > Fixes WARN_ON() on bitfiels ops for all architectures that have > been left out in 8d4fbcfbe0a4bfc73e7f0297c59ae514e1f1436f. > > Cc: Alexey Dobriyan <[EMAIL PROTECTED]> > Cc: Herbert Xu

Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())

2007-08-01 Thread Matthew Wilcox
On Wed, Aug 01, 2007 at 05:26:53PM -0700, Andrew Morton wrote: > Why on earth is that using GFP_ATOMIC? This function later goes on to > create procfs files and such things. Seems fairly common in driver initialisation code. I removed three instances of this in the advansys driver. > y'know,

Re: [PATCH 026 of 35] Split any large bios that arrive at __make_request.

2007-08-01 Thread Tejun Heo
Neil Brown wrote: > On Thursday August 2, [EMAIL PROTECTED] wrote: >> Hmmm... Patches don't apply beyond this one. I'm applying against >> clean 2.6.23-rc1-mm1 grabbed using ketchup. >> > > So do you mean 027 doesn't apply, or that 028 doesn't apply next? > > It is possible that you missed 027.

Re: [RFC 11/26] tmpfs white-out support

2007-08-01 Thread Matt Mackall
On Wed, Aug 01, 2007 at 04:13:46PM +0100, Hugh Dickins wrote: > On Mon, 30 Jul 2007, Jan Blunck wrote: > > > Introduce white-out support to tmpfs. > > > > Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> > > --- > > include/linux/shmem_fs.h |1 > > mm/shmem.c | 54 > >

Re: lmbench ctxsw regression with CFS

2007-08-01 Thread Nick Piggin
On Wed, Aug 01, 2007 at 07:31:26PM -0700, Linus Torvalds wrote: > > > On Thu, 2 Aug 2007, Nick Piggin wrote: > > > > lmbench 3 lat_ctx context switching time with 2 processes bound to a > > single core increases by between 25%-35% on my Core2 system (didn't do > > enough runs to get more

Re: SD still better than CFS for 3d ?(was Re: 2.6.23-rc1)

2007-08-01 Thread Lee Revell
On 7/31/07, Ingo Molnar <[EMAIL PROTECTED]> wrote: > Almost all of the Reiser3 > code runs under the BKL, and the only other major kernel infrastructure > that has BKL dependencies is the TTY code. Also NFS: $ grep -rIi lock_kernel kernel-source/linux-2.6.17/fs/nfs/ | wc -l 94 Lee - To

Re: lmbench ctxsw regression with CFS

2007-08-01 Thread Linus Torvalds
On Thu, 2 Aug 2007, Nick Piggin wrote: > > lmbench 3 lat_ctx context switching time with 2 processes bound to a > single core increases by between 25%-35% on my Core2 system (didn't do > enough runs to get more significance, but it is around 30%). The problem > bisected to the main CFS commit.

Re: Examine user space locks

2007-08-01 Thread Satyam Sharma
Hi Rokas, [ Your mailer does not maintain the Cc: list. That's not good when posting to LKML. Adding back Jan Engelhardt to Cc: ] On Wed, 1 Aug 2007, Rokas Masiulis wrote: > On Wed, Aug 01, 2007 at 09:51:06PM +0200, Jan Engelhardt wrote: > > [...] > > echo t >/proc/sysrq-trigger > > # cat

Re: CFS review

2007-08-01 Thread Linus Torvalds
On Wed, 1 Aug 2007, Roman Zippel wrote: > > I'm not so sure about that. sched_clock() has to be fast, so many archs > may want to continue to use jiffies. As soon as one does that one can also > save a lot of computational overhead by using 32bit instead of 64bit. > The question is then how

lmbench ctxsw regression with CFS

2007-08-01 Thread Nick Piggin
Hi, I didn't follow all of the scheduler debates and flamewars, so apologies if this was already covered. Anyway. lmbench 3 lat_ctx context switching time with 2 processes bound to a single core increases by between 25%-35% on my Core2 system (didn't do enough runs to get more significance, but

Re: [2/2] 2.6.23-rc1: known regressions

2007-08-01 Thread Horms
> IA64 > > Subject : Regression in serial console on ia64 after 2.6.22 > References : http://marc.info/?l=linux-ia64=118483645914066=2 > Last known good : ? > Submitter : Horms <[EMAIL PROTECTED]> > Caused-By : Yinghai Lu <[EMAIL PROTECTED]> > commit

2.6.23-rc6-mm1: compile error mm/sparse.c

2007-08-01 Thread sukadev
I get this compile error on 2.6.23-rc1-mm1 on i386. Config file attached (this basic config file worked on 2.6.22-rc6-mm1) lx26-23-rc1-mm1/mm/sparse.c: In function 'sparse_init': lx26-23-rc1-mm1/mm/sparse.c:482: error: implicit declaration of function 'sparse_early_usemap_alloc'

Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 )

2007-08-01 Thread Matt Mackall
On Wed, Aug 01, 2007 at 11:59:21AM +0200, Jarek Poplawski wrote: > On Tue, Jul 31, 2007 at 05:05:00PM +0200, Gabriel C wrote: > > Jarek Poplawski wrote: > > > On Tue, Jul 31, 2007 at 12:14:36PM +0200, Gabriel C wrote: > > >> Jarek Poplawski wrote: > > >>> On 28-07-2007 20:42, Gabriel C wrote: > >

Re: kupdate weirdness

2007-08-01 Thread David Chinner
On Wed, Aug 01, 2007 at 10:45:16PM +0200, Miklos Szeredi wrote: > The following strange behavior can be observed: > > 1. large file is written > 2. after 30 seconds, nr_dirty goes down by 1024 > 3. then for some time (< 30 sec) nothing happens (disk idle) > 4. then nr_dirty again goes down by

Re: 2.6.22-rc1-mm1 huge pages VM freeze (maybe?)

2007-08-01 Thread Zan Lynx
On Wed, 2007-08-01 at 08:52 -0700, Nish Aravamudan wrote: > On 7/31/07, Zan Lynx <[EMAIL PROTECTED]> wrote: > > On Tue, 2007-07-31 at 15:02 -0700, Randy Dunlap wrote: > > > On Tue, 31 Jul 2007 15:44:21 -0600 Zan Lynx wrote: > > > > > > > I was playing with huge pages and libhugetlbfs. Small

What archs need flush_tlb_page() in handle_pte_fault() ?

2007-08-01 Thread Benjamin Herrenschmidt
Heya ! In my page table accessor spring cleaning, one of my targets is flush_tlb_page(). At this stage, it's only called by generic code in one place (in addition to the asm-generic bits that use it to implement missing accessors, but I'm taking care of those spearately) : In handle_pte_fault(),

Re: [rfc] balance-on-fork NUMA placement

2007-08-01 Thread Nick Piggin
On Wed, Aug 01, 2007 at 03:52:11PM -0700, Martin Bligh wrote: > > >And so forth. Initial forks will balance. If the children refuse to > >die, forks will continue to balance. If the parent starts seeing short > >lived children, fork()s will eventually start to stay local. > > Fork without

Re: CS5530 Alsa driver fails

2007-08-01 Thread Ash Willis
> the VGA video. If your box has VSA2 then VSA2 firmware has some kind of > hooks to allow a native sound driver to take over and to reroute the > interrupts without SB emulation. I don't have the docs for VSA2 but the > horribly big natsemi provided audio driver does show how to do it. > I

Re: [PATCH -mm] linux-audit list is subscribers-only

2007-08-01 Thread Randy Dunlap
On Thu, 02 Aug 2007 01:59:54 +0200 Gabriel C wrote: > Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTED]> > > --- > > --- linux-2.6.23-rc1-mm/MAINTAINERS.orig 2007-08-02 01:51:40.0 > +0200 > +++ linux-2.6.23-rc1-mm/MAINTAINERS 2007-08-02 01:52:17.0 +0200 > @@ -672,7

Re: Profiling the Kernel

2007-08-01 Thread Lee Revell
On 8/1/07, Mohamed Bamakhrama <[EMAIL PROTECTED]> wrote: > Hi *, > I have a question regarding profiling the Linux kernel code during > runtime (by "profile", I mean the usage of each function/module within > the kernel itself). I googled and found many "system-wide" profiler > such as sysprof,

Re: [PATCH 1/7] sysfs: fix locking in sysfs_lookup() and sysfs_rename_dir()

2007-08-01 Thread Eric W. Biederman
Greg KH <[EMAIL PROTECTED]> writes: > On Tue, Jul 31, 2007 at 07:15:08PM +0900, Tejun Heo wrote: >> sd children list walking in sysfs_lookup() and sd renaming in >> sysfs_rename_dir() were left out during i_mutex -> sysfs_mutex >> conversion. Fix them. >> >> Signed-off-by: Tejun Heo <[EMAIL

Re: [PATCH 1/7] sysfs: fix locking in sysfs_lookup() and sysfs_rename_dir()

2007-08-01 Thread Greg KH
On Wed, Aug 01, 2007 at 05:29:00PM -0700, Greg KH wrote: > On Tue, Jul 31, 2007 at 07:15:08PM +0900, Tejun Heo wrote: > > sd children list walking in sysfs_lookup() and sd renaming in > > sysfs_rename_dir() were left out during i_mutex -> sysfs_mutex > > conversion. Fix them. > > > >

Re: [PATCH][RFC] unbreak generic futex_atomic_cmpxchg_inatomic() on UP

2007-08-01 Thread Lennert Buytenhek
On Thu, Aug 02, 2007 at 02:06:27AM +0200, Mikael Pettersson wrote: > > > @@ -52,7 +53,34 @@ futex_atomic_op_inuser (int encoded_op, > > > static inline int > > > futex_atomic_cmpxchg_inatomic(int __user *uaddr, int oldval, int newval) > > > { > > > +#ifdef CONFIG_SMP > > > return -ENOSYS; >

Re: [PATCH 026 of 35] Split any large bios that arrive at __make_request.

2007-08-01 Thread Neil Brown
On Thursday August 2, [EMAIL PROTECTED] wrote: > Hmmm... Patches don't apply beyond this one. I'm applying against > clean 2.6.23-rc1-mm1 grabbed using ketchup. > So do you mean 027 doesn't apply, or that 028 doesn't apply next? It is possible that you missed 027. It originally has 3

Re: [PATCH] 2.6.23-rc1-mm1 - fix missing numa_zonelist_order sysctl

2007-08-01 Thread KAMEZAWA Hiroyuki
On Wed, 01 Aug 2007 15:02:51 -0400 Lee Schermerhorn <[EMAIL PROTECTED]> wrote: > [But, maybe reordering the zonelists is not such a good idea > when ZONE_MOVABLE is populated?] > It's case-by-case I think. In zone order with ZONE_MOVABLE case, user's page cache will not use ZONE_NORMAL until

Re: cpufreq.c:(.text+0xaf178): undefined reference to `cpufreq_gov_performance'

2007-08-01 Thread Gabriel C
Andrew Morton wrote: > On Wed, 1 Aug 2007 16:31:46 -0700 > "Miles Lane" <[EMAIL PROTECTED]> wrote: > >> LD .tmp_vmlinux1 >> drivers/built-in.o: In function `__cpufreq_governor': >> cpufreq.c:(.text+0xaf178): undefined reference to `cpufreq_gov_performance' >> cpufreq.c:(.text+0xaf18a):

Re: [PATCH 1/7] sysfs: fix locking in sysfs_lookup() and sysfs_rename_dir()

2007-08-01 Thread Greg KH
On Tue, Jul 31, 2007 at 07:15:08PM +0900, Tejun Heo wrote: > sd children list walking in sysfs_lookup() and sd renaming in > sysfs_rename_dir() were left out during i_mutex -> sysfs_mutex > conversion. Fix them. > > Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> Ok, to apply this, it messes with

Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())

2007-08-01 Thread Andrew Morton
On Thu, 2 Aug 2007 01:55:33 +0200 Jesper Juhl <[EMAIL PROTECTED]> wrote: > Greetings & Salutations, > > The Coverity checker spotted two potential memory leaks in > drivers/message/fusion/mptbase.c::mpt_attach(). > > There are two returns that may leak the storage allocated for > 'ioc'

Re: [PATCH -mm] Introduce strtol_check_range()

2007-08-01 Thread Satyam Sharma
On Thu, 2 Aug 2007, Satyam Sharma wrote: > On Wed, 1 Aug 2007, Alexey Dobriyan wrote: > > > On Tue, Jul 31, 2007 at 10:04:10PM +0530, Satyam Sharma wrote: > > > Callers (especially "store" functions for sysfs or configfs attributes) > > > that want to convert an input string to a number may

Re: [PATCH][RFC] unbreak generic futex_atomic_cmpxchg_inatomic() on UP

2007-08-01 Thread Mikael Pettersson
On Thu, 2 Aug 2007 01:49:02 +0200, Lennert Buytenhek wrote: > On Thu, Aug 02, 2007 at 01:00:21AM +0200, Mikael Pettersson wrote: > > > @@ -52,7 +53,34 @@ futex_atomic_op_inuser (int encoded_op, > > static inline int > > futex_atomic_cmpxchg_inatomic(int __user *uaddr, int oldval, int newval) >

[PATCH -mm] linux-audit list is subscribers-only

2007-08-01 Thread Gabriel C
Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTED]> --- --- linux-2.6.23-rc1-mm/MAINTAINERS.orig2007-08-02 01:51:40.0 +0200 +++ linux-2.6.23-rc1-mm/MAINTAINERS 2007-08-02 01:52:17.0 +0200 @@ -672,7 +672,7 @@ S: Maintained AUDIT SUBSYSTEM P: David Woodhouse

Re: drbd 8.0.2/3 doesn't load under kernel 2.6.21

2007-08-01 Thread Adrian Bunk
On Wed, Aug 01, 2007 at 07:02:14PM -0400, Maurice Volaski wrote: > First, did you confirm this behavior? Can you please explain that? How > could they possibly interact with one another? It's obvious when looking at the source code that both modules you are trying to use are buggy, and the sum

[PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())

2007-08-01 Thread Jesper Juhl
Greetings & Salutations, The Coverity checker spotted two potential memory leaks in drivers/message/fusion/mptbase.c::mpt_attach(). There are two returns that may leak the storage allocated for 'ioc' (sizeof(MPT_ADAPTER) bytes). A simple fix would be to simply add two kfree() calls before the

Re: cpufreq.c:(.text+0xaf178): undefined reference to `cpufreq_gov_performance'

2007-08-01 Thread Andrew Morton
On Wed, 1 Aug 2007 16:31:46 -0700 "Miles Lane" <[EMAIL PROTECTED]> wrote: > LD .tmp_vmlinux1 > drivers/built-in.o: In function `__cpufreq_governor': > cpufreq.c:(.text+0xaf178): undefined reference to `cpufreq_gov_performance' > cpufreq.c:(.text+0xaf18a): undefined reference to

Re: [PATCH] RT: Add priority-queuing and priority-inheritance to workqueue infrastructure

2007-08-01 Thread Gregory Haskins
On Thu, 2007-08-02 at 02:22 +0400, Oleg Nesterov wrote: > > No. > > > However, IIUC the point of flush_workqueue() is a barrier only relative > > to your own submissions, correct?. E.g. to make sure *your* requests > > are finished, not necessarily the entire queue. > > No, You sure are a

Re: [PATCH -mm 3/3] Freezer: Measure freezing time

2007-08-01 Thread Andrew Morton
On Wed, 1 Aug 2007 23:36:39 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > + do_gettimeofday(); > + elapsed_csecs64 = timeval_to_ns() - timeval_to_ns(); > + do_div(elapsed_csecs64, NSEC_PER_SEC / 100); > + elapsed_csecs = elapsed_csecs64; I'd have thought that we had

Re: [PATCH][RFC] unbreak generic futex_atomic_cmpxchg_inatomic() on UP

2007-08-01 Thread Lennert Buytenhek
On Thu, Aug 02, 2007 at 01:00:21AM +0200, Mikael Pettersson wrote: > @@ -52,7 +53,34 @@ futex_atomic_op_inuser (int encoded_op, > static inline int > futex_atomic_cmpxchg_inatomic(int __user *uaddr, int oldval, int newval) > { > +#ifdef CONFIG_SMP > return -ENOSYS; > +#else Since the

Re: [PATCH -mm 2/3] Freezer: Use wait queue instead of busy looping

2007-08-01 Thread Andrew Morton
On Wed, 1 Aug 2007 23:32:48 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > +/* > + * Used to notify try_to_freeze_tasks() that the refrigerator has been > entered > + * by a task. > + */ > +static int refrigerator_called; this is rather icky. - To unsubscribe from this list: send the

Re: SD still better than CFS for 3d ?(was Re: 2.6.23-rc1)

2007-08-01 Thread Kasper Sandberg
On Tue, 2007-07-31 at 10:57 +0200, Ingo Molnar wrote: > * Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > > On Tue, 2007-07-31 at 01:46 +0200, Kasper Sandberg wrote: > > > > > could perhaps be filesystem related, i have my maildir(extremely > > > large) on reiserfs, and /home on xfs. what my mail

Re: [patch -mm][Intel-IOMMU] Optimize sg map/unmap calls

2007-08-01 Thread Andrew Morton
On Wed, 1 Aug 2007 13:06:23 -0700 "Keshavamurthy, Anil S" <[EMAIL PROTECTED]> wrote: > +/* Computes the padding size required, to make the > + * the start address naturally aligned on its size > + */ > +static int > +iova_get_pad_size(int size, unsigned int limit_pfn) > +{ > + unsigned int

Re: 2.6.23-rc1-mm2

2007-08-01 Thread Mel Gorman
On (01/08/07 22:52), Torsten Kaiser didst pronounce: > On 8/1/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > On Wed, 01 Aug 2007 16:30:08 -0400 > > [EMAIL PROTECTED] wrote: > > > > > As an aside, it looks like bits of dynticks-for-x86_64 are in > > > there. > > > In particular,

Re: [PATCH -mm] Introduce strtol_check_range()

2007-08-01 Thread Satyam Sharma
Hi Alexey, On Wed, 1 Aug 2007, Alexey Dobriyan wrote: > On Tue, Jul 31, 2007 at 10:04:10PM +0530, Satyam Sharma wrote: > > Callers (especially "store" functions for sysfs or configfs attributes) > > that want to convert an input string to a number may often also want to > > check for simple

[PATCH]hpet and rtc max_user_freq predefine in Kconfig

2007-08-01 Thread [EMAIL PROTECTED]
I think users should be able to set max_user_freq values for rtc and hpet during kernel configuration. The default value is set to 1024 with this patch. The default value of 64 is really too small for modern multimedia apps. Besides, this patch fixes link on intel hpet spec. Signed-off-by:

[PATCH] scripts/ver_linux : correct printing of binutils version

2007-08-01 Thread Jesper Juhl
Hi, Currently scripts/ver_linux prints "Binutils" or other random information for the version number in the "binutils" output line on some distributions. This patch corrects that. When I initially submitted a patch to correct that, I was not aware that the output from "ld -v" could differ as

Re: 2.6.22: oops in sbp2_remove_device

2007-08-01 Thread Olaf Hering
On Wed, Aug 01, Stefan Richter wrote: > Revert commit 0555659d63c285ceb7ead3115532e1b71b0f27a7 from 2.6.22-rc1. > The dma_set_mask call somehow failed on a PowerMac G5, PPC64: > http://lkml.org/lkml/2007/8/1/344 This change fixes the oops, and I can access the drive again. - To unsubscribe from

Re: smaller kernel with no real time futexes

2007-08-01 Thread Jakub Jelinek
On Wed, Aug 01, 2007 at 09:24:34PM +0200, Andi Kleen wrote: > Adrian, > > You said earlier you're looking at smaller allnoconfig kernels. > One thing I noticed recently that realtime pi futexes are always > enabled and that pulls in a lot of other code (like the plists) > > Userland needs to

Re: drbd 8.0.2/3 doesn't load under kernel 2.6.21

2007-08-01 Thread Maurice Volaski
First, did you confirm this behavior? Can you please explain that? How could they possibly interact with one another? On Wed, Aug 01, 2007 at 04:21:29PM -0400, Maurice Volaski wrote: I'm making an assumption that depmod is somehow to blame and have logged this as a kernel bug,

[PATCH][RFC] unbreak generic futex_atomic_cmpxchg_inatomic() on UP

2007-08-01 Thread Mikael Pettersson
[Resend. I messed up the To: line the first time] As has been reported recently by Lennert Buytenhek, robust futexes are broken on ARM: >If you're also running into glibc's tst-robust1 test suite test >locking up your ARM machine, you're probably running into the fact >that asm-arm/futex.h

Re: [RFC] Deprecate a.out ELF interpreters

2007-08-01 Thread Andi Kleen
On Thursday 02 August 2007 00:14:48 Theodore Tso wrote: > Do you mean deprecate a.out interpreters? No, just a.out interpreters for ELF binaries. > I could imagine that there might be some people running some very old > statically linked programs from a decade or so ago, but I agree they > are

Re: [rfc] balance-on-fork NUMA placement

2007-08-01 Thread Martin Bligh
This topic seems to come up periodically every since we first introduced the NUMA scheduler, and every time we decide it's a bad idea. What's changed? What workloads does this improve (aside from some artificial benchmark like stream)? To repeat the conclusions of last time ... the primary

Re: LinuxPPS & spinlocks

2007-08-01 Thread Satyam Sharma
Hi, On Wed, 1 Aug 2007, Christopher Hoover wrote: > Satyam Sharma infradead.org> writes: > > On Mon, 30 Jul 2007, Rodolfo Giometti wrote: > > > > > On Mon, Jul 30, 2007 at 10:33:35AM +0530, Satyam Sharma wrote: > > > Currently the RFC says to you that you should open the serial port: > > > >

Re: [patch] sched: yield debugging

2007-08-01 Thread Tim Chen
On Tue, 2007-07-31 at 22:33 +0200, Ingo Molnar wrote: > ok, good! Could you try the updated debug patch below? I've done two > changes: made '1' the default, and added the > /proc/sys/kernel/sched_yield_granularity_ns tunable. (available if > CONFIG_SCHED_DEBUG=y) > > Could you try to change

Processes spinning forever, apparently in lock_timer_base()?

2007-08-01 Thread Chuck Ebbert
Looks like the same problem with spinlock unfairness we've seen elsewhere: it seems to be looping here? Or is everyone stuck just waiting for writeout? lock_timer_base(): for (;;) { tvec_base_t *prelock_base = timer->base; base =

Re: LinuxPPS & spinlocks

2007-08-01 Thread Christopher Hoover
Satyam Sharma infradead.org> writes: > On Mon, 30 Jul 2007, Rodolfo Giometti wrote: > > > On Mon, Jul 30, 2007 at 10:33:35AM +0530, Satyam Sharma wrote: > > Currently the RFC says to you that you should open the serial port: > > > > fd = open("/dev/ttyS0", ...); > > No, it does *NOT*. All

Re: drbd 8.0.2/3 doesn't load under kernel 2.6.21

2007-08-01 Thread Adrian Bunk
On Wed, Aug 01, 2007 at 04:21:29PM -0400, Maurice Volaski wrote: > I'm making an assumption that depmod is somehow to blame and have logged > this as a kernel bug, http://bugzilla.kernel.org/show_bug.cgi?id=8829 depmod is working fine. It's the interaction between your two patches that breaks

Re: More documentation: system call how-to

2007-08-01 Thread Heiko Carstens
On Wed, Aug 01, 2007 at 02:06:57PM -0400, Ulrich Drepper wrote: > I've added a few rules I could think of right now. What should be > added as well is a rule for 64-bit parameters on 32-bit platforms. I > leave this to the s390 people who have the biggest restrictions when > it comes to this.

Re: debugfs helper for decimal challenged

2007-08-01 Thread Greg KH
On Wed, Aug 01, 2007 at 05:52:58PM -0400, Robin Getz wrote: > Greg: > > For those of us who forget that when bits 21 and bit 31 in a hardware > register exposed with debugfs, I should see 2149580800 when I cat it (vs > 0x8020), any objections to providing a hex output interface to the >

Re: [PATCH] RT: Add priority-queuing and priority-inheritance to workqueue infrastructure

2007-08-01 Thread Oleg Nesterov
On 08/01, Gregory Haskins wrote: > > On Thu, 2007-08-02 at 01:34 +0400, Oleg Nesterov wrote: > > On 08/01, Gregory Haskins wrote: > > > > > > On Thu, 2007-08-02 at 00:50 +0400, Oleg Nesterov wrote: > > > > On 08/01, Daniel Walker wrote: > > > > > > > > > > It's translating priorities through the

[PATCH] Fix WARN_ON() on bitfield ops for all other archs

2007-08-01 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> Fixes WARN_ON() on bitfiels ops for all architectures that have been left out in 8d4fbcfbe0a4bfc73e7f0297c59ae514e1f1436f. Cc: Alexey Dobriyan <[EMAIL PROTECTED]> Cc: Herbert Xu <[EMAIL PROTECTED]> Cc: Paul Mundt <[EMAIL PROTECTED]> Cc: Haavard Skinnemoen

Re: VT_PROCESS, VT_LOCKSWITCH capabilities

2007-08-01 Thread Andrew Morton
On Wed, 01 Aug 2007 04:44:32 +0200 Frank Benkstein <[EMAIL PROTECTED]> wrote: > Frank Benkstein wrote: > > I wonder why there are different permissions needed for VT_PROCESS > > (access to the current virtual console) and VT_LOCKSWITCH > > (CAP_SYS_TTY_CONFIG). > > To be more direct: > >

Re: [RFC] Deprecate a.out ELF interpreters

2007-08-01 Thread Theodore Tso
Do you mean deprecate a.out interpreters? I could imagine that there might be some people running some very old statically linked programs from a decade or so ago, but I agree they are pretty small in number. Is the fs/binfmt_aout.c causing problems? It's only 562 lines of code...

[PATCH] qla2xxx: allocate enough space for the full PCI descriptor.

2007-08-01 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- On Thu, 26 Jul 2007, Andrew Vasquez wrote: > On Thu, 26 Jul 2007, Andrew Patterson wrote: > > > On Thu, 2007-07-26 at 15:36 +0200, Ulrich Windl wrote: > > > Hi, > > > > > > <6>QLogic

Re: [RFC 12/26] ext2 white-out support

2007-08-01 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Dave Kleikamp writes: > On Wed, 2007-08-01 at 15:33 -0400, Josef Sipek wrote: > > On Wed, Aug 01, 2007 at 02:10:31PM -0500, Dave Kleikamp wrote: > > > On Wed, 2007-08-01 at 14:44 -0400, Josef Sipek wrote: > > > > Now what? How do you rename? Do you rename in the

RE: [ck] Re: Linus 2.6.23-rc1 -- It does not matter who's code gets merged!

2007-08-01 Thread Arjan van de Ven
On Wed, 2007-08-01 at 11:40 -0700, Hua Zhong wrote: > > > And, from a standpoint of ONGOING, long-term innovation: what matters > > > is that brilliant, new ideas get rewarded one way or another. > > > > and in this case, the reward is that the idea got used and credit was > > given > > You

Re: [PATCH] RT: Add priority-queuing and priority-inheritance to workqueue infrastructure

2007-08-01 Thread Gregory Haskins
On Thu, 2007-08-02 at 01:34 +0400, Oleg Nesterov wrote: > On 08/01, Gregory Haskins wrote: > > > > On Thu, 2007-08-02 at 00:50 +0400, Oleg Nesterov wrote: > > > On 08/01, Daniel Walker wrote: > > > > > > > > It's translating priorities through the work queues, which doesn't seem > > > > to happen

Re: CS5530 Alsa driver fails

2007-08-01 Thread Alan Cox
> I will give up. I didn't checked code earlier. This driver is using SMM. > Probably > firmware isn't what it should be, or I have overwritten it when I was > flashing > Linux. I see in datasheet that it isn't possible to write driver in other > way. > Sadly sound card is generating SMI

[patch 0/1] extending low-level markers

2007-08-01 Thread nwatkins
Mathieu I have been working with your Kernel Markers infrastructure now for some time and have run into an extendability issue. Essentially I am failing to find a way to extend the current __trace_mark macro with site-specific context. That is, I would like the ability to create different

[patch 1/1] Adds flavor field to __mark_marker

2007-08-01 Thread nwatkins
This patch demonstrates an extension field to the low-level marker functionality, and updates macros to accept this additional data. Index: linux-2.6.22-rc6-mm1/include/linux/marker.h === ---

[git patches] IDE fixes

2007-08-01 Thread Bartlomiej Zolnierkiewicz
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/ to receive the following updates: drivers/ide/arm/icside.c |3 +- drivers/ide/ide-tape.c |2 +- drivers/ide/pci/alim15x3.c |2 +- drivers/ide/pci/cmd64x.c |4 +- drivers/ide/pci/cs5520.c

debugfs helper for decimal challenged

2007-08-01 Thread Robin Getz
Greg: For those of us who forget that when bits 21 and bit 31 in a hardware register exposed with debugfs, I should see 2149580800 when I cat it (vs 0x8020), any objections to providing a hex output interface to the debugfs? Since the input side already takes decimal & hex, I don't think

  1   2   3   4   5   6   7   8   9   10   >