Re: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware

2007-08-17 Thread Atsushi Nemoto
On Fri, 17 Aug 2007 17:37:01 +0200 (CEST), Jan Engelhardt <[EMAIL PROTECTED]> wrote: > >Most busses don't have managed device IDs like PCI, USB, or PNP. > > > >The platform, spi, and i2c busses use the driver name, which is > >obviously managed within the scope of all Linux drivers. > > > Yeah

Re: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware

2007-08-17 Thread David Brownell
On Friday 17 August 2007, Jan Engelhardt wrote: > >Most busses don't have managed device IDs like PCI, USB, or PNP. > > > >The platform, spi, and i2c busses use the driver name, which is > >obviously managed within the scope of all Linux drivers. > > > Yeah but that does not tell me why it needs

RE: [-mm PATCH] DMA engine kconfig improvements (rev2)

2007-08-17 Thread Nelson, Shannon
>From: Adrian Bunk [mailto:[EMAIL PROTECTED] >Sent: Thursday, August 16, 2007 5:48 PM >To: Nelson, Shannon >Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; >Williams, Dan J; [EMAIL PROTECTED] >Subject: Re: [-mm PATCH] DMA engine kconfig improvements (rev2) > >On Thu, Aug 16, 2007 at

Re: [PATCH 09/23] lib: percpu_counter_init error handling

2007-08-17 Thread Josef Sipek
On Thu, Aug 16, 2007 at 09:45:34AM +0200, Peter Zijlstra wrote: > alloc_percpu can fail, propagate that error. > > Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> > --- > fs/ext2/super.c| 11 --- > fs/ext3/super.c| 11 --- > fs/ext4/super.c

Re: [patch 3/4] Linux Kernel Markers - Documentation

2007-08-17 Thread Mathieu Desnoyers
* Frank Ch. Eigler ([EMAIL PROTECTED]) wrote: > > Mathieu Desnoyers <[EMAIL PROTECTED]> writes: > > > [...] > > +A marker placed in your code provides a hook to call a function (probe) > > that > > +you can provide at runtime. A marker can be "on" (a probe is connected to > > it) > > +or "off"

Re: [-mm PATCH 0/9] Memory controller introduction (v6)

2007-08-17 Thread Dhaval Giani
On Fri, Aug 17, 2007 at 02:12:28PM +0530, Balbir Singh wrote: Hi Andrew, > The code was also tested on a power box with regular machine usage scenarios, > the config disabled and with a stress suite that touched all the memory > in the system and was limited in a container. > > Dhaval ran

Re: [PATCH] lockdep: annotate rcu_read_{,un}lock()

2007-08-17 Thread Paul E. McKenney
On Fri, Aug 17, 2007 at 09:56:45AM +0200, Peter Zijlstra wrote: > On Thu, 2007-08-16 at 09:01 -0700, Paul E. McKenney wrote: > > On Thu, Aug 16, 2007 at 04:25:07PM +0200, Peter Zijlstra wrote: > > > > > > There seem to be some unbalanced rcu_read_{,un}lock() issues of late, > > > how about doing

Re: [PATCH] [428/2many] MAINTAINERS - SERIAL ATA (SATA) SUBSYSTEM:

2007-08-17 Thread Joe Perches
On Fri, 2007-08-17 at 19:45 +0400, Sergei Shtylyov wrote: > [EMAIL PROTECTED] wrote: > > Add file pattern to MAINTAINER entry > > +F: drivers/ata/sata_* > The libata core doesn't match this pattern, ain't a a vital part of both > SAT and PATA drivers? > MBR, Sergei Improvements to the

Re: Testing the Current Upstream Kernel

2007-08-17 Thread Dave Jones
On Fri, Aug 17, 2007 at 10:31:19AM -0400, Dave Jones wrote: > FWIW, you've been able to build the Fedora SRPMs with --with-vanilla > for a while now, which generates an RPM with no patches at all other > than the -rc/-git on which its based. > We're trying to work out logistics of which

Re: [PATCH 02/23] lib: percpu_counter_add

2007-08-17 Thread Josef Sipek
On Thu, Aug 16, 2007 at 09:45:27AM +0200, Peter Zijlstra wrote: ... > Index: linux-2.6/fs/ext2/balloc.c > === > --- linux-2.6.orig/fs/ext2/balloc.c > +++ linux-2.6/fs/ext2/balloc.c > @@ -163,7 +163,7 @@ static int

Re: [PATCH] [428/2many] MAINTAINERS - SERIAL ATA (SATA) SUBSYSTEM:

2007-08-17 Thread Sergei Shtylyov
Hello. [EMAIL PROTECTED] wrote: Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 04c969c..016cd0c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4077,6 +4077,7 @@ M:[EMAIL PROTECTED] L: [EMAIL

Re: [PATCH] select: fix sys_select to not leak ERESTARTNOHAND to userspace

2007-08-17 Thread John Blackwood
Hi Neil, We've been having problems with this select patch change. Specifically -- previously, when a ptrace attach was done to a task blocked in a select() call and that task had a timeout value, the task would restart the select() call with an updated timeout value. With this patch in place,

Re: Thinking outside the box on file systems

2007-08-17 Thread Valdis . Kletnieks
On Fri, 17 Aug 2007 11:19:21 EDT, Phillip Susi said: > Kyle Moffett wrote: >> Problem 1: "updating cached acls of descendent objects": How do you >> find out what a 'descendent object' is? Answer: You can't without >> recursing through the entire in-memory dentry tree. I suspect Kyle is not

Re: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware

2007-08-17 Thread Jan Engelhardt
On Aug 17 2007 08:23, David Brownell wrote: >On Friday 17 August 2007, Jan Engelhardt wrote: >> On Aug 17 2007 01:06, Atsushi Nemoto wrote: >> >Add an MODULE_ALIAS() to make this platform driver hotplug-aware. >> > >> >... >> >+MODULE_ALIAS("ds1742"); >> >> Why exactly is this needed? What

[PATCH] wait_task_zombie: don't fight with non-existing race with a dying ptracee

2007-08-17 Thread Oleg Nesterov
(textually depends on wait_task_zombie-remove-unneeded-child-signal-check.patch) The "p->exit_signal == -1 && p->ptrace == 0" check and the comment are bogus. We already did exactly the same check in eligible_child(), we did not drop tasklist_lock since then, and both variables need

Re: [Cluster-devel] Re: [gfs2][RFC] readdir caused ls process into D (uninterruptible) state, under testing with Samba 3.0.25

2007-08-17 Thread Steven Whitehouse
Hi, On Fri, 2007-08-17 at 15:43 +0800, rae l wrote: [some comments trimmed for brevity] > > > then I start a simple ls command on the gfs2 mouting point: > > > $ ls /mnt/gfs2 > > > the ls process is also changed to D state, > > > > > > I think it's problems about readdir implementation in gfs2,

Re: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware

2007-08-17 Thread David Brownell
On Friday 17 August 2007, Jan Engelhardt wrote: > On Aug 17 2007 01:06, Atsushi Nemoto wrote: > >Add an MODULE_ALIAS() to make this platform driver hotplug-aware. > > > >... > >+MODULE_ALIAS("ds1742"); > > Why exactly is this needed? What script refers to the module as ds1742 instead > of

Re: Thinking outside the box on file systems

2007-08-17 Thread Phillip Susi
Kyle Moffett wrote: Problem 1: "updating cached acls of descendent objects": How do you find out what a 'descendent object' is? Answer: You can't without recursing through the entire in-memory dentry tree. Such recursion is lock-intensive and has poor performance. Furthermore, you have to

Re: RFHelp: Splitting MAINTAINERS into maintainers/* and Makefile/Kconfig support

2007-08-17 Thread Joe Perches
On Fri, 2007-08-17 at 16:48 +0200, Sam Ravnborg wrote: > Adding a specific target på top-level Makefile is easy to > do so I assume you are looking for something more advanced? No, I'm looking for something simple. Perhaps something like: Makefile contents: all: [0-9a-z]* install: sh

Re: [linux-usb-devel] why was MODALIAS removed from usb kernel events? [u]

2007-08-17 Thread Andreas Jellinghaus [c]
Am Freitag, 17. August 2007 schrieb Alan Stern: > On Fri, 17 Aug 2007, Andreas Jellinghaus [c] wrote: > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit > >diff;h=9f8b17e643fe6aa505629658445849397bda4e4f > > > > removes MODALIAS from one of the events, this breaks user

Re: [PATCH] Isolate some explicit usage of task->tgid

2007-08-17 Thread Pavel Emelyanov
Oleg Nesterov wrote: On 08/17, Pavel Emelyanov wrote: Actually the p->tgid == pid has to be changed to has_group_leader_pid(), but Oleg pointed out that this is the same and thread_group_leader() is more preferable. No, no, sorry for confusion! I was not clear. I meant that

Re: Need help with modules loading

2007-08-17 Thread Larry Finger
Kay Sievers wrote: On 8/17/07, Larry Finger <[EMAIL PROTECTED]> wrote: A new driver for the Broadcom BCM43xx devices has been written that uses mac80211, rather than softmac. The newest versions of the Broadcom firmware does not support all the BCM devices. Accordingly, a separate driver is

Re: [linux-usb-devel] why was MODALIAS removed from usb kernel events? [u]

2007-08-17 Thread Alan Stern
On Fri, 17 Aug 2007, Andreas Jellinghaus [c] wrote: > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=9f8b17e643fe6aa505629658445849397bda4e4f > > removes MODALIAS from one of the events, this breaks user space applications > like openct - everything that depends

Re: RFHelp: Splitting MAINTAINERS into maintainers/* and Makefile/Kconfig support

2007-08-17 Thread Sam Ravnborg
Hi Joe. > > Perhaps with a little automation it could be revived, > > Which is the help I'm looking for. > > Can someone please help here on ideas or implementation > adding a makefile target for MAINTAINERS from files > in a specific subdirectory? Adding a specific target på top-level

Re: [PATCH] Isolate some explicit usage of task->tgid

2007-08-17 Thread Oleg Nesterov
On 08/17, Pavel Emelyanov wrote: > > Actually the p->tgid == pid has to be changed to has_group_leader_pid(), > but Oleg pointed out that this is the same and thread_group_leader() > is more preferable. No, no, sorry for confusion! I was not clear. I meant that thread_group_leader() is imho

why was MODALIAS removed from usb kernel events? [u]

2007-08-17 Thread Andreas Jellinghaus [c]
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=9f8b17e643fe6aa505629658445849397bda4e4f removes MODALIAS from one of the events, this breaks user space applications like openct - everything that depends on getting an event that has both the DEVICE= path to the

[PATCH][resend] i386: Fix a couple busy loops in mach_wakecpu.h:wait_for_init_deassert()

2007-08-17 Thread Satyam Sharma
On Fri, 17 Aug 2007, Satyam Sharma wrote: > On Fri, 17 Aug 2007, Andi Kleen wrote: > [...] > > [PATCH] i386, x86_64: __const_udelay() should not be marked inline Eek, this one wasn't quite right on both counts, (1) correctness of kernel/crash.c did not depend on __const_udelay() being

Re: Testing the Current Upstream Kernel

2007-08-17 Thread Dave Jones
On Thu, Aug 16, 2007 at 10:04:21AM -0400, [EMAIL PROTECTED] wrote: > On Thu, 16 Aug 2007 12:28:34 +0200, Susanne Oberhauser said: > > Jan Blunck <[EMAIL PROTECTED]> writes: > > > > > With our openSUSE Build Service we build a daily kernel, where we take > > > nightly snapshots of the current

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Paul E. McKenney
On Fri, Aug 17, 2007 at 01:09:08PM +0530, Satyam Sharma wrote: > > > On Thu, 16 Aug 2007, Paul E. McKenney wrote: > > > On Fri, Aug 17, 2007 at 07:59:02AM +0800, Herbert Xu wrote: > > > On Thu, Aug 16, 2007 at 09:34:41AM -0700, Paul E. McKenney wrote: > > > > > > > > The compiler can also

[PATCH] [SCSI] arcmsr: Fix error handling

2007-08-17 Thread Maik Hampel
Fixed error handling in queuecommand(), now all READ_ and WRITE_ commands are aborted in case of RAID is gone. Before only READ_6 and WRITE_6 commands were aborted. Signed-off-by: Maik Hampel <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c

Re: System call interposition/unprotecting the table

2007-08-17 Thread Dave Jones
On Wed, Aug 15, 2007 at 12:48:35AM +0200, Andi Kleen wrote: > > > In general the .data protection is only considered a debugging > > > feature. I don't know why Fedora enables it in their production > > > kernels. > > > > That would be because we think you are wrong 8) > > Well, it might

[PATCH] Isolate some explicit usage of task->tgid

2007-08-17 Thread Pavel Emelyanov
With pid namespaces this field is now dangerous to use explicitly, so hide it behind the helpers. Also the pid and pgrp fields o task_struct and signal_struct are to be deprecated. Unfortunately this patch cannot be sent right now as this leads to tons of warnings, so start isolating them,

Re: [kvm-devel] [PATCH/RFC 3/4]Introduce "account modifiers" mechanism

2007-08-17 Thread Laurent Vivier
Avi Kivity wrote: [...] > > The normal user/system accounting has the same issue, no? Whereever we > happen to land (kernel or user) gets the whole tick. > > So I think it is okay to have the same limitation for guest time. > So this is how it looks like. PATCH 1 and 2 are always a

Re: [PATCH] hostfs: Remove pointless if statement

2007-08-17 Thread Jeff Dike
On Fri, Aug 17, 2007 at 12:24:23PM +0530, Satyam Sharma wrote: > We normally use "comments" for that, not dead code that a compiler > then elids ;-) I'd argue that comments are for when you can't make the code self-explanatory. > [PATCH] hostfs: Remove pointless if statement > > And replace

Re: [kvm-devel] [PATCH/RFC 3/4]Introduce "account modifiers" mechanism

2007-08-17 Thread Christian Borntraeger
Am Freitag, 17. August 2007 schrieb Laurent Vivier: > > The normal user/system accounting has the same issue, no? Whereever we > > happen to land (kernel or user) gets the whole tick. > > Yes... but perhaps I should rewrite this too ;-) If you look further, you will see, that this was actually

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Satyam Sharma
On Fri, 17 Aug 2007, Nick Piggin wrote: > Satyam Sharma wrote: > > > On Fri, 17 Aug 2007, Nick Piggin wrote: > > > > > Because they should be thinking about them in terms of barriers, over > > > which the compiler / CPU is not to reorder accesses or cache memory > > > operations, rather than

[PATCH -mm] PNP: Make pnpacpi_suspend handle errors

2007-08-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki <[EMAIL PROTECTED]> pnpacpi_suspend() doesn't check the result returned by acpi_pm_device_sleep_state() before passing it to acpi_bus_set_power(), which may not be desirable.  Make it select the target power state of the device using its second argument if

[PATCH -mm] x86_64: Save registers in saved_context during suspend and hibernation

2007-08-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki <[EMAIL PROTECTED]> During hibernation and suspend on x86_64 save CPU registers in the saved_context structure rather than in a handful of separate variables. Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]> Looks-ok-to: Pavel Machek <[EMAIL PROTECTED]> ---

Re: [kvm-devel] [PATCH/RFC 4/4, second shot]KVM uses "account_guest_time()"

2007-08-17 Thread Laurent Vivier
Avi Kivity wrote: > Laurent Vivier wrote: >> KVM updates vtime in task_struct to allow account_guest_time() to modify >> user, >> system and guest time in cpustat accordingly. >> > >> --- kvm.orig/drivers/kvm/Kconfig 2007-08-17 10:24:46.0 +0200 >> +++ kvm/drivers/kvm/Kconfig

Re: [kvm-devel] [PATCH/RFC 3/4]Introduce "account modifiers" mechanism

2007-08-17 Thread Laurent Vivier
Avi Kivity wrote: > Laurent Vivier wrote: >>> - remove PATCH 3, and add in task_struct a "ktime vtime" where we accumulate guest time (by calling something like guest_enter() and guest_exit() from the virtualization engine), and when in account_system_time() we have

Re: [patch] encapsulate uevent()/add_uevent_var() buffer handling

2007-08-17 Thread Cornelia Huck
On Tue, 14 Aug 2007 15:15:12 +0200, Kay Sievers <[EMAIL PROTECTED]> wrote: > From: Kay Sievers <[EMAIL PROTECTED]> > Subject: Driver core: change add_uevent_var to use a struct This still needs some (trivial) s390 fixes: Signed-off-by: Cornelia Huck <[EMAIL PROTECTED]> ---

Re: [kvm-devel] [PATCH/RFC 4/4, second shot]KVM uses "account_guest_time()"

2007-08-17 Thread Avi Kivity
Laurent Vivier wrote: > KVM updates vtime in task_struct to allow account_guest_time() to modify user, > system and guest time in cpustat accordingly. > > --- kvm.orig/drivers/kvm/Kconfig 2007-08-17 10:24:46.0 +0200 > +++ kvm/drivers/kvm/Kconfig 2007-08-17 10:25:25.0

Re: [kvm-devel] [PATCH/RFC 3/4, second shot]Introduce "account_guest_time"

2007-08-17 Thread Avi Kivity
Laurent Vivier wrote: > This is another way to compute guest time... I remove the "account modifiers" > mechanism and call directly account_guest_time() from account_system_time(). > account_system_time() computes user, system and guest times according value > accumulated in vtime (a ktime_t) in

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Nick Piggin
Satyam Sharma wrote: On Fri, 17 Aug 2007, Nick Piggin wrote: Satyam Sharma wrote: On Fri, 17 Aug 2007, Nick Piggin wrote: Satyam Sharma wrote: It is very obvious. msleep calls schedule() (ie. sleeps), which is always a barrier. Probably you didn't mean that, but no, schedule() is not

Re: [kvm-devel] [PATCH/RFC 3/4]Introduce "account modifiers" mechanism

2007-08-17 Thread Avi Kivity
Laurent Vivier wrote: >> >>> - remove PATCH 3, and add in task_struct a "ktime vtime" where we accumulate >>> guest time (by calling something like guest_enter() and guest_exit() from >>> the >>> virtualization engine), and when in account_system_time() we have cputime > >>> vtime we

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Satyam Sharma
On Fri, 17 Aug 2007, Nick Piggin wrote: > Satyam Sharma wrote: > [...] > > You think both these are equivalent in terms of "looks": > > > > | > > while (!atomic_read()) { | while (!atomic_read_xxx()) { > > ... |

Marvell 88E8056 gigabit ethernet controller

2007-08-17 Thread Kevin E
Hi all, I've read where the onboard Marvell lan controller on some Gigabyte boards don't work. I've got two systems using the same Gigabyte board, on one the LAN works on the other it dies like described by others. Here's the systems: Working system: Gigabyte 965P-DS3 rev 3.3 (BIOS

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Satyam Sharma
On Fri, 17 Aug 2007, Nick Piggin wrote: > Satyam Sharma wrote: > > On Fri, 17 Aug 2007, Nick Piggin wrote: > > > Satyam Sharma wrote: > > > > > > It is very obvious. msleep calls schedule() (ie. sleeps), which is > > > always a barrier. > > > > Probably you didn't mean that, but no,

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Nick Piggin
Satyam Sharma wrote: On Fri, 17 Aug 2007, Nick Piggin wrote: Because they should be thinking about them in terms of barriers, over which the compiler / CPU is not to reorder accesses or cache memory operations, rather than "special" "volatile" accesses. This is obviously just a taste

Re: [PATCH 000 of 6] A few block-layer tidy-up patches.

2007-08-17 Thread Jens Axboe
On Fri, Aug 17 2007, Neil Brown wrote: > On Friday August 17, [EMAIL PROTECTED] wrote: > > > > Please inspect the #block-2.6.24 branch to see the result. > > > > > > I don't know where to look for this. I checked > > > http://git.kernel.org/?p=linux/kernel/git/axboe/linux-2.6-block.git > > >

Re: Corrupted filesystem with new Firewire stack

2007-08-17 Thread Martin K. Petersen
> "Stefan" == Stefan Richter <[EMAIL PROTECTED]> writes: Stefan> There were some similar reports involving that "status write Stefan> for unknown orb". I haven't found a way to reproduce it; I Stefan> noticed it only once in the logs here so far. I get those all the time. Just do heavy

Re: RFHelp: Splitting MAINTAINERS into maintainers/* and Makefile/Kconfig support

2007-08-17 Thread Joe Perches
On Fri, 2007-08-17 at 02:25 -0400, Chris Snook wrote: > The whole point of MAINTAINERS is to have one central repository for this > information, instead of scattering it throughout the various source files. > If > that file is getting too unwieldy (and I don't think it is) then I could >

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Nick Piggin
Satyam Sharma wrote: On Fri, 17 Aug 2007, Nick Piggin wrote: I think they would both be equally ugly, You think both these are equivalent in terms of "looks": | while (!atomic_read()) { | while (!atomic_read_xxx()) { ...

Re: [PATCH] Make checkpatch rant about trailing ; at the end of "if" expr

2007-08-17 Thread Jan Engelhardt
On Aug 16 2007 10:21, Andy Whitcroft wrote: >> +if ($line =~ /\bif\s*\([^\)]*\)\s*\;/) { > >Heh, you are the second person to suggest this check today, do I detect >some ripped out hair due to one of these! > >I've taken this idea and expanded it to cover if, for and while which >can

Re: [2.6.23-rc3] NFSv4 client oops

2007-08-17 Thread Trond Myklebust
On Wed, 2007-08-15 at 18:08 -0400, Jeff Garzik wrote: > While upgrading nfs-utils on my NFSv4 file server (F7 x86-64 > 2.6.23-rc3), I got an oops on the NFSv4 client (FC6 x86-64 2.6.23-rc3), > and communications stopped. > > I rebooted the client, and everything was fine again. Then, on the >

Re: [PATCH/RFC 4/4, second shot]KVM uses "account_guest_time()"

2007-08-17 Thread Laurent Vivier
KVM updates vtime in task_struct to allow account_guest_time() to modify user, system and guest time in cpustat accordingly. Index: kvm/drivers/kvm/Kconfig === --- kvm.orig/drivers/kvm/Kconfig2007-08-17 10:24:46.0

[PATCH/RFC 3/4, second shot]Introduce "account_guest_time"

2007-08-17 Thread Laurent Vivier
This is another way to compute guest time... I remove the "account modifiers" mechanism and call directly account_guest_time() from account_system_time(). account_system_time() computes user, system and guest times according value accumulated in vtime (a ktime_t) in task_struct by the virtual

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Nick Piggin
Satyam Sharma wrote: On Fri, 17 Aug 2007, Nick Piggin wrote: Satyam Sharma wrote: It is very obvious. msleep calls schedule() (ie. sleeps), which is always a barrier. Probably you didn't mean that, but no, schedule() is not barrier because it sleeps. It's a barrier because it's

Re: [PATCH] NOMMU: Separate out VMAs

2007-08-17 Thread Bernd Schmidt
David Howells wrote: David Howells <[EMAIL PROTECTED]> wrote: Yes. I found the major leak this morning. There may be a minor leak, but I'm not convinced it's in the mmap stuff. See revised patch. Oops. That was the old patch. Try this one instead. Here are some changes to make it

Re: Unable to handle kernel NULL pointer dereference at 0000000000000001 RIP

2007-08-17 Thread Jiri Kosina
On Fri, 17 Aug 2007, Andreas Moroder wrote: > our SLES production system 2.6.5-7.252-smp #1 SMP Tue Feb 14 11:11:04 > UTC 2006 x86_64 x86_64 x86_64 stopped with the following messages in the > log Is this a known bug in this version and is it solved in the next > versions. Hi, this is

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Stefan Richter
Nick Piggin wrote: > Satyam Sharma wrote: >> And we have driver / subsystem maintainers such as Stefan >> coming up and admitting that often a lot of code that's written to use >> atomic_read() does assume the read will not be elided by the compiler. > > So these are broken on i386 and x86-64?

Unable to handle kernel NULL pointer dereference at 0000000000000001 RIP

2007-08-17 Thread Andreas Moroder
Hello, our SLES production system 2.6.5-7.252-smp #1 SMP Tue Feb 14 11:11:04 UTC 2006 x86_64 x86_64 x86_64 stopped with the following messages in the log Is this a known bug in this version and is it solved in the next versions. As I wrote it is a production server so I can't change away from

Re: nanosleep() accuracy

2007-08-17 Thread Michal Schmidt
GolovaSteek wrote: > 2007/8/17, Michal Schmidt <[EMAIL PROTECTED]>: > >> GolovaSteek skrev: >> >>> Hello! >>> I need use sleep with accurat timing. >>> I use 2.6.21 with rt-prempt patch. >>> with enabled rt_preempt, dyn_ticks, and local_apic >>> But >>> >>> req.tv_nsec = 30; >>>

Re: [PATCH]: proc: export a processes resource limits via proc/

2007-08-17 Thread Neil Horman
On Fri, Aug 17, 2007 at 04:09:26AM -0400, [EMAIL PROTECTED] wrote: > On Thu, 16 Aug 2007 08:35:38 EDT, Neil Horman said: > > Hey again- > > Andrew requested that I repost this cleanly, after running the patch > > through checkpatch. As requested here it is with the changelog. > > > >

Re: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware

2007-08-17 Thread Jan Engelhardt
On Aug 17 2007 01:06, Atsushi Nemoto wrote: >Add an MODULE_ALIAS() to make this platform driver hotplug-aware. > >Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> >--- >diff --git a/drivers/rtc/rtc-ds1742.c b/drivers/rtc/rtc-ds1742.c >index b2e5481..4bd22dc 100644 >--- a/drivers/rtc/rtc-ds1742.c

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Stefan Richter
I wrote: > Nick Piggin wrote: >> You might find that these places that appear to need barriers are >> buggy for other reasons anyway. Can you point to some in-tree code >> we can have a look at? > > I could, or could not, if I were through with auditing the code. I > remembered one case and

Re: [patch] add kdump_after_notifier

2007-08-17 Thread Vivek Goyal
On Thu, Aug 16, 2007 at 06:26:35PM +0900, Takenori Nagano wrote: > Vivek Goyal wrote: > > So for the time being I think we can put RAS tools on die notifier list > > and if it runs into issues we can always think of creating a separate list. > > > > Few things come to mind. > > > > - Why there

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Stefan Richter
Nick Piggin wrote: > Stefan Richter wrote: >> For architecture port authors, there is Documentation/atomic_ops.txt. >> Driver authors also can learn something from that document, as it >> indirectly documents the atomic_t and bitops APIs. > > "Semantics and Behavior of Atomic and Bitmask

Re: [another git patch] move USB net drivers to drivers/net

2007-08-17 Thread Jan Engelhardt
Hi, On May 10 2007 18:12, Jan Engelhardt wrote: >Subject: Re: [another git patch] move USB net drivers to drivers/net > >Hi Jeff, > > >On May 9 2007 21:38, Jeff Garzik wrote: >>diff --git a/drivers/net/Makefile b/drivers/net/Makefile >>index 59c0459..c5d8423 100644 >>--- a/drivers/net/Makefile

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Satyam Sharma
On Fri, 17 Aug 2007, Nick Piggin wrote: > Satyam Sharma wrote: > > [...] > > The point is about *author expecations*. If people do expect atomic_read() > > (or a variant thereof) to have volatile semantics, why not give them such > > a variant? > > Because they should be thinking about them in

recursive use of bust_spinlocks()

2007-08-17 Thread Jan Beulich
Various architectures may call bust_spinlocks() recursively (when calling die() in the context do an unresolved page fault); the function itself, however, doesn't appear to be meant to be called in this manner. Nevertheless, this doesn't appear to be a problem as long as bust_spinlocks(0) doesn't

Re: nf_conntrack_ipv4 must be loaded explicitly

2007-08-17 Thread Jan Engelhardt
On Aug 2 2007 20:33, Patrick McHardy wrote: >> End result: >> >> After loading nf_conntrack_ipv4.ko, everything works again (also with the >> "bad" ff09b7). But I have to load it explicitly, and I think that >> unfortunately breaks a lot of setups (such as mine) which assume ipv4 >> connection

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Satyam Sharma
On Fri, 17 Aug 2007, Paul Mackerras wrote: > Satyam Sharma writes: > > > I wonder if this'll generate smaller and better code than _both_ the > > other atomic_read_volatile() variants. Would need to build allyesconfig > > on lots of diff arch's etc to test the theory though. > > I'm sure it

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Satyam Sharma
On Fri, 17 Aug 2007, Nick Piggin wrote: > Satyam Sharma wrote: > > > > On Fri, 17 Aug 2007, Nick Piggin wrote: > > > > Also, why would you want to make these insane accessors for atomic_t > > > types? Just make sure everybody knows the basics of barriers, and they > > > can apply that

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Satyam Sharma
On Fri, 17 Aug 2007, Andi Kleen wrote: > On Friday 17 August 2007 05:42, Linus Torvalds wrote: > > On Fri, 17 Aug 2007, Paul Mackerras wrote: > > > I'm really surprised it's as much as a few K. I tried it on powerpc > > > and it only saved 40 bytes (10 instructions) for a G5 config. > > > >

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Satyam Sharma
On Fri, 17 Aug 2007, Nick Piggin wrote: > Satyam Sharma wrote: > > > > On Fri, 17 Aug 2007, Nick Piggin wrote: > > > > > Sure, now > > > > that I learned of these properties I can start to audit code and insert > > > > barriers where I believe they are needed, but this simply means that > > >

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Paul Mackerras
Satyam Sharma writes: > I wonder if this'll generate smaller and better code than _both_ the > other atomic_read_volatile() variants. Would need to build allyesconfig > on lots of diff arch's etc to test the theory though. I'm sure it would be a tiny effect. This whole thread is arguing about

Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel

2007-08-17 Thread Miguel Ojeda
Btw, at: diff -uprN -X linux-2.6.22-base/Documentation/dontdiff linux-2.6.22-base/security/smack/Kconfig linux-2.6.22/security/smack/Kconfig --- linux-2.6.22-base/security/smack/Kconfig1969-12-31 16:00:00.0 -0800 +++ linux-2.6.22/security/smack/Kconfig 2007-07-10 01:08:05.0

[PATCH 2.6.22.3] ppp: fix output buffer size in ppp_decompress_frame

2007-08-17 Thread Konstantin Sharlaimov
This patch addresses the issue with "osize too small" errors in mppe encryption. The patch fixes the issue with wrong output buffer size being passed to ppp decompression routine. Signed-off-by: Konstantin Sharlaimov <[EMAIL PROTECTED]> --- As pointed out by Suresh Mahalingam, the issue addressed

[RFC][PATCH] maps: show swapped out pages in smaps

2007-08-17 Thread Fengguang Wu
Show the amount of swapped out pages in /proc//smaps. Currently there's no way to know who is using the swap file. A possible better way to support it is to add a new counter to struct_mm. Or maybe not that important at all? Signed-off-by: Fengguang Wu <[EMAIL PROTECTED]> --- fs/proc/task_mmu.c

[PATCH] Use find_task_by_pid_ns() in places that operate with virtual pids

2007-08-17 Thread Pavel Emelyanov
When the pid comes from the userspace, the find_task_by_pid_ns() should be used to find the task by pid in particular (usually the current) namespace. These places were lost in earlier patches. Think over: all these places work like this: if (pid == 0) task = current;

[PATCH] Fix the return value of sys_set_tid_address()

2007-08-17 Thread Pavel Emelyanov
This call should return the virtual pid to the caller, just like the sys_getpid()/sys_gettid() do, no the global one. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Cc: Sukadev Bhattiprolu <[EMAIL PROTECTED]> Cc: Oleg Nesterov <[EMAIL

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Nick Piggin
Satyam Sharma wrote: On Fri, 17 Aug 2007, Nick Piggin wrote: Satyam Sharma wrote: [...] Granted, the above IS buggy code. But, the stated objective is to avoid heisenbugs. ^^ Anyway, why are you making up code snippets that are buggy in other ways in order to support this

[PATCH] Fix check for return value of create_pid_namespace

2007-08-17 Thread Pavel Emelyanov
The function in question returns ERR_PTR-s to indicate the error, while the caller checks for return value to be NULL. Found during testing the OpenVZ kernel with pid namespaces. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Cc: Sukadev

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Nick Piggin
Satyam Sharma wrote: On Fri, 17 Aug 2007, Nick Piggin wrote: Also, why would you want to make these insane accessors for atomic_t types? Just make sure everybody knows the basics of barriers, and they can apply that knowledge to atomic_t and all other lockless memory accesses as well.

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Nick Piggin
Satyam Sharma wrote: On Fri, 17 Aug 2007, Nick Piggin wrote: Sure, now that I learned of these properties I can start to audit code and insert barriers where I believe they are needed, but this simply means that almost all occurrences of atomic_read will get barriers (unless there already

Re: [PATCH/RFC 3/4]Introduce "account modifiers" mechanism

2007-08-17 Thread Laurent Vivier
Rusty Russell wrote: > On Fri, 2007-08-17 at 09:35 +0200, Laurent Vivier wrote: >> Rusty Russell wrote: >>> Hi Laurent, >> Hi Rusty, >> how are your puppies ? > > They're getting a little fat, actually. Too many features ... > >> - remove PATCH 3, and add in task_struct a "ktime vtime" where we

Re: Fork Bombing Patch

2007-08-17 Thread Paul Jackson
I agree that (1) one risks overdoing comments and (2) one should minimize comments inside a function body. But I read your earlier statement: Please do not add comments inside functions. as simply requesting no comments inside function bodies, without exception. That seems to me to be too

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Satyam Sharma
On Fri, 17 Aug 2007, Nick Piggin wrote: > Satyam Sharma wrote: > [...] > > Granted, the above IS buggy code. But, the stated objective is to avoid > > heisenbugs. ^^ > Anyway, why are you making up code snippets that are buggy in other > ways in order to support this assertion

[-mm PATCH 3/9] Memory controller accounting setup (v6)

2007-08-17 Thread Balbir Singh
From: Pavel Emelianov <[EMAIL PROTECTED]> Changelog for v5 1. Remove inclusion of memcontrol.h from mm_types.h Changelog As per Paul's review comments 1. Drop css_get() for the root memory container 2. Use mem_container_from_task() as an optimization instead of using

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Andi Kleen
On Friday 17 August 2007 05:42, Linus Torvalds wrote: > On Fri, 17 Aug 2007, Paul Mackerras wrote: > > I'm really surprised it's as much as a few K. I tried it on powerpc > > and it only saved 40 bytes (10 instructions) for a G5 config. > > One of the things that "volatile" generally screws up is

[-mm PATCH 6/9] Memory controller add per container LRU and reclaim (v6)

2007-08-17 Thread Balbir Singh
Changelog since v3 1. Added reclaim retry logic to avoid being OOM'ed due to pages from swap cache (coming in due to reclaim) don't overwhelm the container. Changelog 1. Fix probable NULL pointer dereference based on review comments by YAMAMOTO Takashi Add the page_container to the per

[-mm PATCH 8/9] Memory controller add switch to control what type of pages to limit (v6)

2007-08-17 Thread Balbir Singh
Choose if we want cached pages to be accounted or not. By default both are accounted for. A new set of tunables are added. echo -n 1 > mem_control_type switches the accounting to account for only mapped pages echo -n 3 > mem_control_type switches the behaviour back Signed-off-by: <[EMAIL

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Satyam Sharma
On Fri, 17 Aug 2007, Nick Piggin wrote: > Stefan Richter wrote: > [...] > Just use spinlocks if you're not absolutely clear about potential > races and memory ordering issues -- they're pretty cheap and simple. I fully agree with this. As Paul Mackerras mentioned elsewhere, a lot of authors

[-mm PATCH 9/9] Memory controller make page_referenced() container aware (v6)

2007-08-17 Thread Balbir Singh
Make page_referenced() container aware. Without this patch, page_referenced() can cause a page to be skipped while reclaiming pages. This patch ensures that other containers do not hold pages in a particular container hostage. It is required to ensure that shared pages are freed from a container

[-mm PATCH 7/9] Memory controller OOM handling (v6)

2007-08-17 Thread Balbir Singh
From: Pavel Emelianov <[EMAIL PROTECTED]> Out of memory handling for containers over their limit. A task from the container over limit is chosen using the existing OOM logic and killed. TODO: 1. As discussed in the OLS BOF session, consider implementing a user space policy for OOM handling.

[-mm PATCH 2/9] Memory controller containers setup (v6)

2007-08-17 Thread Balbir Singh
Changelong 1. use depends instead of select in init/Kconfig 2. Port to v11 3. Clean up the usage of names (container files) for v11 Setup the memory container and add basic hooks and controls to integrate and work with the container. Signed-off-by: <[EMAIL PROTECTED]> ---

[-mm PATCH 0/9] Memory controller introduction (v6)

2007-08-17 Thread Balbir Singh
Here's version 6 of the memory controller (against 2.6.23-rc2-mm2). The tests that were run has been included in the _Test Results section_ below. Changelog since version 5 1. Ported to 2.6.23-rc2-mm2 2. Added a css_put() in the case of race between allocation of page_containers (YAMAMOTO

[-mm PATCH 4/9] Memory controller memory accounting (v6)

2007-08-17 Thread Balbir Singh
Changelog for v6 1. Do a css_put() in the case of a race in allocating page containers (YAMAMOTO Takashi) Changelog for v5 1. Rename meta_page to page_container 2. Remove PG_metapage and use the lower bit of the page_container pointer for locking Changelog for v3 1. Fix a probable leak

[-mm PATCH 1/9] Memory controller resource counters (v6)

2007-08-17 Thread Balbir Singh
From: Pavel Emelianov <[EMAIL PROTECTED]> Introduce generic structures and routines for resource accounting. Each resource accounting container is supposed to aggregate it, container_subsystem_state and its resource-specific members within. Signed-off-by: Pavel Emelianov <[EMAIL PROTECTED]>

<    1   2   3   4   5   6   7   >