[PATCH] Remove unneeded pointer intf from speedtch_upload_firmware() in drivers/usb/atm/speedtch.c

2007-09-04 Thread Micah Gruber
This trivial patch removes the unneeded pointer intf returned from usb_ifnum_to_if(), which is never used. The check for NULL can be simply done by if (!usb_ifnum_to_if(usb_dev, 2)). Signed-off-by: Micah Gruber <[EMAIL PROTECTED]> --- --- a/drivers/usb/atm/speedtch.c2007-09-04

[PATCH] Remove unneeded pointer newdp from dccp_v4_request_recv_sock() in net/dccp/ipv4.c

2007-09-04 Thread Micah Gruber
This trivial patch removes the unneeded pointer newdp, which is never used. Signed-off-by: Micah Gruber <[EMAIL PROTECTED]> --- --- a/net/dccp/ipv4.c 2007-09-04 23:18:42.0 +0800 +++ b/net/dccp/ipv4.c 2007-09-05 00:49:54.0 +0800 @@ -381,7 +381,6 @@ { struct

[PATCH] Remove unneeded pointer iph from ipcomp6_input() in net/ipv6/ipcomp6.c

2007-09-04 Thread Micah Gruber
This trivial patch removes the unneeded pointer iph, which is never used. Signed-off-by: Micah Gruber < [EMAIL PROTECTED]> --- --- a/net/ipv6/ipcomp6.c2007-09-04 23:18:43.0 +0800 +++ b/net/ipv6/ipcomp6.c2007-09-05 00:48:05.0 +0800 @@ -65,7 +65,6 @@ static int

Re: [ANNOUNCE] Lguest64 - fatter puppies!

2007-09-04 Thread H. Peter Anvin
Steven Rostedt wrote: This is a formal announcement of Lguest64. Most are aware of the little puppies (lguest32, or simply lguest, or in some circles "rustyvisor"). But this time the puppies ate a bit too much. No more lean and mean puppies, now we got big fat lazy ones. Running on the

Re: tbench regression - Why process scheduler has impact on tbench and why small per-cpu slab (SLUB) cache creates the scenario?

2007-09-04 Thread Zhang, Yanmin
On Tue, 2007-09-04 at 20:59 -0700, Christoph Lameter wrote: > On Wed, 5 Sep 2007, Zhang, Yanmin wrote: > > > 8) kmalloc-4096 order is 1 which means one slab consists of 2 objects. So a > > You can change that by booting with slub_max_order=0. Then we can also use > the per cpu queues to get

2.6.23.rc5: Problem with procfs -- schedstat

2007-09-04 Thread Ph. Marek
Hello everybody, I found a problem in /proc/self/schedstat: a simple "cat" can give "wrong" results. /proc# cat self/schedstat 91117 26027 2 /proc# cat self/schedstat 90691 27872 2 /proc# cat self/schedstat 995483 15675 3 /proc# cat

Re: [PATCH] Add support for keyboard on SEGA Dreamcast

2007-09-04 Thread Dmitry Torokhov
Hi Mike, On Wednesday 05 September 2007 00:34, Mike Frysinger wrote: > > + kbd->dev = input_allocate_device(); > > ... > > + retval = input_register_device(kbd->dev); > > + if (unlikely(retval)) > > + goto cleanup; > > ... > > +      cleanup: > > + kfree(kbd); > > +

Re: [PATCH] Add support for keyboard on SEGA Dreamcast

2007-09-04 Thread Mike Frysinger
On Tuesday 04 September 2007, Adrian McMenamin wrote: > --- a/drivers/input/keyboard/Kconfig > +++ b/drivers/input/keyboard/Kconfig > + Say Y here if you have a DreamCast console running Linux and have funny caps in Dreamcast > --- /dev/null > +++ b/drivers/input/keyboard/maple_keyb.c >

Re: Fwd: [PATCH] IdealTEK URTC1000 support for usbtouchscreen

2007-09-04 Thread Dmitry Torokhov
On Monday 27 August 2007 18:07, Daniel Ritz wrote: > > OK, so here's the new patch, inline this time: > > thanks. looks fine now. forwarding to Dmitry for mainline inclusion... > Applied, thank you. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH] 10-dots braille keyboards

2007-09-04 Thread Dmitry Torokhov
On Monday 20 August 2007 20:38, Samuel Thibault wrote: > Hi, > > Some braille keyboards have 10 dots, so extend the Input braille keys > definitions. > > Signed-off-by: Samuel Thibault <[EMAIL PROTECTED]> > Applied, thank you Samuel. -- Dmitry - To unsubscribe from this list: send the line

Re: [PATCH] Input: i8042 - add HP Pavilion DV4270ca to the MUX blacklist

2007-09-04 Thread Dmitry Torokhov
On Monday 03 September 2007 17:47, Elvis Pranskevichus wrote: > This fixes "atkbd.c: Suprious NAK on isa0060/serio0" errors for > HP Pavilion DV4270ca. Same reasons as for > 9d9d50bb2efb50594abfc3941a5504b62c514ebd > and 6e782584e0713ea89da151333e7fe754c8f40324. > > Signed-off-by: Elvis

Re: ALPS touchpad with new Dell not recognised

2007-09-04 Thread Dmitry Torokhov
Hi, On Saturday 04 August 2007 18:45, William Pettersson wrote: > Hi, > This patch adds support for the Alps touchpad on my Dell Vostro 1400 to > the linux kernel. > > Signed-off-by: William Pettersson <[EMAIL PROTECTED]> Applied, thank you William. -- Dmitry - To unsubscribe from this list:

[PATCH] docproc: style & typo cleanups

2007-09-04 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> - fix typos/spellos in docproc.c and Makefile - add a little whitespace {while, switch} (coding style) - use NULL instead of 0 for pointer testing Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- scripts/basic/Makefile |8

Re: tbench regression - Why process scheduler has impact on tbench and why small per-cpu slab (SLUB) cache creates the scenario?

2007-09-04 Thread Christoph Lameter
On Wed, 5 Sep 2007, Zhang, Yanmin wrote: > 8) kmalloc-4096 order is 1 which means one slab consists of 2 objects. So a You can change that by booting with slub_max_order=0. Then we can also use the per cpu queues to get these order 0 objects which may speed up the allocations because we do not

Re: [PATCH 3/6] x86: Convert cpu_sibling_map to be a per cpu variable (v2) (fwd)

2007-09-04 Thread Christoph Lameter
On Tue, 4 Sep 2007, Andrew Morton wrote: > > My question though, would include/linux/smp.h be the appropriate place for > > the above define? (That is, if the above approach is the correct one... ;-) > > It'd be better to convert the unconverted architectures? That is certainly the cleanest

Re: [PATCH] Add support for keyboard on SEGA Dreamcast

2007-09-04 Thread Dmitry Torokhov
Hi Adrian, On Tuesday 04 September 2007 19:34, Adrian McMenamin wrote: > This patch will add support for the Dreamcast keyboard when used > alongside the maple bus patch (http://lkml.org/lkml/2007/9/4/165) and > the pvr2 patch. > > Signed off by: Adrian McMenamin <[EMAIL PROTECTED]> > Thnank

[ANNOUNCE] Lguest64 - fatter puppies!

2007-09-04 Thread Steven Rostedt
This is a formal announcement of Lguest64. Most are aware of the little puppies (lguest32, or simply lguest, or in some circles "rustyvisor"). But this time the puppies ate a bit too much. No more lean and mean puppies, now we got big fat lazy ones. Running on the hardware that's too lazy to do

Re: [GIT PULL] x86 setup: work around bug in Xen HVM

2007-09-04 Thread H. Peter Anvin
Christoph Hellwig wrote: On Tue, Sep 04, 2007 at 09:55:45AM -0700, H. Peter Anvin wrote: Apparently XEN does not keep the contents of the 48-bit gdt_48 data structure that is passed to lgdt in the XEN machine state. Instead it appears to save the _address_ of the 48-bit

Re: kernel 2.6.22: what IS the VM doing?

2007-09-04 Thread Rik van Riel
Sami Farin wrote: Using SMP kernel 2.6.22.6pre-CFS-v20.5 on Pentium D (IA-32). I think this bug (or whatever you want to call it) got triggered when you first allocate several megabytes of memory in a kernel module and then free them, and then run e.g. X and when memory gets tight, you end up

Cache not being reclaimed?

2007-09-04 Thread Ian Kumlien
Hi, I have just had a quite unexpected 'low memory situation'... This is a AMD64 machine with 2 gig memory, running 64 bit userland. Kernel: 2.6.23-rc3-git10, updating to -rc5-* as soon as i can. I'm using SLUB:s To me, this looks odd... I thought that any cached memory would be reclamed but

[PATCH -mm] ufs: Fix mount check in ufs_fill_super()

2007-09-04 Thread Satyam Sharma
Hi Evgeniy, On Sun, 19 Aug 2007, Evgeniy Dushistov wrote: > > Different types of ufs hold state in different places, > to hide complexity of this, there is ufs_get_fs_state, > it returns state according to "UFS_SB(sb)->s_flags", > but during mount ufs_get_fs_state is called, > before setting

Re: TUN/TAP driver - MAINTAINERS - bad mailing list entry?

2007-09-04 Thread Max Krasnyansky
Joe Perches wrote: MAINTAINERS curently has: TUN/TAP driver P: Maxim Krasnyansky M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] [EMAIL PROTECTED] doesn't seem to be a valid email address. Should it be removed or modified? Sorry for late response. Just noticed this. Yes it's an

tbench regression - Why process scheduler has impact on tbench and why small per-cpu slab (SLUB) cache creates the scenario?

2007-09-04 Thread Zhang, Yanmin
1) Tbench has about 30% regression in kernel 2.6.23-rc4 than 2.6.22. 2.6.23-rc1 has about 10% regression. I investigated 2.6.22 and 2.6.23-rc4. 2) Testing environment: x86_64, qual-core, 2 physical processors, totally 8 cores. 8GB memory. Kernel enables CONFIG_SLUB=y and CONFIG_SLUB_DEBUG=y. 3)

Re: 2.6.22.6 + rt9: suspend/hibernate not working

2007-09-04 Thread Daniel Walker
On Tue, 2007-09-04 at 17:12 -0700, Fernando Lopez-Lezcano wrote: > Hi Ingo... I'm getting reports from some of my Planet CCRMA users (which > I confirmed) that the latest rt kernel I released has broken suspend > (tested on fc6 & fc7, stock Fedora kernel works fine - the rt > configuration files

Re: [PATCH] Fix tsk->exit_state usage (resend)

2007-09-04 Thread Satyam Sharma
Hi Eugene, This already got merged into -mm, but ... On Sun, 19 Aug 2007, Eugene Teo wrote: > > tsk->exit_state can only be 0, EXIT_ZOMBIE, or EXIT_DEAD. A non-zero test > is the same as tsk->exit_state & (EXIT_ZOMBIE | EXIT_DEAD), so just testing > tsk->exit_state is sufficient. ... IMHO

2.6.22.6 + rt9: suspend/hibernate not working

2007-09-04 Thread Fernando Lopez-Lezcano
Hi Ingo... I'm getting reports from some of my Planet CCRMA users (which I confirmed) that the latest rt kernel I released has broken suspend (tested on fc6 & fc7, stock Fedora kernel works fine - the rt configuration files are virtual clones as far as possible of the standard Fedora kernel config

Re: [PATCH] Revised timerfd() interface

2007-09-04 Thread Michael Kerrisk
Davide, > > As I think about this more, I see more problems with > > your argument. timerfd needs the ability to get and > > get-while-setting just as much as the earlier APIs. > > Consider a library that creates a timerfd file descriptor that > > is handed off to an application: that library

Re: [PATCH 3/6] x86: Convert cpu_sibling_map to be a per cpu variable (v2) (fwd)

2007-09-04 Thread Andrew Morton
> On Tue, 04 Sep 2007 16:11:31 -0700 Mike Travis <[EMAIL PROTECTED]> wrote: > > > > It'd be better to convert the unconverted architectures? > > I can easily do the changes for ia64 and test them. I don't have the > capability > of testing on the powerpc. > > And are you asking for just the

Re: [PATCH] Send quota messages via netlink

2007-09-04 Thread Serge E. Hallyn
Quoting Jan Kara ([EMAIL PROTECTED]): > On Tue 04-09-07 16:32:10, Serge E. Hallyn wrote: > > Quoting Jan Kara ([EMAIL PROTECTED]): > > > On Thu 30-08-07 17:14:47, Serge E. Hallyn wrote: > > > > Quoting Jan Kara ([EMAIL PROTECTED]): > > > > > I imagine it so that you have a machine and on it

Re: [patch] sched: fix broken smt/mc optimizations with CFS

2007-09-04 Thread Siddha, Suresh B
On Tue, Sep 04, 2007 at 07:35:21PM -0400, Chuck Ebbert wrote: > On 08/28/2007 06:27 PM, Siddha, Suresh B wrote: > > Try to fix MC/HT scheduler optimization breakage again, with out breaking > > the FUZZ logic. > > > > First fix the check > > if (*imbalance + SCHED_LOAD_SCALE_FUZZ <

Re: [patch] sched: fix broken smt/mc optimizations with CFS

2007-09-04 Thread Chuck Ebbert
On 08/28/2007 06:27 PM, Siddha, Suresh B wrote: > On Mon, Aug 27, 2007 at 12:31:03PM -0700, Siddha, Suresh B wrote: >> Essentially I observed that nice 0 tasks still endup on two cores of same >> package, with out getting spread out to two different packages. This behavior >> is same with out this

Re: 2.6.22.5 forcedeth timeout hang

2007-09-04 Thread Steve Reinhardt
We're seeing this identical timeout starting with 2.6.21, any time we try and push a significant amount of traffic through the nforce ethernet. We've rolled back to 2.6.20.18 and don't see any problems. It seems that this bug got introduced along with all the forcedeth fixes and optimizations

[PATCH] Add support for keyboard on SEGA Dreamcast

2007-09-04 Thread Adrian McMenamin
This patch will add support for the Dreamcast keyboard when used alongside the maple bus patch (http://lkml.org/lkml/2007/9/4/165) and the pvr2 patch. Signed off by: Adrian McMenamin <[EMAIL PROTECTED]> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index

Re: Suspend and hibernation status report

2007-09-04 Thread Len Brown
On Friday 27 July 2007 04:57, Rafael J. Wysocki wrote: Thanks for writing this, Rafael. > * system hibernation state - state, in which the system's processors are off > and > its main memory is not powered, but the information necessary for continuing > the computations carried out when the

[PATCH - RESUBMiT] Minor patch to pvr2 driver required for maple bus support on SEGA Dreamcast

2007-09-04 Thread Adrian McMenamin
The maple bus driver (http://lkml.org/lkml/2007/9/4/165) uses hardware synchronisation between the maple bus and the VBLANK to poll the maple bus. This patch makes the interrupt shareable. By definition the interrupt is for both devices. Signed-off by: Adrian McMenamin <[EMAIL PROTECTED]> diff

[PATCH] Add maple bus support for the SEGA Dreamcast

2007-09-04 Thread Adrian McMenamin
This patch adds support for SEGA's proprietary Maple bus. Maple is a serial communications bus and support is required to operate Dreamcast peripherals. A keyboard driver is also available and will be posted separately. Signed-off by: Adrian McMenamin <[EMAIL PROTECTED]> diff --git

Re: [PATCH 3/6] x86: Convert cpu_sibling_map to be a per cpu variable (v2) (fwd)

2007-09-04 Thread Mike Travis
Andrew Morton wrote: >> On Tue, 04 Sep 2007 13:29:11 -0700 Mike Travis <[EMAIL PROTECTED]> wrote: >>> -- Forwarded message -- >>> Date: Fri, 31 Aug 2007 19:49:03 -0700 >>> From: Andrew Morton <[EMAIL PROTECTED]> >>> To: [EMAIL PROTECTED] >>> Cc: Andi Kleen <[EMAIL PROTECTED]>,

Re: [PATCH 6/7] blk_end_request: remove/unexport end_that_request_*

2007-09-04 Thread Kiyoshi Ueda
Hi, On Tue, 4 Sep 2007 17:25:14 -0400, "Halevy, Benny" <[EMAIL PROTECTED]> wrote: > We suspect we'll still need the extern entry points for handling the bidi > request in the scsi_io_completion() path as we only want to call > end_that_request_chunk on req->next_rq and never >

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-04 Thread Daniel Hazelton
On Tuesday 04 September 2007 15:44:31 Michael Poole wrote: > Chris Friesen writes: > > Daniel Hazelton wrote: > >> On Tuesday 04 September 2007 09:27:02 Krzysztof Halasa wrote: > >>>Daniel Hazelton <[EMAIL PROTECTED]> writes: > US Copyright law. A copyright holder, regardless of what license

Re: [mtd] allow modular mtdsuper

2007-09-04 Thread Satyam Sharma
Hi Jason, On Tue, 4 Sep 2007, Jason Lunz wrote: > > Declare mtdsuper to be gpl-licensed so it can access get_mtd_device and > put_mtd_device when loaded as a module. The actual issue was a bit different -- refer commit bec494775600b1cd in latest -git (patch included below). David, it looks

Re: ramdisk

2007-09-04 Thread linux-os \(Dick Johnson\)
On Tue, 4 Sep 2007, Xu Yang wrote: > Hi Dick, > Thanks for the reply. > > then how to create these device nodes in /dev? from the information i > got from the cosole(unknown block(1,0) ), it seems that I didn't > create the device? I thought the kernel should do this work right? if > not how to

Re: [PATCH] Revised timerfd() interface

2007-09-04 Thread Davide Libenzi
On Tue, 4 Sep 2007, Michael Kerrisk wrote: > > Useless like it'd be a motorcycle w/out a cup-holder :) > > Seriously, the ability to get the previous values from "something" could > > have a meaning if this something is a shared global resource (like > > signals > > for example). In the timerfd

Re: [PATCH] Revised timerfd() interface

2007-09-04 Thread Davide Libenzi
On Tue, 4 Sep 2007, Michael Kerrisk wrote: > Hi Davide, > > > > > > > > > > I'd have thought that the existing stuff would be near-useless without > > > the capabilities which you describe? > > > > Useless like it'd be a motorcycle w/out a cup-holder :) > > Seriously, the ability to get the

Re: [GIT PULL] x86 setup: work around bug in Xen HVM

2007-09-04 Thread Christoph Hellwig
On Tue, Sep 04, 2007 at 09:55:45AM -0700, H. Peter Anvin wrote: > > Apparently XEN does not keep the contents of the 48-bit gdt_48 data > structure that is passed to lgdt in the XEN machine state. Instead it > appears to save the _address_ of the 48-bit descriptor > somewhere.

Re: [PATCH] Send quota messages via netlink

2007-09-04 Thread Jan Kara
On Tue 04-09-07 16:32:10, Serge E. Hallyn wrote: > Quoting Jan Kara ([EMAIL PROTECTED]): > > On Thu 30-08-07 17:14:47, Serge E. Hallyn wrote: > > > Quoting Jan Kara ([EMAIL PROTECTED]): > > > > I imagine it so that you have a machine and on it several virtual > > > > machines which are sharing a

Re: [PATCH 1/7] blk_end_request: add new request completion interface

2007-09-04 Thread Kiyoshi Ueda
Hi Jens, Thank you for the comments. On Mon, 3 Sep 2007 09:45:45 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote: > > +extern int blk_end_request(struct request *rq, int uptodate, int nr_bytes); > > +extern int __blk_end_request(struct request *rq, int uptodate, int > > nr_bytes); > > extern int

[mtd] allow modular mtdsuper

2007-09-04 Thread Jason Lunz
Declare mtdsuper to be gpl-licensed so it can access get_mtd_device and put_mtd_device when loaded as a module. Signed-off-by: Jason Lunz <[EMAIL PROTECTED]> --- drivers/mtd/mtdsuper.c |1 + 1 file changed, 1 insertion(+) Index: linux-2.6.22.6-uml/drivers/mtd/mtdsuper.c

Re: What's happening with the cpuidle code?

2007-09-04 Thread Chuck Ebbert
On 09/04/2007 05:43 PM, Len Brown wrote: > On Tuesday 04 September 2007 16:47, Chuck Ebbert wrote: >> A look at the 'cpuidle' branch of git-acpi shows a commit >> e40cede7d63a029e92712a3fe02faee60cc38fb4, "cpuidle: first >> round of documentation updates" that doesn't show up in that >> branch

Re: hang with CONFIG_MCYRIXIII

2007-09-04 Thread Mark Hindley
Having established that the oops was not the cause of the hangs I have been observing with MCYRIXIII, could anyone suggest ways to track down if this is a compiler or kernel bug? I have just complied latest git (with tcp_input.c oops fix) With CONFIG_MCYRIXIII I got a hang with empty logs and

Re: What's happening with the cpuidle code?

2007-09-04 Thread Len Brown
On Tuesday 04 September 2007 16:47, Chuck Ebbert wrote: > A look at the 'cpuidle' branch of git-acpi shows a commit > e40cede7d63a029e92712a3fe02faee60cc38fb4, "cpuidle: first > round of documentation updates" that doesn't show up in that > branch online. The entire Documentation/cpuidle directory

Re: ramdisk

2007-09-04 Thread Xu Yang
Hi Dick, Thanks for the reply. then how to create these device nodes in /dev? from the information i got from the cosole(unknown block(1,0) ), it seems that I didn't create the device? I thought the kernel should do this work right? if not how to create it? thanks, regards, 2007/9/4, linux-os

Re: 2.6.23-rc4-mm1

2007-09-04 Thread Stephen Hemminger
On Tue, 4 Sep 2007 10:54:32 -0700 Zach Carter <[EMAIL PROTECTED]> wrote: > > > +ioc3-program-uart-predividers.patch > > +sky2-fe-chip-support.patch > > +sky2-use-debugfs-rename.patch > > +sky2-document-gphy_ctrl-bits.patch > > +sky2-dont-restrict-config-space-access.patch > >

Re: [PATCH] Send quota messages via netlink

2007-09-04 Thread Serge E. Hallyn
Quoting Jan Kara ([EMAIL PROTECTED]): > On Thu 30-08-07 17:14:47, Serge E. Hallyn wrote: > > Quoting Jan Kara ([EMAIL PROTECTED]): > > > Maybe before proceeding further with the discussion I'd like to > > > understand following: What are these user namespaces supposed to be good > > > for? > >

Re: [PATCH 6/7] blk_end_request: remove/unexport end_that_request_*

2007-09-04 Thread Jens Axboe
On Tue, Sep 04 2007, Halevy, Benny wrote: > Boaz raised my attention to this patchset today... > We suspect we'll still need the extern entry points for handling the bidi > request in the scsi_io_completion() path as we only want to call > end_that_request_chunk on req->next_rq and never >

RE: [PATCH 6/7] blk_end_request: remove/unexport end_that_request_*

2007-09-04 Thread Halevy, Benny
Boaz raised my attention to this patchset today... We suspect we'll still need the extern entry points for handling the bidi request in the scsi_io_completion() path as we only want to call end_that_request_chunk on req->next_rq and never end_that_request_last. (see

Re: 2.6.23-rc4-mm1

2007-09-04 Thread Wim Van Sebroeck
Hi, > * Fix this warning: > > drivers/watchdog/core/watchdog_dev.c:84: > warning: format '%i' expects type 'int', but argument 5 has type 'size_t' > > * CONFIG_xxx options are directly usable by preprocessor directives. Patch works for me. I applied it to the linux-2.6-watchdog-mm tree.

Re: [PATCH 3/6] x86: Convert cpu_sibling_map to be a per cpu variable (v2) (fwd)

2007-09-04 Thread Andrew Morton
> On Tue, 04 Sep 2007 13:29:11 -0700 Mike Travis <[EMAIL PROTECTED]> wrote: > [Sorry, I did not see this message until Christoph forwarded it to me. I'm > guessing we (SGI) still have a problem with our external spam filter?] > > > > > -- Forwarded message -- > > Date: Fri, 31

Re: [PATCH] Fix a potential NULL pointer dereference in usbat_check_status() in drivers/usb/storage/shuttle_usbat.c

2007-09-04 Thread Jens Axboe
On Tue, Sep 04 2007, Simon Holm Thøgersen wrote: > tir, 04 09 2007 kl. 13:06 +0200, skrev Jens Axboe: > > On Tue, Sep 04 2007, Micah Gruber wrote: > > > This patch fixes a potential null dereference bug where we dereference us > > > before a null check. This patch simply moves the dereferencing

Re: [linux-usb-devel] [PATCH] Fix a potential NULL pointer dereference in usbat_check_status() in drivers/usb/storage/shuttle_usbat.c

2007-09-04 Thread Alan Stern
On Tue, 4 Sep 2007, Simon Holm Thøgersen wrote: > > tir, 04 09 2007 kl. 13:06 +0200, skrev Jens Axboe: > > On Tue, Sep 04 2007, Micah Gruber wrote: > > > This patch fixes a potential null dereference bug where we dereference us > > > before a null check. This patch simply moves the dereferencing

[PATCH 2.6.23-rc5] USB Mass Storage: limit "Rockchip ROCK MP3" device (071b:3203) max I/O to 64 sectors per command

2007-09-04 Thread Massimiliano Ghilardi
From: Massimiliano Ghilardi <[EMAIL PROTECTED]> The MP3/MP4/AVI player "Rockchip ROCK MP3" is seen as a USB disk, but fails if more than 128 sectors (64kB) are sent or requested in a single read or write command, and disconnects from the USB bus. Typical kernel log showing the problem is: usb

Re: origin of __tmp1930643048 network device name: kernel-space or user-space

2007-09-04 Thread Kay Sievers
On 9/4/07, davide rossetti <[EMAIL PROTECTED]> wrote: > I'm trying to track down a problem on a Sun V40Z server with 4 network > devices grabbing random ethX device names. now, trying to force the > device names to what I want, I got a __tmpX form of device name, > which I think is a

[PATCH 2/2] Fix (improve) deadlock condition on module removal netfilter socket option removal

2007-09-04 Thread Neil Horman
Hey- 2nd of two patches. This patch enhances modprobe to operate like rmmod in non-blocking mode. It also adds a -w option to allow for explicit blocking operation. Regards Neil Signed-off-by: Neil Horman <[EMAIL PROTECTED]> modprobe.8 |9 + modprobe.c | 21

Re: [PATCH] Revised timerfd() interface

2007-09-04 Thread Michael Kerrisk
> > > The ABI change doesn't really matter, since timerfd() was broken in > > > 2.6.22 anyway. > > > > > > Both previous APIs provided the features I have described provide: > > > > > > * the ability to fetch the old timer value when applying > > > a new setting > > > > > > * the ability to

What's happening with the cpuidle code?

2007-09-04 Thread Chuck Ebbert
A look at the 'cpuidle' branch of git-acpi shows a commit e40cede7d63a029e92712a3fe02faee60cc38fb4, "cpuidle: first round of documentation updates" that doesn't show up in that branch online. The entire Documentation/cpuidle directory is missing from the tree when looking at the web pages, and

Re: [PATCH] slub - Use local_t protection

2007-09-04 Thread Christoph Lameter
On Tue, 4 Sep 2007, Mathieu Desnoyers wrote: > @@ -1566,12 +1565,13 @@ redo: > object[c->offset]) != object)) > goto redo; > > - put_cpu(); > + local_exit(flags); > if (unlikely((gfpflags & __GFP_ZERO))) > memset(object, 0,

Re: [PATCH 3/6] x86: Convert cpu_sibling_map to be a per cpu variable (v2) (fwd)

2007-09-04 Thread Mike Travis
[Sorry, I did not see this message until Christoph forwarded it to me. I'm guessing we (SGI) still have a problem with our external spam filter?] > > -- Forwarded message -- > Date: Fri, 31 Aug 2007 19:49:03 -0700 > From: Andrew Morton <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED]

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-04 Thread linux-os \(Dick Johnson\)
On Tue, 4 Sep 2007, Chris Friesen wrote: > Daniel Hazelton wrote: >> On Tuesday 04 September 2007 09:27:02 Krzysztof Halasa wrote: >> >>> Daniel Hazelton <[EMAIL PROTECTED]> writes: >>> US Copyright law. A copyright holder, regardless of what license he/she may have released the work

[PATCH 1/2] Fix (improve) deadlock condition on module removal netfilter socket option removal

2007-09-04 Thread Neil Horman
Patch 1/2 to fix netfilter socket option removal This patch changes netfilter socket options to do reference counting on the module refcounter (And saves us 4 bytes in the structure to boot :) ). regards Neil Signed-off-by: Neil Horman <[EMAIL PROTECTED]> include/linux/netfilter.h

Re: [PATCH] Fix a potential NULL pointer dereference in usbat_check_status() in drivers/usb/storage/shuttle_usbat.c

2007-09-04 Thread Simon Holm Thøgersen
tir, 04 09 2007 kl. 13:06 +0200, skrev Jens Axboe: > On Tue, Sep 04 2007, Micah Gruber wrote: > > This patch fixes a potential null dereference bug where we dereference us > > before a null check. This patch simply moves the dereferencing after the > > null check. > > > > Signed-off-by: Micah

[PATCH 0/2] Fix (improve) deadlock condition on module removal netfilter socket option removal

2007-09-04 Thread Neil Horman
Hey all- So I've had a deadlock reported to me. I've found that the sequence of events goes like this: 1) process A (modprobe) runs to remove ip_tables.ko 2) process B (iptables-restore) runs and calls setsockopt on a netfilter socket, increasing the ip_tables socket_ops use count 3)

[PATCH] local_t protection (critical section)

2007-09-04 Thread Mathieu Desnoyers
local_t protection (critical section) Adds local_enter(flags) and local_exit(flags) as primitives to surround critical sections using local_t types. On architectures providing fast atomic primitives, this turns into a preempt disable/enable(). However, on architectures not providing such fast

[PATCH] slub - Use local_t protection

2007-09-04 Thread Mathieu Desnoyers
slub - Use local_t protection Use local_enter/local_exit for protection in the fast path. Depends on the cmpxchg_local slub patch. Signed-off-by: Mathieu Desnoyers <[EMAIL PROTECTED]> CC: Christoph Lameter <[EMAIL PROTECTED]> --- mm/slub.c | 18 ++ 1 file changed, 10

Re: [PATCH] SLUB use cmpxchg_local

2007-09-04 Thread Mathieu Desnoyers
* Christoph Lameter ([EMAIL PROTECTED]) wrote: > Measurements on IA64 slub w/per cpu vs slub w/per cpu/cmpxchg_local > emulation. Results are not good: > Hi Christoph, I tried to come up with a patch set implementing the basics of a new critical section: local_enter(flags) and

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-04 Thread Michael Poole
Chris Friesen writes: > Daniel Hazelton wrote: >> On Tuesday 04 September 2007 09:27:02 Krzysztof Halasa wrote: >> >>>Daniel Hazelton <[EMAIL PROTECTED]> writes: >>> US Copyright law. A copyright holder, regardless of what license he/she may have released the work under, can still revoke

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-04 Thread Chris Friesen
Daniel Hazelton wrote: On Tuesday 04 September 2007 09:27:02 Krzysztof Halasa wrote: Daniel Hazelton <[EMAIL PROTECTED]> writes: US Copyright law. A copyright holder, regardless of what license he/she may have released the work under, can still revoke the license for a specific person or

Re: huge improvement with per-device dirty throttling

2007-09-04 Thread Martin Knoblauch
--- Leroy van Logchem <[EMAIL PROTECTED]> wrote: > Andrea Arcangeli wrote: > > On Wed, Aug 22, 2007 at 01:05:13PM +0200, Andi Kleen wrote: > >> Ok perhaps the new adaptive dirty limits helps your single disk > >> a lot too. But your improvements seem to be more "collateral > damage" @) > >> > >>

Re: [-mm PATCH] Memory controller improve user interface (v3)

2007-09-04 Thread Dave Hansen
On Sun, 2007-09-02 at 16:20 +0530, Balbir Singh wrote: > > +Setting a limit to a number that is not a multiple of page size causes > +rounding up of the value. The user must check back to see (by reading > +memory.limit_in_bytes), to check for differences between desired values and > +committed

Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-04 Thread Mikael Pettersson
Jeff Norden writes: > From: Jeff Norden <[EMAIL PROTECTED]> > > Fix "lost" interrupt problem when using dma with CD/DVD drives in some > configurations. This problem can make installing linux from media > impossible for distro's that have switched to libata-only configurations. > > The

Re: [PATCH] Fix out-by-one error in traps.c

2007-09-04 Thread Rusty Russell
On Fri, 2007-08-31 at 11:24 -0700, Linus Torvalds wrote: > > On Sat, 1 Sep 2007, Rusty Russell wrote: > > > > This is only for the initial booting stack (init_thread_union); see > > arch/i386/kernel/head.S: > > /* Set up the stack pointer */ > > lss stack_start,%esp > > ... > >

Re: 2.6.23-rc4-mm1

2007-09-04 Thread Zach Carter
> +ioc3-program-uart-predividers.patch > +sky2-fe-chip-support.patch > +sky2-use-debugfs-rename.patch > +sky2-document-gphy_ctrl-bits.patch > +sky2-dont-restrict-config-space-access.patch > +sky2-advanced-error-reporting.patch > +sky2-use-pci_config-access-functions.patch >

Re: 2.6.23-rc4-mm1 net bitops compile error

2007-09-04 Thread Jiri Slaby
Adrian Bunk napsal(a): > defconfig fails with the following error on parisc: > > <-- snip --> > > ... > CC net/core/gen_estimator.o > In file included from include2/asm/bitops.h:111, > from > /home/bunk/linux/kernel-2.6/linux-2.6.23-rc4-mm1/net/core/gen_estimator.c:18:

Re: [PATCH] Make rcutorture RNG use temporal entropy

2007-09-04 Thread Paul E. McKenney
On Tue, Sep 04, 2007 at 09:14:19AM -0700, Paul E. McKenney wrote: > On Tue, Sep 04, 2007 at 11:16:50AM +0530, Satyam Sharma wrote: > > Hi Paul, > > > > On Wed, 15 Aug 2007, Paul E. McKenney wrote: > > > > > > The locking used by get_random_bytes() can conflict with the > > > preempt_disable()

Re: Race condition: calling remove_proc_entry in cleanup_module (module_exit) while someone's using procfile

2007-09-04 Thread anon... anon.al
On 9/4/07, Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > For regular proc files, this is fixed in 2.6.23-rc1 and later. Thanks! I see you've been working on it: fix-rmmod-read-write-races-in-proc-entries...

Re: GPL weasels and the atheros stink

2007-09-04 Thread Daniel Hazelton
On Tuesday 04 September 2007 11:10:52 [EMAIL PROTECTED] wrote: > On Mon, 03 Sep 2007 17:23:37 PDT, David Schwartz said: > > > Wrong - I said "You can't complain about Person A doing X when > > > you let Person > > > B do X without complaint". > > > > Yes, I can. There is no inconsistency between

RE: [PATCH 2.6.23-rc4] irq: irq and pci_ids patch for Intel Tolapai

2007-09-04 Thread Gaston, Jason D
>> Please do submit new PCI device IDs to pciids.sf.net project. > >Yep. FYI: I have already posted the Tolapai DID's and device strings to pciids.sf.net. Thanks, Jason - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

origin of __tmp1930643048 network device name: kernel-space or user-space

2007-09-04 Thread davide rossetti
dear all, I'm trying to track down a problem on a Sun V40Z server with 4 network devices grabbing random ethX device names. now, trying to force the device names to what I want, I got a __tmpX form of device name, which I think is a half-configured device... but which piece of software is to

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-04 Thread Daniel Hazelton
On Tuesday 04 September 2007 09:27:02 Krzysztof Halasa wrote: > Daniel Hazelton <[EMAIL PROTECTED]> writes: > > US Copyright law. A copyright holder, regardless of what license he/she > > may have released the work under, can still revoke the license for a > > specific person or group of people.

Re: kernel BUG at mm/slab.c:2980 (was Re: [] xfs_bmap_search_multi_extents+0x6f/0xe0)

2007-09-04 Thread Christoph Lameter
On Tue, 4 Sep 2007, Marco Berizzi wrote: > After a week uptime I got this error. I hope it > will be useful for you. Yes indeed but this is a different type of failure. Looks like a higher allocation failure in the networking code. Someone created objects that required an order 2 allocations

Re: Kernel panic with 2.6.23-rc5

2007-09-04 Thread Paulo Marques
Tilman Schmidt wrote: Paulo Marques schrieb: I just tried booting a brand new 2.6.23-rc5 and after a few minutes it just panicked: machine totally frozen, blinking keyboard leds. [...] Maybe someone out there has a good suggestion that I could try before bisecting... A probable candidate

Re: Fwd: That whole "Linux stealing our code" thing

2007-09-04 Thread Daniel Hazelton
On Tuesday 04 September 2007 04:50:34 James Bruce wrote: > Daniel Hazelton wrote: > > On Monday 03 September 2007 14:26:29 Krzysztof Halasa wrote: > >> Daniel Hazelton <[EMAIL PROTECTED]> writes: > >>> The fact > >>> remains that the person making a work available under *ANY* form of > >>>

Re: Race condition: calling remove_proc_entry in cleanup_module (module_exit) while someone's using procfile

2007-09-04 Thread Alexey Dobriyan
On Tue, Sep 04, 2007 at 06:39:33PM +0200, anon... anon.al wrote: > There is a race condition if an instance is executing "__exit > device_exit" and calls remove_proc_entry, while someone is still using > the procfile, right?. > > static void __exit device_exit(void) > { > // what if the

[GIT PULL] x86 setup: work around bug in Xen HVM

2007-09-04 Thread H. Peter Anvin
Hi Linus, Please pull: git://git.kernel.org/pub/scm/linux/kernel/git/hpa/linux-2.6-x86setup.git for-linus Christian Ehrhardt (1): [x86 setup] Work around bug in Xen HVM arch/i386/boot/pm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) [Log messages and full diffs

Problem to recognize that the file system is full

2007-09-04 Thread Guilherme Vilela
Hi, I'm tryng to mount a nfs file system with the option async and run a program that writes to the file system. The problem is that the program keep writing even when the file system is full. It appears that the nfs dont see that the file system is full and keeps writing to the cache. This

Re: Race condition: calling remove_proc_entry in cleanup_module (module_exit) while someone's using procfile

2007-09-04 Thread anon... anon.al
On 9/4/07, anon... anon.al <[EMAIL PROTECTED]> wrote: > If yes: which mechanism can be used? I was thinking about using an atomic counter in procfile_write proc_f = create_proc_entry(PROC_FILE_NAME, 0644, NULL); //... proc_f->write_proc = procfile_write; int procfile_write(struct file

[PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-04 Thread Jeff Norden
From: Jeff Norden <[EMAIL PROTECTED]> Fix "lost" interrupt problem when using dma with CD/DVD drives in some configurations. This problem can make installing linux from media impossible for distro's that have switched to libata-only configurations. The simple fix is to eliminate the use of dma

Race condition: calling remove_proc_entry in cleanup_module (module_exit) while someone's using procfile

2007-09-04 Thread anon... anon.al
Hi! There is a race condition if an instance is executing "__exit device_exit" and calls remove_proc_entry, while someone is still using the procfile, right?. static void __exit device_exit(void) { // what if the procfile is still in use? remove_proc_entry(PROC_FILE_NAME, _root); } To

Re: Linux 2.6.23-rc5

2007-09-04 Thread S.Çağlar Onur
Hi Again; 04 Eyl 2007 Sal tarihinde, S.Çağlar Onur şunları yazmıştı: > Hi; > > 01 Eyl 2007 Cts tarihinde, Linus Torvalds şunları yazmıştı: > > So have fun, give it a go, and expect a quiet week next week. > > After upgrading -rc5 (i'm currently using linus's latest git + appArmor and >

Re: Linux 2.6.23-rc5

2007-09-04 Thread Prakash Punnoor
On the day of Sunday 02 September 2007 Prakash Punnoor hast written: > Hi, > > 2.6.23-rc5 locks up hard (Magic Syskeys won't even work) after a few > minutes of work on x86_64. 2.6.23-rc4 was fine. I'll try git-bisect to find > out what is causing trouble. Yes, I am using nvidia binary but it

Re: [PATCH] Make rcutorture RNG use temporal entropy

2007-09-04 Thread Paul E. McKenney
On Tue, Sep 04, 2007 at 11:16:50AM +0530, Satyam Sharma wrote: > Hi Paul, > > > On Wed, 15 Aug 2007, Paul E. McKenney wrote: > > > > The locking used by get_random_bytes() can conflict with the > > preempt_disable() and synchronize_sched() form of RCU. This patch changes > > rcutorture's RNG

Re: Linux 2.6.23-rc5

2007-09-04 Thread S.Çağlar Onur
Hi; 01 Eyl 2007 Cts tarihinde, Linus Torvalds şunları yazmıştı: > So have fun, give it a go, and expect a quiet week next week. After upgrading -rc5 (i'm currently using linus's latest git + appArmor and bootsplash patchset) my CD/DVD-ROM suddenly disappeared :). [EMAIL PROTECTED] ~ $ diff

  1   2   3   4   >