Re: Network slowdown due to CFS

2007-09-27 Thread Ingo Molnar
* Martin Michlmayr [EMAIL PROTECTED] wrote: I think the real fix would be for iperf to use blocking network IO though, or maybe to use a POSIX mutex or POSIX semaphores. So it's definitely not a bug in the kernel, only in iperf? (CCing Stephen Hemminger who wrote the iperf patch.)

[PATCH -mm] task_struct: move -fpu_counter and -oomkilladj

2007-09-27 Thread Alexey Dobriyan
There is nice 2 byte hole after struct task_struct::ioprio field into which we can put two 1-byte fields: -fpu_counter and -oomkilladj. [cc'ing Arjan just in case -fpu_counter placement wasn't completely random :^)] Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- include/linux/sched.h |

[PATCH -mm] VT ioctl race fix

2007-09-27 Thread Samuel Ortiz
Hi, When calling the RELDISP VT ioctl, we are reading vt_newvt while the console workqueue could be messing with it (through change_console()). We fix this race by taking the console semaphore before reading vt_newvt. Andrew, would you please consider this patch for -mm inclusion ?

PROBLEM: kernel BUG at net/core/skbuff.c:1341!

2007-09-27 Thread Niccolo Rigacci
1. kernel BUG at net/core/skbuff.c:1341! 2. I got a kernel panic, the hardware is a good IBM 206m server with 2 Gb ECC memory, Memtest86+ run several times without problem. The message on the console is quite explicit, so is this really a kernel bug? The box is a web server with moderate

Re: 2.6.23-rc7 - _random_ IRQ23 : nobody cared

2007-09-27 Thread Paul Rolland
Hello, On Thu, 27 Sep 2007 19:04:11 +1000 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: Let me guess... this is a T61 or X61 ? Bad luck ;) This is an Asus P5W-DH Deluxe motherboard, with a Core2 6400 CPU, a bunch of disk (2 IDE, 3 SATA, 1 CDRW and 1 DVDRW-DL), and a damned Olitec PCI V92

Re: Updating include/asm symlink when $ARCH changes

2007-09-27 Thread Alexey Dobriyan
On 9/27/07, Martin Michlmayr [EMAIL PROTECTED] wrote: I cross compile arm and mips kernels from the same kernel tree. You can use O= feature and skip this issue completely. make ARCH=mips O=../build/mips ... make ARCH=arm O=../build/arm ... When I build a kernel the first time with a

Re: Man page for revised timerfd API

2007-09-27 Thread Michael Kerrisk
Davide, A further question: what is the expected behavior in the following scenario: 1. Create a timerfd and arm it. 2. Wait until M timer expirations have occurred 3. Modify the settings of the timer 4. Wait for N further timer expirations have occurred 5. read() from the timerfd Does the

Re: Man page for revised timerfd API

2007-09-27 Thread Michael Kerrisk
[various useful comments snipped] Thanks Geoff -- I will incorporate all of the points you mentioned. Cheers, Michael -- Michael Kerrisk maintainer of Linux man pages Sections 2, 3, 4, 5, and 7 Want to help with man page maintenance? Grab the latest tarball at

RE: [PATCH 1/2] [INPUT] Blackfin BF54x Input Keypad controller driver

2007-09-27 Thread Hennerich, Michael
Hi Dmitry, -Original Message- From: Dmitry Torokhov [mailto:[EMAIL PROTECTED] Sent: Mittwoch, 26. September 2007 15:38 To: [EMAIL PROTECTED]; Michael Hennerich Cc: [EMAIL PROTECTED]; Linux Kernel; uclinux-dist- [EMAIL PROTECTED] Subject: Re: [PATCH 1/2] [INPUT] Blackfin BF54x Input Keypad

Re: 2.6.23-rc8-mm2 - drivers/net/ibm_newemac/mal - broken

2007-09-27 Thread Kamalesh Babulal
Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/ Hi Andrew, The drivers/net/ibm_newemac/mal seems to be broken with 2.6.23-rc8-mm2 also, it was reported on 2.6.23-rc8-mm1 (http://lkml.org/lkml/2007/9/25/173). -- Thanks Regards,

Re: Network slowdown due to CFS

2007-09-27 Thread Martin Michlmayr
* Ingo Molnar [EMAIL PROTECTED] [2007-09-27 11:49]: Martin, could you check the iperf patch below instead of the yield patch - does it solve the iperf performance problem equally well, and does CPU utilization drop for you too? Yes, it works and CPU goes down too. -- Martin Michlmayr

Re: Network slowdown due to CFS

2007-09-27 Thread Ingo Molnar
* Martin Michlmayr [EMAIL PROTECTED] wrote: * Ingo Molnar [EMAIL PROTECTED] [2007-09-27 11:49]: Martin, could you check the iperf patch below instead of the yield patch - does it solve the iperf performance problem equally well, and does CPU utilization drop for you too? Yes, it works

kernel Oops in ext3 code

2007-09-27 Thread Norbert Preining
Hi all! (Please Cc) kernel 2.6.23-rc6 Debian/sid kernel ooops: BUG: unable to handle kernel paging request at virtual address 104b printing eip: c0195bd3 *pde = Oops: [#1] PREEMPT SMP Modules linked in: vboxdrv binfmt_misc fuse coretemp hwmon gspca videodev

Re: [PATCH 000 of 4] Change prototype for bi_end_io

2007-09-27 Thread Jens Axboe
On Thu, Sep 27 2007, NeilBrown wrote: Hi Jens, here are a few more patches from my set that makes various changes to bio submission and handling. These change the -bi_end_io prototype so that 1/ no 'size' is passed 2/ there is no return value. The 'size' is not really of

Re: Network slowdown due to CFS

2007-09-27 Thread Martin Michlmayr
* Ingo Molnar [EMAIL PROTECTED] [2007-09-27 12:56]: i'm curious by how much does CPU go down, and what's the output of iperf? (does it saturate full 100mbit network bandwidth) I get about 94-95 Mbits/sec and CPU drops from 99% to about 82% (this is with a 600 MHz ARM CPU). -- Martin Michlmayr

Re: sys_chroot+sys_fchdir Fix

2007-09-27 Thread Theodore Tso
On Thu, Sep 27, 2007 at 09:28:08AM +0200, Christer Weinigel wrote: So the OpenBSD man page seems to be in the minority here. Any portable code can not assume that CWD changes. And changing the Linux behaviour now would be a rather big change which might break userspace. And yes, there are

[PATCH] Compile handle_percpu_irq even for uniprocessor kernels

2007-09-27 Thread Ralf Baechle
Compiling handle_percpu_irq only on uniprocessor generates an artificial special case so a typical use like: set_irq_chip_and_handler(irq, some_irq_type, handle_percpu_irq); needs to be conditionally compiled only on SMP systems as well and an alternative UP construct is usually needed - for

Re: Updating include/asm symlink when $ARCH changes

2007-09-27 Thread Sam Ravnborg
On Thu, Sep 27, 2007 at 11:25:21AM +0200, Martin Michlmayr wrote: I cross compile arm and mips kernels from the same kernel tree. When I build a kernel the first time with a fresh kernel tree, the include/asm symlink is set properly. However, when I compile for a different $ARCH, the

Re: [PATCH] Compile handle_percpu_irq even for uniprocessor kernels

2007-09-27 Thread Thomas Gleixner
On Thu, 2007-09-27 at 12:24 +0100, Ralf Baechle wrote: Compiling handle_percpu_irq only on uniprocessor generates an artificial special case so a typical use like: set_irq_chip_and_handler(irq, some_irq_type, handle_percpu_irq); needs to be conditionally compiled only on SMP systems as

Re: [PATCH 1/2] strip generated symbols from *.ko

2007-09-27 Thread Sam Ravnborg
(private reply) Being occupied by non-linux stuff lately but will review your patches soon. non-linux stuff includes too little sleep because my baby girl having yet another new teeth and it hurst... I hope to go over it during the weekend so Ican include it in next merge window. Sam

Re: [PATCH 3/5] ibmebus: Add device creation and bus probing based on of_device

2007-09-27 Thread Arnd Bergmann
On Wednesday 26 September 2007, Joachim Fenkes wrote: The devtree root is now searched for devices matching a built-in whitelist during boot, so these devices appear on the bus from the beginning. It is still possible to manually add/remove devices to/from the bus by using the probe/remove

Re: [PATCH 1/5] PowerPC: Move of_device allocation into of_device.[ch]

2007-09-27 Thread Arnd Bergmann
On Wednesday 26 September 2007, Joachim Fenkes wrote: Extract generic of_device allocation code from of_platform_device_create() and move it into of_device.[ch], called of_device_alloc(). Also, there's now of_device_free() which puts the device node. This way, bus drivers that build on

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

2007-09-27 Thread Arnd Bergmann
On Wednesday 26 September 2007, Joachim Fenkes wrote: Replace struct ibmebus_dev and struct ibmebus_driver with struct of_device and struct of_platform_driver, respectively. Match the external ibmebus interface and drivers using it. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] Acked-by:

Re: [PATCH 2/5] ibmebus: Remove bus match/probe/remove functions

2007-09-27 Thread Arnd Bergmann
On Wednesday 26 September 2007, Joachim Fenkes wrote: Remove old code that will be replaced by rewritten and shorter functions in the next patch. Keep struct ibmebus_dev and struct ibmebus_driver for now, but replace ibmebus_{,un}register_driver() by dummy functions. This way, the kernel will

Re: [PATCH 2/3] MIPS: Remove deprecated IRQ flags (SA_*)

2007-09-27 Thread Ralf Baechle
On Thu, Sep 27, 2007 at 01:35:43AM +0300, Ahmed S. Darwish wrote: A patch to stop using deprecated IRQ flags. The new IRQF_* macros are used instead. Thanks, queued for 2.6.24. Ralf - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: [GIT PULL] Workaround for broken Geode E820 BIOS

2007-09-27 Thread Joerg Pommnitz
I just tried 2.6.23-rc8 with the patch applied. Works fine here, so my very first Acked-by: Joerg Pommnitz [EMAIL PROTECTED] for whatever it's worth, since it is already in Linus' tree. Thanks to Peter and Jordan for taking the interest and time to track this one down and fix it. --

Re: 2.6.23-rc8: Known regressions from 2.6.22

2007-09-27 Thread Rafael J. Wysocki
On Thursday, 27 September 2007 01:29, Chuck Ebbert wrote: On 09/26/2007 07:27 PM, Rafael J. Wysocki wrote: Subject:Regression in 2.6.23-pre Was: Problems with 2.6.23-rc6 on AMD Geode LX800 Submitter: Joerg Pommnitz [EMAIL PROTECTED] References: http://lkml.org/lkml/2007/9/26/91

Re: 2.6.23-rc8: Known regressions from 2.6.22

2007-09-27 Thread Rafael J. Wysocki
On Thursday, 27 September 2007 08:19, Meelis Roos wrote: RJW This message lists some known regressions from 2.6.22 for which there are RJW no fixes in the mainline that I know of. If any of them have been fixed RJW already, please let me know. RJW RJW If you know of any other unresolved

Re: why network devices don't do reference counting? (Re: [PATCH] Module use count must be updated as bridges are created/destroyed)

2007-09-27 Thread Helge Hafting
Stephen Hemminger wrote: On Thu, 27 Sep 2007 00:18:55 +0200 (CEST) Jan Engelhardt [EMAIL PROTECTED] wrote: On Sep 26 2007 14:06, Stephen Hemminger wrote: No, network devices don't do reference counting. Could you explain why, please? After `udevd` on boot loads lots of

Re: 2.6.23-rc8-mm1 -- powerpc link failure

2007-09-27 Thread Andy Whitcroft
actually, my first patch wasn't using weak symbols, but I have been convinced that it's the way to go(tm). Please see http://lkml.org/lkml/2007/9/1/131 and the ongoing thread. I am fine with replacing the brk randomization patch with the one that wasn't using weak symbols (posted in the

eventfd.2 man page

2007-09-27 Thread Michael Kerrisk
Hi Davide, I've slightly tweaked the eventfd.2 man page in preparation for adding it to the man-pages set. Could you please review the text below, and confirm that it correctly describes intended behavior. Thanks, Michael .\ Copyright (C) 2007 Michael Kerrisk [EMAIL PROTECTED] .\ starting

Re: kernel Oops in ext3 code

2007-09-27 Thread Rafael J. Wysocki
On Thursday, 27 September 2007 12:31, Norbert Preining wrote: Hi all! (Please Cc) kernel 2.6.23-rc6 Debian/sid Does it happen with 2.6.22? kernel ooops: BUG: unable to handle kernel paging request at virtual address 104b printing eip: c0195bd3 *pde = Oops:

Re: 2.6.23-rc8-mm1 -- powerpc link failure

2007-09-27 Thread Jiri Kosina
On Thu, 27 Sep 2007, Andy Whitcroft wrote: Ok, this problem seems to still persist in 2.6.23-rc8-mm2. It seems we have three options from here: 1) update the compiler support list to exclude these compilers, or 2) back this change out, or 3) switch to the version not using __weak. The

[git patches] umem driver cleanups

2007-09-27 Thread Jeff Garzik
Please pull from 'umem' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git umem to receive the following updates: drivers/block/umem.c| 202 --- {include/linux = drivers/block}/umem.h | 19 +-- include/linux/pci_ids.h

Re: Warnings and Bug on 2.6.23-rc6 closing rfcomm links (device_move() API ?)

2007-09-27 Thread Rafael J. Wysocki
On Tuesday, 25 September 2007 17:13, Pierre-Yves Paulus wrote: Hello, Yet another report, once again while putting rfcomm system under load. Several USB adapters, several links. Is this a regression or does it happen with 2.6.22 too? Greetings, Rafael - To unsubscribe from this list: send

Revised signalfd man-page

2007-09-27 Thread Michael Kerrisk
Davide, Below is the current signalfd man-page. Could you please review to see whether the man page describes the intended implementation, and especially look at a few questions embedded in the page (look for Davide). Cheers, Michael .\ Copyright (C) 2007 Michael Kerrisk [EMAIL PROTECTED] .\

signalfd_siginfo field names -- revisited

2007-09-27 Thread Michael Kerrisk
Hi Davide, (We started discussing this quite a while back, and you then seemed positively disposed to my idea below, but then holidays intervened, so I'm resending this slightly revised version of my earlier mail.) The signalfd_siginfo structure is defined as: struct signalfd_siginfo { /*

[PATCH] sysfs: backport of sysfs_readdir fix from 2.6.22.y to 2.6.16.y (CVE-2007-3104)

2007-09-27 Thread Miloslav Semler
This patch solves CVE-2007-3104 - sysfs_readdir oops. More can be found here: http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.22.y.git;a=commit;h=dc351252b33f8fede396d6173dba117bcb933607 Signed-off-by: Miloslav Semler --- diff -uprN linux-2.6.16.53/fs/sysfs/dir.c

Re: Network slowdown due to CFS

2007-09-27 Thread Jarek Poplawski
On Thu, Sep 27, 2007 at 11:46:03AM +0200, Ingo Molnar wrote: * Jarek Poplawski [EMAIL PROTECTED] wrote: the (small) patch below fixes the iperf locking bug and removes the yield() use. There are numerous immediate benefits of this patch: ... sched_yield() is almost always the

Re: [PATCH 1/5] The config option itself

2007-09-27 Thread Cedric Le Goater
Pavel Emelyanov wrote: The option is called NAMESPACES. It can be selectable only if EMBEDDED is chosen (this was Eric's requisition). When the EMBEDDED is off namespaces will be on automatically. One more option (NAMESPACES_EXPERIMENTAL) was added by Serge's request to move there all the

Re: [PATCH 2/5] Move the UST namespace under the option

2007-09-27 Thread Cedric Le Goater
Pavel Emelyanov wrote: Currently all the namespace management code is in the kernel/utsname.c file, so just compile it out and make stub in .h file. The init namespace itself is in init/version.c and is left in the kernel. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Acked-by:

Re: [PATCH 4/5] Move the user namespace under the option

2007-09-27 Thread Cedric Le Goater
Pavel Emelyanov wrote: We currently have a CONFIG_USER_NS option. Just rename it into CONFIG_NAMESPACES_EXPERIMANTAL and move the init_user_ns into user.c file to make the kernel compile and work without the namespaces support. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Acked-by:

Re: [PATCH 3/5] Move the IPC namespace under the option

2007-09-27 Thread Cedric Le Goater
Pavel Emelyanov wrote: Currently all the IPC namespace management code is in ipc/util.c. I moved this code into ipc/namespace.c file which is compiled out when needed. The linux/ipc_namespace.h file is used to store the prototypes of the functions in namespace.c and the stubs for

Re: Revised signalfd man-page

2007-09-27 Thread Heikki Orsila
On Thu, Sep 27, 2007 at 02:19:05PM +0200, Michael Kerrisk wrote: uint28_t pad[\fIX\fP]; /* Pad size to 128 bytes (allow space additional fields in the future) */ I think you mean uint8_t.. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED]

Re: [PATCH 4/5] Move the user namespace under the option

2007-09-27 Thread Robert P. J. Day
On Thu, 27 Sep 2007, Cedric Le Goater wrote: diff --git a/include/linux/user_namespace.h b/include/linux/user_namespace.h index b5f41d4..dda160c 100644 --- a/include/linux/user_namespace.h +++ b/include/linux/user_namespace.h @@ -17,7 +17,7 @@ struct user_namespace { extern struct

Re: Revised signalfd man-page

2007-09-27 Thread Michael Kerrisk
On Thu, Sep 27, 2007 at 02:19:05PM +0200, Michael Kerrisk wrote: uint28_t pad[\fIX\fP]; /* Pad size to 128 bytes (allow space additional fields in the future) */ I think you mean uint8_t.. Yep -- I sure do thanks, Michael -- Michael Kerrisk

Re: [RFC] QoS params patch

2007-09-27 Thread roel
Mark Gross wrote: On Wed, Sep 26, 2007 at 04:41:59PM -0700, Randy Dunlap wrote: On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross wrote: The following is the qos_param patch that implements a genralization of latency.c. Just some general comments (as on irc): - use 'diffstat -p1 -w70' to

Re: kernel Oops in ext3 code

2007-09-27 Thread Norbert Preining
On Do, 27 Sep 2007, Rafael J. Wysocki wrote: Does it happen with 2.6.22? Hard to say. It didn't happen as long as I used -22, but it didn't happen for a long time (since I run -rc6), and it is not reproducible. What I did at this time is a: tar -cjf foo.tar.bz2

[PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Alan Cox
The early LFS work that Linux uses favours EFBIG in various places. SuSv3 specifically uses EOVERFLOW for this as noted by Michael (Bug 7253) -- [EOVERFLOW] The named file is a regular file and the size of the file cannot be represented correctly in an object of type off_t. We should

Re: Network slowdown due to CFS

2007-09-27 Thread Ingo Molnar
* Jarek Poplawski [EMAIL PROTECTED] wrote: On Thu, Sep 27, 2007 at 11:46:03AM +0200, Ingo Molnar wrote: [...] What you missed is that there is no such thing as predictable yield behavior for anything but SCHED_FIFO/RR tasks (for which tasks CFS does keep the behavior). Please read this

[PATCH] JBD2: debug code cleanup.

2007-09-27 Thread Jose R. Santos
From: Jose R. Santos [EMAIL PROTECTED] JBD2: debug code cleanup. Mostly stolen from akpm's JBD cleanup patch. - use `#ifdef foo' instead of `#if defined(foo)' - Make journal_enable_debug __read_mostly just for the heck of it - Make jbd_debugfs_dir and jbd_debug static - debugfs_remove(NULL)

Re: Warnings and Bug on 2.6.23-rc6 closing rfcomm links (device_move() API ?)

2007-09-27 Thread Cornelia Huck
On Thu, 27 Sep 2007 14:40:07 +0200, Pierre-Yves Paulus [EMAIL PROTECTED] wrote: Hello, Yet another report, once again while putting rfcomm system under load. Several USB adapters, several links. Is this a regression or does it happen with 2.6.22 too? I've not tested with 2.6.22,

Re: Chroot bug

2007-09-27 Thread Jiri Kosina
On Wed, 26 Sep 2007, Miloslav Semler wrote: so there is no discussion about mount others. I think, if you have CAP_SYS_MOUNT/CAP_SYS_ADMIN, you need not solve chroot() and how to break it. CAP_SYS_PTRACE allows you to break out of chroot in a pretty trivial way too. -- Jiri Kosina - To

Re: lockdep wierdness...

2007-09-27 Thread Peter Zijlstra
On Mon, 2007-09-24 at 22:13 -0400, Steven Rostedt wrote: On Mon, Sep 24, 2007 at 06:07:38PM -0400, Trond Myklebust wrote: I'm seeing lockdep warning about a potential lock inversion between mm-mmap_sem and inode-i_mutex in NFS (see attachment). Unfortunately the basis for the warning

Re: kernel Oops in ext3 code

2007-09-27 Thread Rafael J. Wysocki
On Thursday, 27 September 2007 15:13, Norbert Preining wrote: On Do, 27 Sep 2007, Rafael J. Wysocki wrote: Does it happen with 2.6.22? Hard to say. It didn't happen as long as I used -22, but it didn't happen for a long time (since I run -rc6), and it is not reproducible. What I did at

Re: [PATCH -mm] task_struct: move -fpu_counter and -oomkilladj

2007-09-27 Thread Arjan van de Ven
On Thu, 27 Sep 2007 13:55:57 +0400 Alexey Dobriyan [EMAIL PROTECTED] wrote: There is nice 2 byte hole after struct task_struct::ioprio field into which we can put two 1-byte fields: -fpu_counter and -oomkilladj. [cc'ing Arjan just in case -fpu_counter placement wasn't completely random

Re: lockdep wierdness...

2007-09-27 Thread Christoph Hellwig
On Thu, Sep 27, 2007 at 03:51:07PM +0200, Peter Zijlstra wrote: Christoph, does Steve's story make sense? Yes. All that would need to be done is add an extra lock_class_key to file_system_type for i_mutex_dir_key, and extend alloc_inode to say something like: if (dir)

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Arjan van de Ven
On Thu, 27 Sep 2007 14:29:19 +0100 Alan Cox [EMAIL PROTECTED] wrote: The early LFS work that Linux uses favours EFBIG in various places. SuSv3 specifically uses EOVERFLOW for this as noted by Michael (Bug 7253) isn't this an ABI change? What's the gain for doing this ABI change? - To

[patch 03/10] Remove path_release_on_umount()

2007-09-27 Thread jblunck
path_release_on_umount() should only be called from sys_umount(). I merged the function into sys_umount() instead of having in in namei.c. Signed-off-by: Jan Blunck [EMAIL PROTECTED] --- fs/namei.c| 10 -- fs/namespace.c|4 +++- include/linux/namei.h |1 - 3

[patch 00/10] Use struct path in struct nameidata

2007-09-27 Thread jblunck
This is a respin of the patch series Andreas posted last month. It leaves out the restructuring of the intent which will be done at a later point in time. There are three preparing patches that remove unneeded code IMHO. I haven't got feedback from Takashi since he is on holiday. Please, can

[patch 02/10] Dont touch fs_struct in usermodehelper

2007-09-27 Thread jblunck
This test seems to be unnecessary since we always have rootfs mounted before calling a usermodehelper. Signed-off-by: Andreas Gruenbacher [EMAIL PROTECTED] Signed-off-by: Jan Blunck [EMAIL PROTECTED] --- kernel/kmod.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) Index:

[patch 04/10] Move struct path into its own header

2007-09-27 Thread jblunck
Move the definition of struct path into its own header file for further patches. Signed-off-by: Jan Blunck [EMAIL PROTECTED] Signed-off-by: Andreas Gruenbacher [EMAIL PROTECTED] --- include/linux/namei.h |6 +- include/linux/path.h | 12 2 files changed, 13 insertions(+),

[patch 08/10] Introduce path_get()

2007-09-27 Thread jblunck
This introduces the symmetric function to path_put() for getting a reference to the dentry and vfsmount of a struct path in the right order. Signed-off-by: Jan Blunck [EMAIL PROTECTED] Signed-off-by: Andreas Gruenbacher [EMAIL PROTECTED] --- fs/namei.c | 17 +++--

[patch 01/10] Dont touch fs_struct in drivers

2007-09-27 Thread jblunck
The sound drivers and the pnpbios core test for current-root != NULL. This test seems to be unnecessary since we always have rootfs mounted before initializing the drivers. Signed-off-by: Jan Blunck [EMAIL PROTECTED] --- drivers/pnp/pnpbios/core.c |2 -- sound/core/seq/seq_clientmgr.c |

[patch 07/10] Use path_put() in a few places instead of {mnt,d}put()

2007-09-27 Thread jblunck
Use path_put() in a few places instead of {mnt,d}put() Signed-off-by: Jan Blunck [EMAIL PROTECTED] Signed-off-by: Andreas Gruenbacher [EMAIL PROTECTED] --- fs/afs/mntpt.c |3 +-- fs/namei.c | 15 +-- 2 files changed, 6 insertions(+), 12 deletions(-) Index: b/fs/afs/mntpt.c

[patch 09/10] Use struct path in fs_struct

2007-09-27 Thread jblunck
* Use struct path in fs_struct. Signed-off-by: Andreas Gruenbacher [EMAIL PROTECTED] Signed-off-by: Jan Blunck [EMAIL PROTECTED] --- fs/dcache.c | 31 + fs/namei.c| 47 +- fs/namespace.c|

[patch 06/10] Introduce path_put()

2007-09-27 Thread jblunck
* Add path_put() functions for releasing a reference to the dentry and vfsmount of a struct path in the right order * Switch from path_release(nd) to path_put(nd-path) * Rename dput_path() to path_put_conditional() Signed-off-by: Jan Blunck [EMAIL PROTECTED] Signed-off-by: Andreas Gruenbacher

[patch 10/10] Make set_fs_{root,pwd} take a struct path

2007-09-27 Thread jblunck
In nearly all cases the set_fs_{root,pwd}() calls work on a struct path. Change the function to reflect this and use path_get() here. Signed-off-by: Jan Blunck [EMAIL PROTECTED] Signed-off-by: Andreas Gruenbacher [EMAIL PROTECTED] --- fs/namespace.c| 26 --

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Alan Cox
On Thu, 27 Sep 2007 07:01:18 -0700 Arjan van de Ven [EMAIL PROTECTED] wrote: On Thu, 27 Sep 2007 14:29:19 +0100 Alan Cox [EMAIL PROTECTED] wrote: The early LFS work that Linux uses favours EFBIG in various places. SuSv3 specifically uses EOVERFLOW for this as noted by Michael (Bug 7253)

Re: [PATCH 13/25] Unionfs: add un/likely conditionals on dir ops

2007-09-27 Thread Erez Zadok
In message [EMAIL PROTECTED], roel writes: Erez Zadok wrote: @@ -194,7 +194,7 @@ int check_empty(struct dentry *dentry, struct unionfs_dir_state **namelist) BUG_ON(!S_ISDIR(dentry-d_inode-i_mode)); - if ((err = unionfs_partial_lookup(dentry))) + if (unlikely((err =

[PATCH -mm1 0/2] Fix unlocked call to idr_find()

2007-09-27 Thread Nadia . Derbey
This a series of 2 patches that should be applied on top of the other ipc patches, in 2.6.23-rc6-mm1. The first one is an answer to the following issue pointed out by Jarek: Jarek Poplawski wrote: 1. ipc_lock() and ipc_lock_check() are used without ipc_ids.mutex, but it's probably wrong:

[PATCH -mm1 1/2] fixing idr_find() locking

2007-09-27 Thread Nadia . Derbey
[PATCH 01/02] This is a patch that fixes the way idr_find() used to be called in ipc_lock(): in all the paths that don't imply an update of the ipcs idr, it was called without the idr tree being locked. The changes are: . in ipc_ids, the mutex has been changed into a reader/writer semaphore.

[PATCH -mm1 2/2] Removing unneeded parameters

2007-09-27 Thread Nadia . Derbey
[PATCH 02/02] This is a trivial patch that removes the unneeded parameters from ipc_checkid() and ipc_buildid() interfaces. Signed-off-by: Nadia Derbey [EMAIL PROTECTED] --- This patch applies on top of the 2.6.23-rc6-mm1 ipc/msg.c |5 ++--- ipc/sem.c | 10 -- ipc/shm.c |

Re: PCI: Fix boot-time hang on G31/G33 PC

2007-09-27 Thread Ivan Kokshaysky
On Wed, Sep 26, 2007 at 03:20:40PM -0700, Jesse Barnes wrote: Ivan, your concern is about disabling things like interrupt controllers and power management chips during probe right? You're right that doing that could cause problems if we get and interrupt or PMU event at just the wrong

Re: sys_chroot+sys_fchdir Fix

2007-09-27 Thread Bill Davidsen
Theodore Tso wrote: On Thu, Sep 27, 2007 at 09:28:08AM +0200, Christer Weinigel wrote: So the OpenBSD man page seems to be in the minority here. Any portable code can not assume that CWD changes. And changing the Linux behaviour now would be a rather big change which might break userspace.

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Jens Axboe
On Thu, Sep 27 2007, Alan Cox wrote: On Thu, 27 Sep 2007 07:01:18 -0700 Arjan van de Ven [EMAIL PROTECTED] wrote: On Thu, 27 Sep 2007 14:29:19 +0100 Alan Cox [EMAIL PROTECTED] wrote: The early LFS work that Linux uses favours EFBIG in various places. SuSv3 specifically uses

Re: TCP Spike

2007-09-27 Thread Stephen Hemminger
On Thu, 27 Sep 2007 11:58:01 +0800 Majumder, Rajib [EMAIL PROTECTED] wrote: Hi, We have observed 40ms latency spikes in TCP connections in burst type of traffic. This affects regular TCP sockets. We observed this issue in kernels of 2.4.21 and kernel 2.6.5. Unfortunately, 2.6.5 is out of

Re: [git patches] umem driver cleanups

2007-09-27 Thread Jens Axboe
On Thu, Sep 27 2007, Jeff Garzik wrote: Please pull from 'umem' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git umem I'd be happy to pull these in through the block tree, if Neil (and/or the other maintainers - seems one single person should agree to be listed...)

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Alan Cox
Its a change of a specific error return from the wrong error to the right one, nothing more. Fixing the returned error gives us correct behaviour according to the standards and other systems. It may still break applications. Waving some standard at them if they complain is unlikely to

Re: Network slowdown due to CFS

2007-09-27 Thread Jarek Poplawski
On Thu, Sep 27, 2007 at 03:31:23PM +0200, Ingo Molnar wrote: * Jarek Poplawski [EMAIL PROTECTED] wrote: ... OK, but let's forget about fixing iperf. Probably I got this wrong, but I've thought this bad iperf patch was tested on a few nixes and linux was the most different one. The main

Re: Warnings and Oops on 2.6.23-rc6 while activily using rfcomm links (mm/slab.c)

2007-09-27 Thread Pierre-Yves Paulus
Hello, Please use CONFIG_SLUB and turn on SLUB debugging. Something is very wrong somewhere... I did so, on 2.6.23-rc8. I also did include CONFIG_DEBUG_DRIVER and CONFIG_DEBUG_KOBJECT, following Cornelia Huck's advice. Did you see any messages (from the driver core) surrounding

Re: [PATCH] Module use count must be updated as bridges are created/destroyed

2007-09-27 Thread Stephen Hemminger
On Thu, 27 Sep 2007 08:40:10 +0100 Jan Beulich [EMAIL PROTECTED] wrote: Stephen Hemminger [EMAIL PROTECTED] 26.09.07 19:12 On Wed, 26 Sep 2007 17:08:19 +0100 Jan Beulich [EMAIL PROTECTED] wrote: Stephen Hemminger [EMAIL PROTECTED] 26.09.07 17:37 On Wed, 26 Sep 2007 08:53:27 +0100

Re: why network devices don't do reference counting? (Re: [PATCH] Module use count must be updated as bridges are created/destroyed)

2007-09-27 Thread Stephen Hemminger
On Thu, 27 Sep 2007 13:54:23 +0200 Helge Hafting [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: On Thu, 27 Sep 2007 00:18:55 +0200 (CEST) Jan Engelhardt [EMAIL PROTECTED] wrote: On Sep 26 2007 14:06, Stephen Hemminger wrote: No, network devices don't do reference

[PATCH] Some IO scheduler cleanup in Documentation/block

2007-09-27 Thread Alan D. Brunelle
[PATCH] Some IO scheduler cleanup in Documentation/block as-iosched.txt: o Changed IO scheduler selection text to a reference to the switching-sched.txt file. o Fixed typo: 'for up time...' - 'for up to...' o Added short description of the est_time file. deadline-iosched.txt:

Re: why network devices don't do reference counting? (Re: [PATCH] Module use count must be updated as bridges are created/destroyed)

2007-09-27 Thread Jan Engelhardt
On Sep 27 2007 07:51, Stephen Hemminger wrote: You need every socket to close and all routes to go away including the routes through loopback device, and still there probably are control sockets buried inside ipv6 that hold ref count. IMHO the kernel should just admit that IPV6 can't be

[PATCH -mm] Hook up group scheduler with control groups

2007-09-27 Thread Srivatsa Vaddagiri
Andrew, This is a resend of the patch I had sent earlier at: http://marc.info/?l=linux-kernelm=119065506607858 This patch enables group cpu scheduler feature to work with control groups. Could you include this in -mm for folks to test it? -- Enable cgroup (formerly containers)

Re: [PATCH] Module use count must be updated as bridges are created/destroyed

2007-09-27 Thread Jan Beulich
Sounds like a module utilities problem since unloading one module doesn't normally unload others. I have to disagree here - 'modprobe -r' is specifically unloading all modules the specified one references as long as they have a use count of zero. The difference to other networking modules

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Jens Axboe
On Thu, Sep 27 2007, Alan Cox wrote: Its a change of a specific error return from the wrong error to the right one, nothing more. Fixing the returned error gives us correct behaviour according to the standards and other systems. It may still break applications. Waving some standard

kernel 2.6.23-rc6 hangs on Geode GX1

2007-09-27 Thread Marco Tralli
Hello all, I have random hangs on kernel boot or after few minutes on a NatSemi Geode GX1 based PC-104 (from Advantech) using kernel 2.6.23-rc6. The system locks, no way to use SysRq key, no usefull logs. No problems using kernel 2.6.21 series that I was using before with same config options. I

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Alan Cox
Well it's not my call, just seems like a really bad idea to change the error value. You can't claim full coverage for such testing anyway, it's one of those things that people will complain about two releases later saying it broke app foo. Strange since we've spent years changing error values

Floating Point Issue

2007-09-27 Thread mahamuni ashish
I have small code #include stdio.h #include string.h int main() { float f= 1256.35; char ch[4]; printf(\n1. f : %f,f); memset(ch,'\0',strlen(ch) ); printf(\n2. f : %f,f); return 0; } Expected output is 1. f : 1256.35 2. f : 1256.35 But I am getting the output (on windows) 1. f : 1256.35

Re: 2.6.23-rc8-mm2: problems on HP nx6325

2007-09-27 Thread Rafael J. Wysocki
On Thursday, 27 September 2007 11:22, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/ - The scheduler devel tree has been restored - The driver tree is presently busted, so I reverted it to the 2..23-rc8-mm1 version. -

Re: [PATCH] writeback: remove unnecessary wait in throttle_vm_writeout()

2007-09-27 Thread Rik van Riel
On Thu, 27 Sep 2007 09:50:16 +0800 Fengguang Wu [EMAIL PROTECTED] wrote: We don't want to introduce pointless delays in throttle_vm_writeout() when the writeback limits are not yet exceeded, do we? Good catch. Signed-off-by: Fengguang Wu [EMAIL PROTECTED] Reviewed-by: Rik van Riel [EMAIL

Re: [RFC] QoS params patch

2007-09-27 Thread Mark Gross
On Thu, Sep 27, 2007 at 12:18:21PM +0900, Paul Mundt wrote: On Wed, Sep 26, 2007 at 10:53:03PM -0400, [EMAIL PROTECTED] wrote: On Wed, 26 Sep 2007 17:40:20 PDT, Mark Gross said: --- linux-2.6.23-rc8/kernel/Makefile 2007-09-26 13:54:54.0 -0700 +++

Re: Floating Point Issue

2007-09-27 Thread Jan Engelhardt
On Sep 27 2007 12:41, mahamuni ashish wrote: I have small code This is not a kernel problem. (Read your C book and/or ask in a C newsgroup.) char ch[4]; memset(ch,'\0',strlen(ch) ); - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: Floating Point Issue

2007-09-27 Thread Xavier Bestel
On Thu, 2007-09-27 at 12:41 +0100, mahamuni ashish wrote: int main() { float f= 1256.35; char ch[4]; printf(\n1. f : %f,f); memset(ch,'\0',strlen(ch) ); Can't work. ch[]'s content is undefined, so strlen(ch) may read anywhere in memory, and/or memset() write anywhere. Xav - To

Re: 2.6.23-rc8: Known regressions from 2.6.22

2007-09-27 Thread Meelis Roos
http://lkml.org/lkml/2007/9/22/64 Created: http://bugzilla.kernel.org/show_bug.cgi?id=9087 Please add a summary of your observations to this bug entry. Added; However, it's assigned to serial devices, while imput devices should be more appropriate for PS2 mouse? -- Meelis Roos ([EMAIL

Re: kernel 2.6.23-rc6 hangs on Geode GX1

2007-09-27 Thread R. J. Wysocki
On Thursday, 27 September 2007 16:44, Marco Tralli wrote: Hello all, I have random hangs on kernel boot or after few minutes on a NatSemi Geode GX1 based PC-104 (from Advantech) using kernel 2.6.23-rc6. The system locks, no way to use SysRq key, no usefull logs. Please see:

Re: kernel 2.6.23-rc6 hangs on Geode GX1

2007-09-27 Thread Jordan Crouse
On 27/09/07 17:30 +0200, R. J. Wysocki wrote: On Thursday, 27 September 2007 16:44, Marco Tralli wrote: Hello all, I have random hangs on kernel boot or after few minutes on a NatSemi Geode GX1 based PC-104 (from Advantech) using kernel 2.6.23-rc6. The system locks, no way to use SysRq

Re: Floating Point Issue

2007-09-27 Thread Al Viro
On Thu, Sep 27, 2007 at 12:41:41PM +0100, mahamuni ashish wrote: I have small code #include stdio.h #include string.h int main() { float f= 1256.35; char ch[4]; printf(\n1. f : %f,f); memset(ch,'\0',strlen(ch) ); strlen() applied to uninitialized array = undefined behaviour.

<    1   2   3   4   5   6   7   8   >