Re: ecryptfs-kmem_cache-objects-for-multiple-keys-init-exit-functions.patch

2007-09-27 Thread Michael Halcrow
On Fri, Aug 03, 2007 at 11:42:49AM -0700, Andrew Morton wrote: ecryptfs_init() should be converted to the usual `goto out_foo' unwinding so we don't need N duplicated copies of the error recovery code. if (foo()) goto out; if (bar()) goto out_foo;

NFS server development update

2007-09-27 Thread J. Bruce Fields
These days Neil Brown and I are maintaining the NFS server together, and I'm currently (as of the last few weeks) tracking the to-be-submitted patches. I have limited time and am not expert on all of the relevant code, so I depend on your help! I'm still experimenting a bit with the process

Re: [RFC] QoS params patch

2007-09-27 Thread Mark Gross
On Wed, Sep 26, 2007 at 10:53:03PM -0400, [EMAIL PROTECTED] wrote: On Wed, 26 Sep 2007 17:40:20 PDT, Mark Gross said: (others here are probably better at spotting leaks and races than I am, so I'm skipping those and picking other nits. ;) --- linux-2.6.23-rc8/kernel/Makefile

Re: [RFC] QoS params patch

2007-09-27 Thread Mark Gross
On Wed, Sep 26, 2007 at 09:05:15PM -0700, Randy Dunlap wrote: On Thu, 27 Sep 2007 11:24:40 +0900 Paul Mundt wrote: +/* static helper functions */ +static s32 max_compare(s32 v1, s32 v2) +{ + if (v1 v2) + return v2; + else + return v1; +} + +static

Re: State of the Linux PCI Subsystem for 2.6.23-rc8

2007-09-27 Thread Greg KH
On Thu, Sep 27, 2007 at 03:22:35AM -0400, Jeff Garzik wrote: Greg KH wrote: On Wed, Sep 26, 2007 at 11:40:58PM +0200, Brice Goglin wrote: Greg KH wrote: Here's a summary of the current state of the Linux PCI subsystem, as of 2.6.23-rc8. If the information in here is incorrect, or anyone

Re: NFS server development update

2007-09-27 Thread J. Bruce Fields
On Thu, Sep 27, 2007 at 11:32:33AM -0400, J. Bruce Fields wrote: I'll follow up with a summary of the patches I currently have. ... but this time around that's nothing major--mostly just small bugfixes and cleanup, including 64 bit inode support from Peter Staubach and some preparation for

Re: [REGRESSION from 2.6.23-rc8] (was: Re: 2.6.23-rc4-mm1 and -rc6-mm1: boot failure on HP nx6325, related to clockevents)

2007-09-27 Thread Rafael J. Wysocki
On Thursday, 27 September 2007 01:21, Thomas Gleixner wrote: On Thu, 2007-09-27 at 01:30 +0200, Rafael J. Wysocki wrote: Tested for a couple of times with each kernel, the results seem to be reproducible 100% of the time. Thanks for going through this debug marathon. No big

Re: 2.6.23-rc8-mm2: problems on HP nx6325

2007-09-27 Thread Rafael J. Wysocki
On Thursday, 27 September 2007 17:19, Rafael J. Wysocki wrote: On Thursday, 27 September 2007 11:22, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/ - The scheduler devel tree has been restored - The driver tree is

Re: [PATCH RFC 3/9] RCU: Preemptible RCU

2007-09-27 Thread Paul E. McKenney
On Wed, Sep 26, 2007 at 07:13:51PM +0400, Oleg Nesterov wrote: On 09/23, Paul E. McKenney wrote: On Sun, Sep 23, 2007 at 09:38:07PM +0400, Oleg Nesterov wrote: Isn't DEFINE_PER_CPU_SHARED_ALIGNED better for rcu_flip_flag and rcu_mb_flag? Looks like it to me, thank you for the tip!

Re: 2.6.23-rc8-mm2: problems on HP nx6325

2007-09-27 Thread Thomas Gleixner
On Thu, 2007-09-27 at 17:59 +0200, Rafael J. Wysocki wrote: 2) CPU hotplug is busted (onlining of CPU1 kills the kernel), probably due to the same issue that I'm having with the -hrt version of 2.6.23-rc8 (we're debugging it right now) This one is fixed by the following patch:

correct kernel parameter in documentation.

2007-09-27 Thread Dave Jones
'noacpi' isn't a standalone parameter, give it its prefix. Signed-off-by: Dave Jones [EMAIL PROTECTED] diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 4d175c7..a87bc58 100644 --- a/Documentation/kernel-parameters.txt +++

Re: kernel 2.6.23-rc6 hangs on Geode GX1

2007-09-27 Thread Rafael J. Wysocki
On Thursday, 27 September 2007 17:22, Jordan Crouse wrote: On 27/09/07 17:30 +0200, R. J. Wysocki wrote: On Thursday, 27 September 2007 16:44, Marco Tralli wrote: Hello all, I have random hangs on kernel boot or after few minutes on a NatSemi Geode GX1 based PC-104 (from Advantech)

Re: 2.6.23-rc8: Known regressions from 2.6.22

2007-09-27 Thread Rafael J. Wysocki
On Thursday, 27 September 2007 17:21, Meelis Roos wrote: http://lkml.org/lkml/2007/9/22/64 Created: http://bugzilla.kernel.org/show_bug.cgi?id=9087 Please add a summary of your observations to this bug entry. Added; Thanks However, it's assigned to serial devices, while imput

Add /dev/oldmem to devices.txt documenation.

2007-09-27 Thread Dave Jones
Signed-off-by: Dave Jones [EMAIL PROTECTED] diff --git a/Documentation/devices.txt b/Documentation/devices.txt index 8de132a..6c46730 100644 --- a/Documentation/devices.txt +++ b/Documentation/devices.txt @@ -94,6 +94,8 @@ Your cooperation is appreciated. 9 = /dev/urandom

Re: lockdep wierdness...

2007-09-27 Thread Peter Zijlstra
On Thu, 2007-09-27 at 15:00 +0100, Christoph Hellwig wrote: On Thu, Sep 27, 2007 at 03:51:07PM +0200, Peter Zijlstra wrote: Christoph, does Steve's story make sense? Yes. All that would need to be done is add an extra lock_class_key to file_system_type for i_mutex_dir_key, and

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Theodore Tso
On Thu, Sep 27, 2007 at 04:19:12PM +0100, Alan Cox wrote: Well it's not my call, just seems like a really bad idea to change the error value. You can't claim full coverage for such testing anyway, it's one of those things that people will complain about two releases later saying it broke

Re: correct kernel parameter in documentation.

2007-09-27 Thread Robert P. J. Day
On Thu, 27 Sep 2007, Dave Jones wrote: 'noacpi' isn't a standalone parameter, give it its prefix. Signed-off-by: Dave Jones [EMAIL PROTECTED] diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 4d175c7..a87bc58 100644 ---

Re: kernel 2.6.23-rc6 hangs on Geode GX1

2007-09-27 Thread Marco Tralli
On 27/09/07 17:30 +0200, R. J. Wysocki wrote: On Thursday, 27 September 2007 16:44, Marco Tralli wrote: Hello all, I have random hangs on kernel boot or after few minutes on a NatSemi Geode GX1 based PC-104 (from Advantech) using kernel 2.6.23-rc6. The system locks, no way to use

Re: commit 6dccd16b7c2703e8bbf8bca62b5cf248332afbe2 kills r8169 send performance

2007-09-27 Thread Timo Jantunen
On Wed, 26 Sep 2007, Francois Romieu wrote: Apply and try each patch of the attached tarball on top of 2.6.23-git until the behavior changes (assuming it does). Patch #000n applies on top of patch #000(n - 1). I tested the series on top of -rc8 and 0005 did the trick. And if I use 0005

Re: kernel 2.6.23-rc6 hangs on Geode GX1

2007-09-27 Thread Juergen Beisert
Hi AMrco, On Thursday 27 September 2007 16:44, Marco Tralli wrote: I have random hangs on kernel boot or after few minutes on a NatSemi Geode GX1 based PC-104 (from Advantech) using kernel 2.6.23-rc6. The system locks, no way to use SysRq key, no usefull logs. No problems using kernel 2.6.21

Re: correct kernel parameter in documentation.

2007-09-27 Thread Alan Cox
if you're going to add that libata-related parm to the kernel parms file, wouldn't it make sense for consistency to add the other available boot-time parms from libata-core.c as well? it seems counter-productive to document only a subset of them from the same source file. He's not adding it

Re: [RFC] QoS params patch

2007-09-27 Thread Mark Gross
On Thu, Sep 27, 2007 at 11:24:40AM +0900, Paul Mundt wrote: On Wed, Sep 26, 2007 at 03:40:26PM -0700, Mark Gross wrote: + struct list_head list; + union { + s32 value; + s32 usec; + s32 kbps; + }; + char *name; Your } is in a strange

Re: kernel 2.6.23-rc6 hangs on Geode GX1

2007-09-27 Thread Marco Tralli
On Thursday, 27 September 2007 17:22, Jordan Crouse wrote: On 27/09/07 17:30 +0200, R. J. Wysocki wrote: On Thursday, 27 September 2007 16:44, Marco Tralli wrote: Hello all, I have random hangs on kernel boot or after few minutes on a NatSemi Geode GX1 based PC-104 (from

Re: kernel 2.6.23-rc6 hangs on Geode GX1

2007-09-27 Thread Marco Tralli
Thanks Juergen, It runs stable on 5 different GX1 systems. But I do not use a standard BIOS. I'm using LinuxBIOS instead. But I'm also using these patches. set_cx86_inc was one of performance trick called by geode_configure I didn't find any documentation about incrementor margin before.

Re: [Announce] Linux-tiny project revival

2007-09-27 Thread Indan Zupancic
On Thu, September 27, 2007 09:00, Arnd Bergmann wrote: Assuming that we want to go down that road, I think you can do better with more evil macro magic, by using something along the lines of #define KERN_NOTICE 5, #define PRINTK_CONTINUED , #define printk(level, str, ...) \ do { \

[PATCH] x86-64: pci-gart iommu sg chaining zeroes wrong sg.

2007-09-27 Thread FUJITA Tomonori
This patch is for Jens' block tree (sg chaining branch). I don't have the hardware but this looks like a bug. --- From: FUJITA Tomonori [EMAIL PROTECTED] Subject: [PATCH] x86-64: pci-gart iommu sg chaining zeroes a wrong sg's dma_length Needs to zero the end of the list. Signed-off-by: FUJITA

Re: Man page for revised timerfd API

2007-09-27 Thread Davide Libenzi
On Thu, 27 Sep 2007, Michael Kerrisk wrote: Hi Davide, A follow up to the man page text. Does passing a timerfd file descriptor via a Unix domain socket to another process do the expected thing? That is, the receiving process will be able to read from the file descriptor in order to

Re: Man page for revised timerfd API

2007-09-27 Thread Davide Libenzi
On Thu, 27 Sep 2007, Michael Kerrisk wrote: Davide, A further question: what is the expected behavior in the following scenario: 1. Create a timerfd and arm it. 2. Wait until M timer expirations have occurred 3. Modify the settings of the timer 4. Wait for N further timer expirations

Re: [PATCH] x86-64: pci-gart iommu sg chaining zeroes wrong sg.

2007-09-27 Thread FUJITA Tomonori
On Fri, 28 Sep 2007 01:38:27 +0900 FUJITA Tomonori [EMAIL PROTECTED] wrote: This patch is for Jens' block tree (sg chaining branch). I don't have the hardware but this looks like a bug. --- From: FUJITA Tomonori [EMAIL PROTECTED] Subject: [PATCH] x86-64: pci-gart iommu sg chaining zeroes

Re: 2.6.23-rc8-mm2: problems on HP nx6325

2007-09-27 Thread Sam Ravnborg
Hi Rafael. Fix CPU hotplug breakage on HP nx6325 and similar boxes caused by a reference to disable_apic_timer (labeled as __initdata) from the CPU initialization code. Signed-off-by: Rafael J. Wysocki [EMAIL PROTECTED] --- arch/x86_64/kernel/apic.c |2 +- 1 file changed, 1

Re: eventfd.2 man page

2007-09-27 Thread Davide Libenzi
On Thu, 27 Sep 2007, Michael Kerrisk wrote: Hi Davide, I've slightly tweaked the eventfd.2 man page in preparation for adding it to the man-pages set. Could you please review the text below, and confirm that it correctly describes intended behavior. Looks good to me. At the time that I

[PATCH] UML - Correctly handle skb allocation failures

2007-09-27 Thread Jeff Dike
Handle memory allocation failures when reading packets. We have to read something from the host, even if we can't allocate any memory. If we don't, the host side of the device may fill up and stop delivering interrupts because no new packets can be queued. A single sk_buff is allocated whenever

Re: Revised signalfd man-page

2007-09-27 Thread Davide Libenzi
On Thu, 27 Sep 2007, Michael Kerrisk wrote: .\ Copyright (C) 2007 Michael Kerrisk [EMAIL PROTECTED] .\ starting from a version by Davide Libenzi [EMAIL PROTECTED] .\ .\ This program is free software; you can redistribute it and/or modify .\ it under the terms of the GNU General Public

Re: [PATCH] Add iSCSI iBFT support.

2007-09-27 Thread H. Peter Anvin
Konrad Rzeszutek wrote: +config ISCSI_IBFT + tristate iSCSI Boot Firmware Table Attributes + depends on X86 why only on X86? PowerPC exports this data via the OpenFirmware so it already shows in the /sysfs entries. I was thinking to combine those sysfs entries under this code, but

Re: [PATCH] Add iSCSI iBFT support.

2007-09-27 Thread Peter Jones
H. Peter Anvin wrote: Konrad Rzeszutek wrote: +config ISCSI_IBFT + tristate iSCSI Boot Firmware Table Attributes + depends on X86 why only on X86? PowerPC exports this data via the OpenFirmware so it already shows in the /sysfs entries. I was thinking to combine those sysfs

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 11:59:02 -0400 Theodore Tso [EMAIL PROTECTED] wrote: On Thu, Sep 27, 2007 at 04:19:12PM +0100, Alan Cox wrote: Well it's not my call, just seems like a really bad idea to change the error value. You can't claim full coverage for such testing anyway, it's one of those

Re: 2.6.23-rc8-mm1 -- powerpc link failure

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 14:13:21 +0200 (CEST) Jiri Kosina [EMAIL PROTECTED] wrote: On Thu, 27 Sep 2007, Andy Whitcroft wrote: Ok, this problem seems to still persist in 2.6.23-rc8-mm2. It seems we have three options from here: 1) update the compiler support list to exclude these compilers,

[PATCH] ext4: remove #ifdef CONFIG_EXT4_INDEX

2007-09-27 Thread Eric Sandeen
CONFIG_EXT4_INDEX is not an exposed config option in the kernel, and it is unconditionally defined in ext4_fs.h. tune2fs is already able to turn off dir indexing, so at this point it's just cluttering up the code. Remove it. Signed-off-by: Eric Sandeen [EMAIL PROTECTED] Index:

[PATCH] ext3: remove #ifdef CONFIG_EXT3_INDEX

2007-09-27 Thread Eric Sandeen
CONFIG_EXT3_INDEX is not an exposed config option in the kernel, and it is unconditionally defined in ext3_fs.h. tune2fs is already able to turn off dir indexing, so at this point it's just cluttering up the code. Remove it. Signed-off-by: Eric Sandeen [EMAIL PROTECTED] Index:

Re: Revised signalfd man-page

2007-09-27 Thread Michael Kerrisk
Von: Davide Libenzi [EMAIL PROTECTED] On Thu, 27 Sep 2007, Michael Kerrisk wrote: [...] .\ FIXME Davide, what does the following mean? How (in userspace .\ terms) does a sighand structure become orphaned? The .BR read (2) call can also return 0, in case the sighand structure to

Re: [PATCH] Add iSCSI iBFT support.

2007-09-27 Thread H. Peter Anvin
Peter Jones wrote: It should, presumably, depend on ACPI, rather than on X86...? Actually no. That /should/ be the correct answer, but none of the hardware vendors actually provide the table via ACPI yet. Also, if they did, the support for /sys/firmware/acpi/tables/* would be sufficient

Re: sata_sil24 broken since 2.6.23-rc4-mm1

2007-09-27 Thread Torsten Kaiser
On 9/27/07, Jeff Garzik [EMAIL PROTECTED] wrote: Torsten Kaiser wrote: I compared the dmesg form good and bad boots with -rc7-mm1 but could not see any difference, so do you think that these additional diagnostics could show a difference? Or could you suggest any other debugging options I

Re: Add /dev/oldmem to devices.txt documenation.

2007-09-27 Thread H. Peter Anvin
Dave Jones wrote: Signed-off-by: Dave Jones [EMAIL PROTECTED] diff --git a/Documentation/devices.txt b/Documentation/devices.txt index 8de132a..6c46730 100644 --- a/Documentation/devices.txt +++ b/Documentation/devices.txt @@ -94,6 +94,8 @@ Your cooperation is appreciated.

Re: [PATCH -mm] Hook up group scheduler with control groups

2007-09-27 Thread Randy Dunlap
On Thu, 27 Sep 2007 20:36:24 +0530 Srivatsa Vaddagiri wrote: Andrew, This is a resend of the patch I had sent earlier at: http://marc.info/?l=linux-kernelm=119065506607858 This patch enables group cpu scheduler feature to work with control groups. Could you include this in

[patch] rename signalfd_siginfo fields

2007-09-27 Thread Davide Libenzi
For Michael Kerrisk request, the following patch renames signalfd_siginfo fields in order to keep them consistent with the siginfo_t ones. Signed-off-by: Davide Libenzi [EMAIL PROTECTED] - Davide --- fs/signalfd.c| 44 ++--

Re: [patch 02/10] Dont touch fs_struct in usermodehelper

2007-09-27 Thread Greg KH
On Thu, Sep 27, 2007 at 04:12:02PM +0200, [EMAIL PROTECTED] wrote: This test seems to be unnecessary since we always have rootfs mounted before calling a usermodehelper. Are you sure this is true? I thought we called the usermode helper for hotplug _very_ early in the boot sequence when the

Re: [PATCH] Add iSCSI iBFT support.

2007-09-27 Thread Peter Jones
H. Peter Anvin wrote: Peter Jones wrote: It should, presumably, depend on ACPI, rather than on X86...? Actually no. That /should/ be the correct answer, but none of the hardware vendors actually provide the table via ACPI yet. Also, if they did, the support for /sys/firmware/acpi/tables/*

Re: 2.6.23-rc8-mm2: problems on HP nx6325

2007-09-27 Thread Randy Dunlap
On Thu, 27 Sep 2007 18:53:46 +0200 Sam Ravnborg wrote: Hi Rafael. Fix CPU hotplug breakage on HP nx6325 and similar boxes caused by a reference to disable_apic_timer (labeled as __initdata) from the CPU initialization code. Signed-off-by: Rafael J. Wysocki [EMAIL PROTECTED]

New 'Changes-licensed-under' tag introduced for Linux-wireless

2007-09-27 Thread Luis R. Rodriguez
Our guidelines for patches [1] for Linux-wireless has been updated. One section asks Linux-wireless developers to subscribe to the patch guideline wiki page (section 2) and another which introduces the new 'Changes-licensed-under' (section 10). Here I'll cover the new 'Changes-licensed-under' tag

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Greg KH
On Thu, Sep 27, 2007 at 10:23:43AM -0700, Andrew Morton wrote: On Thu, 27 Sep 2007 11:59:02 -0400 Theodore Tso [EMAIL PROTECTED] wrote: On Thu, Sep 27, 2007 at 04:19:12PM +0100, Alan Cox wrote: There are real things to worry about - sysfs, sysfs, sysfs, ... and all the other crap which

Re: [PATCH -mm] Hook up group scheduler with control groups

2007-09-27 Thread Dhaval Giani
On Thu, Sep 27, 2007 at 10:40:05AM -0700, Randy Dunlap wrote: On Thu, 27 Sep 2007 20:36:24 +0530 Srivatsa Vaddagiri wrote: Hi :) Uh, a few of my previous comments weren't fixed... (below) -- Enable cgroup (formerly containers) based fair group scheduling. This will let

Re: New 'Changes-licensed-under' tag introduced for Linux-wireless

2007-09-27 Thread Stephen Hemminger
On Thu, 27 Sep 2007 14:00:09 -0400 Luis R. Rodriguez [EMAIL PROTECTED] wrote: Our guidelines for patches [1] for Linux-wireless has been updated. One section asks Linux-wireless developers to subscribe to the patch guideline wiki page (section 2) and another which introduces the new

Re: Another Hitachi Disk with NCQ problems

2007-09-27 Thread Tejun Heo
Peter Schwabe wrote: Hello, in my Thinkpad T61 there is another Hitachi harddisk with NCQ problems (spurious completions during NCQ...). Model number: HITACHI HTS541612J9SA00 Serial number: SBDIC7JP Adding the line { HITACHI HTS541612J9SA00, SBDIC7JP, ATA_HORKAGE_NONCQ, }, to the

Re: Stardom SATA HSM violation

2007-09-27 Thread Tejun Heo
Mark Lord wrote: Tejun Heo wrote: Hello, Mark Lord wrote: I reported a very similar bug back a few releases ago. Anyone who wants to try it themselves, can do this with hdparm-7.7 (from sourceforge): hdparm --drq-hsm-error /dev/sda Whether or not it hangs the machine does depend upon

Re: Serial ATA does not find partitions (Hitachi HD, new? ATI controller) where old SATA works

2007-09-27 Thread Tejun Heo
Hernan G Solari wrote: Hello I am disturbing you with this problem because I think there is something to be learnt, I have no urgency or further-problem with my work-around. Description: trying to boot with kernel 2.6.22 the booting process stops not finding the root partition, in

Re: [PATCHSET 3/4] sysfs: divorce sysfs from kobject and driver model

2007-09-27 Thread Tejun Heo
Hello, Greg. Sorry about the late reply. I'm sandwiched between several release dates (I bet you know) and sudden burst of family/personal events (all kinds of them - good, annual and bad). Greg KH wrote: * sysfs becomes a separate module and driver model becomes a user of sysfs. Those two

Re: [PATCHSET 4/4] sysfs: implement new features

2007-09-27 Thread Tejun Heo
Hello, Greg. Please read the other reply first. We need some consensus there first. Greg KH wrote: * Notify pollers on file deactivation. This looks nice. Cool. * Name-formatting for symlinks. e.g. symlink pointing to /dira/dirb/leaf can be named as symlink:%1-%0 and it will show up

Re: Floating Point Issue

2007-09-27 Thread Trond Myklebust
On Thu, 2007-09-27 at 12:41 +0100, mahamuni ashish wrote: I have small code #include stdio.h #include string.h int main() { float f= 1256.35; char ch[4]; printf(\n1. f : %f,f); memset(ch,'\0',strlen(ch) ); printf(\n2. f : %f,f); return 0; } Expected output is 1. f :

Re: Stardom SATA HSM violation

2007-09-27 Thread Alan Cox
I think there have been enough cases where this draining was necessary. IIRC, ata_piix was involved in those cases, right? If so, can you please submit a patch which applies this only to affected controllers? I don't feel too confident about applying this to all SFF controllers. Old IDE

Re: PCI: Fix boot-time hang on G31/G33 PC

2007-09-27 Thread Kok, Auke
Ivan Kokshaysky wrote: On Wed, Sep 26, 2007 at 03:20:40PM -0700, Jesse Barnes wrote: Ivan, your concern is about disabling things like interrupt controllers and power management chips during probe right? You're right that doing that could cause problems if we get and interrupt or PMU event

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Matthew Wilcox
On Thu, Sep 27, 2007 at 02:37:42PM -0400, Theodore Tso wrote: I'm reminded of Rusty's 2003 OLS Keynote, where he points out that what's important is not making an interface easy to use, but _hard_ _to_ _misuse_. That fact that sysfs is all laid out in a directory, but for which some

[RFC][PATCH 1/5] get mount write in __dentry_open()

2007-09-27 Thread Dave Hansen
The first three patches here fix actual bugs. I think the last two will reduce the chance for any future bugs to creep in. RFC for now. -- This is a bug fix for the r/o bind mount patch set. We need to ensure taking a mnt write on the mnt referenced by any new struct file. ---

[RFC][PATCH 5/5] make open_namei() return a filp

2007-09-27 Thread Dave Hansen
If open_namei() succeeds, there is potentially a mnt_want_write() that needs to get balanced. If the caller doesn't create a 'struct file' and eventually __fput() it, or manually drop the write count on an error, we have a bug. Forcing open_namei() to return a filp fixes this. Any caller

[RFC][PATCH 2/5] move mnt_want_write() into open_namei_create()

2007-09-27 Thread Dave Hansen
In a moment, we're going to make may_open() stop doing the mnt_want/drop_write() pair. Doing this first makes the next patch simpler. --- lxc-dave/fs/namei.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff -puN

[patch] anon-inodes use open coded atomic_inc for the shared inode

2007-09-27 Thread Davide Libenzi
Since we know the shared inode count is always 0, we can avoid igrab() and use an open coded atomic_inc(). Signed-off-by: Davide Libenzi [EMAIL PROTECTED] - Davide --- fs/anon_inodes.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) Index:

[RFC][PATCH 4/5] do namei_flags calculation inside open_namei()

2007-09-27 Thread Dave Hansen
My end goal here is to make sure all users of may_open() return filps. This will ensure that we properly release mount write counts which were taken for the filp in may_open(). This patch moves the sys_open flags to namei flags calculation into fs/namei.c. We'll shortly be moving the

[RFC][PATCH 3/5] move mnt_want_write() out of may_open()

2007-09-27 Thread Dave Hansen
may_open() can fail in a lot of ways. It is also named such that it doesn't appear to be _taking_ action, just checking a bunch of conditions. So, it makes a poor place to take and release the mnt writer count. This moves the burder of taking the mnt writer counts into the callers. The

Re: New 'Changes-licensed-under' tag introduced for Linux-wireless

2007-09-27 Thread Alexey Dobriyan
On Thu, Sep 27, 2007 at 02:00:09PM -0400, Luis R. Rodriguez wrote: Our guidelines for patches [1] for Linux-wireless has been updated. One section asks Linux-wireless developers to subscribe to the patch guideline wiki page (section 2) and another which introduces the new

Re: [RFC][PATCH 5/5] make open_namei() return a filp

2007-09-27 Thread Christoph Hellwig
On Thu, Sep 27, 2007 at 11:52:15AM -0700, Dave Hansen wrote: If open_namei() succeeds, there is potentially a mnt_want_write() that needs to get balanced. If the caller doesn't create a 'struct file' and eventually __fput() it, or manually drop the write count on an error, we have a bug.

RE: [ofa-general] [PATCH v3] iw_cxgb3: Support iwarp-only interfacesto avoid 4-tuple conflicts.

2007-09-27 Thread Kanevsky, Arkady
Sean, What is the model on how client connects, say for iSCSI, when client and server both support, iWARP and 10GbE or 1GbE, and would like to setup most performant connection for ULP? Thanks, Arkady Kanevsky email: [EMAIL PROTECTED] Network Appliance Inc.

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Theodore Tso
On Thu, Sep 27, 2007 at 10:59:17AM -0700, Greg KH wrote: Come on now, I'm _very_ tired of this kind of discussion. Please go read the documentation on how to _use_ sysfs from userspace in such a way that you can properly access these data structures so that no breakage occurs. I've read it;

Re: [ofa-general] [PATCH v3] iw_cxgb3: Support iwarp-only interfaces to avoid 4-tuple conflicts.

2007-09-27 Thread Sean Hefty
The sysadmin creates for iwarp use only alias interfaces of the form devname:iw* where devname is the native interface name (eg eth0) for the iwarp netdev device. The alias label can be anything starting with iw. The iw immediately after the ':' is the key used by the iw_cxgb3 driver. I'm

Re: why network devices don't do reference counting?

2007-09-27 Thread David Miller
From: Helge Hafting [EMAIL PROTECTED] Date: Thu, 27 Sep 2007 13:54:23 +0200 Wouldn't it be enough to down all the interfaces and close all the sockets? No need to bring down every app. And there are routes, and neighbour cache entries, and all sorts of external references to the stack. For

Re: [PATCH -mm] Hook up group scheduler with control groups

2007-09-27 Thread Randy Dunlap
On Thu, 27 Sep 2007 23:34:15 +0530 Dhaval Giani wrote: +config RESOURCE_COUNTERS + bool Resource counters + help + This option enables controller independent resource accounting + infrastructure that works with cgroups Use tab + 2 spaces consistently for help text

Re: why network devices don't do reference counting?

2007-09-27 Thread David Miller
From: Jan Engelhardt [EMAIL PROTECTED] Date: Thu, 27 Sep 2007 16:55:36 +0200 (CEST) On Sep 27 2007 07:51, Stephen Hemminger wrote: You need every socket to close and all routes to go away including the routes through loopback device, and still there probably are control sockets buried

Re: 2.6.23-rc8-mm2: problems on HP nx6325

2007-09-27 Thread Sam Ravnborg
On Thu, Sep 27, 2007 at 10:33:51AM -0700, Randy Dunlap wrote: On Thu, 27 Sep 2007 18:53:46 +0200 Sam Ravnborg wrote: Hi Rafael. Fix CPU hotplug breakage on HP nx6325 and similar boxes caused by a reference to disable_apic_timer (labeled as __initdata) from the CPU initialization

Re: 2.6.23-rc8-mm2: BUG near reiserfs_xattr_set

2007-09-27 Thread Laurent Riffard
Le 27.09.2007 11:22, Andrew Morton a écrit : ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/ I've got this BUG a few seconds after I logged in into Gnome desktop : [partially hand copied BUG] BUG: unable to handle kernel NULL pointer dereference at

Re: [ofa-general] [PATCH v3] iw_cxgb3: Support iwarp-only interfaces to avoid 4-tuple conflicts.

2007-09-27 Thread Steve Wise
Sean Hefty wrote: The sysadmin creates for iwarp use only alias interfaces of the form devname:iw* where devname is the native interface name (eg eth0) for the iwarp netdev device. The alias label can be anything starting with iw. The iw immediately after the ':' is the key used by the

Re: [PATCHSET 3/4] sysfs: divorce sysfs from kobject and driver model

2007-09-27 Thread Eric W. Biederman
I still need to look at the code in detail but I have some concerns I want to inject into this conversation of future sysfs architecture. - If we want to carefully limit sysfs from going to wild code review is clearly not enough. We need some technological measures to assist us. As the

RE: [ofa-general] [PATCH v3] iw_cxgb3: Support iwarp-onlyinterfacesto avoid 4-tuple conflicts.

2007-09-27 Thread Sean Hefty
What is the model on how client connects, say for iSCSI, when client and server both support, iWARP and 10GbE or 1GbE, and would like to setup most performant connection for ULP? For the most performance connection, the ULP would use IB, and all these problems go away. :) This proposal is for

Re: [RFC][PATCH] kill do_filp_open()

2007-09-27 Thread Christoph Hellwig
On Thu, Sep 27, 2007 at 12:08:23PM -0700, Dave Hansen wrote: This kills off the almost empty do_filp_open(). However, let's keep filp_open() around. It does the nameidata allocation on the stack, and also adds the AT_FDCWD argument. I think that's enough to keep it around. So why would

[RFC][PATCH] kill do_filp_open()

2007-09-27 Thread Dave Hansen
This kills off the almost empty do_filp_open(). However, let's keep filp_open() around. It does the nameidata allocation on the stack, and also adds the AT_FDCWD argument. I think that's enough to keep it around. --- lxc-dave/fs/open.c | 40 ++-- 1 file

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-27 Thread Brett Warden
Fixes use of parport_write_control() to match the newer interface that requires explicit parport_data_reverse() and parport_data_forward() calls. This eliminates the following error message and restores the original intended behavior: parport0 (bw-qcam): use data_reverse for this! Also increases

Re: 2.6.23-rc8-mm1 -- powerpc link failure

2007-09-27 Thread Sam Ravnborg
On Thu, Sep 27, 2007 at 10:13:42AM -0700, Andrew Morton wrote: On Thu, 27 Sep 2007 14:13:21 +0200 (CEST) Jiri Kosina [EMAIL PROTECTED] wrote: On Thu, 27 Sep 2007, Andy Whitcroft wrote: Ok, this problem seems to still persist in 2.6.23-rc8-mm2. It seems we have three options from

Re: 2.6.23-rc8-mm2: problems on HP nx6325

2007-09-27 Thread Rafael J. Wysocki
On Thursday, 27 September 2007 21:19, Sam Ravnborg wrote: On Thu, Sep 27, 2007 at 10:33:51AM -0700, Randy Dunlap wrote: On Thu, 27 Sep 2007 18:53:46 +0200 Sam Ravnborg wrote: Hi Rafael. Fix CPU hotplug breakage on HP nx6325 and similar boxes caused by a reference to

Re: TCP Spike

2007-09-27 Thread Ilpo Järvinen
On Thu, 27 Sep 2007, Majumder, Rajib wrote: We have observed 40ms latency spikes in TCP connections in burst type of traffic. This affects regular TCP sockets. Are segments being sent full-sized, or is there perhaps some Nagle component in it as well? I.e., are the applications using

Re: [PATCH -mm] Hook up group scheduler with control groups

2007-09-27 Thread Dhaval Giani
On Thu, Sep 27, 2007 at 12:00:33PM -0700, Randy Dunlap wrote: On Thu, 27 Sep 2007 23:34:15 +0530 Dhaval Giani wrote: +config RESOURCE_COUNTERS + bool Resource counters + help + This option enables controller independent resource accounting Above line is tab + 2 spaces

Re: 2.6.23-rc8-mm2: problems on HP nx6325

2007-09-27 Thread Randy Dunlap
On Thu, 27 Sep 2007 21:48:59 +0200 Rafael J. Wysocki wrote: On Thursday, 27 September 2007 21:19, Sam Ravnborg wrote: On Thu, Sep 27, 2007 at 10:33:51AM -0700, Randy Dunlap wrote: On Thu, 27 Sep 2007 18:53:46 +0200 Sam Ravnborg wrote: Hi Rafael. Fix CPU hotplug breakage

Re: + oom-prevent-including-schedh-in-header-file.patch added to -mm tree

2007-09-27 Thread Alexey Dobriyan
It's not necessary to include all of linux/sched.h in linux/oom.h. Instead, simply include prototypes for the relevant structs and include linux/types.h for gfp_t. Cc: Andrea Arcangeli [EMAIL PROTECTED] Cc: Christoph Lameter [EMAIL PROTECTED] Cc: Alexey Dobriyan [EMAIL PROTECTED]

Re: [PATCH -mm] Hook up group scheduler with control groups

2007-09-27 Thread Frans Pop
Dhaval Giani wrote: +config FAIR_CGROUP_SCHED + bool Control groups + depends on CGROUPS + help There are also stray spaces before the tab on the last two lines above. Cheers, Frans Pop - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: 2.6.23-rc8-mm2: problems on HP nx6325

2007-09-27 Thread Rafael J. Wysocki
On Thursday, 27 September 2007 21:37, Randy Dunlap wrote: On Thu, 27 Sep 2007 21:48:59 +0200 Rafael J. Wysocki wrote: On Thursday, 27 September 2007 21:19, Sam Ravnborg wrote: On Thu, Sep 27, 2007 at 10:33:51AM -0700, Randy Dunlap wrote: On Thu, 27 Sep 2007 18:53:46 +0200 Sam Ravnborg

[PATCH mm 1/3] fix BUG at include/linux/mm.h:220!

2007-09-27 Thread Hugh Dickins
a.k.a. mm-use-pagevec-to-rotate-reclaimable-page-fix-3.patch put_page_testzero's VM_BUG_ON(atomic_read(page-_count) == 0) fired a couple of times while heavily swapping (on -rc7-mm1 and -rc8-mm1). release_pages() has been using spin_lock_irq/spin_unlock_irq: but now that it's being called by

Re: 2.6.23-rc8-mm2: BUG near reiserfs_xattr_set

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 21:18:55 +0200 Laurent Riffard [EMAIL PROTECTED] wrote: Le 27.09.2007 11:22, Andrew Morton a écrit : ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/ I've got this BUG a few seconds after I logged in into Gnome desktop :

[PATCH mm 2/3] kill redundancy in rotate_reclaimable_page

2007-09-27 Thread Hugh Dickins
a.k.a. mm-use-pagevec-to-rotate-reclaimable-page-cleanup.patch diff -U5 shows rotate_reclaimable_page() is pointlessly testing PageActive and PageLRU twice in a row: of course there used to be a lock taken in between those tests; but now that pagevec_move_tail() is making those tests under lock,

[PATCH mm 3/3] move_tail_pages into lru_add_drain

2007-09-27 Thread Hugh Dickins
a.k.a. mm-use-pagevec-to-rotate-reclaimable-page-cleanup-2.patch Opinions may differ, but I'm uneasy with leaving pages to be rotated on their pagevecs for too long: although they're still visible via the LRU, their page counts are raised, which excludes them from some operations. Memory hotplug

Re: 2.6.23-rc8-mm2: BUG near reiserfs_xattr_set

2007-09-27 Thread Dave Hansen
On Thu, 2007-09-27 at 12:48 -0700, Andrew Morton wrote: Hi, Dave! It's fully reproducible. /home is mounted with the following options: /dev/mapper/vglinux1-lvhome on /home type reiserfs (rw,noatime,nodiratime,user_xattr) This BUG happened with rc8-mm1 too. rc6-mm1 works

Re: New 'Changes-licensed-under' tag introduced for Linux-wireless

2007-09-27 Thread Krzysztof Halasa
Stephen Hemminger [EMAIL PROTECTED] writes: No, please don't down this legal rat hole. It would cause bullshit like people submitting dual licensed patches to the scheduler or GPL only patches to the ath5k or ACPI code. Precisely. Signed-off-by means the patch author already authorized the

Re: [RFC] QoS params patch update.

2007-09-27 Thread Mark Gross
On Wed, Sep 26, 2007 at 09:05:15PM -0700, Randy Dunlap wrote: On Thu, 27 Sep 2007 11:24:40 +0900 Paul Mundt wrote: +/* static helper functions */ +static s32 max_compare(s32 v1, s32 v2) +{ + if (v1 v2) + return v2; + else + return v1; +} + +static

RE: [ofa-general] [PATCH v3] iw_cxgb3: Supportiwarp-onlyinterfacesto avoid 4-tuple conflicts.

2007-09-27 Thread Kanevsky, Arkady
Sean, IB aside, it looks like an ULP which is capable of being both RDMA aware and RDMA not-aware, like iSER and iSCSI, NFS-RDMA and NFS, SDP and sockets, will be treated as two separete ULPs. Each has its own IP address, since there is a different IP address for iWARP port and regular Ethernet

Re: 2.6.23-rc8-mm2: BUG near reiserfs_xattr_set

2007-09-27 Thread Christoph Hellwig
On Thu, Sep 27, 2007 at 12:48:33PM -0700, Andrew Morton wrote: __fput+0x124/0x1a9 fput+0x31/0x35 reiserfs_xattr_set+0x291/0x2b0 [reiserfs] user_set+0x4c/0x57 [reiserfs] reiserfs_setxattr+0x81/0xf1 [reiserfs] vfs_setxattr+0x7d/0xfa setxattr+0xb9/0xd1 sys_lsetxattr+0x4c/0x85

<    1   2   3   4   5   6   7   8   >