Re: [NET] IPv6 oops bisected

2007-10-07 Thread Denis V. Lunev
David Miller wrote: > From: "Denis V. Lunev" <[EMAIL PROTECTED]> > Date: Mon, 08 Oct 2007 10:34:23 +0400 > >> OK. I am installing Fedora 7 right now... > > You don't need to install Fedora, just read the code! :-) > > The bug is obvious and it's been explained thoroughly in this > thread. > > W

[patch] fs: restore nobh

2007-10-07 Thread Nick Piggin
Hi, This is overdue, sorry. Got a little complicated, and I've been away from my filesystem test setup so I didn't want ot send it (lucky, coz I found a bug after more substantial testing). Anyway, RFC? --- Implement nobh in new aops. This is a bit tricky. FWIW, nobh_truncate is now implemented

[PATCH] param_sysfs_builtin memchr argument fix

2007-10-07 Thread Dave Young
If memchr argument is longer than strlen(kp->name), there will be some weird result. Signed-off-by: Dave Young <[EMAIL PROTECTED]> --- params.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff -upr linux/kernel/params.c linux.new/kernel/params.c --- linux/kernel/params.c

Re: [NET] IPv6 oops bisected

2007-10-07 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Mon, 08 Oct 2007 10:34:23 +0400 > OK. I am installing Fedora 7 right now... You don't need to install Fedora, just read the code! :-) The bug is obvious and it's been explained thoroughly in this thread. When 'dev' is NULL in ip6_route_add() we n

Re: 2.6.23-rc8-mm2

2007-10-07 Thread Dave Young
On 9/29/07, Greg KH <[EMAIL PROTECTED]> wrote: > On Sat, Sep 29, 2007 at 05:37:29PM +0800, Dave Young wrote: > > Hi, > > The kernel report warnings about sysfs filename duplicate under > > rc8-mm1 and rc8-mm2. > > 1. > > cut > > NET: Registered protocol family 16 > > ACPI: bus type pci reg

[PATCHv2 1/9] compat_ioctl: move common block ioctls to compat_blkdev_ioctl

2007-10-07 Thread Arnd Bergmann
Make compat_blkdev_ioctl and blkdev_ioctl reflect the respective native versions. This is somewhat more efficient and makes it easier to keep the two in sync. Also get rid of the bogus handling for broken_blkgetsize and the duplicate entry for BLKRASET. Signed-off-by: Arnd Bergmann <[EMAIL PROTEC

Re: [NET] IPv6 oops bisected

2007-10-07 Thread Denis V. Lunev
David Miller wrote: > From: Herbert Xu <[EMAIL PROTECTED]> > Date: Mon, 8 Oct 2007 14:19:42 +0800 > >> On Sun, Oct 07, 2007 at 11:16:08PM -0700, David Miller wrote: >>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c >>> index a7db84c..7109ad6 100644 >>> --- a/net/ipv6/route.c >>> +++ b/net/ipv6/

Re: [ofa-general] Updated InfiniBand/RDMA merge plans for 2.6.24

2007-10-07 Thread Jack Morgenstein
On Saturday 06 October 2007 01:18, Roland Dreier wrote: >  - XRC.  Given the length of the backlog above and the fact that a >    first draft of this code has not been posted yet, I don't see any >    way that we could have something this major ready in time. > I posted the first draft patch set t

Re: [NET] IPv6 oops bisected

2007-10-07 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Mon, 8 Oct 2007 14:19:42 +0800 > On Sun, Oct 07, 2007 at 11:16:08PM -0700, David Miller wrote: > > > > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > > index a7db84c..7109ad6 100644 > > --- a/net/ipv6/route.c > > +++ b/net/ipv6/route.c > > @@ -1188,7

Re: [NET] IPv6 oops bisected

2007-10-07 Thread Herbert Xu
On Sun, Oct 07, 2007 at 11:16:08PM -0700, David Miller wrote: > > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > index a7db84c..7109ad6 100644 > --- a/net/ipv6/route.c > +++ b/net/ipv6/route.c > @@ -1188,7 +1188,7 @@ int ip6_route_add(struct fib6_config *cfg) > if ((cfg->fc_flags & RTF_RE

Re: [NET] IPv6 oops bisected

2007-10-07 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Sun, 07 Oct 2007 10:56:07 -0400 > /etc/sysconfig/network-scripts/network-functions-ipv6: line 246: 1760 Killed > LC_ALL=C /sbin/ip $options > > > NULL pointer dereference at 0x03f8 > > backtrace: > :ipv6:ip6_route_add+0x1b1/0x543 'dev' can

Re: [git patches] net driver updates

2007-10-07 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri, 5 Oct 2007 14:20:08 -0400 > Please pull from 'upstream-davem' branch of > master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git > upstream-davem > Pulled, and pushed back out to net-2.6.24, thanks Jeff. - To unsubscribe from this lis

Re: [patch 0/9] compat_ioctl: introduce block/compat_ioctl.c

2007-10-07 Thread David Miller
From: Al Viro <[EMAIL PROTECTED]> Date: Mon, 8 Oct 2007 06:12:18 +0100 > On Sat, Oct 06, 2007 at 08:19:02PM +0200, Arnd Bergmann wrote: > > This is my block ioctl series split up into managable chunks. I'm not > > really sure about the last two of these, I'd prefer to get a second > > opinion on t

Re: [patch 0/9] compat_ioctl: introduce block/compat_ioctl.c

2007-10-07 Thread Al Viro
On Sat, Oct 06, 2007 at 08:19:02PM +0200, Arnd Bergmann wrote: > This is my block ioctl series split up into managable chunks. I'm not > really sure about the last two of these, I'd prefer to get a second > opinion on those. > > Please apply once your tests have gone though. BTW, one note: 0x1260

Re: Serial ATA does not find partitions (Hitachi HD, new? ATI controller) where old SATA works

2007-10-07 Thread Hernan G Solari
Hmmm... and the kernel freezes after this? libata driver isn't initialized yet. I don't think libata has anything to do with here. as I told you, the ATA problem was with the 2.6.22 version of the kernel and is not longer related to the freeze with kernel 2.6.23-rc8 I asked whether you

Re: 2.6.23-rc7-mm1 -- powerpc rtas panic

2007-10-07 Thread Nish Aravamudan
On 10/5/07, Linas Vepstas <[EMAIL PROTECTED]> wrote: > On Thu, Oct 04, 2007 at 05:01:47PM -0700, Nish Aravamudan wrote: > > On 10/2/07, Tony Breeds <[EMAIL PROTECTED]> wrote: > > > On Wed, Oct 03, 2007 at 10:30:16AM +1000, Michael Ellerman wrote: > > > > > > > I realise it'll make the patch bigger,

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Willy Tarreau
On Sun, Oct 07, 2007 at 09:56:09PM +0200, Jan Engelhardt wrote: > > On Oct 7 2007 21:13, Willy Tarreau wrote: > >There are two distinct populations : > > - those [...] > >who would never have imagined that pressing Escape > >during the boot of windows 3.1/95 provided them with the full te

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Willy Tarreau
On Sun, Oct 07, 2007 at 09:47:25PM +0200, Oleg Verych wrote: > On Sun, Oct 07, 2007 at 09:13:09PM +0200, Willy Tarreau wrote: > > On Sun, Oct 07, 2007 at 08:47:52PM +0200, Rene Herman wrote: > > > On 10/07/2007 06:12 PM, Ingo Molnar wrote: > > > > > > >* Oleg Verych <[EMAIL PROTECTED]> wrote: > >

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-07 Thread Balbir Singh
Hugh Dickins wrote: > On Fri, 5 Oct 2007, Balbir Singh wrote: >> Hugh Dickins wrote: >>> That's where it should happen, yes; but my point is that it very >>> often does not. Because the swap cache page (read in as part of >>> the readaround cluster of some other cgroup, or in swapoff by some >>> o

Re: 2.6.23-rc8-mm[12] - the amazing disappearing MSI IRQ

2007-10-07 Thread Valdis . Kletnieks
On Sun, 07 Oct 2007 00:51:32 EDT, [EMAIL PROTECTED] said: > I've also seen the eth0 MSI IRQ evaporate, leaving *two* 'none-edge' IRQs, > but I can't replicate it at the moment, as it seems to happen pseudo-randomly. Ignore this part - the problem is confined to the HDA-Intel driver. I've verified

Re: XFS internal error

2007-10-07 Thread Max Waterman
Barry Naujok wrote: Yes, the latest xfs_repair doesn't create a lost+found unless it needs to, and if it does so, it will list the inodes moved there. So, in your case, nothing went to lost+found. Regards, Barry. Great. Thanks a lot for your help :) Max. PS. I'm still missing working at SGI

Re: Serial ATA does not find partitions (Hitachi HD, new? ATI controller) where old SATA works

2007-10-07 Thread Tejun Heo
Hello, Hernan G Solari wrote: >> Hmmm... and the kernel freezes after this? libata driver isn't >> initialized yet. I don't think libata has anything to do with here. >> >> > as I told you, the ATA problem was with the 2.6.22 version of the kernel > and is not longer related to the freeze wit

Re: XFS internal error

2007-10-07 Thread Barry Naujok
On Mon, 08 Oct 2007 11:54:28 +1000, Max Waterman <[EMAIL PROTECTED]> wrote: David Chinner wrote: I suggest that you run xfs_check on the filesystem and if that shows up errors, run xfs_repair onteh filesystem to correct them. It did, and I did, and another xfs_check produced no output. Do

Re: race with page_referenced_one->ptep_test_and_clear_young and pagetable setup/pulldown

2007-10-07 Thread Nick Piggin
On Friday 05 October 2007 12:44, Andrew Morton wrote: > On Thu, 04 Oct 2007 18:43:32 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > David's change 10a8d6ae4b3182d6588a5809a8366343bc295c20, "i386: add > > ptep_test_and_clear_{dirty,young}" has introduced an SMP race which > > affects the

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

2007-10-07 Thread Ryan Finnie
On 10/7/07, Pekka J Enberg <[EMAIL PROTECTED]> wrote: > On 10/7/07, Erez Zadok <[EMAIL PROTECTED]> wrote: > > Anyway, some Ubuntu users of Unionfs reported that msync(2) sometimes > > returns AOP_WRITEPAGE_ACTIVATE (decimal 524288) back to userland. > > Therefore, some user programs fail, esp. if t

Re: XFS internal error

2007-10-07 Thread Max Waterman
David Chinner wrote: 1994 of file fs/xfs/xfs_da_btree.c. Caller 0x889b2de4 Did you ever run 2.6.17-2.6.17.6? I guess so, since I've been upgrading steadily since I installed FC6 some time ago. If so, this implies: http://oss.sgi.com/projects/xfs/faq.html#dir2 Ah. I did see

Re: Serial ATA does not find partitions (Hitachi HD, new? ATI controller) where old SATA works

2007-10-07 Thread Tejun Heo
Hello, Hernan. Hernan G Solari wrote: > >> If you can set up a serial console, it would be better. If not, can you >> please take a photo of the crash and post it? >> > I am running short of elements, no digital camera o movil phone for the > case or serial link. > However, what it is on the

Re: syntax highlighting, emacs ([PATCH 0/2] Colored kernel output (run2))

2007-10-07 Thread Ken Moffat
On Mon, Oct 08, 2007 at 12:11:21AM +0200, Jan Engelhardt wrote: > > Actually, blue is perceived as one of the darkest colors by the human > eye. There is a reason that the RGB -> grayscale transformation uses > the following weighting: r=76 g=154 b=26. But, not every video card reproduces blue i

Re: [PATCH] [343/2many] MAINTAINERS - IPVS

2007-10-07 Thread Simon Horman
On Sun, Aug 12, 2007 at 11:32:48PM -0700, [EMAIL PROTECTED] wrote: > Add file pattern to MAINTAINER entry > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > > diff --git a/MAINTAINERS b/MAINTAINERS > index dbfdb75..a8fb231 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3300,6 +3300,8 @@ P

Re: .23-rc9, V4L, make randconfig build failure

2007-10-07 Thread Trent Piepho
On Sat, 6 Oct 2007, Ingo Molnar wrote: > FYI, just found this V4L build failure in -rc9: > > drivers/built-in.o: In function `saa7146_unregister_device': > : undefined reference to `video_unregister_device' > drivers/built-in.o: In function `saa7146_register_device': > : undefined reference to

Re: [PATCH] remove throttle_vm_writeout()

2007-10-07 Thread Fengguang Wu
On Mon, Oct 08, 2007 at 09:54:33AM +1000, David Chinner wrote: > On Fri, Oct 05, 2007 at 08:30:28PM +0800, Fengguang Wu wrote: > > The improvement could be: > > - kswapd is now explicitly preferred to do the writeout; > > Careful. kswapd is much less efficient at writeout than pdflush > because it

Re: XFS internal error

2007-10-07 Thread David Chinner
[please cc [EMAIL PROTECTED] on XFS bug reports. thx.] On Sun, Oct 07, 2007 at 09:09:58AM +0800, Max Waterman wrote: > Hi, > > I have just had an XFS error occur while deleting some directory > hierarchy. I hope this is the correct place to report it. . > This is in syslog : > > > Oct 6 23

Re: [DEBUG PATCH] demonstration of hang in sched domain partitioning code

2007-10-07 Thread Nick Piggin
On Friday 05 October 2007 19:24, Paul Jackson wrote: > Nick, > > I'm running into a problem trying to use your suggested > partition_sched_domains(cpumask_t *partition) routine the way > I thought I was supposed to be able to use it. > > If I ask to set up the same partition twice in a row having >

Re: [13/18] x86_64: Allow fallback for the stack

2007-10-07 Thread Nick Piggin
On Friday 05 October 2007 07:20, Christoph Lameter wrote: > On Thu, 4 Oct 2007, Rik van Riel wrote: > > > Well we can now address the rarity. That is the whole point of the > > > patchset. > > > > Introducing complexity to fight a very rare problem with a good > > fallback (refusing to fork more ta

Re: can't change euid 0 to uid != running user

2007-10-07 Thread Ray Lee
On 10/7/07, Luciano Rocha <[EMAIL PROTECTED]> wrote: > On Fri, Oct 05, 2007 at 08:28:50AM -0700, Ray Lee wrote: > > On 10/5/07, Luciano Rocha <[EMAIL PROTECTED]> wrote: > > > I have the following problem: > > > $ sudo -u ie -s # or sudo su ie > > > unable to change to runas uid: Resource temporaril

Re: [PATCH] remove throttle_vm_writeout()

2007-10-07 Thread David Chinner
On Fri, Oct 05, 2007 at 08:30:28PM +0800, Fengguang Wu wrote: > The improvement could be: > - kswapd is now explicitly preferred to do the writeout; Careful. kswapd is much less efficient at writeout than pdflush because it does not do low->high offset writeback per address space. It just flushes

Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..

2007-10-07 Thread Alistair John Strachan
On Friday 05 October 2007 09:32:40 you wrote: > On Fri, 5 Oct 2007, Sam Ravnborg wrote: > > > > cp: cannot stat `arch/x86_64/boot/bzImage': No such file or directory > > > > > > > > Obviously, this file has moved to arch/x86/boot, but it seems like > > > > possibly unnecessary breakage. I've been c

Re: Crash on 2.6.21.7 Vanilla + DRBD 0.7

2007-10-07 Thread David Chinner
On Thu, Oct 04, 2007 at 09:29:40AM +0200, Laurent Caron wrote: > > Hi, > > I did compile a fresh 2.6.21.7 kernel from kernel.org (no distro patch, > ), and latest svn (3062) 0.7.X drbd. > > After just 2 days of uptime, I did experience another crash. > > I wonder if it is an XFS related bu

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Alistair John Strachan
On Monday 08 October 2007 00:10:10 Rene Herman wrote: > I find Alan's suggestion to provide the functionality the same way you'd > provide for translated kernel messages (seeing as how there also are people > that want those) much more sensible. By the way, I agree that this is the best approach.

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Oleg Verych
On Mon, Oct 08, 2007 at 01:01:33AM +0200, Jan Engelhardt wrote: > > On Oct 8 2007 01:02, Oleg Verych wrote: > > > >If you are not going to see OOPes of new kernels running old distros, ask > >any perl hacker (as they lovely mentioned in lkml) to hack for you > >something like: > > > >sed -u -e ' >

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Alistair John Strachan
On Monday 08 October 2007 00:10:10 Rene Herman wrote: > On 10/08/2007 12:40 AM, Alistair John Strachan wrote: > > Splash screens are clearly cosmetic, and it's kind of shameful (imo) that > > important messages explaining real problems are obscured from view by > > functionless splash screens. > >

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Alan Cox
> is bogus, they're very functionally separable ideas. A coloured oops seems to > be a good way of telling novice users what information is relevant to their > bug report. Unless they are colour blind or on a system like a PDA with a mono display 8) - To unsubscribe from this list: send the line

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Rene Herman
On 10/08/2007 12:40 AM, Alistair John Strachan wrote: Splash screens are clearly cosmetic, and it's kind of shameful (imo) that important messages explaining real problems are obscured from view by functionless splash screens. They're not functionless. You (and I) might not care for the funct

Re: NAK nettiquete (was Re: "Re: [PATCH 0/2] Colored kernel output (run2)"

2007-10-07 Thread Jan Engelhardt
On Oct 7 2007 17:23, Alan Cox wrote: > >>>- If you want to do "pretty" boot up you do it in X or frame buffer >>>(which is going to get easier and easier with the X shift to kernel side >>>video support) >> >> fb is slow. Feels like a 9600bps serial line. > >So fix your fb. There is enough inform

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Alistair John Strachan
On Sunday 07 October 2007 20:13:09 you wrote: > On Sun, Oct 07, 2007 at 08:47:52PM +0200, Rene Herman wrote: > > On 10/07/2007 06:12 PM, Ingo Molnar wrote: > > >* Oleg Verych <[EMAIL PROTECTED]> wrote: > > >>Coloring isn't useful. If it was, it would be implemented ~16 years > > >>ago. > > > > > >C

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Jan Engelhardt
On Oct 8 2007 01:02, Oleg Verych wrote: > >If you are not going to see OOPes of new kernels running old distros, ask >any perl hacker (as they lovely mentioned in lkml) to hack for you >something like: > >sed -u -e ' >/^<1/s_^_'$COLOR1'_ >/^<2/s_^_'$COLOR2'_ >/^<3/s_^_'$COLOR3'_ >/^<4/s_^_'$COLOR4

Re: [NFS] What's slated for inclusion in 2.6.24-rc1 from the NFS client git tree...

2007-10-07 Thread David Chinner
On Fri, Oct 05, 2007 at 02:12:22PM -0400, Jeff Layton wrote: > On Fri, 05 Oct 2007 13:30:10 -0400 > [EMAIL PROTECTED] wrote: > > > On Thu, 04 Oct 2007 10:00:50 EDT, Trond Myklebust said: > > > > > How about a boot/module parameter to turn it on or off? > > > > > > I don't see any point in having

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Oleg Verych
On Sun, Oct 07, 2007 at 11:11:54PM +0200, Ingo Molnar wrote: > > * Willy Tarreau <[EMAIL PROTECTED]> wrote: > > > I would say that while I'm not particularly fond of flashy colors > > everywhere, I think that being able to use colors to indicate > > particular actions in progress or conditions

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-07 Thread Randy Dunlap
On Sun, 7 Oct 2007 16:56:01 -0500 Rob Landley wrote: > On Friday 05 October 2007 6:01:10 pm Miguel Ojeda wrote: > > > *shrug* That doesn't mean my objections are important to anyone else, > > > just that I don't personally see any reason to be enthusiastic about this > > > patch. > > > > Take a l

Re: [PATCH] [2/6] scheduler: Refactor common code of sleep_on / wait_for_completion v2

2007-10-07 Thread Andi Kleen
Andi Kleen <[EMAIL PROTECTED]> writes: > These functions were largely cut'n'pasted. This moves Here's a replacement patch fixing a minor problem: sleep_on_common wasn't marked __sched and ended up in the wrong section; breaking the WCHAN backtracing. -Andi Refactor common code of sleep_on / w

Re: Linux Kernel Markers - performance characterization with large IO load on large-ish system

2007-10-07 Thread Joshua Root
Ingo Molnar wrote: actually, the pure marker overhead seems to be a regression: Kernel Options Min valAvg valMax valStd Dev - markers - bt cfg 15.349127 16.169459 16.372980 0.184417 + markers - bt cfg 15.280382 16.202398 16.409257 0.191861 why isnt the marker near

Re: Bug #4580: hda: lost interrupt when resuming from S3 - Sony VGN-T1XP

2007-10-07 Thread Jeff Garzik
Alan Cox wrote: On Sun, 7 Oct 2007 22:17:06 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: Hi, IDE/ATA wizzards are kindly requested to have a look at: http://bugzilla.kernel.org/show_bug.cgi?id=4580#c21 as I have no idea of what we can do about the "hard drive password vs suspend" pro

Re: syntax highlighting, emacs ([PATCH 0/2] Colored kernel output (run2))

2007-10-07 Thread Jan Engelhardt
On Oct 8 2007 00:18, Oleg Verych wrote: > >Kind of funny thing with it. One for shell in `mcedit` is much nicer, but >`emacs` is more powerful as editor(R). But both have highlighting >problems with non trivial scripts (quoiting, data here, etc). I don't >know if it will ever be fixed :). No, it

Re: Bug #4580: hda: lost interrupt when resuming from S3 - Sony VGN-T1XP

2007-10-07 Thread Alan Cox
On Sun, 7 Oct 2007 22:17:06 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > Hi, > > IDE/ATA wizzards are kindly requested to have a look at: > > http://bugzilla.kernel.org/show_bug.cgi?id=4580#c21 > > as I have no idea of what we can do about the "hard drive password vs suspend" > proble

Re: syntax highlighting, emacs ([PATCH 0/2] Colored kernel output (run2))

2007-10-07 Thread Oleg Verych
On Sun, Oct 07, 2007 at 10:43:46PM +0200, Jan Engelhardt wrote: > > On Oct 7 2007 22:50, Oleg Verych wrote: > > > >In fact mc config (ini) section is a better way. > > Yes, for the default colors. But /usr/share/mc/syntax/ specifies > more of them. Syntax highlighting, OK. Kind of funny thing w

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-07 Thread Rob Landley
On Friday 05 October 2007 6:01:10 pm Miguel Ojeda wrote: > > *shrug* That doesn't mean my objections are important to anyone else, > > just that I don't personally see any reason to be enthusiastic about this > > patch. > > Take a look to other suggested changes, maybe you like some of them > and

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-07 Thread Rob Landley
On Saturday 06 October 2007 1:10:26 am Vegard Nossum wrote: > On 10/5/07, Rob Landley <[EMAIL PROTECTED]> wrote: > > The original idea (selectively compile out printk() instances based on > > log level to conserve space) is explicitly not addressed by this patch, > > and in fact this patch might ac

dtc_setup() used anywhere?

2007-10-07 Thread Johannes Weiner
Hi, The compiler warned me that dtc_setup() is unused in drivers/scsi/dtc.c:182. I do not see a call to it anywhere and no __setup() near to it. Am I missing something? Hannes -- 3BD8 AF56 11AF 205C 9DB6 B10F 76F1 0634 71A4 DCA0 - To unsubscribe from this list: send the line "unsubscr

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Alan Cox
> Jan's code is here today and it works fine for me. How can you > coherently argue against the plain fact that his feature solves my > usecases perfectly fine, So add a notifier for console printk output. Then you can keep whatever out of kernel patches you like for printk output in chinese, co

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Ingo Molnar
* Oleg Verych <[EMAIL PROTECTED]> wrote: > > For instance, anyone who has experienced read errors on and IDE disk > > knows that it can literally take hours/days to boot, after > > displaying thousands of messages. Here, having the ability to see > > that no IRQ was assigned or something like

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Ingo Molnar
* Willy Tarreau <[EMAIL PROTECTED]> wrote: > I would say that while I'm not particularly fond of flashy colors > everywhere, I think that being able to use colors to indicate > particular actions in progress or conditions can be a good thing. RAID > errors, devices disabled due to command-line

Re: [TRIVIAL PATCH] Remove unused variable in drivers/dma/ioatdma.c

2007-10-07 Thread David Miller
From: Johannes Weiner <[EMAIL PROTECTED]> Date: Sun, 7 Oct 2007 21:18:49 +0200 > Hi, > > I found this in an `allyesconfig' build: > > CC drivers/dma/ioatdma.o > drivers/dma/ioatdma.c: In function #ioat_dma_free_chan_resources#: > drivers/dma/ioatdma.c:247: warning: unused variable #ch

[PATCH] [6/6] scheduler: Remove bogus comment in sched_group_set_shares

2007-10-07 Thread Andi Kleen
Function never returns -EINVAL. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Index: linux-2.6-sched-devel/kernel/sched.c === --- linux-2.6-sched-devel.orig/kernel/sched.c +++ linux-2.6-sched-devel/kernel/sched.c @@ -6814,8 +6814,6

[PATCH] [3/6] scheduler: Do devirtualization for sched_fair

2007-10-07 Thread Andi Kleen
Some CPUs like K8 cannot predict indirect calls. A common optimization in object oriented languages is to check for the most common call target and then call it directly; otherwise do an indirect call. This patch does this manually for sched_fair calls in sched.c In theory -- it doesn't seem to

[PATCH] [4/6] scheduler: Refactor normalize_rt_tasks

2007-10-07 Thread Andi Kleen
Replace a particularly ugly ifdef with an inline and a new macro. Also split up the function to be easier readable. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Index: linux-2.6-sched-devel/kernel/sched.c === --- linux-2.6-sched-de

[PATCH] [5/6] scheduler: Protect important kernel threads against normalize_rt

2007-10-07 Thread Andi Kleen
Not only the migration thread, but also softlockup and stop machine need to be protected against normalize_rt(). Instead of checking for them all I added a new process flag for this. This was the last available bit in 32bit task->flags, sorry for that. This removes the is_migration_thread macro

[PATCH] [2/6] scheduler: Refactor common code of sleep_on / wait_for_completion

2007-10-07 Thread Andi Kleen
These functions were largely cut'n'pasted. This moves the common code into single helpers instead. Advantage is about 1k less code on x86-64 and 91 lines of code removed. It adds one function call to the non timeout version of the functions; i don't expect this to be measurable. Signed-off-by: A

[PATCH] [0/6] Some scheduler changes for sched-devel

2007-10-07 Thread Andi Kleen
- Various source code cleanups (no functional changes) - Shrink binary size by refactoring some code - One K8 optimization that is unfortunately not measurable. But it sounded good in theory! @) (if you have a better scheduling latency benchmark than lmbench3 it would be cool to try) - One real

[PATCH] [1/6] scheduler: Remove some unnecessary gotos in sched.c

2007-10-07 Thread Andi Kleen
No need to be more spagetti than absolutely necessary. Replace loops implemented with gotos with real loops. Replace err = ...; goto x; x: return err; with return ...; No functional changes. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Index: linux-2.6-sched-devel/kernel/sched.c

Re: tty UI (Re: [PATCH 0/2] Colored kernel output (run2))

2007-10-07 Thread Jan Engelhardt
On Oct 7 2007 22:50, Oleg Verych wrote: > >In fact mc config (ini) section is a better way. Yes, for the default colors. But /usr/share/mc/syntax/ specifies more of them. >I use default blue (which is very annoying) If blue were annoying, it would not be the default Windows background (since Wi

tty UI (Re: [PATCH 0/2] Colored kernel output (run2))

2007-10-07 Thread Oleg Verych
On Sun, Oct 07, 2007 at 10:04:44PM +0200, Jan Engelhardt wrote: > > On Oct 7 2007 22:00, Rene Herman wrote: > > On 10/07/2007 09:56 PM, Jan Engelhardt wrote: > > > >> Some is good, as long as it is not excessive. While I could imagine that > >> Knoppix will abuse the feature and use vt.printk_colo

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Rene Herman
On 10/07/2007 10:04 PM, Jan Engelhardt wrote: On Oct 7 2007 22:00, Rene Herman wrote: On 10/07/2007 09:56 PM, Jan Engelhardt wrote: Some is good, as long as it is not excessive. While I could imagine that Knoppix will abuse the feature and use vt.printk_color=9,9,9,9,11,10,12, this is not wha

Re: [PATCH] Fix SH4 DMAC API

2007-10-07 Thread Paul Mundt
On Sat, Oct 06, 2007 at 02:52:43PM +0100, Adrian McMenamin wrote: > This patch fixes the DMA cascade by masking the correct bits. > > Tested and working with Dreamcast PVR2 DMA. With this patch applied > the existing mainline code in arch/sh/drivers/dma/dma-sh.c works, > whereas before I was patch

Re: [PATCH 2/5] forcedeth: interrupt handling cleanup

2007-10-07 Thread Jeff Garzik
Yinghai Lu wrote: On 10/7/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: Yinghai Lu wrote: On 10/6/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: commit a606d2a111cdf948da5d69eb1de5526c5c2dafef Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri Oct 5 22:56:05 2007 -0400 [netdrvr] forcedeth: inte

Re: [PATCH 0/5] forcedeth: several proposed updates for testing

2007-10-07 Thread Jeff Garzik
Yinghai Lu wrote: On 10/7/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: Jeff Garzik wrote: The 'fe-lock' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git fe-lock OK, I've successfully tested patches 1-5 on an AMD64 system with 00:0a.0 Bridge: nVidia Corporation CK80

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Rene Herman
On 10/07/2007 09:56 PM, Jan Engelhardt wrote: Some is good, as long as it is not excessive. While I could imagine that Knoppix will abuse the feature and use vt.printk_color=9,9,9,9,11,10,12, this is not what serious people would do. [1] http://tinyurl.com/yr9zgq [2] http://tinyurl.com/234ba3

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Jan Engelhardt
On Oct 7 2007 21:27, Rene Herman wrote: > > I saw you remark on FB console in a reply to Alan just now and I > quite agree with you. The (current) FB console is slow and I'll add > "dumb" myself. When you have a 1280x1024 screen available, you get > to do cool things like put up nice little window

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Jan Engelhardt
On Oct 7 2007 22:00, Rene Herman wrote: > On 10/07/2007 09:56 PM, Jan Engelhardt wrote: > >> Some is good, as long as it is not excessive. While I could imagine that >> Knoppix will abuse the feature and use vt.printk_color=9,9,9,9,11,10,12, this >> is not what serious people would do. >> >> [1]

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

2007-10-07 Thread Pekka J Enberg
Hi Erez, On 10/7/07, Erez Zadok <[EMAIL PROTECTED]> wrote: > Anyway, some Ubuntu users of Unionfs reported that msync(2) sometimes > returns AOP_WRITEPAGE_ACTIVATE (decimal 524288) back to userland. > Therefore, some user programs fail, esp. if they're written such as > this: [snip] On 10/7/07,

Re: Sleeping in RCU list traversal

2007-10-07 Thread Tetsuo Handa
Hello. Peter Zijlstra wrote: > > So, I don't need to grab a reference to "ptr" > > because memory region pointed by "ptr" will never be kfree()ed. > > And it is legal to use "ptr" after rcu_read_unlock() > > because memory region pointed by "ptr" will never be kfree()ed. > > Still think that is a

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Rene Herman
On 10/07/2007 09:13 PM, Willy Tarreau wrote: On Sun, Oct 07, 2007 at 08:47:52PM +0200, Rene Herman wrote: But well, there actually have been worse arguments given that VGA console is getting less and less important. I recently did a perusal of alternative distributions and didn't find a sing

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Jan Engelhardt
On Oct 7 2007 21:13, Willy Tarreau wrote: >There are two distinct populations : > - those [...] >who would never have imagined that pressing Escape >during the boot of windows 3.1/95 provided them with the full text >messages. This is news to me. DOS always showed messages, and under

2.6.23-rc9-git5: Known regressions from 2.6.22

2007-10-07 Thread Rafael J. Wysocki
This message contains a list of some known regressions from 2.6.22 for which there are no fixes in the mainline that I know of.  If any of them have been fixed already, please let me know. If you know of any other unresolved regressions from 2.6.22, please let me know either and I'll add them to

[TRIVIAL PATCH] Remove unused variable in drivers/dma/ioatdma.c

2007-10-07 Thread Johannes Weiner
Hi, I found this in an `allyesconfig' build: CC drivers/dma/ioatdma.o drivers/dma/ioatdma.c: In function #ioat_dma_free_chan_resources#: drivers/dma/ioatdma.c:247: warning: unused variable #chanctrl# Hannes Signed-off-by: Johannes Weiner <[EMAIL PROTECTED]> diff --git a/driv

Re: [Oops] on 2.6.23-rc9 sysRq Show Tasks (t)

2007-10-07 Thread Ahmed S. Darwish
On Sun, Oct 07, 2007 at 01:12:38AM +0400, Alexey Dobriyan wrote: > On Sat, Oct 06, 2007 at 10:14:06PM +0200, Ahmed S. Darwish wrote: > > Pressing sysRq+T always produce an Oops for every running system task (94 > > Oopses, that's a record ;)). > > uh-oh. For every sleeping task, I think. > > > T

Re: [PATCH 0/5] forcedeth: several proposed updates for testing

2007-10-07 Thread Yinghai Lu
On 10/7/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Jeff Garzik wrote: > > The 'fe-lock' branch of > > git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git fe-lock > OK, I've successfully tested patches 1-5 on an AMD64 system with > > 00:0a.0 Bridge: nVidia Corporation CK804 Ethern

Re: [PATCH 2/5] forcedeth: interrupt handling cleanup

2007-10-07 Thread Yinghai Lu
On 10/7/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Yinghai Lu wrote: > > On 10/6/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > >> commit a606d2a111cdf948da5d69eb1de5526c5c2dafef > >> Author: Jeff Garzik <[EMAIL PROTECTED]> > >> Date: Fri Oct 5 22:56:05 2007 -0400 > >> > >> [netdrvr] forcedet

Re: Linux Kernel Markers - performance characterization with large IO load on large-ish system

2007-10-07 Thread Ingo Molnar
* Alan D. Brunelle <[EMAIL PROTECTED]> wrote: > o All kernels start off with Linux 2.6.23-rc6 + 2.6.23-rc6-mm1 > > o '- bt cfg' or '+ bt cfg' means a kernel without or with blktrace > configured respectively. > > o '- markers' or '+ markers' means a kernel without or with the > 11-patch

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Oleg Verych
On Sun, Oct 07, 2007 at 09:13:09PM +0200, Willy Tarreau wrote: > On Sun, Oct 07, 2007 at 08:47:52PM +0200, Rene Herman wrote: > > On 10/07/2007 06:12 PM, Ingo Molnar wrote: > > > > >* Oleg Verych <[EMAIL PROTECTED]> wrote: > > > > >>Coloring isn't useful. If it was, it would be implemented ~16 ye

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Rene Herman
On 10/07/2007 08:58 PM, Jan Engelhardt wrote: On Oct 7 2007 20:47, Rene Herman wrote: Coloring isn't useful. If it was, it would be implemented ~16 years ago. Congratulations, this is the most stupid argument i've ever read on lkml. "Ay. World is finished. Everyone can go home and watch Fri

msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

2007-10-07 Thread Erez Zadok
According to vfs.txt, ->writepage() may return AOP_WRITEPAGE_ACTIVATE back to the VFS/VM. Indeed some filesystems such as tmpfs can return AOP_WRITEPAGE_ACTIVATE; and stackable file systems (e.g., Unionfs) also return AOP_WRITEPAGE_ACTIVATE if the lower f/s returned it. Anyway, some Ubuntu users

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Willy Tarreau
On Sun, Oct 07, 2007 at 08:47:52PM +0200, Rene Herman wrote: > On 10/07/2007 06:12 PM, Ingo Molnar wrote: > > >* Oleg Verych <[EMAIL PROTECTED]> wrote: > > >>Coloring isn't useful. If it was, it would be implemented ~16 years > >>ago. > > > >Congratulations, this is the most stupid argument i've

Re: [PATCH] 0/3 checkpatch updates, new checkfiles script

2007-10-07 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Ingo Molnar writes: > > * Erez Zadok <[EMAIL PROTECTED]> wrote: > > > So, I ran the above script and it found nearly 1.5 million reported > > warnings/errors, with drivers being the largest abuser, not > > surprisingly. [...] > > have you tried that with the lat

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Jan Engelhardt
On Oct 7 2007 20:47, Rene Herman wrote: > >> > Coloring isn't useful. If it was, it would be implemented ~16 years >> > ago. >> >> Congratulations, this is the most stupid argument i've ever read on lkml. > > "Ay. World is finished. Everyone can go home and watch Friends reruns now." > > But well

Re: [PATCH] Fix Oops in toshiba_acpi error return path

2007-10-07 Thread Dmitry Torokhov
On Sunday 07 October 2007, Andrey Borzenkov wrote: > This fixes oops when registering backlight device fails. Attached as I still > cannot convince kmail to not mangle long lines ... > > -andrey > Re: kmail - it usually behaves well with the patches as long as you turn off word wrapping and use

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Rene Herman
On 10/07/2007 06:12 PM, Ingo Molnar wrote: * Oleg Verych <[EMAIL PROTECTED]> wrote: Coloring isn't useful. If it was, it would be implemented ~16 years ago. Congratulations, this is the most stupid argument i've ever read on lkml. "Ay. World is finished. Everyone can go home and watch Fr

Re: Sleeping in RCU list traversal

2007-10-07 Thread Peter Zijlstra
On Mon, 2007-10-08 at 01:56 +0900, Tetsuo Handa wrote: > So, I don't need to grab a reference to "ptr" > because memory region pointed by "ptr" will never be kfree()ed. > And it is legal to use "ptr" after rcu_read_unlock() > because memory region pointed by "ptr" will never be kfree()ed. Still

Re: NAK nettiquete (was Re: "Re: [PATCH 0/2] Colored kernel output (run2)"

2007-10-07 Thread Arnaldo Carvalho de Melo
Em Sun, Oct 07, 2007 at 04:12:22PM +0100, Alan Cox escreveu: > > The few times I've tried to NAK something outright, I've always tried to > > attach > > plenty of technical explanation > > Fair comment to my "silly" response > > The problems I see are > > - We run on a lot more than VGA PC con

Re: lockdep: how to tell it multiple pte locks is OK?

2007-10-07 Thread Arjan van de Ven
On Sun, 7 Oct 2007 10:17:47 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > On Oct 7, 2007, at 9:58 AM, Arjan van de Ven wrote: > > > On Sat, 06 Oct 2007 23:31:33 -0700 > > > >> I'm presume I'm the first person to try holding multiple pte locks > >> at once, so there's no existing locki

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-07 Thread Hugh Dickins
On Fri, 5 Oct 2007, Balbir Singh wrote: > Hugh Dickins wrote: > > > > That's where it should happen, yes; but my point is that it very > > often does not. Because the swap cache page (read in as part of > > the readaround cluster of some other cgroup, or in swapoff by some > > other cgroup) is al

  1   2   >