--- Al Viro <[EMAIL PROTECTED]> wrote:
> On Sat, Oct 27, 2007 at 11:01:12AM +0200, Ahmed S. Darwish wrote:
> > The problem here (As discussed in private mails) is that the for loop
> > assumes that the beginning of given user-space buffer is the beginning
> > of a rule. This leads to situations
Hi Stephen,
On Tuesday 23 October 2007 15:55, Stephen Hemminger wrote:
> +
> +static int apanel_setkeycode(struct input_dev *idev, int scancode, int
> keycode)
> +{
> + struct apanel *ap = idev->private;
> +
> + if (keycode < 0 || keycode > KEY_MAX)
> + return -EINVAL;
> +
>
On Sun, Oct 28, 2007 at 03:43:43AM +, Al Viro wrote:
>On Sun, Oct 28, 2007 at 11:24:41AM +0800, WANG Cong wrote:
>>
>> Hi, Jeff, Sam!
>>
>> I just pulled from Linus-tree, and got the following error when building uml.
>>
>> $ make defconfig ARCH=um
>>
On Sat, 27 Oct 2007, Russell King wrote:
>
> FYI, here's what I have queued (cut'n'pasted so probably won't apply):
Yes, much nicer.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo
struct user.u_ar0 is defined to contain a pointer offset on all
architectures in which it is defined (all architectures which define
an a.out format except SPARC.) However, it has a pointer type in the
headers, which is pointless -- is not exported to
userspace, and it just makes the code messy.
On Wednesday 24 October 2007 12:26, Adrian Bunk wrote:
> hp_sdc_exit() mustn't be __exit since it's called from the
> __init hp_sdc_register().
>
Applied, thank you Adrian.
--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL
> 6) Epoll removes the file from the set, when the *kernel* object gets
>closed (internal use-count goes to zero)
>
> With that in mind, how can the code snippet above trigger a removal from
> the epoll set?
I don't see how that can be. Suppose I add fd 8 to an epoll set.
Suppose fd
Alexey Dobriyan <[EMAIL PROTECTED]> writes:
> On Sat, Oct 27, 2007 at 10:34:53PM +0400, wrote:
>> --- a/arch/powerpc/kernel/idle.c
>> +++ b/arch/powerpc/kernel/idle.c
>> @@ -122,7 +122,7 @@ static ctl_table powersave_nap_sysctl_root[] = {
>> {
>> .ctl_name = CTL_KERN,
>>
On Sun, Oct 28, 2007 at 11:24:41AM +0800, WANG Cong wrote:
>
> Hi, Jeff, Sam!
>
> I just pulled from Linus-tree, and got the following error when building uml.
>
> $ make defconfig ARCH=um
> /home/wangcong/projects/linux-2.6/arch/um/Makefile-i386:32:
>
Too many troubles with the bitlocks and we really do not need
to do any bitops. Bitops do not effectively retrieve the old
value which we want. So use a cmpxchg instead on the arches
that allow it.
Instead of modifying the page->flags with fake atomic operations
we pass the page state as a
Restructure slab_alloc so that the code flows in the sequence
it is usually executed.
Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]>
---
mm/slub.c | 40
1 file changed, 24 insertions(+), 16 deletions(-)
Index: linux-2.6/mm/slub.c
There is the need to use the objects per slab in the first part of
__slab_alloc() which is still pretty hot. Copy the number of objects
per slab into the kmem_cache_cpu structure. That way we can get the
value from a cache line that we already need to touch. This brings
the kmem_cache_cpu
Provide an alternate implementation of the SLUB fast paths for alloc
and free using cmpxchg_local. The cmpxchg_local fast path is selected
for arches that have CONFIG_FAST_CMPXCHG_LOCAL set. An arch should only
set CONFIG_FAST_CMPXCHG_LOCAL if the cmpxchg_local is faster than an
interrupt
Currently we use the NULL pointer to signal that there are no more objects.
However the NULL pointers of all slabs match in contrast to the
pointers to the real objects which are distinctive for each slab page.
Change the end pointer to be simply a pointer to the first object with
bit 0 set. That
Recent reports from Intel indicated that there were regression on
SMP benchmarks vs. SLAB. This is a discussion of performance results
and some patches are attached to fix various issues.
The patches are also available via git pull from
Use a single exit path by using goto's to the hottest exit path.
Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]>
---
mm/slub.c |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
Index: linux-2.6/mm/slub.c
===
The fast path always results in a valid object. Move the check
for the NULL pointer to the slow branch that calls
__slab_alloc. Only __slab_alloc can return NULL if there is no
memory available anymore and that case is exceedingly rare.
Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]>
---
The kmem_cache_node determination can be moved into add_full()
and add_partial(). This removes some code from the slab_free()
slow path and reduces the register overhead that has to be managed
in the slow path.
Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]>
---
mm/slub.c | 29
Some function tend to get folded into __slab_free and __slab_alloc
although they are rarely called. They cause register pressure that
leads to bad code generation.
Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]>
---
mm/slub.c | 13 +++--
1 file changed, 7 insertions(+), 6
Add a parameter to add_partial instead of having separate functions.
That allows the detailed control from multiple places when putting
slabs back to the partial list. If we put slabs back to the front
then they are likely immediately used for allocations. If they are
put at the end then we can
Hi, Jeff, Sam!
I just pulled from Linus-tree, and got the following error when building uml.
$ make defconfig ARCH=um
/home/wangcong/projects/linux-2.6/arch/um/Makefile-i386:32:
/home/wangcong/projects/linux-2.6/arch/i386/Makefile.cpu: No such file or
directory
make: *** No rule to make
> I am writing a driver to map a PCI board memory space (pcibar2) into a
> user-space vma via 'mmap'. What is the relationship between the address
> returned from ioremap and the type of address needed in the
> 'io_remap_page_range' or 'remap_pfn_range' functions? How about the
> following?
On Sun, Oct 28, 2007 at 12:38:50PM +1100, Stephen Rothwell wrote:
> Hi Olof,
>
> Just a trivial thing ...
>
> On Sat, 27 Oct 2007 12:28:51 -0500 Olof Johansson <[EMAIL PROTECTED]> wrote:
> >
> > +u8 iic_get_target_id(int cpu)
> > +{
> > + return per_cpu(iic, cpu).target_id;
> > +}
> > +
> >
Hi Olof,
Just a trivial thing ...
On Sat, 27 Oct 2007 12:28:51 -0500 Olof Johansson <[EMAIL PROTECTED]> wrote:
>
> +u8 iic_get_target_id(int cpu)
> +{
> + return per_cpu(iic, cpu).target_id;
> +}
> +
> +EXPORT_SYMBOL_GPL(iic_get_target_id);
We don't normally put a blank line between a
Alexey Dobriyan <[EMAIL PROTECTED]> wrote:
>
>irq_flags_t flags;
>
>flags = spin_lock_irqXXX();
>spin_unlock_irqYYY(, flags);
>
> where XXX and YYY are still to be found good names :^) It's also a solution
How about flags?
flags = spin_lock_irqflags();
On Sat, Oct 27, 2007 at 04:07:41PM +0200, Tilman Schmidt wrote:
> Greg KH schrieb:
> > On Fri, Oct 26, 2007 at 11:46:39AM +0200, Tilman Schmidt wrote:
> >> [...] I still think there will always be
> >> a number of external modules that cannot be merged right now or at
> >> all, and deliberately
On Sat, Oct 27, 2007 at 04:47:15PM +0200, Tilman Schmidt wrote:
> Adrian Bunk schrieb:
> > On Fri, Oct 26, 2007 at 11:46:39AM +0200, Tilman Schmidt wrote:
> >> On Thu, 25 Oct 2007 19:56:47 -0700, Greg KH wrote:
> >>> On Fri, Oct 26, 2007 at 01:09:14AM +0200, Tilman Schmidt wrote:
> [...] Once
I recently noticed that all architectures appear to have an entry n
struct user called u_ar0:
struct user_pt_regs * u_ar0; /* Used by gdb to help find the values
for */
/* the registers. */
In all cases, u_ar0 is a pointer type, although the type of pointer
Mike Waychison wrote:
The following series is meant to clean up FIBMAP paths with the eventual goal
of allowing users to be able to FIBMAP their data.
Keep in mind FIBMAP is currently extremely expensive on some
filesystems, e.g. ext3. Therefore, additional filesystem-level work
would have
Hi,
On Thursday 25 October 2007, Sam Ravnborg wrote:
> > It's clearly invalid in that it depends on what it selects, but it should
> > just abort instead.
>
> Thanks for the report and especially for the testcase!
> I will try to look at it a bit later if noone bites me (I'm afraid not).
Well,
Hello,
it seems that there is some dependency missing for CONFIG_USB_SUSPEND.
When I compile a kernel without CONFIG_SUSPEND, USB suspend doesn't work
(or at least doesn't expose its interface to userspace).
/sys/bus/usb/devices/.../power doesn't exist, but it is there when I
enable
On Sat, Oct 27, 2007 at 11:01:12AM +0200, Ahmed S. Darwish wrote:
> The problem here (As discussed in private mails) is that the for loop
> assumes that the beginning of given user-space buffer is the beginning
> of a rule. This leads to situations where the rule becomes "ecret 20",
> or "cret
On Sat, 27 Oct 2007 23:30:57 +0200 Johannes Stezenbach wrote:
> On Fri, Oct 26, 2007, Ingo Molnar wrote:
> >
> > the attached config (generated via make randconfig) fails to build due
> > to the combination of these config entries:
> >
> > CONFIG_VIDEO_DEV=m
> > CONFIG_VIDEO_SAA7146_VV=y
>
Hi,
On Monday 22 October 2007, Randy Dunlap wrote:
> ~
> Another common idiom that we see (and sometimes have problems
> with) is this:
>
> When B (module or subsystem) uses interfaces from A (module or
> subsystem), A can be linked
David wrote:
> I think there's a mixup in the flag name [MPOL_MF_RELATIVE] there
Most likely. The discussion involving that flag name was kinda mixed up ;).
> but I actually would recommend against any flag to effect Choice A.
> It's simply going to be too complex to describe and is going to be
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/ioctl.c | 164 +++-
1 files changed, 84 insertions(+), 80 deletions(-)
diff --git a/fs/ioctl.c b/fs/ioctl.c
index c2a773e..652cacf 100644
--- a/fs/ioctl.c
+++ b/fs/ioctl.c
@@ -12,8 +12,8
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
---
fs/unionfs/commonfops.c | 32 ++--
1 files changed, 6 insertions(+), 26 deletions(-)
diff --git a/fs/unionfs/commonfops.c b/fs/unionfs/commonfops.c
index 50e5775..c99b519 100644
--- a/fs/unionfs/commonfops.c
+++
Rename old vfs_ioctl to do_ioctl, because the comment above it clearly
indicates that it is an internal function not to be exported to modules;
therefore it should have a more traditional do_XXX name. The new do_ioctl
is exported in fs.h but not to modules.
Rename the old do_ioctl to vfs_ioctl
This series of three proposed patches changes fs/ioctl.c and Unionfs as
follows. This series is against v2.6.24-rc1-192-gef49c32.
Patch 1: just applies coding standards to fs/ioctl.c (while I'm at it, I
figured it's worth cleaning VFS files one at a time).
Patch 2: does two things:
(a)
On Friday 26 October 2007 10:44, Peter wrote:
> > ...the way the watermarks work they will be evenly distributed
> > over the appropriate zones. ..
Hi Peter,
The term is "highwater mark" not "high watermark". A watermark is an
anti-counterfeiting device printed on paper money. "Highwater" is
In message <[EMAIL PROTECTED]>, Christoph Hellwig writes:
> On Mon, Oct 22, 2007 at 08:48:04PM -0400, Erez Zadok wrote:
> > Why? Are you concerned that the security policy may change after a module
> > is loaded?
>
> No, it's a matter of proper layering. We generally don't want modules
> like
On Friday 26 October 2007 10:55, Christoph Lameter wrote:
> On Fri, 26 Oct 2007, Pavel Machek wrote:
> > > And, _no_, it does not necessarily mean global serialisation. By
> > > simply saying there must be N pages available I say nothing about
> > > on which node they should be available, and the
> This patch is too simplistic. ide-cd.c:ide_cdrom_drive_status() looks
> to be a reasonable implementation. However, the worry is that
> GET_EVENT_NOTIFICATION is a MMC command; devices not conforming to MMC
> won't support it. In theory, they should just return ILLEGAL_REQUEST,
> but USB
On Sat, 27 Oct 2007, Peter Zijlstra wrote:
> > > [ 592.752781]
> > > [ 592.753478] [ BUG: lock held when returning to user space! ]
> > > [ 592.753880]
> > > [ 592.754262] hwclock/1452 is leaving
On Sat, 2007-10-27 at 23:47 +0400, Alexey Dobriyan wrote:
> Remove proc_fs.h from headers that doesn't really need it.
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -17,6 +17,7 @@
> #include
> #include
> #include
> +#include
Your code doesn't match your
On Sunday 28 October 2007 00:07:12 Glauber de Oliveira Costa wrote:
> Commit d3d1c4bdf16bd154d9f27f34fca28edca90465eb introduces a new config
> knob that, according to its changelog, should select CONFIG_PARAVIRT.
Hi Glauber,
PARAVIRT is now selected by the options which need it. Merely
On Sat, 27 Oct 2007, Maxim Levitsky wrote:
> > Use del_timer_sync(). It guarantees that when it returns, the timer
> > will be stopped and the timer routine will no longer be running on any
> > CPU.
> >
> Even if the timer re-enables itself, are you sure?
Last time I looked at the source
On Sat, 27 Oct 2007, Anton Altaparmakov wrote:
> And another of my pet peeves with ->bmap is that it uses 0 to mean "sparse"
> which causes a conflict on NTFS at least as block zero is part of the $Boot
> system file so it is a real, valid block... NTFS uses -1 to denote sparse
> blocks
On Sat, 2007-10-27 at 23:30 +0200, Peter Zijlstra wrote:
> On Sat, 2007-10-27 at 16:02 -0500, Steve French wrote:
> > On 10/27/07, Peter Zijlstra <[EMAIL PROTECTED]> wrote:
> > > Hi,
> > >
> > > I had me a little look at bdi usage in networked filesystems.
> > >
> > > NFS, CIFS, (smbfs), AFS,
On Sat, 2007-10-27 at 23:08 +0200, Kay Sievers wrote:
> On Sat, 2007-10-27 at 09:02 -0700, Greg KH wrote:
> > Ah, I see a few problems. Here, try this version instead. It's
> > compile-tested only, and should be a lot simpler.
> >
> > Note, we still are not setting the parent to the new bdi
On Fri, Oct 26, 2007, Ingo Molnar wrote:
>
> the attached config (generated via make randconfig) fails to build due
> to the combination of these config entries:
>
> CONFIG_VIDEO_DEV=m
> CONFIG_VIDEO_SAA7146_VV=y
>
> i found no obvious Kconfig way to force VIDEO_SAA7146_VV to be modular
>
On Sat, 2007-10-27 at 16:02 -0500, Steve French wrote:
> On 10/27/07, Peter Zijlstra <[EMAIL PROTECTED]> wrote:
> > Hi,
> >
> > I had me a little look at bdi usage in networked filesystems.
> >
> > NFS, CIFS, (smbfs), AFS, CODA and NCP
> >
> > And of those, NFS is the only one that I could find
On Saturday, 27 October 2007 14:05, Maxim Levitsky wrote:
> Hi,
>
> Recently I noticed that my system resumes just after suspend to disk.
>
> I traced this to commit 9cd9a0058dd35268b24fa16795a92c800f4086d4.
>
> Note:
>
> This happens only if I enable WOL using /proc/acpi/wakeup
> (echo "ILAN"
David wrote:
> I prefer Choice B because it does not force mempolicies to have any
> dependence on cpusets with regard to what nodemask is passed.
Yes, well said.
> It would be very good to store the passed nodemask to set_mempolicy in
> struct mempolicy,
Yes - that's what I'm intending to
Hi,
On Sun, 28 Oct 2007, Alexey Dobriyan wrote:
> > If it's just about the type checking, something like below should pretty
> > much do the same.
>
> It won't catch, the following if both variables are unsigned long:
>
> spin_lock_irqsave(, flags);
> [stuff]
>
On Fri, 2007-10-26 at 14:31 -0700, Jesse Barnes wrote:
> On Friday, October 26, 2007 12:08 pm Kay Sievers wrote:
> > The open coded: device_create_file(>dev, _attrs[i])
> > should probably replaced by passing the array to the class, and the
> > core will do that for you.
>
> You mean just set
On Sun, 2007-10-28 at 00:14 +0400, Alexey Dobriyan wrote:
> On Sat, Oct 27, 2007 at 09:20:43PM +0200, Roman Zippel wrote:
> > On Sun, 21 Oct 2007, Alexey Dobriyan wrote:
> >
> > > So far remedies were:
> > > a) grep(1) -- obviously fragile. I tried at some point grepping for
> > >
On Sat, 2007-10-27 at 09:02 -0700, Greg KH wrote:
> On Sat, Oct 27, 2007 at 10:39:59AM +0200, Peter Zijlstra wrote:
> > On Fri, 2007-10-26 at 19:40 -0700, Greg KH wrote:
> > > On Sat, Oct 27, 2007 at 03:18:08AM +0200, Peter Zijlstra wrote:
> > > > On Fri, 2007-10-26 at 22:04 +0200, Peter Zijlstra
On 10/27/07, Peter Zijlstra <[EMAIL PROTECTED]> wrote:
> Hi,
>
> I had me a little look at bdi usage in networked filesystems.
>
> NFS, CIFS, (smbfs), AFS, CODA and NCP
>
> And of those, NFS is the only one that I could find that creates
> backing_dev_info structures. The rest seems to fall back
> > You have chosen (1) above, which keeps Choice A as the default.
>
> There can be different defaults for the user space API via libnuma that
> are indepdent from the kernel API which needs to remain stable. The kernel
> API can be extended but not changed.
Yes - the user level code can have
On Wed, Oct 24, 2007 at 06:26:26PM +0200, Adrian Bunk wrote:
> The Coverity checker spotted the following array overflow caused by
> commit 34c0d154243dd913c5690ae6ceb9557017429b9c:
The line is a left-over from times when gfs stored the mode of the
inode in the file handle. It can simply be
> +/**
> + * smk_write_cipso - write() for /smack/cipso
> + * @filp: file pointer, not actually used
> + * @buf: where to get the data from
> + * @count: bytes sent
> + * @ppos: where to start
> + *
> + * Returns number of bytes written or error code, as appropriate
> + */
> +static ssize_t
In message <[EMAIL PROTECTED]>, Hugh Dickins writes:
> On Mon, 22 Oct 2007, Erez Zadok wrote:
[...]
> > If you've got suggestions how I can handle unionfs_write more cleanly, or
> > comments on the above possibilities, I'd love to hear them.
>
> For now I think you should pursue the
On Fri, Oct 26, 2007 at 07:37:21AM -0700, Arjan van de Ven wrote:
> before going into the LSM / security side of things, I'd like to get
> the VFS guys to look at your VFS interaction code.
It's been NACKed a few times, and just reposting it won't help.
-
To unsubscribe from this list: send the
On Oct 28 2007 00:24, Alexey Dobriyan wrote:
>
>> (Which would be the logical choice if it were a function and not a
>> macro...) That would flag up all violations ("without cast to different
>> pointer" or so) while usually not breaking compilation.
>>
>> Of course, irq_flags_t is probably
On Thu, Oct 25, 2007 at 05:40:03PM +0200, Jan Engelhardt wrote:
> On Oct 21 2007, Alexey Dobriyan wrote:
> >
> >One of type of bugs steadily being fought is the following one:
> >
> > unsigned int flags;
> > spin_lock_irqsave(, flags);
> >
> >where "flags" should be "unsigned long". Here
On Sat, Oct 27, 2007 at 07:44:04PM +0100, Al Viro wrote:
>
> Signed-off-by: Al Viro <[EMAIL PROTECTED]>
> ---
> diff --git a/drivers/scsi/arm/scsi.h b/drivers/scsi/arm/scsi.h
> index 21ba571..2d09fef 100644
> --- a/drivers/scsi/arm/scsi.h
> +++ b/drivers/scsi/arm/scsi.h
> @@ -39,7 +39,7 @@ static
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
---
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index d9f78c8..1c50278 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9299,7 +9299,6 @@ static struct alc_config_preset alc268_presets[] =
On Sat, Oct 27, 2007 at 09:20:43PM +0200, Roman Zippel wrote:
> On Sun, 21 Oct 2007, Alexey Dobriyan wrote:
>
> > So far remedies were:
> > a) grep(1) -- obviously fragile. I tried at some point grepping for
> >spin_lock_irqsave(), found quite a few, but it became bring quickly.
> > b)
Steven Rostedt wrote:
> --
>
> On Sat, 27 Oct 2007, Rui Nuno Capela wrote:
>
>>> On Mon, October 15, 2007 11:49, Rui Nuno Capela wrote:
I am experiencing some highly annoying but intermitent freezing on a
pentium4 2.80G HT/SMT box, when doing normal desktop work with 2.6.23-rt1.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
---
diff --git a/include/linux/mv643xx_eth.h b/include/linux/mv643xx_eth.h
index 3f27239..8df230a 100644
--- a/include/linux/mv643xx_eth.h
+++ b/include/linux/mv643xx_eth.h
@@ -8,6 +8,9 @@
#define MV643XX_ETH_NAME "mv643xx_eth"
#define
Linus,
please pull x86 bugfixes from
ssh://master.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git
Some more voyager fixes and other compile warning fixups than in the
yesterday pull request.
Thanks,
tglx
Eric W. Biederman (1):
x86: Fix boot protocol KEEP_SEGMENTS
On Sat, Oct 27, 2007 at 03:32:04PM -0400, David Woodhouse wrote:
> On Sat, 2007-10-27 at 22:42 +0400, Anton Vorontsov wrote:
> > Well, PROP_PRESENT wasn't my idea, currently it's used by pmu and
> > olpc drivers becuase it's not trivial to register/unregister their
> > batteries on physical
Remove proc_fs.h from headers that doesn't really need it. Typical overkill is
including full header when one can get away with just forward declaration of
"struct proc_dir_entry".
Number of files that are recompiled after touching proc_fs.h drops from 1100
to 513(!) on x86_64 allmodconfig.
On Sat, 27 Oct 2007 22:34:53 +0400, Alexey Dobriyan wrote:
> On Sat, Oct 27, 2007 at 07:57:38PM +0200, Mikael Pettersson wrote:
> > Booting 2.6.24-rc1 on my PowerMac the kernel now spits
> > out a sysctl warning early in the boot sequence:
> >
> > --- dmesg-2.6.23
> > +++ dmesg-2.6.24-rc1
> > ...
On Sat, 2007-10-27 at 22:42 +0400, Anton Vorontsov wrote:
> Well, PROP_PRESENT wasn't my idea, currently it's used by pmu and
> olpc drivers becuase it's not trivial to register/unregister their
> batteries on physical insertion/removal. I have some plans to teach
> at least pmu batteries to not
Already have this one queued for Linus in my tree.
On Sat, Oct 27, 2007 at 07:44:04PM +0100, Al Viro wrote:
>
> Signed-off-by: Al Viro <[EMAIL PROTECTED]>
> ---
> diff --git a/drivers/scsi/arm/scsi.h b/drivers/scsi/arm/scsi.h
> index 21ba571..2d09fef 100644
> --- a/drivers/scsi/arm/scsi.h
> +++
On Saturday 27 October 2007 21:17:55 Alan Stern wrote:
> On Fri, 26 Oct 2007, Maxim Levitsky wrote:
>
> > > > Looking through the dmfe code, I noticed yet another possible race.
> > > > A race between the .suspend, and a timer that serves both as a
> > > > watchdog, and link state detector.
> >
Hi,
On Sun, 21 Oct 2007, Alexey Dobriyan wrote:
> So far remedies were:
> a) grep(1) -- obviously fragile. I tried at some point grepping for
>spin_lock_irqsave(), found quite a few, but it became bring quickly.
> b) BUILD_BUG_ON(sizeof(flags) != sizeof(unsigned long)) -- was tried,
>
--- "Ahmed S. Darwish" <[EMAIL PROTECTED]> wrote:
> Hi Casey,
>
> Casey <[EMAIL PROTECTED]> wrote:
> >
> > This version is again aimed at addressing Al Viro's issues in
> > smackfs. Ahmed Darwish has again contributed in the repair of the
> > locking issues there. The move to 2.6.24 was also an
On Fri, 26 Oct 2007, Maxim Levitsky wrote:
> > > Looking through the dmfe code, I noticed yet another possible race.
> > > A race between the .suspend, and a timer that serves both as a watchdog,
> > > and link state detector.
> > > Again I need to prevent it from running during the
On Fri, 26 Oct 2007, David Rientjes wrote:
> Hacking and requiring an updated version of libnuma to allow empty
> nodemasks to be passed is a poor solution; if mempolicy's are supposed to
> be independent from cpusets, then what semantics does an empty nodemask
> actually imply when using
On Sat, 2007-10-27 at 06:49 -0700, Haavard Skinnemoen wrote:
> On Fri, 26 Oct 2007 09:36:17 -0700
> Dan Williams <[EMAIL PROTECTED]> wrote:
>
> > @@ -221,7 +220,6 @@ void dma_chan_cleanup(struct kref *kref)
> > {
> > struct dma_chan *chan = container_of(kref, struct dma_chan, refcount);
>
On Thu, 25 Oct 2007, Greg KH wrote:
> On Tue, Oct 23, 2007 at 12:01:37AM -0400, Alan Stern wrote:
> > On Tue, 23 Oct 2007, Arnd Bergmann wrote:
> >
> > > usb_hcd_flush_endpoint() has a retry loop that starts with a
> > > spin_lock_irq(),
> > > but only gives up the spinlock, not the irq_disable
Mathieu Desnoyers <[EMAIL PROTECTED]> writes:
> We make sure that the thread flag read is coherent between our new test and
> the ALLWORK_MASK test by first saving it in a register used for both
> comparisons.
>
That doesn't make sense. If someone is setting those asynchronously you
can
Andrew Morton wrote:
On Fri, 26 Oct 2007 21:33:40 +0200
Ingo Molnar <[EMAIL PROTECTED]> wrote:
* Andrew Morton <[EMAIL PROTECTED]> wrote:
so a final 'sync' should be added to the test too, and the time it takes
factored into the bandwidth numbers?
That's one way of doing it. Or just run
On Fri, Oct 26, 2007 at 03:37:38PM -0400, Mathieu Desnoyers wrote:
>
> 1 - process A enters in a syscall, TIF_KERNEL_TRACE is cleared
> 2 - we activate TIF_KERNEL_TRACE
> 3 - process A returns from syscall (with wrong top of stack ?) -> segfault.
>
> Am I on the right track ?
Yes. The code was
On Saturday 27 October 2007, Al Viro wrote:
> struct device doesn't have ->dma; it's in struct expansion_card where
> that struct device is embedded into.
Yeah, your fix is obviously correct, thanks!
Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
Andy Whitcroft wrote:
On Thu, Oct 25, 2007 at 01:48:14PM -0700, Andrew Morton wrote:
Andy, I thought we were going to whine about __inline__ and __inline, too?
Hmmm, I don't remember that coming up, but I'll add it to the todo. I
am assuming plain 'inline' is preferred over both of these --
--- Joshua Brindle <[EMAIL PROTECTED]> wrote:
> Casey Schaufler wrote:
> > The Smack patch and Paul Moore's netlabel API patch,
> > together for 2.6.24-rc1. Paul's changes are identical
> > to the previous posting, but it's been a while so they're
> > here again.
> >
> > The sole intent of
(pointer > 0) is deeply weird; (pointer >= 0) is even dumber...
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
---
diff --git a/drivers/video/cirrusfb.c b/drivers/video/cirrusfb.c
index f99cb77..f7e2d5a 100644
--- a/drivers/video/cirrusfb.c
+++ b/drivers/video/cirrusfb.c
@@ -2509,8 +2509,7 @@
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
---
diff --git a/drivers/scsi/arm/scsi.h b/drivers/scsi/arm/scsi.h
index 21ba571..2d09fef 100644
--- a/drivers/scsi/arm/scsi.h
+++ b/drivers/scsi/arm/scsi.h
@@ -39,7 +39,7 @@ static inline int next_SCp(struct scsi_pointer *SCp)
On Sat, Oct 27, 2007 at 08:54:30PM +0400, Andrey Borzenkov wrote:
> I am not exactly sure about this one ... what other power_supply class
> drivers
> do? Should I fix HAL instead (but then, I do not know whether HAL is the only
> application that is using this interface).
Well, PROP_PRESENT
On Sat, Oct 27, 2007 at 10:34:53PM +0400, wrote:
> --- a/arch/powerpc/kernel/idle.c
> +++ b/arch/powerpc/kernel/idle.c
> @@ -122,7 +122,7 @@ static ctl_table powersave_nap_sysctl_root[] = {
> {
> .ctl_name = CTL_KERN,
> .procname = "kernel",
> -
#include
is an odd thing to do...
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
---
drivers/mmc/host/au1xmmc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/au1xmmc.c b/drivers/mmc/host/au1xmmc.c
index b2104d4..c3926eb 100644
---
struct device doesn't have ->dma; it's in struct expansion_card where
that struct device is embedded into.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
---
diff --git a/drivers/ide/arm/icside.c b/drivers/ide/arm/icside.c
index 410a0d1..93f71fc 100644
--- a/drivers/ide/arm/icside.c
+++
On Sat, Oct 27, 2007 at 07:57:38PM +0200, Mikael Pettersson wrote:
> Booting 2.6.24-rc1 on my PowerMac the kernel now spits
> out a sysctl warning early in the boot sequence:
>
> --- dmesg-2.6.23
> +++ dmesg-2.6.24-rc1
> ...
> IP route cache hash table entries: 32768 (order: 5, 131072 bytes)
>
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
---
diff --git a/arch/frv/mb93090-mb00/pci-dma.c b/arch/frv/mb93090-mb00/pci-dma.c
index 671ce1e..662f7b1 100644
--- a/arch/frv/mb93090-mb00/pci-dma.c
+++ b/arch/frv/mb93090-mb00/pci-dma.c
@@ -15,6 +15,7 @@
#include
#include
#include
+#include
Nestor A. Diaz wrote:
Hello People,
I need your help, this problem is turning me crazy.
Did you know there is a raid list?
I have created a RAID 10 using a RAID0 configuration on top of a two
RAID1 devices (all software raid), like this:
You have created a raid 0+1, raid10 is a
Andrey Borzenkov wrote:
> On Saturday 27 October 2007, Alexey Starikovskiy wrote:
>> Andrey Borzenkov wrote:
>>> I am not exactly sure about this one ... what other power_supply class
>>> drivers do? Should I fix HAL instead (but then, I do not know whether HAL
>>> is the only application that is
1 - 100 of 496 matches
Mail list logo
