Re: [PATCH] sysfs: add filter function to groups

2007-10-31 Thread Stefan Richter
Cornelia Huck wrote: > Greg KH <[EMAIL PROTECTED]> wrote: >> On Tue, Oct 30, 2007 at 01:25:43PM -0500, James Bottomley wrote: >>> + for (i = 0, attr = grp->attrs; *attr; i++, attr++) >>> + if (grp->is_visible && >>> + grp->is_visible(kobj, *attr, i)) >>> +

Re: [PATCH] add_partition silently ignored errors

2007-10-31 Thread Cornelia Huck
On Tue, 30 Oct 2007 15:56:35 -0700, Dirk Hohndel <[EMAIL PROTECTED]> wrote: > On Tue, Oct 30, 2007 at 06:31:12PM +0100, Cornelia Huck wrote: > > On Tue, 30 Oct 2007 09:56:08 -0700, > > Dirk Hohndel <[EMAIL PROTECTED]> wrote: > > > > > > > IIRC, Al recently vetoed a similar patch. As far as I'm

Re: tipc_config.h requires linux/string.h, which does not exist in exported headers

2007-10-31 Thread Sam Ravnborg
> > Here is what I mean, specifically. And this is build tested :-) > > From 97ef1bb0c8e371b7988287f38bd107c4aa14d78d Mon Sep 17 00:00:00 2001 > From: David S. Miller <[EMAIL PROTECTED]> > Date: Tue, 30 Oct 2007 21:44:00 -0700 > Subject: [PATCH] [TIPC]: Fix headercheck wrt. tipc_config.h > >

Re: [PATCH] sysfs: add filter function to groups

2007-10-31 Thread Cornelia Huck
On Tue, 30 Oct 2007 20:55:06 -0700, Greg KH <[EMAIL PROTECTED]> wrote: > On Tue, Oct 30, 2007 at 01:25:43PM -0500, James Bottomley wrote: > > Index: BUILD-2.6/fs/sysfs/group.c > > === > > --- BUILD-2.6.orig/fs/sysfs/group.c

Re: kbuild: possible regression?

2007-10-31 Thread Sam Ravnborg
On Wed, Oct 31, 2007 at 10:03:50AM +0100, Jan Altenberg wrote: > Hi all, > > I'm not quite sure if this might be a regression, but I recognized a > change to kbuild's behaviour, which causes some of my build scripts to > fail. > > The build scripts do: > > return system(('make -C %s O=%s

Re: [git patches] libata fixes

2007-10-31 Thread Jeff Garzik
Mikael Pettersson wrote: That's my fault for misremembering the rule about the number of dashes before the other comments part :-( I'll remember better in the future. Well, I should have caught it and hand-edited it on my side too... Jeff - To unsubscribe from this list: send the

Re: 32bit builds on x86-64 host.

2007-10-31 Thread Sam Ravnborg
On Wed, Oct 31, 2007 at 08:57:39AM +, Christoph Hellwig wrote: > On Tue, Oct 30, 2007 at 06:00:01PM -0700, Jeremy Fitzhardinge wrote: > > Christoph Hellwig wrote: > > > Which seems rather unnatural to me. All other merge architectures have > > > ARCH= where archdir is the name under arch,

Re: [git patches] libata fixes

2007-10-31 Thread Mikael Pettersson
On Tue, 30 Oct 2007 11:54:01 -0700 (PDT), Linus Torvalds wrote: > On Tue, 30 Oct 2007, Jeff Garzik wrote: > > > > Mikael Pettersson (2): > > sata_promise: ASIC PRD table bug workaround, take 2 > > sata_promise: cleanups > > You and Mikael need to sort out the way you send/accept

Re: How to debug complete kernel lock-ups

2007-10-31 Thread John Sigler
John Sigler wrote: John Sigler wrote: I have an x86 system with two PCI slots, in which I inserted two specialized output cards (Dektec DTA-105). http://www.dektec.com/Products/DTA-105/ (They provide an open source driver.) My problem is: when I write to the 4 ports (each card has 2 ports)

Re: Major SATA / EXT3 Issue?

2007-10-31 Thread Heikki Orsila
On Wed, Oct 31, 2007 at 03:25:54AM -0400, Theodore Tso wrote: > On Tue, Oct 30, 2007 at 03:59:24PM +0200, Heikki Orsila wrote: > > 3. fsck -p on boot failed > > > > (it is very probable not many files were corrupted at this stage) > > Maybe... The system wouldn't have worked as it did, if there

Re: [PATCH 5/6] fix typo in SubmittingPatches

2007-10-31 Thread Andy Whitcroft
On Tue, Oct 30, 2007 at 10:11:44PM -0700, Greg Kroah-Hartman wrote: > From: Keiichi Kii <[EMAIL PROTECTED]> > > Fix typo. > > Signed-off-by: Keiichi Kii <[EMAIL PROTECTED]> > Cc: Andy Whitcroft <[EMAIL PROTECTED]> > Cc: Randy Dunlap <[EMAIL PROTECTED]> > Signed-off-by: Greg Kroah-Hartman <[EMAIL

Re: [PATCH]bluetooth: hci_sysfs connection bus_id add support for diffrent hci device

2007-10-31 Thread Dave Young
On 10/31/07, Marcel Holtmann <[EMAIL PROTECTED]> wrote: > Hi Dave, > > > > diff -upr linux/net/bluetooth/hci_sysfs.c > > > linux.new/net/bluetooth/hci_sysfs.c > > > --- linux/net/bluetooth/hci_sysfs.c 2007-10-31 10:21:00.0 +0800 > > > +++ linux.new/net/bluetooth/hci_sysfs.c 2007-10-31

Re: [patch] sched: schedstat needs a diet

2007-10-31 Thread Rick Lindsley
On 10/18/07, Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > Good question indeed. How large is this memory footprint exactly ? If it > is as small as you say, I suspect that the real issue could be that > these variable are accessed by the scheduler critical paths and >

Re: build #336 failed for 2.6.24-rc1-ga3634d7 in linux/.check.tipc_config.h

2007-10-31 Thread David Miller
From: Toralf Förster <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 09:52:53 +0100 > Hello, > > the build with the attached .config failed, make ends with: > ... > CHECK include/linux/times.h > CHECK include/linux/tiocl.h > CHECK include/linux/tipc.h > CHECK

Re: [PATCH]bluetooth: hci_sysfs connection bus_id add support for diffrent hci device

2007-10-31 Thread Dave Young
On 10/31/07, David Miller <[EMAIL PROTECTED]> wrote: > From: Dave Young <[EMAIL PROTECTED]> > Date: Wed, 31 Oct 2007 10:30:17 +0800 > > > diff -upr linux/net/bluetooth/hci_sysfs.c > > linux.new/net/bluetooth/hci_sysfs.c > > --- linux/net/bluetooth/hci_sysfs.c 2007-10-31 10:21:00.0 +0800

Re: Linux Security *Module* Framework (Was: LSM conversion to static interface)

2007-10-31 Thread Peter Dolding
On 10/31/07, Crispin Cowan <[EMAIL PROTECTED]> wrote: > Peter Dolding wrote: > > Lets end the bitrot. Start having bits go into the main OS security > > features where they should be. > > > Linus categorically rejected this idea, several times, very clearly. > > He did so because the security

kbuild: possible regression?

2007-10-31 Thread Jan Altenberg
Hi all, I'm not quite sure if this might be a regression, but I recognized a change to kbuild's behaviour, which causes some of my build scripts to fail. The build scripts do: return system(('make -C %s O=%s ARCH=%s CROSS_COMPILE=%s '+ 'oldconfig %s %s < /dev/null || exit

Re: 32bit builds on x86-64 host.

2007-10-31 Thread Christoph Hellwig
On Tue, Oct 30, 2007 at 06:00:01PM -0700, Jeremy Fitzhardinge wrote: > Christoph Hellwig wrote: > > Which seems rather unnatural to me. All other merge architectures have > > ARCH= where archdir is the name under arch, e.g. mips, powerpc, > > s390. They then have a CONFIG_FOO_64 and set the

Re: [PATCH 28/33] nfs: teach the NFS client how to treat PG_swapcache pages

2007-10-31 Thread Christoph Hellwig
On Tue, Oct 30, 2007 at 05:04:29PM +0100, Peter Zijlstra wrote: > Replace all relevant occurences of page->index and page->mapping in the NFS > client with the new page_file_index() and page_file_mapping() functions. As discussed personally and on the list a strong NACK for this. Swapcache pages

Re: [PATCH 09/14] Blackfin SPI driver: Fix SPI driver to work with SPI flash ST25P16 on bf548

2007-10-31 Thread Bryan Wu
On Wed, 2007-10-31 at 01:02 -0700, David Brownell wrote: > On Wednesday 31 October 2007, Bryan Wu wrote: > > IMO, the spi_transfer.speed_hz <= spi_board_info.max_speed_hz and if > > spi_trasnfer.speed_hz is 0, we should use spi_board_info.max_speed_hz. > > From the meaning of max_speed_hz, the

Re: [PATCH] Swap delay accounting, include lock_page() delays

2007-10-31 Thread Nick Piggin
On Wednesday 31 October 2007 18:52, Balbir Singh wrote: > Reported-by: Nick Piggin <[EMAIL PROTECTED]> > > The delay incurred in lock_page() should also be accounted in swap delay > accounting > > Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> Ah right, I forgot to resend this one, sorry. Thanks

Re: [PATCH 00/33] Swap over NFS -v14

2007-10-31 Thread Christoph Hellwig
On Tue, Oct 30, 2007 at 09:37:53PM -0700, David Miller wrote: > Don't be misled. Swapping over NFS is just a scarecrow for the > seemingly real impetus behind these changes which is network storage > stuff like iSCSI. So can we please do swap over network storage only first? All these VM bits

[PATCH] "killing" sg_last(), and discussion

2007-10-31 Thread Jeff Garzik
I looked into killing sg_last(), but really, this is the best its gonna get (moving sg_last to libata-core.c). You could maybe kill one use with caching, but in the other sg_last() callsites there isn't another s/g loop we can stick a "last_sg = sg;" into. libata is stuck because we undertake

Re: [PATCH 09/14] Blackfin SPI driver: Fix SPI driver to work with SPI flash ST25P16 on bf548

2007-10-31 Thread Mike Frysinger
On 10/31/07, David Brownell <[EMAIL PROTECTED]> wrote: > (ISTR the M25P16 in $SUBJECT has two read commands, one of > which is only usable at clock rates below 33 MHz or so, but > most other commands can work above that speed just fine.) pretty much all SPI flashes have two read commands ("slow"

[BUILD-FAILURE] 2.6.24-rc1-git8 build fails drivers/pci/probe.c

2007-10-31 Thread Kamalesh Babulal
Hi, The 2.6.24-rc-git8 build fails with build error CC drivers/pci/probe.o drivers/pci/probe.c: In function 'pci_create_legacy_files': drivers/pci/probe.c:56: error: implicit declaration of function 'class_device_create_bin_file' drivers/pci/probe.c: In function

Re: [PATCH]: exit_ivtv_i2c() cannot be __devexit

2007-10-31 Thread Hans Verkuil
On Wednesday 31 October 2007 05:23, David Miller wrote: > Please apply, thanks! > > [MEDIA] IVTV: exit_ivtv_i2c() cannot be __devexit > > It is referenced both from __devinit code (ivtv_probe) and > normal .text (ivtv_process_eeprom), and therefore cannot > be discarded via __devexit. Good catch!

Re: [PATCH] dump_stack on panic

2007-10-31 Thread Christoph Hellwig
On Wed, Oct 31, 2007 at 01:14:04AM +0100, Andi Kleen wrote: > One (mostly psychological, but still serious) problem is that stack > dumps make panics always look like kernel bugs. But there are panics > which are definitely not kernel bugs: like the popular cannot mount > root or machine checks

Re: [PATCH 6/16] CRIS architecture: Correct compile errors

2007-10-31 Thread Jesper Nilsson
On Tue, Oct 30, 2007 at 03:14:10PM -0700, Andrew Morton wrote: > On Tue, 30 Oct 2007 10:31:01 +0100 > Jesper Nilsson <[EMAIL PROTECTED]> wrote: > > > - New file include/asm-cris/irq_regs.h. > > - Change handling of registers for do_IRQ. > > - Add GENERIC_HARDIRQS to Kconfig. > > > >

Re: dev_ifname32() fails on 32->64bit calls in copy_in_user().

2007-10-31 Thread Eric W. Biederman
Benjamin Herrenschmidt <[EMAIL PROTECTED]> writes: > Bug is in the new dev_ifname32: > > uifr = compat_alloc_user_space(sizeof(struct ifreq)); > if (copy_in_user(uifr, compat_ptr(arg), sizeof(struct ifreq32))); > return -EFAULT; > > There's a stray ";" after the if

termios bug fix proposal

2007-10-31 Thread David Miller
Right now there is at least one case in the tree (IRNET PPP) where either the build is failing or garbage is being moved to/from userspace for TCGETS and TCSETSF calls. This is happening silently on x86 and friends because there is zero type checking in these termios translator macros. I

Re: [PATCH 09/14] Blackfin SPI driver: Fix SPI driver to work with SPI flash ST25P16 on bf548

2007-10-31 Thread David Brownell
On Wednesday 31 October 2007, Bryan Wu wrote: > IMO, the spi_transfer.speed_hz <= spi_board_info.max_speed_hz and if > spi_trasnfer.speed_hz is 0, we should use spi_board_info.max_speed_hz. > From the meaning of max_speed_hz, the spi_transfer.speed_hz should not > beyond max_speed_hz. According

Re: [PATCH 10/16] CRIS architecture: Correct compile errors

2007-10-31 Thread Jesper Nilsson
On Tue, Oct 30, 2007 at 03:14:17PM -0700, Andrew Morton wrote: > On Tue, 30 Oct 2007 10:33:28 +0100 > Jesper Nilsson <[EMAIL PROTECTED]> wrote: > > > New and improved serial driver for cris v10. > > I wasn't able to apply this due to extensive patch rejects. Yes, I noticed that too when trying

Re: [PATCH]bluetooth: hci_sysfs connection bus_id add support for diffrent hci device

2007-10-31 Thread Marcel Holtmann
Hi Dave, > > diff -upr linux/net/bluetooth/hci_sysfs.c > > linux.new/net/bluetooth/hci_sysfs.c > > --- linux/net/bluetooth/hci_sysfs.c 2007-10-31 10:21:00.0 +0800 > > +++ linux.new/net/bluetooth/hci_sysfs.c 2007-10-31 10:21:55.0 > > +0800 > > @@ -302,7 +302,8 @@ void

[PATCH] Swap delay accounting, include lock_page() delays

2007-10-31 Thread Balbir Singh
Reported-by: Nick Piggin <[EMAIL PROTECTED]> The delay incurred in lock_page() should also be accounted in swap delay accounting Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- mm/memory.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN

Re: Huawei E220 and usb storage

2007-10-31 Thread Norbert Preining
On Di, 30 Okt 2007, Pete Zaitcev wrote: > > printk(KERN_ERR "ENTERING usb_stor_huawei_e220_init!\n"); > > at the beginning of the function but it never showed up in my log files. > > So it seems that the UNUSUAL_DEV entry does not match. > > This doesn't seem to be possible, considering the

Re: 2.6.23 regression: accessing invalid mmap'ed memory from gdb causes unkillable spinning

2007-10-31 Thread David Miller
From: Nick Piggin <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 08:41:06 +0100 > On Tue, Oct 30, 2007 at 11:56:00PM -0700, David Miller wrote: > > From: Nick Piggin <[EMAIL PROTECTED]> > > Date: Wed, 31 Oct 2007 07:42:21 +0100 > > > > Anyways, my core suggestion is to add a hook here so platforms

Re: 2.6.23 regression: accessing invalid mmap'ed memory from gdb causes unkillable spinning

2007-10-31 Thread Nick Piggin
On Tue, Oct 30, 2007 at 11:56:00PM -0700, David Miller wrote: > From: Nick Piggin <[EMAIL PROTECTED]> > Date: Wed, 31 Oct 2007 07:42:21 +0100 > > > Sysrq+T fails to show the stack trace of a running task. Presumably this > > is to avoid a garbled stack, however it can often be useful, and besides

Re: tipc_config.h requires linux/string.h, which does not exist in exported headers

2007-10-31 Thread Alex Riesen
David Miller, Wed, Oct 31, 2007 05:56:16 +0100: > diff --git a/include/linux/string.h b/include/linux/string.h > index 836062b..c5d3fca 100644 > --- a/include/linux/string.h > +++ b/include/linux/string.h > @@ -3,16 +3,14 @@ > > /* We don't want strings.h stuff being user by user stuff by

Re: [dm-devel] Re: dm: bounce_pfn limit added

2007-10-31 Thread Hannes Reinecke
Vasily Averin wrote: > Alasdair G Kergon wrote: >> So currently we treat bounce_pfn as a property that does not need to be >> propagated through the stack. >> >> But is that the right approach? >> - Is there a blk_queue_bounce() missing either from dm or elsewhere? >> (And BTW can the

Re: [PATCH 09/14] Blackfin SPI driver: Fix SPI driver to work with SPI flash ST25P16 on bf548

2007-10-31 Thread Bryan Wu
On Wed, 2007-10-31 at 00:11 -0700, David Brownell wrote: > On Tuesday 30 October 2007, Bryan Wu wrote: > > Maybe there are some confusion of mixing up the spi_trasnfer.speed_hz > > with the spi_device.max_speed_hz. > > > > spi_device.max_speed_hz comes from spi_board_info.max_speed_hz, it is > >

Re: Major SATA / EXT3 Issue?

2007-10-31 Thread Theodore Tso
On Tue, Oct 30, 2007 at 03:59:24PM +0200, Heikki Orsila wrote: > 3. fsck -p on boot failed > > (it is very probable not many files were corrupted at this stage) Maybe... > > 4. I ran fsck.ext3 -y > > => that corrupted lots and lots of files. This went > into a loop, the fsck.ext3 restarted

[2.6.24-rc1-git] Warning with make tags and cscope

2007-10-31 Thread Kamalesh Babulal
Hi, Get following warning while building tags and cscope index files $ make tags -j 2 MAKE tags find: arch/i386: No such file or directory find: arch/i386: No such file or directory find: arch/i386: No such file or directory $ make cscope -j 2 FILELST cscope.files find: arch/i386: No such

Re: [RFC 0/2] readdir() as an inode operation

2007-10-31 Thread Theodore Tso
On Tue, Oct 30, 2007 at 04:26:04PM +0100, Jan Kara wrote: > > This is a first try to move readdir() to become an inode operation. This is > > necessary for a VFS implementation of "something like union-mounts" where a > > readdir() needs to read the directory contents of multiple directories. > >

[RFC] mempolicy minor code cleanups

2007-10-31 Thread Paul Jackson
From: Paul Jackson <[EMAIL PROTECTED]> Some minor code cleanups for mm/mempolicy.c. This patch should have been sent out before, to be applied first to 2.6.23-mm1, -before- another patch I sent out an hour ago: [RFC] cpuset relative memory policies - second choice Signed-off-by: Paul

Re: [dm-devel] Re: dm: bounce_pfn limit added

2007-10-31 Thread Vasily Averin
Alasdair G Kergon wrote: > So currently we treat bounce_pfn as a property that does not need to be > propagated through the stack. > > But is that the right approach? > - Is there a blk_queue_bounce() missing either from dm or elsewhere? > (And BTW can the bio_alloc() that lurks within lead to

Re: [PATCH 09/14] Blackfin SPI driver: Fix SPI driver to work with SPI flash ST25P16 on bf548

2007-10-31 Thread David Brownell
On Tuesday 30 October 2007, Bryan Wu wrote: > Maybe there are some confusion of mixing up the spi_trasnfer.speed_hz > with the spi_device.max_speed_hz. > > spi_device.max_speed_hz comes from spi_board_info.max_speed_hz, it is > for the default max speed value. It's initialized from board_info,

Re: [PATCH]bluetooth: hci_sysfs connection bus_id add support for diffrent hci device

2007-10-31 Thread David Miller
From: Dave Young <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 10:30:17 +0800 > diff -upr linux/net/bluetooth/hci_sysfs.c linux.new/net/bluetooth/hci_sysfs.c > --- linux/net/bluetooth/hci_sysfs.c 2007-10-31 10:21:00.0 +0800 > +++ linux.new/net/bluetooth/hci_sysfs.c 2007-10-31

Re: [PATCH]bluetooth: hci_sysfs connection bus_id add support for diffrent hci device

2007-10-31 Thread David Miller
From: Dave Young [EMAIL PROTECTED] Date: Wed, 31 Oct 2007 10:30:17 +0800 diff -upr linux/net/bluetooth/hci_sysfs.c linux.new/net/bluetooth/hci_sysfs.c --- linux/net/bluetooth/hci_sysfs.c 2007-10-31 10:21:00.0 +0800 +++ linux.new/net/bluetooth/hci_sysfs.c 2007-10-31

Re: [PATCH 09/14] Blackfin SPI driver: Fix SPI driver to work with SPI flash ST25P16 on bf548

2007-10-31 Thread David Brownell
On Tuesday 30 October 2007, Bryan Wu wrote: Maybe there are some confusion of mixing up the spi_trasnfer.speed_hz with the spi_device.max_speed_hz. spi_device.max_speed_hz comes from spi_board_info.max_speed_hz, it is for the default max speed value. It's initialized from board_info, yes.

[RFC] mempolicy minor code cleanups

2007-10-31 Thread Paul Jackson
From: Paul Jackson [EMAIL PROTECTED] Some minor code cleanups for mm/mempolicy.c. This patch should have been sent out before, to be applied first to 2.6.23-mm1, -before- another patch I sent out an hour ago: [RFC] cpuset relative memory policies - second choice Signed-off-by: Paul Jackson

Re: [dm-devel] Re: dm: bounce_pfn limit added

2007-10-31 Thread Vasily Averin
Alasdair G Kergon wrote: So currently we treat bounce_pfn as a property that does not need to be propagated through the stack. But is that the right approach? - Is there a blk_queue_bounce() missing either from dm or elsewhere? (And BTW can the bio_alloc() that lurks within lead to

Re: [RFC 0/2] readdir() as an inode operation

2007-10-31 Thread Theodore Tso
On Tue, Oct 30, 2007 at 04:26:04PM +0100, Jan Kara wrote: This is a first try to move readdir() to become an inode operation. This is necessary for a VFS implementation of something like union-mounts where a readdir() needs to read the directory contents of multiple directories. Besides

Re: Major SATA / EXT3 Issue?

2007-10-31 Thread Theodore Tso
On Tue, Oct 30, 2007 at 03:59:24PM +0200, Heikki Orsila wrote: 3. fsck -p on boot failed (it is very probable not many files were corrupted at this stage) Maybe... 4. I ran fsck.ext3 -y = that corrupted lots and lots of files. This went into a loop, the fsck.ext3 restarted checking

Re: [PATCH 09/14] Blackfin SPI driver: Fix SPI driver to work with SPI flash ST25P16 on bf548

2007-10-31 Thread Bryan Wu
On Wed, 2007-10-31 at 00:11 -0700, David Brownell wrote: On Tuesday 30 October 2007, Bryan Wu wrote: Maybe there are some confusion of mixing up the spi_trasnfer.speed_hz with the spi_device.max_speed_hz. spi_device.max_speed_hz comes from spi_board_info.max_speed_hz, it is for the

Re: [dm-devel] Re: dm: bounce_pfn limit added

2007-10-31 Thread Hannes Reinecke
Vasily Averin wrote: Alasdair G Kergon wrote: So currently we treat bounce_pfn as a property that does not need to be propagated through the stack. But is that the right approach? - Is there a blk_queue_bounce() missing either from dm or elsewhere? (And BTW can the bio_alloc() that lurks

Re: tipc_config.h requires linux/string.h, which does not exist in exported headers

2007-10-31 Thread Alex Riesen
David Miller, Wed, Oct 31, 2007 05:56:16 +0100: diff --git a/include/linux/string.h b/include/linux/string.h index 836062b..c5d3fca 100644 --- a/include/linux/string.h +++ b/include/linux/string.h @@ -3,16 +3,14 @@ /* We don't want strings.h stuff being user by user stuff by accident */

Re: 2.6.23 regression: accessing invalid mmap'ed memory from gdb causes unkillable spinning

2007-10-31 Thread Nick Piggin
On Tue, Oct 30, 2007 at 11:56:00PM -0700, David Miller wrote: From: Nick Piggin [EMAIL PROTECTED] Date: Wed, 31 Oct 2007 07:42:21 +0100 Sysrq+T fails to show the stack trace of a running task. Presumably this is to avoid a garbled stack, however it can often be useful, and besides there

Re: 2.6.23 regression: accessing invalid mmap'ed memory from gdb causes unkillable spinning

2007-10-31 Thread David Miller
From: Nick Piggin [EMAIL PROTECTED] Date: Wed, 31 Oct 2007 08:41:06 +0100 On Tue, Oct 30, 2007 at 11:56:00PM -0700, David Miller wrote: From: Nick Piggin [EMAIL PROTECTED] Date: Wed, 31 Oct 2007 07:42:21 +0100 Anyways, my core suggestion is to add a hook here so platforms can do the

[PATCH] Swap delay accounting, include lock_page() delays

2007-10-31 Thread Balbir Singh
Reported-by: Nick Piggin [EMAIL PROTECTED] The delay incurred in lock_page() should also be accounted in swap delay accounting Signed-off-by: Balbir Singh [EMAIL PROTECTED] --- mm/memory.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN

[2.6.24-rc1-git] Warning with make tags and cscope

2007-10-31 Thread Kamalesh Babulal
Hi, Get following warning while building tags and cscope index files $ make tags -j 2 MAKE tags find: arch/i386: No such file or directory find: arch/i386: No such file or directory find: arch/i386: No such file or directory $ make cscope -j 2 FILELST cscope.files find: arch/i386: No such

Re: Huawei E220 and usb storage

2007-10-31 Thread Norbert Preining
On Di, 30 Okt 2007, Pete Zaitcev wrote: printk(KERN_ERR ENTERING usb_stor_huawei_e220_init!\n); at the beginning of the function but it never showed up in my log files. So it seems that the UNUSUAL_DEV entry does not match. This doesn't seem to be possible, considering the

Re: [PATCH]bluetooth: hci_sysfs connection bus_id add support for diffrent hci device

2007-10-31 Thread Marcel Holtmann
Hi Dave, diff -upr linux/net/bluetooth/hci_sysfs.c linux.new/net/bluetooth/hci_sysfs.c --- linux/net/bluetooth/hci_sysfs.c 2007-10-31 10:21:00.0 +0800 +++ linux.new/net/bluetooth/hci_sysfs.c 2007-10-31 10:21:55.0 +0800 @@ -302,7 +302,8 @@ void

Re: [PATCH 09/14] Blackfin SPI driver: Fix SPI driver to work with SPI flash ST25P16 on bf548

2007-10-31 Thread David Brownell
On Wednesday 31 October 2007, Bryan Wu wrote: IMO, the spi_transfer.speed_hz = spi_board_info.max_speed_hz and if spi_trasnfer.speed_hz is 0, we should use spi_board_info.max_speed_hz. From the meaning of max_speed_hz, the spi_transfer.speed_hz should not beyond max_speed_hz. According to the

Re: [PATCH 6/16] CRIS architecture: Correct compile errors

2007-10-31 Thread Jesper Nilsson
On Tue, Oct 30, 2007 at 03:14:10PM -0700, Andrew Morton wrote: On Tue, 30 Oct 2007 10:31:01 +0100 Jesper Nilsson [EMAIL PROTECTED] wrote: - New file include/asm-cris/irq_regs.h. - Change handling of registers for do_IRQ. - Add GENERIC_HARDIRQS to Kconfig. Signed-off-by: Jesper

Re: [PATCH] dump_stack on panic

2007-10-31 Thread Christoph Hellwig
On Wed, Oct 31, 2007 at 01:14:04AM +0100, Andi Kleen wrote: One (mostly psychological, but still serious) problem is that stack dumps make panics always look like kernel bugs. But there are panics which are definitely not kernel bugs: like the popular cannot mount root or machine checks or a

Re: [PATCH]: exit_ivtv_i2c() cannot be __devexit

2007-10-31 Thread Hans Verkuil
On Wednesday 31 October 2007 05:23, David Miller wrote: Please apply, thanks! [MEDIA] IVTV: exit_ivtv_i2c() cannot be __devexit It is referenced both from __devinit code (ivtv_probe) and normal .text (ivtv_process_eeprom), and therefore cannot be discarded via __devexit. Good catch!

[BUILD-FAILURE] 2.6.24-rc1-git8 build fails drivers/pci/probe.c

2007-10-31 Thread Kamalesh Babulal
Hi, The 2.6.24-rc-git8 build fails with build error CC drivers/pci/probe.o drivers/pci/probe.c: In function 'pci_create_legacy_files': drivers/pci/probe.c:56: error: implicit declaration of function 'class_device_create_bin_file' drivers/pci/probe.c: In function

Re: dev_ifname32() fails on 32-64bit calls in copy_in_user().

2007-10-31 Thread Eric W. Biederman
Benjamin Herrenschmidt [EMAIL PROTECTED] writes: Bug is in the new dev_ifname32: uifr = compat_alloc_user_space(sizeof(struct ifreq)); if (copy_in_user(uifr, compat_ptr(arg), sizeof(struct ifreq32))); return -EFAULT; There's a stray ; after the if statement, that

Re: [PATCH 10/16] CRIS architecture: Correct compile errors

2007-10-31 Thread Jesper Nilsson
On Tue, Oct 30, 2007 at 03:14:17PM -0700, Andrew Morton wrote: On Tue, 30 Oct 2007 10:33:28 +0100 Jesper Nilsson [EMAIL PROTECTED] wrote: New and improved serial driver for cris v10. I wasn't able to apply this due to extensive patch rejects. Yes, I noticed that too when trying to apply

termios bug fix proposal

2007-10-31 Thread David Miller
Right now there is at least one case in the tree (IRNET PPP) where either the build is failing or garbage is being moved to/from userspace for TCGETS and TCSETSF calls. This is happening silently on x86 and friends because there is zero type checking in these termios translator macros. I

Re: [PATCH 09/14] Blackfin SPI driver: Fix SPI driver to work with SPI flash ST25P16 on bf548

2007-10-31 Thread Mike Frysinger
On 10/31/07, David Brownell [EMAIL PROTECTED] wrote: (ISTR the M25P16 in $SUBJECT has two read commands, one of which is only usable at clock rates below 33 MHz or so, but most other commands can work above that speed just fine.) pretty much all SPI flashes have two read commands (slow and

Re: [PATCH] Swap delay accounting, include lock_page() delays

2007-10-31 Thread Nick Piggin
On Wednesday 31 October 2007 18:52, Balbir Singh wrote: Reported-by: Nick Piggin [EMAIL PROTECTED] The delay incurred in lock_page() should also be accounted in swap delay accounting Signed-off-by: Balbir Singh [EMAIL PROTECTED] Ah right, I forgot to resend this one, sorry. Thanks for

[PATCH] killing sg_last(), and discussion

2007-10-31 Thread Jeff Garzik
I looked into killing sg_last(), but really, this is the best its gonna get (moving sg_last to libata-core.c). You could maybe kill one use with caching, but in the other sg_last() callsites there isn't another s/g loop we can stick a last_sg = sg; into. libata is stuck because we undertake the

Re: [PATCH 00/33] Swap over NFS -v14

2007-10-31 Thread Christoph Hellwig
On Tue, Oct 30, 2007 at 09:37:53PM -0700, David Miller wrote: Don't be misled. Swapping over NFS is just a scarecrow for the seemingly real impetus behind these changes which is network storage stuff like iSCSI. So can we please do swap over network storage only first? All these VM bits look

Re: [PATCH 5/6] fix typo in SubmittingPatches

2007-10-31 Thread Andy Whitcroft
On Tue, Oct 30, 2007 at 10:11:44PM -0700, Greg Kroah-Hartman wrote: From: Keiichi Kii [EMAIL PROTECTED] Fix typo. Signed-off-by: Keiichi Kii [EMAIL PROTECTED] Cc: Andy Whitcroft [EMAIL PROTECTED] Cc: Randy Dunlap [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED]

Re: [patch] sched: schedstat needs a diet

2007-10-31 Thread Rick Lindsley
On 10/18/07, Mathieu Desnoyers [EMAIL PROTECTED] wrote: Good question indeed. How large is this memory footprint exactly ? If it is as small as you say, I suspect that the real issue could be that these variable are accessed by the scheduler critical paths and therefore

Re: build #336 failed for 2.6.24-rc1-ga3634d7 in linux/.check.tipc_config.h

2007-10-31 Thread David Miller
From: Toralf Förster [EMAIL PROTECTED] Date: Wed, 31 Oct 2007 09:52:53 +0100 Hello, the build with the attached .config failed, make ends with: ... CHECK include/linux/times.h CHECK include/linux/tiocl.h CHECK include/linux/tipc.h CHECK include/linux/tipc_config.h

Re: [PATCH 28/33] nfs: teach the NFS client how to treat PG_swapcache pages

2007-10-31 Thread Christoph Hellwig
On Tue, Oct 30, 2007 at 05:04:29PM +0100, Peter Zijlstra wrote: Replace all relevant occurences of page-index and page-mapping in the NFS client with the new page_file_index() and page_file_mapping() functions. As discussed personally and on the list a strong NACK for this. Swapcache pages

Re: [PATCH 09/14] Blackfin SPI driver: Fix SPI driver to work with SPI flash ST25P16 on bf548

2007-10-31 Thread Bryan Wu
On Wed, 2007-10-31 at 01:02 -0700, David Brownell wrote: On Wednesday 31 October 2007, Bryan Wu wrote: IMO, the spi_transfer.speed_hz = spi_board_info.max_speed_hz and if spi_trasnfer.speed_hz is 0, we should use spi_board_info.max_speed_hz. From the meaning of max_speed_hz, the

Re: 32bit builds on x86-64 host.

2007-10-31 Thread Christoph Hellwig
On Tue, Oct 30, 2007 at 06:00:01PM -0700, Jeremy Fitzhardinge wrote: Christoph Hellwig wrote: Which seems rather unnatural to me. All other merge architectures have ARCH=archdir where archdir is the name under arch, e.g. mips, powerpc, s390. They then have a CONFIG_FOO_64 and set the

Re: Linux Security *Module* Framework (Was: LSM conversion to static interface)

2007-10-31 Thread Peter Dolding
On 10/31/07, Crispin Cowan [EMAIL PROTECTED] wrote: Peter Dolding wrote: Lets end the bitrot. Start having bits go into the main OS security features where they should be. Linus categorically rejected this idea, several times, very clearly. He did so because the security community

kbuild: possible regression?

2007-10-31 Thread Jan Altenberg
Hi all, I'm not quite sure if this might be a regression, but I recognized a change to kbuild's behaviour, which causes some of my build scripts to fail. The build scripts do: return system(('make -C %s O=%s ARCH=%s CROSS_COMPILE=%s '+ 'oldconfig %s %s /dev/null || exit

Re: [PATCH]bluetooth: hci_sysfs connection bus_id add support for diffrent hci device

2007-10-31 Thread Dave Young
On 10/31/07, David Miller [EMAIL PROTECTED] wrote: From: Dave Young [EMAIL PROTECTED] Date: Wed, 31 Oct 2007 10:30:17 +0800 diff -upr linux/net/bluetooth/hci_sysfs.c linux.new/net/bluetooth/hci_sysfs.c --- linux/net/bluetooth/hci_sysfs.c 2007-10-31 10:21:00.0 +0800 +++

Re: [PATCH]bluetooth: hci_sysfs connection bus_id add support for diffrent hci device

2007-10-31 Thread Dave Young
On 10/31/07, Marcel Holtmann [EMAIL PROTECTED] wrote: Hi Dave, diff -upr linux/net/bluetooth/hci_sysfs.c linux.new/net/bluetooth/hci_sysfs.c --- linux/net/bluetooth/hci_sysfs.c 2007-10-31 10:21:00.0 +0800 +++ linux.new/net/bluetooth/hci_sysfs.c 2007-10-31

Re: How to debug complete kernel lock-ups

2007-10-31 Thread John Sigler
John Sigler wrote: John Sigler wrote: I have an x86 system with two PCI slots, in which I inserted two specialized output cards (Dektec DTA-105). http://www.dektec.com/Products/DTA-105/ (They provide an open source driver.) My problem is: when I write to the 4 ports (each card has 2 ports)

Re: kbuild: possible regression?

2007-10-31 Thread Sam Ravnborg
On Wed, Oct 31, 2007 at 10:03:50AM +0100, Jan Altenberg wrote: Hi all, I'm not quite sure if this might be a regression, but I recognized a change to kbuild's behaviour, which causes some of my build scripts to fail. The build scripts do: return system(('make -C %s O=%s ARCH=%s

Re: [PATCH] sysfs: add filter function to groups

2007-10-31 Thread Cornelia Huck
On Tue, 30 Oct 2007 20:55:06 -0700, Greg KH [EMAIL PROTECTED] wrote: On Tue, Oct 30, 2007 at 01:25:43PM -0500, James Bottomley wrote: Index: BUILD-2.6/fs/sysfs/group.c === --- BUILD-2.6.orig/fs/sysfs/group.c 2007-10-28

Re: [PATCH] sysfs: add filter function to groups

2007-10-31 Thread Stefan Richter
Cornelia Huck wrote: Greg KH [EMAIL PROTECTED] wrote: On Tue, Oct 30, 2007 at 01:25:43PM -0500, James Bottomley wrote: + for (i = 0, attr = grp-attrs; *attr; i++, attr++) + if (grp-is_visible + grp-is_visible(kobj, *attr, i)) +

Re: tipc_config.h requires linux/string.h, which does not exist in exported headers

2007-10-31 Thread Sam Ravnborg
Here is what I mean, specifically. And this is build tested :-) From 97ef1bb0c8e371b7988287f38bd107c4aa14d78d Mon Sep 17 00:00:00 2001 From: David S. Miller [EMAIL PROTECTED] Date: Tue, 30 Oct 2007 21:44:00 -0700 Subject: [PATCH] [TIPC]: Fix headercheck wrt. tipc_config.h It wants

Re: [git patches] libata fixes

2007-10-31 Thread Jeff Garzik
Mikael Pettersson wrote: That's my fault for misremembering the rule about the number of dashes before the other comments part :-( I'll remember better in the future. Well, I should have caught it and hand-edited it on my side too... Jeff - To unsubscribe from this list: send the

Re: 32bit builds on x86-64 host.

2007-10-31 Thread Sam Ravnborg
On Wed, Oct 31, 2007 at 08:57:39AM +, Christoph Hellwig wrote: On Tue, Oct 30, 2007 at 06:00:01PM -0700, Jeremy Fitzhardinge wrote: Christoph Hellwig wrote: Which seems rather unnatural to me. All other merge architectures have ARCH=archdir where archdir is the name under arch, e.g.

Re: [git patches] libata fixes

2007-10-31 Thread Mikael Pettersson
On Tue, 30 Oct 2007 11:54:01 -0700 (PDT), Linus Torvalds wrote: On Tue, 30 Oct 2007, Jeff Garzik wrote: Mikael Pettersson (2): sata_promise: ASIC PRD table bug workaround, take 2 sata_promise: cleanups You and Mikael need to sort out the way you send/accept patches.

Re: [PATCH 00/33] Swap over NFS -v14

2007-10-31 Thread Peter Zijlstra
On Tue, 2007-10-30 at 21:37 -0700, David Miller wrote: From: Nick Piggin [EMAIL PROTECTED] Date: Wed, 31 Oct 2007 14:26:32 +1100 Is it really worth all the added complexity of making swap over NFS files work, given that you could use a network block device instead? Don't be misled.

Re: 2.6.23 performance regression

2007-10-31 Thread Ingo Molnar
* Nick Piggin [EMAIL PROTECTED] wrote: On Tuesday 30 October 2007 18:54, Lorenzo Allegrucci wrote: Hi, sorry if this is a faq but reading http://people.freebsd.org/~kris/scaling/7.0%20Preview.pdf (slides 17, 18) looks like 2.6.23 is having a performance regression on MySQL and

Re: Major SATA / EXT3 Issue?

2007-10-31 Thread Heikki Orsila
On Wed, Oct 31, 2007 at 03:25:54AM -0400, Theodore Tso wrote: On Tue, Oct 30, 2007 at 03:59:24PM +0200, Heikki Orsila wrote: 3. fsck -p on boot failed (it is very probable not many files were corrupted at this stage) Maybe... The system wouldn't have worked as it did, if there were so

Re: [PATCH] add_partition silently ignored errors

2007-10-31 Thread Cornelia Huck
On Tue, 30 Oct 2007 15:56:35 -0700, Dirk Hohndel [EMAIL PROTECTED] wrote: On Tue, Oct 30, 2007 at 06:31:12PM +0100, Cornelia Huck wrote: On Tue, 30 Oct 2007 09:56:08 -0700, Dirk Hohndel [EMAIL PROTECTED] wrote: IIRC, Al recently vetoed a similar patch. As far as I'm concerned,

[PATCH 1/5] The config option itself

2007-10-31 Thread Pavel Emelyanov
The option is called NAMESPACES. It can be selectable only if EMBEDDED is chosen (this was Eric's requisition). When the EMBEDDED is off namespaces will be on automatically. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git a/init/Kconfig b/init/Kconfig index c3de3ed..fc76773

Re: [PATCH] sysfs: add filter function to groups

2007-10-31 Thread Cornelia Huck
On Wed, 31 Oct 2007 10:52:35 +0100, Stefan Richter [EMAIL PROTECTED] wrote: Cornelia Huck wrote: Greg KH [EMAIL PROTECTED] wrote: On Tue, Oct 30, 2007 at 01:25:43PM -0500, James Bottomley wrote: + for (i = 0, attr = grp-attrs; *attr; i++, attr++) + if (grp-is_visible +

[PATCH 5/5] Move the PID namespace under the option

2007-10-31 Thread Pavel Emelyanov
For the same reasons as with the IPC namespaces, all the prototypes and stubs go to the pid_namespace.h file. The namespace management code itself is moved to the pid_namespace.c file. The pid_namespace cache is created inside an initcall, i.e. a bit later than the pid hash is initialized. This

[PATCH 4/5] Move the user namespace under the option

2007-10-31 Thread Pavel Emelyanov
We already have a CONFIG_USER_NS option. Just tune it a bit and move the init_user_ns into user.c file to make the kernel compile and work without the namespaces support. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git a/init/Kconfig b/init/Kconfig index b1aa7f1..1ec7009 100644

<    1   2   3   4   5   6   7   8   9   >